]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/tools.c
More for -q tool mode
[openldap] / servers / slapd / back-bdb / tools.c
index 76ded258cdb5eac2b34c967d98bf998b5d364484..b36ead159eee3a415370645717bb64efb67487fe 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2000-2005 The OpenLDAP Foundation.
+ * Copyright 2000-2007 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -18,6 +18,7 @@
 
 #include <stdio.h>
 #include <ac/string.h>
+#include <ac/errno.h>
 
 #define AVL_INTERNAL
 #include "back-bdb.h"
@@ -25,6 +26,9 @@
 
 static DBC *cursor = NULL;
 static DBT key, data;
+static EntryHeader eh;
+static ID nid, previd = NOID;
+static char ehbuf[16];
 
 typedef struct dn_id {
        ID id;
@@ -38,26 +42,44 @@ static unsigned nholes;
 
 static int index_nattrs;
 
+#ifdef BDB_TOOL_IDL_CACHING
 #define bdb_tool_idl_cmp               BDB_SYMBOL(tool_idl_cmp)
 #define bdb_tool_idl_flush_one         BDB_SYMBOL(tool_idl_flush_one)
 #define bdb_tool_idl_flush             BDB_SYMBOL(tool_idl_flush)
 
 static int bdb_tool_idl_flush( BackendDB *be );
-static int bdb_tool_ix_rec( int base );
-static void * bdb_tool_index_task( void *ctx, void *ptr );
 
 #define        IDBLOCK 1024
 
-static ID *bdb_tool_idls;
-static int bdb_tool_idl_next;
+typedef struct bdb_tool_idl_cache_entry {
+       struct bdb_tool_idl_cache_entry *next;
+       ID ids[IDBLOCK];
+} bdb_tool_idl_cache_entry;
+typedef struct bdb_tool_idl_cache {
+       struct berval kstr;
+       bdb_tool_idl_cache_entry *head, *tail;
+       ID first, last;
+       int count;
+} bdb_tool_idl_cache;
+
+static bdb_tool_idl_cache_entry *bdb_tool_idl_free_list;
+#endif /* BDB_TOOL_IDL_CACHING */
 
 static ID bdb_tool_ix_id;
 static Operation *bdb_tool_ix_op;
-static volatile int *bdb_tool_index_threads;
+static int *bdb_tool_index_threads, bdb_tool_index_tcount;
 static void *bdb_tool_index_rec;
 static struct bdb_info *bdb_tool_info;
 static ldap_pvt_thread_mutex_t bdb_tool_index_mutex;
-static ldap_pvt_thread_cond_t bdb_tool_index_cond;
+static ldap_pvt_thread_cond_t bdb_tool_index_cond_main;
+static ldap_pvt_thread_cond_t bdb_tool_index_cond_work;
+
+static ldap_pvt_thread_mutex_t bdb_tool_trickle_mutex;
+static ldap_pvt_thread_cond_t bdb_tool_trickle_cond;
+
+static void * bdb_tool_index_task( void *ctx, void *ptr );
+static void * bdb_tool_trickle_task( void *ctx, void *ptr );
 
 int bdb_tool_entry_open(
        BackendDB *be, int mode )
@@ -67,8 +89,10 @@ int bdb_tool_entry_open(
        /* initialize key and data thangs */
        DBTzero( &key );
        DBTzero( &data );
-       key.flags = DB_DBT_REALLOC;
-       data.flags = DB_DBT_REALLOC;
+       key.flags = DB_DBT_USERMEM;
+       key.data = &nid;
+       key.size = key.ulen = sizeof( nid );
+       data.flags = DB_DBT_USERMEM;
 
        if (cursor == NULL) {
                int rc = bdb->bi_id2entry->bdi_db->cursor(
@@ -79,26 +103,30 @@ int bdb_tool_entry_open(
                }
        }
 
-       /* Set up for slapindex */
-       if ( !(slapMode & SLAP_TOOL_READONLY )) {
-               int i;
-               if ( bdb->bi_idl_cache_max_size )
-                       bdb_tool_idls = ch_malloc( bdb->bi_idl_cache_max_size *
-                               sizeof( ID ) * IDBLOCK );
-               if ( !bdb_tool_info && ( slapMode & SLAP_TOOL_QUICK )) {
+       /* Set up for threaded slapindex */
+       if (( slapMode & (SLAP_TOOL_QUICK|SLAP_TOOL_READONLY)) == SLAP_TOOL_QUICK ) {
+               if ( !bdb_tool_info ) {
+                       ldap_pvt_thread_mutex_init( &bdb_tool_trickle_mutex );
+                       ldap_pvt_thread_cond_init( &bdb_tool_trickle_cond );
+                       ldap_pvt_thread_pool_submit( &connection_pool, bdb_tool_trickle_task, bdb->bi_dbenv );
+
                        ldap_pvt_thread_mutex_init( &bdb_tool_index_mutex );
-                       ldap_pvt_thread_cond_init( &bdb_tool_index_cond );
-                       bdb_tool_index_threads = ch_malloc( slap_tool_thread_max * sizeof( int ));
-                       bdb_tool_index_rec = ch_malloc( bdb->bi_nattrs * sizeof( IndexRec ));
-                       for (i=1; i<slap_tool_thread_max; i++) {
-                               int *ptr = ch_malloc( sizeof( int ));
-                               *ptr = i;
-                               ldap_pvt_thread_pool_submit( &connection_pool,
-                                       bdb_tool_index_task, ptr );
-                               ldap_pvt_thread_yield();
+                       ldap_pvt_thread_cond_init( &bdb_tool_index_cond_main );
+                       ldap_pvt_thread_cond_init( &bdb_tool_index_cond_work );
+                       if ( bdb->bi_nattrs ) {
+                               int i;
+                               bdb_tool_index_threads = ch_malloc( slap_tool_thread_max * sizeof( int ));
+                               bdb_tool_index_rec = ch_malloc( bdb->bi_nattrs * sizeof( IndexRec ));
+                               bdb_tool_index_tcount = slap_tool_thread_max - 1;
+                               for (i=1; i<slap_tool_thread_max; i++) {
+                                       int *ptr = ch_malloc( sizeof( int ));
+                                       *ptr = i;
+                                       ldap_pvt_thread_pool_submit( &connection_pool,
+                                               bdb_tool_index_task, ptr );
+                               }
                        }
+                       bdb_tool_info = bdb;
                }
-               bdb_tool_info = bdb;
        }
 
        return 0;
@@ -107,22 +135,20 @@ int bdb_tool_entry_open(
 int bdb_tool_entry_close(
        BackendDB *be )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
-
        if ( bdb_tool_info ) {
                slapd_shutdown = 1;
+               ldap_pvt_thread_mutex_lock( &bdb_tool_trickle_mutex );
+               ldap_pvt_thread_cond_signal( &bdb_tool_trickle_cond );
+               ldap_pvt_thread_mutex_unlock( &bdb_tool_trickle_mutex );
                ldap_pvt_thread_mutex_lock( &bdb_tool_index_mutex );
-               ldap_pvt_thread_cond_broadcast( &bdb_tool_index_cond );
+               bdb_tool_index_tcount = slap_tool_thread_max - 1;
+               ldap_pvt_thread_cond_broadcast( &bdb_tool_index_cond_work );
                ldap_pvt_thread_mutex_unlock( &bdb_tool_index_mutex );
        }
 
-       if( key.data ) {
-               ch_free( key.data );
-               key.data = NULL;
-       }
-       if( data.data ) {
-               ch_free( data.data );
-               data.data = NULL;
+       if( eh.bv.bv_val ) {
+               ch_free( eh.bv.bv_val );
+               eh.bv.bv_val = NULL;
        }
 
        if( cursor ) {
@@ -130,11 +156,9 @@ int bdb_tool_entry_close(
                cursor = NULL;
        }
 
+#ifdef BDB_TOOL_IDL_CACHING
        bdb_tool_idl_flush( be );
-
-       free( bdb_tool_idls );
-       bdb_tool_idls = NULL;
-       bdb_tool_idl_next = 0;
+#endif
 
        if( nholes ) {
                unsigned i;
@@ -159,10 +183,14 @@ ID bdb_tool_entry_next(
        assert( be != NULL );
        assert( slapMode & SLAP_TOOL_MODE );
        assert( bdb != NULL );
-       
+
+       /* Get the header */
+       data.ulen = data.dlen = sizeof( ehbuf );
+       data.data = ehbuf;
+       data.flags |= DB_DBT_PARTIAL;
        rc = cursor->c_get( cursor, &key, &data, DB_NEXT );
 
-       if( rc != 0 ) {
+       if( rc ) {
                /* If we're doing linear indexing and there are more attrs to
                 * index, and we're at the end of the database, start over.
                 */
@@ -180,11 +208,8 @@ ID bdb_tool_entry_next(
                }
        }
 
-       if( data.data == NULL ) {
-               return NOID;
-       }
-
        BDB_DISK2ID( key.data, &id );
+       previd = id;
        return id;
 }
 
@@ -206,7 +231,7 @@ ID bdb_tool_dn2id_get(
        op.o_tmpmemctx = NULL;
        op.o_tmpmfuncs = &ch_mfuncs;
 
-       rc = bdb_cache_find_ndn( &op, NULL, dn, &ei );
+       rc = bdb_cache_find_ndn( &op, 0, dn, &ei );
        if ( ei ) bdb_cache_entryinfo_unlock( ei );
        if ( rc == DB_NOTFOUND )
                return NOID;
@@ -214,72 +239,86 @@ ID bdb_tool_dn2id_get(
        return ei->bei_id;
 }
 
-int bdb_tool_id2entry_get(
-       Backend *be,
-       ID id,
-       Entry **e
-)
-{
-       int rc = bdb_id2entry( be, NULL, 0, id, e );
-
-       if ( rc == DB_NOTFOUND && id == 0 ) {
-               Entry *dummy = ch_calloc( 1, sizeof(Entry) );
-               struct berval gluebv = BER_BVC("glue");
-               dummy->e_name.bv_val = ch_strdup( "" );
-               dummy->e_nname.bv_val = ch_strdup( "" );
-               attr_merge_one( dummy, slap_schema.si_ad_objectClass, &gluebv, NULL );
-               attr_merge_one( dummy, slap_schema.si_ad_structuralObjectClass,
-                       &gluebv, NULL );
-               *e = dummy;
-               rc = LDAP_SUCCESS;
-       }
-       return rc;
-}
-
 Entry* bdb_tool_entry_get( BackendDB *be, ID id )
 {
-       int rc;
        Entry *e = NULL;
-       struct berval bv;
+       char *dptr;
+       int rc, eoff;
 
        assert( be != NULL );
        assert( slapMode & SLAP_TOOL_MODE );
-       assert( data.data != NULL );
 
-       DBT2bv( &data, &bv );
+       if ( id != previd ) {
+               data.ulen = data.dlen = sizeof( ehbuf );
+               data.data = ehbuf;
+               data.flags |= DB_DBT_PARTIAL;
+
+               BDB_ID2DISK( id, &nid );
+               rc = cursor->c_get( cursor, &key, &data, DB_SET );
+               if ( rc ) goto done;
+       }
+
+       /* Get the header */
+       dptr = eh.bv.bv_val;
+       eh.bv.bv_val = ehbuf;
+       eh.bv.bv_len = data.size;
+       rc = entry_header( &eh );
+       eoff = eh.data - eh.bv.bv_val;
+       eh.bv.bv_val = dptr;
+       if ( rc ) goto done;
+
+       /* Get the size */
+       data.flags &= ~DB_DBT_PARTIAL;
+       data.ulen = 0;
+    rc = cursor->c_get( cursor, &key, &data, DB_CURRENT );
+       if ( rc != DB_BUFFER_SMALL ) goto done;
+
+       /* Allocate a block and retrieve the data */
+       eh.bv.bv_len = eh.nvals * sizeof( struct berval ) + data.size;
+       eh.bv.bv_val = ch_realloc( eh.bv.bv_val, eh.bv.bv_len );
+       eh.data = eh.bv.bv_val + eh.nvals * sizeof( struct berval );
+       data.data = eh.data;
+       data.ulen = data.size;
+
+       /* Skip past already parsed nattr/nvals */
+       eh.data += eoff;
+
+    rc = cursor->c_get( cursor, &key, &data, DB_CURRENT );
+       if ( rc ) goto done;
 
 #ifdef SLAP_ZONE_ALLOC
        /* FIXME: will add ctx later */
-       rc = entry_decode( &bv, &e, NULL );
+       rc = entry_decode( &eh, &e, NULL );
 #else
-       rc = entry_decode( &bv, &e );
+       rc = entry_decode( &eh, &e );
 #endif
 
        if( rc == LDAP_SUCCESS ) {
                e->e_id = id;
-       }
 #ifdef BDB_HIER
-       if ( slapMode & SLAP_TOOL_READONLY ) {
-               EntryInfo *ei = NULL;
-               Operation op = {0};
-               Opheader ohdr = {0};
-
-               op.o_hdr = &ohdr;
-               op.o_bd = be;
-               op.o_tmpmemctx = NULL;
-               op.o_tmpmfuncs = &ch_mfuncs;
-
-               rc = bdb_cache_find_parent( &op, NULL, cursor->locker, id, &ei );
-               if ( rc == LDAP_SUCCESS ) {
-                       bdb_cache_entryinfo_unlock( ei );
-                       e->e_private = ei;
-                       ei->bei_e = e;
-                       bdb_fix_dn( e, 0 );
-                       ei->bei_e = NULL;
-                       e->e_private = NULL;
+               if ( slapMode & SLAP_TOOL_READONLY ) {
+                       EntryInfo *ei = NULL;
+                       Operation op = {0};
+                       Opheader ohdr = {0};
+
+                       op.o_hdr = &ohdr;
+                       op.o_bd = be;
+                       op.o_tmpmemctx = NULL;
+                       op.o_tmpmfuncs = &ch_mfuncs;
+
+                       rc = bdb_cache_find_parent( &op, CURSOR_GETLOCKER(cursor), id, &ei );
+                       if ( rc == LDAP_SUCCESS ) {
+                               bdb_cache_entryinfo_unlock( ei );
+                               e->e_private = ei;
+                               ei->bei_e = e;
+                               bdb_fix_dn( e, 0 );
+                               ei->bei_e = NULL;
+                               e->e_private = NULL;
+                       }
                }
-       }
 #endif
+       }
+done:
        return e;
 }
 
@@ -301,7 +340,7 @@ static int bdb_tool_next_id(
                return 0;
        }
 
-       rc = bdb_cache_find_ndn( op, tid, &ndn, &ei );
+       rc = bdb_cache_find_ndn( op, tid ? TXN_ID( tid ) : 0, &ndn, &ei );
        if ( ei ) bdb_cache_entryinfo_unlock( ei );
        if ( rc == DB_NOTFOUND ) {
                if ( !be_issuffix( op->o_bd, &ndn ) ) {
@@ -383,6 +422,9 @@ bdb_tool_index_add(
 {
        struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
 
+       if ( !bdb->bi_nattrs )
+               return 0;
+
        if ( slapMode & SLAP_TOOL_QUICK ) {
                IndexRec *ir;
                int i, rc;
@@ -400,23 +442,34 @@ bdb_tool_index_add(
                bdb_tool_ix_id = e->e_id;
                bdb_tool_ix_op = op;
                ldap_pvt_thread_mutex_lock( &bdb_tool_index_mutex );
+               /* Wait for all threads to be ready */
+               while ( bdb_tool_index_tcount ) {
+                       ldap_pvt_thread_cond_wait( &bdb_tool_index_cond_main, 
+                               &bdb_tool_index_mutex );
+               }
                for ( i=1; i<slap_tool_thread_max; i++ )
                        bdb_tool_index_threads[i] = LDAP_BUSY;
-               ldap_pvt_thread_cond_broadcast( &bdb_tool_index_cond );
+               bdb_tool_index_tcount = slap_tool_thread_max - 1;
+               ldap_pvt_thread_cond_broadcast( &bdb_tool_index_cond_work );
                ldap_pvt_thread_mutex_unlock( &bdb_tool_index_mutex );
                rc = bdb_index_recrun( op, bdb, ir, e->e_id, 0 );
                if ( rc )
                        return rc;
+               ldap_pvt_thread_mutex_lock( &bdb_tool_index_mutex );
                for ( i=1; i<slap_tool_thread_max; i++ ) {
                        if ( bdb_tool_index_threads[i] == LDAP_BUSY ) {
-                               ldap_pvt_thread_yield();
+                               ldap_pvt_thread_cond_wait( &bdb_tool_index_cond_main, 
+                                       &bdb_tool_index_mutex );
                                i--;
                                continue;
                        }
-                       if ( bdb_tool_index_threads[i] )
-                               return bdb_tool_index_threads[i];
+                       if ( bdb_tool_index_threads[i] ) {
+                               rc = bdb_tool_index_threads[i];
+                               break;
+                       }
                }
-               return 0;
+               ldap_pvt_thread_mutex_unlock( &bdb_tool_index_mutex );
+               return rc;
        } else {
                return bdb_index_entry_add( op, txn, e );
        }
@@ -468,11 +521,18 @@ ID bdb_tool_entry_put(
                goto done;
        }
 
-       /* id2entry index */
-       rc = bdb_id2entry_add( be, tid, e );
+       if (( slapMode & SLAP_TOOL_QUICK ) && (( e->e_id & 0xfff ) == 0xfff )) {
+               ldap_pvt_thread_mutex_lock( &bdb_tool_trickle_mutex );
+               ldap_pvt_thread_cond_signal( &bdb_tool_trickle_cond );
+               ldap_pvt_thread_mutex_unlock( &bdb_tool_trickle_mutex );
+       }
+
+       if ( !bdb->bi_linear_index )
+               rc = bdb_tool_index_add( &op, tid, e );
        if( rc != 0 ) {
                snprintf( text->bv_val, text->bv_len,
-                               "id2entry_add failed: %s (%d)",
+                               "index_entry_add failed: %s (%d)",
+                               rc == LDAP_OTHER ? "Internal error" :
                                db_strerror(rc), rc );
                Debug( LDAP_DEBUG_ANY,
                        "=> " LDAP_XSTRING(bdb_tool_entry_put) ": %s\n",
@@ -480,11 +540,11 @@ ID bdb_tool_entry_put(
                goto done;
        }
 
-       if ( !bdb->bi_linear_index )
-               rc = bdb_tool_index_add( &op, tid, e );
+       /* id2entry index */
+       rc = bdb_id2entry_add( be, tid, e );
        if( rc != 0 ) {
                snprintf( text->bv_val, text->bv_len,
-                               "index_entry_add failed: %s (%d)",
+                               "id2entry_add failed: %s (%d)",
                                db_strerror(rc), rc );
                Debug( LDAP_DEBUG_ANY,
                        "=> " LDAP_XSTRING(bdb_tool_entry_put) ": %s\n",
@@ -512,6 +572,7 @@ done:
                TXN_ABORT( tid );
                snprintf( text->bv_val, text->bv_len,
                        "txn_aborted! %s (%d)",
+                       rc == LDAP_OTHER ? "Internal error" :
                        db_strerror(rc), rc );
                Debug( LDAP_DEBUG_ANY,
                        "=> " LDAP_XSTRING(bdb_tool_entry_put) ": %s\n",
@@ -525,7 +586,8 @@ done:
 
 int bdb_tool_entry_reindex(
        BackendDB *be,
-       ID id )
+       ID id,
+       AttributeDescription **adv )
 {
        struct bdb_info *bi = (struct bdb_info *) be->be_private;
        int rc;
@@ -545,6 +607,47 @@ int bdb_tool_entry_reindex(
                return 0;
        }
 
+       /* Check for explicit list of attrs to index */
+       if ( adv ) {
+               int i, j, n;
+
+               if ( bi->bi_attrs[0]->ai_desc != adv[0] ) {
+                       /* count */
+                       for ( n = 0; adv[n]; n++ ) ;
+
+                       /* insertion sort */
+                       for ( i = 0; i < n; i++ ) {
+                               AttributeDescription *ad = adv[i];
+                               for ( j = i-1; j>=0; j--) {
+                                       if ( SLAP_PTRCMP( adv[j], ad ) <= 0 ) break;
+                                       adv[j+1] = adv[j];
+                               }
+                               adv[j+1] = ad;
+                       }
+               }
+
+               for ( i = 0; adv[i]; i++ ) {
+                       if ( bi->bi_attrs[i]->ai_desc != adv[i] ) {
+                               for ( j = i+1; j < bi->bi_nattrs; j++ ) {
+                                       if ( bi->bi_attrs[j]->ai_desc == adv[i] ) {
+                                               AttrInfo *ai = bi->bi_attrs[i];
+                                               bi->bi_attrs[i] = bi->bi_attrs[j];
+                                               bi->bi_attrs[j] = ai;
+                                               break;
+                                       }
+                               }
+                               if ( j == bi->bi_nattrs ) {
+                                       Debug( LDAP_DEBUG_ANY,
+                                               LDAP_XSTRING(bdb_tool_entry_reindex)
+                                               ": no index configured for %s\n",
+                                               adv[i]->ad_cname.bv_val, 0, 0 );
+                                       return -1;
+                               }
+                       }
+               }
+               bi->bi_nattrs = i;
+       }
+
        /* Get the first attribute to index */
        if (bi->bi_linear_index && !index_nattrs) {
                index_nattrs = bi->bi_nattrs - 1;
@@ -643,17 +746,21 @@ ID bdb_tool_entry_modify(
                (long) e->e_id, e->e_dn, 0 );
 
        if (! (slapMode & SLAP_TOOL_QUICK)) {
-       rc = TXN_BEGIN( bdb->bi_dbenv, NULL, &tid, 
-               bdb->bi_db_opflags );
-       if( rc != 0 ) {
-               snprintf( text->bv_val, text->bv_len,
-                       "txn_begin failed: %s (%d)",
-                       db_strerror(rc), rc );
-               Debug( LDAP_DEBUG_ANY,
-                       "=> " LDAP_XSTRING(bdb_tool_entry_modify) ": %s\n",
-                        text->bv_val, 0, 0 );
-               return NOID;
-       }
+               if( cursor ) {
+                       cursor->c_close( cursor );
+                       cursor = NULL;
+               }
+               rc = TXN_BEGIN( bdb->bi_dbenv, NULL, &tid, 
+                       bdb->bi_db_opflags );
+               if( rc != 0 ) {
+                       snprintf( text->bv_val, text->bv_len,
+                               "txn_begin failed: %s (%d)",
+                               db_strerror(rc), rc );
+                       Debug( LDAP_DEBUG_ANY,
+                               "=> " LDAP_XSTRING(bdb_tool_entry_modify) ": %s\n",
+                                text->bv_val, 0, 0 );
+                       return NOID;
+               }
        }
 
        op.o_hdr = &ohdr;
@@ -673,33 +780,6 @@ ID bdb_tool_entry_modify(
                goto done;
        }
 
-#if 0
-       /* FIXME: this is bogus, we don't have the old values to delete
-        * from the index because the given entry has already been modified.
-        */
-       rc = bdb_index_entry_del( &op, tid, e );
-       if( rc != 0 ) {
-               snprintf( text->bv_val, text->bv_len,
-                               "index_entry_del failed: %s (%d)",
-                               db_strerror(rc), rc );
-               Debug( LDAP_DEBUG_ANY,
-                       "=> " LDAP_XSTRING(bdb_tool_entry_modify) ": %s\n",
-                       text->bv_val, 0, 0 );
-               goto done;
-       }
-#endif
-
-       rc = bdb_index_entry_add( &op, tid, e );
-       if( rc != 0 ) {
-               snprintf( text->bv_val, text->bv_len,
-                               "index_entry_add failed: %s (%d)",
-                               db_strerror(rc), rc );
-               Debug( LDAP_DEBUG_ANY,
-                       "=> " LDAP_XSTRING(bdb_tool_entry_modify) ": %s\n",
-                       text->bv_val, 0, 0 );
-               goto done;
-       }
-
 done:
        if( rc == 0 ) {
                if (! (slapMode & SLAP_TOOL_QUICK)) {
@@ -731,14 +811,7 @@ done:
        return e->e_id;
 }
 
-
-typedef struct bdb_tool_idl_cache {
-       struct berval kstr;
-       ID first, last;
-       int idls[BDB_IDL_DB_SIZE / IDBLOCK];
-       int idn, count;
-} bdb_tool_idl_cache;
-
+#ifdef BDB_TOOL_IDL_CACHING
 static int
 bdb_tool_idl_cmp( const void *v1, const void *v2 )
 {
@@ -754,13 +827,15 @@ bdb_tool_idl_flush_one( void *v1, void *arg )
 {
        bdb_tool_idl_cache *ic = v1;
        DB *db = arg;
+       struct bdb_info *bdb = bdb_tool_info;
+       bdb_tool_idl_cache_entry *ice;
        DBC *curs;
        DBT key, data;
        int i, rc;
        ID id, nid;
 
-       if ( !ic->count ) {
-               ch_free( ic );
+       /* Freshly allocated, ignore it */
+       if ( !ic->head && ic->count <= BDB_IDL_DB_SIZE ) {
                return 0;
        }
 
@@ -825,10 +900,9 @@ bdb_tool_idl_flush_one( void *v1, void *arg )
 
                /* Just a normal write */
                rc = 0;
-               for ( n=0; n<=ic->idn; n++ ) {
-                       ID *ids = bdb_tool_idls + ic->idls[n];
+               for ( ice = ic->head, n=0; ice; ice = ice->next, n++ ) {
                        int end;
-                       if ( n < ic->idn ) {
+                       if ( ice->next ) {
                                end = IDBLOCK;
                        } else {
                                end = ic->count & (IDBLOCK-1);
@@ -836,8 +910,8 @@ bdb_tool_idl_flush_one( void *v1, void *arg )
                                        end = IDBLOCK;
                        }
                        for ( i=0; i<end; i++ ) {
-                               if ( !ids[i] ) continue;
-                               BDB_ID2DISK( ids[i], &nid );
+                               if ( !ice->ids[i] ) continue;
+                               BDB_ID2DISK( ice->ids[i], &nid );
                                rc = curs->c_put( curs, &key, &data, DB_NODUPDATA );
                                if ( rc ) {
                                        if ( rc == DB_KEYEXIST ) {
@@ -853,12 +927,38 @@ bdb_tool_idl_flush_one( void *v1, void *arg )
                                break;
                        }
                }
+               if ( ic->head ) {
+                       ldap_pvt_thread_mutex_lock( &bdb->bi_idl_tree_lrulock );
+                       ic->tail->next = bdb_tool_idl_free_list;
+                       bdb_tool_idl_free_list = ic->head;
+                       bdb->bi_idl_cache_size -= n;
+                       ldap_pvt_thread_mutex_unlock( &bdb->bi_idl_tree_lrulock );
+               }
+       }
+       if ( ic != db->app_private ) {
+               ch_free( ic );
+       } else {
+               ic->head = ic->tail = NULL;
        }
-       ch_free( ic );
        curs->c_close( curs );
        return rc;
 }
 
+static int
+bdb_tool_idl_flush_db( DB *db, bdb_tool_idl_cache *ic )
+{
+       Avlnode *root = db->app_private;
+       int rc;
+
+       db->app_private = ic;
+       rc = avl_apply( root, bdb_tool_idl_flush_one, db, -1, AVL_INORDER );
+       avl_free( root, NULL );
+       db->app_private = NULL;
+       if ( rc != -1 )
+               rc = 0;
+       return rc;
+}
+
 static int
 bdb_tool_idl_flush( BackendDB *be )
 {
@@ -870,17 +970,12 @@ bdb_tool_idl_flush( BackendDB *be )
        for ( i=BDB_NDB; i < bdb->bi_ndatabases; i++ ) {
                db = bdb->bi_databases[i]->bdi_db;
                if ( !db->app_private ) continue;
-               rc = avl_apply( db->app_private, bdb_tool_idl_flush_one, db, -1,
-                       AVL_INORDER );
-               avl_free( db->app_private, NULL );
-               db->app_private = NULL;
-               if ( rc == -1 )
+               rc = bdb_tool_idl_flush_db( db, NULL );
+               if ( rc )
                        break;
-               rc = 0;
        }
        if ( !rc ) {
                bdb->bi_idl_cache_size = 0;
-               bdb_tool_idl_next = 0;
        }
        return rc;
 }
@@ -894,8 +989,7 @@ int bdb_tool_idl_add(
 {
        struct bdb_info *bdb = (struct bdb_info *) be->be_private;
        bdb_tool_idl_cache *ic, itmp;
-       ID *ids;
-       Avlnode *root;
+       bdb_tool_idl_cache_entry *ice;
        int rc;
 
        if ( !bdb->bi_idl_cache_max_size )
@@ -903,10 +997,7 @@ int bdb_tool_idl_add(
 
        DBT2bv( key, &itmp.kstr );
 
-retry:
-       root = db->app_private;
-
-       ic = avl_find( root, &itmp, bdb_tool_idl_cmp );
+       ic = avl_find( (Avlnode *)db->app_private, &itmp, bdb_tool_idl_cmp );
 
        /* No entry yet, create one */
        if ( !ic ) {
@@ -919,11 +1010,11 @@ retry:
                ic->kstr.bv_len = itmp.kstr.bv_len;
                ic->kstr.bv_val = (char *)(ic+1);
                AC_MEMCPY( ic->kstr.bv_val, itmp.kstr.bv_val, ic->kstr.bv_len );
-               ic->idn = -1;
+               ic->head = ic->tail = NULL;
                ic->last = 0;
                ic->count = 0;
-               avl_insert( &root, ic, bdb_tool_idl_cmp, avl_dup_error );
-               db->app_private = root;
+               avl_insert( (Avlnode **)&db->app_private, ic, bdb_tool_idl_cmp,
+                       avl_dup_error );
 
                /* load existing key count here */
                rc = db->cursor( db, NULL, &curs, 0 );
@@ -952,37 +1043,79 @@ retry:
                return 0;
        /* Are we at the limit, and converting to a range? */
        } else if ( ic->count == BDB_IDL_DB_SIZE ) {
+               int n;
+               for ( ice = ic->head, n=0; ice; ice = ice->next, n++ )
+                       /* counting */ ;
+               if ( n ) {
+                       ldap_pvt_thread_mutex_lock( &bdb->bi_idl_tree_lrulock );
+                       ic->tail->next = bdb_tool_idl_free_list;
+                       bdb_tool_idl_free_list = ic->head;
+                       bdb->bi_idl_cache_size -= n;
+                       ldap_pvt_thread_mutex_unlock( &bdb->bi_idl_tree_lrulock );
+               }
+               ic->head = ic->tail = NULL;
                ic->last = id;
                ic->count++;
-               ic->idn = -1;
                return 0;
        }
        /* No free block, create that too */
-       if ( ic->idn == -1 || ( ic->count & (IDBLOCK-1)) == 0) {
+       if ( !ic->tail || ( ic->count & (IDBLOCK-1)) == 0) {
+               ice = NULL;
                ldap_pvt_thread_mutex_lock( &bdb->bi_idl_tree_lrulock );
-               bdb->bi_idl_cache_size++;
-               if ( bdb->bi_idl_cache_size > bdb->bi_idl_cache_max_size ) {
-                       rc = bdb_tool_idl_flush( be );
+               if ( bdb->bi_idl_cache_size >= bdb->bi_idl_cache_max_size ) {
                        ldap_pvt_thread_mutex_unlock( &bdb->bi_idl_tree_lrulock );
+                       rc = bdb_tool_idl_flush_db( db, ic );
                        if ( rc )
                                return rc;
-                       goto retry;
+                       avl_insert( (Avlnode **)&db->app_private, ic, bdb_tool_idl_cmp,
+                               avl_dup_error );
+                       ldap_pvt_thread_mutex_lock( &bdb->bi_idl_tree_lrulock );
+               }
+               bdb->bi_idl_cache_size++;
+               if ( bdb_tool_idl_free_list ) {
+                       ice = bdb_tool_idl_free_list;
+                       bdb_tool_idl_free_list = ice->next;
                }
-               ic->idls[++ic->idn] = bdb_tool_idl_next;
-               ids = bdb_tool_idls + bdb_tool_idl_next;
-               bdb_tool_idl_next += IDBLOCK;
                ldap_pvt_thread_mutex_unlock( &bdb->bi_idl_tree_lrulock );
-
-               memset( ids, 0, IDBLOCK * sizeof( ID ));
+               if ( !ice ) {
+                       ice = ch_malloc( sizeof( bdb_tool_idl_cache_entry ));
+               }
+               memset( ice, 0, sizeof( *ice ));
+               if ( !ic->head ) {
+                       ic->head = ice;
+               } else {
+                       ic->tail->next = ice;
+               }
+               ic->tail = ice;
                if ( !ic->count )
                        ic->first = id;
        }
-       ids = bdb_tool_idls + ic->idls[ic->idn];
-       ids[ ic->count & (IDBLOCK-1) ] = id;
+       ice = ic->tail;
+       ice->ids[ ic->count & (IDBLOCK-1) ] = id;
        ic->count++;
 
        return 0;
 }
+#endif
+
+static void *
+bdb_tool_trickle_task( void *ctx, void *ptr )
+{
+       DB_ENV *env = ptr;
+       int wrote;
+
+       ldap_pvt_thread_mutex_lock( &bdb_tool_trickle_mutex );
+       while ( 1 ) {
+               ldap_pvt_thread_cond_wait( &bdb_tool_trickle_cond,
+                       &bdb_tool_trickle_mutex );
+               if ( slapd_shutdown )
+                       break;
+               env->memp_trickle( env, 30, &wrote );
+       }
+       ldap_pvt_thread_mutex_unlock( &bdb_tool_trickle_mutex );
+
+       return NULL;
+}
 
 static void *
 bdb_tool_index_task( void *ctx, void *ptr )
@@ -992,7 +1125,10 @@ bdb_tool_index_task( void *ctx, void *ptr )
        free( ptr );
        while ( 1 ) {
                ldap_pvt_thread_mutex_lock( &bdb_tool_index_mutex );
-               ldap_pvt_thread_cond_wait( &bdb_tool_index_cond,
+               bdb_tool_index_tcount--;
+               if ( !bdb_tool_index_tcount )
+                       ldap_pvt_thread_cond_signal( &bdb_tool_index_cond_main );
+               ldap_pvt_thread_cond_wait( &bdb_tool_index_cond_work,
                        &bdb_tool_index_mutex );
                ldap_pvt_thread_mutex_unlock( &bdb_tool_index_mutex );
                if ( slapd_shutdown )