]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-dnssrv/search.c
ITS#2888 don't return LDAP_SIZELIMIT_EXCEEDED prematurely
[openldap] / servers / slapd / back-dnssrv / search.c
index 720aa179a7ac6cbd48294277472334bf1d6f0e48..f0077d5bd0c5777bfda958b2434791e975cbe2fa 100644 (file)
@@ -1,10 +1,23 @@
 /* search.c - DNS SRV backend search function */
 /* $OpenLDAP$ */
-/*
- * Copyright 2000-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 2000-2003 The OpenLDAP Foundation.
+ * Portions Copyright 2000-2003 Kurt D. Zeilenga.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* ACKNOWLEDGEMENTS:
+ * This work was originally developed by Kurt D. Zeilenga for inclusion
+ * in OpenLDAP Software.
  */
-
 
 #include "portable.h"
 
 
 int
 dnssrv_back_search(
-    Backend    *be,
-    Connection *conn,
     Operation  *op,
-    struct berval      *dn,
-    struct berval      *ndn,
-    int                scope,
-    int                deref,
-    int                size,
-    int                time,
-    Filter     *filter,
-    struct berval      *filterstr,
-    AttributeName      *attrs,
-    int                attrsonly )
+    SlapReply  *rs )
 {
        int i;
        int rc;
@@ -40,35 +42,46 @@ dnssrv_back_search(
        char **hosts = NULL;
        char *refdn;
        struct berval nrefdn = { 0, NULL };
-       BVarray urls = NULL;
-
-       assert( get_manageDSAit( op ) );
+       BerVarray urls = NULL;
+       int manageDSAit;
+
+       rs->sr_ref = NULL;
+
+       manageDSAit = get_manageDSAit( op );
+       /*
+        * FIXME: we may return a referral if manageDSAit is not set
+        */
+       if ( ! manageDSAit ) {
+               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+                               "manageDSAit must be set" );
+               goto done;
+       }
 
-       if( ldap_dn2domain( dn->bv_val, &domain ) ) {
-               send_ldap_result( conn, op, LDAP_REFERRAL,
-                       NULL, NULL, default_referral, NULL );
+       if( ldap_dn2domain( op->o_req_dn.bv_val, &domain ) || domain == NULL ) {
+               rs->sr_err = LDAP_REFERRAL;
+               rs->sr_ref = default_referral;
+               send_ldap_result( op, rs );
+               rs->sr_ref = NULL;
                goto done;
        }
 
        Debug( LDAP_DEBUG_TRACE, "DNSSRV: dn=\"%s\" -> domain=\"%s\"\n",
-               dn->bv_len ? dn->bv_val : "",
-               domain == NULL ? "" : domain,
-               0 );
+               op->o_req_dn.bv_len ? op->o_req_dn.bv_val : "", domain, 0 );
 
-       if( rc = ldap_domain2hostlist( domain, &hostlist ) ) {
+       if( ( rc = ldap_domain2hostlist( domain, &hostlist ) ) ) {
                Debug( LDAP_DEBUG_TRACE, "DNSSRV: domain2hostlist returned %d\n",
                        rc, 0, 0 );
-               send_ldap_result( conn, op, LDAP_NO_SUCH_OBJECT,
-                       NULL, "no DNS SRV RR available for DN", NULL, NULL );
+               send_ldap_error( op, rs, LDAP_NO_SUCH_OBJECT,
+                       "no DNS SRV RR available for DN" );
                goto done;
        }
 
-       hosts = str2charray( hostlist, " " );
+       hosts = ldap_str2charray( hostlist, " " );
 
        if( hosts == NULL ) {
                Debug( LDAP_DEBUG_TRACE, "DNSSRV: str2charrary error\n", 0, 0, 0 );
-               send_ldap_result( conn, op, LDAP_OTHER,
-                       NULL, "problem processing DNS SRV records for DN", NULL, NULL );
+               send_ldap_error( op, rs, LDAP_OTHER,
+                       "problem processing DNS SRV records for DN" );
                goto done;
        }
 
@@ -81,32 +94,30 @@ dnssrv_back_search(
                strcpy( url.bv_val, "ldap://" );
                strcpy( &url.bv_val[sizeof("ldap://")-1], hosts[i] );
 
-               if( bvarray_add( &urls, &url ) < 0 ) {
+               if( ber_bvarray_add( &urls, &url ) < 0 ) {
                        free( url.bv_val );
-                       send_ldap_result( conn, op, LDAP_OTHER,
-                       NULL, "problem processing DNS SRV records for DN",
-                       NULL, NULL );
+                       send_ldap_error( op, rs, LDAP_OTHER,
+                       "problem processing DNS SRV records for DN" );
                        goto done;
                }
        }
 
        Statslog( LDAP_DEBUG_STATS,
-           "conn=%ld op=%d DNSSRV p=%d dn=\"%s\" url=\"%s\"\n",
+           "conn=%lu op=%lu DNSSRV p=%d dn=\"%s\" url=\"%s\"\n",
            op->o_connid, op->o_opid, op->o_protocol,
-               dn->bv_len ? dn->bv_val : "", urls[0].bv_val );
+               op->o_req_dn.bv_len ? op->o_req_dn.bv_val : "", urls[0].bv_val );
 
        Debug( LDAP_DEBUG_TRACE,
                "DNSSRV: ManageDSAit scope=%d dn=\"%s\" -> url=\"%s\"\n",
-               scope,
-               dn->bv_len ? dn->bv_val : "",
+               op->oq_search.rs_scope,
+               op->o_req_dn.bv_len ? op->o_req_dn.bv_val : "",
                urls[0].bv_val );
 
        rc = ldap_domain2dn(domain, &refdn);
 
        if( rc != LDAP_SUCCESS ) {
-               send_ldap_result( conn, op, LDAP_OTHER,
-                       NULL, "DNS SRV problem processing manageDSAit control",
-                       NULL, NULL );
+               send_ldap_error( op, rs, LDAP_OTHER,
+                       "DNS SRV problem processing manageDSAit control" );
                goto done;
 
        } else {
@@ -114,31 +125,30 @@ dnssrv_back_search(
                bv.bv_val = refdn;
                bv.bv_len = strlen( refdn );
 
-               rc = dnNormalize2( NULL, &bv, &nrefdn );
+               rc = dnNormalize( 0, NULL, NULL, &bv, &nrefdn, op->o_tmpmemctx );
                if( rc != LDAP_SUCCESS ) {
-                       send_ldap_result( conn, op, LDAP_OTHER,
-                               NULL, "DNS SRV problem processing manageDSAit control",
-                               NULL, NULL );
+                       send_ldap_error( op, rs, LDAP_OTHER,
+                               "DNS SRV problem processing manageDSAit control" );
                        goto done;
                }
        }
 
-       if( !dn_match( &nrefdn, ndn ) ) {
+       if( !dn_match( &nrefdn, &op->o_req_ndn ) ) {
                /* requested dn is subordinate */
 
                Debug( LDAP_DEBUG_TRACE,
-                       "DNSSRV: dn=\"%s\" subordindate to refdn=\"%s\"\n",
-                       dn->bv_len ? dn->bv_val : "",
+                       "DNSSRV: dn=\"%s\" subordinate to refdn=\"%s\"\n",
+                       op->o_req_dn.bv_len ? op->o_req_dn.bv_val : "",
                        refdn == NULL ? "" : refdn,
                        NULL );
 
-               send_ldap_result( conn, op, LDAP_NO_SUCH_OBJECT,
-                       refdn, NULL,
-                       NULL, NULL );
+               rs->sr_matched = refdn;
+               rs->sr_err = LDAP_NO_SUCH_OBJECT;
+               send_ldap_result( op, rs );
+               rs->sr_matched = NULL;
 
-       } else if ( scope == LDAP_SCOPE_ONELEVEL ) {
-               send_ldap_result( conn, op, LDAP_SUCCESS,
-                       NULL, NULL, NULL, NULL );
+       } else if ( op->oq_search.rs_scope == LDAP_SCOPE_ONELEVEL ) {
+               send_ldap_error( op, rs, LDAP_SUCCESS, NULL );
 
        } else {
                struct berval   vals[2];
@@ -146,10 +156,10 @@ dnssrv_back_search(
                AttributeDescription *ad_objectClass
                        = slap_schema.si_ad_objectClass;
                AttributeDescription *ad_ref = slap_schema.si_ad_ref;
-               e->e_dn = strdup( dn->bv_val );
-               e->e_name.bv_len = dn->bv_len;
-               e->e_ndn = strdup( ndn->bv_val );
-               e->e_nname.bv_len = ndn->bv_len;
+               e->e_name.bv_val = strdup( op->o_req_dn.bv_val );
+               e->e_name.bv_len = op->o_req_dn.bv_len;
+               e->e_nname.bv_val = strdup( op->o_req_ndn.bv_val );
+               e->e_nname.bv_len = op->o_req_ndn.bv_len;
 
                e->e_attrs = NULL;
                e->e_private = NULL;
@@ -158,15 +168,15 @@ dnssrv_back_search(
 
                vals[0].bv_val = "top";
                vals[0].bv_len = sizeof("top")-1;
-               attr_merge( e, ad_objectClass, vals );
+               attr_mergeit( e, ad_objectClass, vals );
 
                vals[0].bv_val = "referral";
                vals[0].bv_len = sizeof("referral")-1;
-               attr_merge( e, ad_objectClass, vals );
+               attr_mergeit( e, ad_objectClass, vals );
 
                vals[0].bv_val = "extensibleObject";
                vals[0].bv_len = sizeof("extensibleObject")-1;
-               attr_merge( e, ad_objectClass, vals );
+               attr_mergeit( e, ad_objectClass, vals );
 
                {
                        AttributeDescription *ad = NULL;
@@ -187,7 +197,7 @@ dnssrv_back_search(
                                }
 
                                vals[0].bv_len = strlen(vals[0].bv_val);
-                               attr_merge( e, ad, vals );
+                               attr_mergeit( e, ad, vals );
                        }
                }
 
@@ -200,23 +210,26 @@ dnssrv_back_search(
                        if( rc == LDAP_SUCCESS ) {
                                vals[0].bv_val = domain;
                                vals[0].bv_len = strlen(domain);
-                               attr_merge( e, ad, vals );
+                               attr_mergeit( e, ad, vals );
                        }
                }
 
-               attr_merge( e, ad_ref, urls );
+               attr_mergeit( e, ad_ref, urls );
 
-               rc = test_filter( be, conn, op, e, filter ); 
+               rc = test_filter( op, e, op->oq_search.rs_filter ); 
 
                if( rc == LDAP_COMPARE_TRUE ) {
-                       send_search_entry( be, conn, op,
-                               e, attrs, attrsonly, NULL );
+                       rs->sr_entry = e;
+                       rs->sr_attrs = op->oq_search.rs_attrs;
+                       send_search_entry( op, rs );
+                       rs->sr_entry = NULL;
+                       rs->sr_attrs = NULL;
                }
 
                entry_free( e );
-                       
-               send_ldap_result( conn, op, LDAP_SUCCESS,
-                       NULL, NULL, NULL, NULL );
+
+               rs->sr_err = LDAP_SUCCESS;
+               send_ldap_result( op, rs );
        }
 
        if ( refdn ) free( refdn );
@@ -225,7 +238,8 @@ dnssrv_back_search(
 done:
        if( domain != NULL ) ch_free( domain );
        if( hostlist != NULL ) ch_free( hostlist );
-       if( hosts != NULL ) charray_free( hosts );
-       if( urls != NULL ) bvarray_free( urls );
+       if( hosts != NULL ) ldap_charray_free( hosts );
+       if( urls != NULL ) ber_bvarray_free( urls );
        return 0;
 }
+