]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-ldap/config.c
import fix to ITS#4071
[openldap] / servers / slapd / back-ldap / config.c
index a8e82ad0eacd6c612c246ca2760630c0d1bce8c8..6d80e96153bf2884732c2176c38476a46f663d34 100644 (file)
@@ -1,38 +1,24 @@
 /* config.c - ldap backend configuration file routine */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
- */
-/* This is an altered version */
-/*
- * Copyright 1999, Howard Chu, All rights reserved. <hyc@highlandsun.com>
- * 
- * Permission is granted to anyone to use this software for any purpose
- * on any computer system, and to alter it and redistribute it, subject
- * to the following restrictions:
- * 
- * 1. The author is not responsible for the consequences of use of this
- *    software, no matter how awful, even if they arise from flaws in it.
- * 
- * 2. The origin of this software must not be misrepresented, either by
- *    explicit claim or by omission.  Since few users ever read sources,
- *    credits should appear in the documentation.
- * 
- * 3. Altered versions must be plainly marked as such, and must not be
- *    misrepresented as being the original software.  Since few users
- *    ever read sources, credits should appear in the documentation.
- * 
- * 4. This notice may not be removed or altered.
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
+ * Copyright 2003-2005 The OpenLDAP Foundation.
+ * Portions Copyright 1999-2003 Howard Chu.
+ * Portions Copyright 2000-2003 Pierangelo Masarati.
+ * All rights reserved.
  *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
  *
- * Copyright 2000, Pierangelo Masarati, All rights reserved. <ando@sys-net.it>
- * 
- * This software is being modified by Pierangelo Masarati.
- * The previously reported conditions apply to the modified code as well.
- * Changes in the original code are highlighted where required.
- * Credits for the original code go to the author, Howard Chu.
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* ACKNOWLEDGEMENTS:
+ * This work was initially developed by the Howard Chu for inclusion
+ * in OpenLDAP Software and subsequently enhanced by Pierangelo
+ * Masarati.
  */
 
 #include "portable.h"
 
 #include "slap.h"
 #include "back-ldap.h"
+#include "lutil.h"
+#undef ldap_debug
+/* for advanced URL parsing */
+#include "../../../libraries/libldap/ldap-int.h"
+
+static SLAP_EXTOP_MAIN_FN ldap_back_exop_whoami;
 
 int
 ldap_back_db_config(
@@ -81,15 +73,88 @@ ldap_back_db_config(
 
        /* URI of server to query (preferred over "server" directive) */
        } else if ( strcasecmp( argv[0], "uri" ) == 0 ) {
+               LDAPURLDesc     *tmpludp;
+               int             urlrc, i;
+
                if (argc != 2) {
-                       fprintf( stderr,
-       "%s: line %d: missing address in \"uri <address>\" line\n",
-                           fname, lineno );
+                       fprintf( stderr, "%s: line %d: "
+                               "missing uri "
+                               "in \"uri <uri>\" line\n",
+                               fname, lineno );
                        return( 1 );
                }
-               if (li->url != NULL)
-                       ch_free(li->url);
-               li->url = ch_strdup(argv[1]);
+               if ( li->url != NULL ) {
+                       ch_free( li->url );
+               }
+               if ( li->lud != NULL ) {
+                       ldap_free_urldesc( li->lud );
+               }
+
+               urlrc = ldap_url_parselist( &li->lud, argv[ 1 ] );
+               if ( urlrc != LDAP_URL_SUCCESS ) {
+                       char    *why;
+
+                       switch ( urlrc ) {
+                       case LDAP_URL_ERR_MEM:
+                               why = "no memory";
+                               break;
+                       case LDAP_URL_ERR_PARAM:
+                               why = "parameter is bad";
+                               break;
+                       case LDAP_URL_ERR_BADSCHEME:
+                               why = "URL doesn't begin with \"[c]ldap[si]://\"";
+                               break;
+                       case LDAP_URL_ERR_BADENCLOSURE:
+                               why = "URL is missing trailing \">\"";
+                               break;
+                       case LDAP_URL_ERR_BADURL:
+                               why = "URL is bad";
+                       case LDAP_URL_ERR_BADHOST:
+                               why = "host/port is bad";
+                               break;
+                       case LDAP_URL_ERR_BADATTRS:
+                               why = "bad (or missing) attributes";
+                               break;
+                       case LDAP_URL_ERR_BADSCOPE:
+                               why = "scope string is invalid (or missing)";
+                               break;
+                       case LDAP_URL_ERR_BADFILTER:
+                               why = "bad or missing filter";
+                               break;
+                       case LDAP_URL_ERR_BADEXTS:
+                               why = "bad or missing extensions";
+                               break;
+                       default:
+                               why = "unknown reason";
+                               break;
+                       }
+                       fprintf( stderr, "%s: line %d: "
+                                       "unable to parse uri \"%s\" "
+                                       "in \"uri <uri>\" line: %s\n",
+                                       fname, lineno, argv[ 1 ], why );
+                       return 1;
+               }
+
+               for ( i = 0, tmpludp = li->lud;
+                               tmpludp;
+                               i++, tmpludp = tmpludp->lud_next )
+               {
+                       if ( ( tmpludp->lud_dn != NULL
+                                               && tmpludp->lud_dn[0] != '\0' )
+                                       || tmpludp->lud_attrs != NULL
+                                       || tmpludp->lud_filter != NULL
+                                       || tmpludp->lud_exts != NULL )
+                       {
+                               fprintf( stderr, "%s: line %d: "
+                                               "warning, only protocol, "
+                                               "host and port allowed "
+                                               "in \"uri <uri>\" statement "
+                                               "for uri #%d of \"%s\"\n",
+                                               fname, lineno, i, argv[1] );
+                       }
+               }
+
+               li->url = ch_strdup( argv[ 1 ] );
 
        /* name to use for ldap_back_group */
        } else if ( strcasecmp( argv[0], "binddn" ) == 0 ) {
@@ -99,7 +164,7 @@ ldap_back_db_config(
                            fname, lineno );
                        return( 1 );
                }
-               li->binddn = ch_strdup(argv[1]);
+               ber_str2bv( argv[1], 0, 1, &li->binddn );
 
        /* password to use for ldap_back_group */
        } else if ( strcasecmp( argv[0], "bindpw" ) == 0 ) {
@@ -109,8 +174,30 @@ ldap_back_db_config(
                            fname, lineno );
                        return( 1 );
                }
-               li->bindpw = ch_strdup(argv[1]);
-       
+               ber_str2bv( argv[1], 0, 1, &li->bindpw );
+
+#ifdef LDAP_BACK_PROXY_AUTHZ
+       /* name to use for proxyAuthz propagation */
+       } else if ( strcasecmp( argv[0], "proxyauthzdn" ) == 0 ) {
+               if (argc != 2) {
+                       fprintf( stderr,
+       "%s: line %d: missing name in \"proxyauthzdn <name>\" line\n",
+                           fname, lineno );
+                       return( 1 );
+               }
+               ber_str2bv( argv[1], 0, 1, &li->proxyauthzdn );
+
+       /* password to use for proxyAuthz propagation */
+       } else if ( strcasecmp( argv[0], "proxyauthzpw" ) == 0 ) {
+               if (argc != 2) {
+                       fprintf( stderr,
+       "%s: line %d: missing password in \"proxyauthzpw <password>\" line\n",
+                           fname, lineno );
+                       return( 1 );
+               }
+               ber_str2bv( argv[1], 0, 1, &li->proxyauthzpw );
+#endif /* LDAP_BACK_PROXY_AUTHZ */
+
        /* save bind creds for referral rebinds? */
        } else if ( strcasecmp( argv[0], "rebind-as-user" ) == 0 ) {
                if (argc != 1) {
@@ -121,6 +208,17 @@ ldap_back_db_config(
                }
                li->savecred = 1;
        
+       /* intercept exop_who_am_i? */
+       } else if ( strcasecmp( argv[0], "proxy-whoami" ) == 0 ) {
+               if (argc != 1) {
+                       fprintf( stderr,
+       "%s: line %d: proxy-whoami takes no arguments\n",
+                           fname, lineno );
+                       return( 1 );
+               }
+               load_extop( (struct berval *)&slap_EXOP_WHOAMI,
+                       0, ldap_back_exop_whoami );
+       
        /* dn massaging */
        } else if ( strcasecmp( argv[0], "suffixmassage" ) == 0 ) {
                BackendDB *tmp_be;
@@ -149,7 +247,7 @@ ldap_back_db_config(
                }
                
                ber_str2bv( argv[1], 0, 0, &bvnc );
-               if ( dnPrettyNormal( NULL, &bvnc, &pvnc, &nvnc ) != LDAP_SUCCESS ) {
+               if ( dnPrettyNormal( NULL, &bvnc, &pvnc, &nvnc, NULL ) != LDAP_SUCCESS ) {
                        fprintf( stderr, "%s: line %d: suffix DN %s is invalid\n",
                                fname, lineno, bvnc.bv_val );
                        return( 1 );
@@ -167,7 +265,7 @@ ldap_back_db_config(
                }
 
                ber_str2bv( argv[2], 0, 0, &brnc );
-               if ( dnPrettyNormal( NULL, &brnc, &prnc, &nrnc ) != LDAP_SUCCESS ) {
+               if ( dnPrettyNormal( NULL, &brnc, &prnc, &nrnc, NULL ) != LDAP_SUCCESS ) {
                        fprintf( stderr, "%s: line %d: suffix DN %s is invalid\n",
                                fname, lineno, brnc.bv_val );
                        free( nvnc.bv_val );
@@ -198,7 +296,8 @@ ldap_back_db_config(
                 * FIXME: no extra rewrite capabilities should be added
                 * to the database
                 */
-               rc = suffix_massage_config( li->rwinfo, &pvnc, &nvnc, &prnc, &nrnc );
+               rc = suffix_massage_config( li->rwmap.rwm_rw,
+                               &pvnc, &nvnc, &prnc, &nrnc );
                free( nvnc.bv_val );
                free( pvnc.bv_val );
                free( nrnc.bv_val );
@@ -207,17 +306,18 @@ ldap_back_db_config(
                return( rc );
 
 #else /* !ENABLE_REWRITE */
-               ber_bvarray_add( &li->suffix_massage, &pvnc );
-               ber_bvarray_add( &li->suffix_massage, &nvnc );
+               ber_bvarray_add( &li->rwmap.rwm_suffix_massage, &pvnc );
+               ber_bvarray_add( &li->rwmap.rwm_suffix_massage, &nvnc );
                
-               ber_bvarray_add( &li->suffix_massage, &prnc );
-               ber_bvarray_add( &li->suffix_massage, &nrnc );
+               ber_bvarray_add( &li->rwmap.rwm_suffix_massage, &prnc );
+               ber_bvarray_add( &li->rwmap.rwm_suffix_massage, &nrnc );
 #endif /* !ENABLE_REWRITE */
 
        /* rewrite stuff ... */
        } else if ( strncasecmp( argv[0], "rewrite", 7 ) == 0 ) {
 #ifdef ENABLE_REWRITE
-               return rewrite_parse( li->rwinfo, fname, lineno, argc, argv );
+               return rewrite_parse( li->rwmap.rwm_rw,
+                               fname, lineno, argc, argv );
 
 #else /* !ENABLE_REWRITE */
                fprintf( stderr, "%s: line %d: rewrite capabilities "
@@ -226,90 +326,258 @@ ldap_back_db_config(
                
        /* objectclass/attribute mapping */
        } else if ( strcasecmp( argv[0], "map" ) == 0 ) {
-               struct ldapmap *map;
-               struct ldapmapping *mapping;
-               char *src, *dst;
+               return ldap_back_map_config( &li->rwmap.rwm_oc,
+                               &li->rwmap.rwm_at,
+                               fname, lineno, argc, argv );
 
-               if ( argc < 3 || argc > 4 ) {
-                       fprintf( stderr,
+       /* anything else */
+       } else {
+               return SLAP_CONF_UNKNOWN;
+       }
+       return 0;
+}
+
+int
+ldap_back_map_config(
+               struct ldapmap  *oc_map,
+               struct ldapmap  *at_map,
+               const char      *fname,
+               int             lineno,
+               int             argc,
+               char            **argv )
+{
+       struct ldapmap          *map;
+       struct ldapmapping      *mapping;
+       char                    *src, *dst;
+       int                     is_oc = 0;
+
+       if ( argc < 3 || argc > 4 ) {
+               fprintf( stderr,
        "%s: line %d: syntax is \"map {objectclass | attribute} [<local> | *] {<foreign> | *}\"\n",
-                               fname, lineno );
-                       return( 1 );
-               }
+                       fname, lineno );
+               return 1;
+       }
 
-               if ( strcasecmp( argv[1], "objectclass" ) == 0 ) {
-                       map = &li->oc_map;
-               } else if ( strcasecmp( argv[1], "attribute" ) == 0 ) {
-                       map = &li->at_map;
-               } else {
-                       fprintf( stderr, "%s: line %d: syntax is "
-                               "\"map {objectclass | attribute} [<local> | *] "
-                               "{<foreign> | *}\"\n",
-                               fname, lineno );
-                       return( 1 );
+       if ( strcasecmp( argv[1], "objectclass" ) == 0 ) {
+               map = oc_map;
+               is_oc = 1;
+
+       } else if ( strcasecmp( argv[1], "attribute" ) == 0 ) {
+               map = at_map;
+
+       } else {
+               fprintf( stderr, "%s: line %d: syntax is "
+                       "\"map {objectclass | attribute} [<local> | *] "
+                       "{<foreign> | *}\"\n",
+                       fname, lineno );
+               return 1;
+       }
+
+       if ( strcmp( argv[2], "*" ) == 0 ) {
+               if ( argc < 4 || strcmp( argv[3], "*" ) == 0 ) {
+                       map->drop_missing = ( argc < 4 );
+                       return 0;
                }
+               src = dst = argv[3];
+
+       } else if ( argc < 4 ) {
+               src = "";
+               dst = argv[2];
+
+       } else {
+               src = argv[2];
+               dst = ( strcmp( argv[3], "*" ) == 0 ? src : argv[3] );
+       }
+
+       if ( ( map == at_map )
+                       && ( strcasecmp( src, "objectclass" ) == 0
+                       || strcasecmp( dst, "objectclass" ) == 0 ) )
+       {
+               fprintf( stderr,
+                       "%s: line %d: objectclass attribute cannot be mapped\n",
+                       fname, lineno );
+       }
 
-               if ( strcmp( argv[2], "*" ) == 0 ) {
-                       if ( argc < 4 || strcmp( argv[3], "*" ) == 0 ) {
-                               map->drop_missing = ( argc < 4 );
-                               return 0;
+       mapping = (struct ldapmapping *)ch_calloc( 2,
+               sizeof(struct ldapmapping) );
+       if ( mapping == NULL ) {
+               fprintf( stderr,
+                       "%s: line %d: out of memory\n",
+                       fname, lineno );
+               return 1;
+       }
+       ber_str2bv( src, 0, 1, &mapping->src );
+       ber_str2bv( dst, 0, 1, &mapping->dst );
+       mapping[1].src = mapping->dst;
+       mapping[1].dst = mapping->src;
+
+       /*
+        * schema check
+        */
+       if ( is_oc ) {
+               if ( src[0] != '\0' ) {
+                       if ( oc_bvfind( &mapping->src ) == NULL ) {
+                               fprintf( stderr,
+       "%s: line %d: warning, source objectClass '%s' "
+       "should be defined in schema\n",
+                                       fname, lineno, src );
+
+                               /*
+                                * FIXME: this should become an err
+                                */
+                               goto error_return;
                        }
-                       src = dst = argv[3];
-               } else if ( argc < 4 ) {
-                       src = "";
-                       dst = argv[2];
-               } else {
-                       src = argv[2];
-                       dst = ( strcmp( argv[3], "*" ) == 0 ? src : argv[3] );
                }
 
-               if ( ( map == &li->at_map )
-                       && ( strcasecmp( src, "objectclass" ) == 0
-                               || strcasecmp( dst, "objectclass" ) == 0 ) )
-               {
+               if ( oc_bvfind( &mapping->dst ) == NULL ) {
                        fprintf( stderr,
-                               "%s: line %d: objectclass attribute cannot be mapped\n",
-                               fname, lineno );
+       "%s: line %d: warning, destination objectClass '%s' "
+       "is not defined in schema\n",
+                               fname, lineno, dst );
                }
+       } else {
+               int                     rc;
+               const char              *text = NULL;
+               AttributeDescription    *ad = NULL;
+
+               if ( src[0] != '\0' ) {
+                       rc = slap_bv2ad( &mapping->src, &ad, &text );
+                       if ( rc != LDAP_SUCCESS ) {
+                               fprintf( stderr,
+       "%s: line %d: warning, source attributeType '%s' "
+       "should be defined in schema\n",
+                                       fname, lineno, src );
+
+                               /*
+                                * FIXME: this should become an err
+                                */
+                               goto error_return;
+                       }
 
-               mapping = (struct ldapmapping *)ch_calloc( 2,
-                       sizeof(struct ldapmapping) );
-               if ( mapping == NULL ) {
-                       fprintf( stderr,
-                               "%s: line %d: out of memory\n",
-                               fname, lineno );
-                       return( 1 );
+                       ad = NULL;
                }
-               ber_str2bv( src, 0, 1, &mapping->src );
-               ber_str2bv( dst, 0, 1, &mapping->dst );
-               mapping[1].src = mapping->dst;
-               mapping[1].dst = mapping->src;
-
-               if ( (*src != '\0' &&
-                         avl_find( map->map, (caddr_t)mapping, mapping_cmp ) != NULL) ||
-                       avl_find( map->remap, (caddr_t)&mapping[1], mapping_cmp ) != NULL)
-               {
+
+               rc = slap_bv2ad( &mapping->dst, &ad, &text );
+               if ( rc != LDAP_SUCCESS ) {
                        fprintf( stderr,
-                               "%s: line %d: duplicate mapping found (ignored)\n",
-                               fname, lineno );
-                       return 0;
+       "%s: line %d: warning, destination attributeType '%s' "
+       "is not defined in schema\n",
+                               fname, lineno, dst );
                }
+       }
 
-               if ( *src != '\0' )
-                       avl_insert( &map->map, (caddr_t)mapping,
-                                               mapping_cmp, mapping_dup );
-               avl_insert( &map->remap, (caddr_t)&mapping[1],
+       if ( (src[0] != '\0' && avl_find( map->map, (caddr_t)mapping, mapping_cmp ) != NULL)
+                       || avl_find( map->remap, (caddr_t)&mapping[1], mapping_cmp ) != NULL)
+       {
+               fprintf( stderr,
+                       "%s: line %d: duplicate mapping found (ignored)\n",
+                       fname, lineno );
+               goto error_return;
+       }
+
+       if ( src[0] != '\0' ) {
+               avl_insert( &map->map, (caddr_t)mapping,
                                        mapping_cmp, mapping_dup );
+       }
+       avl_insert( &map->remap, (caddr_t)&mapping[1],
+                               mapping_cmp, mapping_dup );
 
-       /* anything else */
+       return 0;
+
+error_return:;
+       if ( mapping ) {
+               ch_free( mapping->src.bv_val );
+               ch_free( mapping->dst.bv_val );
+               ch_free( mapping );
+       }
+
+       return 1;
+}
+
+static int
+ldap_back_exop_whoami(
+       Operation *op,
+       SlapReply *rs )
+{
+       struct berval *bv = NULL;
+
+       if ( op->oq_extended.rs_reqdata != NULL ) {
+               /* no request data should be provided */
+               rs->sr_text = "no request data expected";
+               return rs->sr_err = LDAP_PROTOCOL_ERROR;
+       }
+
+       rs->sr_err = backend_check_restrictions( op, rs, 
+                       (struct berval *)&slap_EXOP_WHOAMI );
+       if( rs->sr_err != LDAP_SUCCESS ) return rs->sr_err;
+
+       /* if auth'd by back-ldap and request is proxied, forward it */
+       if ( op->o_conn->c_authz_backend && !strcmp(op->o_conn->c_authz_backend->be_type, "ldap" ) && !dn_match(&op->o_ndn, &op->o_conn->c_ndn)) {
+               struct ldapconn *lc;
+
+               LDAPControl c, *ctrls[2] = {NULL, NULL};
+               LDAPMessage *res;
+               Operation op2 = *op;
+               ber_int_t msgid;
+               int do_retry = 1;
+
+               ctrls[0] = &c;
+               op2.o_ndn = op->o_conn->c_ndn;
+               lc = ldap_back_getconn(&op2, rs);
+               if (!lc || !ldap_back_dobind( lc, op, rs )) {
+                       return -1;
+               }
+               c.ldctl_oid = LDAP_CONTROL_PROXY_AUTHZ;
+               c.ldctl_iscritical = 1;
+               c.ldctl_value.bv_val = ch_malloc(op->o_ndn.bv_len+4);
+               c.ldctl_value.bv_len = op->o_ndn.bv_len + 3;
+               strcpy(c.ldctl_value.bv_val, "dn:");
+               strcpy(c.ldctl_value.bv_val+3, op->o_ndn.bv_val);
+
+retry:
+               rs->sr_err = ldap_whoami(lc->ld, ctrls, NULL, &msgid);
+               if (rs->sr_err == LDAP_SUCCESS) {
+                       if (ldap_result(lc->ld, msgid, 1, NULL, &res) == -1) {
+                               ldap_get_option(lc->ld, LDAP_OPT_ERROR_NUMBER,
+                                       &rs->sr_err);
+                               if ( rs->sr_err == LDAP_SERVER_DOWN && do_retry ) {
+                                       do_retry = 0;
+                                       if ( ldap_back_retry( lc, op, rs ))
+                                               goto retry;
+                               }
+                               ldap_back_freeconn( op, lc );
+                               lc = NULL;
+
+                       } else {
+                               rs->sr_err = ldap_parse_whoami(lc->ld, res, &bv);
+                               ldap_msgfree(res);
+                       }
+               }
+               ch_free(c.ldctl_value.bv_val);
+               if (rs->sr_err != LDAP_SUCCESS) {
+                       rs->sr_err = slap_map_api2result( rs );
+               }
        } else {
-               fprintf( stderr, "%s: line %d: unknown directive \"%s\" "
-                       "in ldap database definition (ignored)\n",
-                   fname, lineno, argv[0] );
+       /* else just do the same as before */
+               bv = (struct berval *) ch_malloc( sizeof(struct berval) );
+               if( op->o_dn.bv_len ) {
+                       bv->bv_len = op->o_dn.bv_len + sizeof("dn:") - 1;
+                       bv->bv_val = ch_malloc( bv->bv_len + 1 );
+                       AC_MEMCPY( bv->bv_val, "dn:", sizeof("dn:") - 1 );
+                       AC_MEMCPY( &bv->bv_val[sizeof("dn:") - 1], op->o_dn.bv_val,
+                               op->o_dn.bv_len );
+                       bv->bv_val[bv->bv_len] = '\0';
+               } else {
+                       bv->bv_len = 0;
+                       bv->bv_val = NULL;
+               }
        }
-       return 0;
+
+       rs->sr_rspdata = bv;
+       return rs->sr_err;
 }
 
+
 #ifdef ENABLE_REWRITE
 static char *
 suffix_massage_regexize( const char *s )
@@ -318,44 +586,62 @@ suffix_massage_regexize( const char *s )
        const char *p, *r;
        int i;
 
+       if ( s[ 0 ] == '\0' ) {
+               return ch_strdup( "^(.+)$" );
+       }
+
        for ( i = 0, p = s; 
                        ( r = strchr( p, ',' ) ) != NULL; 
                        p = r + 1, i++ )
                ;
 
-       res = ch_calloc( sizeof( char ), strlen( s ) + 4 + 4*i + 1 );
+       res = ch_calloc( sizeof( char ), strlen( s )
+               + STRLENOF( "((.+),)?" )
+               + STRLENOF( "[ ]?" ) * i
+               + STRLENOF( "$" ) + 1 );
 
-       ptr = slap_strcopy( res, "(.*)" );
+       ptr = lutil_strcopy( res, "((.+),)?" );
        for ( i = 0, p = s;
                        ( r = strchr( p, ',' ) ) != NULL;
                        p = r + 1 , i++ ) {
-               ptr = slap_strncopy( ptr, p, r - p + 1 );
-               ptr = slap_strcopy( ptr, "[ ]?" );
+               ptr = lutil_strncopy( ptr, p, r - p + 1 );
+               ptr = lutil_strcopy( ptr, "[ ]?" );
 
                if ( r[ 1 ] == ' ' ) {
                        r++;
                }
        }
-       slap_strcopy( ptr, p );
+       ptr = lutil_strcopy( ptr, p );
+       ptr[ 0 ] = '$';
+       ptr++;
+       ptr[ 0 ] = '\0';
 
        return res;
 }
 
 static char *
-suffix_massage_patternize( const char *s )
+suffix_massage_patternize( const char *s, const char *p )
 {
        ber_len_t       len;
-       char            *res;
+       char            *res, *ptr;
 
-       len = strlen( s );
+       len = strlen( p );
+
+       if ( s[ 0 ] == '\0' ) {
+               len++;
+       }
 
        res = ch_calloc( sizeof( char ), len + sizeof( "%1" ) );
        if ( res == NULL ) {
                return NULL;
        }
 
-       strcpy( res, "%1" );
-       strcpy( res + sizeof( "%1" ) - 1, s );
+       ptr = lutil_strcopy( res, ( p[ 0 ] == '\0' ? "%2" : "%1" ) );
+       if ( s[ 0 ] == '\0' ) {
+               ptr[ 0 ] = ',';
+               ptr++;
+       }
+       ptr = lutil_strcopy( ptr, p );
 
        return res;
 }
@@ -384,12 +670,21 @@ suffix_massage_config(
 
        rargv[ 0 ] = "rewriteRule";
        rargv[ 1 ] = suffix_massage_regexize( pvnc->bv_val );
-       rargv[ 2 ] = suffix_massage_patternize( prnc->bv_val );
+       rargv[ 2 ] = suffix_massage_patternize( pvnc->bv_val, prnc->bv_val );
        rargv[ 3 ] = ":";
        rargv[ 4 ] = NULL;
        rewrite_parse( info, "<suffix massage>", ++line, 4, rargv );
        ch_free( rargv[ 1 ] );
        ch_free( rargv[ 2 ] );
+
+       if ( BER_BVISEMPTY( pvnc ) ) {
+               rargv[ 0 ] = "rewriteRule";
+               rargv[ 1 ] = "^$";
+               rargv[ 2 ] = prnc->bv_val;
+               rargv[ 3 ] = ":";
+               rargv[ 4 ] = NULL;
+               rewrite_parse( info, "<suffix massage>", ++line, 4, rargv );
+       }
        
        rargv[ 0 ] = "rewriteContext";
        rargv[ 1 ] = "searchResult";
@@ -398,74 +693,35 @@ suffix_massage_config(
        
        rargv[ 0 ] = "rewriteRule";
        rargv[ 1 ] = suffix_massage_regexize( prnc->bv_val );
-       rargv[ 2 ] = suffix_massage_patternize( pvnc->bv_val );
+       rargv[ 2 ] = suffix_massage_patternize( prnc->bv_val, pvnc->bv_val );
        rargv[ 3 ] = ":";
        rargv[ 4 ] = NULL;
        rewrite_parse( info, "<suffix massage>", ++line, 4, rargv );
        ch_free( rargv[ 1 ] );
        ch_free( rargv[ 2 ] );
 
-       /*
-        * the filter should be rewritten as
-        * 
-        * rewriteRule
-        *      "(.*)member=([^)]+),o=Foo Bar,[ ]?c=US(.*)"
-        *      "%1member=%2,dc=example,dc=com%3"
-        *
-        * where "o=Foo Bar, c=US" is the virtual naming context,
-        * and "dc=example, dc=com" is the real naming context
-        */
-       rargv[ 0 ] = "rewriteContext";
-       rargv[ 1 ] = "searchFilter";
-       rargv[ 2 ] = NULL;
-       rewrite_parse( info, "<suffix massage>", ++line, 2, rargv );
-
-#if 1 /* rewrite filters */
-       {
-               /*
-                * Note: this is far more optimistic than desirable:
-                * for any AVA value ending with the virtual naming
-                * context the terminal part will be replaced by the
-                * real naming context; a better solution would be to
-                * walk the filter looking for DN-valued attributes,
-                * and only rewrite those that require rewriting
-                */
-               char vbuf[LDAP_FILT_MAXSIZ], rbuf[LDAP_FILT_MAXSIZ];
-
-               snprintf( vbuf, sizeof( vbuf ), "(.*)%s\\)(.*)", nvnc->bv_val );
-               snprintf( rbuf, sizeof( rbuf ), "%%1%s)%%2", nrnc->bv_val );
-               
+       if ( BER_BVISEMPTY( prnc ) ) {
                rargv[ 0 ] = "rewriteRule";
-               rargv[ 1 ] = vbuf;
-               rargv[ 2 ] = rbuf;
+               rargv[ 1 ] = "^$";
+               rargv[ 2 ] = pvnc->bv_val;
                rargv[ 3 ] = ":";
                rargv[ 4 ] = NULL;
                rewrite_parse( info, "<suffix massage>", ++line, 4, rargv );
        }
-#endif /* rewrite filters */
-
-#if 0 /*  "matched" is not normalized */
+       
        rargv[ 0 ] = "rewriteContext";
-       rargv[ 1 ] = "matchedDn";
+       rargv[ 1 ] = "matchedDN";
        rargv[ 2 ] = "alias";
        rargv[ 3 ] = "searchResult";
        rargv[ 4 ] = NULL;
        rewrite_parse( info, "<suffix massage>", ++line, 4, rargv );
-#else /* normalize "matched" */
-       rargv[ 0 ] = "rewriteContext";
-       rargv[ 1 ] = "matchedDn";
-       rargv[ 2 ] = NULL;
-       rewrite_parse( info, "<suffix massage>", ++line, 2, rargv );
 
-       rargv[ 0 ] = "rewriteRule";
-       rargv[ 1 ] = suffix_massage_regexize( prnc->bv_val );
-       rargv[ 2 ] = suffix_massage_patternize( nvnc->bv_val );
-       rargv[ 3 ] = ":";
+       rargv[ 0 ] = "rewriteContext";
+       rargv[ 1 ] = "searchAttrDN";
+       rargv[ 2 ] = "alias";
+       rargv[ 3 ] = "searchResult";
        rargv[ 4 ] = NULL;
        rewrite_parse( info, "<suffix massage>", ++line, 4, rargv );
-       ch_free( rargv[ 1 ] );
-       ch_free( rargv[ 2 ] );
-#endif /* normalize "matched" */
 
        return 0;
 }