]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-ldap/search.c
fix previous commit: don't loop on undefined; return success with no data in case...
[openldap] / servers / slapd / back-ldap / search.c
index bf78dec637e58b79092969fc217bbbfd33d17795..fd57590a139fd9e1e6011ee9ab12e4ae25bc9051 100644 (file)
@@ -41,6 +41,96 @@ ldap_build_entry( Operation *op, LDAPMessage *e, Entry *ent,
         struct berval *bdn, int flags );
 #define LDAP_BUILD_ENTRY_PRIVATE       0x01
 
+/*
+ * Quick'n'dirty rewrite of filter in case of error, to deal with
+ * <draft-zeilenga-ldap-t-f>.
+ */
+static int
+munge_filter(
+       Operation       *op,
+       struct berval   *filter )
+{
+       struct ldapinfo *li = (struct ldapinfo *) op->o_bd->be_private;
+
+       char            *ptr;
+       int             gotit = 0;
+
+       Debug( LDAP_DEBUG_ARGS, "=> ldap_back_munge_filter \"%s\"\n",
+                       filter->bv_val, 0, 0 );
+
+       for ( ptr = strstr( filter->bv_val, "(?=" ); 
+                       ptr;
+                       ptr = strstr( ptr, "(?=" ) )
+       {
+               static struct berval
+                       bv_true = BER_BVC( "(?=true)" ),
+                       bv_false = BER_BVC( "(?=false)" ),
+                       bv_t = BER_BVC( "(&)" ),
+                       bv_f = BER_BVC( "(|)" ),
+                       bv_T = BER_BVC( "(objectClass=*)" ),
+                       bv_F = BER_BVC( "(!(objectClass=*))" );
+               struct berval   *oldbv = NULL,
+                               *newbv = NULL,
+                               oldfilter = BER_BVNULL;
+
+               if ( strncmp( ptr, bv_true.bv_val, bv_true.bv_len ) == 0 ) {
+                       oldbv = &bv_true;
+                       if ( li->flags & LDAP_BACK_F_SUPPORT_T_F ) {
+                               newbv = &bv_t;
+
+                       } else {
+                               newbv = &bv_T;
+                       }
+
+               } else if ( strncmp( ptr, bv_false.bv_val, bv_false.bv_len ) == 0 )
+               {
+                       oldbv = &bv_false;
+                       if ( li->flags & LDAP_BACK_F_SUPPORT_T_F ) {
+                               newbv = &bv_f;
+
+                       } else {
+                               newbv = &bv_F;
+                       }
+
+               } else {
+                       gotit = 0;
+                       goto done;
+               }
+
+               oldfilter = *filter;
+               if ( !( li->flags & LDAP_BACK_F_SUPPORT_T_F ) ) {
+                       filter->bv_len += newbv->bv_len - oldbv->bv_len;
+                       if ( filter->bv_val == op->ors_filterstr.bv_val ) {
+                               filter->bv_val = op->o_tmpalloc( filter->bv_len + 1,
+                                               op->o_tmpmemctx );
+
+                               AC_MEMCPY( filter->bv_val, op->ors_filterstr.bv_val,
+                                               op->ors_filterstr.bv_len + 1 );
+
+                       } else {
+                               filter->bv_val = op->o_tmprealloc( filter->bv_val,
+                                               filter->bv_len + 1, op->o_tmpmemctx );
+                       }
+
+                       ptr = filter->bv_val + ( ptr - oldfilter.bv_val );
+               }
+
+               AC_MEMCPY( &ptr[ newbv->bv_len ],
+                               &ptr[ oldbv->bv_len ], 
+                               oldfilter.bv_len - ( ptr - filter->bv_val ) - oldbv->bv_len + 1 );
+               AC_MEMCPY( ptr, newbv->bv_val, newbv->bv_len );
+
+               ptr += newbv->bv_len;
+               gotit = 1;
+       }
+
+done:;
+       Debug( LDAP_DEBUG_ARGS, "<= ldap_back_munge_filter \"%s\" (%d)\n",
+                       filter->bv_val, gotit, 0 );
+
+       return gotit;
+}
+
 int
 ldap_back_search(
                Operation       *op,
@@ -52,25 +142,25 @@ ldap_back_search(
                        *e;
        int             rc = 0,
                        msgid; 
-       struct berval   match = BER_BVNULL;
+       struct berval   match = BER_BVNULL,
+                       filter = BER_BVNULL;
        int             i;
        char            **attrs = NULL;
        int             dontfreetext = 0;
-       int             freeconn = 0;
        int             do_retry = 1;
        LDAPControl     **ctrls = NULL;
 
-       lc = ldap_back_getconn( op, rs );
+       lc = ldap_back_getconn( op, rs, LDAP_BACK_SENDERR );
        if ( !lc ) {
-               return -1;
+               return rs->sr_err;
        }
 
        /*
         * FIXME: in case of values return filter, we might want
         * to map attrs and maybe rewrite value
         */
-       if ( !ldap_back_dobind( lc, op, rs ) ) {
-               return -1;
+       if ( !ldap_back_dobind( lc, op, rs, LDAP_BACK_SENDERR ) ) {
+               return rs->sr_err;
        }
 
        /* should we check return values? */
@@ -110,22 +200,46 @@ ldap_back_search(
                dontfreetext = 1;
                goto finish;
        }
-       
+
+       /* deal with <draft-zeilenga-ldap-t-f> filters */
+       filter = op->ors_filterstr;
 retry:
        rs->sr_err = ldap_search_ext( lc->lc_ld, op->o_req_ndn.bv_val,
-                       op->ors_scope, op->ors_filterstr.bv_val,
+                       op->ors_scope, filter.bv_val,
                        attrs, op->ors_attrsonly, ctrls, NULL,
                        tv.tv_sec ? &tv : NULL,
                        op->ors_slimit, &msgid );
 
        if ( rs->sr_err != LDAP_SUCCESS ) {
 fail:;
-               rc = ldap_back_op_result( lc, op, rs, msgid, 0 );
-               if ( freeconn ) {
+               switch ( rs->sr_err ) {
+               case LDAP_SERVER_DOWN:
+                       if ( do_retry ) {
+                               do_retry = 0;
+                               if ( ldap_back_retry( lc, op, rs, LDAP_BACK_DONTSEND ) ) {
+                                       goto retry;
+                               }
+                       }
+                       rc = ldap_back_op_result( lc, op, rs, msgid, LDAP_BACK_DONTSEND );
                        ldap_back_freeconn( op, lc );
                        lc = NULL;
+                       goto finish;
+
+               case LDAP_FILTER_ERROR:
+                       if ( munge_filter( op, &filter ) ) {
+                               goto retry;
+                       }
+
+                       /* invalid filters return success with no data */
+                       rs->sr_err = LDAP_SUCCESS;
+                       rs->sr_text = NULL;
+                       goto finish;
+               
+               default:
+                       rs->sr_err = slap_map_api2result( rs );
+                       rs->sr_text = NULL;
+                       goto finish;
                }
-               goto finish;
        }
 
        /* We pull apart the ber result, stuff it into a slapd entry, and
@@ -138,7 +252,7 @@ fail:;
                /* check for abandon */
                if ( op->o_abandon ) {
                        ldap_abandon_ext( lc->lc_ld, msgid, NULL, NULL );
-                       rc = 0;
+                       rc = SLAPD_ABANDON;
                        goto finish;
                }
 
@@ -165,18 +279,16 @@ fail:;
                                abort = send_search_entry( op, rs );
                                while ( ent.e_attrs ) {
                                        Attribute       *a;
-                                       BerVarray       v;
 
                                        a = ent.e_attrs;
                                        ent.e_attrs = a->a_next;
 
-                                       v = a->a_vals;
+                                       if ( a->a_nvals != a->a_vals ) {
+                                               ber_bvarray_free( a->a_nvals );
+                                       }
                                        if ( a->a_vals != &slap_dummy_bv ) {
                                                ber_bvarray_free( a->a_vals );
                                        }
-                                       if ( a->a_nvals != v ) {
-                                               ber_bvarray_free( a->a_nvals );
-                                       }
                                        ch_free( a );
                                }
                                
@@ -234,13 +346,34 @@ fail:;
                        }
 
                } else {
+                       char            **references = NULL;
+
                        rc = ldap_parse_result( lc->lc_ld, res, &rs->sr_err,
                                        &match.bv_val, (char **)&rs->sr_text,
-                                       NULL, &rs->sr_ctrls, 1 );
-                       if (rc != LDAP_SUCCESS ) {
+                                       &references, &rs->sr_ctrls, 1 );
+                       if ( rc != LDAP_SUCCESS ) {
                                rs->sr_err = rc;
                        }
                        rs->sr_err = slap_map_api2result( rs );
+
+                       if ( references ) {
+                               int     cnt;
+
+                               for ( cnt = 0; references[ cnt ]; cnt++ )
+                                       /* NO OP */ ;
+                               
+                               rs->sr_ref = ch_calloc( cnt + 1, sizeof( struct berval ) );
+
+                               for ( cnt = 0; references[ cnt ]; cnt++ ) {
+                                       ber_str2bv( references[ cnt ], 0, 1, &rs->sr_ref[ cnt ] );
+                               }
+
+                               /* cleanup */
+                               if ( references ) {
+                                       ldap_value_free( references );
+                               }
+                       }
+
                        rc = 0;
                        break;
                }
@@ -249,13 +382,11 @@ fail:;
        if ( rc == -1 ) {
                if ( do_retry ) {
                        do_retry = 0;
-                       if ( ldap_back_retry( lc, op, rs ) ) {
+                       if ( ldap_back_retry( lc, op, rs, LDAP_BACK_SENDERR ) ) {
                                goto retry;
                        }
                }
-               /* FIXME: invalidate the connection? */
                rs->sr_err = LDAP_SERVER_DOWN;
-               freeconn = 1;
                goto fail;
        }
 
@@ -270,7 +401,9 @@ fail:;
        }
 
 finish:;
-       send_ldap_result( op, rs );
+       if ( rc != SLAPD_ABANDON ) {
+               send_ldap_result( op, rs );
+       }
 
        (void)ldap_back_proxy_authz_ctrl_free( op, &ctrls );
 
@@ -283,12 +416,23 @@ finish:;
                rs->sr_matched = NULL;
                LDAP_FREE( match.bv_val );
        }
+
+       if ( !BER_BVISNULL( &filter ) && filter.bv_val != op->ors_filterstr.bv_val ) {
+               op->o_tmpfree( filter.bv_val, op->o_tmpmemctx );
+       }
+
        if ( rs->sr_text ) {
                if ( !dontfreetext ) {
                        LDAP_FREE( (char *)rs->sr_text );
                }
                rs->sr_text = NULL;
        }
+
+       if ( rs->sr_ref ) {
+               ber_bvarray_free( rs->sr_ref );
+               rs->sr_ref = NULL;
+       }
+
        if ( attrs ) {
                ch_free( attrs );
        }
@@ -500,7 +644,6 @@ ldap_back_entry_get(
                        *e = NULL;
        char            *gattr[3];
        char            *filter = NULL;
-       Connection      *oconn;
        SlapReply       rs;
        int             do_retry = 1;
        LDAPControl     **ctrls = NULL;
@@ -508,16 +651,12 @@ ldap_back_entry_get(
        /* Tell getconn this is a privileged op */
        do_not_cache = op->o_do_not_cache;
        op->o_do_not_cache = 1;
-       lc = ldap_back_getconn( op, &rs );
-       oconn = op->o_conn;
-       op->o_conn = NULL;
-       if ( !lc || !ldap_back_dobind( lc, op, &rs ) ) {
+       lc = ldap_back_getconn( op, &rs, LDAP_BACK_DONTSEND );
+       if ( !lc || !ldap_back_dobind( lc, op, &rs, LDAP_BACK_DONTSEND ) ) {
                op->o_do_not_cache = do_not_cache;
-               op->o_conn = oconn;
-               return 1;
+               return rs.sr_err;
        }
        op->o_do_not_cache = do_not_cache;
-       op->o_conn = oconn;
 
        if ( at ) {
                if ( oc && at != slap_schema.si_ad_objectClass ) {
@@ -550,12 +689,12 @@ ldap_back_entry_get(
        
 retry:
        rc = ldap_search_ext_s( lc->lc_ld, ndn->bv_val, LDAP_SCOPE_BASE, filter,
-                               at ? gattr : NULL, 0, ctrls, NULL, LDAP_NO_LIMIT,
-                               LDAP_NO_LIMIT, &result );
+                               at ? gattr : NULL, 0, ctrls, NULL,
+                               LDAP_NO_LIMIT, LDAP_NO_LIMIT, &result );
        if ( rc != LDAP_SUCCESS ) {
                if ( rc == LDAP_SERVER_DOWN && do_retry ) {
                        do_retry = 0;
-                       if ( ldap_back_retry( lc, op, &rs ) ) {
+                       if ( ldap_back_retry( lc, op, &rs, LDAP_BACK_DONTSEND ) ) {
                                goto retry;
                        }
                }