]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-ldbm/add.c
Remove abandon cruft
[openldap] / servers / slapd / back-ldbm / add.c
index 44c70c63cf766bd09103f3186786454195c7b41c..059abb031189cfb3ed8d1572005687e892c08922 100644 (file)
@@ -1,7 +1,7 @@
 /* add.c - ldap ldbm back-end add routine */
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-1999 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
@@ -28,37 +28,49 @@ ldbm_back_add(
        char            *pdn;
        Entry           *p = NULL;
        int                     rootlock = 0;
-       int                     rc; 
-
-#ifdef SLAPD_SCHEMA_NOT_COMPAT
-       static AttributeDescription *children = NULL;
+       int                     rc;
+       ID               id = NOID;
+       const char      *text = NULL;
+       AttributeDescription *children = slap_schema.si_ad_children;
+       char textbuf[SLAP_TEXT_BUFLEN];
+       size_t textlen = sizeof textbuf;
+
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "backend", LDAP_LEVEL_ENTRY,"ldbm_back_add: %s\n",
+               e->e_dn ));
 #else
-       static const char *children = "children";
-#endif
-
-
        Debug(LDAP_DEBUG_ARGS, "==> ldbm_back_add: %s\n", e->e_dn, 0, 0);
+#endif
 
        /* nobody else can add until we lock our parent */
        ldap_pvt_thread_mutex_lock(&li->li_add_mutex);
 
-       if ( ( dn2id( be, e->e_ndn ) ) != NOID ) {
+       if ( ( rc = dn2id( be, e->e_ndn, &id ) ) || id != NOID ) {
+               /* if (rc) something bad happened to ldbm cache */
                ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
-               entry_free( e );
-               send_ldap_result( conn, op, LDAP_ALREADY_EXISTS,
+               send_ldap_result( conn, op, 
+                       rc ? LDAP_OPERATIONS_ERROR : LDAP_ALREADY_EXISTS,
                        NULL, NULL, NULL, NULL );
                return( -1 );
        }
 
-       if ( schema_check_entry( e ) != 0 ) {
+       rc = entry_schema_check( e, NULL, &text, textbuf, textlen );
+
+       if ( rc != LDAP_SUCCESS ) {
                ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
 
-               Debug( LDAP_DEBUG_TRACE, "entry failed schema check\n",
-                       0, 0, 0 );
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                       "ldbm_back_add: entry (%s) failed schema check.\n",
+                       e->e_dn ));
+#else
+               Debug( LDAP_DEBUG_TRACE, "entry failed schema check: %s\n",
+                       text, 0, 0 );
+#endif
 
-               entry_free( e );
-               send_ldap_result( conn, op, LDAP_OBJECT_CLASS_VIOLATION,
-                       NULL, NULL, NULL, NULL );
+
+               send_ldap_result( conn, op, rc,
+                       NULL, text, NULL, NULL );
                return( -1 );
        }
 
@@ -77,7 +89,7 @@ ldbm_back_add(
 
                /* get parent with writer lock */
                if ( (p = dn2entry_w( be, pdn, &matched )) == NULL ) {
-                       char *matched_dn;
+                       char *matched_dn = NULL;
                        struct berval **refs;
 
                        ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
@@ -90,44 +102,51 @@ ldbm_back_add(
                                cache_return_entry_r( &li->li_cache, matched );
 
                        } else {
-                               matched_dn = NULL;
-                               refs = default_referral;
+                               refs = referral_rewrite( default_referral,
+                                       NULL, &e->e_name, LDAP_SCOPE_DEFAULT );
                        }
 
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                               "ldbm_back_add: Parent of (%s) does not exist.\n",
+                               e->e_dn ));
+#else
                        Debug( LDAP_DEBUG_TRACE, "parent does not exist\n",
                                0, 0, 0 );
+#endif
 
-                       send_ldap_result( conn, op, LDAP_REFERRAL,
-                           matched_dn, NULL, refs, NULL );
+                       send_ldap_result( conn, op, LDAP_REFERRAL, matched_dn,
+                               refs == NULL ? "parent does not exist" : "parent is referral",
+                               refs, NULL );
 
-                       if( matched != NULL ) {
-                               ber_bvecfree( refs );
-                               free( matched_dn );
-                       }
+                       ber_bvecfree( refs );
+                       free( matched_dn );
 
-                       entry_free( e );
-                       free( pdn );
                        return -1;
                }
 
                /* don't need the add lock anymore */
                ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
 
-               free(pdn);
-
                if ( ! access_allowed( be, conn, op, p,
                        children, NULL, ACL_WRITE ) )
                {
                        /* free parent and writer lock */
                        cache_return_entry_w( &li->li_cache, p ); 
 
-                       Debug( LDAP_DEBUG_TRACE, "no access to parent\n", 0,
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                                  "ldbm_back_add: No write access to parent (%s).\n",
+                                  e->e_dn ));
+#else
+                       Debug( LDAP_DEBUG_TRACE, "no write access to parent\n", 0,
                            0, 0 );
+#endif
+
                        send_ldap_result( conn, op, LDAP_INSUFFICIENT_ACCESS,
-                           NULL, NULL, NULL, NULL );
+                           NULL, "no write access to parent", NULL, NULL );
 
 
-                       entry_free( e );
                        return -1;
                }
 
@@ -137,13 +156,18 @@ ldbm_back_add(
                        /* free parent and writer lock */
                        cache_return_entry_w( &li->li_cache, p );
 
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                                  "ldbm_back_add:  Parent is an alias.\n"));
+#else
                        Debug( LDAP_DEBUG_TRACE, "parent is alias\n", 0,
                            0, 0 );
+#endif
+
 
                        send_ldap_result( conn, op, LDAP_ALIAS_PROBLEM,
-                           NULL, NULL, NULL, NULL );
+                           NULL, "parent is an alias", NULL, NULL );
 
-                       entry_free( e );
                        return -1;
                }
 
@@ -157,36 +181,78 @@ ldbm_back_add(
                        /* free parent and writer lock */
                        cache_return_entry_w( &li->li_cache, p );
 
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                                  "ldbm_back_add: Parent is referral.\n" ));
+#else
                        Debug( LDAP_DEBUG_TRACE, "parent is referral\n", 0,
                            0, 0 );
+#endif
+
                        send_ldap_result( conn, op, LDAP_REFERRAL,
                            matched_dn, NULL, refs, NULL );
 
                        ber_bvecfree( refs );
                        free( matched_dn );
-                       entry_free( e );
                        return -1;
                }
 
        } else {
                if(pdn != NULL) {
                        assert( *pdn == '\0' );
-                       free(pdn);
                }
 
                /* no parent, must be adding entry to root */
-               if ( !be_isroot( be, op->o_ndn ) && !be_issuffix( be, "" ) ) {
-                       ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
+               if ( !be_isroot( be, &op->o_ndn ) ) {
+                       if ( be_issuffix( be, "" ) || be_isupdate( be, &op->o_ndn ) ) {
+                               p = (Entry *)&slap_entry_root;
+                               
+                               rc = access_allowed( be, conn, op, p,
+                                       children, NULL, ACL_WRITE );
+                               p = NULL;
+                               
+                               if ( ! rc ) {
+                                       ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
+
+#ifdef NEW_LOGGING
+                                       LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                                               "ldbm_back_add: No write "
+                                               "access to parent (\"\").\n" ));
+#else
+                                       Debug( LDAP_DEBUG_TRACE, 
+                                               "no write access to parent\n", 
+                                               0, 0, 0 );
+#endif
 
-                       Debug( LDAP_DEBUG_TRACE, "%s add denied\n",
-                                       pdn == NULL ? "suffix" : "entry at root",
-                                       0, 0 );
+                                       send_ldap_result( conn, op, 
+                                               LDAP_INSUFFICIENT_ACCESS,
+                                               NULL, 
+                                               "no write access to parent", 
+                                               NULL, NULL );
 
-                       send_ldap_result( conn, op, LDAP_INSUFFICIENT_ACCESS,
-                           NULL, NULL, NULL, NULL );
+                                       return -1;
+                               }
 
-                       entry_free( e );
-                       return -1;
+                       } else {
+                               ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
+
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                                          "ldbm_back_add: %s add denied.\n",
+                                          pdn == NULL ? "suffix" 
+                                          : "entry at root" ));
+#else
+                               Debug( LDAP_DEBUG_TRACE, "%s add denied\n",
+                                               pdn == NULL ? "suffix" 
+                                               : "entry at root", 0, 0 );
+#endif
+
+                               send_ldap_result( conn, op, 
+                                               LDAP_INSUFFICIENT_ACCESS,
+                                               NULL, NULL, NULL, NULL );
+
+                               return -1;
+                       }
                }
 
                /*
@@ -198,7 +264,31 @@ ldbm_back_add(
                ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
        }
 
-       e->e_id = next_id( be );
+       if ( next_id( be, &e->e_id ) ) {
+               if( p != NULL) {
+                       /* free parent and writer lock */
+                       cache_return_entry_w( &li->li_cache, p ); 
+               }
+
+               if ( rootlock ) {
+                       /* release root lock */
+                       ldap_pvt_thread_mutex_unlock(&li->li_root_mutex);
+               }
+
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                          "ldbm_back_add: next_id failed.\n" ));
+#else
+               Debug( LDAP_DEBUG_ANY, "ldbm_add: next_id failed\n",
+                       0, 0, 0 );
+#endif
+
+
+               send_ldap_result( conn, op, LDAP_OTHER,
+                       NULL, "next_id add failed", NULL, NULL );
+
+               return( -1 );
+       }
 
        /*
         * Try to add the entry to the cache, assign it a new dnid.
@@ -216,60 +306,83 @@ ldbm_back_add(
                        ldap_pvt_thread_mutex_unlock(&li->li_root_mutex);
                }
 
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                          "ldbm_back_add: cache_add_entry_lock failed.\n" ));
+#else
                Debug( LDAP_DEBUG_ANY, "cache_add_entry_lock failed\n", 0, 0,
                    0 );
-
-               /* free the entry */
-               entry_free( e );
+#endif
 
                send_ldap_result( conn, op,
-                       rc > 0 ? LDAP_ALREADY_EXISTS : LDAP_OPERATIONS_ERROR,
-                       NULL, NULL, NULL, NULL );
+                       rc > 0 ? LDAP_ALREADY_EXISTS : LDAP_OTHER,
+                       NULL, rc > 0 ? NULL : "cache add failed", NULL, NULL );
 
                return( -1 );
        }
 
        rc = -1;
 
-       /*
-        * Add the entry to the attribute indexes, then add it to
-        * the id2children index, dn2id index, and the id2entry index.
-        */
-
        /* attribute indexes */
-       if ( index_add_entry( be, e ) != 0 ) {
-               Debug( LDAP_DEBUG_TRACE, "index_add_entry failed\n", 0,
+       if ( index_entry_add( be, e, e->e_attrs ) != LDAP_SUCCESS ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                          "ldbm_back_add: index_entry_add failed.\n" ));
+#else
+               Debug( LDAP_DEBUG_TRACE, "index_entry_add failed\n", 0,
                    0, 0 );
-               send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
-                       NULL, NULL, NULL, NULL );
+#endif
+               
+               send_ldap_result( conn, op, LDAP_OTHER,
+                       NULL, "index generation failed", NULL, NULL );
 
                goto return_results;
        }
 
        /* dn2id index */
        if ( dn2id_add( be, e->e_ndn, e->e_id ) != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                          "ldbm_back_add: dn2id_add failed.\n" ));
+#else
                Debug( LDAP_DEBUG_TRACE, "dn2id_add failed\n", 0,
                    0, 0 );
-               send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
-                       NULL, NULL, NULL, NULL );
+#endif
+               /* FIXME: delete attr indices? */
+
+               send_ldap_result( conn, op, LDAP_OTHER,
+                       NULL, "DN index generation failed", NULL, NULL );
 
                goto return_results;
        }
 
        /* id2entry index */
        if ( id2entry_add( be, e ) != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
+                          "ldbm_back_add: id2entry_add failed.\n" ));
+#else
                Debug( LDAP_DEBUG_TRACE, "id2entry_add failed\n", 0,
                    0, 0 );
+#endif
+
+               /* FIXME: delete attr indices? */
                (void) dn2id_delete( be, e->e_ndn, e->e_id );
-               send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
-                       NULL, NULL, NULL, NULL );
+               
+               send_ldap_result( conn, op, LDAP_OTHER,
+                       NULL, "entry store failed", NULL, NULL );
 
                goto return_results;
        }
 
        send_ldap_result( conn, op, LDAP_SUCCESS,
                NULL, NULL, NULL, NULL );
+
+       /* marks the entry as committed, so it is added to the cache;
+        * otherwise it is removed from the cache, but not destroyed;
+        * it will be destroyed by the caller */
        rc = 0;
+       cache_entry_commit( e );
 
 return_results:;
        if (p != NULL) {
@@ -283,7 +396,8 @@ return_results:;
        }
 
        if ( rc ) {
-               /* free entry and writer lock */
+               /* in case of error, writer lock is freed 
+                * and entry's private data is destroyed */
                cache_return_entry_w( &li->li_cache, e );
        }