]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-ldbm/add.c
add referral check to functions elaborated by overlays
[openldap] / servers / slapd / back-ldbm / add.c
index 8e6b560302ea10623b6efd2a1e589b7d4a5c078f..34ab716fd1f7f6fae71884d2bca336dadd5aee7c 100644 (file)
@@ -1,8 +1,17 @@
 /* add.c - ldap ldbm back-end add routine */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
@@ -34,28 +43,28 @@ ldbm_back_add(
 #endif
 
 #ifdef NEW_LOGGING
-       LDAP_LOG( BACK_LDBM, ENTRY, "ldbm_back_add: %s\n", op->o_req_dn.bv_val, 0, 0 );
+       LDAP_LOG( BACK_LDBM, ENTRY, "ldbm_back_add: %s\n",
+               op->o_req_dn.bv_val, 0, 0 );
 #else
-       Debug(LDAP_DEBUG_ARGS, "==> ldbm_back_add: %s\n", op->o_req_dn.bv_val, 0, 0);
+       Debug(LDAP_DEBUG_ARGS, "==> ldbm_back_add: %s\n",
+               op->o_req_dn.bv_val, 0, 0);
 #endif
        
-       rs->sr_err = entry_schema_check( op->o_bd, op->oq_add.rs_e, NULL, &rs->sr_text, textbuf, textlen );
+       rs->sr_err = entry_schema_check( op->o_bd, op->oq_add.rs_e, NULL,
+               &rs->sr_text, textbuf, textlen );
 
        if ( rs->sr_err != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG( BACK_LDBM, ERR, 
-                       "ldbm_back_add: entry (%s) failed schema check.\n", op->o_req_dn.bv_val, 0, 0 );
+               LDAP_LOG( BACK_LDBM, ERR,
+                       "ldbm_back_add: entry (%s) failed schema check.\n",
+                       op->o_req_dn.bv_val, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "entry failed schema check: %s\n",
                        rs->sr_text, 0, 0 );
 #endif
 
                send_ldap_result( op, rs );
-#ifdef LDAP_SYNCREPL
                return rs->sr_err;
-#else
-               return( -1 );
-#endif
        }
 
 #ifdef LDBM_SUBENTRIES
@@ -77,26 +86,19 @@ ldbm_back_add(
                send_ldap_error( op, rs, LDAP_INSUFFICIENT_ACCESS,
                    "no write access to entry" );
 
-#ifdef LDAP_SYNCREPL
                return LDAP_INSUFFICIENT_ACCESS;
-#else
-               return -1;
-#endif
        }
 
        /* grab giant lock for writing */
        ldap_pvt_thread_rdwr_wlock(&li->li_giant_rwlock);
 
-       if ( ( rs->sr_err = dn2id( op->o_bd, &op->o_req_ndn, &id ) ) || id != NOID ) {
+       rs->sr_err = dn2id( op->o_bd, &op->o_req_ndn, &id );
+       if ( rs->sr_err || id != NOID ) {
                /* if (rs->sr_err) something bad happened to ldbm cache */
                ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
                rs->sr_err = rs->sr_err ? LDAP_OTHER : LDAP_ALREADY_EXISTS;
                send_ldap_result( op, rs );
-#ifdef LDAP_SYNCREPL
                return rs->sr_err;
-#else
-               return( -1 );
-#endif
        }
 
        /*
@@ -111,8 +113,7 @@ ldbm_back_add(
                dnParent( &op->o_req_ndn, &pdn );
        }
 
-       if( pdn.bv_len )
-       {
+       if( pdn.bv_len ) {
                Entry *matched = NULL;
 
                /* get parent with writer lock */
@@ -140,23 +141,19 @@ ldbm_back_add(
                                0, 0, 0 );
 #endif
 
-                       rs->sr_text = rs->sr_ref ? "parent is referral" : "parent does not exist";
+                       rs->sr_text = rs->sr_ref
+                               ? "parent is referral" : "parent does not exist";
                        rs->sr_err = LDAP_REFERRAL;
                        send_ldap_result( op, rs );
 
                        ber_bvarray_free( rs->sr_ref );
                        free( (char *)rs->sr_matched );
-
-#ifdef LDAP_SYNCREPL
+                       rs->sr_ref = NULL;
+                       rs->sr_matched = NULL;
                        return rs->sr_err;
-#else
-                       return -1;
-#endif
                }
 
-               if ( ! access_allowed( op, p,
-                       children, NULL, ACL_WRITE, NULL ) )
-               {
+               if ( ! access_allowed( op, p, children, NULL, ACL_WRITE, NULL ) ) {
                        /* free parent and writer lock */
                        cache_return_entry_w( &li->li_cache, p ); 
                        ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
@@ -173,11 +170,7 @@ ldbm_back_add(
                        send_ldap_error( op, rs, LDAP_INSUFFICIENT_ACCESS,
                            "no write access to parent" );
 
-#ifdef LDAP_SYNCREPL
                        return LDAP_INSUFFICIENT_ACCESS;
-#else
-                       return -1;
-#endif
                }
 
 #ifdef LDBM_SUBENTRIES
@@ -210,15 +203,10 @@ ldbm_back_add(
                            0, 0 );
 #endif
 
-
                        send_ldap_error( op, rs, LDAP_ALIAS_PROBLEM,
                            "parent is an alias" );
 
-#ifdef LDAP_SYNCREPL
                        return LDAP_ALIAS_PROBLEM;
-#else
-                       return -1;
-#endif
                }
 
                if ( is_entry_referral( p ) ) {
@@ -234,7 +222,7 @@ ldbm_back_add(
 
 #ifdef NEW_LOGGING
                        LDAP_LOG( BACK_LDBM, ERR,
-                                  "ldbm_back_add: Parent is referral.\n", 0, 0, 0 );
+                          "ldbm_back_add: Parent is referral.\n", 0, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_TRACE, "parent is referral\n", 0,
                            0, 0 );
@@ -244,11 +232,9 @@ ldbm_back_add(
 
                        ber_bvarray_free( rs->sr_ref );
                        free( (char *)rs->sr_matched );
-#ifdef LDAP_SYNCREPL
+                       rs->sr_ref = NULL;
+                       rs->sr_matched = NULL;
                        return rs->sr_err;
-#else
-                       return -1;
-#endif
                }
 
 #ifdef LDBM_SUBENTRIES
@@ -259,88 +245,25 @@ ldbm_back_add(
 #endif
 
        } else {
-               if( pdn.bv_val != NULL )
-               {
-                       assert( *pdn.bv_val == '\0' );
-               }
+               assert( pdn.bv_val == NULL || *pdn.bv_val == '\0' );
 
-               /* no parent, must be adding entry to root */
-               if ( !be_isroot( op->o_bd, &op->o_ndn ) )
+               if ( !be_isroot( op->o_bd, &op->o_ndn )
+                       && !is_entry_glue( op->oq_add.rs_e ))
                {
-                       if ( be_issuffix( op->o_bd, (struct berval *)&slap_empty_bv ) || be_isupdate( op->o_bd, &op->o_ndn ) ) {
-                               p = (Entry *)&slap_entry_root;
-                               
-                               rs->sr_err = access_allowed( op, p,
-                                       children, NULL, ACL_WRITE, NULL );
-                               p = NULL;
-                               
-                               if ( ! rs->sr_err ) {
-                                       ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
-
-#ifdef NEW_LOGGING
-                                       LDAP_LOG( BACK_LDBM, ERR,
-                                               "ldbm_back_add: No write "
-                                               "access to parent (\"\").\n", 0, 0, 0 );
-#else
-                                       Debug( LDAP_DEBUG_TRACE, 
-                                               "no write access to parent\n", 
-                                               0, 0, 0 );
-#endif
-
-                                       send_ldap_error( op, rs,
-                                               LDAP_INSUFFICIENT_ACCESS,
-                                               "no write access to parent" );
-
-#ifdef LDAP_SYNCREPL
-                                       return LDAP_INSUFFICIENT_ACCESS;
-#else
-                                       return -1;
-#endif
-                               }
-#ifdef LDAP_SYNCREPL
-                       } else if ( !is_entry_glue( op->oq_add.rs_e )) {
-#else
-                       } else {
-#endif
-                               ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
+                       ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
 
 #ifdef NEW_LOGGING
-                               LDAP_LOG( BACK_LDBM, ERR,
-                                          "ldbm_back_add: %s add denied.\n",
-                                          pdn.bv_val == NULL ? "suffix" 
-                                          : "entry at root", 0, 0 );
+                       LDAP_LOG( BACK_LDBM, ERR,
+                          "ldbm_back_add: %s add denied.\n",
+                          pdn.bv_val == NULL ? "suffix" : "entry at root", 0, 0 );
 #else
-                               Debug( LDAP_DEBUG_TRACE, "%s add denied\n",
-                                               pdn.bv_val == NULL ? "suffix" 
-                                               : "entry at root", 0, 0 );
+                       Debug( LDAP_DEBUG_TRACE, "%s add denied\n",
+                               pdn.bv_val == NULL ? "suffix" : "entry at root", 0, 0 );
 #endif
 
-                               send_ldap_error( op, rs,
-                                               LDAP_NO_SUCH_OBJECT, NULL );
-
-#ifdef LDAP_SYNCREPL
-                                       return LDAP_NO_SUCH_OBJECT;
-#else
-                                       return -1;
-#endif
-                       }
+                       send_ldap_error( op, rs, LDAP_NO_SUCH_OBJECT, NULL );
+                       return LDAP_NO_SUCH_OBJECT;
                }
-
-#ifdef LDBM_SUBENTRIES
-                       if( subentry ) {
-#ifdef NEW_LOGGING
-                                       LDAP_LOG ( OPERATION, DETAIL1,
-                                               "bdb_add: no parent, cannot add subentry\n", 0, 0, 0 );
-#else
-                                       Debug( LDAP_DEBUG_TRACE,
-                                               "bdb_add: no parent, cannot add subentry\n", 0, 0, 0 );
-#endif
-                                       rs->sr_err = LDAP_NO_SUCH_OBJECT;
-                                       rs->sr_text = "no parent, cannot add subentry";
-                                       goto return_results;
-                               }
-#endif
-
        }
 
        if ( next_id( op->o_bd, &op->oq_add.rs_e->e_id ) ) {
@@ -362,17 +285,14 @@ ldbm_back_add(
                send_ldap_error( op, rs, LDAP_OTHER,
                        "next_id add failed" );
 
-#ifdef LDAP_SYNCREPL
                return LDAP_OTHER;
-#else
-               return( -1 );
-#endif
        }
 
        /*
         * Try to add the entry to the cache, assign it a new dnid.
         */
-       rs->sr_err = cache_add_entry_rw(&li->li_cache, op->oq_add.rs_e, CACHE_WRITE_LOCK);
+       rs->sr_err = cache_add_entry_rw( &li->li_cache, op->oq_add.rs_e,
+               CACHE_WRITE_LOCK );
 
        if ( rs->sr_err != 0 ) {
                if( p != NULL) {
@@ -394,11 +314,7 @@ ldbm_back_add(
                rs->sr_err = rs->sr_err > 0 ? LDAP_ALREADY_EXISTS : LDAP_OTHER;
                send_ldap_result( op, rs );
 
-#ifdef LDAP_SYNCREPL
                return rs->sr_err;
-#else
-               return( -1 );
-#endif
        }
 
        rs->sr_err = -1;
@@ -420,7 +336,9 @@ ldbm_back_add(
        }
 
        /* dn2id index */
-       if ( dn2id_add( op->o_bd, &op->oq_add.rs_e->e_nname, op->oq_add.rs_e->e_id ) != 0 ) {
+       if ( dn2id_add( op->o_bd, &op->oq_add.rs_e->e_nname,
+               op->oq_add.rs_e->e_id ) != 0 )
+       {
 #ifdef NEW_LOGGING
                LDAP_LOG( BACK_LDBM, ERR,
                        "ldbm_back_add: dn2id_add failed.\n", 0, 0, 0 );
@@ -447,7 +365,8 @@ ldbm_back_add(
 #endif
 
                /* FIXME: delete attr indices? */
-               (void) dn2id_delete( op->o_bd, &op->oq_add.rs_e->e_nname, op->oq_add.rs_e->e_id );
+               (void) dn2id_delete( op->o_bd, &op->oq_add.rs_e->e_nname,
+                       op->oq_add.rs_e->e_id );
                
                send_ldap_error( op, rs, LDAP_OTHER,
                        "entry store failed" );
@@ -456,6 +375,7 @@ ldbm_back_add(
        }
 
        rs->sr_err = LDAP_SUCCESS;
+       rs->sr_text = NULL;
        send_ldap_result( op, rs );
 
        /* marks the entry as committed, so it is added to the cache;