rework op/rs structures to deal with opeartional attributes

[openldap] / servers / slapd / back-ldbm / bind.c

diff --git a/servers/slapd/back-ldbm/bind.c b/servers/slapd/back-ldbm/bind.c
index 32ade6e953fdc61dc0fb398fcbf862df2d697d4b..02ca82df89a73a20bf1d2eeb4d90c9582b624354 100644 (file)
--- a/servers/slapd/back-ldbm/bind.c
+++ b/servers/slapd/back-ldbm/bind.c
@@ -49,7 +49,8 @@ ldbm_back_bind(
        LDAP_LOG( BACK_LDBM, ENTRY, 
                "ldbm_back_bind: dn: %s.\n", op->o_req_dn.bv_val, 0, 0 );
 #else
-       Debug(LDAP_DEBUG_ARGS, "==> ldbm_back_bind: dn: %s\n", op->o_req_dn.bv_val, 0, 0);
+       Debug(LDAP_DEBUG_ARGS,
+               "==> ldbm_back_bind: dn: %s\n", op->o_req_dn.bv_val, 0, 0);
 #endif
 
        if ( op->oq_bind.rb_method == LDAP_AUTH_SIMPLE && be_isroot_pw( op ) ) {
@@ -64,33 +65,14 @@ ldbm_back_bind(
        /* get entry with reader lock */
        if ( (e = dn2entry_r( op->o_bd, &op->o_req_ndn, &matched )) == NULL ) {
                if( matched != NULL ) {
-                       rs->sr_matched = ch_strdup( matched->e_dn );
-                       rs->sr_flags |= REP_MATCHED_MUSTBEFREED;
-
-                       rs->sr_ref = is_entry_referral( matched )
-                               ? get_entry_referrals( op, matched )
-                               : NULL;
-
                        cache_return_entry_r( &li->li_cache, matched );
-
-               } else {
-                       rs->sr_ref = referral_rewrite( default_referral,
-                               NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
                }
-
                ldap_pvt_thread_rdwr_runlock(&li->li_giant_rwlock);
 
                /* allow noauth binds */
                rc = 1;
-               if ( rs->sr_ref != NULL ) {
-                       rs->sr_err = LDAP_REFERRAL;
-               } else {
-                       rs->sr_err = LDAP_INVALID_CREDENTIALS;
-               }
+               rs->sr_err = LDAP_INVALID_CREDENTIALS;
                send_ldap_result( op, rs );
-
-               if ( rs->sr_ref ) ber_bvarray_free( rs->sr_ref );
-               rs->sr_ref = NULL;
                return rs->sr_err;
        }
 
@@ -114,37 +96,31 @@ ldbm_back_bind(
                /* entry is an alias, don't allow bind */
 #ifdef NEW_LOGGING
                LDAP_LOG( BACK_LDBM, INFO, 
-                       "ldbm_back_bind: entry (%s) is an alias.\n", e->e_name.bv_val, 0, 0 );
+                       "ldbm_back_bind: entry (%s) is an alias.\n",
+                       e->e_name.bv_val, 0, 0 );
 #else
-               Debug( LDAP_DEBUG_TRACE, "entry is alias\n", 0,
-                   0, 0 );
+               Debug( LDAP_DEBUG_TRACE, "entry is alias\n", 0, 0, 0 );
 #endif
+
+#if 1
+               rc = LDAP_INVALID_CREDENTIALS;
+#else
                rs->sr_text = "entry is alias";
                rc = LDAP_ALIAS_PROBLEM;
+#endif
                goto return_results;
        }
 
        if ( is_entry_referral( e ) ) {
                /* entry is a referral, don't allow bind */
-               rs->sr_ref = get_entry_referrals( op, e );
-
 #ifdef NEW_LOGGING
                LDAP_LOG( BACK_LDBM, INFO, 
-                          "ldbm_back_bind: entry(%s) is a referral.\n", e->e_dn, 0, 0 );
+                       "ldbm_back_bind: entry(%s) is a referral.\n", e->e_dn, 0, 0 );
 #else
-               Debug( LDAP_DEBUG_TRACE, "entry is referral\n", 0,
-                   0, 0 );
+               Debug( LDAP_DEBUG_TRACE, "entry is referral\n", 0, 0, 0 );
 #endif
 
-
-               if( rs->sr_ref != NULL ) {
-                       rc = LDAP_REFERRAL;
-                       rs->sr_matched = ch_strdup( e->e_name.bv_val );
-                       rs->sr_flags |= REP_MATCHED_MUSTBEFREED;
-
-               } else {
-                       rc = LDAP_INVALID_CREDENTIALS;
-               }
+               rc = LDAP_INVALID_CREDENTIALS;
                goto return_results;
        }
 
@@ -153,17 +129,27 @@ ldbm_back_bind(
                if ( ! access_allowed( op, e,
                        password, NULL, ACL_AUTH, NULL ) )
                {
+#if 1
+                       rc = LDAP_INVALID_CREDENTIALS;
+#else
                        rc = LDAP_INSUFFICIENT_ACCESS;
+#endif
                        goto return_results;
                }
 
                if ( (a = attr_find( e->e_attrs, password )) == NULL ) {
                        /* stop front end from sending result */
+#if 1
+                       rc = LDAP_INVALID_CREDENTIALS;
+#else
                        rc = LDAP_INAPPROPRIATE_AUTH;
+#endif
                        goto return_results;
                }
 
-               if ( slap_passwd_check( op->o_conn, a, &op->oq_bind.rb_cred, &rs->sr_text ) != 0 ) {
+               if ( slap_passwd_check( op->o_conn,
+                       a, &op->oq_bind.rb_cred, &rs->sr_text ) != 0 )
+               {
                        /* stop front end from sending result */
                        rc = LDAP_INVALID_CREDENTIALS;
                        goto return_results;
@@ -174,7 +160,9 @@ ldbm_back_bind(
 
 #ifdef LDAP_API_FEATURE_X_OPENLDAP_V2_KBIND
        case LDAP_AUTH_KRBV41:
-               if ( krbv4_ldap_auth( op->o_bd, &op->oq_bind.rb_cred, &ad ) != LDAP_SUCCESS ) {
+               if ( krbv4_ldap_auth( op->o_bd, &op->oq_bind.rb_cred, &ad )
+                       != LDAP_SUCCESS )
+               {
                        rc = LDAP_INVALID_CREDENTIALS;
                        goto return_results;
                }
@@ -213,15 +201,10 @@ ldbm_back_bind(
                }
                rc = 0;
                break;
-
-       case LDAP_AUTH_KRBV42:
-               rs->sr_text = "Kerberos bind step 2 not supported";
-               /* stop front end from sending result */
-               rc = LDAP_UNWILLING_TO_PERFORM;
-               goto return_results;
 #endif
 
        default:
+               assert( 0 ); /* should not be reachable */
                rs->sr_text = "authentication method not supported";
                rc = LDAP_STRONG_AUTH_NOT_SUPPORTED;
                goto return_results;