]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-ldbm/modify.c
silence warning
[openldap] / servers / slapd / back-ldbm / modify.c
index c7978238a2ee8575acb0b551345d6a6281121548..46ca1025a9471f132ae9b6db966aba937af53af5 100644 (file)
@@ -1,7 +1,7 @@
 /* modify.c - ldbm backend modify routine */
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
  * Juan C. Gomez (gomez@engr.sgi.com) 05/18/99
  */ 
 int ldbm_modify_internal(
-    Backend    *be,
-    Connection *conn,
     Operation  *op,
-    const char *dn,
     Modifications      *modlist,
     Entry      *e,
        const char **text,
@@ -41,14 +38,13 @@ int ldbm_modify_internal(
        Attribute       *ap;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "backend", LDAP_LEVEL_ENTRY,
-               "ldbm_modify_internal: %s\n", dn ));
+       LDAP_LOG( BACK_LDBM, ENTRY,  "ldbm_modify_internal: %s\n", e->e_name.bv_val, 0, 0 );
 #else
-       Debug(LDAP_DEBUG_TRACE, "ldbm_modify_internal: %s\n", dn, 0, 0);
+       Debug(LDAP_DEBUG_TRACE, "ldbm_modify_internal: %s\n", e->e_name.bv_val, 0, 0);
 #endif
 
 
-       if ( !acl_check_modlist( be, conn, op, e, modlist )) {
+       if ( !acl_check_modlist( op, e, modlist )) {
                return LDAP_INSUFFICIENT_ACCESS;
        }
 
@@ -61,18 +57,17 @@ int ldbm_modify_internal(
                switch ( mod->sm_op ) {
                case LDAP_MOD_ADD:
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                               "ldbm_modify_internal: add\n" ));
+                       LDAP_LOG( BACK_LDBM, DETAIL1, "ldbm_modify_internal: add\n", 0, 0, 0);
 #else
                        Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: add\n", 0, 0, 0);
 #endif
 
-                       rc = modify_add_values( e, mod, text, textbuf, textlen );
+                       rc = modify_add_values( e, mod, get_permissiveModify( op ),
+                                               text, textbuf, textlen );
                        if( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_INFO,
-                                       "ldbm_modify_internal: failed %d (%s)\n",
-                                       rc, *text ));
+                               LDAP_LOG( BACK_LDBM, INFO, 
+                                       "ldbm_modify_internal: failed %d (%s)\n", rc, *text, 0 );
 #else
                                Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: %d %s\n",
                                        rc, *text, 0);
@@ -82,18 +77,18 @@ int ldbm_modify_internal(
 
                case LDAP_MOD_DELETE:
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                               "ldbm_modify_internal: delete\n" ));
+                       LDAP_LOG( BACK_LDBM, DETAIL1, "ldbm_modify_internal: delete\n", 0,0,0);
 #else
                        Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: delete\n", 0, 0, 0);
 #endif
 
-                       rc = modify_delete_values( e, mod, text, textbuf, textlen );
+                       rc = modify_delete_values( e, mod, get_permissiveModify( op ),
+                                                       text, textbuf, textlen );
                        assert( rc != LDAP_TYPE_OR_VALUE_EXISTS );
                        if( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_INFO,
-                                       "ldbm_modify_internal: failed %d (%s)\n", rc, *text ));
+                               LDAP_LOG( BACK_LDBM, INFO, 
+                                       "ldbm_modify_internal: failed %d (%s)\n", rc, *text, 0 );
 #else
                                Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: %d %s\n",
                                        rc, *text, 0);
@@ -103,18 +98,17 @@ int ldbm_modify_internal(
 
                case LDAP_MOD_REPLACE:
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                               "ldbm_modify_internal:  replace\n" ));
+                       LDAP_LOG( BACK_LDBM, DETAIL1, "ldbm_modify_internal:  replace\n",0,0,0);
 #else
                        Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: replace\n", 0, 0, 0);
 #endif
 
-                       rc = modify_replace_values( e, mod, text, textbuf, textlen );
-                       assert( rc != LDAP_TYPE_OR_VALUE_EXISTS );
+                       rc = modify_replace_values( e, mod, get_permissiveModify( op ),
+                                                       text, textbuf, textlen );
                        if( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_INFO,
-                                       "ldbm_modify_internal: failed %d (%s)\n", rc, *text ));
+                               LDAP_LOG( BACK_LDBM, INFO, 
+                                       "ldbm_modify_internal: failed %d (%s)\n", rc, *text, 0 );
 #else
                                Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: %d %s\n",
                                        rc, *text, 0);
@@ -124,8 +118,8 @@ int ldbm_modify_internal(
 
                case SLAP_MOD_SOFTADD:
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                               "ldbm_modify_internal: softadd\n" ));
+                       LDAP_LOG( BACK_LDBM, DETAIL1, 
+                               "ldbm_modify_internal: softadd\n", 0, 0, 0 );
 #else
                        Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: softadd\n", 0, 0, 0);
 #endif
@@ -135,15 +129,16 @@ int ldbm_modify_internal(
                         */
                        mod->sm_op = LDAP_MOD_ADD;
 
-                       rc = modify_add_values( e, mod, text, textbuf, textlen );
+                       rc = modify_add_values( e, mod, get_permissiveModify( op ),
+                                               text, textbuf, textlen );
                        if ( rc == LDAP_TYPE_OR_VALUE_EXISTS ) {
                                rc = LDAP_SUCCESS;
                        }
 
                        if( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_INFO,
-                                          "ldbm_modify_internal: failed %d (%s)\n", rc, *text ));
+                               LDAP_LOG( BACK_LDBM, INFO, 
+                                          "ldbm_modify_internal: failed %d (%s)\n", rc, *text, 0 );
 #else
                                Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: %d %s\n",
                                        rc, *text, 0);
@@ -153,8 +148,8 @@ int ldbm_modify_internal(
 
                default:
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
-                               "ldbm_modify_internal: invalid op %d\n", mod->sm_op ));
+                       LDAP_LOG( BACK_LDBM, ERR, 
+                               "ldbm_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
 #else
                        Debug(LDAP_DEBUG_ANY, "ldbm_modify_internal: invalid op %d\n",
                                mod->sm_op, 0, 0);
@@ -163,8 +158,8 @@ int ldbm_modify_internal(
                        rc = LDAP_OTHER;
                        *text = "Invalid modify operation";
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_INFO,
-                               "ldbm_modify_internal: %d (%s)\n", rc, *text ));
+                       LDAP_LOG( BACK_LDBM, INFO, 
+                               "ldbm_modify_internal: %d (%s)\n", rc, *text, 0 );
 #else
                        Debug(LDAP_DEBUG_ARGS, "ldbm_modify_internal: %d %s\n",
                                rc, *text, 0);
@@ -181,7 +176,7 @@ int ldbm_modify_internal(
                }
 
                /* check if modified attribute was indexed */
-               rc = index_is_indexed( be, mod->sm_desc );
+               rc = index_is_indexed( op->o_bd, mod->sm_desc );
                if ( rc == LDAP_SUCCESS ) {
                        ap = attr_find( save_attrs, mod->sm_desc );
                        if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
@@ -192,12 +187,22 @@ int ldbm_modify_internal(
        }
 
        /* check that the entry still obeys the schema */
-       rc = entry_schema_check( be, e, save_attrs, text, textbuf, textlen );
+#ifndef LDAP_CACHING
+       rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
+#else /* LDAP_CACHING */
+       if ( !op->o_caching_on ) {
+               rc = entry_schema_check( op->o_bd, e, save_attrs,
+                               text, textbuf, textlen );
+       } else {
+               rc = LDAP_SUCCESS; 
+       }
+#endif /* LDAP_CACHING */
+
        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
-                       "ldbm_modify_internal: entry failed schema check: %s\n",
-                       *text ));
+               LDAP_LOG( BACK_LDBM, ERR, 
+                       "ldbm_modify_internal: entry failed schema check: %s\n", 
+                       *text, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "entry failed schema check: %s\n",
                        *text, 0, 0 );
@@ -207,10 +212,7 @@ int ldbm_modify_internal(
        }
 
        /* check for abandon */
-       ldap_pvt_thread_mutex_lock( &op->o_abandonmutex );
-       rc = op->o_abandon;
-       ldap_pvt_thread_mutex_unlock( &op->o_abandonmutex );
-       if ( rc ) {
+       if ( op->o_abandon ) {
                rc = SLAPD_ABANDON;
                goto exit;
        }
@@ -220,12 +222,14 @@ int ldbm_modify_internal(
        /* start with deleting the old index entries */
        for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
                if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
-                       rc = index_values( be, ap->a_desc, ap->a_vals, e->e_id,
-                                          SLAP_INDEX_DELETE_OP );
+                       rc = index_values( op->o_bd, ap->a_desc,
+                               ap->a_nvals,
+                               e->e_id, SLAP_INDEX_DELETE_OP );
                        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
-                                          "ldbm_modify_internal: Attribute index delete failure\n" ));
+                               LDAP_LOG( BACK_LDBM, ERR,
+                                       "ldbm_modify_internal: Attribute index delete failure\n",
+                                       0, 0, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                       "Attribute index delete failure",
@@ -240,12 +244,14 @@ int ldbm_modify_internal(
        /* add the new index entries */
        for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
                if ( ap->a_flags & SLAP_ATTR_IXADD ) {
-                       rc = index_values( be, ap->a_desc, ap->a_vals, e->e_id,
-                                          SLAP_INDEX_ADD_OP );
+                       rc = index_values( op->o_bd, ap->a_desc,
+                               ap->a_nvals,
+                               e->e_id, SLAP_INDEX_ADD_OP );
                        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
-                                          "ldbm_modify_internal: Attribute index add failure\n" ));
+                               LDAP_LOG( BACK_LDBM, ERR,
+                                       "ldbm_modify_internal: Attribute index add failure\n",
+                                       0, 0, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                       "Attribute index add failure",
@@ -273,106 +279,103 @@ exit:
 
 int
 ldbm_back_modify(
-    Backend    *be,
-    Connection *conn,
     Operation  *op,
-    struct berval      *dn,
-    struct berval      *ndn,
-    Modifications      *modlist
-)
+    SlapReply  *rs )
 {
-       int rc;
-       struct ldbminfo *li = (struct ldbminfo *) be->be_private;
+       struct ldbminfo *li = (struct ldbminfo *) op->o_bd->be_private;
        Entry           *matched;
        Entry           *e;
        int             manageDSAit = get_manageDSAit( op );
-       const char *text = NULL;
        char textbuf[SLAP_TEXT_BUFLEN];
        size_t textlen = sizeof textbuf;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "backend", LDAP_LEVEL_ENTRY,
-               "ldbm_back_modify: enter\n" ));
+       LDAP_LOG( BACK_LDBM, ENTRY, "ldbm_back_modify: enter\n", 0, 0, 0);
 #else
        Debug(LDAP_DEBUG_ARGS, "ldbm_back_modify:\n", 0, 0, 0);
 #endif
 
+       /* grab giant lock for writing */
+       ldap_pvt_thread_rdwr_wlock(&li->li_giant_rwlock);
 
        /* acquire and lock entry */
-       if ( (e = dn2entry_w( be, ndn, &matched )) == NULL ) {
-               char* matched_dn = NULL;
-               BerVarray refs;
-
+       if ( (e = dn2entry_w( op->o_bd, &op->o_req_ndn, &matched )) == NULL ) {
                if ( matched != NULL ) {
-                       matched_dn = ch_strdup( matched->e_dn );
-                       refs = is_entry_referral( matched )
-                               ? get_entry_referrals( be, conn, op, matched )
+                       rs->sr_matched = ch_strdup( matched->e_dn );
+                       rs->sr_ref = is_entry_referral( matched )
+                               ? get_entry_referrals( op, matched )
                                : NULL;
                        cache_return_entry_r( &li->li_cache, matched );
                } else {
-                       refs = referral_rewrite( default_referral,
-                               NULL, dn, LDAP_SCOPE_DEFAULT );
+                       rs->sr_ref = referral_rewrite( default_referral,
+                               NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
                }
 
-               send_ldap_result( conn, op, LDAP_REFERRAL,
-                       matched_dn, NULL, refs, NULL );
+               ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
+               rs->sr_err = LDAP_REFERRAL;
+               send_ldap_result( op, rs );
 
-               if ( refs ) ber_bvarray_free( refs );
-               free( matched_dn );
+               if ( rs->sr_ref ) ber_bvarray_free( rs->sr_ref );
+               free( (char *)rs->sr_matched );
 
                return( -1 );
        }
 
-    if ( !manageDSAit && is_entry_referral( e ) ) {
+#ifndef LDAP_CACHING
+       if ( !manageDSAit && is_entry_referral( e ) )
+#else /* LDAP_CACHING */
+       if ( !op->o_caching_on && !manageDSAit && is_entry_referral( e ) )
+#endif /* LDAP_CACHING */
+       {
                /* parent is a referral, don't allow add */
                /* parent is an alias, don't allow add */
-               BerVarray refs = get_entry_referrals( be,
-                       conn, op, e );
+               rs->sr_ref = get_entry_referrals( op, e );
 
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "backend", LDAP_LEVEL_INFO,
-                          "ldbm_back_modify: entry (%s) is referral\n", ndn->bv_val ));
+               LDAP_LOG( BACK_LDBM, INFO, 
+                          "ldbm_back_modify: entry (%s) is referral\n", op->o_req_ndn.bv_val, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "entry is referral\n", 0,
                    0, 0 );
 #endif
 
+               rs->sr_err = LDAP_REFERRAL;
+               rs->sr_matched = e->e_name.bv_val;
+               send_ldap_result( op, rs );
 
-               send_ldap_result( conn, op, LDAP_REFERRAL,
-                   e->e_dn, NULL, refs, NULL );
-
-               if ( refs ) ber_bvarray_free( refs );
+               if ( rs->sr_ref ) ber_bvarray_free( rs->sr_ref );
 
                goto error_return;
        }
        
        /* Modify the entry */
-       rc = ldbm_modify_internal( be, conn, op, ndn->bv_val, modlist, e,
-               &text, textbuf, textlen );
+       rs->sr_err = ldbm_modify_internal( op, op->oq_modify.rs_modlist, e,
+               &rs->sr_text, textbuf, textlen );
 
-       if( rc != LDAP_SUCCESS ) {
-               if( rc != SLAPD_ABANDON ) {
-                       send_ldap_result( conn, op, rc,
-                               NULL, text, NULL, NULL );
+       if( rs->sr_err != LDAP_SUCCESS ) {
+               if( rs->sr_err != SLAPD_ABANDON ) {
+                       send_ldap_result( op, rs );
                }
 
                goto error_return;
        }
 
        /* change the entry itself */
-       if ( id2entry_add( be, e ) != 0 ) {
-               send_ldap_result( conn, op, LDAP_OTHER,
-                       NULL, "id2entry failure", NULL, NULL );
+       if ( id2entry_add( op->o_bd, e ) != 0 ) {
+               send_ldap_error( op, rs, LDAP_OTHER,
+                       "id2entry failure" );
                goto error_return;
        }
 
-       send_ldap_result( conn, op, LDAP_SUCCESS,
-               NULL, NULL, NULL, NULL );
+       send_ldap_error( op, rs, LDAP_SUCCESS,
+               NULL );
 
        cache_return_entry_w( &li->li_cache, e );
+       ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
        return( 0 );
 
 error_return:;
        cache_return_entry_w( &li->li_cache, e );
+       ldap_pvt_thread_rdwr_wunlock(&li->li_giant_rwlock);
        return( -1 );
 }