]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-mdb/search.c
Merge remote-tracking branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
[openldap] / servers / slapd / back-mdb / search.c
index a457dd57ce2ebd006e3c96d9dee1d1ab4b01c903..5cc0d28c00b5f3d0ff91f081a06f6a461a6bf97e 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2000-2011 The OpenLDAP Foundation.
+ * Copyright 2000-2013 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -32,8 +32,9 @@ static int search_candidates(
        SlapReply *rs,
        Entry *e,
        MDB_txn *txn,
+       MDB_cursor *mci,
        ID      *ids,
-       ID      *scopes );
+       ID2L    scopes );
 
 static int parse_paged_cookie( Operation *op, SlapReply *rs );
 
@@ -97,7 +98,7 @@ static Entry * deref_base (
                        break;
                }
 
-               rs->sr_err = mdb_dn2entry( op, txn, &ndn, &e, 0 );
+               rs->sr_err = mdb_dn2entry( op, txn, NULL, &ndn, &e, NULL, 0 );
                if (rs->sr_err) {
                        rs->sr_err = LDAP_ALIAS_PROBLEM;
                        rs->sr_text = "aliasedObject not found";
@@ -128,9 +129,10 @@ static Entry * deref_base (
 static int search_aliases(
        Operation *op,
        SlapReply *rs,
-       Entry *e,
+       ID e_id,
        MDB_txn *txn,
-       ID *scopes,
+       MDB_cursor *mci,
+       ID2L scopes,
        ID *stack )
 {
        ID *aliases, *curscop, *visited, *newsubs, *oldsubs, *tmp;
@@ -158,11 +160,11 @@ static int search_aliases(
        MDB_IDL_ZERO( aliases );
        rs->sr_err = mdb_filter_candidates( op, txn, &af, aliases,
                curscop, visited );
-       if (rs->sr_err != LDAP_SUCCESS) {
+       if (rs->sr_err != LDAP_SUCCESS || MDB_IDL_IS_ZERO( aliases )) {
                return rs->sr_err;
        }
        oldsubs[0] = 1;
-       oldsubs[1] = e->e_id;
+       oldsubs[1] = e_id;
 
        MDB_IDL_ZERO( visited );
        MDB_IDL_ZERO( newsubs );
@@ -174,20 +176,14 @@ static int search_aliases(
                /* Set curscop to only the aliases in the current scope. Start with
                 * all the aliases, then get the intersection with the scope.
                 */
-               rs->sr_err = mdb_idscope( op, txn, e->e_id, aliases, curscop );
-
-               if (first) {
-                       first = 0;
-               } else {
-                       mdb_entry_return( op, e );
-               }
+               rs->sr_err = mdb_idscope( op, txn, e_id, aliases, curscop );
 
                /* Dereference all of the aliases in the current scope. */
                cursora = 0;
                for (ida = mdb_idl_first(curscop, &cursora); ida != NOID;
                        ida = mdb_idl_next(curscop, &cursora))
                {
-                       rs->sr_err = mdb_id2entry(op, txn, ida, &a);
+                       rs->sr_err = mdb_id2entry(op, mci, ida, &a);
                        if (rs->sr_err != LDAP_SUCCESS) {
                                continue;
                        }
@@ -208,7 +204,10 @@ static int search_aliases(
                                /* If the target was not already in our current scopes,
                                 * make note of it in the newsubs list.
                                 */
-                               if (mdb_idl_insert(scopes, a->e_id) == 0) {
+                               ID2 mid;
+                               mid.mid = a->e_id;
+                               mid.mval.mv_data = NULL;
+                               if (mdb_id2l_insert(scopes, &mid) == 0) {
                                        mdb_idl_insert(newsubs, a->e_id);
                                }
                                mdb_entry_return( op, a );
@@ -219,6 +218,7 @@ static int search_aliases(
                                 */
                                mdb_entry_return( op, matched );
                                rs->sr_text = NULL;
+                               rs->sr_err = 0;
                        }
                }
                /* If this is a OneLevel search, we're done; oldsubs only had one
@@ -243,9 +243,13 @@ nextido:
                 * be found, ignore it and move on. This should never happen;
                 * we should never see the ID of an entry that doesn't exist.
                 */
-               rs->sr_err = mdb_id2entry(op, txn, ido, &e);
-               if ( rs->sr_err != LDAP_SUCCESS ) {
-                       goto nextido;
+               {
+                       MDB_val edata;
+                       rs->sr_err = mdb_id2edata(op, mci, ido, &edata);
+                       if ( rs->sr_err != MDB_SUCCESS ) {
+                               goto nextido;
+                       }
+                       e_id = ido;
                }
        }
        return rs->sr_err;
@@ -255,35 +259,69 @@ nextido:
  * a range and simple iteration hits missing entryIDs
  */
 static int
-mdb_get_nextid(struct mdb_info *mdb, MDB_txn *txn, ID *cursor)
+mdb_get_nextid(MDB_cursor *mci, ID *cursor)
 {
-       MDB_cursor *curs;
        MDB_val key;
        ID id;
        int rc;
 
        id = *cursor + 1;
-       rc = mdb_cursor_open( txn, mdb->mi_id2entry, &curs );
-       if ( rc )
-               return rc;
        key.mv_data = &id;
        key.mv_size = sizeof(ID);
-       rc = mdb_cursor_get( curs, &key, NULL, MDB_SET_RANGE );
-       mdb_cursor_close( curs );
+       rc = mdb_cursor_get( mci, &key, NULL, MDB_SET_RANGE );
        if ( rc )
                return rc;
        memcpy( cursor, key.mv_data, sizeof(ID));
        return 0;
 }
 
+static void scope_chunk_free( void *key, void *data )
+{
+       ID2 *p1, *p2;
+       for (p1 = data; p1; p1 = p2) {
+               p2 = p1[0].mval.mv_data;
+               ber_memfree_x(p1, NULL);
+       }
+}
+
+static ID2 *scope_chunk_get( Operation *op )
+{
+       struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
+       ID2 *ret = NULL;
+
+       ldap_pvt_thread_pool_getkey( op->o_threadctx, (void *)scope_chunk_get,
+                       (void *)&ret, NULL );
+       if ( !ret ) {
+               ret = ch_malloc( MDB_IDL_UM_SIZE * sizeof( ID2 ));
+       } else {
+               void *r2 = ret[0].mval.mv_data;
+               ldap_pvt_thread_pool_setkey( op->o_threadctx, (void *)scope_chunk_get,
+                       r2, scope_chunk_free, NULL, NULL );
+       }
+       return ret;
+}
+
+static void scope_chunk_ret( Operation *op, ID2 *scopes )
+{
+       struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
+       void *ret = NULL;
+
+       ldap_pvt_thread_pool_getkey( op->o_threadctx, (void *)scope_chunk_get,
+                       &ret, NULL );
+       scopes[0].mval.mv_data = ret;
+       ldap_pvt_thread_pool_setkey( op->o_threadctx, (void *)scope_chunk_get,
+                       (void *)scopes, scope_chunk_free, NULL, NULL );
+}
+
 int
 mdb_search( Operation *op, SlapReply *rs )
 {
        struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
-       ID              id, cursor;
+       ID              id, cursor, nsubs, ncand, cscope;
        ID              lastid = NOID;
        ID              candidates[MDB_IDL_UM_SIZE];
-       ID              scopes[MDB_IDL_DB_SIZE];
+       ID              iscopes[MDB_IDL_DB_SIZE];
+       ID2             *scopes;
        Entry           *e = NULL, *base = NULL;
        Entry           *matched = NULL;
        AttributeName   *attrs;
@@ -292,8 +330,9 @@ mdb_search( Operation *op, SlapReply *rs )
        int             manageDSAit;
        int             tentries = 0;
        IdScopes        isc;
+       MDB_cursor      *mci, *mcd;
 
-       mdb_op_info     opinfo = {0}, *moi = &opinfo;
+       mdb_op_info     opinfo = {{{0}}}, *moi = &opinfo;
        MDB_txn                 *ltid = NULL;
 
        Debug( LDAP_DEBUG_TRACE, "=> " LDAP_XSTRING(mdb_search) "\n", 0, 0, 0);
@@ -311,16 +350,32 @@ mdb_search( Operation *op, SlapReply *rs )
        }
 
        ltid = moi->moi_txn;
+
+       rs->sr_err = mdb_cursor_open( ltid, mdb->mi_id2entry, &mci );
+       if ( rs->sr_err ) {
+               send_ldap_error( op, rs, LDAP_OTHER, "internal error" );
+               return rs->sr_err;
+       }
+
+       rs->sr_err = mdb_cursor_open( ltid, mdb->mi_dn2id, &mcd );
+       if ( rs->sr_err ) {
+               mdb_cursor_close( mci );
+               send_ldap_error( op, rs, LDAP_OTHER, "internal error" );
+               return rs->sr_err;
+       }
+
+       scopes = scope_chunk_get( op );
        isc.mt = ltid;
-       isc.mc = NULL;
+       isc.mc = mcd;
        isc.scopes = scopes;
+       isc.oscope = op->ors_scope;
 
        if ( op->ors_deref & LDAP_DEREF_FINDING ) {
                MDB_IDL_ZERO(candidates);
        }
 dn2entry_retry:
        /* get entry with reader lock */
-       rs->sr_err = mdb_dn2entry( op, ltid, &op->o_req_ndn, &e, 1 );
+       rs->sr_err = mdb_dn2entry( op, ltid, mcd, &op->o_req_ndn, &e, &nsubs, 1 );
 
        switch(rs->sr_err) {
        case MDB_NOTFOUND:
@@ -483,13 +538,42 @@ dn2entry_retry:
        /* select candidates */
        if ( op->oq_search.rs_scope == LDAP_SCOPE_BASE ) {
                rs->sr_err = base_candidate( op->o_bd, base, candidates );
-
+               scopes[0].mid = 0;
+               ncand = 1;
        } else {
+               if ( op->ors_scope == LDAP_SCOPE_ONELEVEL ) {
+                       size_t nkids;
+                       MDB_val key, data;
+                       key.mv_data = &base->e_id;
+                       key.mv_size = sizeof( ID );
+                       mdb_cursor_get( mcd, &key, &data, MDB_SET );
+                       mdb_cursor_count( mcd, &nkids );
+                       nsubs = nkids - 1;
+               } else if ( !base->e_id ) {
+                       /* we don't maintain nsubs for entryID 0.
+                        * just grab entry count from id2entry stat
+                        */
+                       MDB_stat ms;
+                       mdb_stat( ltid, mdb->mi_id2entry, &ms );
+                       nsubs = ms.ms_entries;
+               }
                MDB_IDL_ZERO( candidates );
-               MDB_IDL_ZERO( scopes );
-               mdb_idl_insert( scopes, base->e_id );
+               scopes[0].mid = 1;
+               scopes[1].mid = base->e_id;
+               scopes[1].mval.mv_data = NULL;
                rs->sr_err = search_candidates( op, rs, base,
-                       ltid, candidates, scopes );
+                       ltid, mci, candidates, scopes );
+               ncand = MDB_IDL_N( candidates );
+               if ( !base->e_id || ncand == NOID ) {
+                       /* grab entry count from id2entry stat
+                        */
+                       MDB_stat ms;
+                       mdb_stat( ltid, mdb->mi_id2entry, &ms );
+                       if ( !base->e_id )
+                               nsubs = ms.ms_entries;
+                       if ( ncand == NOID )
+                               ncand = ms.ms_entries;
+               }
        }
 
        /* start cursor at beginning of candidates.
@@ -507,7 +591,7 @@ dn2entry_retry:
        /* if not root and candidates exceed to-be-checked entries, abort */
        if ( op->ors_limit      /* isroot == FALSE */ &&
                op->ors_limit->lms_s_unchecked != -1 &&
-               MDB_IDL_N(candidates) > (unsigned) op->ors_limit->lms_s_unchecked )
+               ncand > (unsigned) op->ors_limit->lms_s_unchecked )
        {
                rs->sr_err = LDAP_ADMINLIMIT_EXCEEDED;
                send_ldap_result( op, rs );
@@ -518,7 +602,7 @@ dn2entry_retry:
        if ( op->ors_limit == NULL      /* isroot == TRUE */ ||
                !op->ors_limit->lms_s_pr_hide )
        {
-               tentries = MDB_IDL_N(candidates);
+               tentries = ncand;
        }
 
        if ( get_pagedresults( op ) > SLAP_CONTROL_IGNORED ) {
@@ -550,13 +634,43 @@ dn2entry_retry:
                }
                if ( id == (ID)ps->ps_cookie )
                        id = mdb_idl_next( candidates, &cursor );
+               nsubs = ncand;  /* always bypass scope'd search */
                goto loop_begin;
        }
+       if ( nsubs < ncand ) {
+               int rc;
+               /* Do scope-based search */
+
+               /* if any alias scopes were set, save them */
+               if (scopes[0].mid > 1) {
+                       cursor = 1;
+                       for (cscope = 1; cscope <= scopes[0].mid; cscope++) {
+                               /* Ignore the original base */
+                               if (scopes[cscope].mid == base->e_id)
+                                       continue;
+                               iscopes[cursor++] = scopes[cscope].mid;
+                       }
+                       iscopes[0] = scopes[0].mid - 1;
+               } else {
+                       iscopes[0] = 0;
+               }
+
+               isc.id = base->e_id;
+               isc.numrdns = 0;
+               rc = mdb_dn2id_walk( op, &isc );
+               if ( rc )
+                       id = NOID;
+               else
+                       id = isc.id;
+               cscope = 0;
+       } else {
+               id = mdb_idl_first( candidates, &cursor );
+       }
 
-       for ( id = mdb_idl_first( candidates, &cursor );
-                 id != NOID ; id = mdb_idl_next( candidates, &cursor ) )
+       while (id != NOID)
        {
                int scopeok;
+               MDB_val edata;
 
 loop_begin:
 
@@ -587,25 +701,82 @@ loop_begin:
                        goto done;
                }
 
+
+               if ( nsubs < ncand ) {
+                       unsigned i;
+                       /* Is this entry in the candidate list? */
+                       scopeok = 0;
+                       if (MDB_IDL_IS_RANGE( candidates )) {
+                               if ( id >= MDB_IDL_RANGE_FIRST( candidates ) &&
+                                       id <= MDB_IDL_RANGE_LAST( candidates ))
+                                       scopeok = 1;
+                       } else {
+                               i = mdb_idl_search( candidates, id );
+                               if ( candidates[i] == id )
+                                       scopeok = 1;
+                       }
+                       if ( scopeok )
+                               goto scopeok;
+                       goto loop_continue;
+               }
+
+               /* Does this candidate actually satisfy the search scope?
+                */
+               scopeok = 0;
+               isc.numrdns = 0;
+               switch( op->ors_scope ) {
+               case LDAP_SCOPE_BASE:
+                       /* This is always true, yes? */
+                       if ( id == base->e_id ) scopeok = 1;
+                       break;
+
+#ifdef LDAP_SCOPE_CHILDREN
+               case LDAP_SCOPE_CHILDREN:
+                       if ( id == base->e_id ) break;
+                       /* Fall-thru */
+#endif
+               case LDAP_SCOPE_SUBTREE:
+                       if ( id == base->e_id ) {
+                               scopeok = 1;
+                               break;
+                       }
+                       /* Fall-thru */
+               case LDAP_SCOPE_ONELEVEL:
+                       isc.id = id;
+                       isc.nscope = 0;
+                       rs->sr_err = mdb_idscopes( op, &isc );
+                       if ( rs->sr_err == MDB_SUCCESS ) {
+                               if ( isc.nscope )
+                                       scopeok = 1;
+                       } else {
+                               if ( rs->sr_err == MDB_NOTFOUND )
+                                       goto notfound;
+                       }
+                       break;
+               }
+
+               /* Not in scope, ignore it */
+               if ( !scopeok )
+               {
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(mdb_search)
+                               ": %ld scope not okay\n",
+                               (long) id, 0, 0 );
+                       goto loop_continue;
+               }
+
+scopeok:
                if ( id == base->e_id ) {
                        e = base;
                } else {
 
                        /* get the entry */
-                       rs->sr_err = mdb_id2entry( op, ltid, id, &e );
-
-                       if (rs->sr_err == LDAP_BUSY) {
-                               rs->sr_text = "ldap server busy";
-                               send_ldap_result( op, rs );
-                               goto done;
-
-                       } else if ( rs->sr_err == LDAP_OTHER ) {
-                               rs->sr_text = "internal error";
-                               send_ldap_result( op, rs );
-                               goto done;
-                       }
+                       rs->sr_err = mdb_id2edata( op, mci, id, &edata );
+                       if ( rs->sr_err == MDB_NOTFOUND ) {
+notfound:
+                               if( nsubs < ncand )
+                                       goto loop_continue;
 
-                       if ( e == NULL ) {
                                if( !MDB_IDL_IS_RANGE(candidates) ) {
                                        /* only complain for non-range IDLs */
                                        Debug( LDAP_DEBUG_TRACE,
@@ -614,7 +785,7 @@ loop_begin:
                                                (long) id, 0, 0 );
                                } else {
                                        /* get the next ID from the DB */
-                                       rs->sr_err = mdb_get_nextid( mdb, ltid, &cursor );
+                                       rs->sr_err = mdb_get_nextid( mci, &cursor );
                                        if ( rs->sr_err == MDB_NOTFOUND ) {
                                                break;
                                        }
@@ -628,7 +799,23 @@ loop_begin:
                                }
 
                                goto loop_continue;
+                       } else if ( rs->sr_err ) {
+                               rs->sr_err = LDAP_OTHER;
+                               rs->sr_text = "internal error in mdb_id2edata";
+                               send_ldap_result( op, rs );
+                               goto done;
+                       }
+
+                       rs->sr_err = mdb_entry_decode( op, &edata, &e );
+                       if ( rs->sr_err ) {
+                               rs->sr_err = LDAP_OTHER;
+                               rs->sr_text = "internal error in mdb_entry_decode";
+                               send_ldap_result( op, rs );
+                               goto done;
                        }
+                       e->e_id = id;
+                       e->e_name.bv_val = NULL;
+                       e->e_nname.bv_val = NULL;
                }
 
                if ( is_entry_subentry( e ) ) {
@@ -650,56 +837,18 @@ loop_begin:
                        goto loop_continue;
                }
 
-               /* Does this candidate actually satisfy the search scope?
-                */
-               scopeok = 0;
-               isc.numrdns = 0;
-               switch( op->ors_scope ) {
-               case LDAP_SCOPE_BASE:
-                       /* This is always true, yes? */
-                       if ( id == base->e_id ) scopeok = 1;
-                       break;
-
-#ifdef LDAP_SCOPE_CHILDREN
-               case LDAP_SCOPE_CHILDREN:
-                       if ( id == base->e_id ) break;
-                       /* Fall-thru */
-#endif
-               case LDAP_SCOPE_SUBTREE:
-                       if ( id == base->e_id ) {
-                               scopeok = 1;
-                               break;
-                       }
-                       /* Fall-thru */
-               case LDAP_SCOPE_ONELEVEL:
-                       isc.id = id;
-                       if ( mdb_idscopes( op, &isc ) == MDB_SUCCESS ) scopeok = 1;
-                       break;
-               }
-
                /* aliases were already dereferenced in candidate list */
                if ( op->ors_deref & LDAP_DEREF_SEARCHING ) {
                        /* but if the search base is an alias, and we didn't
                         * deref it when finding, return it.
                         */
                        if ( is_entry_alias(e) &&
-                               ((op->ors_deref & LDAP_DEREF_FINDING) ||
-                                       !bvmatch(&e->e_nname, &op->o_req_ndn)))
+                               ((op->ors_deref & LDAP_DEREF_FINDING) || e != base ))
                        {
                                goto loop_continue;
                        }
                }
 
-               /* Not in scope, ignore it */
-               if ( !scopeok )
-               {
-                       Debug( LDAP_DEBUG_TRACE,
-                               LDAP_XSTRING(mdb_search)
-                               ": %ld scope not okay\n",
-                               (long) id, 0, 0 );
-                       goto loop_continue;
-               }
-
                if ( !manageDSAit && is_entry_glue( e )) {
                        goto loop_continue;
                }
@@ -708,12 +857,13 @@ loop_begin:
                        struct berval pdn, pndn;
                        char *d, *n;
                        int i;
+
                        /* child of base, just append RDNs to base->e_name */
-                       if ( isc.nscope == 1 ) {
+                       if ( nsubs < ncand || isc.scopes[isc.nscope].mid == base->e_id ) {
                                pdn = base->e_name;
                                pndn = base->e_nname;
                        } else {
-                               mdb_id2name( op, ltid, &isc.mc, scopes[isc.nscope], &pdn, &pndn );
+                               mdb_id2name( op, ltid, &isc.mc, scopes[isc.nscope].mid, &pdn, &pndn );
                        }
                        e->e_name.bv_len = pdn.bv_len;
                        e->e_nname.bv_len = pndn.bv_len;
@@ -725,14 +875,28 @@ loop_begin:
                        e->e_nname.bv_val = op->o_tmpalloc(e->e_nname.bv_len + 1, op->o_tmpmemctx);
                        d = e->e_name.bv_val;
                        n = e->e_nname.bv_val;
-                       for (i=0; i<isc.numrdns; i++) {
-                               memcpy(d, isc.rdns[i].bv_val, isc.rdns[i].bv_len);
-                               d += isc.rdns[i].bv_len;
-                               *d++ = ',';
-                               memcpy(n, isc.nrdns[i].bv_val, isc.nrdns[i].bv_len);
-                               n += isc.nrdns[i].bv_len;
-                               *n++ = ',';
+                       if (nsubs < ncand) {
+                               /* RDNs are in top-down order */
+                               for (i=isc.numrdns-1; i>=0; i--) {
+                                       memcpy(d, isc.rdns[i].bv_val, isc.rdns[i].bv_len);
+                                       d += isc.rdns[i].bv_len;
+                                       *d++ = ',';
+                                       memcpy(n, isc.nrdns[i].bv_val, isc.nrdns[i].bv_len);
+                                       n += isc.nrdns[i].bv_len;
+                                       *n++ = ',';
+                               }
+                       } else {
+                               /* RDNs are in bottom-up order */
+                               for (i=0; i<isc.numrdns; i++) {
+                                       memcpy(d, isc.rdns[i].bv_val, isc.rdns[i].bv_len);
+                                       d += isc.rdns[i].bv_len;
+                                       *d++ = ',';
+                                       memcpy(n, isc.nrdns[i].bv_val, isc.nrdns[i].bv_len);
+                                       n += isc.nrdns[i].bv_len;
+                                       *n++ = ',';
+                               }
                        }
+
                        if (pdn.bv_len) {
                                memcpy(d, pdn.bv_val, pdn.bv_len+1);
                                memcpy(n, pndn.bv_val, pndn.bv_len+1);
@@ -742,7 +906,7 @@ loop_begin:
                                e->e_name.bv_len--;
                                e->e_nname.bv_len--;
                        }
-                       if (isc.nscope != 1) {
+                       if (pndn.bv_val != base->e_nname.bv_val) {
                                op->o_tmpfree(pndn.bv_val, op->o_tmpmemctx);
                                op->o_tmpfree(pdn.bv_val, op->o_tmpmemctx);
                        }
@@ -842,6 +1006,37 @@ loop_continue:
                        e = NULL;
                        rs->sr_entry = NULL;
                }
+
+               if ( nsubs < ncand ) {
+                       int rc = mdb_dn2id_walk( op, &isc );
+                       if (rc) {
+                               id = NOID;
+                               /* We got to the end of a subtree. If there are any
+                                * alias scopes left, search them too.
+                                */
+                               while (iscopes[0] && cscope < iscopes[0]) {
+                                       cscope++;
+                                       isc.id = iscopes[cscope];
+                                       if ( base )
+                                               mdb_entry_return( op, base );
+                                       rs->sr_err = mdb_id2entry(op, mci, isc.id, &base);
+                                       if ( !rs->sr_err ) {
+                                               mdb_id2name( op, ltid, &isc.mc, isc.id, &base->e_name, &base->e_nname );
+                                               isc.numrdns = 0;
+                                               if (isc.oscope == LDAP_SCOPE_ONELEVEL)
+                                                       isc.oscope = LDAP_SCOPE_BASE;
+                                               rc = mdb_dn2id_walk( op, &isc );
+                                               if ( !rc ) {
+                                                       id = isc.id;
+                                                       break;
+                                               }
+                                       }
+                               }
+                       } else
+                               id = isc.id;
+               } else {
+                       id = mdb_idl_next( candidates, &cursor );
+               }
        }
 
 nochange:
@@ -858,18 +1053,21 @@ nochange:
        rs->sr_err = LDAP_SUCCESS;
 
 done:
+       mdb_cursor_close( mcd );
+       mdb_cursor_close( mci );
        if ( moi == &opinfo ) {
                mdb_txn_reset( moi->moi_txn );
                LDAP_SLIST_REMOVE( &op->o_extra, &moi->moi_oe, OpExtra, oe_next );
+       } else {
+               moi->moi_ref--;
        }
-       if( isc.mc )
-               mdb_cursor_close( isc.mc );
        if( rs->sr_v2ref ) {
                ber_bvarray_free( rs->sr_v2ref );
                rs->sr_v2ref = NULL;
        }
        if (base)
                mdb_entry_return( op,base);
+       scope_chunk_ret( op, scopes );
 
        return rs->sr_err;
 }
@@ -958,8 +1156,9 @@ static int search_candidates(
        SlapReply *rs,
        Entry *e,
        MDB_txn *txn,
+       MDB_cursor *mci,
        ID      *ids,
-       ID      *scopes )
+       ID2L    scopes )
 {
        struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
        int rc, depth = 1;
@@ -1024,7 +1223,7 @@ static int search_candidates(
        }
 
        if( op->ors_deref & LDAP_DEREF_SEARCHING ) {
-               rc = search_aliases( op, rs, e, txn, scopes, stack );
+               rc = search_aliases( op, rs, e->e_id, txn, mci, scopes, stack );
        } else {
                rc = LDAP_SUCCESS;
        }