]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-mdb/tools.c
Merge remote-tracking branch 'origin/mdb.master'
[openldap] / servers / slapd / back-mdb / tools.c
index 3747c7ad079355cc75a73358f75b42fc212b1311..0839d56784ed1571c669a3d58f0ccaaf2f795971 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2011-2013 The OpenLDAP Foundation.
+ * Copyright 2011-2014 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -72,10 +72,11 @@ static Filter               *tool_filter;
 static Entry           *tool_next_entry;
 
 static ID mdb_tool_ix_id;
-static Operation *mdb_tool_ix_op;
+static BackendDB *mdb_tool_ix_be;
 static MDB_txn *mdb_tool_ix_txn;
 static int mdb_tool_index_tcount, mdb_tool_threads;
 static IndexRec *mdb_tool_index_rec;
+static AttrIxInfo **mdb_tool_axinfo;
 static struct mdb_info *mdb_tool_info;
 static ldap_pvt_thread_mutex_t mdb_tool_index_mutex;
 static ldap_pvt_thread_cond_t mdb_tool_index_cond_main;
@@ -84,19 +85,28 @@ static void * mdb_tool_index_task( void *ctx, void *ptr );
 
 static int     mdb_writes, mdb_writes_per_commit;
 
+/* Number of ops per commit in Quick mode.
+ * Batching speeds writes overall, but too large a
+ * batch will fail with MDB_TXN_FULL.
+ */
+#ifndef MDB_WRITES_PER_COMMIT
+#define MDB_WRITES_PER_COMMIT  500
+#endif
+
 static int
 mdb_tool_entry_get_int( BackendDB *be, ID id, Entry **ep );
 
 int mdb_tool_entry_open(
        BackendDB *be, int mode )
 {
-       /* In Quick mode, commit once per 1000 entries */
+       /* In Quick mode, commit once per 500 entries */
        mdb_writes = 0;
        if ( slapMode & SLAP_TOOL_QUICK )
-               mdb_writes_per_commit = 1000;
+               mdb_writes_per_commit = MDB_WRITES_PER_COMMIT;
        else
                mdb_writes_per_commit = 1;
 
+#ifdef MDB_TOOL_IDL_CACHING                    /* threaded indexing has no performance advantage */
        /* Set up for threaded slapindex */
        if (( slapMode & (SLAP_TOOL_QUICK|SLAP_TOOL_READONLY)) == SLAP_TOOL_QUICK ) {
                if ( !mdb_tool_info ) {
@@ -106,12 +116,16 @@ int mdb_tool_entry_open(
                        ldap_pvt_thread_cond_init( &mdb_tool_index_cond_work );
                        if ( mdb->mi_nattrs ) {
                                int i;
-#if 0                  /* threaded indexing has no performance advantage */
                                mdb_tool_threads = slap_tool_thread_max - 1;
-#endif
                                if ( mdb_tool_threads > 1 ) {
                                        mdb_tool_index_rec = ch_calloc( mdb->mi_nattrs, sizeof( IndexRec ));
+                                       mdb_tool_axinfo = ch_calloc( mdb_tool_threads, sizeof( AttrIxInfo* ) +
+                                               sizeof( AttrIxInfo ));
+                                       mdb_tool_axinfo[0] = (AttrIxInfo *)(mdb_tool_axinfo + mdb_tool_threads);
+                                       for (i=1; i<mdb_tool_threads; i++)
+                                               mdb_tool_axinfo[i] = mdb_tool_axinfo[i-1]+1;
                                        mdb_tool_index_tcount = mdb_tool_threads - 1;
+                                       mdb_tool_ix_be = be;
                                        for (i=1; i<mdb_tool_threads; i++) {
                                                int *ptr = ch_malloc( sizeof( int ));
                                                *ptr = i;
@@ -123,6 +137,7 @@ int mdb_tool_entry_open(
                        }
                }
        }
+#endif
 
        return 0;
 }
@@ -130,7 +145,9 @@ int mdb_tool_entry_open(
 int mdb_tool_entry_close(
        BackendDB *be )
 {
+#ifdef MDB_TOOL_IDL_CACHING
        if ( mdb_tool_info ) {
+               int i;
                slapd_shutdown = 1;
                ldap_pvt_thread_mutex_lock( &mdb_tool_index_mutex );
 
@@ -154,7 +171,22 @@ int mdb_tool_entry_close(
                slapd_shutdown = 0;
                ch_free( mdb_tool_index_rec );
                mdb_tool_index_tcount = mdb_tool_threads - 1;
+               if (txn)
+                       MDB_TOOL_IDL_FLUSH( be, txn );
+               for (i=0; i<mdb_tool_threads; i++) {
+                       mdb_tool_idl_cache *ic;
+                       mdb_tool_idl_cache_entry *ice;
+                       while ((ic = mdb_tool_axinfo[i]->ai_clist)) {
+                               mdb_tool_axinfo[i]->ai_clist = ic->head;
+                               free(ic);
+                       }
+                       while ((ice = mdb_tool_axinfo[i]->ai_flist)) {
+                               mdb_tool_axinfo[i]->ai_flist = ice->next;
+                               free(ice);
+                       }
+               }
        }
+#endif
 
        if( idcursor ) {
                mdb_cursor_close( idcursor );
@@ -165,9 +197,14 @@ int mdb_tool_entry_close(
                cursor = NULL;
        }
        if( txn ) {
-               MDB_TOOL_IDL_FLUSH( be, txn );
-               if ( mdb_txn_commit( txn ))
+               int rc;
+               if (( rc = mdb_txn_commit( txn ))) {
+                       Debug( LDAP_DEBUG_ANY,
+                               LDAP_XSTRING(mdb_tool_entry_close) ": database %s: "
+                               "txn_commit failed: %s (%d)\n",
+                               be->be_suffix[0].bv_val, mdb_strerror(rc), rc );
                        return -1;
+               }
                txn = NULL;
        }
 
@@ -359,7 +396,7 @@ mdb_tool_entry_get_int( BackendDB *be, ID id, Entry **ep )
                        }
                }
        }
-       rc = mdb_entry_decode( &op, &data, &e );
+       rc = mdb_entry_decode( &op, txn, &data, &e );
        e->e_id = id;
        if ( !BER_BVISNULL( &dn )) {
                e->e_name = dn;
@@ -457,7 +494,7 @@ static int mdb_tool_next_id(
                        "=> mdb_tool_next_id: %s\n", text->bv_val, 0, 0 );
                        return rc;
                }
-               rc = mdb_dn2id_add( op, mcp, mcd, pid, 1, e );
+               rc = mdb_dn2id_add( op, mcp, mcd, pid, 1, 1, e );
                if ( rc ) {
                        snprintf( text->bv_val, text->bv_len,
                                "dn2id_add failed: %s (%d)",
@@ -547,7 +584,6 @@ mdb_tool_index_add(
                                return rc;
                }
                mdb_tool_ix_id = e->e_id;
-               mdb_tool_ix_op = op;
                mdb_tool_ix_txn = txn;
                ldap_pvt_thread_mutex_lock( &mdb_tool_index_mutex );
                /* Wait for all threads to be ready */
@@ -559,33 +595,37 @@ mdb_tool_index_add(
                for ( i=1; i<mdb_tool_threads; i++ )
                        mdb_tool_index_rec[i].ir_i = LDAP_BUSY;
                mdb_tool_index_tcount = mdb_tool_threads - 1;
-               ldap_pvt_thread_mutex_unlock( &mdb_tool_index_mutex );
                ldap_pvt_thread_cond_broadcast( &mdb_tool_index_cond_work );
-
-               rc = mdb_index_recrun( op, txn, mdb, ir, e->e_id, 0 );
-               if ( rc )
-                       return rc;
-               ldap_pvt_thread_mutex_lock( &mdb_tool_index_mutex );
-               for ( i=1; i<mdb_tool_threads; i++ ) {
-                       if ( mdb_tool_index_rec[i].ir_i == LDAP_BUSY ) {
-                               ldap_pvt_thread_cond_wait( &mdb_tool_index_cond_main,
-                                       &mdb_tool_index_mutex );
-                               i--;
-                               continue;
-                       }
-                       if ( mdb_tool_index_rec[i].ir_i ) {
-                               rc = mdb_tool_index_rec[i].ir_i;
-                               break;
-                       }
-               }
                ldap_pvt_thread_mutex_unlock( &mdb_tool_index_mutex );
-               return rc;
+
+               return mdb_index_recrun( op, txn, mdb, ir, e->e_id, 0 );
        } else
        {
                return mdb_index_entry_add( op, txn, e );
        }
 }
 
+static int
+mdb_tool_index_finish()
+{
+       int i, rc;
+       ldap_pvt_thread_mutex_lock( &mdb_tool_index_mutex );
+       for ( i=1; i<mdb_tool_threads; i++ ) {
+               if ( mdb_tool_index_rec[i].ir_i == LDAP_BUSY ) {
+                       ldap_pvt_thread_cond_wait( &mdb_tool_index_cond_main,
+                               &mdb_tool_index_mutex );
+                       i--;
+                       continue;
+               }
+               if ( mdb_tool_index_rec[i].ir_i ) {
+                       rc = mdb_tool_index_rec[i].ir_i;
+                       break;
+               }
+       }
+       ldap_pvt_thread_mutex_unlock( &mdb_tool_index_mutex );
+       return rc;
+}
+
 ID mdb_tool_entry_put(
        BackendDB *be,
        Entry *e,
@@ -666,6 +706,9 @@ ID mdb_tool_entry_put(
                goto done;
        }
 
+       if ( mdb_tool_threads > 1 ) {
+               LDAP_SLIST_INSERT_HEAD( &op.o_extra, &mdb_tool_axinfo[0]->ai_oe, oe_next );
+       }
        rc = mdb_tool_index_add( &op, txn, e );
        if( rc != 0 ) {
                snprintf( text->bv_val, text->bv_len,
@@ -688,6 +731,9 @@ ID mdb_tool_entry_put(
                goto done;
        }
 
+       if( mdb->mi_nattrs && mdb_tool_threads > 1 )
+               rc = mdb_tool_index_finish();
+
 done:
        if( rc == 0 ) {
                mdb_writes++;
@@ -732,6 +778,8 @@ done:
        return e->e_id;
 }
 
+static int mdb_dn2id_upgrade( BackendDB *be );
+
 int mdb_tool_entry_reindex(
        BackendDB *be,
        ID id,
@@ -749,6 +797,13 @@ int mdb_tool_entry_reindex(
        assert( tool_base == NULL );
        assert( tool_filter == NULL );
 
+       /* Special: do a dn2id upgrade */
+       if ( adv && adv[0] == slap_schema.si_ad_entryDN ) {
+               /* short-circuit tool_entry_next() */
+               mdb_cursor_get( cursor, &key, &data, MDB_LAST );
+               return mdb_dn2id_upgrade( be );
+       }
+
        /* No indexes configured, nothing to do. Could return an
         * error here to shortcut things.
         */
@@ -991,8 +1046,18 @@ static void *
 mdb_tool_index_task( void *ctx, void *ptr )
 {
        int base = *(int *)ptr;
+       Operation op = {0};
+       Opheader ohdr = {0};
+       AttrIxInfo ai = {0}, *aio;
 
        free( ptr );
+       op.o_hdr = &ohdr;
+       op.o_bd = mdb_tool_ix_be;
+       op.o_tmpmemctx = NULL;
+       op.o_tmpmfuncs = &ch_mfuncs;
+       aio = mdb_tool_axinfo[base];
+       mdb_tool_axinfo[base] = &ai;
+       LDAP_SLIST_INSERT_HEAD( &op.o_extra, &ai.ai_oe, oe_next );
        while ( 1 ) {
                ldap_pvt_thread_mutex_lock( &mdb_tool_index_mutex );
                mdb_tool_index_tcount--;
@@ -1004,11 +1069,13 @@ mdb_tool_index_task( void *ctx, void *ptr )
                        mdb_tool_index_tcount--;
                        if ( !mdb_tool_index_tcount )
                                ldap_pvt_thread_cond_signal( &mdb_tool_index_cond_main );
+                       *aio = ai;
+                       mdb_tool_axinfo[base] = aio;
                        ldap_pvt_thread_mutex_unlock( &mdb_tool_index_mutex );
                        break;
                }
                ldap_pvt_thread_mutex_unlock( &mdb_tool_index_mutex );
-               mdb_tool_index_rec[base].ir_i = mdb_index_recrun( mdb_tool_ix_op,
+               mdb_tool_index_rec[base].ir_i = mdb_index_recrun( &op,
                        mdb_tool_ix_txn,
                        mdb_tool_info, mdb_tool_index_rec, mdb_tool_ix_id, base );
        }
@@ -1028,7 +1095,7 @@ mdb_tool_idl_cmp( const void *v1, const void *v2 )
 }
 
 static int
-mdb_tool_idl_flush_one( MDB_cursor *mc, AttrInfo *ai, mdb_tool_idl_cache *ic )
+mdb_tool_idl_flush_one( MDB_cursor *mc, AttrIxInfo *ai, mdb_tool_idl_cache *ic )
 {
        mdb_tool_idl_cache_entry *ice;
        MDB_val key, data[2];
@@ -1092,25 +1159,19 @@ mdb_tool_idl_flush_one( MDB_cursor *mc, AttrInfo *ai, mdb_tool_idl_cache *ic )
 
                data[0].mv_size = sizeof(ID);
                rc = 0;
-               i = ic->offset;
                for ( ice = ic->head, n=0; ice; ice = ice->next, n++ ) {
                        int end;
                        if ( ice->next ) {
                                end = IDBLOCK;
                        } else {
-                               end = ic->count & (IDBLOCK-1);
+                               end = (ic->count-ic->offset) & (IDBLOCK-1);
                                if ( !end )
                                        end = IDBLOCK;
                        }
-                       data[1].mv_size = end - i;
-                       data[0].mv_data = &ice->ids[i];
-                       i = 0;
-                       rc = mdb_cursor_put( mc, &key, data, MDB_NODUPDATA|MDB_APPEND|MDB_MULTIPLE );
+                       data[1].mv_size = end;
+                       data[0].mv_data = ice->ids;
+                       rc = mdb_cursor_put( mc, &key, data, MDB_APPENDDUP|MDB_MULTIPLE );
                        if ( rc ) {
-                               if ( rc == MDB_KEYEXIST ) {
-                                       rc = 0;
-                                       continue;
-                               }
                                rc = -1;
                                break;
                        }
@@ -1126,7 +1187,7 @@ mdb_tool_idl_flush_one( MDB_cursor *mc, AttrInfo *ai, mdb_tool_idl_cache *ic )
 }
 
 static int
-mdb_tool_idl_flush_db( MDB_txn *txn, AttrInfo *ai )
+mdb_tool_idl_flush_db( MDB_txn *txn, AttrInfo *ai, AttrIxInfo *ax )
 {
        MDB_cursor *mc;
        Avlnode *root;
@@ -1135,7 +1196,7 @@ mdb_tool_idl_flush_db( MDB_txn *txn, AttrInfo *ai )
        mdb_cursor_open( txn, ai->ai_dbi, &mc );
        root = tavl_end( ai->ai_root, TAVL_DIR_LEFT );
        do {
-               rc = mdb_tool_idl_flush_one( mc, ai, root->avl_data );
+               rc = mdb_tool_idl_flush_one( mc, ax, root->avl_data );
                if ( rc != -1 )
                        rc = 0;
        } while ((root = tavl_next(root, TAVL_DIR_RIGHT)));
@@ -1153,7 +1214,7 @@ mdb_tool_idl_flush( BackendDB *be, MDB_txn *txn )
 
        for ( i=0; i < mdb->mi_nattrs; i++ ) {
                if ( !mdb->mi_attrs[i]->ai_root ) continue;
-               rc = mdb_tool_idl_flush_db( txn, mdb->mi_attrs[i] );
+               rc = mdb_tool_idl_flush_db( txn, mdb->mi_attrs[i], mdb_tool_axinfo[i % mdb_tool_threads] );
                tavl_free(mdb->mi_attrs[i]->ai_root, NULL);
                mdb->mi_attrs[i]->ai_root = NULL;
                if ( rc )
@@ -1172,7 +1233,8 @@ int mdb_tool_idl_add(
        mdb_tool_idl_cache *ic, itmp;
        mdb_tool_idl_cache_entry *ice;
        int i, rc, lcount;
-       AttrInfo *ai = (AttrInfo *)mc;
+       AttrIxInfo *ax = (AttrIxInfo *)mc;
+       AttrInfo *ai = (AttrInfo *)ax->ai_ai;
        mc = ai->ai_cursor;
 
        dbi = ai->ai_dbi;
@@ -1186,9 +1248,9 @@ int mdb_tool_idl_add(
                ID nid;
                int rc;
 
-               if ( ai->ai_clist ) {
-                       ic = ai->ai_clist;
-                       ai->ai_clist = ic->head;
+               if ( ax->ai_clist ) {
+                       ic = ax->ai_clist;
+                       ax->ai_clist = ic->head;
                } else {
                        ic = ch_malloc( sizeof( mdb_tool_idl_cache ) + itmp.kstr.bv_len + 4 );
                }
@@ -1230,8 +1292,8 @@ int mdb_tool_idl_add(
        /* Are we at the limit, and converting to a range? */
        } else if ( ic->count == MDB_IDL_DB_SIZE ) {
                if ( ic->head ) {
-                       ic->tail->next = ai->ai_flist;
-                       ai->ai_flist = ic->head;
+                       ic->tail->next = ax->ai_flist;
+                       ax->ai_flist = ic->head;
                }
                ic->head = ic->tail = NULL;
                ic->last = id;
@@ -1239,11 +1301,11 @@ int mdb_tool_idl_add(
                continue;
        }
        /* No free block, create that too */
-       lcount = ic->count & (IDBLOCK-1);
+       lcount = (ic->count-ic->offset) & (IDBLOCK-1);
        if ( !ic->tail || lcount == 0) {
-               if ( ai->ai_flist ) {
-                       ice = ai->ai_flist;
-                       ai->ai_flist = ice->next;
+               if ( ax->ai_flist ) {
+                       ice = ax->ai_flist;
+                       ax->ai_flist = ice->next;
                } else {
                        ice = ch_malloc( sizeof( mdb_tool_idl_cache_entry ));
                }
@@ -1260,11 +1322,214 @@ int mdb_tool_idl_add(
                        ic->first = id;
        }
        ice = ic->tail;
-       if (!lcount || ice->ids[lcount-1] != id)
+       if (!lcount || ice->ids[lcount-1] != id) {
                ice->ids[lcount] = id;
-       ic->count++;
+               ic->count++;
+       }
        }
 
        return 0;
 }
 #endif /* MDB_TOOL_IDL_CACHING */
+
+/* Upgrade from pre 2.4.34 dn2id format */
+
+#include <ac/unistd.h>
+#include <lutil_meter.h>
+
+#define STACKSIZ       2048
+
+typedef struct rec {
+       ID id;
+       size_t len;
+       char rdn[512];
+} rec;
+
+static int
+mdb_dn2id_upgrade( BackendDB *be ) {
+       struct mdb_info *mi = (struct mdb_info *) be->be_private;
+       MDB_txn *mt;
+       MDB_cursor *mc = NULL;
+       MDB_val key, data;
+       char *ptr;
+       int rc, writes=0, depth=0;
+       int enable_meter = 0;
+       ID id = 0, *num, count = 0;
+       rec *stack;
+       lutil_meter_t meter;
+
+       if (!(mi->mi_flags & MDB_NEED_UPGRADE)) {
+               Debug( LDAP_DEBUG_ANY, "database %s: No upgrade needed.\n",
+                       be->be_suffix[0].bv_val, 0, 0 );
+               return 0;
+       }
+
+       {
+               MDB_stat st;
+
+               mdb_stat(mdb_cursor_txn(cursor), mi->mi_dbis[MDB_ID2ENTRY], &st);
+               if (!st.ms_entries) {
+                       /* Empty DB, nothing to upgrade? */
+                       return 0;
+               }
+               if (isatty(2))
+                       enable_meter = !lutil_meter_open(&meter,
+                               &lutil_meter_text_display,
+                               &lutil_meter_linear_estimator,
+                               st.ms_entries);
+       }
+
+       num = ch_malloc(STACKSIZ * (sizeof(ID) + sizeof(rec)));
+       stack = (rec *)(num + STACKSIZ);
+
+       rc = mdb_txn_begin(mi->mi_dbenv, NULL, 0, &mt);
+       if (rc) {
+               Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_txn_begin failed, %s (%d)\n",
+                       mdb_strerror(rc), rc, 0 );
+               goto leave;
+       }
+       rc = mdb_cursor_open(mt, mi->mi_dbis[MDB_DN2ID], &mc);
+       if (rc) {
+               Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_open failed, %s (%d)\n",
+                       mdb_strerror(rc), rc, 0 );
+               goto leave;
+       }
+
+       key.mv_size = sizeof(ID);
+       /* post-order depth-first update */
+       for(;;) {
+               size_t dkids;
+               unsigned char *ptr;
+
+               /* visit */
+               key.mv_data = &id;
+               stack[depth].id = id;
+               rc = mdb_cursor_get(mc, &key, &data, MDB_SET);
+               if (rc) {
+                       Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_get failed, %s (%d)\n",
+                               mdb_strerror(rc), rc, 0 );
+                       goto leave;
+               }
+               num[depth] = 1;
+
+               rc = mdb_cursor_count(mc, &dkids);
+               if (rc) {
+                       Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_count failed, %s (%d)\n",
+                               mdb_strerror(rc), rc, 0 );
+                       goto leave;
+               }
+               if (dkids > 1) {
+                       rc = mdb_cursor_get(mc, &key, &data, MDB_NEXT_DUP);
+down:
+                       ptr = (unsigned char *)data.mv_data + data.mv_size - sizeof(ID);
+                       memcpy(&id, ptr, sizeof(ID));
+                       depth++;
+                       memcpy(stack[depth].rdn, data.mv_data, data.mv_size);
+                       stack[depth].len = data.mv_size;
+                       continue;
+               }
+
+
+               /* pop: write updated count, advance to next node */
+pop:
+               /* update superior counts */
+               if (depth)
+                       num[depth-1] += num[depth];
+
+               key.mv_data = &id;
+               id = stack[depth-1].id;
+               data.mv_data = stack[depth].rdn;
+               data.mv_size = stack[depth].len;
+               rc = mdb_cursor_get(mc, &key, &data, MDB_GET_BOTH);
+               if (rc) {
+                       Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_get(BOTH) failed, %s (%d)\n",
+                               mdb_strerror(rc), rc, 0 );
+                       goto leave;
+               }
+               data.mv_data = stack[depth].rdn;
+               ptr = (unsigned char *)data.mv_data + data.mv_size;
+               memcpy(ptr, &num[depth], sizeof(ID));
+               data.mv_size += sizeof(ID);
+               rc = mdb_cursor_del(mc, 0);
+               if (rc) {
+                       Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_del failed, %s (%d)\n",
+                               mdb_strerror(rc), rc, 0 );
+                       goto leave;
+               }
+               rc = mdb_cursor_put(mc, &key, &data, 0);
+               if (rc) {
+                       Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_put failed, %s (%d)\n",
+                               mdb_strerror(rc), rc, 0 );
+                       goto leave;
+               }
+               count++;
+#if 1
+               if (enable_meter)
+                       lutil_meter_update(&meter, count, 0);
+#else
+               {
+                       int len;
+                       ptr = data.mv_data;
+                       len = (ptr[0] & 0x7f) << 8 | ptr[1];
+                       printf("ID: %zu, %zu, %.*s\n", stack[depth].id, num[depth], len, ptr+2);
+               }
+#endif
+               writes++;
+               if (writes == 1000) {
+                       mdb_cursor_close(mc);
+                       rc = mdb_txn_commit(mt);
+                       if (rc) {
+                               Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_txn_commit failed, %s (%d)\n",
+                                       mdb_strerror(rc), rc, 0 );
+                               goto leave;
+                       }
+                       rc = mdb_txn_begin(mi->mi_dbenv, NULL, 0, &mt);
+                       if (rc) {
+                               Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_txn_begin(2) failed, %s (%d)\n",
+                                       mdb_strerror(rc), rc, 0 );
+                               goto leave;
+                       }
+                       rc = mdb_cursor_open(mt, mi->mi_dbis[MDB_DN2ID], &mc);
+                       if (rc) {
+                               Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_open(2) failed, %s (%d)\n",
+                                       mdb_strerror(rc), rc, 0 );
+                               goto leave;
+                       }
+                       rc = mdb_cursor_get(mc, &key, &data, MDB_GET_BOTH);
+                       if (rc) {
+                               Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_cursor_get(2) failed, %s (%d)\n",
+                                       mdb_strerror(rc), rc, 0 );
+                               goto leave;
+                       }
+                       writes = 0;
+               }
+               depth--;
+
+               rc = mdb_cursor_get(mc, &key, &data, MDB_NEXT_DUP);
+               if (rc == 0)
+                       goto down;
+               rc = 0;
+               if (depth)
+                       goto pop;
+               else
+                       break;
+       }
+leave:
+       mdb_cursor_close(mc);
+       if (mt) {
+               int r2;
+               r2 = mdb_txn_commit(mt);
+               if (r2) {
+                       Debug(LDAP_DEBUG_ANY, "mdb_dn2id_upgrade: mdb_txn_commit(2) failed, %s (%d)\n",
+                               mdb_strerror(r2), r2, 0 );
+                       if (!rc)
+                               rc = r2;
+               }
+       }
+       ch_free(num);
+       if (enable_meter) {
+               lutil_meter_update(&meter, count, 1);
+               lutil_meter_close(&meter);
+       }
+       return rc;
+}