]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-meta/bind.c
Read config tree from back-ldif
[openldap] / servers / slapd / back-meta / bind.c
index eec3d54b370f207ec615a4c4dc6af7245c998181..69fe2ea995ea527d5f127a425f0484a6123dad0f 100644 (file)
@@ -1,67 +1,23 @@
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
- *
- * Copyright 2001, Pierangelo Masarati, All rights reserved. <ando@sys-net.it>
- *
- * This work has been developed to fulfill the requirements
- * of SysNet s.n.c. <http:www.sys-net.it> and it has been donated
- * to the OpenLDAP Foundation in the hope that it may be useful
- * to the Open Source community, but WITHOUT ANY WARRANTY.
- *
- * Permission is granted to anyone to use this software for any purpose
- * on any computer system, and to alter it and redistribute it, subject
- * to the following restrictions:
- *
- * 1. The author and SysNet s.n.c. are not responsible for the consequences
- *    of use of this software, no matter how awful, even if they arise from 
- *    flaws in it.
- *
- * 2. The origin of this software must not be misrepresented, either by
- *    explicit claim or by omission.  Since few users ever read sources,
- *    credits should appear in the documentation.
- *
- * 3. Altered versions must be plainly marked as such, and must not be
- *    misrepresented as being the original software.  Since few users
- *    ever read sources, credits should appear in the documentation.
- *    SysNet s.n.c. cannot be responsible for the consequences of the
- *    alterations.
- *
- * 4. This notice may not be removed or altered.
- *
+/* $OpenLDAP$ */
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * This software is based on the backend back-ldap, implemented
- * by Howard Chu <hyc@highlandsun.com>, and modified by Mark Valence
- * <kurash@sassafras.com>, Pierangelo Masarati <ando@sys-net.it> and other
- * contributors. The contribution of the original software to the present
- * implementation is acknowledged in this copyright statement.
+ * Copyright 1999-2005 The OpenLDAP Foundation.
+ * Portions Copyright 2001-2003 Pierangelo Masarati.
+ * Portions Copyright 1999-2003 Howard Chu.
+ * All rights reserved.
  *
- * A special acknowledgement goes to Howard for the overall architecture
- * (and for borrowing large pieces of code), and to Mark, who implemented
- * from scratch the attribute/objectclass mapping.
- *
- * The original copyright statement follows.
- *
- * Copyright 1999, Howard Chu, All rights reserved. <hyc@highlandsun.com>
- *
- * Permission is granted to anyone to use this software for any purpose
- * on any computer system, and to alter it and redistribute it, subject
- * to the following restrictions:
- *
- * 1. The author is not responsible for the consequences of use of this
- *    software, no matter how awful, even if they arise from flaws in it.
- *
- * 2. The origin of this software must not be misrepresented, either by
- *    explicit claim or by omission.  Since few users ever read sources,
- *    credits should appear in the documentation.
- *
- * 3. Altered versions must be plainly marked as such, and must not be
- *    misrepresented as being the original software.  Since few users
- *    ever read sources, credits should appear in the
- *    documentation.
- *
- * 4. This notice may not be removed or altered.
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
  *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* ACKNOWLEDGEMENTS:
+ * This work was initially developed by the Howard Chu for inclusion
+ * in OpenLDAP Software and subsequently enhanced by Pierangelo
+ * Masarati.
  */
 
 #include "portable.h"
@@ -83,6 +39,7 @@ static int
 meta_back_do_single_bind(
                struct metaconn         *lc,
                Operation               *op,
+               SlapReply               *rs,
                int                     candidate
 );
 
@@ -94,32 +51,23 @@ meta_back_bind( Operation *op, SlapReply *rs )
 
        int rc = -1, i, gotit = 0, ndnlen, isroot = 0;
        int op_type = META_OP_ALLOW_MULTIPLE;
-       int err = LDAP_SUCCESS;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( BACK_META, ENTRY, "meta_back_bind: dn: %s.\n",
-                       op->o_req_dn.bv_val, 0, 0 );
-#else /* !NEW_LOGGING */
+       rs->sr_err = LDAP_SUCCESS;
+
        Debug( LDAP_DEBUG_ARGS, "meta_back_bind: dn: %s.\n%s%s",
                        op->o_req_dn.bv_val, "", "" );
-#endif /* !NEW_LOGGING */
 
-       if ( op->oq_bind.rb_method == LDAP_AUTH_SIMPLE && be_isroot_pw( op ) ) {
+       if ( op->orb_method == LDAP_AUTH_SIMPLE && be_isroot_pw( op ) ) {
                isroot = 1;
-               ber_dupbv( &op->oq_bind.rb_edn, be_root_dn( op->o_bd ) );
+               ber_dupbv( &op->orb_edn, be_root_dn( op->o_bd ) );
                op_type = META_OP_REQUIRE_ALL;
        }
        lc = meta_back_getconn( op, rs, op_type,
-                       &op->o_req_ndn, NULL );
+                       &op->o_req_ndn, NULL, LDAP_BACK_SENDERR );
        if ( !lc ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( BACK_META, NOTICE,
-                               "meta_back_bind: no target for dn %s.\n", dn->bv_val, 0, 0 );
-#else /* !NEW_LOGGING */
                Debug( LDAP_DEBUG_ANY,
                                "meta_back_bind: no target for dn %s.\n%s%s",
                                op->o_req_dn.bv_val, "", "");
-#endif /* !NEW_LOGGING */
 
                send_ldap_result( op, rs );
                return -1;
@@ -128,20 +76,20 @@ meta_back_bind( Operation *op, SlapReply *rs )
        /*
         * Each target is scanned ...
         */
-       lc->bound_target = META_BOUND_NONE;
+       lc->mc_bound_target = META_BOUND_NONE;
        ndnlen = op->o_req_ndn.bv_len;
        for ( i = 0; i < li->ntargets; i++ ) {
                int             lerr;
                struct berval   orig_dn = op->o_req_dn;
                struct berval   orig_ndn = op->o_req_ndn;
-               struct berval   orig_cred = op->oq_bind.rb_cred;
-               int             orig_method = op->oq_bind.rb_method;
+               struct berval   orig_cred = op->orb_cred;
+               int             orig_method = op->orb_method;
                
 
                /*
                 * Skip non-candidates
                 */
-               if ( lc->conns[ i ].candidate != META_CANDIDATE ) {
+               if ( lc->mc_conns[ i ].msc_candidate != META_CANDIDATE ) {
                        continue;
                }
 
@@ -152,43 +100,37 @@ meta_back_bind( Operation *op, SlapReply *rs )
                         * A bind operation is expected to have
                         * ONE CANDIDATE ONLY!
                         */
-#ifdef NEW_LOGGING
-                       LDAP_LOG( BACK_META, WARNING,
-                                       "==>meta_back_bind: more than one"
-                                       " candidate is attempting to bind"
-                                       " ...\n" , 0, 0, 0 );
-#else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ANY,
                                        "==>meta_back_bind: more than one"
                                        " candidate is attempting to bind"
                                        " ...\n%s%s%s", 
                                        "", "", "" );
-#endif /* !NEW_LOGGING */
                }
 
-               if ( isroot && li->targets[ i ]->pseudorootdn.bv_val != NULL ) {
-                       op->o_req_dn = li->targets[ i ]->pseudorootdn;
-                       op->o_req_ndn = li->targets[ i ]->pseudorootdn;
-                       op->oq_bind.rb_cred = li->targets[ i ]->pseudorootpw;
-                       op->oq_bind.rb_method = LDAP_AUTH_SIMPLE;
+               if ( isroot && li->targets[ i ]->mt_pseudorootdn.bv_val != NULL ) {
+                       op->o_req_dn = li->targets[ i ]->mt_pseudorootdn;
+                       op->o_req_ndn = li->targets[ i ]->mt_pseudorootdn;
+                       op->orb_cred = li->targets[ i ]->mt_pseudorootpw;
+                       op->orb_method = LDAP_AUTH_SIMPLE;
                }
                
-               lerr = meta_back_do_single_bind( lc, op, i );
+               lerr = meta_back_do_single_bind( lc, op, rs, i );
                if ( lerr != LDAP_SUCCESS ) {
-                       err = lerr;
-                       ( void )meta_clear_one_candidate( &lc->conns[ i ], 1 );
+                       rs->sr_err = lerr;
+                       ( void )meta_clear_one_candidate( &lc->mc_conns[ i ], 1 );
+
                } else {
                        rc = LDAP_SUCCESS;
                }
 
                op->o_req_dn = orig_dn;
                op->o_req_ndn = orig_ndn;
-               op->oq_bind.rb_cred = orig_cred;
-               op->oq_bind.rb_method = orig_method;
+               op->orb_cred = orig_cred;
+               op->orb_method = orig_method;
        }
 
        if ( isroot ) {
-               lc->bound_target = META_BOUND_ALL;
+               lc->mc_bound_target = META_BOUND_ALL;
        }
 
        /*
@@ -196,7 +138,7 @@ meta_back_bind( Operation *op, SlapReply *rs )
         * err is the last error that occurred during a bind;
         * if at least (and at most?) one bind succeedes, fine.
         */
-       if ( rc != LDAP_SUCCESS /* && err != LDAP_SUCCESS */ ) {
+       if ( rc != LDAP_SUCCESS /* && rs->sr_err != LDAP_SUCCESS */ ) {
                
                /*
                 * deal with bind failure ...
@@ -206,11 +148,11 @@ meta_back_bind( Operation *op, SlapReply *rs )
                 * no target was found within the naming context, 
                 * so bind must fail with invalid credentials
                 */
-               if ( err == LDAP_SUCCESS && gotit == 0 ) {
-                       err = LDAP_INVALID_CREDENTIALS;
+               if ( rs->sr_err == LDAP_SUCCESS && gotit == 0 ) {
+                       rs->sr_err = LDAP_INVALID_CREDENTIALS;
                }
 
-               rs->sr_err = ldap_back_map_result( err );
+               rs->sr_err = slap_map_api2result( rs );
                send_ldap_result( op, rs );
                return -1;
        }
@@ -227,82 +169,99 @@ static int
 meta_back_do_single_bind(
                struct metaconn         *lc,
                Operation               *op,
+               SlapReply               *rs,
                int                     candidate
 )
 {
-       struct metainfo *li = ( struct metainfo * )op->o_bd->be_private;
-       struct berval   mdn = { 0, NULL };
-       int             rc;
-       ber_int_t       msgid;
+       struct metainfo         *li = ( struct metainfo * )op->o_bd->be_private;
+       struct berval           mdn = BER_BVNULL;
+       dncookie                dc;
+       struct metasingleconn   *lsc = &lc->mc_conns[ candidate ];
+       int                     msgid;
        
        /*
         * Rewrite the bind dn if needed
         */
-       switch ( rewrite_session( li->targets[ candidate ]->rwinfo,
-                               "bindDn", op->o_req_dn.bv_val,
-                               lc->conn, &mdn.bv_val ) ) {
-       case REWRITE_REGEXEC_OK:
-               if ( mdn.bv_val == NULL ) {
-                       mdn = op->o_req_dn;
-               } else {
-                       mdn.bv_len = strlen( mdn.bv_val );
-               }
-#ifdef NEW_LOGGING
-               LDAP_LOG( BACK_META, DETAIL1,
-                               "[rw] bindDn: \"%s\" -> \"%s\"\n",
-                               op->o_req_dn.bv_val, mdn.bv_val, 0 );
-#else /* !NEW_LOGGING */
-               Debug( LDAP_DEBUG_ARGS,
-                               "rw> bindDn: \"%s\" -> \"%s\"\n%s",
-                               op->o_req_dn.bv_val, mdn.bv_val, "" );
-#endif /* !NEW_LOGGING */
-               break;
-               
-       case REWRITE_REGEXEC_UNWILLING:
-               return LDAP_UNWILLING_TO_PERFORM;
+       dc.rwmap = &li->targets[ candidate ]->mt_rwmap;
+       dc.conn = op->o_conn;
+       dc.rs = rs;
+       dc.ctx = "bindDN";
 
-       case REWRITE_REGEXEC_ERR:
-               return LDAP_OTHER;
+       if ( ldap_back_dn_massage( &dc, &op->o_req_dn, &mdn ) ) {
+               send_ldap_result( op, rs );
+               return -1;
        }
 
-       if ( op->o_ctrls ) {
-               rc = ldap_set_option( lc->conns[ candidate ].ld, 
-                               LDAP_OPT_SERVER_CONTROLS, op->o_ctrls );
-               if ( rc != LDAP_SUCCESS ) {
-                       rc = ldap_back_map_result( rc );
-                       goto return_results;
-               }
-       }
-       
-       rc = ldap_sasl_bind(lc->conns[ candidate ].ld, mdn.bv_val,
-                       LDAP_SASL_SIMPLE, &op->oq_bind.rb_cred,
-                       op->o_ctrls, NULL, &msgid);
-       if ( rc != LDAP_SUCCESS ) {
-               rc = ldap_back_map_result( rc );
+       /* FIXME: this fixes the bind problem right now; we need
+        * to use the asynchronous version to get the "matched"
+        * and more in case of failure ... */
+       /* FIXME: should be check if at least some of the op->o_ctrls
+        * can/should be passed? */
+       rs->sr_err = ldap_sasl_bind( lsc->msc_ld, mdn.bv_val,
+                       LDAP_SASL_SIMPLE, &op->orb_cred,
+                       op->o_ctrls, NULL, &msgid );
+       if ( rs->sr_err == LDAP_SUCCESS ) {
+               LDAPMessage     *res;
+               struct timeval  tv = { 0, 0 };
+               int             rc;
+               int             nretries = 0;
 
-       } else {
                /*
-                * FIXME: handle response!!!
+                * handle response!!!
                 */
-               ber_dupbv( &lc->conns[ candidate ].bound_dn, &op->o_req_dn );
-               lc->conns[ candidate ].bound = META_BOUND;
-               lc->bound_target = candidate;
-
-               if ( li->savecred ) {
-                       if ( lc->conns[ candidate ].cred.bv_val )
-                               ch_free( lc->conns[ candidate ].cred.bv_val );
-                       ber_dupbv( &lc->conns[ candidate ].cred,
-                                       &op->oq_bind.rb_cred );
-                       ldap_set_rebind_proc( lc->conns[ candidate ].ld, 
-                                       meta_back_rebind, 
-                                       &lc->conns[ candidate ] );
+retry:;
+               switch ( ldap_result( lsc->msc_ld, msgid, 0, &tv, &res ) ) {
+               case 0:
+                       if ( ++nretries <= META_BIND_NRETRIES ) {
+                               ldap_pvt_thread_yield();
+                               tv.tv_sec = 0;
+                               tv.tv_usec = META_BIND_TIMEOUT;
+                               goto retry;
+                       }
+                       rs->sr_err = LDAP_BUSY;
+                       break;
+
+               case -1:
+                       ldap_get_option( lsc->msc_ld, LDAP_OPT_ERROR_NUMBER,
+                                       &rs->sr_err );
+                       break;
+
+               default:
+                       rc = ldap_parse_result( lsc->msc_ld, res, &rs->sr_err,
+                                       NULL, NULL, NULL, NULL, 1 );
+                       if ( rc != LDAP_SUCCESS ) {
+                               rs->sr_err = rc;
+                       }
+                       break;
                }
+       }
+
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               rs->sr_err = slap_map_api2result( rs );
+               goto return_results;
+       }
 
-               if ( li->cache.ttl != META_DNCACHE_DISABLED
-                               && op->o_req_ndn.bv_len != 0 ) {
-                       ( void )meta_dncache_update_entry( &li->cache,
-                                       &op->o_req_ndn, candidate );
+       if ( !BER_BVISNULL( &lsc->msc_bound_ndn ) ) {
+               ber_memfree( lsc->msc_bound_ndn.bv_val );
+       }
+       ber_dupbv( &lsc->msc_bound_ndn, &op->o_req_dn );
+       lsc->msc_bound = META_BOUND;
+       lc->mc_bound_target = candidate;
+
+       if ( LDAP_BACK_SAVECRED( li ) ) {
+               if ( !BER_BVISNULL( &lsc->msc_cred ) ) {
+                       /* destroy sensitive data */
+                       memset( lsc->msc_cred.bv_val, 0, lsc->msc_cred.bv_len );
+                       ber_memfree( lsc->msc_cred.bv_val );
                }
+               ber_dupbv( &lsc->msc_cred, &op->orb_cred );
+               ldap_set_rebind_proc( lsc->msc_ld, meta_back_rebind, lsc );
+       }
+
+       if ( li->cache.ttl != META_DNCACHE_DISABLED
+                       && op->o_req_ndn.bv_len != 0 ) {
+               ( void )meta_dncache_update_entry( &li->cache,
+                               &op->o_req_ndn, candidate );
        }
 
 return_results:;
@@ -311,50 +270,41 @@ return_results:;
                free( mdn.bv_val );
        }
 
-       return rc;
+       return rs->sr_err;
 }
 
 /*
  * meta_back_dobind
  */
 int
-meta_back_dobind( struct metaconn *lc, Operation *op )
+meta_back_dobind( struct metaconn *lc, Operation *op, ldap_back_send_t sendok )
 {
-       struct metasingleconn *lsc;
-       int bound = 0, i;
+       struct metasingleconn   *lsc;
+       int                     bound = 0, i;
 
        /*
         * all the targets are bound as pseudoroot
         */
-       if ( lc->bound_target == META_BOUND_ALL ) {
+       if ( lc->mc_bound_target == META_BOUND_ALL ) {
                return 1;
        }
 
-       for ( i = 0, lsc = lc->conns; !META_LAST(lsc); ++i, ++lsc ) {
-               int rc;
+       for ( i = 0, lsc = lc->mc_conns; !META_LAST( lsc ); ++i, ++lsc ) {
+               int             rc;
+               struct berval   cred = BER_BVC("");
+               int             msgid;
 
                /*
                 * Not a candidate or something wrong with this target ...
                 */
-               if ( lsc->ld == NULL ) {
+               if ( lsc->msc_ld == NULL ) {
                        continue;
                }
 
-               /*
-                * If required, set controls
-                */
-               if ( op->o_ctrls ) {
-                       if ( ldap_set_option( lsc->ld, LDAP_OPT_SERVER_CONTROLS,
-                                       op->o_ctrls ) != LDAP_SUCCESS ) {
-                               ( void )meta_clear_one_candidate( lsc, 1 );
-                               continue;
-                       }
-               }
-       
                /*
                 * If the target is already bound it is skipped
                 */
-               if ( lsc->bound == META_BOUND && lc->bound_target == i ) {
+               if ( lsc->msc_bound == META_BOUND && lc->mc_bound_target == i ) {
                        ++bound;
                        continue;
                }
@@ -364,29 +314,67 @@ meta_back_dobind( struct metaconn *lc, Operation *op )
                 * (note: if the target was already bound, the anonymous
                 * bind clears the previous bind).
                 */
-               if ( lsc->bound_dn.bv_val ) {
-                       ch_free( lsc->bound_dn.bv_val );
-                       lsc->bound_dn.bv_val = NULL;
-                       lsc->bound_dn.bv_len = 0;
+               if ( !BER_BVISNULL( &lsc->msc_bound_ndn ) ) {
+                       ber_memfree( lsc->msc_bound_ndn.bv_val );
+                       BER_BVZERO( &lsc->msc_bound_ndn );
                }
                
+               if ( /* FIXME: need li ... li->savecred && */ 
+                               !BER_BVISNULL( &lsc->msc_cred ) )
+               {
+                       /* destroy sensitive data */
+                       memset( lsc->msc_cred.bv_val, 0, lsc->msc_cred.bv_len );
+                       ber_memfree( lsc->msc_cred.bv_val );
+                       BER_BVZERO( &lsc->msc_cred );
+               }
+
+               /* FIXME: should we check if at least some of the op->o_ctrls
+                * can/should be passed? */
+               rc = ldap_sasl_bind( lsc->msc_ld, "", LDAP_SASL_SIMPLE, &cred,
+                               NULL, NULL, &msgid );
+               if ( rc == LDAP_SUCCESS ) {
+                       LDAPMessage     *res;
+                       struct timeval  tv = { 0, 0 };
+                       int             err;
+                       int             nretries = 0;
+
+                       /*
+                        * handle response!!!
+                        */
+retry:;
+                       switch ( ldap_result( lsc->msc_ld, msgid, 0, &tv, &res ) ) {
+                       case 0:
+                               if ( ++nretries <= META_BIND_NRETRIES ) {
+                                       ldap_pvt_thread_yield();
+                                       tv.tv_sec = 0;
+                                       tv.tv_usec = META_BIND_TIMEOUT;
+                                       goto retry;
+                               }
+
+                               rc = LDAP_BUSY;
+                               break;
+
+                       case -1:
+                               ldap_get_option( lsc->msc_ld, LDAP_OPT_ERROR_NUMBER,
+                                               &rc );
+                               break;
+
+                       default:
+                               rc = ldap_parse_result( lsc->msc_ld, res, &err,
+                                               NULL, NULL, NULL, NULL, 1 );
+                               if ( rc == LDAP_SUCCESS ) {
+                                       rc = err;
+                               }
+                               break;
+                       }
+               }
 
-               rc = ldap_bind_s( lsc->ld, 0, NULL, LDAP_AUTH_SIMPLE );
                if ( rc != LDAP_SUCCESS ) {
-                       
-#ifdef NEW_LOGGING
-                       LDAP_LOG( BACK_META, WARNING,
-                                       "meta_back_dobind: (anonymous)"
-                                       " bind failed"
-                                       " with error %d (%s)\n",
-                                       rc, ldap_err2string( rc ), 0 );
-#else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ANY,
                                        "==>meta_back_dobind: (anonymous)"
                                        " bind failed"
                                        " with error %d (%s)\n",
                                        rc, ldap_err2string( rc ), 0 );
-#endif /* !NEW_LOGGING */
 
                        /*
                         * null cred bind should always succeed
@@ -399,7 +387,7 @@ meta_back_dobind( struct metaconn *lc, Operation *op )
                        continue;
                } /* else */
                
-               lsc->bound = META_ANONYMOUS;
+               lsc->msc_bound = META_ANONYMOUS;
                ++bound;
        }
 
@@ -421,11 +409,11 @@ meta_back_is_valid( struct metaconn *lc, int candidate )
                return 0;
        }
 
-       for ( i = 0, lsc = lc->conns; !META_LAST(lsc) && i < candidate; 
+       for ( i = 0, lsc = lc->mc_conns; !META_LAST( lsc ) && i < candidate; 
                        ++i, ++lsc );
        
-       if ( !META_LAST(lsc) ) {
-               return( lsc->ld != NULL );
+       if ( !META_LAST( lsc ) ) {
+               return ( lsc->msc_ld != NULL );
        }
 
        return 0;
@@ -441,10 +429,11 @@ static int
 meta_back_rebind( LDAP *ld, LDAP_CONST char *url, ber_tag_t request,
        ber_int_t msgid, void *params )
 {
-       struct metasingleconn *lc = params;
+       struct metasingleconn   *lsc = params;
 
-       return ldap_bind_s( ld, lc->bound_dn.bv_val, lc->cred.bv_val,
-                       LDAP_AUTH_SIMPLE );
+       return ldap_sasl_bind_s( ld, lsc->msc_bound_ndn.bv_val,
+                       LDAP_SASL_SIMPLE, &lsc->msc_cred,
+                       NULL, NULL, NULL );
 }
 
 /*
@@ -453,55 +442,58 @@ meta_back_rebind( LDAP *ld, LDAP_CONST char *url, ber_tag_t request,
 int
 meta_back_op_result( struct metaconn *lc, Operation *op, SlapReply *rs )
 {
-       int i, rerr = LDAP_SUCCESS;
-       struct metasingleconn *lsc;
-       char *rmsg = NULL;
-       char *rmatch = NULL;
-
-       for ( i = 0, lsc = lc->conns; !META_LAST(lsc); ++i, ++lsc ) {
-               int err = LDAP_SUCCESS;
-               char *msg = NULL;
-               char *match = NULL;
-
-               ldap_get_option( lsc->ld, LDAP_OPT_ERROR_NUMBER, &err );
-               if ( err != LDAP_SUCCESS ) {
+       int                     i,
+                               rerr = LDAP_SUCCESS;
+       struct metasingleconn   *lsc;
+       char                    *rmsg = NULL;
+       char                    *rmatch = NULL;
+       int                     free_rmsg = 0,
+                               free_rmatch = 0;
+
+       for ( i = 0, lsc = lc->mc_conns; !META_LAST( lsc ); ++i, ++lsc ) {
+               char    *msg = NULL;
+               char    *match = NULL;
+
+               rs->sr_err = LDAP_SUCCESS;
+
+               ldap_get_option( lsc->msc_ld, LDAP_OPT_ERROR_NUMBER, &rs->sr_err );
+               if ( rs->sr_err != LDAP_SUCCESS ) {
                        /*
                         * better check the type of error. In some cases
                         * (search ?) it might be better to return a
                         * success if at least one of the targets gave
                         * positive result ...
                         */
-                       ldap_get_option( lsc->ld,
+                       ldap_get_option( lsc->msc_ld,
                                        LDAP_OPT_ERROR_STRING, &msg );
-                       ldap_get_option( lsc->ld,
+                       ldap_get_option( lsc->msc_ld,
                                        LDAP_OPT_MATCHED_DN, &match );
-                       err = ldap_back_map_result( err );
+                       rs->sr_err = slap_map_api2result( rs );
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG( BACK_META, RESULTS,
-                                       "meta_back_op_result: target"
-                                       " <%d> sending msg \"%s\""
-                                       " (matched \"%s\")\n",
-                                       i, ( msg ? msg : "" ),
-                                       ( match ? match : "" ) );
-#else /* !NEW_LOGGING */
                        Debug(LDAP_DEBUG_ANY,
                                        "==> meta_back_op_result: target"
                                        " <%d> sending msg \"%s\""
                                        " (matched \"%s\")\n", 
                                        i, ( msg ? msg : "" ),
                                        ( match ? match : "" ) );
-#endif /* !NEW_LOGGING */
 
                        /*
                         * FIXME: need to rewrite "match" (need rwinfo)
                         */
-                       switch ( err ) {
+                       switch ( rs->sr_err ) {
                        default:
-                               rerr = err;
+                               rerr = rs->sr_err;
+                               if ( rmsg ) {
+                                       ber_memfree( rmsg );
+                               }
                                rmsg = msg;
+                               free_rmsg = 1;
                                msg = NULL;
+                               if ( rmatch ) {
+                                       ber_memfree( rmatch );
+                               }
                                rmatch = match;
+                               free_rmatch = 1;
                                match = NULL;
                                break;
                        }
@@ -520,6 +512,12 @@ meta_back_op_result( struct metaconn *lc, Operation *op, SlapReply *rs )
        rs->sr_text = rmsg;
        rs->sr_matched = rmatch;
        send_ldap_result( op, rs );
+       if ( free_rmsg ) {
+               ber_memfree( rmsg );
+       }
+       if ( free_rmatch ) {
+               ber_memfree( rmatch );
+       }
        rs->sr_text = NULL;
        rs->sr_matched = NULL;