]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-meta/bind.c
use result of validation (ITS#4028)
[openldap] / servers / slapd / back-meta / bind.c
index 9cbc4edcca22f747fbacb64f88fa5ac1c9ecc4db..eb25c58fe01452ca927466c78c57df73e12e184d 100644 (file)
@@ -24,6 +24,7 @@
 
 #include <stdio.h>
 
+#include <ac/errno.h>
 #include <ac/socket.h>
 #include <ac/string.h>
 
@@ -37,16 +38,16 @@ static LDAP_REBIND_PROC     meta_back_rebind;
 
 static int
 meta_back_single_bind(
-               Operation               *op,
-               SlapReply               *rs,
-               struct metaconn         *mc,
-               int                     candidate );
+       Operation               *op,
+       SlapReply               *rs,
+       metaconn_t              *mc,
+       int                     candidate );
 
 int
 meta_back_bind( Operation *op, SlapReply *rs )
 {
-       struct metainfo *li = ( struct metainfo * )op->o_bd->be_private;
-       struct metaconn *mc;
+       metainfo_t      *mi = ( metainfo_t * )op->o_bd->be_private;
+       metaconn_t      *mc = NULL;
 
        int             rc = LDAP_OTHER,
                        i, gotit = 0, isroot = 0;
@@ -58,9 +59,16 @@ meta_back_bind( Operation *op, SlapReply *rs )
        Debug( LDAP_DEBUG_ARGS, "meta_back_bind: dn: %s.\n%s%s",
                        op->o_req_dn.bv_val, "", "" );
 
-       if ( op->orb_method == LDAP_AUTH_SIMPLE && be_isroot_pw( op ) ) {
+       if ( op->orb_method == LDAP_AUTH_SIMPLE
+               && be_isroot_dn( op->o_bd, &op->o_req_ndn ) )
+       {
+               if ( !be_isroot_pw( op ) ) {
+                       rs->sr_err = LDAP_INVALID_CREDENTIALS;
+                       rs->sr_text = NULL;
+                       send_ldap_result( op, rs );
+                       return rs->sr_err;
+               }
                isroot = 1;
-               ber_dupbv( &op->orb_edn, be_root_dn( op->o_bd ) );
        }
 
        /* we need meta_back_getconn() not send result even on error,
@@ -90,7 +98,7 @@ meta_back_bind( Operation *op, SlapReply *rs )
         * Each target is scanned ...
         */
        mc->mc_auth_target = META_BOUND_NONE;
-       for ( i = 0; i < li->mi_ntargets; i++ ) {
+       for ( i = 0; i < mi->mi_ntargets; i++ ) {
                int             lerr;
                Operation       op2 = *op;
 
@@ -115,11 +123,11 @@ meta_back_bind( Operation *op, SlapReply *rs )
                                        0, 0, 0 );
                }
 
-               if ( isroot && !BER_BVISNULL( &li->mi_targets[ i ]->mt_pseudorootdn ) )
+               if ( isroot && !BER_BVISNULL( &mi->mi_targets[ i ].mt_pseudorootdn ) )
                {
-                       op2.o_req_dn = li->mi_targets[ i ]->mt_pseudorootdn;
-                       op2.o_req_ndn = li->mi_targets[ i ]->mt_pseudorootdn;
-                       op2.orb_cred = li->mi_targets[ i ]->mt_pseudorootpw;
+                       op2.o_req_dn = mi->mi_targets[ i ].mt_pseudorootdn;
+                       op2.o_req_ndn = mi->mi_targets[ i ].mt_pseudorootdn;
+                       op2.orb_cred = mi->mi_targets[ i ].mt_pseudorootpw;
                        op2.orb_method = LDAP_AUTH_SIMPLE;
                }
                
@@ -128,15 +136,23 @@ meta_back_bind( Operation *op, SlapReply *rs )
                        rs->sr_err = lerr;
                        candidates[ i ].sr_tag = META_NOT_CANDIDATE;
 
+                       if ( META_BACK_ONERR_STOP( mi ) ) {
+                               rc = rs->sr_err;
+                               break;
+                       }
+                               
                } else {
                        rc = LDAP_SUCCESS;
                }
        }
 
-       if ( isroot ) {
+       if ( isroot && rc == LDAP_SUCCESS ) {
                mc->mc_auth_target = META_BOUND_ALL;
+               ber_dupbv( &op->orb_edn, be_root_dn( op->o_bd ) );
        }
 
+       meta_back_release_conn( op, mc );
+
        /*
         * rc is LDAP_SUCCESS if at least one bind succeeded,
         * err is the last error that occurred during a bind;
@@ -171,22 +187,23 @@ meta_back_bind( Operation *op, SlapReply *rs )
  */
 static int
 meta_back_single_bind(
-               Operation               *op,
-               SlapReply               *rs,
-               struct metaconn         *mc,
-               int                     candidate
-)
+       Operation               *op,
+       SlapReply               *rs,
+       metaconn_t              *mc,
+       int                     candidate )
 {
-       struct metainfo         *li = ( struct metainfo * )op->o_bd->be_private;
+       metainfo_t              *mi = ( metainfo_t * )op->o_bd->be_private;
+       metatarget_t            *mt = &mi->mi_targets[ candidate ];
        struct berval           mdn = BER_BVNULL;
        dncookie                dc;
-       struct metasingleconn   *msc = &mc->mc_conns[ candidate ];
-       int                     msgid;
+       metasingleconn_t        *msc = &mc->mc_conns[ candidate ];
+       int                     msgid,
+                               rebinding = 0;
        
        /*
         * Rewrite the bind dn if needed
         */
-       dc.rwmap = &li->mi_targets[ candidate ]->mt_rwmap;
+       dc.target = &mi->mi_targets[ candidate ];
        dc.conn = op->o_conn;
        dc.rs = rs;
        dc.ctx = "bindDN";
@@ -201,38 +218,94 @@ meta_back_single_bind(
         * and more in case of failure ... */
        /* FIXME: should be check if at least some of the op->o_ctrls
         * can/should be passed? */
+rebind:;
        rs->sr_err = ldap_sasl_bind( msc->msc_ld, mdn.bv_val,
                        LDAP_SASL_SIMPLE, &op->orb_cred,
                        op->o_ctrls, NULL, &msgid );
        if ( rs->sr_err == LDAP_SUCCESS ) {
                LDAPMessage     *res;
-               struct timeval  tv = { 0, 0 };
+               struct timeval  tv = { 0, 100000 };
                int             rc;
-               int             nretries = META_BIND_NRETRIES;
+               int             nretries = mt->mt_nretries;
 
                /*
                 * handle response!!!
                 */
 retry:;
+               tv.tv_sec = 0;
+               tv.tv_usec = META_BIND_TIMEOUT;
                switch ( ldap_result( msc->msc_ld, msgid, 0, &tv, &res ) ) {
                case 0:
-                       if ( nretries > 0 ) {
+                       Debug( LDAP_DEBUG_ANY,
+                               "%s meta_back_single_bind: "
+                               "ldap_result=0 nretries=%d%s\n",
+                               op->o_log_prefix, nretries,
+                               rebinding ? " rebinding" : "" );
+
+                       if ( nretries != META_RETRY_NEVER ) {
                                ldap_pvt_thread_yield();
+                               if ( nretries > 0 ) {
+                                       nretries--;
+                               }
                                tv.tv_sec = 0;
-                               tv.tv_usec = META_BIND_TIMEOUT;
-                               nretries--;
+                               tv.tv_usec = 100000;
                                goto retry;
                        }
                        rs->sr_err = LDAP_BUSY;
-                       break;
+                       if ( rebinding ) {
+                               ldap_abandon_ext( msc->msc_ld, msgid, NULL, NULL );
+                               break;
+                       }
+
+                       /* FIXME: some times the request times out
+                        * while the other party is not willing to
+                        * send a response any more.  Give it a second
+                        * chance with a freshly bound connection */
+                       rebinding = 1;
+                       nretries = mt->mt_nretries;
+                       /* fallthru */
 
                case -1:
                        ldap_get_option( msc->msc_ld, LDAP_OPT_ERROR_NUMBER,
                                        &rs->sr_err );
-                       if ( rs->sr_err == LDAP_UNAVAILABLE && nretries > 0 ) {
-                               nretries--;
-                               if ( meta_back_retry( op, rs, mc, candidate, LDAP_BACK_SENDERR ) ) {
-                                       goto retry;
+
+                       if ( rebinding ) {
+                               ldap_abandon_ext( msc->msc_ld, msgid, NULL, NULL );
+                       }
+
+                       Debug( LDAP_DEBUG_ANY,
+                               "### %s meta_back_single_bind: "
+                               "err=%d nretries=%d\n",
+                               op->o_log_prefix, rs->sr_err, nretries );
+
+                       rc = slap_map_api2result( rs );
+                       if ( rs->sr_err == LDAP_UNAVAILABLE && nretries != META_RETRY_NEVER ) {
+                               ldap_pvt_thread_mutex_lock( &mi->mi_conn_mutex );
+                               if ( mc->mc_refcnt == 1 ) {
+                                       ldap_unbind_ext_s( msc->msc_ld, NULL, NULL );
+                                       msc->msc_ld = NULL;
+                                       msc->msc_bound = 0;
+
+                                       ( void )rewrite_session_delete( mt->mt_rwmap.rwm_rw, op->o_conn );
+
+                                       /* mc here must be the regular mc,
+                                        * reset and ready for init */
+                                       rc = meta_back_init_one_conn( op, rs,
+                                               mt, msc, LDAP_BACK_DONTSEND );
+
+                               } else {
+                                       /* can't do anything about it */
+                                       rc = 0;
+                               }
+
+                               ldap_pvt_thread_mutex_unlock( &mi->mi_conn_mutex );
+
+                               if ( rc ) {
+                                       if ( nretries > 0 ) {
+                                               nretries--;
+                                       }
+                                       ldap_pvt_thread_yield();
+                                       goto rebind;
                                }
                        }
                        break;
@@ -256,15 +329,15 @@ retry:;
        msc->msc_bound = META_BOUND;
        mc->mc_auth_target = candidate;
 
-       if ( LDAP_BACK_SAVECRED( li ) ) {
+       if ( LDAP_BACK_SAVECRED( mi ) ) {
                ber_bvreplace( &msc->msc_cred, &op->orb_cred );
                ldap_set_rebind_proc( msc->msc_ld, meta_back_rebind, msc );
        }
 
-       if ( li->mi_cache.ttl != META_DNCACHE_DISABLED
+       if ( mi->mi_cache.ttl != META_DNCACHE_DISABLED
                        && op->o_req_ndn.bv_len != 0 )
        {
-               ( void )meta_dncache_update_entry( &li->mi_cache,
+               ( void )meta_dncache_update_entry( &mi->mi_cache,
                                &op->o_req_ndn, candidate );
        }
 
@@ -282,13 +355,21 @@ return_results:;
 int
 meta_back_single_dobind(
        Operation               *op,
-       struct metasingleconn   *msc,
+       SlapReply               *rs,
+       metaconn_t              *mc,
+       int                     candidate,
        ldap_back_send_t        sendok,
-       int                     retries )
+       int                     nretries,
+       int                     dolock )
 {
-       int             rc;
-       struct berval   cred = BER_BVC( "" );
-       int             msgid;
+       metainfo_t              *mi = ( metainfo_t * )op->o_bd->be_private;
+       metatarget_t            *mt = &mi->mi_targets[ candidate ];
+       metasingleconn_t        *msc = &mc->mc_conns[ candidate ];
+       int                     rc;
+       struct berval           cred = BER_BVC( "" );
+       int                     msgid,
+                               rebinding = 0,
+                               save_nretries = nretries;
 
        /*
         * Otherwise an anonymous bind is performed
@@ -300,9 +381,7 @@ meta_back_single_dobind(
                BER_BVZERO( &msc->msc_bound_ndn );
        }
                
-       if ( /* FIXME: need li ... li->savecred && */ 
-                       !BER_BVISNULL( &msc->msc_cred ) )
-       {
+       if ( !BER_BVISNULL( &msc->msc_cred ) ) {
                /* destroy sensitive data */
                memset( msc->msc_cred.bv_val, 0, msc->msc_cred.bv_len );
                ber_memfree( msc->msc_cred.bv_val );
@@ -311,43 +390,119 @@ meta_back_single_dobind(
 
        /* FIXME: should we check if at least some of the op->o_ctrls
         * can/should be passed? */
+rebind:;
        rc = ldap_sasl_bind( msc->msc_ld, "", LDAP_SASL_SIMPLE, &cred,
                        NULL, NULL, &msgid );
        if ( rc == LDAP_SUCCESS ) {
                LDAPMessage     *res;
-               struct timeval  tv = { 0, 0 };
-               int             err;
+               struct timeval  tv = { 0, 100000 };
 
                /*
                 * handle response!!!
                 */
 retry:;
+               tv.tv_sec = 0;
+               tv.tv_usec = META_BIND_TIMEOUT;
                switch ( ldap_result( msc->msc_ld, msgid, 0, &tv, &res ) ) {
                case 0:
-                       if ( retries > 0 ) {
+                       Debug( LDAP_DEBUG_ANY,
+                               "%s meta_back_single_dobind: "
+                               "ldap_result=0 nretries=%d%s\n",
+                               op->o_log_prefix, nretries,
+                               rebinding ? " rebinding" : "" );
+
+                       if ( nretries != META_RETRY_NEVER ) {
                                ldap_pvt_thread_yield();
+                               if ( nretries > 0 ) {
+                                       nretries--;
+                               }
                                tv.tv_sec = 0;
-                               tv.tv_usec = META_BIND_TIMEOUT;
-                               retries--;
+                               tv.tv_usec = 100000;
                                goto retry;
                        }
 
                        rc = LDAP_BUSY;
-                       break;
+                       if ( rebinding ) {
+                               ldap_abandon_ext( msc->msc_ld, msgid, NULL, NULL );
+                               break;
+                       }
+
+                       /* FIXME: some times the request times out
+                        * while the other party is not willing to
+                        * send a response any more.  Give it a second
+                        * chance with a freshly bound connection */
+                       rebinding = 1;
+                       nretries = save_nretries;
+                       /* fallthru */
 
                case -1:
                        ldap_get_option( msc->msc_ld,
-                                       LDAP_OPT_ERROR_NUMBER, &rc );
+                                       LDAP_OPT_ERROR_NUMBER, &rs->sr_err );
+
+                       if ( rebinding ) {
+                               ldap_abandon_ext( msc->msc_ld, msgid, NULL, NULL );
+                       }
+
+                       Debug( LDAP_DEBUG_ANY,
+                               "### %s meta_back_single_dobind: "
+                               "err=%d nretries=%d\n",
+                               op->o_log_prefix, rs->sr_err, nretries );
+
+                       rc = slap_map_api2result( rs );
+                       if ( rc == LDAP_UNAVAILABLE && nretries != META_RETRY_NEVER ) {
+                               if ( dolock ) {
+                                       ldap_pvt_thread_mutex_lock( &mi->mi_conn_mutex );
+                               }
+
+                               if ( mc->mc_refcnt == 1 ) {
+                                       ldap_unbind_ext_s( msc->msc_ld, NULL, NULL );
+                                       msc->msc_ld = NULL;
+                                       msc->msc_bound = 0;
+
+                                       ( void )rewrite_session_delete( mt->mt_rwmap.rwm_rw, op->o_conn );
+
+                                       /* mc here must be the regular mc,
+                                        * reset and ready for init */
+                                       rc = meta_back_init_one_conn( op, rs,
+                                               mt, msc, LDAP_BACK_DONTSEND );
+                               
+
+                               } else {
+                                       /* can't do anything about it */
+                                       rc = LDAP_UNAVAILABLE;
+                               }
+
+                               if ( dolock ) {
+                                       ldap_pvt_thread_mutex_unlock( &mi->mi_conn_mutex );
+                               }
+
+                               if ( rc == LDAP_SUCCESS ) {
+                                       ldap_pvt_thread_yield();
+                                       if ( nretries > 0 ) {
+                                               nretries--;
+                                       }
+                                       goto rebind;
+                               }
+                       }
                        break;
 
                default:
-                       rc = ldap_parse_result( msc->msc_ld, res, &err,
+                       rc = ldap_parse_result( msc->msc_ld, res, &rs->sr_err,
                                        NULL, NULL, NULL, NULL, 1 );
                        if ( rc == LDAP_SUCCESS ) {
-                               rc = err;
+                               rc = slap_map_api2result( rs );
                        }
                        break;
                }
+
+       } else {
+               rs->sr_err = rc;
+               rc = slap_map_api2result( rs );
+       }
+
+       rs->sr_err = rc;
+       if ( rc != LDAP_SUCCESS && ( sendok & LDAP_BACK_SENDERR ) ) {
+               send_ldap_result( op, rs );
        }
 
        return rc;
@@ -357,13 +512,29 @@ retry:;
  * meta_back_dobind
  */
 int
-meta_back_dobind( struct metaconn *mc, Operation *op, ldap_back_send_t sendok )
+meta_back_dobind(
+       Operation               *op,
+       SlapReply               *rs,
+       metaconn_t              *mc,
+       ldap_back_send_t        sendok )
 {
-       struct metasingleconn   *msc;
-       int                     bound = 0, i;
+       metainfo_t              *mi = ( metainfo_t * )op->o_bd->be_private;
+
+       int                     bound = 0,
+                               i,
+                               isroot = 0;
 
        SlapReply               *candidates = meta_back_candidates_get( op );
 
+       if ( be_isroot( op ) ) {
+               isroot = 1;
+       }
+
+       Debug( LDAP_DEBUG_TRACE,
+               "%s meta_back_dobind: conn=%ld%s\n",
+               op->o_log_prefix, mc->mc_conn->c_connid,
+               isroot ? " (isroot)" : "" );
+
        ldap_pvt_thread_mutex_lock( &mc->mc_mutex );
 
        /*
@@ -374,25 +545,49 @@ meta_back_dobind( struct metaconn *mc, Operation *op, ldap_back_send_t sendok )
                goto done;
        }
 
-       for ( i = 0, msc = &mc->mc_conns[ 0 ]; !META_LAST( msc ); ++i, ++msc ) {
-               int             rc;
+       for ( i = 0; i < mi->mi_ntargets; i++ ) {
+               metatarget_t            *mt = &mi->mi_targets[ i ];
+               metasingleconn_t        *msc = &mc->mc_conns[ i ];
+               int                     rc;
 
                /*
-                * Not a candidate or something wrong with this target ...
+                * Not a candidate
                 */
-               if ( msc->msc_ld == NULL ) {
+               if ( candidates[ i ].sr_tag != META_CANDIDATE ) {
                        continue;
                }
 
+               assert( msc->msc_ld != NULL );
+
                /*
                 * If the target is already bound it is skipped
                 */
                if ( msc->msc_bound == META_BOUND && mc->mc_auth_target == i ) {
                        ++bound;
+
+                       Debug( LDAP_DEBUG_TRACE, "%s meta_back_dobind[%d]: "
+                                       "authcTarget\n",
+                                       op->o_log_prefix, i, 0 );
                        continue;
                }
 
-               rc = meta_back_single_dobind( op, msc, sendok, META_BIND_NRETRIES );
+               if ( isroot && !BER_BVISNULL( &mi->mi_targets[ i ].mt_pseudorootdn ) )
+               {
+                       Operation       op2 = *op;
+
+                       op2.o_tag = LDAP_REQ_BIND;
+                       op2.o_req_dn = mi->mi_targets[ i ].mt_pseudorootdn;
+                       op2.o_req_ndn = mi->mi_targets[ i ].mt_pseudorootdn;
+                       op2.orb_cred = mi->mi_targets[ i ].mt_pseudorootpw;
+                       op2.orb_method = LDAP_AUTH_SIMPLE;
+
+                       rc = meta_back_single_bind( &op2, rs, mc, i );
+
+               } else {
+                       rc = meta_back_single_dobind( op, rs, mc, i,
+                               LDAP_BACK_DONTSEND, mt->mt_nretries, 1 );
+               }
+
                if ( rc != LDAP_SUCCESS ) {
                        Debug( LDAP_DEBUG_ANY, "%s meta_back_dobind[%d]: "
                                        "(anonymous) err=%d\n",
@@ -405,14 +600,19 @@ meta_back_dobind( struct metaconn *mc, Operation *op, ldap_back_send_t sendok )
                         * due to technical reasons (remote host down?)
                         * so better clear the handle
                         */
-                       candidates[ i ].sr_tag = META_NOT_CANDIDATE;
-#if 0
-                       ( void )meta_clear_one_candidate( msc );
-#endif
+                       /* leave the target candidate, but record the error for later use */
+                       candidates[ i ].sr_err = rc;
+                       if ( META_BACK_ONERR_STOP( mi ) ) {
+                               bound = 0;
+                               goto done;
+                       }
                        continue;
                } /* else */
                
-               candidates[ i ].sr_tag = META_CANDIDATE;
+               Debug( LDAP_DEBUG_TRACE, "%s meta_back_dobind[%d]: "
+                               "(anonymous)\n",
+                               op->o_log_prefix, i, 0 );
+
                msc->msc_bound = META_ANONYMOUS;
                ++bound;
        }
@@ -420,6 +620,21 @@ meta_back_dobind( struct metaconn *mc, Operation *op, ldap_back_send_t sendok )
 done:;
         ldap_pvt_thread_mutex_unlock( &mc->mc_mutex );
 
+       Debug( LDAP_DEBUG_TRACE,
+               "%s meta_back_dobind: conn=%ld bound=%d\n",
+               op->o_log_prefix, mc->mc_conn->c_connid, bound );
+
+       if ( bound == 0 ) {
+               meta_back_release_conn( op, mc );
+
+               if ( sendok & LDAP_BACK_SENDERR ) {
+                       if ( rs->sr_err == LDAP_SUCCESS ) {
+                               rs->sr_err = LDAP_BUSY;
+                       }
+                       send_ldap_result( op, rs );
+               }
+       }
+
        return( bound > 0 );
 }
 
@@ -430,10 +645,14 @@ done:;
  * credentials as the original user on this session.
  */
 static int 
-meta_back_rebind( LDAP *ld, LDAP_CONST char *url, ber_tag_t request,
-       ber_int_t msgid, void *params )
+meta_back_rebind(
+       LDAP                    *ld,
+       LDAP_CONST char         *url,
+       ber_tag_t               request,
+       ber_int_t               msgid,
+       void                    *params )
 {
-       struct metasingleconn   *msc = (struct metasingleconn *)params;
+       metasingleconn_t        *msc = ( metasingleconn_t * )params;
 
        return ldap_sasl_bind_s( ld, msc->msc_bound_ndn.bv_val,
                        LDAP_SASL_SIMPLE, &msc->msc_cred,
@@ -445,21 +664,23 @@ meta_back_rebind( LDAP *ld, LDAP_CONST char *url, ber_tag_t request,
  */
 int
 meta_back_op_result(
-       struct metaconn *mc,
+       metaconn_t      *mc,
        Operation       *op,
        SlapReply       *rs,
        int             candidate )
 {
+       metainfo_t              *mi = ( metainfo_t * )op->o_bd->be_private;
+
        int                     i,
                                rerr = LDAP_SUCCESS;
-       struct metasingleconn   *msc;
-       char                    *rmsg = NULL;
-       char                    *rmatch = NULL;
-       int                     free_rmsg = 0,
-                               free_rmatch = 0;
+       char                    *rmsg = NULL,
+                               *rmatch = NULL;
+       const char              *save_rmsg = NULL,
+                               *save_rmatch = NULL;
+       void                    *rmatch_ctx = NULL;
 
        if ( candidate != META_TARGET_NONE ) {
-               msc = &mc->mc_conns[ candidate ];
+               metasingleconn_t        *msc = &mc->mc_conns[ candidate ];
 
                rs->sr_err = LDAP_SUCCESS;
 
@@ -473,17 +694,20 @@ meta_back_op_result(
                         */
                        ldap_get_option( msc->msc_ld,
                                        LDAP_OPT_ERROR_STRING, &rmsg );
+                       if ( rmsg != NULL && rmsg[ 0 ] == '\0' ) {
+                               ldap_memfree( rmsg );
+                               rmsg = NULL;
+                       }
+
                        ldap_get_option( msc->msc_ld,
                                        LDAP_OPT_MATCHED_DN, &rmatch );
-                       rerr = rs->sr_err = slap_map_api2result( rs );
-
-                       if ( rmsg ) {
-                               free_rmsg = 1;
-                       }
-                       if ( rmatch ) {
-                               free_rmatch = 1;
+                       if ( rmatch != NULL && rmatch[ 0 ] == '\0' ) {
+                               ldap_memfree( rmatch );
+                               rmatch = NULL;
                        }
 
+                       rerr = rs->sr_err = slap_map_api2result( rs );
+
                        Debug(LDAP_DEBUG_ANY,
                                        "==> meta_back_op_result: target"
                                        " <%d> sending msg \"%s\""
@@ -493,9 +717,10 @@ meta_back_op_result(
                }
 
        } else {
-               for ( i = 0, msc = &mc->mc_conns[ 0 ]; !META_LAST( msc ); ++i, ++msc ) {
-                       char    *msg = NULL;
-                       char    *match = NULL;
+               for ( i = 0; i < mi->mi_ntargets; i++ ) {
+                       metasingleconn_t        *msc = &mc->mc_conns[ i ];
+                       char                    *msg = NULL;
+                       char                    *match = NULL;
 
                        rs->sr_err = LDAP_SUCCESS;
 
@@ -509,8 +734,18 @@ meta_back_op_result(
                                 */
                                ldap_get_option( msc->msc_ld,
                                                LDAP_OPT_ERROR_STRING, &msg );
+                               if ( msg != NULL && msg[ 0 ] == '\0' ) {
+                                       ldap_memfree( msg );
+                                       msg = NULL;
+                               }
+
                                ldap_get_option( msc->msc_ld,
                                                LDAP_OPT_MATCHED_DN, &match );
+                               if ( match != NULL && match[ 0 ] == '\0' ) {
+                                       ldap_memfree( match );
+                                       match = NULL;
+                               }
+
                                rs->sr_err = slap_map_api2result( rs );
        
                                Debug(LDAP_DEBUG_ANY,
@@ -526,44 +761,60 @@ meta_back_op_result(
                                switch ( rs->sr_err ) {
                                default:
                                        rerr = rs->sr_err;
-                                       if ( rmsg ) {
-                                               ber_memfree( rmsg );
+                                       if ( msg != NULL ) {
+                                               if ( rmsg ) {
+                                                       ldap_memfree( rmsg );
+                                               }
+                                               rmsg = msg;
+                                               msg = NULL;
                                        }
-                                       rmsg = msg;
-                                       free_rmsg = 1;
-                                       msg = NULL;
-                                       if ( rmatch ) {
-                                               ber_memfree( rmatch );
+                                       if ( match != NULL ) {
+                                               if ( rmatch ) {
+                                                       ldap_memfree( rmatch );
+                                               }
+                                               rmatch = match;
+                                               match = NULL;
                                        }
-                                       rmatch = match;
-                                       free_rmatch = 1;
-                                       match = NULL;
                                        break;
                                }
+
+                               if ( msg ) {
+                                       ldap_memfree( msg );
+                               }
        
-                               /* better test the pointers before freeing? */
                                if ( match ) {
-                                       free( match );
-                               }
-                               if ( msg ) {
-                                       free( msg );
+                                       ldap_memfree( match );
                                }
                        }
                }
        }
        
        rs->sr_err = rerr;
-       rs->sr_text = rmsg;
-       rs->sr_matched = rmatch;
+       if ( rmsg != NULL ) {
+               save_rmsg = rs->sr_text;
+               rs->sr_text = rmsg;
+       }
+       if ( rmatch != NULL ) {
+               struct berval   dn, pdn;
+
+               ber_str2bv( rmatch, 0, 0, &dn );
+               if ( dnPretty( NULL, &dn, &pdn, op->o_tmpmemctx ) == LDAP_SUCCESS ) {
+                       ldap_memfree( rmatch );
+                       rmatch_ctx = op->o_tmpmemctx;
+                       rmatch = pdn.bv_val;
+               }
+               save_rmatch = rs->sr_matched;
+               rs->sr_matched = rmatch;
+       }
        send_ldap_result( op, rs );
-       if ( free_rmsg ) {
+       if ( rmsg != NULL ) {
                ber_memfree( rmsg );
+               rs->sr_text = save_rmsg;
        }
-       if ( free_rmatch ) {
-               ber_memfree( rmatch );
+       if ( rmatch != NULL ) {
+               ber_memfree_x( rmatch, rmatch_ctx );
+               rs->sr_matched = save_rmatch;
        }
-       rs->sr_text = NULL;
-       rs->sr_matched = NULL;
 
        return ( ( rerr == LDAP_SUCCESS ) ? 0 : -1 );
 }