]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-meta/compare.c
Do not return pointers into BerElement we do not own
[openldap] / servers / slapd / back-meta / compare.c
index 9b0e9a43f70fcd26aeeb27005c6e7f4e176fdb73..b4131c7557c667916df4003b218e67d0362cd18e 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright 1998-2001 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  *
  * Copyright 2001, Pierangelo Masarati, All rights reserved. <ando@sys-net.it>
@@ -80,21 +80,24 @@ meta_back_compare(
                Backend                 *be,
                Connection              *conn,
                Operation               *op,
-               const char              *dn,
-               const char              *ndn,
+               struct berval           *dn,
+               struct berval           *ndn,
                AttributeAssertion      *ava
 )
 {
        struct metainfo *li = ( struct metainfo * )be->be_private;
        struct metaconn *lc;
-       struct metasingleconn **lsc;
+       struct metasingleconn *lsc;
        char *match = NULL, *err = NULL, *mmatch = NULL;
-       int candidates = 0, last = 0, i, count, rc, cres, rres;
+       int candidates = 0, last = 0, i, count, rc;
+               int cres = LDAP_SUCCESS, rres = LDAP_SUCCESS;
        int *msgid;
 
        lc = meta_back_getconn( li, conn, op, META_OP_ALLOW_MULTIPLE,
                        ndn, NULL );
        if ( !lc || !meta_back_dobind( lc, op ) ) {
+               send_ldap_result( conn, op, LDAP_OTHER,
+                               NULL, NULL, NULL, NULL );
                return -1;
        }
 
@@ -106,12 +109,13 @@ meta_back_compare(
        /*
         * start an asynchronous compare for each candidate target
         */
-       for ( i = 0, lsc = lc->conns; lsc[ 0 ] != NULL; ++i, ++lsc ) {
+       for ( i = 0, lsc = lc->conns; !META_LAST(lsc); ++i, ++lsc ) {
                char *mdn = NULL;
-               char *mapped_attr = ava->aa_desc->ad_cname->bv_val;
-               char *mapped_value = ava->aa_value->bv_val;
+               struct berval mapped_attr = ava->aa_desc->ad_cname;
+               struct berval mapped_value = ava->aa_value;
 
-               if ( lsc[ 0 ]->candidate != META_CANDIDATE ) {
+               if ( lsc->candidate != META_CANDIDATE ) {
+                       msgid[ i ] = -1;
                        continue;
                }
 
@@ -119,31 +123,31 @@ meta_back_compare(
                 * Rewrite the compare dn, if needed
                 */
                switch ( rewrite_session( li->targets[ i ]->rwinfo,
-                                       "compareDn", dn, conn, &mdn ) ) {
+                                       "compareDn", 
+                                       dn->bv_val, conn, &mdn ) ) {
                case REWRITE_REGEXEC_OK:
                        if ( mdn == NULL ) {
-                               mdn = ( char * )dn;
+                               mdn = ( char * )dn->bv_val;
                        }
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                                       "[rw] compareDn: \"%s\" -> \"%s\"\n",
-                                       dn, mdn ));
+                       LDAP_LOG( BACK_META, DETAIL1,
+                               "[rw] compareDn: \"%s\" -> \"%s\"\n", dn->bv_val, mdn, 0 );
 #else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ARGS,
                                        "rw> compareDn: \"%s\" -> \"%s\"\n%s",
-                                       dn, mdn, "" );
+                                       dn->bv_val, mdn, "" );
 #endif /* !NEW_LOGGING */
                        break;
                
                case REWRITE_REGEXEC_UNWILLING:
                        send_ldap_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
-                                       NULL, "Unwilling to perform",
+                                       NULL, "Operation not allowed",
                                        NULL, NULL );
                        return -1;
                        
                case REWRITE_REGEXEC_ERR:
-                       send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
-                                       NULL, "Operations error",
+                       send_ldap_result( conn, op,  LDAP_OTHER,
+                                       NULL, "Rewrite error",
                                        NULL, NULL );
                        return -1;
                }
@@ -151,23 +155,22 @@ meta_back_compare(
                /*
                 * if attr is objectClass, try to remap the value
                 */
-               if ( ava->aa_desc->ad_type->sat_oid 
-                       == slap_schema.si_ad_objectClass->ad_type->sat_oid ) {
-                       mapped_value = ldap_back_map( &li->targets[ i ]->oc_map,
-                                       ava->aa_value->bv_val, 0 );
+               if ( ava->aa_desc == slap_schema.si_ad_objectClass ) {
+                       ldap_back_map( &li->targets[ i ]->oc_map,
+                                       &ava->aa_value, &mapped_value,
+                                       BACKLDAP_MAP );
 
-                       if ( mapped_value == NULL ) {
-                               lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                       if ( mapped_value.bv_val == NULL || mapped_value.bv_val[0] == '\0' ) {
                                continue;
                        }
                /*
                 * else try to remap the attribute
                 */
                } else {
-                       mapped_attr = ldap_back_map( &li->targets[ i ]->at_map,
-                               ava->aa_desc->ad_cname->bv_val, 0 );
-                       if ( mapped_attr == NULL ) {
-                               lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                       ldap_back_map( &li->targets[ i ]->at_map,
+                               &ava->aa_desc->ad_cname, &mapped_attr,
+                               BACKLDAP_MAP );
+                       if ( mapped_attr.bv_val == NULL || mapped_attr.bv_val[0] == '\0' ) {
                                continue;
                        }
                }
@@ -177,21 +180,20 @@ meta_back_compare(
                 * that returns determines the result; a constraint on unicity
                 * of the result ought to be enforced
                 */
-               msgid[ i ] = ldap_compare( lc->conns[ i ]->ld, mdn,
-                               mapped_attr, mapped_value );
-               if ( msgid[ i ] == -1 ) {
-                       lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
-                       continue;
-               }
-
-               if ( mdn != dn ) {
+               msgid[ i ] = ldap_compare( lc->conns[ i ].ld, mdn,
+                               mapped_attr.bv_val, mapped_value.bv_val );
+               if ( mdn != dn->bv_val ) {
                        free( mdn );
                }
-               if ( mapped_attr != ava->aa_desc->ad_cname->bv_val ) {
-                       free( mapped_attr );
+               if ( mapped_attr.bv_val != ava->aa_desc->ad_cname.bv_val ) {
+                       free( mapped_attr.bv_val );
                }
-               if ( mapped_value != ava->aa_value->bv_val ) {
-                       free( mapped_value );
+               if ( mapped_value.bv_val != ava->aa_value.bv_val ) {
+                       free( mapped_value.bv_val );
+               }
+
+               if ( msgid[ i ] == -1 ) {
+                       continue;
                }
 
                ++candidates;
@@ -205,15 +207,15 @@ meta_back_compare(
                /*
                 * FIXME: should we check for abandon?
                 */
-               for ( i = 0, lsc = lc->conns; lsc[ 0 ] != NULL; lsc++, i++ ) {
+               for ( i = 0, lsc = lc->conns; !META_LAST(lsc); lsc++, i++ ) {
                        int lrc;
                        LDAPMessage *res = NULL;
 
-                       if ( lsc[ 0 ]->candidate != META_CANDIDATE ) {
+                       if ( msgid[ i ] == -1 ) {
                                continue;
                        }
 
-                       lrc = ldap_result( lsc[ 0 ]->ld, msgid[ i ],
+                       lrc = ldap_result( lsc->ld, msgid[ i ],
                                        0, NULL, &res );
 
                        if ( lrc == 0 ) {
@@ -226,13 +228,12 @@ meta_back_compare(
                                continue;
                        } else if ( lrc == LDAP_RES_COMPARE ) {
                                if ( count > 0 ) {
-                                       rres = LDAP_OPERATIONS_ERROR;
+                                       rres = LDAP_OTHER;
                                        rc = -1;
                                        goto finish;
                                }
                                
-                               cres = ldap_result2error( lsc[ 0 ]->ld,
-                                               res, 1 );
+                               cres = ldap_result2error( lsc->ld, res, 1 );
                                switch ( cres ) {
                                case LDAP_COMPARE_TRUE:
                                case LDAP_COMPARE_FALSE:
@@ -242,7 +243,7 @@ meta_back_compare(
                                         * sending to cache ...
                                         */
                                        if ( li->cache.ttl != META_DNCACHE_DISABLED ) {
-                                               ( void )meta_dncache_update_entry( &li->cache, ch_strdup( ndn ), i );
+                                               ( void )meta_dncache_update_entry( &li->cache, ndn, i );
                                        }
 
                                        count++;
@@ -255,22 +256,23 @@ meta_back_compare(
                                        if ( err != NULL ) {
                                                free( err );
                                        }
-                                       ldap_get_option( lsc[ 0 ]->ld,
+                                       ldap_get_option( lsc->ld,
                                                LDAP_OPT_ERROR_STRING, &err );
 
                                        if ( match != NULL ) {
                                                free( match );
                                        }
-                                       ldap_get_option( lsc[ 0 ]->ld,
+                                       ldap_get_option( lsc->ld,
                                                LDAP_OPT_MATCHED_DN, &match );
                                        
                                        last = i;
                                        break;
                                }
-                               lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                               msgid[ i ] = -1;
                                --candidates;
+
                        } else {
-                               lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                               msgid[ i ] = -1;
                                --candidates;
                                if ( res ) {
                                        ldap_msgfree( res );
@@ -280,7 +282,7 @@ meta_back_compare(
                }
        }
 
-finish:
+finish:;
 
        /*
         * Rewrite the matched portion of the search base, if required
@@ -312,9 +314,8 @@ finish:
                                mmatch = ( char * )match;
                        }
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                                       "[rw] matchedDn: \"%s\" -> \"%s\"\n",
-                                       match, mmatch ));
+                       LDAP_LOG( BACK_META, DETAIL1,
+                               "[rw] matchedDn: \"%s\" -> \"%s\"\n", match, mmatch, 0 );
 #else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ARGS, "rw> matchedDn:"
                                        " \"%s\" -> \"%s\"\n%s",
@@ -325,14 +326,14 @@ finish:
                
                case REWRITE_REGEXEC_UNWILLING:
                        send_ldap_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
-                                       NULL, "Unwilling to perform",
+                                       NULL, "Operation not allowed",
                                        NULL, NULL );
                        rc = -1;
                        goto cleanup;
                        
                case REWRITE_REGEXEC_ERR:
-                       send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
-                                       NULL, "Operations error",
+                       send_ldap_result( conn, op, LDAP_OTHER,
+                                       NULL, "Rewrite error",
                                        NULL, NULL );
                        rc = -1;
                        goto cleanup;
@@ -341,7 +342,7 @@ finish:
 
        send_ldap_result( conn, op, rres, mmatch, err, NULL, NULL );
 
-cleanup:
+cleanup:;
        if ( match != NULL ) {
                if ( mmatch != match ) {
                        free( mmatch );