]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-meta/search.c
use more appropriate error code
[openldap] / servers / slapd / back-meta / search.c
index 699f6e8b0643bc35773d374c9daeeecfc8a231d0..0f6bce2dc73952084d09310812f6bb037c67de99 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright 1998-2001 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  *
  * Copyright 2001, Pierangelo Masarati, All rights reserved. <ando@sys-net.it>
 #include "../back-ldap/back-ldap.h"
 #include "back-meta.h"
 #include "ldap_pvt.h"
+#undef ldap_debug      /* silence a warning in ldap-int.h */
+#include "ldap_log.h"
 #include "../../../libraries/libldap/ldap-int.h"
 
-static void
+static int
 meta_send_entry(
                Backend         *be,
                Operation       *op,
@@ -114,13 +116,14 @@ meta_back_search(
 {
        struct metainfo *li = ( struct metainfo * )be->be_private;
        struct metaconn *lc;
-       struct metasingleconn **lsc;
-       struct timeval  tv;
+       struct metasingleconn *lsc;
+       struct timeval  tv = { 0, 0 };
        LDAPMessage     *res, *e;
        int     count, rc = 0, *msgid, sres = LDAP_NO_SUCH_OBJECT;
        char *match = NULL, *err = NULL;
        char *mbase = NULL, *mmatch = NULL;
        struct berval mfilter;
+       BerVarray v2refs = NULL;
                
        int i, last = 0, candidates = 0, op_type;
        struct slap_limits_set *limit = NULL;
@@ -132,6 +135,12 @@ meta_back_search(
                op_type = META_OP_ALLOW_MULTIPLE;
        }
        
+       /*
+        * controls are set in ldap_back_dobind()
+        * 
+        * FIXME: in case of values return filter, we might want
+        * to map attrs and maybe rewrite value
+        */
        lc = meta_back_getconn( li, conn, op, op_type, nbase, NULL );
        if ( !lc || !meta_back_dobind( lc, op ) ) {
                return -1;
@@ -142,8 +151,8 @@ meta_back_search(
         */
        msgid = ch_calloc( sizeof( int ), li->ntargets );
        if ( msgid == NULL ) {
-               send_search_result( conn, op, LDAP_OPERATIONS_ERROR,
-                               NULL, NULL, NULL, NULL, 0 );
+               send_ldap_result( conn, op, LDAP_OTHER,
+                               NULL, NULL, NULL, NULL );
                return -1;
        }
        
@@ -158,13 +167,13 @@ meta_back_search(
        /* if requested limit higher than hard limit, abort */
        if ( !isroot && tlimit > limit->lms_t_hard ) {
                /* no hard limit means use soft instead */
-               if ( limit->lms_t_hard == 0 ) {
+               if ( limit->lms_t_hard == 0 && tlimit > limit->lms_t_soft ) {
                        tlimit = limit->lms_t_soft;
                        
                /* positive hard limit means abort */
                } else if ( limit->lms_t_hard > 0 ) {
-                       send_search_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
-                                       NULL, NULL, NULL, NULL, 0 );
+                       send_ldap_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
+                                       NULL, NULL, NULL, NULL );
                        rc = 0;
                        goto finish;
                }
@@ -176,13 +185,13 @@ meta_back_search(
        /* if requested limit higher than hard limit, abort */
        if ( !isroot && slimit > limit->lms_s_hard ) {
                /* no hard limit means use soft instead */
-               if ( limit->lms_s_hard == 0 ) {
+               if ( limit->lms_s_hard == 0 && slimit > limit->lms_s_soft ) {
                        slimit = limit->lms_s_soft;
                        
                /* positive hard limit means abort */
                } else if ( limit->lms_s_hard > 0 ) {
-                       send_search_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
-                                       NULL, NULL, NULL, NULL, 0 );
+                       send_ldap_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
+                                       NULL, NULL, NULL, NULL );
                        rc = 0;
                        goto finish;
                }
@@ -193,26 +202,27 @@ meta_back_search(
        /*
         * Inits searches
         */
-       for ( i = 0, lsc = lc->conns; lsc[ 0 ] != NULL; ++i, ++lsc ) {
+       for ( i = 0, lsc = lc->conns; !META_LAST(lsc); ++i, ++lsc ) {
                char    *realbase = ( char * )base->bv_val;
                int     realscope = scope;
-               int     suffixlen;
+               ber_len_t suffixlen;
                char    *mapped_filter, **mapped_attrs;
                
-               if ( lsc[ 0 ]->candidate != META_CANDIDATE ) {
+               if ( lsc->candidate != META_CANDIDATE ) {
                        continue;
                }
 
+               /* should we check return values? */
                if ( deref != -1 ) {
-                       ldap_set_option( lsc[ 0 ]->ld, LDAP_OPT_DEREF,
+                       ldap_set_option( lsc->ld, LDAP_OPT_DEREF,
                                        ( void * )&deref);
                }
                if ( tlimit != -1 ) {
-                       ldap_set_option( lsc[ 0 ]->ld, LDAP_OPT_TIMELIMIT,
+                       ldap_set_option( lsc->ld, LDAP_OPT_TIMELIMIT,
                                        ( void * )&tlimit);
                }
                if ( slimit != -1 ) {
-                       ldap_set_option( lsc[ 0 ]->ld, LDAP_OPT_SIZELIMIT,
+                       ldap_set_option( lsc->ld, LDAP_OPT_SIZELIMIT,
                                        ( void * )&slimit);
                }
 
@@ -236,7 +246,7 @@ meta_back_search(
                                        /*
                                         * this target is no longer candidate
                                         */
-                                       lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                                       lsc->candidate = META_NOT_CANDIDATE;
                                        continue;
                                }
                                break;
@@ -259,7 +269,7 @@ meta_back_search(
                                /*
                                 * this target is no longer candidate
                                 */
-                               lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                               lsc->candidate = META_NOT_CANDIDATE;
                                continue;
                        }
 
@@ -276,9 +286,8 @@ meta_back_search(
                        mbase = realbase;
                }
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                               "[rw] searchBase: \"%s\" -> \"%s\"\n",
-                               base->bv_val, mbase ));
+               LDAP_LOG( BACK_META, DETAIL1,
+                       "[rw] searchBase: \"%s\" -> \"%s\"\n", base->bv_val, mbase, 0 );
 #else /* !NEW_LOGGING */
                Debug( LDAP_DEBUG_ARGS, "rw> searchBase: \"%s\" -> \"%s\"\n%s",
                                base->bv_val, mbase, "" );
@@ -287,15 +296,13 @@ meta_back_search(
                
                case REWRITE_REGEXEC_UNWILLING:
                        send_ldap_result( conn, op, LDAP_UNWILLING_TO_PERFORM,
-                                       NULL, "Unwilling to perform",
-                                       NULL, NULL );
+                                       NULL, NULL, NULL, NULL );
                        rc = -1;
                        goto finish;
 
                case REWRITE_REGEXEC_ERR:
-                       send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
-                                       NULL, "Operations error",
-                                       NULL, NULL );
+                       send_ldap_result( conn, op, LDAP_OTHER,
+                                       NULL, NULL, NULL, NULL );
                        rc = -1;
                        goto finish;
                }
@@ -316,9 +323,9 @@ meta_back_search(
                                mfilter = *filterstr;
                        }
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                                       "[rw] searchFilter: \"%s\" -> \"%s\"\n",
-                                       filterstr->bv_val, mfilter.bv_val ));
+                       LDAP_LOG( BACK_META, DETAIL1,
+                               "[rw] searchFilter: \"%s\" -> \"%s\"\n",
+                               filterstr->bv_val, mfilter.bv_val, 0 );
 #else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ARGS,
                                "rw> searchFilter: \"%s\" -> \"%s\"\n%s",
@@ -333,7 +340,7 @@ meta_back_search(
                        goto finish;
 
                case REWRITE_REGEXEC_ERR:
-                       send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
+                       send_ldap_result( conn, op, LDAP_OTHER,
                                        NULL, NULL, NULL, NULL );
                        rc = -1;
                        goto finish;
@@ -347,7 +354,9 @@ meta_back_search(
                if ( mapped_filter == NULL ) {
                        mapped_filter = ( char * )mfilter.bv_val;
                } else {
-                       ber_memfree( mfilter.bv_val );
+                       if ( mfilter.bv_val != filterstr->bv_val ) {
+                               free( mfilter.bv_val );
+                       }
                }
                mfilter.bv_val = NULL;
                mfilter.bv_len = 0;
@@ -369,10 +378,10 @@ meta_back_search(
                /*
                 * Starts the search
                 */
-               msgid[ i ] = ldap_search( lsc[ 0 ]->ld, mbase, realscope,
+               msgid[ i ] = ldap_search( lsc->ld, mbase, realscope,
                                mapped_filter, mapped_attrs, attrsonly ); 
                if ( msgid[ i ] == -1 ) {
-                       lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                       lsc->candidate = META_NOT_CANDIDATE;
                        continue;
                }
 
@@ -400,22 +409,23 @@ meta_back_search(
 
        /*
         * In case there are no candidates, no cycle takes place...
+        *
+        * FIXME: we might use a queue, to balance the load 
+        * among the candidates
         */
        for ( count = 0, rc = 0; candidates > 0; ) {
                int ab, gotit = 0;
 
                /* check for abandon */
-               ldap_pvt_thread_mutex_lock( &op->o_abandonmutex );
                ab = op->o_abandon;
-               ldap_pvt_thread_mutex_unlock( &op->o_abandonmutex );
 
-               for ( i = 0, lsc = lc->conns; lsc[ 0 ] != NULL; lsc++, i++ ) {
-                       if ( lsc[ 0 ]->candidate != META_CANDIDATE ) {
+               for ( i = 0, lsc = lc->conns; !META_LAST(lsc); lsc++, i++ ) {
+                       if ( lsc->candidate != META_CANDIDATE ) {
                                continue;
                        }
                        
                        if ( ab ) {
-                               ldap_abandon( lsc[ 0 ]->ld, msgid[ i ] );
+                               ldap_abandon( lsc->ld, msgid[ i ] );
                                rc = 0;
                                break;
                        }
@@ -423,55 +433,114 @@ meta_back_search(
                        if ( slimit > 0 && count == slimit ) {
                                send_search_result( conn, op,
                                                LDAP_SIZELIMIT_EXCEEDED,
-                                               NULL, NULL, NULL, NULL, count );
+                                               NULL, NULL, v2refs, NULL, 
+                                               count );
                                goto finish;
                        }
 
-                       rc = ldap_result( lsc[ 0 ]->ld, msgid[ i ],
+                       /*
+                        * FIXME: handle time limit as well?
+                        * Note that target servers are likely 
+                        * to handle it, so at some time we'll
+                        * get a LDAP_TIMELIMIT_EXCEEDED from
+                        * one of them ...
+                        */
+                       rc = ldap_result( lsc->ld, msgid[ i ],
                                        0, &tv, &res );
 
                        if ( rc == 0 ) {
                                continue;
+
                        } else if ( rc == -1 ) {
                                /* something REALLY bad happened! */
                                ( void )meta_clear_unused_candidates( li,
                                                lc, -1, 0 );
-                               send_search_result( conn, op,
-                                               LDAP_OPERATIONS_ERROR,
-                                               "", "", NULL, NULL, count );
+                               send_search_result( conn, op, LDAP_OTHER,
+                                               NULL, NULL, v2refs, NULL, 
+                                               count );
                                
                                /* anything else needs be done? */
                                goto finish;
+
                        } else if ( rc == LDAP_RES_SEARCH_ENTRY ) {
-                               e = ldap_first_entry( lsc[ 0 ]->ld, res );
-                               meta_send_entry(be, op, lc, i, e, attrs,
-                                               attrsonly);
-                               count++;
+                               e = ldap_first_entry( lsc->ld, res );
+                               if ( meta_send_entry( be, op, lc, i, e, attrs,
+                                               attrsonly ) == LDAP_SUCCESS ) {
+                                       count++;
+                               }
                                ldap_msgfree( res );
                                gotit = 1;
+
+                       } else if ( rc == LDAP_RES_SEARCH_REFERENCE ) {
+                               char            **references = NULL;
+                               LDAPControl     **ctrls = NULL;
+                               BerVarray       refs;
+                               int             cnt;
+
+                               /*
+                                * FIXME: should we collect references
+                                * and send them alltogether at the end?
+                                */
+
+                               rc = ldap_parse_reference( lsc->ld, res,
+                                               &references, &ctrls, 1 );
+
+                               if ( rc != LDAP_SUCCESS ) {
+                                       continue;
+                               }
+
+                               if ( references == NULL ) {
+                                       continue;
+                               }
+
+                               for ( cnt = 0; references[ cnt ]; cnt++ )
+                                       /* NO OP */ ;
+                               
+                               refs = ch_calloc( cnt + 1, sizeof( struct berval ) );
+
+                               for ( cnt = 0; references[ cnt ]; cnt++ ) {
+                                       refs[ cnt ].bv_val = references[ cnt ];
+                                       refs[ cnt ].bv_len = strlen( references[ cnt ] );
+                               }
+
+                               /* ignore return value by now */
+                               ( void )send_search_reference( be, conn, op, 
+                                               NULL, refs, ctrls, &v2refs );
+
+                               /* cleanup */
+                               if ( references ) {
+                                       ldap_value_free( references );
+                                       ch_free( refs );
+                               }
+
+                               if ( ctrls ) {
+                                       ldap_controls_free( ctrls );
+                               }
+
                        } else {
-                               sres = ldap_result2error( lsc[ 0 ]->ld,
+                               sres = ldap_result2error( lsc->ld,
                                                res, 1 );
                                sres = ldap_back_map_result( sres );
                                if ( err != NULL ) {
                                        free( err );
                                }
-                               ldap_get_option( lsc[ 0 ]->ld,
+                               ldap_get_option( lsc->ld,
                                                LDAP_OPT_ERROR_STRING, &err );
                                if ( match != NULL ) {
                                        free( match );
                                }
-                               ldap_get_option( lsc[ 0 ]->ld,
+                               ldap_get_option( lsc->ld,
                                                LDAP_OPT_MATCHED_DN, &match );
 
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
-                                               "meta_back_search [%d]"
-                                               " match=\"%s\" err=\"%s\"\n",
-                                               i, match, err ));
+                               LDAP_LOG( BACK_META, ERR,
+                                       "meta_back_search [%d] "
+                                       "match=\"%s\" err=\"%s\"\n",
+                                       i, match, err );
 #else /* !NEW_LOGGING */
                                Debug( LDAP_DEBUG_ANY,
-       "=>meta_back_search [%d] match=\"%s\" err=\"%s\"\n",
+                                       "=>meta_back_search [%d] "
+                                       "match=\"%s\" err=\"%s\"\n",
                                        i, match, err );        
 #endif /* !NEW_LOGGING */
                                
@@ -482,7 +551,7 @@ meta_back_search(
                                 * When no candidates are left,
                                 * the outer cycle finishes
                                 */
-                               lsc[ 0 ]->candidate = META_NOT_CANDIDATE;
+                               lsc->candidate = META_NOT_CANDIDATE;
                                --candidates;
                        }
                }
@@ -522,9 +591,8 @@ meta_back_search(
                                mmatch = ( char * )match;
                        }
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                                       "[rw] matchedDn: \"%s\" -> \"%s\"\n",
-                                       match, mmatch ));
+                       LDAP_LOG( BACK_META, DETAIL1,
+                               "[rw] matchedDn: \"%s\" -> \"%s\"\n", match, mmatch, 0 );
 #else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ARGS, "rw> matchedDn:"
                                       " \"%s\" -> \"%s\"\n%s",
@@ -539,15 +607,24 @@ meta_back_search(
                        goto finish;
                        
                case REWRITE_REGEXEC_ERR:
-                       send_ldap_result( conn, op, LDAP_OPERATIONS_ERROR,
+                       send_ldap_result( conn, op, LDAP_OTHER,
                                        NULL, NULL, NULL, NULL );
                        rc = -1;
                        goto finish;
                }
        }
 
-       send_search_result( conn, op, sres,
-               mmatch, err, NULL, NULL, count );
+       /*
+        * In case we returned at least one entry, we return LDAP_SUCCESS
+        * otherwise, the latter error code we got
+        *
+        * FIXME: we should handle error codes and return the more 
+        * important/reasonable
+        */
+       if ( sres == LDAP_SUCCESS && v2refs ) {
+               sres = LDAP_REFERRAL;
+       }
+       send_search_result( conn, op, sres, mmatch, err, v2refs, NULL, count );
 
 finish:;
        if ( match ) {
@@ -562,13 +639,13 @@ finish:;
        }
        
        if ( msgid ) {
-               free( msgid );
+               ch_free( msgid );
        }
-       
+
        return rc;
 }
 
-static void
+static int
 meta_send_entry(
                Backend         *be,
                Operation       *op,
@@ -588,8 +665,8 @@ meta_send_entry(
        struct berval           *bv, bdn;
        const char              *text;
 
-       if ( ber_scanf( &ber, "{o{", &bdn ) == LBER_ERROR ) {
-               return;
+       if ( ber_scanf( &ber, "{m{", &bdn ) == LBER_ERROR ) {
+               return LDAP_DECODING_ERROR;
        }
 
        /*
@@ -603,26 +680,32 @@ meta_send_entry(
 
                } else {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                                       "[rw] searchResult[%d]:"
-                                       " \"%s\" -> \"%s\"\n",
-                                       target, bdn.bv_val, ent.e_name.bv_val ));
+                       LDAP_LOG( BACK_META, DETAIL1,
+                               "[rw] searchResult[%d]: \"%s\" -> \"%s\"\n",
+                               target, bdn.bv_val, ent.e_name.bv_val );
 #else /* !NEW_LOGGING */
                        Debug( LDAP_DEBUG_ARGS, "rw> searchResult[%d]: \"%s\""
                                        " -> \"%s\"\n", target, bdn.bv_val, ent.e_name.bv_val );
 #endif /* !NEW_LOGGING */
-                       free( bdn.bv_val );
-                       bdn.bv_val = NULL;
                        ent.e_name.bv_len = strlen( ent.e_name.bv_val );
                }
                break;
                
        case REWRITE_REGEXEC_ERR:
        case REWRITE_REGEXEC_UNWILLING:
-               return;
+               return LDAP_OTHER;
        }
 
-       dnNormalize2( NULL, &ent.e_name, &ent.e_nname );
+       /*
+        * Note: this may fail if the target host(s) schema differs
+        * from the one known to the meta, and a DN with unknown
+        * attributes is returned.
+        * 
+        * FIXME: should we log anything, or delegate to dnNormalize2?
+        */
+       if ( dnNormalize2( NULL, &ent.e_name, &ent.e_nname ) != LDAP_SUCCESS ) {
+               return LDAP_INVALID_DN_SYNTAX;
+       }
 
        /*
         * cache dn
@@ -638,7 +721,7 @@ meta_send_entry(
        ent.e_private = 0;
        attrp = &ent.e_attrs;
 
-       while ( ber_scanf( &ber, "{o", &a ) != LBER_ERROR ) {
+       while ( ber_scanf( &ber, "{m", &a ) != LBER_ERROR ) {
                ldap_back_map( &li->targets[ target ]->at_map, 
                                &a, &mapped, 1 );
                if ( mapped.bv_val == NULL ) {
@@ -648,6 +731,7 @@ meta_send_entry(
                if ( attr == NULL ) {
                        continue;
                }
+               attr->a_flags = 0;
                attr->a_next = 0;
                attr->a_desc = NULL;
                if ( slap_bv2ad( &mapped, &attr->a_desc, &text )
@@ -655,9 +739,8 @@ meta_send_entry(
                        if ( slap_bv2undef_ad( &mapped, &attr->a_desc, &text ) 
                                        != LDAP_SUCCESS) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "backend", LDAP_LEVEL_DETAIL1,
-                                               "slap_bv2undef_ad(%s): "
-                                               "%s\n", mapped.bv_val, text ));
+                               LDAP_LOG( BACK_META, DETAIL1,
+                                       "slap_bv2undef_ad(%s): %s\n", mapped.bv_val, text, 0 );
 #else /* !NEW_LOGGING */
                                Debug( LDAP_DEBUG_ANY,
                                                "slap_bv2undef_ad(%s): "
@@ -668,9 +751,18 @@ meta_send_entry(
                        }
                }
 
-               if ( ber_scanf( &ber, "[W]", &attr->a_vals ) == LBER_ERROR ) {
+               /* no subschemaSubentry */
+               if ( attr->a_desc == slap_schema.si_ad_subschemaSubentry ) {
+                       ch_free(attr);
+                       continue;
+               }
+
+               if ( ber_scanf( &ber, "[W]", &attr->a_vals ) == LBER_ERROR 
+                               || attr->a_vals == NULL ) {
                        attr->a_vals = &dummy;
-               } else if ( strcasecmp( mapped.bv_val, "objectClass" ) == 0 ) {
+
+               } else if ( attr->a_desc == slap_schema.si_ad_objectClass
+                               || attr->a_desc == slap_schema.si_ad_structuralObjectClass ) {
                        int i, last;
                        for ( last = 0; attr->a_vals[ last ].bv_val; ++last );
                        for ( i = 0, bv = attr->a_vals; bv->bv_val; bv++, i++ ) {
@@ -687,7 +779,7 @@ meta_send_entry(
                                        i--;
 
                                } else if ( mapped.bv_val != bv->bv_val ) {
-                                       ch_free( bv->bv_val );
+                                       free( bv->bv_val );
                                        ber_dupbv( bv, &mapped );
                                }
                        }
@@ -718,13 +810,10 @@ meta_send_entry(
                                                break;
                                        }
 #ifdef NEW_LOGGING
-                                       LDAP_LOG(( "backend",
-                                                       LDAP_LEVEL_DETAIL1,
-                                                       "[rw] searchResult on"
-                                                       " attr=%s:"
-                                                       " \"%s\" -> \"%s\"\n",
-                                       attr->a_desc->ad_type->sat_cname.bv_val,
-                                                       bv->bv_val, newval ));
+                                       LDAP_LOG( BACK_META, DETAIL1,
+                                               "[rw] searchResult on attr=%s: \"%s\" -> \"%s\"\n",
+                                               attr->a_desc->ad_type->sat_cname.bv_val,
+                                               bv->bv_val, newval );
 #else /* !NEW_LOGGING */
                                        Debug( LDAP_DEBUG_ARGS,
                                                "rw> searchResult on attr=%s:"
@@ -732,7 +821,6 @@ meta_send_entry(
                                        attr->a_desc->ad_type->sat_cname.bv_val,
                                                bv->bv_val, newval );
 #endif /* !NEW_LOGGING */
-                                       
                                        free( bv->bv_val );
                                        bv->bv_val = newval;
                                        bv->bv_len = strlen( newval );
@@ -759,17 +847,19 @@ meta_send_entry(
                attr = ent.e_attrs;
                ent.e_attrs = attr->a_next;
                if ( attr->a_vals != &dummy ) {
-                       bvarray_free( attr->a_vals );
+                       ber_bvarray_free( attr->a_vals );
                }
                free( attr );
        }
        
-       if ( ent.e_dn ) {
+       if ( ent.e_dn && ent.e_dn != bdn.bv_val ) {
                free( ent.e_dn );
        }
        if ( ent.e_ndn ) {
                free( ent.e_ndn );
        }
+
+       return LDAP_SUCCESS;
 }
 
 static int
@@ -779,8 +869,7 @@ is_one_level_rdn(
 )
 {
        for ( ; from--; ) {
-               if ( DN_SEPARATOR( rdn[ from ] ) 
-                               && ! DN_ESCAPE( rdn[ from ] - 1 ) ) {
+               if ( DN_SEPARATOR( rdn[ from ] ) ) {
                        return 0;
                }
        }