better fix: in case of error during bind, just bail out (very conservative, though)

[openldap] / servers / slapd / back-meta / unbind.c

diff --git a/servers/slapd/back-meta/unbind.c b/servers/slapd/back-meta/unbind.c
index 40350141c9db3570b59056c68b2332c6af269ad3..ed4bc96e30e82339f83857ef7ce7e01f22632b0c 100644 (file)
--- a/servers/slapd/back-meta/unbind.c
+++ b/servers/slapd/back-meta/unbind.c
@@ -24,6 +24,7 @@
 
 #include <stdio.h>
 
+#include <ac/errno.h>
 #include <ac/socket.h>
 #include <ac/string.h>
 
@@ -33,49 +34,48 @@
 
 int
 meta_back_conn_destroy(
-               Backend         *be,
-               Connection      *conn
-)
+       Backend         *be,
+       Connection      *conn )
 {
-       struct metainfo *li = ( struct metainfo * )be->be_private;
-       struct metaconn *lc,
-                       lc_curr = { 0 };
+       metainfo_t      *mi = ( metainfo_t * )be->be_private;
+       metaconn_t      *mc,
+                       mc_curr = { 0 };
+       int             i;
+
 
        Debug( LDAP_DEBUG_TRACE,
                "=>meta_back_conn_destroy: fetching conn %ld\n",
                conn->c_connid, 0, 0 );
        
-       lc_curr.mc_conn = conn;
+       mc_curr.mc_conn = conn;
        
-       ldap_pvt_thread_mutex_lock( &li->conn_mutex );
-       lc = avl_delete( &li->conntree, ( caddr_t )&lc_curr,
+       ldap_pvt_thread_mutex_lock( &mi->mi_conn_mutex );
+       mc = avl_delete( &mi->mi_conntree, ( caddr_t )&mc_curr,
                        meta_back_conn_cmp );
-       ldap_pvt_thread_mutex_unlock( &li->conn_mutex );
+       ldap_pvt_thread_mutex_unlock( &mi->mi_conn_mutex );
 
-       if ( lc ) {
-               int i;
-               
+       if ( mc ) {
                Debug( LDAP_DEBUG_TRACE,
                        "=>meta_back_conn_destroy: destroying conn %ld\n",
-                       lc->mc_conn->c_connid, 0, 0 );
+                       LDAP_BACK_PCONN_ID( mc->mc_conn ), 0, 0 );
                
-               /*
-                * Cleanup rewrite session
-                */
-               for ( i = 0; i < li->ntargets; ++i ) {
-                       if ( lc->mc_conns[ i ].msc_ld == NULL ) {
-                               continue;
-                       }
+               assert( mc->mc_refcnt == 0 );
 
-                       rewrite_session_delete( li->targets[ i ]->mt_rwmap.rwm_rw, conn );
-                       meta_clear_one_candidate( &lc->mc_conns[ i ], 1 );
+               for ( i = 0; i < mi->mi_ntargets; ++i ) {
+                       if ( mc->mc_conns[ i ].msc_ld != NULL ) {
+                               meta_clear_one_candidate( &mc->mc_conns[ i ] );
+                       }
                }
 
-               free( lc->mc_conns );
-               free( lc );
+               meta_back_conn_free( mc );
        }
 
-       /* no response to unbind */
+       /*
+        * Cleanup rewrite session
+        */
+       for ( i = 0; i < mi->mi_ntargets; ++i ) {
+               rewrite_session_delete( mi->mi_targets[ i ].mt_rwmap.rwm_rw, conn );
+       }
 
        return 0;
 }