]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-monitor/conn.c
should we touch timestamps when internally updating?
[openldap] / servers / slapd / back-monitor / conn.c
index ff65b7503b5128961f5335dc99eaea7484c9a2bc..40d0a58b91a8121f5901fde17b4f64c9a50093a9 100644 (file)
 /* conn.c - deal with connection subsystem */
-/*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* $OpenLDAP$ */
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 2001-2005 The OpenLDAP Foundation.
+ * Portions Copyright 2001-2003 Pierangelo Masarati.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
-/*
- * Copyright 2001 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
- * 
- * Copyright 2001, Pierangelo Masarati, All rights reserved. <ando@sys-net.it>
- * 
- * This work has beed deveolped for the OpenLDAP Foundation 
- * in the hope that it may be useful to the Open Source community, 
- * but WITHOUT ANY WARRANTY.
- * 
- * Permission is granted to anyone to use this software for any purpose
- * on any computer system, and to alter it and redistribute it, subject
- * to the following restrictions:
- * 
- * 1. The author and SysNet s.n.c. are not responsible for the consequences
- *    of use of this software, no matter how awful, even if they arise from
- *    flaws in it.
- * 
- * 2. The origin of this software must not be misrepresented, either by
- *    explicit claim or by omission.  Since few users ever read sources,
- *    credits should appear in the documentation.
- * 
- * 3. Altered versions must be plainly marked as such, and must not be
- *    misrepresented as being the original software.  Since few users
- *    ever read sources, credits should appear in the documentation.
- *    SysNet s.n.c. cannot be responsible for the consequences of the
- *    alterations.
- * 
- * 4. This notice may not be removed or altered.
+/* ACKNOWLEDGEMENTS:
+ * This work was initially developed by Pierangelo Masarati for inclusion
+ * in OpenLDAP Software.
  */
 
 #include "portable.h"
 
 #include <stdio.h>
+#include <ac/string.h>
 
 #include "slap.h"
+#include "lutil.h"
 #include "back-monitor.h"
 
 int
 monitor_subsys_conn_init(
-       BackendDB               *be
+       BackendDB               *be,
+       monitor_subsys_t        *ms
 )
 {
-       struct monitorinfo      *mi;
-       
-       Entry                   *e;
-       struct berval           *bv[2], val;
+       monitor_info_t  *mi;
+       Entry           *e, **ep, *e_conn;
+       monitor_entry_t *mp;
+       char            buf[ BACKMONITOR_BUFSIZE ];
+       struct berval   bv;
 
        assert( be != NULL );
 
-       mi = ( struct monitorinfo * )be->be_private;
+       mi = ( monitor_info_t * )be->be_private;
 
-       if ( monitor_cache_get( mi,
-                       monitor_subsys[SLAPD_MONITOR_CONN].mss_ndn, &e ) ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG(( "operation", LDAP_LEVEL_CRIT,
+       if ( monitor_cache_get( mi, &ms->mss_ndn, &e_conn ) ) {
+               Debug( LDAP_DEBUG_ANY,
                        "monitor_subsys_conn_init: "
-                       "unable to get entry '%s'\n",
-                       monitor_subsys[SLAPD_MONITOR_CONN].mss_ndn ));
-#else
+                       "unable to get entry \"%s\"\n",
+                       ms->mss_ndn.bv_val, 0, 0 );
+               return( -1 );
+       }
+
+       mp = ( monitor_entry_t * )e_conn->e_private;
+       mp->mp_children = NULL;
+       ep = &mp->mp_children;
+
+       /*
+        * Total conns
+        */
+       snprintf( buf, sizeof( buf ),
+               "dn: cn=Total,%s\n"
+               "objectClass: %s\n"
+               "structuralObjectClass: %s\n"
+               "cn: Total\n"
+               "creatorsName: %s\n"
+               "modifiersName: %s\n"
+               "createTimestamp: %s\n"
+               "modifyTimestamp: %s\n",
+               ms->mss_dn.bv_val,
+               mi->mi_oc_monitorCounterObject->soc_cname.bv_val,
+               mi->mi_oc_monitorCounterObject->soc_cname.bv_val,
+               mi->mi_creatorsName.bv_val,
+               mi->mi_creatorsName.bv_val,
+               mi->mi_startTime.bv_val,
+               mi->mi_startTime.bv_val );
+       
+       e = str2entry( buf );
+       if ( e == NULL ) {
                Debug( LDAP_DEBUG_ANY,
                        "monitor_subsys_conn_init: "
-                       "unable to get entry '%s'\n%s%s",
-                       monitor_subsys[SLAPD_MONITOR_CONN].mss_ndn, 
-                       "", "" );
-#endif
+                       "unable to create entry \"cn=Total,%s\"\n",
+                       ms->mss_ndn.bv_val, 0, 0 );
                return( -1 );
        }
+       
+       BER_BVSTR( &bv, "0" );
+       attr_merge_one( e, mi->mi_ad_monitorCounter, &bv, NULL );
+       
+       mp = monitor_entrypriv_create();
+       if ( mp == NULL ) {
+               return -1;
+       }
+       e->e_private = ( void * )mp;
+       mp->mp_info = ms;
+       mp->mp_flags = ms->mss_flags \
+               | MONITOR_F_SUB | MONITOR_F_PERSISTENT;
+       mp->mp_flags &= ~MONITOR_F_VOLATILE_CH;
 
-       bv[0] = &val;
-       bv[1] = NULL;
+       if ( monitor_cache_add( mi, e ) ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "monitor_subsys_conn_init: "
+                       "unable to add entry \"cn=Total,%s\"\n",
+                       ms->mss_ndn.bv_val, 0, 0 );
+               return( -1 );
+       }
 
-       monitor_cache_release( mi, e );
+       *ep = e;
+       ep = &mp->mp_next;
+       
+       /*
+        * Current conns
+        */
+       snprintf( buf, sizeof( buf ),
+               "dn: cn=Current,%s\n"
+               "objectClass: %s\n"
+               "structuralObjectClass: %s\n"
+               "cn: Current\n"
+               "creatorsName: %s\n"
+               "modifiersName: %s\n"
+               "createTimestamp: %s\n"
+               "modifyTimestamp: %s\n",
+               ms->mss_dn.bv_val,
+               mi->mi_oc_monitorCounterObject->soc_cname.bv_val,
+               mi->mi_oc_monitorCounterObject->soc_cname.bv_val,
+               mi->mi_creatorsName.bv_val,
+               mi->mi_creatorsName.bv_val,
+               mi->mi_startTime.bv_val,
+               mi->mi_startTime.bv_val );
+       
+       e = str2entry( buf );
+       if ( e == NULL ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "monitor_subsys_conn_init: "
+                       "unable to create entry \"cn=Current,%s\"\n",
+                       ms->mss_ndn.bv_val, 0, 0 );
+               return( -1 );
+       }
+       
+       BER_BVSTR( &bv, "0" );
+       attr_merge_one( e, mi->mi_ad_monitorCounter, &bv, NULL );
+       
+       mp = monitor_entrypriv_create();
+       if ( mp == NULL ) {
+               return -1;
+       }
+       e->e_private = ( void * )mp;
+       mp->mp_info = ms;
+       mp->mp_flags = ms->mss_flags \
+               | MONITOR_F_SUB | MONITOR_F_PERSISTENT;
+       mp->mp_flags &= ~MONITOR_F_VOLATILE_CH;
+
+       if ( monitor_cache_add( mi, e ) ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "monitor_subsys_conn_init: "
+                       "unable to add entry \"cn=Current,%s\"\n",
+                       ms->mss_ndn.bv_val, 0, 0 );
+               return( -1 );
+       }
+       
+       *ep = e;
+       ep = &mp->mp_next;
+
+       monitor_cache_release( mi, e_conn );
 
        return( 0 );
 }
 
 int
 monitor_subsys_conn_update(
-       struct monitorinfo      *mi,
+       Operation               *op,
        Entry                   *e
 )
 {
-       Connection              *c;
-       int                     connindex;
-       int                     nconns, nwritewaiters, nreadwaiters;
+       monitor_info_t  *mi = ( monitor_info_t * )op->o_bd->be_private;
 
-       Attribute               *a;
-       struct berval           *bv[2], val, **b = NULL;
-       char                    buf[1024];
+       long                    n = -1;
+       static struct berval    total_bv = BER_BVC( "cn=total" ),
+                               current_bv = BER_BVC( "cn=current" );
+       struct berval           rdn;
 
-       assert( mi != NULL );
-       assert( e != NULL );
+       assert( mi );
+       assert( e );
+
+       dnRdn( &e->e_nname, &rdn );
        
-       bv[0] = &val;
-       bv[1] = NULL;
-
-       nconns = nwritewaiters = nreadwaiters = 0;
-       for ( c = connection_first( &connindex );
-                       c != NULL;
-                       c = connection_next( c, &connindex ), nconns++ ) {
-               if ( c->c_writewaiter ) {
-                       nwritewaiters++;
-               }
-               if ( c->c_currentber != NULL ) {
-                       nreadwaiters++;
+       if ( dn_match( &rdn, &total_bv ) ) {
+               n = connections_nextid();
+
+       } else if ( dn_match( &rdn, &current_bv ) ) {
+               Connection      *c;
+               int             connindex;
+
+               for ( n = 0, c = connection_first( &connindex );
+                               c != NULL;
+                               n++, c = connection_next( c, &connindex ) ) {
+                       /* No Op */ ;
                }
+               connection_done( c );
        }
-       connection_done(c);
 
-#if 0
-       snprintf( buf, sizeof( buf ), "readwaiters=%d", nreadwaiters );
+       if ( n != -1 ) {
+               Attribute       *a;
+               char            buf[] = "+9223372036854775807L";
+               ber_len_t       len;
 
-       if ( ( a = attr_find( e->e_attrs, monitor_ad_desc ) ) != NULL ) {
-               for ( b = a->a_vals; b[0] != NULL; b++ ) {
-                       if ( strncmp( b[0]->bv_val, "readwaiters=",
-                                       sizeof( "readwaiters=" ) - 1 ) == 0 ) {
-                               free( b[0]->bv_val );
-                               b[0] = ber_bvstrdup( buf );
-                               break;
-                       }
+               a = attr_find( e->e_attrs, mi->mi_ad_monitorCounter );
+               if ( a == NULL ) {
+                       return( -1 );
                }
+
+               snprintf( buf, sizeof( buf ), "%ld", n );
+               len = strlen( buf );
+               if ( len > a->a_vals[ 0 ].bv_len ) {
+                       a->a_vals[ 0 ].bv_val = ber_memrealloc( a->a_vals[ 0 ].bv_val, len + 1 );
+               }
+               a->a_vals[ 0 ].bv_len = len;
+               AC_MEMCPY( a->a_vals[ 0 ].bv_val, buf, len + 1 );
+
+               /* FIXME: touch modifyTimestamp? */
        }
-       
-       if ( b == NULL || b[0] == NULL ) {
-               val.bv_val = buf;
-               val.bv_len = strlen( buf );
-               attr_merge( e, monitor_ad_desc, bv );
-       }
-#endif
 
        return( 0 );
 }
 
 static int
 conn_create(
+       monitor_info_t          *mi,
        Connection              *c,
-       Entry                   **ep
+       Entry                   **ep,
+       monitor_subsys_t        *ms
 )
 {
-       struct monitorentrypriv *mp;
+       monitor_entry_t *mp;
        struct tm               *ltm;
-       char                    buf[1024];
-       char                    buf2[22];
-       char                    buf3[22];
+       char                    buf[ BACKMONITOR_BUFSIZE ];
+       char                    buf2[ LDAP_LUTIL_GENTIME_BUFSIZE ];
+       char                    buf3[ LDAP_LUTIL_GENTIME_BUFSIZE ];
 
-       struct berval           *bv[2], val;
+       struct berval           bv;
 
        Entry                   *e;
 
+       struct tm       *ctm;
+       char            ctmbuf[ LDAP_LUTIL_GENTIME_BUFSIZE ];
+       struct tm       *mtm;
+       char            mtmbuf[ LDAP_LUTIL_GENTIME_BUFSIZE ];
+#ifdef HAVE_GMTIME_R
+       struct tm       tm_buf;
+#endif /* HAVE_GMTIME_R */
+
        assert( c != NULL );
        assert( ep != NULL );
 
+#ifndef HAVE_GMTIME_R
+       ldap_pvt_thread_mutex_lock( &gmtime_mutex );
+#endif
+#ifdef HACK_LOCAL_TIME
+# ifdef HAVE_LOCALTIME_R
+       ctm = localtime_r( &c->c_starttime, &tm_buf );
+       lutil_localtime( ctmbuf, sizeof( ctmbuf ), ctm, -timezone );
+       mtm = localtime_r( &c->c_activitytime, &tm_buf );
+       lutil_localtime( mtmbuf, sizeof( mtmbuf ), mtm, -timezone );
+# else
+       ctm = localtime( &c->c_starttime );
+       lutil_localtime( ctmbuf, sizeof( ctmbuf ), ctm, -timezone );
+       mtm = localtime( &c->c_activitytime );
+       lutil_localtime( mtmbuf, sizeof( mtmbuf ), mtm, -timezone );
+# endif /* HAVE_LOCALTIME_R */
+#else /* !HACK_LOCAL_TIME */
+# ifdef HAVE_GMTIME_R
+       ctm = gmtime_r( &c->c_starttime, &tm_buf );
+       lutil_gentime( ctmbuf, sizeof( ctmbuf ), ctm );
+       mtm = gmtime_r( &c->c_activitytime, &tm_buf );
+       lutil_gentime( mtmbuf, sizeof( mtmbuf ), mtm );
+# else
+       ctm = gmtime( &c->c_starttime );
+       lutil_gentime( ctmbuf, sizeof( ctmbuf ), ctm );
+       mtm = gmtime( &c->c_activitytime );
+       lutil_gentime( mtmbuf, sizeof( mtmbuf ), mtm );
+# endif /* HAVE_GMTIME_R */
+#endif /* !HACK_LOCAL_TIME */
+#ifndef HAVE_GMTIME_R
+       ldap_pvt_thread_mutex_unlock( &gmtime_mutex );
+#endif
+
        snprintf( buf, sizeof( buf ),
-               "dn: cn=%ld,%s\n"
-               "objectClass: top\n"
-               "objectClass: LDAPsubEntry\n"
-#ifdef SLAPD_MONITORSUBENTRY
-               "objectClass: monitorSubEntry\n"
-#else /* !SLAPD_MONITORSUBENTRY */
-               "objectClass: extensibleObject\n"
-#endif /* !SLAPD_MONITORSUBENTRY */
-               "cn: %ld\n",
-               c->c_connid, monitor_subsys[SLAPD_MONITOR_CONN].mss_dn,
-               c->c_connid );
+               "dn: cn=Connection %ld,%s\n"
+               "objectClass: %s\n"
+               "structuralObjectClass: %s\n"
+               "cn: Connection %ld\n"
+               "creatorsName: %s\n"
+               "modifiersName: %s\n"
+               "createTimestamp: %s\n"
+               "modifyTimestamp: %s\n",
+               c->c_connid, ms->mss_dn.bv_val,
+               mi->mi_oc_monitorConnection->soc_cname.bv_val,
+               mi->mi_oc_monitorConnection->soc_cname.bv_val,
+               c->c_connid,
+               mi->mi_creatorsName.bv_val,
+               mi->mi_creatorsName.bv_val,
+               ctmbuf,
+               mtmbuf );
+               
        e = str2entry( buf );
 
        if ( e == NULL) {
-#ifdef NEW_LOGGING
-               LDAP_LOG(( "operation", LDAP_LEVEL_CRIT,
-                       "monitor_subsys_conn_create: "
-                       "unable to create entry "
-                       "'cn=%ld,%s' entry\n",
-                       c->c_connid, 
-                       monitor_subsys[SLAPD_MONITOR_CONN].mss_dn ));
-#else
                Debug( LDAP_DEBUG_ANY,
                        "monitor_subsys_conn_create: "
                        "unable to create entry "
-                       "'cn=%ld,%s' entry\n%s",
+                       "\"cn=Connection %ld,%s\" entry\n",
                        c->c_connid, 
-                       monitor_subsys[SLAPD_MONITOR_CONN].mss_dn, "" );
-#endif
+                       ms->mss_dn.bv_val, 0 );
                return( -1 );
        }
 
+#ifndef HAVE_GMTIME_R
        ldap_pvt_thread_mutex_lock( &gmtime_mutex );
-       
+#endif
+
+#ifdef HAVE_GMTIME_R
+       ltm = gmtime_r( &c->c_starttime, &tm_buf );
+#else
        ltm = gmtime( &c->c_starttime );
-       strftime( buf2, sizeof(buf2), "%Y%m%d%H%M%SZ", ltm );
-                       
+#endif
+       lutil_gentime( buf2, sizeof( buf2 ), ltm );
+
+#ifdef HAVE_GMTIME_R
+       ltm = gmtime_r( &c->c_activitytime, &tm_buf );
+#else
        ltm = gmtime( &c->c_activitytime );
-       strftime( buf3, sizeof(buf2), "%Y%m%d%H%M%SZ", ltm );
-                       
+#endif
+       lutil_gentime( buf3, sizeof( buf3 ), ltm );
+
+#ifndef HAVE_GMTIME_R
        ldap_pvt_thread_mutex_unlock( &gmtime_mutex );
+#endif /* HAVE_GMTIME_R */
 
+       /* monitored info */
        sprintf( buf,
-               "%ld : %ld "
+               "%ld "
+               ": %ld "
                ": %ld/%ld/%ld/%ld "
                ": %ld/%ld/%ld "
                ": %s%s%s%s%s%s "
-               ": %s : %s : %s "
-               ": %s : %s : %s : %s",
+               ": %s "
+               ": %s "
+               ": %s "
+               ": %s "
+               ": %s "
+               ": %s "
+               ": %s",
                c->c_connid,
                (long) c->c_protocol,
                c->c_n_ops_received, c->c_n_ops_executing,
-               c->c_n_ops_pending, c->c_n_ops_completed,
+                       c->c_n_ops_pending, c->c_n_ops_completed,
                
                /* add low-level counters here */
                c->c_n_get, c->c_n_read, c->c_n_write,
                
                c->c_currentber ? "r" : "",
                c->c_writewaiter ? "w" : "",
-               c->c_ops != NULL ? "x" : "",
-               c->c_pending_ops != NULL ? "p" : "",
+               LDAP_STAILQ_EMPTY( &c->c_ops ) ? "" : "x",
+               LDAP_STAILQ_EMPTY( &c->c_pending_ops ) ? "" : "p",
                connection_state2str( c->c_conn_state ),
                c->c_sasl_bind_in_progress ? "S" : "",
                
-               c->c_cdn ? c->c_cdn : SLAPD_ANONYMOUS,
+               c->c_dn.bv_len ? c->c_dn.bv_val : SLAPD_ANONYMOUS,
                
-               c->c_listener_url,
-               c->c_peer_domain,
-               c->c_peer_name,
-               c->c_sock_name,
+               c->c_listener_url.bv_val,
+               c->c_peer_domain.bv_val,
+               c->c_peer_name.bv_val,
+               c->c_sock_name.bv_val,
                
                buf2,
                buf3
                );
 
-       bv[0] = &val;
-       bv[1] = NULL;
+       bv.bv_val = buf;
+       bv.bv_len = strlen( buf );
+       attr_merge_one( e, mi->mi_ad_monitoredInfo, &bv, NULL );
+
+       /* connection number */
+       snprintf( buf, sizeof( buf ), "%ld", c->c_connid );
+       bv.bv_val = buf;
+       bv.bv_len = strlen( buf );
+       attr_merge_one( e, mi->mi_ad_monitorConnectionNumber, &bv, NULL );
+
+       /* authz DN */
+       attr_merge_one( e, mi->mi_ad_monitorConnectionAuthzDN,
+                       &c->c_dn, &c->c_ndn );
 
-       val.bv_val = buf;
-       val.bv_len = strlen( buf );
-       attr_merge( e, monitor_ad_desc, bv );
+       /* local address */
+       attr_merge_one( e, mi->mi_ad_monitorConnectionLocalAddress,
+                       &c->c_sock_name, NULL );
 
-       mp = ( struct monitorentrypriv * )ch_calloc( sizeof( struct monitorentrypriv ), 1 );
+       /* peer address */
+       attr_merge_one( e, mi->mi_ad_monitorConnectionPeerAddress,
+                       &c->c_peer_name, NULL );
+
+       mp = monitor_entrypriv_create();
+       if ( mp == NULL ) {
+               return -1;
+       }
        e->e_private = ( void * )mp;
-       mp->mp_info = &monitor_subsys[ SLAPD_MONITOR_CONN ];
-       mp->mp_children = NULL;
+       mp->mp_info = ms;
        mp->mp_flags = MONITOR_F_SUB | MONITOR_F_VOLATILE;
 
        *ep = e;
@@ -252,64 +414,94 @@ conn_create(
 
 int 
 monitor_subsys_conn_create( 
-       struct monitorinfo      *mi,
-       const char              *ndn,
+       Operation               *op,
+       struct berval           *ndn,
        Entry                   *e_parent,
        Entry                   **ep
 )
 {
+       monitor_info_t  *mi = ( monitor_info_t * )op->o_bd->be_private;
+
        Connection              *c;
        int                     connindex;
-       struct monitorentrypriv *mp;
+       monitor_entry_t         *mp;
+       int                     rc = 0;
+       monitor_subsys_t        *ms;
 
        assert( mi != NULL );
        assert( e_parent != NULL );
        assert( ep != NULL );
 
+       ms = (( monitor_entry_t *)e_parent->e_private)->mp_info;
+
        *ep = NULL;
 
        if ( ndn == NULL ) {
-               Entry *e, *e_tmp = NULL;
+               Entry   *e = NULL,
+                       *e_tmp = NULL;
 
                /* create all the children of e_parent */
                for ( c = connection_first( &connindex );
                                c != NULL;
-                               c = connection_next( c, &connindex )) {
-                       if ( conn_create( c, &e ) || e == NULL ) {
-                               // error
+                               c = connection_next( c, &connindex ))
+               {
+                       if ( conn_create( mi, c, &e, ms ) || e == NULL ) {
+                               for ( ; e_tmp != NULL; ) {
+                                       mp = ( monitor_entry_t * )e_tmp->e_private;
+                                       e = mp->mp_next;
+
+                                       ch_free( mp );
+                                       e_tmp->e_private = NULL;
+                                       entry_free( e_tmp );
+
+                                       e_tmp = e;
+                               }
+                               rc = -1;
+                               break;
                        }
-                       mp = ( struct monitorentrypriv * )e->e_private;
+                       mp = ( monitor_entry_t * )e->e_private;
                        mp->mp_next = e_tmp;
                        e_tmp = e;
                }
                connection_done(c);
-
                *ep = e;
+
        } else {
-               /* create exactly the required entry */
-               char *rdn, *value;
-               unsigned long connid;
+               unsigned long           connid;
+               char                    *next = NULL;
+               static struct berval    nconn_bv = BER_BVC( "cn=connection " );
+
               
-               rdn = dn_rdn( NULL, ndn );
-               value = rdn_attr_value( rdn );
-               connid = atol( value );
-               free( value );
-               free( rdn );
+               /* create exactly the required entry;
+                * the normalized DN must start with "cn=connection ",
+                * followed by the connection id, followed by
+                * the RDN separator "," */
+               if ( ndn->bv_len <= nconn_bv.bv_len
+                               || strncmp( ndn->bv_val, nconn_bv.bv_val, nconn_bv.bv_len ) != 0 )
+               {
+                       return -1;
+               }
+               
+               connid = strtol( &ndn->bv_val[ nconn_bv.bv_len ], &next, 10 );
+               if ( next[ 0 ] != ',' ) {
+                       return -1;
+               }
 
                for ( c = connection_first( &connindex );
                                c != NULL;
                                c = connection_next( c, &connindex )) {
                        if ( c->c_connid == connid ) {
-                               if ( conn_create( c, ep ) || *ep == NULL ) {
-                                       // error
+                               if ( conn_create( mi, c, ep, ms ) || *ep == NULL ) {
+                                       rc = -1;
                                }
+
+                               break;
                        }
                }
                
                connection_done(c);
-       
        }
 
-       return( 0 );
+       return rc;
 }