should we touch timestamps when internally updating?

[openldap] / servers / slapd / back-monitor / operation.c

diff --git a/servers/slapd/back-monitor/operation.c b/servers/slapd/back-monitor/operation.c
index 090405646fb11ae59751cfce374751c929c223f6..8ce09525d3b6a4d18bab52a14c6ad8046e8c2703 100644 (file)
--- a/servers/slapd/back-monitor/operation.c
+++ b/servers/slapd/back-monitor/operation.c
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2001-2004 The OpenLDAP Foundation.
+ * Copyright 2001-2005 The OpenLDAP Foundation.
  * Portions Copyright 2001-2003 Pierangelo Masarati.
  * All rights reserved.
  *
@@ -48,20 +48,20 @@ struct monitor_ops_t {
 int
 monitor_subsys_ops_init(
        BackendDB               *be,
-       monitorsubsys           *ms
+       monitor_subsys_t        *ms
 )
 {
-       struct monitorinfo      *mi;
+       monitor_info_t  *mi;
        
-       Entry                   *e_op, **ep;
-       struct monitorentrypriv *mp;
-       char                    buf[ BACKMONITOR_BUFSIZE ];
-       int                     i;
-       struct berval           bv_zero = BER_BVC("0");
+       Entry           *e_op, **ep;
+       monitor_entry_t *mp;
+       char            buf[ BACKMONITOR_BUFSIZE ];
+       int             i;
+       struct berval   bv_zero = BER_BVC( "0" );
 
        assert( be != NULL );
 
-       mi = ( struct monitorinfo * )be->be_private;
+       mi = ( monitor_info_t * )be->be_private;
 
        if ( monitor_cache_get( mi,
                        &ms->mss_ndn, &e_op ) )
@@ -77,7 +77,7 @@ monitor_subsys_ops_init(
        attr_merge_one( e_op, mi->mi_ad_monitorOpInitiated, &bv_zero, NULL );
        attr_merge_one( e_op, mi->mi_ad_monitorOpCompleted, &bv_zero, NULL );
 
-       mp = ( struct monitorentrypriv * )e_op->e_private;
+       mp = ( monitor_entry_t * )e_op->e_private;
        mp->mp_children = NULL;
        ep = &mp->mp_children;
 
@@ -103,7 +103,7 @@ monitor_subsys_ops_init(
                                ms->mss_dn.bv_val,
                                mi->mi_oc_monitorOperation->soc_cname.bv_val,
                                mi->mi_oc_monitorOperation->soc_cname.bv_val,
-                               &monitor_op[ i ].rdn.bv_val[STRLENOF( "cn=" )],
+                               &monitor_op[ i ].rdn.bv_val[ STRLENOF( "cn=" ) ],
                                mi->mi_ad_monitorOpInitiated->ad_cname.bv_val,
                                mi->mi_ad_monitorOpCompleted->ad_cname.bv_val,
                                mi->mi_creatorsName.bv_val,
@@ -123,12 +123,13 @@ monitor_subsys_ops_init(
        
                /* steal normalized RDN */
                dnRdn( &e->e_nname, &rdn );
-               ber_dupbv( &monitor_op[i].nrdn, &rdn );
+               ber_dupbv( &monitor_op[ i ].nrdn, &rdn );
        
-               mp = ( struct monitorentrypriv * )ch_calloc( sizeof( struct monitorentrypriv ), 1 );
+               mp = monitor_entrypriv_create();
+               if ( mp == NULL ) {
+                       return -1;
+               }
                e->e_private = ( void * )mp;
-               mp->mp_next = NULL;
-               mp->mp_children = NULL;
                mp->mp_info = ms;
                mp->mp_flags = ms->mss_flags \
                        | MONITOR_F_SUB | MONITOR_F_PERSISTENT;
@@ -157,8 +158,7 @@ monitor_subsys_ops_update(
        Entry                   *e
 )
 {
-       struct monitorinfo      *mi = 
-               (struct monitorinfo *)op->o_bd->be_private;
+       monitor_info_t          *mi = ( monitor_info_t * )op->o_bd->be_private;
 
        ldap_pvt_mp_t           nInitiated,
                                nCompleted;
@@ -215,6 +215,8 @@ monitor_subsys_ops_update(
        UI2BV( &a->a_vals[ 0 ], nCompleted );
        ldap_pvt_mp_clear( nCompleted );
 
+       /* FIXME: touch modifyTimestamp? */
+
        return( 0 );
 }