should we touch timestamps when internally updating?

[openldap] / servers / slapd / back-monitor / overlay.c

diff --git a/servers/slapd/back-monitor/overlay.c b/servers/slapd/back-monitor/overlay.c
index 7610a6f8018fee80c49fe8fb085678c6023b92b1..b90fc8a2b0a0623758370bf45effe0aee8293e9c 100644 (file)
--- a/servers/slapd/back-monitor/overlay.c
+++ b/servers/slapd/back-monitor/overlay.c
@@ -1,7 +1,7 @@
 /* overlay.c - deals with overlay subsystem */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2001-2004 The OpenLDAP Foundation.
+ * Copyright 2001-2005 The OpenLDAP Foundation.
  * Portions Copyright 2001-2003 Pierangelo Masarati.
  * All rights reserved.
  *
@@ -32,18 +32,18 @@
  */
 int
 monitor_subsys_overlay_init(
-       BackendDB       *be,
-       monitorsubsys   *ms
+       BackendDB               *be,
+       monitor_subsys_t        *ms
 )
 {
-       struct monitorinfo      *mi;
+       monitor_info_t          *mi;
        Entry                   *e_overlay, **ep;
        int                     i;
-       struct monitorentrypriv *mp;
+       monitor_entry_t         *mp;
        slap_overinst           *on;
-       monitorsubsys           *ms_database;
+       monitor_subsys_t        *ms_database;
 
-       mi = ( struct monitorinfo * )be->be_private;
+       mi = ( monitor_info_t * )be->be_private;
 
        ms_database = monitor_back_get_subsys( SLAPD_MONITOR_DATABASE_NAME );
        if ( ms_database == NULL ) {
@@ -56,10 +56,7 @@ monitor_subsys_overlay_init(
                return -1;
        }
 
-       if ( monitor_cache_get( mi, 
-                               &ms->mss_ndn, 
-                               &e_overlay ) )
-       {
+       if ( monitor_cache_get( mi, &ms->mss_ndn, &e_overlay ) ) {
                Debug( LDAP_DEBUG_ANY,
                        "monitor_subsys_overlay_init: "
                        "unable to get entry \"%s\"\n",
@@ -67,7 +64,7 @@ monitor_subsys_overlay_init(
                return( -1 );
        }
 
-       mp = ( struct monitorentrypriv * )e_overlay->e_private;
+       mp = ( monitor_entry_t * )e_overlay->e_private;
        mp->mp_children = NULL;
        ep = &mp->mp_children;
 
@@ -114,23 +111,11 @@ monitor_subsys_overlay_init(
                                &bv, NULL );
 
                for ( j = 0; j < nBackendDB; j++ ) {
-                       BackendDB       *be = &backendDB[j];
+                       BackendDB       *be = &backendDB[ j ];
                        char            buf[ SLAP_LDAPDN_MAXLEN ];
                        struct berval   dn;
-                       slap_overinst   *on2;
 
-                       if ( strcmp( be->bd_info->bi_type, "over" ) != 0 ) {
-                               continue;
-                       }
-
-                       on2 = ((slap_overinfo *)be->bd_info->bi_private)->oi_list;
-                       for ( ; on2; on2 = on2->on_next ) {
-                               if ( on2->on_bi.bi_type == on->on_bi.bi_type ) {
-                                       break;
-                               }
-                       }
-
-                       if ( on2 == NULL ) {
+                       if ( !overlay_is_inst( be, on->on_bi.bi_type ) ) {
                                continue;
                        }
 
@@ -143,10 +128,11 @@ monitor_subsys_overlay_init(
                                        &dn, NULL );
                }
                
-               mp = ( struct monitorentrypriv * )ch_calloc( sizeof( struct monitorentrypriv ), 1 );
+               mp = monitor_entrypriv_create();
+               if ( mp == NULL ) {
+                       return -1;
+               }
                e->e_private = ( void * )mp;
-               mp->mp_next = NULL;
-               mp->mp_children = NULL;
                mp->mp_info = ms;
                mp->mp_flags = ms->mss_flags
                        | MONITOR_F_SUB;