]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-relay/config.c
refuse illegal values for "threads" (ITS#4433)
[openldap] / servers / slapd / back-relay / config.c
index a73eee0d6850b64073929c185bfa67a659c864bd..b8f85830115a5883ff1840862c1cc422a80f933c 100644 (file)
@@ -1,7 +1,7 @@
 /* config.c - relay backend configuration file routine */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2003-2004 The OpenLDAP Foundation.
+ * Copyright 2004-2006 The OpenLDAP Foundation.
  * Portions Copyright 2004 Pierangelo Masarati.
  * All rights reserved.
  *
 
 #include <stdio.h>
 
-#include <ac/string.h>
-#include <ac/socket.h>
-
 #include "slap.h"
 #include "back-relay.h"
-#include "lutil.h"
 
 int
 relay_back_db_config(
-    BackendDB  *be,
-    const char *fname,
-    int                lineno,
-    int                argc,
-    char       **argv
-)
+       BackendDB       *be,
+       const char      *fname,
+       int             lineno,
+       int             argc,
+       char            **argv )
 {
        relay_back_info *ri = (struct relay_back_info *)be->be_private;
 
        if ( ri == NULL ) {
-               fprintf( stderr, "%s: line %d: relay backend info is null!\n",
-                   fname, lineno );
-               return( 1 );
+               Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                       "%s: line %d: relay backend info is null.\n",
+                       fname, lineno );
+               return 1;
        }
 
        /* real naming context */
-       if ( strcasecmp( argv[0], "relay" ) == 0 ) {
+       if ( strcasecmp( argv[ 0 ], "relay" ) == 0 ) {
                struct berval   dn, ndn, pdn;
                int             rc;
-               char            *cargv[ 4 ];
+               BackendDB       *bd;
+
+               switch ( argc ) {
+               case 3:
+                       if ( strcmp( argv[ 2 ], "massage" ) != 0 ) {
+                               Log3( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                                       "%s: line %d: "
+                                       "unknown arg[#2]=\"%s\" "
+                                       "in \"relay <dn> [massage]\" line\n",
+                                       fname, lineno, argv[ 2 ] );
+                               return 1;
+                       }
+
+                       if ( be->be_nsuffix == NULL ) {
+                               Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                                       "%s: line %d: "
+                                       "\"relay\" directive "
+                                       "must appear after \"suffix\".\n",
+                                       fname, lineno );
+                               return 1;
+                       }
+
+                       if ( !BER_BVISNULL( &be->be_nsuffix[ 1 ] ) ) {
+                               Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                                       "%s: line %d: "
+                                       "relayng of multiple suffix "
+                                       "database not supported.\n",
+                                       fname, lineno );
+                               return 1;
+                       }
+                       /* fallthru */
+
+               case 2:
+                       break;
+
+               case 1:
+                       Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: missing relay suffix "
+                               "in \"relay <dn> [massage]\" line.\n",
+                               fname, lineno );
+                       return 1;
+
+               default:
+                       Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: extra cruft "
+                               "in \"relay <dn> [massage]\" line.\n",
+                               fname, lineno );
+                       return 1;
+               }
 
-               if (argc != 2) {
-                       fprintf( stderr,
-       "%s: line %d: missing relay suffix in \"relay <dn>\" line\n",
-                           fname, lineno );
-                       return( 1 );
+               if ( !BER_BVISNULL( &ri->ri_realsuffix ) ) {
+                       Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: "
+                               "relay dn already specified.\n",
+                               fname, lineno );
+                       return 1;
+               }
+
+               /* The man page says that the "relay" directive
+                * automatically instantiates slapo-rwm; I don't
+                * like this very much any more, I'd prefer to
+                * have automatic instantiation only when "massage"
+                * is specified, so one has better control on
+                * where the overlay gets instantiated, but this
+                * would break compatibility.  One can still control
+                * where the overlay is instantiated by moving
+                * around the "relay" directive, although this could
+                * make slapd.conf a bit confusing. */
+               if ( overlay_config( be, "rwm" ) ) {
+                       Log2( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: unable to install "
+                               "rwm overlay "
+                               "in \"relay <dn> [massage]\" line\n",
+                               fname, lineno );
+                       return 1;
                }
 
                dn.bv_val = argv[ 1 ];
                dn.bv_len = strlen( argv[ 1 ] );
                rc = dnPrettyNormal( NULL, &dn, &pdn, &ndn, NULL );
                if ( rc != LDAP_SUCCESS ) {
-                       fprintf( stderr, "%s: line %d: "
-                                       "relay dn \"%s\" is invalid\n",
-                                       fname, lineno, argv[ 1 ] );
+                       Log3( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: "
+                               "relay dn \"%s\" is invalid "
+                               "in \"relay <dn> [massage]\" line\n",
+                               fname, lineno, argv[ 1 ] );
                        return 1;
                }
 
-               ri->ri_bd = select_backend( &ndn, 0, 1 );
-               if ( ri->ri_bd == NULL ) {
-                       fprintf( stderr, "%s: line %d: "
-                                       "cannot find database "
-                                       "of relay dn \"%s\"\n",
-                                       fname, lineno, argv[ 1 ] );
-                       return 1;
-
-               } else if ( ri->ri_bd == be ) {
-                       fprintf( stderr, "%s: line %d: "
-                                       "relay dn \"%s\" would call self\n",
-                                       fname, lineno, pdn.bv_val );
-                       return 1;
-               } 
-
-               if ( overlay_config( be, "rewrite-remap" ) ) {
-                       fprintf( stderr, "unable to install "
-                                       "rewrite-remap overlay "
-                                       "in back-relay \"%s\" => \"%s\"\n",
-                                       be->be_suffix[0].bv_val,
-                                       ri->ri_bd->be_suffix[0].bv_val ? 
-                                       ri->ri_bd->be_suffix[0].bv_val : "<unknown>" );
-                       return 1;
+               bd = select_backend( &ndn, 0, 1 );
+               if ( bd == NULL ) {
+                       Log3( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: "
+                               "cannot find database "
+                               "of relay dn \"%s\" "
+                               "in \"relay <dn> [massage]\" line\n",
+                               fname, lineno, argv[ 1 ] );
+                       rc = 1;
+                       goto relay_done;
+
+               } else if ( bd->be_private == be->be_private ) {
+                       Log3( LDAP_DEBUG_ANY, LDAP_LEVEL_ERR,
+                               "%s: line %d: "
+                               "relay dn \"%s\" would call self "
+                               "in \"relay <dn> [massage]\" line\n",
+                               fname, lineno, pdn.bv_val );
+                       rc = 1;
+                       goto relay_done;
                }
 
-               cargv[ 0 ] = "suffixmassage";
-               cargv[ 1 ] = be->be_suffix[0].bv_val;
-               cargv[ 2 ] = ri->ri_bd->be_suffix[0].bv_val;
-               cargv[ 3 ] = NULL;
+               ri->ri_realsuffix = ndn;
 
-               if ( be->be_config( be, "back-relay", 1, 3, cargv ) ) {
-                       return 1;
+               if ( argc == 3 ) {
+                       char    *cargv[ 4 ];
+
+                       cargv[ 0 ] = "rwm-suffixmassage";
+                       cargv[ 1 ] = be->be_suffix[0].bv_val;
+                       cargv[ 2 ] = pdn.bv_val;
+                       cargv[ 3 ] = NULL;
+
+                       rc = be->be_config( be, fname, lineno, 3, cargv );
                }
 
-       /* anything else */
-       } else {
-               return SLAP_CONF_UNKNOWN;
+relay_done:;
+               ch_free( pdn.bv_val );
+
+               return rc;
        }
 
-       return 0;
+       /* anything else */
+       return SLAP_CONF_UNKNOWN;
 }