slapi_ch_bvdup() should be implemented in terms of ber_dupbv()

[openldap] / servers / slapd / back-sql / compare.c

diff --git a/servers/slapd/back-sql/compare.c b/servers/slapd/back-sql/compare.c
index d339009fb671f5db57e46cd67f776ec3ba204c35..768bab8f0afb61a94dfb8604e831a07719baaf0d 100644 (file)
--- a/servers/slapd/back-sql/compare.c
+++ b/servers/slapd/back-sql/compare.c
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1999-2005 The OpenLDAP Foundation.
+ * Copyright 1999-2006 The OpenLDAP Foundation.
  * Portions Copyright 1999 Dmitry Kovalev.
  * Portions Copyright 2002 Pierangelo Masarati.
  * All rights reserved.
@@ -34,10 +34,10 @@ backsql_compare( Operation *op, SlapReply *rs )
        SQLHDBC                 dbh = SQL_NULL_HDBC;
        Entry                   e = { 0 };
        Attribute               *a = NULL;
-       backsql_srch_info       bsi;
+       backsql_srch_info       bsi = { 0 };
        int                     rc;
-       AttributeName           anlist[2],
-                               *anlistp = NULL;
+       int                     manageDSAit = get_manageDSAit( op );
+       AttributeName           anlist[2];
 
        Debug( LDAP_DEBUG_TRACE, "==>backsql_compare()\n", 0, 0, 0 );
 
@@ -56,35 +56,53 @@ backsql_compare( Operation *op, SlapReply *rs )
        anlist[ 0 ].an_desc = op->oq_compare.rs_ava->aa_desc;
        BER_BVZERO( &anlist[ 1 ].an_name );
 
-       /*
-        * Try to get attr as dynamic operational
-        */
-       if ( !is_at_operational( op->oq_compare.rs_ava->aa_desc->ad_type ) ) {
-               anlistp = anlist;
-       }
-
        /*
         * Get the entry
         */
        bsi.bsi_e = &e;
-       rc = backsql_init_search( &bsi, &op->o_req_ndn,
-                       LDAP_SCOPE_BASE, 
-                       SLAP_NO_LIMIT, SLAP_NO_LIMIT,
-                       (time_t)(-1), NULL, dbh, op, rs, anlistp,
+       rc = backsql_init_search( &bsi, &op->o_req_ndn, LDAP_SCOPE_BASE,
+                       (time_t)(-1), NULL, dbh, op, rs, anlist,
                        ( BACKSQL_ISF_MATCHED | BACKSQL_ISF_GET_ENTRY ) );
-       if ( rc != LDAP_SUCCESS ) {
+       switch ( rc ) {
+       case LDAP_SUCCESS:
+               break;
+
+       case LDAP_REFERRAL:
+               if ( manageDSAit && !BER_BVISNULL( &bsi.bsi_e->e_nname ) &&
+                               dn_match( &op->o_req_ndn, &bsi.bsi_e->e_nname ) )
+               {
+                       rs->sr_err = LDAP_SUCCESS;
+                       rs->sr_text = NULL;
+                       rs->sr_matched = NULL;
+                       if ( rs->sr_ref ) {
+                               ber_bvarray_free( rs->sr_ref );
+                               rs->sr_ref = NULL;
+                       }
+                       break;
+               }
+               /* fallthru */
+
+       default:
                Debug( LDAP_DEBUG_TRACE, "backsql_compare(): "
                        "could not retrieve compareDN ID - no such entry\n", 
                        0, 0, 0 );
                goto return_results;
        }
 
+       if ( get_assert( op ) &&
+                       ( test_filter( op, &e, get_assertion( op ) )
+                         != LDAP_COMPARE_TRUE ) )
+       {
+               rs->sr_err = LDAP_ASSERTION_FAILED;
+               goto return_results;
+       }
+
        if ( is_at_operational( op->oq_compare.rs_ava->aa_desc->ad_type ) ) {
                SlapReply       nrs = { 0 };
+               Attribute       **ap;
 
-               e.e_attrs = NULL;
-               ber_dupbv( &e.e_name, &bsi.bsi_base_id.eid_dn );
-               ber_dupbv( &e.e_nname, &bsi.bsi_base_id.eid_ndn );
+               for ( ap = &e.e_attrs; *ap; ap = &(*ap)->a_next )
+                       ;
 
                nrs.sr_attrs = anlist;
                nrs.sr_entry = &e;
@@ -96,17 +114,7 @@ backsql_compare( Operation *op, SlapReply *rs )
                        goto return_results;
                }
                
-               e.e_attrs = nrs.sr_operational_attrs;
-
-       } else {
-               rc = backsql_id2entry( &bsi, &bsi.bsi_base_id );
-               if ( rc != LDAP_SUCCESS ) {
-                       Debug( LDAP_DEBUG_TRACE, "backsql_compare(): "
-                               "error %d in backsql_id2entry() "
-                               "- compare failed\n", rc, 0, 0 );
-                       rs->sr_err = rc;
-                       goto return_results;
-               }
+               *ap = nrs.sr_operational_attrs;
        }
 
        if ( ! access_allowed( op, &e, op->oq_compare.rs_ava->aa_desc,
@@ -166,10 +174,12 @@ return_results:;
                rs->sr_ref = NULL;
        }
 
-       (void)backsql_free_entryID( op, &bsi.bsi_base_id, 0 );
+       if ( !BER_BVISNULL( &bsi.bsi_base_id.eid_ndn ) ) {
+               (void)backsql_free_entryID( op, &bsi.bsi_base_id, 0 );
+       }
 
-       if ( bsi.bsi_e ) {
-               entry_clean( bsi.bsi_e );
+       if ( !BER_BVISNULL( &e.e_nname ) ) {
+               backsql_entry_clean( op, &e );
        }
 
        if ( bsi.bsi_attrs != NULL ) {