]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/backend.c
Preliminary checkin for new access_allowed() signature. Still need
[openldap] / servers / slapd / backend.c
index 3eb2a679d4bfeefa6dc3a3371d9dcef9968b8be1..4953724f4df08d570866cd4d06d5b3f98e306d40 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2007 The OpenLDAP Foundation.
+ * Copyright 1998-2009 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -226,9 +226,22 @@ int backend_startup_one(Backend *be, ConfigReply *cr)
                        (void)backend_set_controls( be );
 
                } else {
+                       char *type = be->bd_info->bi_type;
+                       char *suffix = "(null)";
+
+                       if ( overlay_is_over( be ) ) {
+                               slap_overinfo   *oi = (slap_overinfo *)be->bd_info->bi_private;
+                               type = oi->oi_orig->bi_type;
+                       }
+
+                       if ( be->be_suffix != NULL && !BER_BVISNULL( &be->be_suffix[0] ) ) {
+                               suffix = be->be_suffix[0].bv_val;
+                       }
+
                        Debug( LDAP_DEBUG_ANY,
-                               "backend_startup_one: bi_db_open failed! (%d)\n",
-                               rc, 0, 0 );
+                               "backend_startup_one (type=%s, suffix=\"%s\"): "
+                               "bi_db_open failed! (%d)\n",
+                               type, suffix, rc );
                }
        }
 
@@ -261,15 +274,13 @@ int backend_startup(Backend *be)
                                return rc;
                        }
                }
-               /* append global access controls */
-               acl_append( &be->be_acl, frontendDB->be_acl, -1 );
 
                return backend_startup_one( be, &cr );
        }
 
        /* open frontend, if required */
        if ( frontendDB->bd_info->bi_db_open ) {
-               rc = frontendDB->bd_info->bi_db_open( frontendDB, NULL );
+               rc = frontendDB->bd_info->bi_db_open( frontendDB, &cr );
                if ( rc != 0 ) {
                        Debug( LDAP_DEBUG_ANY,
                                "backend_startup: bi_db_open(frontend) failed! (%d)\n",
@@ -310,8 +321,6 @@ int backend_startup(Backend *be)
                                "has no suffix\n",
                                i, be->bd_info->bi_type, 0 );
                }
-               /* append global access controls */
-               acl_append( &be->be_acl, frontendDB->be_acl, -1 );
 
                rc = backend_startup_one( be, &cr );
 
@@ -349,11 +358,13 @@ int backend_shutdown( Backend *be )
                }
 
                if ( be->bd_info->bi_db_close ) {
-                       be->bd_info->bi_db_close( be, NULL );
+                       rc = be->bd_info->bi_db_close( be, NULL );
+                       if ( rc ) return rc;
                }
 
                if( be->bd_info->bi_close ) {
-                       be->bd_info->bi_close( be->bd_info );
+                       rc = be->bd_info->bi_close( be->bd_info );
+                       if ( rc ) return rc;
                }
 
                return 0;
@@ -451,7 +462,7 @@ void backend_destroy_one( BackendDB *bd, int dynamic )
        if ( !BER_BVISNULL( &bd->be_rootpw ) ) {
                free( bd->be_rootpw.bv_val );
        }
-       acl_destroy( bd->be_acl, frontendDB->be_acl );
+       acl_destroy( bd->be_acl );
        limits_destroy( bd->be_limits );
        if ( !BER_BVISNULL( &bd->be_update_ndn ) ) {
                ch_free( bd->be_update_ndn.bv_val );
@@ -502,7 +513,8 @@ int backend_destroy(void)
                if ( !BER_BVISNULL( &bd->be_rootpw ) ) {
                        free( bd->be_rootpw.bv_val );
                }
-               acl_destroy( bd->be_acl, frontendDB->be_acl );
+               acl_destroy( bd->be_acl );
+               frontendDB = NULL;
        }
 
        return 0;
@@ -585,6 +597,7 @@ backend_db_init(
        }
 
        be->bd_info = bi;
+       be->bd_self = be;
 
        be->be_def_limit = frontendDB->be_def_limit;
        be->be_dfltaccess = frontendDB->be_dfltaccess;
@@ -593,8 +606,7 @@ backend_db_init(
        be->be_requires = frontendDB->be_requires;
        be->be_ssf_set = frontendDB->be_ssf_set;
 
-       be->be_pcl_mutexp = &be->be_pcl_mutex;
-       ldap_pvt_thread_mutex_init( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_init( &be->be_pcl_mutex );
 
        /* assign a default depth limit for alias deref */
        be->be_max_deref_depth = SLAPD_DEFAULT_MAXDEREFDEPTH; 
@@ -613,6 +625,9 @@ backend_db_init(
                        nbackends--;
                }
        } else {
+               if ( !bi->bi_nDB ) {
+                       backend_init_controls( bi );
+               }
                bi->bi_nDB++;
        }
        return( be );
@@ -744,10 +759,10 @@ be_slurp_update( Operation *op )
 int
 be_shadow_update( Operation *op )
 {
-       /* This assumes that all internal ops (connid == -1) on a syncrepl
+       /* This assumes that all internal ops (connid <= -1000) on a syncrepl
         * database are syncrepl operations.
         */
-       return (( SLAP_SYNC_SHADOW( op->o_bd ) && op->o_connid == -1 ) ||
+       return ( ( SLAP_SYNC_SHADOW( op->o_bd ) && SLAPD_SYNC_IS_SYNCCONN( op->o_connid ) ) ||
                ( SLAP_SHADOW( op->o_bd ) && be_isupdate_dn( op->o_bd, &op->o_ndn ) ) );
 }
 
@@ -783,7 +798,7 @@ be_isroot_pw( Operation *op )
  * checks if binding as rootdn
  *
  * return value:
- *     SLAP_CB_CONTINUE                if not the rootdn
+ *     SLAP_CB_CONTINUE                if not the rootdn, or if rootpw is null
  *     LDAP_SUCCESS                    if rootdn & rootpw
  *     LDAP_INVALID_CREDENTIALS        if rootdn & !rootpw
  *
@@ -795,6 +810,9 @@ int
 be_rootdn_bind( Operation *op, SlapReply *rs )
 {
        int             rc;
+#ifdef SLAPD_SPASSWD
+       void    *old_authctx = NULL;
+#endif
 
        assert( op->o_tag == LDAP_REQ_BIND );
        assert( op->orb_method == LDAP_AUTH_SIMPLE );
@@ -819,14 +837,15 @@ be_rootdn_bind( Operation *op, SlapReply *rs )
        }
 
 #ifdef SLAPD_SPASSWD
-       ldap_pvt_thread_pool_setkey( op->o_threadctx, slap_sasl_bind,
-               op->o_conn->c_sasl_authctx, NULL );
+       ldap_pvt_thread_pool_setkey( op->o_threadctx, (void *)slap_sasl_bind,
+               op->o_conn->c_sasl_authctx, 0, &old_authctx, NULL );
 #endif
 
        rc = lutil_passwd( &op->o_bd->be_rootpw, &op->orb_cred, NULL, NULL );
 
 #ifdef SLAPD_SPASSWD
-       ldap_pvt_thread_pool_setkey( op->o_threadctx, slap_sasl_bind, NULL, NULL );
+       ldap_pvt_thread_pool_setkey( op->o_threadctx, (void *)slap_sasl_bind,
+               old_authctx, 0, NULL, NULL );
 #endif
 
        rc = ( rc == 0 ? LDAP_SUCCESS : LDAP_INVALID_CREDENTIALS );
@@ -941,6 +960,14 @@ backend_check_controls(
 
                        case LDAP_COMPARE_FALSE:
                                if ( !op->o_bd->be_ctrls[cid] && (*ctrls)->ldctl_iscritical ) {
+#ifdef SLAP_CONTROL_X_WHATFAILED
+                                       if ( get_whatFailed( op ) ) {
+                                               char *oids[ 2 ];
+                                               oids[ 0 ] = (*ctrls)->ldctl_oid;
+                                               oids[ 1 ] = NULL;
+                                               slap_ctrl_whatFailed_add( op, rs, oids );
+                                       }
+#endif
                                        /* RFC 4511 allows unavailableCriticalExtension to be
                                         * returned when the server is unwilling to perform
                                         * an operation extended by a recognized critical
@@ -991,13 +1018,19 @@ backend_check_restrictions(
        slap_mask_t requires;
        slap_mask_t opflag;
        slap_mask_t exopflag = 0;
-       slap_ssf_set_t *ssf;
+       slap_ssf_set_t ssfs, *ssf;
        int updateop = 0;
        int starttls = 0;
        int session = 0;
 
+       restrictops = frontendDB->be_restrictops;
+       requires = frontendDB->be_requires;
+       ssfs = frontendDB->be_ssf_set;
+       ssf = &ssfs;
+
        if ( op->o_bd ) {
-               int     rc = SLAP_CB_CONTINUE;
+               slap_ssf_t *fssf, *bssf;
+               int     rc = SLAP_CB_CONTINUE, i;
 
                if ( op->o_bd->be_chk_controls ) {
                        rc = ( *op->o_bd->be_chk_controls )( op, rs );
@@ -1011,14 +1044,13 @@ backend_check_restrictions(
                        return rs->sr_err;
                }
 
-               restrictops = op->o_bd->be_restrictops;
-               requires = op->o_bd->be_requires;
-               ssf = &op->o_bd->be_ssf_set;
-
-       } else {
-               restrictops = frontendDB->be_restrictops;
-               requires = frontendDB->be_requires;
-               ssf = &frontendDB->be_ssf_set;
+               restrictops |= op->o_bd->be_restrictops;
+               requires |= op->o_bd->be_requires;
+               bssf = &op->o_bd->be_ssf_set.sss_ssf;
+               fssf = &ssfs.sss_ssf;
+               for ( i=0; i<sizeof(ssfs)/sizeof(slap_ssf_t); i++ ) {
+                       if ( bssf[i] ) fssf[i] = bssf[i];
+               }
        }
 
        switch( op->o_tag ) {
@@ -1277,7 +1309,8 @@ backend_check_restrictions(
        }
 
        if( ( restrictops & opflag )
-                       || ( exopflag && ( restrictops & exopflag ) ) ) {
+                       || ( exopflag && ( restrictops & exopflag ) )
+                       || (( restrictops & SLAP_RESTRICT_READONLY ) && updateop )) {
                if( ( restrictops & SLAP_RESTRICT_OP_MASK) == SLAP_RESTRICT_OP_READS ) {
                        rs->sr_text = "read operations restricted";
                } else if ( restrictops & exopflag ) {
@@ -1345,8 +1378,18 @@ fe_acl_group(
        int rc;
        GroupAssertion *g;
        Backend *be = op->o_bd;
+       OpExtra         *oex;
+
+       LDAP_SLIST_FOREACH(oex, &op->o_extra, oe_next) {
+               if ( oex->oe_key == (void *)backend_group )
+                       break;
+       }
+
+       if ( oex && ((OpExtraDB *)oex)->oe_db )
+               op->o_bd = ((OpExtraDB *)oex)->oe_db;
 
-       op->o_bd = select_backend( gr_ndn, 0 );
+       if ( !op->o_bd || !SLAP_DBHIDDEN( op->o_bd ))
+               op->o_bd = select_backend( gr_ndn, 0 );
 
        for ( g = op->o_groups; g; g = g->ga_next ) {
                if ( g->ga_be != op->o_bd || g->ga_oc != group_oc ||
@@ -1481,7 +1524,7 @@ fe_acl_group(
                                                {
                                                        rc = 0;
                                                }
-                                               filter_free_x( op, filter );
+                                               filter_free_x( op, filter, 1 );
                                        }
 loopit:
                                        ldap_free_urldesc( ludp );
@@ -1552,17 +1595,23 @@ backend_group(
        AttributeDescription *group_at )
 {
        int                     rc;
-       BackendDB               *be_orig;
+       BackendDB *be_orig;
+       OpExtraDB       oex;
 
        if ( op->o_abandon ) {
                return SLAPD_ABANDON;
        }
 
+       oex.oe_db = op->o_bd;
+       oex.oe.oe_key = (void *)backend_group;
+       LDAP_SLIST_INSERT_HEAD(&op->o_extra, &oex.oe, oe_next);
+
        be_orig = op->o_bd;
        op->o_bd = frontendDB;
        rc = frontendDB->be_group( op, target, gr_ndn,
                op_ndn, group_oc, group_at );
        op->o_bd = be_orig;
+       LDAP_SLIST_REMOVE(&op->o_extra, &oex.oe, OpExtra, oe_next);
 
        return rc;
 }
@@ -1576,40 +1625,54 @@ fe_acl_attribute(
        BerVarray *vals,
        slap_access_t access )
 {
-       Entry                   *e = NULL;
        void                    *o_priv = op->o_private, *e_priv = NULL;
        Attribute               *a = NULL;
        int                     freeattr = 0, i, j, rc = LDAP_SUCCESS;
        AccessControlState      acl_state = ACL_STATE_INIT;
+       AclCheck                ak;
        Backend                 *be = op->o_bd;
+       OpExtra         *oex;
 
-       op->o_bd = select_backend( edn, 0 );
+       LDAP_SLIST_FOREACH(oex, &op->o_extra, oe_next) {
+               if ( oex->oe_key == (void *)backend_attribute )
+                       break;
+       }
+
+       if ( oex && ((OpExtraDB *)oex)->oe_db )
+               op->o_bd = ((OpExtraDB *)oex)->oe_db;
+
+       if ( !op->o_bd || !SLAP_DBHIDDEN( op->o_bd ))
+               op->o_bd = select_backend( edn, 0 );
 
        if ( target && dn_match( &target->e_nname, edn ) ) {
-               e = target;
+               ak.ak_e = target;
 
        } else {
                op->o_private = NULL;
-               rc = be_entry_get_rw( op, edn, NULL, entry_at, 0, &e );
+               ak.ak_e = NULL;
+               rc = be_entry_get_rw( op, edn, NULL, entry_at, 0, &ak.ak_e );
                e_priv = op->o_private;
                op->o_private = o_priv;
        } 
 
-       if ( e ) {
+       if ( ak.ak_e ) {
+               ak.ak_state = &acl_state;
+               ak.ak_desc = entry_at;
+               ak.ak_access = access;
                if ( entry_at == slap_schema.si_ad_entry || entry_at == slap_schema.si_ad_children ) {
                        assert( vals == NULL );
 
+                       ak.ak_val = NULL;
                        rc = LDAP_SUCCESS;
                        if ( op->o_conn && access > ACL_NONE &&
-                               access_allowed( op, e, entry_at, NULL,
-                                               access, &acl_state ) == 0 )
+                               access_allowed( op, &ak ) == 0 )
                        {
                                rc = LDAP_INSUFFICIENT_ACCESS;
                        }
                        goto freeit;
                }
 
-               a = attr_find( e->e_attrs, entry_at );
+               a = attr_find( ak.ak_e->e_attrs, entry_at );
                if ( a == NULL ) {
                        SlapReply       rs = { 0 };
                        AttributeName   anlist[ 2 ];
@@ -1622,7 +1685,7 @@ fe_acl_attribute(
                        /* NOTE: backend_operational() is also called
                         * when returning results, so it's supposed
                         * to do no harm to entries */
-                       rs.sr_entry = e;
+                       rs.sr_entry = ak.ak_e;
                        rc = backend_operational( op, &rs );
                        rs.sr_entry = NULL;
  
@@ -1641,8 +1704,7 @@ fe_acl_attribute(
                        BerVarray v;
 
                        if ( op->o_conn && access > ACL_NONE &&
-                               access_allowed( op, e, entry_at, NULL,
-                                               access, &acl_state ) == 0 )
+                               access_allowed( op, &ak ) == 0 )
                        {
                                rc = LDAP_INSUFFICIENT_ACCESS;
                                goto freeit;
@@ -1653,11 +1715,9 @@ fe_acl_attribute(
                                op->o_tmpmemctx );
                        for ( i = 0, j = 0; !BER_BVISNULL( &a->a_vals[i] ); i++ )
                        {
+                               ak.ak_val = &a->a_nvals[i];
                                if ( op->o_conn && access > ACL_NONE && 
-                                       access_allowed( op, e, entry_at,
-                                                       &a->a_nvals[i],
-                                                       access,
-                                                       &acl_state ) == 0 )
+                                       access_allowed( op, &ak ) == 0 )
                                {
                                        continue;
                                }
@@ -1678,9 +1738,9 @@ fe_acl_attribute(
                                rc = LDAP_SUCCESS;
                        }
                }
-freeit:                if ( e != target ) {
+freeit:                if ( ak.ak_e != target ) {
                        op->o_private = e_priv;
-                       be_entry_release_r( op, e );
+                       be_entry_release_r( op, ak.ak_e );
                        op->o_private = o_priv;
                }
                if ( freeattr ) {
@@ -1702,13 +1762,19 @@ backend_attribute(
        slap_access_t access )
 {
        int                     rc;
-       BackendDB               *be_orig;
+       BackendDB *be_orig;
+       OpExtraDB       oex;
+
+       oex.oe_db = op->o_bd;
+       oex.oe.oe_key = (void *)backend_attribute;
+       LDAP_SLIST_INSERT_HEAD(&op->o_extra, &oex.oe, oe_next);
 
        be_orig = op->o_bd;
        op->o_bd = frontendDB;
        rc = frontendDB->be_attribute( op, target, edn,
                entry_at, vals, access );
        op->o_bd = be_orig;
+       LDAP_SLIST_REMOVE(&op->o_extra, &oex.oe, OpExtra, oe_next);
 
        return rc;
 }
@@ -1716,48 +1782,43 @@ backend_attribute(
 int 
 backend_access(
        Operation               *op,
-       Entry                   *target,
-       struct berval           *edn,
-       AttributeDescription    *entry_at,
-       struct berval           *nval,
-       slap_access_t           access,
-       slap_mask_t             *mask )
+       AclCheck                *ak,
+       struct berval           *edn )
 {
-       Entry           *e = NULL;
        void            *o_priv = op->o_private, *e_priv = NULL;
        int             rc = LDAP_INSUFFICIENT_ACCESS;
        Backend         *be = op->o_bd;
+       int freeent = 0;
 
        /* pedantic */
        assert( op != NULL );
        assert( op->o_conn != NULL );
        assert( edn != NULL );
-       assert( access > ACL_NONE );
-
-       op->o_bd = select_backend( edn, 0 );
+       assert( ak->ak_access > ACL_NONE );
 
-       if ( target && dn_match( &target->e_nname, edn ) ) {
-               e = target;
+       if ( !op->o_bd ) {
+               op->o_bd = select_backend( edn, 0 );
+       }
 
-       } else {
+       if ( !ak->ak_e || !dn_match( &ak->ak_e->e_nname, edn ) ) {
                op->o_private = NULL;
-               rc = be_entry_get_rw( op, edn, NULL, entry_at, 0, &e );
+               rc = be_entry_get_rw( op, edn, NULL, ak->ak_desc, 0, &ak->ak_e );
+               freeent = 1;
                e_priv = op->o_private;
                op->o_private = o_priv;
        } 
 
-       if ( e ) {
+       if ( ak->ak_e ) {
                Attribute       *a = NULL;
                int             freeattr = 0;
 
-               if ( entry_at == NULL ) {
-                       entry_at = slap_schema.si_ad_entry;
+               if ( ak->ak_desc == NULL ) {
+                       ak->ak_desc = slap_schema.si_ad_entry;
                }
 
-               if ( entry_at == slap_schema.si_ad_entry || entry_at == slap_schema.si_ad_children )
+               if ( ak->ak_desc == slap_schema.si_ad_entry || ak->ak_desc == slap_schema.si_ad_children )
                {
-                       if ( access_allowed_mask( op, e, entry_at,
-                                       NULL, access, NULL, mask ) == 0 )
+                       if ( access_allowed( op, ak ) == 0 )
                        {
                                rc = LDAP_INSUFFICIENT_ACCESS;
 
@@ -1766,13 +1827,13 @@ backend_access(
                        }
 
                } else {
-                       a = attr_find( e->e_attrs, entry_at );
+                       a = attr_find( ak->ak_e->e_attrs, ak->ak_desc );
                        if ( a == NULL ) {
                                SlapReply       rs = { 0 };
                                AttributeName   anlist[ 2 ];
 
-                               anlist[ 0 ].an_name = entry_at->ad_cname;
-                               anlist[ 0 ].an_desc = entry_at;
+                               anlist[ 0 ].an_name = ak->ak_desc->ad_cname;
+                               anlist[ 0 ].an_desc = ak->ak_desc;
                                BER_BVZERO( &anlist[ 1 ].an_name );
                                rs.sr_attrs = anlist;
                        
@@ -1781,7 +1842,7 @@ backend_access(
                                /* NOTE: backend_operational() is also called
                                 * when returning results, so it's supposed
                                 * to do no harm to entries */
-                               rs.sr_entry = e;
+                               rs.sr_entry = ak->ak_e;
                                rc = backend_operational( op, &rs );
                                rs.sr_entry = NULL;
 
@@ -1797,8 +1858,7 @@ backend_access(
                        }
 
                        if ( a ) {
-                               if ( access_allowed_mask( op, e, entry_at,
-                                               nval, access, NULL, mask ) == 0 )
+                               if ( access_allowed( op, ak ) == 0 )
                                {
                                        rc = LDAP_INSUFFICIENT_ACCESS;
                                        goto freeit;
@@ -1806,9 +1866,9 @@ backend_access(
                                rc = LDAP_SUCCESS;
                        }
                }
-freeit:                if ( e != target ) {
+freeit:                if ( freeent ) {
                        op->o_private = e_priv;
-                       be_entry_release_r( op, e );
+                       be_entry_release_r( op, ak->ak_e );
                        op->o_private = o_priv;
                }
                if ( freeattr ) {
@@ -1826,7 +1886,14 @@ fe_aux_operational(
        SlapReply *rs )
 {
        Attribute               **ap;
-       int                     rc = 0;
+       int                     rc = LDAP_SUCCESS;
+       BackendDB               *be_orig = op->o_bd;
+       OpExtra         *oex;
+
+       LDAP_SLIST_FOREACH(oex, &op->o_extra, oe_next) {
+               if ( oex->oe_key == (void *)backend_operational )
+                       break;
+       }
 
        for ( ap = &rs->sr_operational_attrs; *ap; ap = &(*ap)->a_next )
                /* just count them */ ;
@@ -1852,19 +1919,20 @@ fe_aux_operational(
                ap = &(*ap)->a_next;
        }
 
-       if ( op->o_bd != NULL ) {
-               BackendDB               *be_orig = op->o_bd;
+       /* Let the overlays have a chance at this */
+       if ( oex && ((OpExtraDB *)oex)->oe_db )
+               op->o_bd = ((OpExtraDB *)oex)->oe_db;
 
-               /* Let the overlays have a chance at this */
+       if ( !op->o_bd || !SLAP_DBHIDDEN( op->o_bd ))
                op->o_bd = select_backend( &op->o_req_ndn, 0 );
-               if ( op->o_bd != NULL && !be_match( op->o_bd, frontendDB ) &&
-                       ( SLAP_OPATTRS( rs->sr_attr_flags ) || rs->sr_attrs ) &&
-                       op->o_bd->be_operational != NULL )
-               {
-                       rc = op->o_bd->be_operational( op, rs );
-               }
-               op->o_bd = be_orig;
+
+       if ( op->o_bd != NULL && !be_match( op->o_bd, frontendDB ) &&
+               ( SLAP_OPATTRS( rs->sr_attr_flags ) || rs->sr_attrs ) &&
+               op->o_bd->be_operational != NULL )
+       {
+               rc = op->o_bd->be_operational( op, rs );
        }
+       op->o_bd = be_orig;
 
        return rc;
 }
@@ -1873,6 +1941,11 @@ int backend_operational( Operation *op, SlapReply *rs )
 {
        int rc;
        BackendDB *be_orig;
+       OpExtraDB       oex;
+
+       oex.oe_db = op->o_bd;
+       oex.oe.oe_key = (void *)backend_operational;
+       LDAP_SLIST_INSERT_HEAD(&op->o_extra, &oex.oe, oe_next);
 
        /* Moved this into the frontend so global overlays are called */
 
@@ -1880,6 +1953,7 @@ int backend_operational( Operation *op, SlapReply *rs )
        op->o_bd = frontendDB;
        rc = frontendDB->be_operational( op, rs );
        op->o_bd = be_orig;
+       LDAP_SLIST_REMOVE(&op->o_extra, &oex.oe, OpExtra, oe_next);
 
        return rc;
 }