]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/config.c
Detect TLS config changes
[openldap] / servers / slapd / config.c
index a488bdd3d2d8e716877d7302a8b2ce04066314d8..8f8e92ac61c48a01e7c1ab538bdf6757002799ee 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2005 The OpenLDAP Foundation.
+ * Copyright 1998-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 #include "lutil.h"
 #include "config.h"
 
+#ifdef HAVE_TLS
+#include <openssl/ssl.h>
+#endif
+
 #define ARGS_STEP      512
 
 /*
@@ -81,6 +85,7 @@ static void fp_getline_init(ConfigArgs *c);
 static int fp_parse_line(ConfigArgs *c);
 
 static char    *strtok_quote(char *line, char *sep, char **quote_ptr);
+static char *strtok_quote_ldif(char **line);
 
 ConfigArgs *
 new_config_args( BackendDB *be, const char *fname, int lineno, int argc, char **argv )
@@ -130,45 +135,55 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                c->argv[1] = "";
        }
        if(Conf->min_args && (c->argc < Conf->min_args)) {
-               sprintf( c->msg, "<%s> missing <%s> argument",
+               snprintf( c->msg, sizeof( c->msg ), "<%s> missing <%s> argument",
                        c->argv[0], Conf->what );
                Debug(LDAP_DEBUG_CONFIG, "%s: keyword %s\n", c->log, c->msg, 0 );
                return(ARG_BAD_CONF);
        }
        if(Conf->max_args && (c->argc > Conf->max_args)) {
-               sprintf( c->msg, "<%s> extra cruft after <%s> ignored",
+               char    *ignored = " ignored";
+
+               snprintf( c->msg, sizeof( c->msg ), "<%s> extra cruft after <%s>",
                        c->argv[0], Conf->what );
-               Debug(LDAP_DEBUG_CONFIG, "%s: %s\n", c->log, c->msg, 0 );
+
+#ifdef LDAP_DEVEL
+               ignored = "";
+#endif /* LDAP_DEVEL */
+               Debug(LDAP_DEBUG_CONFIG, "%s: %s%s.\n",
+                               c->log, c->msg, ignored );
+#ifdef LDAP_DEVEL
+               return(ARG_BAD_CONF);
+#endif /* LDAP_DEVEL */
        }
        if((arg_type & ARG_DB) && !c->be) {
-               sprintf( c->msg, "<%s> only allowed within database declaration",
+               snprintf( c->msg, sizeof( c->msg ), "<%s> only allowed within database declaration",
                        c->argv[0] );
                Debug(LDAP_DEBUG_CONFIG, "%s: keyword %s\n",
                        c->log, c->msg, 0);
                return(ARG_BAD_CONF);
        }
        if((arg_type & ARG_PRE_BI) && c->bi) {
-               sprintf( c->msg, "<%s> must occur before any backend %sdeclaration",
+               snprintf( c->msg, sizeof( c->msg ), "<%s> must occur before any backend %sdeclaration",
                        c->argv[0], (arg_type & ARG_PRE_DB) ? "or database " : "" );
                Debug(LDAP_DEBUG_CONFIG, "%s: keyword %s\n",
                        c->log, c->msg, 0 );
                return(ARG_BAD_CONF);
        }
        if((arg_type & ARG_PRE_DB) && c->be && c->be != frontendDB) {
-               sprintf( c->msg, "<%s> must occur before any database declaration",
+               snprintf( c->msg, sizeof( c->msg ), "<%s> must occur before any database declaration",
                        c->argv[0] );
                Debug(LDAP_DEBUG_CONFIG, "%s: keyword %s\n",
                        c->log, c->msg, 0);
                return(ARG_BAD_CONF);
        }
        if((arg_type & ARG_PAREN) && *c->argv[1] != '(' /*')'*/) {
-               sprintf( c->msg, "<%s> old format not supported", c->argv[0] );
+               snprintf( c->msg, sizeof( c->msg ), "<%s> old format not supported", c->argv[0] );
                Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
                        c->log, c->msg, 0);
                return(ARG_BAD_CONF);
        }
        if((arg_type & ARGS_POINTER) && !Conf->arg_item && !(arg_type & ARG_OFFSET)) {
-               sprintf( c->msg, "<%s> invalid config_table, arg_item is NULL",
+               snprintf( c->msg, sizeof( c->msg ), "<%s> invalid config_table, arg_item is NULL",
                        c->argv[0] );
                Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
                        c->log, c->msg, 0);
@@ -180,33 +195,66 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                int j;
                iarg = 0; larg = 0; barg = 0;
                switch(arg_type & ARGS_NUMERIC) {
-                       case ARG_INT:           iarg = atoi(c->argv[1]);                break;
-                       case ARG_LONG:          larg = strtol(c->argv[1], NULL, 0);     break;
-                       case ARG_BER_LEN_T:     barg = (ber_len_t)atol(c->argv[1]);     break;
+                       case ARG_INT:
+                               if ( lutil_atoix( &iarg, c->argv[1], 0 ) != 0 ) {
+                                       snprintf( c->msg, sizeof( c->msg ),
+                                               "<%s> unable to parse \"%s\" as int",
+                                               c->argv[0], c->argv[1] );
+                                       Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
+                                               c->log, c->msg, 0);
+                                       return(ARG_BAD_CONF);
+                               }
+                               break;
+                       case ARG_LONG:
+                               if ( lutil_atolx( &larg, c->argv[1], 0 ) != 0 ) {
+                                       snprintf( c->msg, sizeof( c->msg ),
+                                               "<%s> unable to parse \"%s\" as long",
+                                               c->argv[0], c->argv[1] );
+                                       Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
+                                               c->log, c->msg, 0);
+                                       return(ARG_BAD_CONF);
+                               }
+                               break;
+                       case ARG_BER_LEN_T: {
+                               unsigned long   l;
+                               if ( lutil_atoulx( &l, c->argv[1], 0 ) != 0 ) {
+                                       snprintf( c->msg, sizeof( c->msg ),
+                                               "<%s> unable to parse \"%s\" as ber_len_t",
+                                               c->argv[0], c->argv[1] );
+                                       Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
+                                               c->log, c->msg, 0);
+                                       return(ARG_BAD_CONF);
+                               }
+                               barg = (ber_len_t)l;
+                               } break;
                        case ARG_ON_OFF:
-                               if(c->argc == 1) {
+                               if (c->argc == 1) {
                                        iarg = 1;
-                               } else if(!strcasecmp(c->argv[1], "on") ||
-                                       !strcasecmp(c->argv[1], "true")) {
+                               } else if ( !strcasecmp(c->argv[1], "on") ||
+                                       !strcasecmp(c->argv[1], "true") ||
+                                       !strcasecmp(c->argv[1], "yes") )
+                               {
                                        iarg = 1;
-                               } else if(!strcasecmp(c->argv[1], "off") ||
-                                       !strcasecmp(c->argv[1], "false")) {
+                               } else if ( !strcasecmp(c->argv[1], "off") ||
+                                       !strcasecmp(c->argv[1], "false") ||
+                                       !strcasecmp(c->argv[1], "no") )
+                               {
                                        iarg = 0;
                                } else {
-                                       sprintf( c->msg, "<%s> invalid value, ignored",
+                                       snprintf( c->msg, sizeof( c->msg ), "<%s> invalid value",
                                                c->argv[0] );
-                                       Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
+                                       Debug(LDAP_DEBUG_ANY, "%s: %s\n",
                                                c->log, c->msg, 0 );
-                                       return(0);
+                                       return(ARG_BAD_CONF);
                                }
                                break;
                }
                j = (arg_type & ARG_NONZERO) ? 1 : 0;
                if(iarg < j && larg < j && barg < j ) {
                        larg = larg ? larg : (barg ? barg : iarg);
-                       sprintf( c->msg, "<%s> invalid value, ignored",
+                       snprintf( c->msg, sizeof( c->msg ), "<%s> invalid value",
                                c->argv[0] );
-                       Debug(LDAP_DEBUG_CONFIG, "%s: %s\n",
+                       Debug(LDAP_DEBUG_ANY, "%s: %s\n",
                                c->log, c->msg, 0 );
                        return(ARG_BAD_CONF);
                }
@@ -227,7 +275,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                ber_str2bv( c->argv[1], 0, 0, &bv );
                rc = dnPrettyNormal( NULL, &bv, &c->value_dn, &c->value_ndn, NULL );
                if ( rc != LDAP_SUCCESS ) {
-                       sprintf( c->msg, "<%s> invalid DN %d (%s)",
+                       snprintf( c->msg, sizeof( c->msg ), "<%s> invalid DN %d (%s)",
                                c->argv[0], rc, ldap_err2string( rc ));
                        Debug(LDAP_DEBUG_CONFIG, "%s: %s\n" , c->log, c->msg, 0);
                        return(ARG_BAD_CONF);
@@ -254,7 +302,7 @@ int config_set_vals(ConfigTable *Conf, ConfigArgs *c) {
 #endif
                if(rc) {
                        if ( !c->msg[0] ) {
-                               sprintf( c->msg, "<%s> handler exited with %d",
+                               snprintf( c->msg, sizeof( c->msg ), "<%s> handler exited with %d",
                                        c->argv[0], rc );
                                Debug(LDAP_DEBUG_CONFIG, "%s: %s!\n",
                                        c->log, c->msg, 0 );
@@ -269,13 +317,13 @@ int config_set_vals(ConfigTable *Conf, ConfigArgs *c) {
                else if (c->bi)
                        ptr = c->bi->bi_private;
                else {
-                       sprintf( c->msg, "<%s> offset is missing base pointer",
+                       snprintf( c->msg, sizeof( c->msg ), "<%s> offset is missing base pointer",
                                c->argv[0] );
                        Debug(LDAP_DEBUG_CONFIG, "%s: %s!\n",
                                c->log, c->msg, 0);
                        return(ARG_BAD_CONF);
                }
-               ptr = (void *)((char *)ptr + (int)Conf->arg_item);
+               ptr = (void *)((char *)ptr + (long)Conf->arg_item);
        } else if (arg_type & ARGS_POINTER) {
                ptr = Conf->arg_item;
        }
@@ -361,7 +409,7 @@ config_get_vals(ConfigTable *cf, ConfigArgs *c)
                                ptr = c->bi->bi_private;
                        else
                                return 1;
-                       ptr = (void *)((char *)ptr + (int)cf->arg_item);
+                       ptr = (void *)((char *)ptr + (long)cf->arg_item);
                } else {
                        ptr = cf->arg_item;
                }
@@ -382,10 +430,10 @@ config_get_vals(ConfigTable *cf, ConfigArgs *c)
        if ( cf->arg_type & ARGS_POINTER) {
                bv.bv_val = c->log;
                switch(cf->arg_type & ARGS_POINTER) {
-               case ARG_INT: bv.bv_len = sprintf(bv.bv_val, "%d", c->value_int); break;
-               case ARG_LONG: bv.bv_len = sprintf(bv.bv_val, "%ld", c->value_long); break;
-               case ARG_BER_LEN_T: bv.bv_len = sprintf(bv.bv_val, "%ld", c->value_ber_t); break;
-               case ARG_ON_OFF: bv.bv_len = sprintf(bv.bv_val, "%s",
+               case ARG_INT: bv.bv_len = snprintf(bv.bv_val, sizeof( c->log ), "%d", c->value_int); break;
+               case ARG_LONG: bv.bv_len = snprintf(bv.bv_val, sizeof( c->log ), "%ld", c->value_long); break;
+               case ARG_BER_LEN_T: bv.bv_len = snprintf(bv.bv_val, sizeof( c->log ), "%ld", c->value_ber_t); break;
+               case ARG_ON_OFF: bv.bv_len = snprintf(bv.bv_val, sizeof( c->log ), "%s",
                        c->value_int ? "TRUE" : "FALSE"); break;
                case ARG_STRING:
                        if ( c->value_string && c->value_string[0]) {
@@ -402,6 +450,9 @@ config_get_vals(ConfigTable *cf, ConfigArgs *c)
                        }
                        break;
                }
+               if (bv.bv_val == c->log && bv.bv_len >= sizeof( c->log ) ) {
+                       return 1;
+               }
                if (( cf->arg_type & ARGS_POINTER ) == ARG_STRING )
                        ber_bvarray_add(&c->rvalue_vals, &bv);
                else
@@ -434,13 +485,14 @@ init_config_attrs(ConfigTable *ct) {
                                freeit = 1;
 
                        } else {
+                               ldap_attributetype_free( at );
                                fprintf( stderr, "init_config_attrs: AttributeType \"%s\": %s, %s\n",
                                        ct[i].attribute, scherr2str(code), err );
                                return code;
                        }
                }
                code = slap_str2ad( at->at_names[0], &ct[i].ad, &err );
-               if ( freeit ) {
+               if ( freeit || code ) {
                        ldap_attributetype_free( at );
                } else {
                        ldap_memfree( at );
@@ -475,19 +527,99 @@ init_config_ocs( ConfigOCs *ocs ) {
                if ( code && code != SLAP_SCHERR_CLASS_DUP ) {
                        fprintf( stderr, "init_config_ocs: objectclass \"%s\": %s, %s\n",
                                ocs[i].co_def, scherr2str(code), err );
+                       ldap_objectclass_free(oc);
                        return code;
                }
                ocs[i].co_oc = oc_find(oc->oc_names[0]);
-               ldap_memfree(oc);
+               if ( code )
+                       ldap_objectclass_free(oc);
+               else
+                       ldap_memfree(oc);
        }
        return 0;
 }
 
+/* Split an LDIF line into space-separated tokens. Words may be grouped
+ * by quotes. A quoted string may begin in the middle of a word, but must
+ * end at the end of the word (be followed by whitespace or EOS). Any other
+ * quotes are passed through unchanged. All other characters are passed
+ * through unchanged.
+ */
+static char *
+strtok_quote_ldif( char **line )
+{
+       char *beg, *ptr, *quote=NULL;
+       int inquote=0;
+
+       ptr = *line;
+
+       if ( !ptr || !*ptr )
+               return NULL;
+
+       while( isspace( (unsigned char) *ptr )) ptr++;
+
+       if ( *ptr == '"' ) {
+               inquote = 1;
+               ptr++;
+       }
+
+       beg = ptr;
+
+       for (;*ptr;ptr++) {
+               if ( *ptr == '"' ) {
+                       if ( inquote && ( !ptr[1] || isspace((unsigned char) ptr[1]))) {
+                               *ptr++ = '\0';
+                               break;
+                       }
+                       inquote = 1;
+                       quote = ptr;
+                       continue;
+               }
+               if ( inquote )
+                       continue;
+               if ( isspace( (unsigned char) *ptr )) {
+                       *ptr++ = '\0';
+                       break;
+               }
+       }
+       if ( quote ) {
+               while ( quote < ptr ) {
+                       *quote = quote[1];
+                       quote++;
+               }
+       }
+       if ( !*ptr ) {
+               *line = NULL;
+       } else {
+               while ( isspace( (unsigned char) *ptr )) ptr++;
+               *line = ptr;
+       }
+       return beg;
+}
+
+static void
+config_parse_ldif( ConfigArgs *c )
+{
+       char *next;
+       c->tline = ch_strdup(c->line);
+       next = c->tline;
+
+       while ((c->argv[c->argc] = strtok_quote_ldif( &next )) != NULL) {
+               c->argc++;
+               if ( c->argc >= c->argv_size ) {
+                       char **tmp = ch_realloc( c->argv, (c->argv_size + ARGS_STEP) *
+                               sizeof( *c->argv ));
+                       c->argv = tmp;
+                       c->argv_size += ARGS_STEP;
+               }
+       }
+       c->argv[c->argc] = NULL;
+}
+
 int
 config_parse_vals(ConfigTable *ct, ConfigArgs *c, int valx)
 {
        int     rc = 0;
-       char    *saveline = NULL;
 
        snprintf( c->log, sizeof( c->log ), "%s: value #%d",
                ct->ad->ad_cname.bv_val, valx );
@@ -495,29 +627,20 @@ config_parse_vals(ConfigTable *ct, ConfigArgs *c, int valx)
        c->argv[0] = ct->ad->ad_cname.bv_val;
 
        if ( ( ct->arg_type & ARG_QUOTE ) && c->line[ 0 ] != '"' ) {
-               ber_len_t       len;
-
-               saveline = c->line;
-               len = strlen( c->line );
-               c->line = ch_malloc( len + STRLENOF( "\"\"" ) + 1 );
-               sprintf( c->line, "\"%s\"", saveline );
-       }
-
-       if ( fp_parse_line( c ) ) {
-               rc = 1;
+               c->argv[c->argc] = c->line;
+               c->argc++;
+               c->argv[c->argc] = NULL;
+               c->tline = NULL;
        } else {
-               rc = config_check_vals( ct, c, 1 );
-       }
-
-       if ( saveline ) {
-               ch_free( c->line );
-               c->line = saveline;
+               config_parse_ldif( c );
        }
+       rc = config_check_vals( ct, c, 1 );
+       ch_free( c->tline );
+       c->tline = NULL;
 
        if ( rc )
                rc = LDAP_CONSTRAINT_VIOLATION;
 
-       ch_free( c->tline );
        return rc;
 }
 
@@ -525,7 +648,6 @@ int
 config_parse_add(ConfigTable *ct, ConfigArgs *c)
 {
        int     rc = 0;
-       char    *saveline = NULL;
 
        snprintf( c->log, sizeof( c->log ), "%s: value #%d",
                ct->ad->ad_cname.bv_val, c->valx );
@@ -533,28 +655,17 @@ config_parse_add(ConfigTable *ct, ConfigArgs *c)
        c->argv[0] = ct->ad->ad_cname.bv_val;
 
        if ( ( ct->arg_type & ARG_QUOTE ) && c->line[ 0 ] != '"' ) {
-               ber_len_t       len;
-
-               saveline = c->line;
-               len = strlen( c->line );
-                       
-               c->line = ch_malloc( len + STRLENOF( "\"\"" ) + 1 );
-               sprintf( c->line, "\"%s\"", saveline );
-       }
-
-       if ( fp_parse_line( c ) ) {
-               rc = 1;
+               c->argv[c->argc] = c->line;
+               c->argc++;
+               c->argv[c->argc] = NULL;
+               c->tline = NULL;
        } else {
-               c->op = LDAP_MOD_ADD;
-               rc = config_add_vals( ct, c );
-       }
-
-       if ( saveline ) {
-               ch_free( c->line );
-               c->line = saveline;
+               config_parse_ldif( c );
        }
-
+       c->op = LDAP_MOD_ADD;
+       rc = config_add_vals( ct, c );
        ch_free( c->tline );
+
        return rc;
 }
 
@@ -589,6 +700,7 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                Debug(LDAP_DEBUG_ANY,
                    "could not stat config file \"%s\": %s (%d)\n",
                    fname, strerror(errno), errno);
+               ch_free( c );
                return(1);
        }
 
@@ -597,6 +709,7 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                Debug(LDAP_DEBUG_ANY,
                    "regular file expected, got \"%s\"\n",
                    fname, 0, 0 );
+               ch_free( c );
                return(1);
        }
 
@@ -606,6 +719,7 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                Debug(LDAP_DEBUG_ANY,
                    "could not open config file \"%s\": %s (%d)\n",
                    fname, strerror(errno), errno);
+               ch_free( c );
                return(1);
        }
 
@@ -628,19 +742,14 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                ch_free( c->tline );
                if ( fp_parse_line( c ) ) {
                        rc = 1;
-                       goto leave;
+                       goto done;
                }
 
                if ( c->argc < 1 ) {
-                       Debug( SLAPD_DEBUG_CONFIG_ERROR, "%s: bad config line" 
-                               SLAPD_CONF_UNKNOWN_IGNORED ".\n",
+                       Debug( LDAP_DEBUG_ANY, "%s: bad config line.\n",
                                c->log, 0, 0);
-#ifdef SLAPD_CONF_UNKNOWN_BAILOUT
                        rc = 1;
-                       goto leave;
-#else /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
-                       continue;
-#endif /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
+                       goto done;
                }
 
                c->op = SLAP_CONFIG_ADD;
@@ -655,11 +764,11 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                                Debug(LDAP_DEBUG_CONFIG, "%s: unknown user type <%s>\n",
                                        c->log, c->argv[0], 0);
                                rc = 1;
-                               goto leave;
+                               goto done;
 
                        } else if ( rc == ARG_BAD_CONF ) {
                                rc = 1;
-                               goto leave;
+                               goto done;
                        }
                        
                } else if ( c->bi && !c->be ) {
@@ -677,20 +786,16 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                        if ( rc ) {
                                switch(rc) {
                                case SLAP_CONF_UNKNOWN:
-                                       Debug( SLAPD_DEBUG_CONFIG_ERROR, "%s: "
-                                               "unknown directive <%s> inside backend info definition"
-                                               SLAPD_CONF_UNKNOWN_IGNORED ".\n",
+                                       Debug( LDAP_DEBUG_ANY, "%s: unknown directive "
+                                               "<%s> inside backend info definition.\n",
                                                c->log, *c->argv, 0);
-#ifndef SLAPD_CONF_UNKNOWN_BAILOUT
-                                       continue;
-#endif /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
                                default:
                                        rc = 1;
-                                       goto leave;
+                                       goto done;
                                }
                        }
 
-               } else if ( c->be ) {
+               } else if ( c->be && c->be != frontendDB ) {
                        rc = SLAP_CONF_UNKNOWN;
                        if ( c->be->be_cf_ocs ) {
                                ct = config_find_keyword( c->be->be_cf_ocs->co_table, c );
@@ -702,57 +807,57 @@ read_config_file(const char *fname, int depth, ConfigArgs *cf, ConfigTable *cft)
                                rc = (*c->be->be_config)(c->be, c->fname, c->lineno,
                                        c->argc, c->argv);
                        }
-                       if ( rc ) {
-                               switch(rc) {
-                               case SLAP_CONF_UNKNOWN:
-                                       Debug( SLAPD_DEBUG_CONFIG_ERROR, "%s: "
-                                               "unknown directive <%s> inside backend database "
-                                               "definition" SLAPD_CONF_UNKNOWN_IGNORED ".\n",
-                                               c->log, *c->argv, 0);
-#ifndef SLAPD_CONF_UNKNOWN_BAILOUT
-                                       continue;
-#endif /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
-                               default:
-                                       rc = 1;
-                                       goto leave;
-                               }
+                       if ( rc == SLAP_CONF_UNKNOWN && SLAP_ISGLOBALOVERLAY( frontendDB ) )
+                       {
+                               /* global overlays may need 
+                                * definitions inside other databases...
+                                */
+                               rc = (*frontendDB->be_config)( frontendDB,
+                                       c->fname, (int)c->lineno, c->argc, c->argv );
+                       }
+
+                       switch ( rc ) {
+                       case 0:
+                               break;
+
+                       case SLAP_CONF_UNKNOWN:
+                               Debug( LDAP_DEBUG_ANY, "%s: unknown directive "
+                                       "<%s> inside backend database definition.\n",
+                                       c->log, *c->argv, 0);
+                               
+                       default:
+                               rc = 1;
+                               goto done;
                        }
 
                } else if ( frontendDB->be_config ) {
-                       rc = (*frontendDB->be_config)(frontendDB, c->fname, (int)c->lineno, c->argc, c->argv);
+                       rc = (*frontendDB->be_config)( frontendDB,
+                               c->fname, (int)c->lineno, c->argc, c->argv);
                        if ( rc ) {
                                switch(rc) {
                                case SLAP_CONF_UNKNOWN:
-                                       Debug( SLAPD_DEBUG_CONFIG_ERROR, "%s: "
-                                               "unknown directive <%s> inside global database definition"
-                                               SLAPD_CONF_UNKNOWN_IGNORED ".\n",
+                                       Debug( LDAP_DEBUG_ANY, "%s: unknown directive "
+                                               "<%s> inside global database definition.\n",
                                                c->log, *c->argv, 0);
-#ifndef SLAPD_CONF_UNKNOWN_BAILOUT
-                                       continue;
-#endif /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
+
                                default:
                                        rc = 1;
-                                       goto leave;
+                                       goto done;
                                }
                        }
                        
                } else {
-                       Debug( SLAPD_DEBUG_CONFIG_ERROR, "%s: "
-                               "unknown directive <%s> outside backend info and database definitions"
-                               SLAPD_CONF_UNKNOWN_IGNORED ".\n",
+                       Debug( LDAP_DEBUG_ANY, "%s: unknown directive "
+                               "<%s> outside backend info and database definitions.\n",
                                c->log, *c->argv, 0);
-#ifdef SLAPD_CONF_UNKNOWN_BAILOUT
                        rc = 1;
-                       goto leave;
-#else /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
-                       continue;
-#endif /* ! SLAPD_CONF_UNKNOWN_BAILOUT */
+                       goto done;
                }
        }
 
        rc = 0;
 
-leave:
+done:
        ch_free(c->tline);
        fclose(fp);
        ch_free(c->argv);
@@ -765,9 +870,9 @@ leave:
 int
 verb_to_mask(const char *word, slap_verbmasks *v) {
        int i;
-       for(i = 0; !BER_BVISNULL(&v[i].word); i++)
-               if(!strcasecmp(word, v[i].word.bv_val))
-                       break;
+       for(i = 0; !BER_BVISNULL(&v[i].word); i++) {
+               if(!strcasecmp(word, v[i].word.bv_val)) break;
+       }
        return(i);
 }
 
@@ -776,7 +881,7 @@ verbs_to_mask(int argc, char *argv[], slap_verbmasks *v, slap_mask_t *m) {
        int i, j;
        for(i = 1; i < argc; i++) {
                j = verb_to_mask(argv[i], v);
-               if(BER_BVISNULL(&v[j].word)) return(1);
+               if(BER_BVISNULL(&v[j].word)) return i;
                while (!v[j].mask) j--;
                *m |= v[j].mask;
        }
@@ -788,18 +893,20 @@ verbs_to_mask(int argc, char *argv[], slap_verbmasks *v, slap_mask_t *m) {
  */
 int
 mask_to_verbs(slap_verbmasks *v, slap_mask_t m, BerVarray *bva) {
-       int i;
-
-       if (!m) return 1;
-       for (i=0; !BER_BVISNULL(&v[i].word); i++) {
-               if (!v[i].mask) continue;
-               if (( m & v[i].mask ) == v[i].mask ) {
-                       value_add_one( bva, &v[i].word );
-                       m ^= v[i].mask;
-                       if ( !m ) break;
+       int i, rc = 1;
+
+       if (m) {
+               for (i=0; !BER_BVISNULL(&v[i].word); i++) {
+                       if (!v[i].mask) continue;
+                       if (( m & v[i].mask ) == v[i].mask ) {
+                               value_add_one( bva, &v[i].word );
+                               rc = 0;
+                               m ^= v[i].mask;
+                               if ( !m ) break;
+                       }
                }
        }
-       return 0;
+       return rc;
 }
 
 int
@@ -809,8 +916,7 @@ slap_verbmasks_init( slap_verbmasks **vp, slap_verbmasks *v )
 
        assert( *vp == NULL );
 
-       for ( i = 0; !BER_BVISNULL( &v[ i ].word ); i++ )
-               ;
+       for ( i = 0; !BER_BVISNULL( &v[ i ].word ); i++ ) /* EMPTY */;
 
        *vp = ch_calloc( i + 1, sizeof( slap_verbmasks ) );
 
@@ -921,15 +1027,8 @@ static slap_verbmasks methkey[] = {
        { BER_BVNULL, 0 }
 };
 
-typedef struct cf_aux_table {
-       struct berval key;
-       int off;
-       char type;
-       char quote;
-       slap_verbmasks *aux;
-} cf_aux_table;
-
-static cf_aux_table bindkey[] = {
+static slap_cf_aux_table bindkey[] = {
+       { BER_BVC("uri="), offsetof(slap_bindconf, sb_uri), 'b', 1, NULL },
        { BER_BVC("starttls="), offsetof(slap_bindconf, sb_tls), 'd', 0, tlskey },
        { BER_BVC("bindmethod="), offsetof(slap_bindconf, sb_method), 'd', 0, methkey },
        { BER_BVC("binddn="), offsetof(slap_bindconf, sb_binddn), 'b', 1, NULL },
@@ -939,34 +1038,55 @@ static cf_aux_table bindkey[] = {
        { BER_BVC("realm="), offsetof(slap_bindconf, sb_realm), 'b', 0, NULL },
        { BER_BVC("authcID="), offsetof(slap_bindconf, sb_authcId), 'b', 0, NULL },
        { BER_BVC("authzID="), offsetof(slap_bindconf, sb_authzId), 'b', 1, NULL },
+#ifdef HAVE_TLS
+
+#define aux_TLS (bindkey+10)   /* beginning of TLS keywords */
+
+       { BER_BVC("tls_cert="), offsetof(slap_bindconf, sb_tls_cert), 's', 1, NULL },
+       { BER_BVC("tls_key="), offsetof(slap_bindconf, sb_tls_key), 's', 1, NULL },
+       { BER_BVC("tls_cacert="), offsetof(slap_bindconf, sb_tls_cacert), 's', 1, NULL },
+       { BER_BVC("tls_cacertdir="), offsetof(slap_bindconf, sb_tls_cacertdir), 's', 1, NULL },
+       { BER_BVC("tls_reqcert="), offsetof(slap_bindconf, sb_tls_reqcert), 's', 1, NULL },
+       { BER_BVC("tls_cipher_suite="), offsetof(slap_bindconf, sb_tls_cipher_suite), 's', 1, NULL },
+#ifdef HAVE_OPENSSL_CRL
+       { BER_BVC("tls_crlcheck="), offsetof(slap_bindconf, sb_tls_crlcheck), 's', 1, NULL },
+#endif
+#endif
        { BER_BVNULL, 0, 0, 0, NULL }
 };
 
-int bindconf_parse( const char *word, slap_bindconf *bc ) {
-       int rc = 0;
-       cf_aux_table *tab;
+int
+slap_cf_aux_table_parse( const char *word, void *dst, slap_cf_aux_table *tab0, LDAP_CONST char *tabmsg )
+{
+       int rc = SLAP_CONF_UNKNOWN;
+       slap_cf_aux_table *tab;
 
-       for (tab = bindkey; !BER_BVISNULL(&tab->key); tab++) {
+       for (tab = tab0; !BER_BVISNULL(&tab->key); tab++ ) {
                if ( !strncasecmp( word, tab->key.bv_val, tab->key.bv_len )) {
                        char **cptr;
                        int *iptr, j;
+                       unsigned *uptr;
+                       long *lptr;
+                       unsigned long *ulptr;
                        struct berval *bptr;
                        const char *val = word + tab->key.bv_len;
 
                        switch ( tab->type ) {
                        case 's':
-                               cptr = (char **)((char *)bc + tab->off);
+                               cptr = (char **)((char *)dst + tab->off);
                                *cptr = ch_strdup( val );
+                               rc = 0;
                                break;
 
                        case 'b':
-                               bptr = (struct berval *)((char *)bc + tab->off);
+                               bptr = (struct berval *)((char *)dst + tab->off);
                                ber_str2bv( val, 0, 1, bptr );
+                               rc = 0;
                                break;
 
                        case 'd':
                                assert( tab->aux != NULL );
-                               iptr = (int *)((char *)bc + tab->off);
+                               iptr = (int *)((char *)dst + tab->off);
 
                                rc = 1;
                                for ( j = 0; !BER_BVISNULL( &tab->aux[j].word ); j++ ) {
@@ -976,11 +1096,35 @@ int bindconf_parse( const char *word, slap_bindconf *bc ) {
                                        }
                                }
                                break;
+
+                       case 'i':
+                               iptr = (int *)((char *)dst + tab->off);
+
+                               rc = lutil_atoix( iptr, val, 0 );
+                               break;
+
+                       case 'u':
+                               uptr = (unsigned *)((char *)dst + tab->off);
+
+                               rc = lutil_atoux( uptr, val, 0 );
+                               break;
+
+                       case 'I':
+                               lptr = (long *)((char *)dst + tab->off);
+
+                               rc = lutil_atolx( lptr, val, 0 );
+                               break;
+
+                       case 'U':
+                               ulptr = (unsigned long *)((char *)dst + tab->off);
+
+                               rc = lutil_atoulx( ulptr, val, 0 );
+                               break;
                        }
 
                        if ( rc ) {
-                               Debug( LDAP_DEBUG_ANY, "invalid bind config value %s\n",
-                                       word, 0, 0 );
+                               Debug( LDAP_DEBUG_ANY, "invalid %s value %s\n",
+                                       tabmsg, word, 0 );
                        }
                        
                        return rc;
@@ -990,22 +1134,27 @@ int bindconf_parse( const char *word, slap_bindconf *bc ) {
        return rc;
 }
 
-int bindconf_unparse( slap_bindconf *bc, struct berval *bv ) {
+int
+slap_cf_aux_table_unparse( void *src, struct berval *bv, slap_cf_aux_table *tab0 )
+{
        char buf[BUFSIZ], *ptr;
-       cf_aux_table *tab;
+       slap_cf_aux_table *tab;
        struct berval tmp;
 
        ptr = buf;
-       for (tab = bindkey; !BER_BVISNULL(&tab->key); tab++) {
+       for (tab = tab0; !BER_BVISNULL(&tab->key); tab++ ) {
                char **cptr;
                int *iptr, i;
+               unsigned *uptr;
+               long *lptr;
+               unsigned long *ulptr;
                struct berval *bptr;
 
-               cptr = (char **)((char *)bc + tab->off);
+               cptr = (char **)((char *)src + tab->off);
 
                switch ( tab->type ) {
                case 'b':
-                       bptr = (struct berval *)((char *)bc + tab->off);
+                       bptr = (struct berval *)((char *)src + tab->off);
                        cptr = &bptr->bv_val;
                case 's':
                        if ( *cptr ) {
@@ -1019,7 +1168,7 @@ int bindconf_unparse( slap_bindconf *bc, struct berval *bv ) {
 
                case 'd':
                        assert( tab->aux != NULL );
-                       iptr = (int *)((char *)bc + tab->off);
+                       iptr = (int *)((char *)src + tab->off);
                
                        for ( i = 0; !BER_BVISNULL( &tab->aux[i].word ); i++ ) {
                                if ( *iptr == tab->aux[i].mask ) {
@@ -1030,6 +1179,37 @@ int bindconf_unparse( slap_bindconf *bc, struct berval *bv ) {
                                }
                        }
                        break;
+
+               case 'i':
+                       iptr = (int *)((char *)src + tab->off);
+                       *ptr++ = ' ';
+                       ptr = lutil_strcopy( ptr, tab->key.bv_val );
+                       ptr += snprintf( ptr, sizeof( buf ) - ( ptr - buf ), "%d", *iptr );
+                       break;
+
+               case 'u':
+                       uptr = (unsigned *)((char *)src + tab->off);
+                       *ptr++ = ' ';
+                       ptr = lutil_strcopy( ptr, tab->key.bv_val );
+                       ptr += snprintf( ptr, sizeof( buf ) - ( ptr - buf ), "%u", *uptr );
+                       break;
+
+               case 'I':
+                       lptr = (long *)((char *)src + tab->off);
+                       *ptr++ = ' ';
+                       ptr = lutil_strcopy( ptr, tab->key.bv_val );
+                       ptr += snprintf( ptr, sizeof( buf ) - ( ptr - buf ), "%ld", *lptr );
+                       break;
+
+               case 'U':
+                       ulptr = (unsigned long *)((char *)src + tab->off);
+                       *ptr++ = ' ';
+                       ptr = lutil_strcopy( ptr, tab->key.bv_val );
+                       ptr += snprintf( ptr, sizeof( buf ) - ( ptr - buf ), "%lu", *ulptr );
+                       break;
+
+               default:
+                       assert( 0 );
                }
        }
        tmp.bv_val = buf;
@@ -1038,7 +1218,30 @@ int bindconf_unparse( slap_bindconf *bc, struct berval *bv ) {
        return 0;
 }
 
+int
+bindconf_parse( const char *word, slap_bindconf *bc )
+{
+#ifdef HAVE_TLS
+       /* Detect TLS config changes explicitly */
+       if ( slap_cf_aux_table_parse( word, bc, aux_TLS, "tls config" ) == 0 ) {
+               bc->sb_tls_do_init = 1;
+               return 0;
+       }
+#endif
+       return slap_cf_aux_table_parse( word, bc, bindkey, "bind config" );
+}
+
+int
+bindconf_unparse( slap_bindconf *bc, struct berval *bv )
+{
+       return slap_cf_aux_table_unparse( bc, bv, bindkey );
+}
+
 void bindconf_free( slap_bindconf *bc ) {
+       if ( !BER_BVISNULL( &bc->sb_uri ) ) {
+               ch_free( bc->sb_uri.bv_val );
+               BER_BVZERO( &bc->sb_uri );
+       }
        if ( !BER_BVISNULL( &bc->sb_binddn ) ) {
                ch_free( bc->sb_binddn.bv_val );
                BER_BVZERO( &bc->sb_binddn );
@@ -1067,8 +1270,119 @@ void bindconf_free( slap_bindconf *bc ) {
                ch_free( bc->sb_authzId.bv_val );
                BER_BVZERO( &bc->sb_authzId );
        }
+#ifdef HAVE_TLS
+       if ( bc->sb_tls_ctx ) {
+               SSL_CTX_free( bc->sb_tls_ctx );
+               bc->sb_tls_ctx = NULL;
+       }
+       if ( bc->sb_tls_cert ) {
+               ch_free( bc->sb_tls_cert );
+               bc->sb_tls_cert = NULL;
+       }
+       if ( bc->sb_tls_key ) {
+               ch_free( bc->sb_tls_key );
+               bc->sb_tls_key = NULL;
+       }
+       if ( bc->sb_tls_cacert ) {
+               ch_free( bc->sb_tls_cacert );
+               bc->sb_tls_cacert = NULL;
+       }
+       if ( bc->sb_tls_cacertdir ) {
+               ch_free( bc->sb_tls_cacertdir );
+               bc->sb_tls_cacertdir = NULL;
+       }
+       if ( bc->sb_tls_reqcert ) {
+               ch_free( bc->sb_tls_reqcert );
+               bc->sb_tls_reqcert = NULL;
+       }
+       if ( bc->sb_tls_cipher_suite ) {
+               ch_free( bc->sb_tls_cipher_suite );
+               bc->sb_tls_cipher_suite = NULL;
+       }
+#ifdef HAVE_OPENSSL_CRL
+       if ( bc->sb_tls_crlcheck ) {
+               ch_free( bc->sb_tls_crlcheck );
+               bc->sb_tls_crlcheck = NULL;
+       }
+#endif
+#endif
 }
 
+#ifdef HAVE_TLS
+static struct {
+       const char *key;
+       size_t offset;
+       int opt;
+} bindtlsopts[] = {
+       { "tls_cert", offsetof(slap_bindconf, sb_tls_cert), LDAP_OPT_X_TLS_CERTFILE },
+       { "tls_key", offsetof(slap_bindconf, sb_tls_key), LDAP_OPT_X_TLS_KEYFILE },
+       { "tls_cacert", offsetof(slap_bindconf, sb_tls_cacert), LDAP_OPT_X_TLS_CACERTFILE },
+       { "tls_cacertdir", offsetof(slap_bindconf, sb_tls_cacertdir), LDAP_OPT_X_TLS_CACERTDIR },
+       { "tls_cipher_suite", offsetof(slap_bindconf, sb_tls_cipher_suite), LDAP_OPT_X_TLS_CIPHER_SUITE },
+       {0, 0}
+};
+
+int bindconf_tls_set( slap_bindconf *bc, LDAP *ld )
+{
+       int i, rc, newctx = 0, res = 0;
+       char *ptr = (char *)bc, **word;
+
+       bc->sb_tls_do_init = 0;
+
+       for (i=0; bindtlsopts[i].opt; i++) {
+               word = (char **)(ptr + bindtlsopts[i].offset);
+               if ( *word ) {
+                       rc = ldap_set_option( ld, bindtlsopts[i].opt, *word );
+                       if ( rc ) {
+                               Debug( LDAP_DEBUG_ANY,
+                                       "bindconf_tls_set: failed to set %s to %s\n",
+                                               bindtlsopts[i].key, *word, 0 );
+                               res = -1;
+                       } else
+                               newctx = 1;
+               }
+       }
+       if ( bc->sb_tls_reqcert ) {
+               rc = ldap_int_tls_config( ld, LDAP_OPT_X_TLS_REQUIRE_CERT,
+                       bc->sb_tls_reqcert );
+               if ( rc ) {
+                       Debug( LDAP_DEBUG_ANY,
+                               "bindconf_tls_set: failed to set tls_reqcert to %s\n",
+                                       bc->sb_tls_reqcert, 0, 0 );
+                       res = -1;
+               } else
+                       newctx = 1;
+       }
+#ifdef HAVE_OPENSSL_CRL
+       if ( bc->sb_tls_crlcheck ) {
+               rc = ldap_int_tls_config( ld, LDAP_OPT_X_TLS_CRLCHECK,
+                       bc->sb_tls_crlcheck );
+               if ( rc ) {
+                       Debug( LDAP_DEBUG_ANY,
+                               "bindconf_tls_set: failed to set tls_crlcheck to %s\n",
+                                       bc->sb_tls_crlcheck, 0, 0 );
+                       res = -1;
+               } else
+                       newctx = 1;
+       }
+#endif
+       if ( newctx ) {
+               int opt = 0;
+
+               if ( bc->sb_tls_ctx ) {
+                       SSL_CTX_free( bc->sb_tls_ctx );
+                       bc->sb_tls_ctx = NULL;
+               }
+               rc = ldap_set_option( ld, LDAP_OPT_X_TLS_NEWCTX, &opt );
+               if ( rc )
+                       res = rc;
+               else
+                       ldap_get_option( ld, LDAP_OPT_X_TLS_CTX, &bc->sb_tls_ctx );
+       }
+       
+       return res;
+}
+#endif
 
 /* -------------------------------------- */
 
@@ -1318,7 +1632,9 @@ int config_generic_wrapper( Backend *be, const char *fname, int lineno,
        c.argc = argc;
        c.argv = argv;
        c.valx = -1;
-       sprintf( c.log, "%s: line %d", fname, lineno );
+       c.line = line;
+       c.op = SLAP_CONFIG_ADD;
+       snprintf( c.log, sizeof( c.log ), "%s: line %d", fname, lineno );
 
        rc = SLAP_CONF_UNKNOWN;
        ct = config_find_keyword( be->be_cf_ocs->co_table, &c );