]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/config.c
Partial revert of f30269f5d2e4bb5ee7486fe6542078d1b59dba6d
[openldap] / servers / slapd / config.c
index 6cec953681ec67ea3ae1fe518f7fe96eef45e90e..b0011bb93709d393b19a8388b01e34db1afe51ac 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2010 The OpenLDAP Foundation.
+ * Copyright 1998-2012 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -195,13 +195,16 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
        c->type = arg_user;
        memset(&c->values, 0, sizeof(c->values));
        if(arg_type == ARG_STRING) {
+               assert( c->argc == 2 );
                if ( !check_only )
                        c->value_string = ch_strdup(c->argv[1]);
        } else if(arg_type == ARG_BERVAL) {
+               assert( c->argc == 2 );
                if ( !check_only )
                        ber_str2bv( c->argv[1], 0, 1, &c->value_bv );
        } else if(arg_type == ARG_DN) {
                struct berval bv;
+               assert( c->argc == 2 );
                ber_str2bv( c->argv[1], 0, 0, &bv );
                rc = dnPrettyNormal( NULL, &bv, &c->value_dn, &c->value_ndn, NULL );
                if ( rc != LDAP_SUCCESS ) {
@@ -216,6 +219,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                }
        } else if(arg_type == ARG_ATDESC) {
                const char *text = NULL;
+               assert( c->argc == 2 );
                c->value_ad = NULL;
                rc = slap_str2ad( c->argv[1], &c->value_ad, &text );
                if ( rc != LDAP_SUCCESS ) {
@@ -229,6 +233,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                iarg = 0; larg = 0; barg = 0;
                switch(arg_type) {
                        case ARG_INT:
+                               assert( c->argc == 2 );
                                if ( lutil_atoix( &iarg, c->argv[1], 0 ) != 0 ) {
                                        snprintf( c->cr_msg, sizeof( c->cr_msg ),
                                                "<%s> unable to parse \"%s\" as int",
@@ -239,6 +244,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                                }
                                break;
                        case ARG_UINT:
+                               assert( c->argc == 2 );
                                if ( lutil_atoux( &uiarg, c->argv[1], 0 ) != 0 ) {
                                        snprintf( c->cr_msg, sizeof( c->cr_msg ),
                                                "<%s> unable to parse \"%s\" as unsigned int",
@@ -249,6 +255,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                                }
                                break;
                        case ARG_LONG:
+                               assert( c->argc == 2 );
                                if ( lutil_atolx( &larg, c->argv[1], 0 ) != 0 ) {
                                        snprintf( c->cr_msg, sizeof( c->cr_msg ),
                                                "<%s> unable to parse \"%s\" as long",
@@ -259,6 +266,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                                }
                                break;
                        case ARG_ULONG:
+                               assert( c->argc == 2 );
                                if ( lutil_atoulx( &ularg, c->argv[1], 0 ) != 0 ) {
                                        snprintf( c->cr_msg, sizeof( c->cr_msg ),
                                                "<%s> unable to parse \"%s\" as unsigned long",
@@ -270,6 +278,7 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                                break;
                        case ARG_BER_LEN_T: {
                                unsigned long   l;
+                               assert( c->argc == 2 );
                                if ( lutil_atoulx( &l, c->argv[1], 0 ) != 0 ) {
                                        snprintf( c->cr_msg, sizeof( c->cr_msg ),
                                                "<%s> unable to parse \"%s\" as ber_len_t",
@@ -281,6 +290,8 @@ int config_check_vals(ConfigTable *Conf, ConfigArgs *c, int check_only ) {
                                barg = (ber_len_t)l;
                                } break;
                        case ARG_ON_OFF:
+                               /* note: this is an explicit exception
+                                * to the "need exactly 2 args" rule */
                                if (c->argc == 1) {
                                        iarg = 1;
                                } else if ( !strcasecmp(c->argv[1], "on") ||
@@ -467,7 +478,7 @@ config_get_vals(ConfigTable *cf, ConfigArgs *c)
                                c->value_string = ch_strdup(*(char **)ptr);
                        break;
                case ARG_BERVAL:
-                       ber_dupbv( &c->value_bv, (struct berval *)ptr ); break;
+                       c->value_bv = *((struct berval *)ptr); break;
                case ARG_ATDESC:
                        c->value_ad = *(AttributeDescription **)ptr; break;
                }
@@ -935,6 +946,66 @@ mask_to_verbs(slap_verbmasks *v, slap_mask_t m, BerVarray *bva) {
        return rc;
 }
 
+/* Return the verbs as a single string, separated by delim */
+int
+mask_to_verbstring(slap_verbmasks *v, slap_mask_t m0, char delim, struct berval *bv)
+{
+       int i, rc = 1;
+
+       BER_BVZERO( bv );
+       if (m0) {
+               slap_mask_t m = m0;
+               char *ptr;
+               for (i=0; !BER_BVISNULL(&v[i].word); i++) {
+                       if (!v[i].mask) continue;
+                       if (( m & v[i].mask ) == v[i].mask ) {
+                               bv->bv_len += v[i].word.bv_len + 1;
+                               rc = 0;
+                               m ^= v[i].mask;
+                               if ( !m ) break;
+                       }
+               }
+               bv->bv_val = ch_malloc(bv->bv_len);
+               bv->bv_len--;
+               ptr = bv->bv_val;
+               m = m0;
+               for (i=0; !BER_BVISNULL(&v[i].word); i++) {
+                       if (!v[i].mask) continue;
+                       if (( m & v[i].mask ) == v[i].mask ) {
+                               ptr = lutil_strcopy(ptr, v[i].word.bv_val);
+                               *ptr++ = delim;
+                               m ^= v[i].mask;
+                               if ( !m ) break;
+                       }
+               }
+               ptr[-1] = '\0';
+       }
+       return rc;
+}
+
+/* Parse a verbstring */
+int
+verbstring_to_mask(slap_verbmasks *v, char *str, char delim, slap_mask_t *m) {
+       int j;
+       char *d;
+       struct berval bv;
+
+       do {
+               bv.bv_val = str;
+               d = strchr( str, delim );
+               if ( d )
+                       bv.bv_len = d - str;
+               else
+                       bv.bv_len = strlen( str );
+               j = bverb_to_mask( &bv, v );
+               if(BER_BVISNULL(&v[j].word)) return 1;
+               while (!v[j].mask) j--;
+               *m |= v[j].mask;
+               str += bv.bv_len + 1;
+       } while ( d );
+       return(0);
+}
+
 int
 slap_verbmasks_init( slap_verbmasks **vp, slap_verbmasks *v )
 {
@@ -1210,30 +1281,6 @@ static slap_verbmasks versionkey[] = {
        { BER_BVNULL, 0 }
 };
 
-static int
-slap_sb_uri(
-       struct berval *val,
-       void *bcp,
-       slap_cf_aux_table *tab0,
-       const char *tabmsg,
-       int unparse )
-{
-       slap_bindconf *bc = bcp;
-       if ( unparse ) {
-               if ( bc->sb_uri.bv_len >= val->bv_len )
-                       return -1;
-               val->bv_len = bc->sb_uri.bv_len;
-               AC_MEMCPY( val->bv_val, bc->sb_uri.bv_val, val->bv_len );
-       } else {
-               bc->sb_uri = *val;
-#ifdef HAVE_TLS
-               if ( ldap_is_ldaps_url( val->bv_val ))
-                       bc->sb_tls_do_init = 1;
-#endif
-       }
-       return 0;
-}
-
 static int 
 slap_keepalive_parse(
        struct berval *val,
@@ -1320,6 +1367,30 @@ slap_keepalive_parse(
        return 0;
 }
 
+static int
+slap_sb_uri(
+       struct berval *val,
+       void *bcp,
+       slap_cf_aux_table *tab0,
+       const char *tabmsg,
+       int unparse )
+{
+       slap_bindconf *bc = bcp;
+       if ( unparse ) {
+               if ( bc->sb_uri.bv_len >= val->bv_len )
+                       return -1;
+               val->bv_len = bc->sb_uri.bv_len;
+               AC_MEMCPY( val->bv_val, bc->sb_uri.bv_val, val->bv_len );
+       } else {
+               bc->sb_uri = *val;
+#ifdef HAVE_TLS
+               if ( ldap_is_ldaps_url( val->bv_val ))
+                       bc->sb_tls_do_init = 1;
+#endif
+       }
+       return 0;
+}
+
 static slap_cf_aux_table bindkey[] = {
        { BER_BVC("uri="), 0, 'x', 1, slap_sb_uri },
        { BER_BVC("version="), offsetof(slap_bindconf, sb_version), 'i', 0, versionkey },
@@ -1572,26 +1643,6 @@ slap_cf_aux_table_unparse( void *src, struct berval *bv, slap_cf_aux_table *tab0
                        }
                        break;
 
-               case 'x':
-                       *ptr++ = ' ';
-                       ptr = lutil_strcopy( ptr, tab->key.bv_val );
-                       if ( tab->quote ) *ptr++ = '"';
-                       if ( tab->aux != NULL ) {
-                               struct berval value;
-                               slap_cf_aux_table_parse_x *func = (slap_cf_aux_table_parse_x *)tab->aux;
-                               int rc;
-
-                               value.bv_val = ptr;
-                               value.bv_len = buf + sizeof( buf ) - ptr;
-
-                               rc = func( &value, (void *)((char *)src + tab->off), tab, "(unparse)", 1 );
-                               if ( rc == 0 ) {
-                                       ptr += value.bv_len;
-                               }
-                       }
-                       if ( tab->quote ) *ptr++ = '"';
-                       break;
-
                default:
                        assert( 0 );
                }
@@ -1746,6 +1797,10 @@ void bindconf_free( slap_bindconf *bc ) {
                bc->sb_tls_crlcheck = NULL;
        }
 #endif
+       if ( bc->sb_tls_ctx ) {
+               ldap_pvt_tls_ctx_free( bc->sb_tls_ctx );
+               bc->sb_tls_ctx = NULL;
+       }
 #endif
 }