]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/connection.c
fix ITS#3834
[openldap] / servers / slapd / connection.c
index d81299aad4612c3f819b6cd9374af4f2fa9c3183..036f7ae0e17f2eeaf8f0371bc9a5cedfeb61158e 100644 (file)
@@ -1,13 +1,34 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2005 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms are permitted
+ * provided that this notice is preserved and that due credit is given
+ * to the University of Michigan at Ann Arbor. The name of the University
+ * may not be used to endorse or promote products derived from this
+ * software without specific prior written permission. This software
+ * is provided ``as is'' without express or implied warranty.
  */
 
 #include "portable.h"
 
 #include <stdio.h>
+#ifdef HAVE_LIMITS_H
 #include <limits.h>
+#endif
 
 #include <ac/socket.h>
 #include <ac/errno.h>
 #include <ac/time.h>
 #include <ac/unistd.h>
 
-#include "ldap_pvt.h"
 #include "lutil.h"
 #include "slap.h"
 
+#ifdef LDAP_SLAPI
+#include "slapi/slapi.h"
+#endif
+
 /* protected by connections_mutex */
 static ldap_pvt_thread_mutex_t connections_mutex;
 static Connection *connections = NULL;
+
+static ldap_pvt_thread_mutex_t conn_nextid_mutex;
 static unsigned long conn_nextid = 0;
 
 /* structure state (protected by connections_mutex) */
@@ -35,16 +61,18 @@ static unsigned long conn_nextid = 0;
 #define SLAP_C_ACTIVE                  0x02    /* one or more threads */
 #define SLAP_C_BINDING                 0x03    /* binding */
 #define SLAP_C_CLOSING                 0x04    /* closing */
+#define SLAP_C_CLIENT                  0x05    /* outbound client conn */
 
 const char *
 connection_state2str( int state )
 {
        switch( state ) {
-       case SLAP_C_INVALID:    return "!";             
-       case SLAP_C_INACTIVE:   return "|";             
-       case SLAP_C_ACTIVE:             return "";                      
+       case SLAP_C_INVALID:    return "!";
+       case SLAP_C_INACTIVE:   return "|";
+       case SLAP_C_ACTIVE:             return "";
        case SLAP_C_BINDING:    return "B";
-       case SLAP_C_CLOSING:    return "C";                     
+       case SLAP_C_CLOSING:    return "C";
+       case SLAP_C_CLIENT:             return "L";
        }
 
        return "?";
@@ -67,39 +95,33 @@ static ldap_pvt_thread_start_t connection_operation;
  */
 int connections_init(void)
 {
+       int i;
+
        assert( connections == NULL );
 
        if( connections != NULL) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO,
-                          "connections_init:  already initialized.\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "connections_init: already initialized.\n",
                        0, 0, 0 );
-#endif
                return -1;
        }
 
        /* should check return of every call */
        ldap_pvt_thread_mutex_init( &connections_mutex );
+       ldap_pvt_thread_mutex_init( &conn_nextid_mutex );
 
        connections = (Connection *) ch_calloc( dtblsize, sizeof(Connection) );
 
        if( connections == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR,
-                          "connections_init: allocation (%d * %ld) of connection "
-                          "array failed\n", dtblsize, (long) sizeof(Connection), 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                        "connections_init: allocation (%d*%ld) of connection array failed\n",
                        dtblsize, (long) sizeof(Connection), 0 );
-#endif
                return -1;
        }
 
-    assert( connections[0].c_struct_state == SLAP_C_UNINITIALIZED );
-    assert( connections[dtblsize-1].c_struct_state == SLAP_C_UNINITIALIZED );
+       assert( connections[0].c_struct_state == SLAP_C_UNINITIALIZED );
+       assert( connections[dtblsize-1].c_struct_state == SLAP_C_UNINITIALIZED );
+
+       for (i=0; i<dtblsize; i++) connections[i].c_conn_idx = i;
 
        /*
         * per entry initialization of the Connection array initialization
@@ -119,13 +141,8 @@ int connections_destroy(void)
        /* should check return of every call */
 
        if( connections == NULL) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO,
-                          "connections_destroy: nothing to destroy.\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "connections_destroy: nothing to destroy.\n",
                        0, 0, 0 );
-#endif
                return -1;
        }
 
@@ -135,6 +152,11 @@ int connections_destroy(void)
                        ldap_pvt_thread_mutex_destroy( &connections[i].c_mutex );
                        ldap_pvt_thread_mutex_destroy( &connections[i].c_write_mutex );
                        ldap_pvt_thread_cond_destroy( &connections[i].c_write_cv );
+#ifdef LDAP_SLAPI
+                       if ( slapi_plugins_used ) {
+                               slapi_int_free_object_extensions( SLAPI_X_EXT_CONNECTION, &connections[i] );
+                       }
+#endif
                }
        }
 
@@ -142,6 +164,7 @@ int connections_destroy(void)
        connections = NULL;
 
        ldap_pvt_thread_mutex_destroy( &connections_mutex );
+       ldap_pvt_thread_mutex_destroy( &conn_nextid_mutex );
        return 0;
 }
 
@@ -158,6 +181,12 @@ int connections_shutdown(void)
                if( connections[i].c_struct_state != SLAP_C_USED ) {
                        continue;
                }
+               /* give persistent clients a chance to cleanup */
+               if( connections[i].c_conn_state == SLAP_C_CLIENT ) {
+                       ldap_pvt_thread_pool_submit( &connection_pool,
+                       connections[i].c_clientfunc, connections[i].c_clientarg );
+                       continue;
+               }
 
                ldap_pvt_thread_mutex_lock( &connections[i].c_mutex );
 
@@ -186,6 +215,11 @@ int connections_timeout_idle(time_t now)
                c != NULL;
                c = connection_next( c, &connindex ) )
        {
+               /* Don't timeout a slow-running request or a persistent
+                * outbound connection */
+               if( c->c_n_ops_executing ||
+                       c->c_conn_state == SLAP_C_CLIENT ) continue;
+
                if( difftime( c->c_activitytime+global_idletimeout, now) < 0 ) {
                        /* close it */
                        connection_closing( c );
@@ -204,13 +238,9 @@ static Connection* connection_get( ber_socket_t s )
 
        Connection *c;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( CONNECTION, ENTRY, "connection_get: socket %ld\n", (long)s, 0, 0 );
-#else
        Debug( LDAP_DEBUG_ARGS,
                "connection_get(%ld)\n",
                (long) s, 0, 0 );
-#endif
 
        assert( connections != NULL );
 
@@ -268,27 +298,17 @@ static Connection* connection_get( ber_socket_t s )
                        assert( c->c_conn_state == SLAP_C_INVALID );
                        assert( sd == AC_SOCKET_INVALID );
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, ARGS, 
-                               "connection_get:  connection %d not used\n", s, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                                "connection_get(%d): connection not used\n",
                                s, 0, 0 );
-#endif
 
                        ldap_pvt_thread_mutex_unlock( &c->c_mutex );
                        return NULL;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, RESULTS, 
-                       "connection_get: get for %d got connid %lu\n", s, c->c_connid, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "connection_get(%d): got connid=%lu\n",
                        s, c->c_connid, 0 );
-#endif
 
                c->c_n_get++;
 
@@ -296,13 +316,12 @@ static Connection* connection_get( ber_socket_t s )
                assert( c->c_conn_state != SLAP_C_INVALID );
                assert( sd != AC_SOCKET_INVALID );
 
-#ifdef SLAPD_MONITOR
-               c->c_activitytime = slap_get_time();
-#else
-               if( global_idletimeout > 0 ) {
+#ifndef SLAPD_MONITOR
+               if ( global_idletimeout > 0 )
+#endif /* ! SLAPD_MONITOR */
+               {
                        c->c_activitytime = slap_get_time();
                }
-#endif
        }
 
        return c;
@@ -318,9 +337,9 @@ long connection_init(
        Listener *listener,
        const char* dnsname,
        const char* peername,
-       int tls_udp_option,
+       int flags,
        slap_ssf_t ssf,
-       const char *authid )
+       struct berval *authid )
 {
        unsigned long id;
        Connection *c;
@@ -332,18 +351,12 @@ long connection_init(
        assert( peername != NULL );
 
 #ifndef HAVE_TLS
-       assert( tls_udp_option != 1 );
+       assert( flags != CONN_IS_TLS );
 #endif
 
        if( s == AC_SOCKET_INVALID ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                          "connection_init: init of socket %ld invalid.\n", (long)s, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
-                      "connection_init(%ld): invalid.\n",
-                      (long) s, 0, 0 );
-#endif
+                       "connection_init: init of socket %ld invalid.\n", (long)s, 0, 0 );
                return -1;
        }
 
@@ -359,48 +372,47 @@ long connection_init(
 
 #else
        {
-               ber_socket_t    i;
-
+               ber_socket_t i;
                c = NULL;
 
-       for( i=0; i < dtblsize; i++) {
-               ber_socket_t    sd;
+               for( i=0; i < dtblsize; i++) {
+                       ber_socket_t    sd;
 
-           if( connections[i].c_struct_state == SLAP_C_UNINITIALIZED ) {
-               assert( connections[i].c_sb == 0 );
-               c = &connections[i];
-               break;
-           }
+                       if( connections[i].c_struct_state == SLAP_C_UNINITIALIZED ) {
+                               assert( connections[i].c_sb == 0 );
+                               c = &connections[i];
+                               break;
+                       }
 
                        sd = AC_SOCKET_INVALID;
-                       if (connections[i].c_sb != NULL)
-                       ber_sockbuf_ctrl( connections[i].c_sb, LBER_SB_OPT_GET_FD, &sd );
-           
-           if( connections[i].c_struct_state == SLAP_C_UNUSED ) {
-               assert( sd == AC_SOCKET_INVALID );
-               c = &connections[i];
-               break;
-           }
+                       if (connections[i].c_sb != NULL) {
+                               ber_sockbuf_ctrl( connections[i].c_sb,
+                                       LBER_SB_OPT_GET_FD, &sd );
+                       }
 
-           assert( connections[i].c_struct_state == SLAP_C_USED );
-           assert( connections[i].c_conn_state != SLAP_C_INVALID );
-           assert( sd != AC_SOCKET_INVALID );
-       }
+                       if( connections[i].c_struct_state == SLAP_C_UNUSED ) {
+                               assert( sd == AC_SOCKET_INVALID );
+                               c = &connections[i];
+                               break;
+                       }
 
-       if( c == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                          "connection_init: skt %d connection table full "
-                          "(%d/%d)\n", s, i, dtblsize );
-#else
-               Debug( LDAP_DEBUG_ANY,
+                       if( connections[i].c_conn_state == SLAP_C_CLIENT ) {
+                               continue;
+                       }
+
+                       assert( connections[i].c_struct_state == SLAP_C_USED );
+                       assert( connections[i].c_conn_state != SLAP_C_INVALID );
+                       assert( sd != AC_SOCKET_INVALID );
+               }
+
+               if( c == NULL ) {
+                       Debug( LDAP_DEBUG_ANY,
                                "connection_init(%d): connection table full "
                                "(%d/%d)\n", s, i, dtblsize);
-#endif
-           ldap_pvt_thread_mutex_unlock( &connections_mutex );
-           return -1;
+                       ldap_pvt_thread_mutex_unlock( &connections_mutex );
+                       return -1;
+               }
        }
-       }
 #endif
 
        assert( c != NULL );
@@ -410,30 +422,25 @@ long connection_init(
                c->c_send_search_entry = slap_send_search_entry;
                c->c_send_search_reference = slap_send_search_reference;
                c->c_send_ldap_extended = slap_send_ldap_extended;
-#ifdef LDAP_RES_INTERMEDIATE_RESP
-               c->c_send_ldap_intermediate_resp = slap_send_ldap_intermediate_resp;
+#ifdef LDAP_RES_INTERMEDIATE
+               c->c_send_ldap_intermediate = slap_send_ldap_intermediate;
 #endif
 
-               c->c_authmech.bv_val = NULL;
-               c->c_authmech.bv_len = 0;
-               c->c_dn.bv_val = NULL;
-               c->c_dn.bv_len = 0;
-               c->c_ndn.bv_val = NULL;
-               c->c_ndn.bv_len = 0;
-               c->c_groups = NULL;
+               BER_BVZERO( &c->c_authmech );
+               BER_BVZERO( &c->c_dn );
+               BER_BVZERO( &c->c_ndn );
 
                c->c_listener = NULL;
-               c->c_peer_domain.bv_val = NULL;
-               c->c_peer_domain.bv_len = 0;
-               c->c_peer_name.bv_val = NULL;
-               c->c_peer_name.bv_len = 0;
+               BER_BVZERO( &c->c_peer_domain );
+               BER_BVZERO( &c->c_peer_name );
 
                LDAP_STAILQ_INIT(&c->c_ops);
                LDAP_STAILQ_INIT(&c->c_pending_ops);
 
-               c->c_sasl_bind_mech.bv_val = NULL;
-               c->c_sasl_bind_mech.bv_len = 0;
-               c->c_sasl_context = NULL;
+               BER_BVZERO( &c->c_sasl_bind_mech );
+               c->c_sasl_done = 0;
+               c->c_sasl_authctx = NULL;
+               c->c_sasl_sockctx = NULL;
                c->c_sasl_extra = NULL;
                c->c_sasl_bindop = NULL;
 
@@ -451,35 +458,54 @@ long connection_init(
                ldap_pvt_thread_mutex_init( &c->c_write_mutex );
                ldap_pvt_thread_cond_init( &c->c_write_cv );
 
+#ifdef LDAP_SLAPI
+               if ( slapi_plugins_used ) {
+                       slapi_int_create_object_extensions( SLAPI_X_EXT_CONNECTION, c );
+               }
+#endif
+
                c->c_struct_state = SLAP_C_UNUSED;
        }
 
-    ldap_pvt_thread_mutex_lock( &c->c_mutex );
-
-    assert( c->c_struct_state == SLAP_C_UNUSED );
-    assert( c->c_authmech.bv_val == NULL );
-    assert( c->c_dn.bv_val == NULL );
-    assert( c->c_ndn.bv_val == NULL );
-    assert( c->c_groups == NULL );
-    assert( c->c_listener == NULL );
-    assert( c->c_peer_domain.bv_val == NULL );
-    assert( c->c_peer_name.bv_val == NULL );
-    assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
-    assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) );
-       assert( c->c_sasl_bind_mech.bv_val == NULL );
-       assert( c->c_sasl_context == NULL );
+       ldap_pvt_thread_mutex_lock( &c->c_mutex );
+
+       assert( c->c_struct_state == SLAP_C_UNUSED );
+       assert( BER_BVISNULL( &c->c_authmech ) );
+       assert( BER_BVISNULL( &c->c_dn ) );
+       assert( BER_BVISNULL( &c->c_ndn ) );
+       assert( c->c_listener == NULL );
+       assert( BER_BVISNULL( &c->c_peer_domain ) );
+       assert( BER_BVISNULL( &c->c_peer_name ) );
+       assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
+       assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) );
+       assert( BER_BVISNULL( &c->c_sasl_bind_mech ) );
+       assert( c->c_sasl_done == 0 );
+       assert( c->c_sasl_authctx == NULL );
+       assert( c->c_sasl_sockctx == NULL );
        assert( c->c_sasl_extra == NULL );
        assert( c->c_sasl_bindop == NULL );
        assert( c->c_currentber == NULL );
+       assert( c->c_writewaiter == 0);
 
        c->c_listener = listener;
+
+       if ( flags == CONN_IS_CLIENT ) {
+               c->c_conn_state = SLAP_C_CLIENT;
+               c->c_struct_state = SLAP_C_USED;
+               ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_FD, &s );
+               ldap_pvt_thread_mutex_unlock( &c->c_mutex );
+               ldap_pvt_thread_mutex_unlock( &connections_mutex );
+
+               return 0;
+       }
+
        ber_str2bv( dnsname, 0, 1, &c->c_peer_domain );
        ber_str2bv( peername, 0, 1, &c->c_peer_name );
 
-    c->c_n_ops_received = 0;
-    c->c_n_ops_executing = 0;
-    c->c_n_ops_pending = 0;
-    c->c_n_ops_completed = 0;
+       c->c_n_ops_received = 0;
+       c->c_n_ops_executing = 0;
+       c->c_n_ops_pending = 0;
+       c->c_n_ops_completed = 0;
 
        c->c_n_get = 0;
        c->c_n_read = 0;
@@ -488,17 +514,16 @@ long connection_init(
        /* set to zero until bind, implies LDAP_VERSION3 */
        c->c_protocol = 0;
 
-#ifdef SLAPD_MONITOR
-       c->c_activitytime = c->c_starttime = slap_get_time();
-#else
-       if( global_idletimeout > 0 ) {
+#ifndef SLAPD_MONITOR
+       if ( global_idletimeout > 0 )
+#endif /* ! SLAPD_MONITOR */
+       {
                c->c_activitytime = c->c_starttime = slap_get_time();
        }
-#endif
 
 #ifdef LDAP_CONNECTIONLESS
        c->c_is_udp = 0;
-       if( tls_udp_option == 2 ) {
+       if( flags == CONN_IS_UDP ) {
                c->c_is_udp = 1;
 #ifdef LDAP_DEBUG
                ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_debug,
@@ -527,44 +552,40 @@ long connection_init(
        if( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_NONBLOCK,
                c /* non-NULL */ ) < 0 )
        {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                          "connection_init: conn %lu  set nonblocking failed\n",
-                          c->c_connid, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                        "connection_init(%d, %s): set nonblocking failed\n",
                        s, c->c_peer_name.bv_val, 0 );
-#endif
        }
 
-    id = c->c_connid = conn_nextid++;
+       ldap_pvt_thread_mutex_lock( &conn_nextid_mutex );
+       id = c->c_connid = conn_nextid++;
+       ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex );
 
-    c->c_conn_state = SLAP_C_INACTIVE;
-    c->c_struct_state = SLAP_C_USED;
+       c->c_conn_state = SLAP_C_INACTIVE;
+       c->c_struct_state = SLAP_C_USED;
 
        c->c_ssf = c->c_transport_ssf = ssf;
        c->c_tls_ssf = 0;
 
 #ifdef HAVE_TLS
-    if ( tls_udp_option == 1 ) {
-           c->c_is_tls = 1;
-           c->c_needs_tls_accept = 1;
-    } else {
-           c->c_is_tls = 0;
-           c->c_needs_tls_accept = 0;
-    }
+       if ( flags == CONN_IS_TLS ) {
+               c->c_is_tls = 1;
+               c->c_needs_tls_accept = 1;
+       } else {
+               c->c_is_tls = 0;
+               c->c_needs_tls_accept = 0;
+       }
 #endif
 
-       slap_sasl_open( c );
+       slap_sasl_open( c, 0 );
        slap_sasl_external( c, ssf, authid );
 
-    ldap_pvt_thread_mutex_unlock( &c->c_mutex );
-    ldap_pvt_thread_mutex_unlock( &connections_mutex );
+       ldap_pvt_thread_mutex_unlock( &c->c_mutex );
+       ldap_pvt_thread_mutex_unlock( &connections_mutex );
 
-    backend_connection_init(c);
+       backend_connection_init(c);
 
-    return id;
+       return id;
 }
 
 void connection2anonymous( Connection *c )
@@ -579,76 +600,66 @@ void connection2anonymous( Connection *c )
 
        if(c->c_authmech.bv_val != NULL ) {
                free(c->c_authmech.bv_val);
-               c->c_authmech.bv_val = NULL;
        }
-       c->c_authmech.bv_len = 0;
+       BER_BVZERO( &c->c_authmech );
 
        if(c->c_dn.bv_val != NULL) {
                free(c->c_dn.bv_val);
-               c->c_dn.bv_val = NULL;
        }
-       c->c_dn.bv_len = 0;
+       BER_BVZERO( &c->c_dn );
        if(c->c_ndn.bv_val != NULL) {
                free(c->c_ndn.bv_val);
-               c->c_ndn.bv_val = NULL;
        }
-       c->c_ndn.bv_len = 0;
+       BER_BVZERO( &c->c_ndn );
+       if(c->c_sasl_authz_dn.bv_val != NULL) {
+               free(c->c_sasl_authz_dn.bv_val);
+       }
+       BER_BVZERO( &c->c_sasl_authz_dn );
 
        c->c_authz_backend = NULL;
-       
-       {
-               GroupAssertion *g, *n;
-               for (g = c->c_groups; g; g=n) {
-                       n = g->ga_next;
-                       free(g);
-               }
-               c->c_groups = NULL;
-       }
 }
 
 static void
 connection_destroy( Connection *c )
 {
        /* note: connections_mutex should be locked by caller */
-    ber_socket_t       sd;
-    unsigned long      connid;
+       ber_socket_t    sd;
+       unsigned long   connid;
 
-    assert( connections != NULL );
-    assert( c != NULL );
-    assert( c->c_struct_state != SLAP_C_UNUSED );
-    assert( c->c_conn_state != SLAP_C_INVALID );
-    assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
+       assert( connections != NULL );
+       assert( c != NULL );
+       assert( c->c_struct_state != SLAP_C_UNUSED );
+       assert( c->c_conn_state != SLAP_C_INVALID );
+       assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
+       assert( c->c_writewaiter == 0);
 
-    /* only for stats (print -1 as "%lu" may give unexpected results ;) */
-    connid = c->c_connid;
+       /* only for stats (print -1 as "%lu" may give unexpected results ;) */
+       connid = c->c_connid;
 
-    backend_connection_destroy(c);
+       backend_connection_destroy(c);
 
-    c->c_protocol = 0;
-    c->c_connid = -1;
+       c->c_protocol = 0;
+       c->c_connid = -1;
 
-    c->c_activitytime = c->c_starttime = 0;
+       c->c_activitytime = c->c_starttime = 0;
 
        connection2anonymous( c );
        c->c_listener = NULL;
 
        if(c->c_peer_domain.bv_val != NULL) {
                free(c->c_peer_domain.bv_val);
-               c->c_peer_domain.bv_val = NULL;
        }
-       c->c_peer_domain.bv_len = 0;
+       BER_BVZERO( &c->c_peer_domain );
        if(c->c_peer_name.bv_val != NULL) {
                free(c->c_peer_name.bv_val);
-               c->c_peer_name.bv_val = NULL;
        }
-       c->c_peer_name.bv_len = 0;
+       BER_BVZERO( &c->c_peer_name );
 
        c->c_sasl_bind_in_progress = 0;
        if(c->c_sasl_bind_mech.bv_val != NULL) {
                free(c->c_sasl_bind_mech.bv_val);
-               c->c_sasl_bind_mech.bv_val = NULL;
        }
-       c->c_sasl_bind_mech.bv_len = 0;
+       BER_BVZERO( &c->c_sasl_bind_mech );
 
        slap_sasl_close( c );
 
@@ -659,11 +670,11 @@ connection_destroy( Connection *c )
 
        ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd );
        if ( sd != AC_SOCKET_INVALID ) {
-               slapd_remove( sd, 0 );
+               slapd_remove( sd, 1, 0 );
 
                Statslog( LDAP_DEBUG_STATS,
-                   "conn=%lu fd=%d closed\n",
-                       connid, sd, 0, 0, 0 );
+                       "conn=%lu fd=%ld closed\n",
+                       connid, (long) sd, 0, 0, 0 );
        }
 
        ber_sockbuf_free( c->c_sb );
@@ -675,8 +686,15 @@ connection_destroy( Connection *c )
                ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_MAX_INCOMING, &max );
        }
 
-    c->c_conn_state = SLAP_C_INVALID;
-    c->c_struct_state = SLAP_C_UNUSED;
+       c->c_conn_state = SLAP_C_INVALID;
+       c->c_struct_state = SLAP_C_UNUSED;
+
+#ifdef LDAP_SLAPI
+       /* call destructors, then constructors; avoids unnecessary allocation */
+       if ( slapi_plugins_used ) {
+               slapi_int_clear_object_extensions( SLAPI_X_EXT_CONNECTION, c );
+       }
+#endif
 }
 
 int connection_state_closing( Connection *c )
@@ -698,10 +716,20 @@ static void connection_abandon( Connection *c )
 {
        /* c_mutex must be locked by caller */
 
-       Operation *o;
-
-       LDAP_STAILQ_FOREACH(o, &c->c_ops, o_next) {
+       Operation *o, *next, op = {0};
+       Opheader ohdr = {0};
+       SlapReply rs = {0};
+
+       op.o_hdr = &ohdr;
+       op.o_conn = c;
+       op.o_connid = c->c_connid;
+       op.o_tag = LDAP_REQ_ABANDON;
+       for ( o = LDAP_STAILQ_FIRST( &c->c_ops ); o; o=next ) {
+               next = LDAP_STAILQ_NEXT( o, o_next );
+               op.orn_msgid = o->o_msgid;
                o->o_abandon = 1;
+               op.o_bd = frontendDB;
+               frontendDB->be_abandon( &op, &rs );
        }
 
        /* remove pending operations */
@@ -725,15 +753,9 @@ void connection_closing( Connection *c )
                ber_socket_t    sd;
 
                ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd );
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, DETAIL1, 
-                          "connection_closing: conn %lu readying socket %d for close.\n",
-                          c->c_connid, sd, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "connection_closing: readying conn=%lu sd=%d for close\n",
                        c->c_connid, sd, 0 );
-#endif
                /* update state to closing */
                c->c_conn_state = SLAP_C_CLOSING;
 
@@ -745,7 +767,12 @@ void connection_closing( Connection *c )
 
                /* wake write blocked operations */
                slapd_clr_write( sd, 1 );
-               ldap_pvt_thread_cond_signal( &c->c_write_cv );
+               if ( c->c_writewaiter ) {
+                       ldap_pvt_thread_cond_signal( &c->c_write_cv );
+                       ldap_pvt_thread_mutex_unlock( &c->c_mutex );
+                       ldap_pvt_thread_yield();
+                       ldap_pvt_thread_mutex_lock( &c->c_mutex );
+               }
        }
 }
 
@@ -762,25 +789,14 @@ static void connection_close( Connection *c )
 
        ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd );
        if( !LDAP_STAILQ_EMPTY(&c->c_ops) ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, DETAIL1, 
-                          "connection_close: conn %lu  deferring sd %d\n",
-                          c->c_connid, sd, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "connection_close: deferring conn=%lu sd=%d\n",
                        c->c_connid, sd, 0 );
-#endif
                return;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( CONNECTION, RESULTS, 
-                  "connection_close: conn %lu  sd %d\n", c->c_connid, sd, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "connection_close: conn=%lu sd=%d\n",
                c->c_connid, sd, 0 );
-#endif
        connection_destroy( c );
 }
 
@@ -867,214 +883,203 @@ void connection_done( Connection *c )
  */
 
 #ifdef SLAPD_MONITOR
-#define INCR_OP(var,index) \
+/* FIXME: returns 0 in case of failure */
+#define INCR_OP_INITIATED(index) \
        do { \
-               ldap_pvt_thread_mutex_lock( &num_ops_mutex ); \
-               (var)[(index)]++; \
-               ldap_pvt_thread_mutex_unlock( &num_ops_mutex ); \
+               ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex ); \
+               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_initiated_[(index)], 1); \
+               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex ); \
+       } while (0)
+#define INCR_OP_COMPLETED(index) \
+       do { \
+               ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex ); \
+               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_completed, 1); \
+               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_completed_[(index)], 1); \
+               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex ); \
        } while (0)
 #else /* !SLAPD_MONITOR */
-#define INCR_OP(var,index) 
+#define INCR_OP_INITIATED(index) 
+#define INCR_OP_COMPLETED(index) \
+       do { \
+               ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex ); \
+               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_completed, 1); \
+               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex ); \
+       } while (0)
 #endif /* !SLAPD_MONITOR */
 
+/*
+ * NOTE: keep in sync with enum in slapd.h
+ */
+static int (*opfun[])( Operation *op, SlapReply *rs ) = {
+       do_bind,
+       do_unbind,
+       do_add,
+       do_delete,
+       do_modrdn,
+       do_modify,
+       do_compare,
+       do_search,
+       do_abandon,
+       do_extended,
+       NULL
+};
+
 static void *
 connection_operation( void *ctx, void *arg_v )
 {
-       int rc = SLAPD_DISCONNECT;
+       int rc = LDAP_OTHER;
        Operation *op = arg_v;
        SlapReply rs = {REP_RESULT};
        ber_tag_t tag = op->o_tag;
-#ifdef SLAPD_MONITOR
-       ber_tag_t oldtag = tag;
-#endif /* SLAPD_MONITOR */
+       int opidx = -1;
        Connection *conn = op->o_conn;
-       void *memctx;
+       void *memctx = NULL;
+       void *memctx_null = NULL;
+       ber_len_t memsiz;
 
-       ldap_pvt_thread_mutex_lock( &num_ops_mutex );
-       num_ops_initiated++;
-       ldap_pvt_thread_mutex_unlock( &num_ops_mutex );
+       ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex );
+       /* FIXME: returns 0 in case of failure */
+       ldap_pvt_mp_add_ulong(slap_counters.sc_ops_initiated, 1);
+       ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex );
 
        op->o_threadctx = ctx;
 
+       switch ( tag ) {
+       case LDAP_REQ_BIND:
+       case LDAP_REQ_UNBIND:
+       case LDAP_REQ_ADD:
+       case LDAP_REQ_DELETE:
+       case LDAP_REQ_MODDN:
+       case LDAP_REQ_MODIFY:
+       case LDAP_REQ_COMPARE:
+       case LDAP_REQ_SEARCH:
+       case LDAP_REQ_ABANDON:
+       case LDAP_REQ_EXTENDED:
+               break;
+       default:
+               Debug( LDAP_DEBUG_ANY, "connection_operation: "
+                       "conn %lu unknown LDAP request 0x%lx\n",
+                       conn->c_connid, tag, 0 );
+               op->o_tag = LBER_ERROR;
+               rs.sr_err = LDAP_PROTOCOL_ERROR;
+               rs.sr_text = "unknown LDAP request";
+               send_ldap_disconnect( op, &rs );
+               rc = SLAPD_DISCONNECT;
+               goto operations_error;
+       }
+
        if( conn->c_sasl_bind_in_progress && tag != LDAP_REQ_BIND ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_operation: conn %lu SASL bind in progress (tag=%ld).\n",
-                       conn->c_connid, (long)tag, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "connection_operation: "
                        "error: SASL bind in progress (tag=%ld).\n",
                        (long) tag, 0, 0 );
-#endif
                send_ldap_error( op, &rs, LDAP_OPERATIONS_ERROR,
                        "SASL bind in progress" );
+               rc = LDAP_OPERATIONS_ERROR;
                goto operations_error;
        }
 
-       /* For all operations besides Add, we can use thread-local
-        * storage for most mallocs.
+       /* We can use Thread-Local storage for most mallocs. We can
+        * also use TL for ber parsing, but not on Add or Modify.
         */
-#define        SLAB_SIZE       1048576
-       if ( tag == LDAP_REQ_SEARCH ) {
-               memctx = sl_mem_create( SLAB_SIZE, ctx );
-               ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, memctx );
-               op->o_tmpmemctx = memctx;
-               op->o_tmpmfuncs = &sl_mfuncs;
-       } else {
-               op->o_tmpmemctx = NULL;
-               op->o_tmpmfuncs = &ch_mfuncs;
+#if 0
+       memsiz = ber_len( op->o_ber ) * 64;
+       if ( SLAP_SLAB_SIZE > memsiz ) memsiz = SLAP_SLAB_SIZE;
+#endif
+       memsiz = SLAP_SLAB_SIZE;
+
+       memctx = slap_sl_mem_create( memsiz, SLAP_SLAB_STACK, ctx );
+       op->o_tmpmemctx = memctx;
+       op->o_tmpmfuncs = &slap_sl_mfuncs;
+       if ( tag != LDAP_REQ_ADD && tag != LDAP_REQ_MODIFY ) {
+               /* Note - the ber and its buffer are already allocated from
+                * regular memory; this only affects subsequent mallocs that
+                * ber_scanf may invoke.
+                */
+               ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, &memctx );
        }
 
        switch ( tag ) {
        case LDAP_REQ_BIND:
-               INCR_OP(num_ops_initiated_, SLAP_OP_BIND);
-               rc = do_bind( op, &rs );
+               opidx = SLAP_OP_BIND;
                break;
 
        case LDAP_REQ_UNBIND:
-               INCR_OP(num_ops_initiated_, SLAP_OP_UNBIND);
-               rc = do_unbind( op, &rs );
+               opidx = SLAP_OP_UNBIND;
                break;
 
        case LDAP_REQ_ADD:
-               INCR_OP(num_ops_initiated_, SLAP_OP_ADD);
-               rc = do_add( op, &rs );
+               opidx = SLAP_OP_ADD;
                break;
 
        case LDAP_REQ_DELETE:
-               INCR_OP(num_ops_initiated_, SLAP_OP_DELETE);
-               rc = do_delete( op, &rs );
+               opidx = SLAP_OP_DELETE;
                break;
 
        case LDAP_REQ_MODRDN:
-               INCR_OP(num_ops_initiated_, SLAP_OP_MODRDN);
-               rc = do_modrdn( op, &rs );
+               opidx = SLAP_OP_MODRDN;
                break;
 
        case LDAP_REQ_MODIFY:
-               INCR_OP(num_ops_initiated_, SLAP_OP_MODIFY);
-               rc = do_modify( op, &rs );
+               opidx = SLAP_OP_MODIFY;
                break;
 
        case LDAP_REQ_COMPARE:
-               INCR_OP(num_ops_initiated_, SLAP_OP_COMPARE);
-               rc = do_compare( op, &rs );
+               opidx = SLAP_OP_COMPARE;
                break;
 
        case LDAP_REQ_SEARCH:
-               INCR_OP(num_ops_initiated_, SLAP_OP_SEARCH);
-               rc = do_search( op, &rs );
+               opidx = SLAP_OP_SEARCH;
                break;
 
        case LDAP_REQ_ABANDON:
-               INCR_OP(num_ops_initiated_, SLAP_OP_ABANDON);
-               rc = do_abandon( op, &rs );
+               opidx = SLAP_OP_ABANDON;
                break;
 
        case LDAP_REQ_EXTENDED:
-               INCR_OP(num_ops_initiated_, SLAP_OP_EXTENDED);
-               rc = do_extended( op, &rs );
+               opidx = SLAP_OP_EXTENDED;
                break;
 
        default:
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                          "connection_operation: conn %lu  unknown LDAP request 0x%lx\n",
-                          conn->c_connid, tag, 0  );
-#else
-               Debug( LDAP_DEBUG_ANY, "unknown LDAP request 0x%lx\n",
-                   tag, 0, 0 );
-#endif
-               op->o_tag = LBER_ERROR;
-               rs.sr_err = LDAP_PROTOCOL_ERROR;
-               rs.sr_text = "unknown LDAP request";
-               send_ldap_disconnect( op, &rs );
-               rc = -1;
-               break;
+               /* not reachable */
+               assert( 0 );
        }
 
-#ifdef SLAPD_MONITOR
-       oldtag = tag;
-#endif /* SLAPD_MONITOR */
-       if( rc == SLAPD_DISCONNECT ) tag = LBER_ERROR;
+       assert( opidx > -1 );
+       INCR_OP_INITIATED( opidx );
+       rc = (*(opfun[opidx]))( op, &rs );
 
 operations_error:
-       ldap_pvt_thread_mutex_lock( &num_ops_mutex );
-       num_ops_completed++;
-#ifdef SLAPD_MONITOR
-       switch (oldtag) {
-       case LDAP_REQ_BIND:
-               num_ops_completed_[SLAP_OP_BIND]++;
-               break;
-       case LDAP_REQ_UNBIND:
-               num_ops_completed_[SLAP_OP_UNBIND]++;
-               break;
-       case LDAP_REQ_ADD:
-               num_ops_completed_[SLAP_OP_ADD]++;
-               break;
-       case LDAP_REQ_DELETE:
-               num_ops_completed_[SLAP_OP_DELETE]++;
-               break;
-       case LDAP_REQ_MODRDN:
-               num_ops_completed_[SLAP_OP_MODRDN]++;
-               break;
-       case LDAP_REQ_MODIFY:
-               num_ops_completed_[SLAP_OP_MODIFY]++;
-               break;
-       case LDAP_REQ_COMPARE:
-               num_ops_completed_[SLAP_OP_COMPARE]++;
-               break;
-       case LDAP_REQ_SEARCH:
-               num_ops_completed_[SLAP_OP_SEARCH]++;
-               break;
-       case LDAP_REQ_ABANDON:
-               num_ops_completed_[SLAP_OP_ABANDON]++;
-               break;
-       case LDAP_REQ_EXTENDED:
-               num_ops_completed_[SLAP_OP_EXTENDED]++;
-               break;
+       if ( rc == SLAPD_DISCONNECT ) {
+               tag = LBER_ERROR;
+
+       } else if ( opidx > -1 ) {
+               /* increment completed operations count 
+                * only if operation was initiated
+                * and rc != SLAPD_DISCONNECT */
+               INCR_OP_COMPLETED( opidx );
        }
-#endif /* SLAPD_MONITOR */
-       ldap_pvt_thread_mutex_unlock( &num_ops_mutex );
 
-#ifdef LDAP_EXOP_X_CANCEL
        if ( op->o_cancel == SLAP_CANCEL_REQ ) {
-               op->o_cancel = LDAP_TOO_LATE;
+               if ( rc == SLAPD_ABANDON )
+                       op->o_cancel = SLAP_CANCEL_ACK;
+               else
+                       op->o_cancel = LDAP_TOO_LATE;
        }
-
        while ( op->o_cancel != SLAP_CANCEL_NONE &&
                op->o_cancel != SLAP_CANCEL_DONE )
        {
                ldap_pvt_thread_yield();
        }
-#endif
 
        ldap_pvt_thread_mutex_lock( &conn->c_mutex );
 
-       conn->c_n_ops_executing--;
-       conn->c_n_ops_completed++;
+       ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, &memctx_null );
 
        LDAP_STAILQ_REMOVE( &conn->c_ops, op, slap_op, o_next);
        LDAP_STAILQ_NEXT(op, o_next) = NULL;
-
-#if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
-       if ( op->o_cancel == SLAP_CANCEL_ACK )
-               goto co_op_free;
-#endif
-#ifdef LDAP_CLIENT_UPDATE
-       if ( ( op->o_clientupdate_type & SLAP_LCUP_PERSIST ) )
-               goto no_co_op_free;
-#endif
-#ifdef LDAP_SYNC
-       if ( ( op->o_sync_mode & SLAP_SYNC_PERSIST ) )
-               goto no_co_op_free;
-#endif
-
-co_op_free:
-
        slap_op_free( op );
-
-no_co_op_free:
+       conn->c_n_ops_executing--;
+       conn->c_n_ops_completed++;
 
        switch( tag ) {
        case LBER_ERROR:
@@ -1093,12 +1098,56 @@ no_co_op_free:
        }
 
        connection_resched( conn );
-
        ldap_pvt_thread_mutex_unlock( &conn->c_mutex );
-
        return NULL;
 }
 
+static const Listener dummy_list = { BER_BVC(""), BER_BVC("") };
+
+int connection_client_setup(
+       ber_socket_t s,
+       ldap_pvt_thread_start_t *func,
+       void *arg )
+{
+       int rc;
+       Connection *c;
+
+       rc = connection_init( s, (Listener *)&dummy_list, "", "",
+               CONN_IS_CLIENT, 0, NULL );
+       if ( rc < 0 ) return -1;
+
+       c = connection_get( s );
+       c->c_clientfunc = func;
+       c->c_clientarg = arg;
+       connection_return( c );
+       slapd_add_internal( s, 0 );
+       slapd_set_read( s, 1 );
+       return 0;
+}
+
+void connection_client_enable(
+       ber_socket_t s )
+{
+       slapd_set_read( s, 1 );
+}
+
+void connection_client_stop(
+       ber_socket_t s )
+{
+       Connection *c;
+
+       /* get (locked) connection */
+       c = connection_get( s );
+       
+       assert( c->c_conn_state == SLAP_C_CLIENT );
+
+       c->c_listener = NULL;
+       c->c_conn_state = SLAP_C_INVALID;
+       c->c_struct_state = SLAP_C_UNUSED;
+       connection_return( c );
+       slapd_remove( s, 0, 1 );
+}
+
 int connection_read(ber_socket_t s)
 {
        int rc = 0;
@@ -1112,15 +1161,10 @@ int connection_read(ber_socket_t s)
        c = connection_get( s );
 
        if( c == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                       "connection_read: sock %ld no connection\n", (long)s, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                        "connection_read(%ld): no connection!\n",
                        (long) s, 0, 0 );
-#endif
-               slapd_remove(s, 0);
+               slapd_remove(s, 1, 0);
 
                ldap_pvt_thread_mutex_unlock( &connections_mutex );
                return -1;
@@ -1129,49 +1173,40 @@ int connection_read(ber_socket_t s)
        c->c_n_read++;
 
        if( c->c_conn_state == SLAP_C_CLOSING ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                       "connection_read: conn %lu connection closing, ignoring input\n",
-                       c->c_connid, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "connection_read(%d): closing, ignoring input for id=%lu\n",
                        s, c->c_connid, 0 );
-#endif
                connection_return( c );
                ldap_pvt_thread_mutex_unlock( &connections_mutex );
                return 0;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( CONNECTION, DETAIL1, 
-                  "connection_read: conn %lu  checking for input.\n", 
-                  c->c_connid, 0, 0  );
-#else
+       if ( c->c_conn_state == SLAP_C_CLIENT ) {
+               slapd_clr_read( s, 0 );
+               ldap_pvt_thread_pool_submit( &connection_pool,
+                       c->c_clientfunc, c->c_clientarg );
+               connection_return( c );
+               ldap_pvt_thread_mutex_unlock( &connections_mutex );
+               return 0;
+       }
+
        Debug( LDAP_DEBUG_TRACE,
                "connection_read(%d): checking for input on id=%lu\n",
                s, c->c_connid, 0 );
-#endif
 
 #ifdef HAVE_TLS
        if ( c->c_is_tls && c->c_needs_tls_accept ) {
-               rc = ldap_pvt_tls_accept( c->c_sb, NULL );
+               rc = ldap_pvt_tls_accept( c->c_sb, slap_tls_ctx );
                if ( rc < 0 ) {
 #if 0 /* required by next #if 0 */
                        struct timeval tv;
                        fd_set rfd;
 #endif
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, ERR, 
-                                  "connection_read: conn %lu  TLS accept error, error %d\n",
-                                  c->c_connid, rc, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                                "connection_read(%d): TLS accept error "
                                "error=%d id=%lu, closing\n",
                                s, rc, c->c_connid );
-#endif
                        c->c_needs_tls_accept = 0;
                        /* connections_mutex and c_mutex are locked */
                        connection_closing( c );
@@ -1182,10 +1217,10 @@ int connection_read(ber_socket_t s)
                        FD_ZERO(&rfd);
                        FD_SET(s, &rfd);
                        for (rc=1; rc>0;) {
-                           tv.tv_sec = 1;
-                           tv.tv_usec = 0;
-                           rc = select(s+1, &rfd, NULL, NULL, &tv);
-                           if (rc == 1) {
+                               tv.tv_sec = 1;
+                               tv.tv_usec = 0;
+                               rc = select(s+1, &rfd, NULL, NULL, &tv);
+                               if (rc == 1) {
                                        ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DRAIN, NULL);
                                }
                        }
@@ -1194,7 +1229,7 @@ int connection_read(ber_socket_t s)
 
                } else if ( rc == 0 ) {
                        void *ssl;
-                       struct berval authid = { 0, NULL };
+                       struct berval authid = BER_BVNULL;
 
                        c->c_needs_tls_accept = 0;
 
@@ -1208,19 +1243,12 @@ int connection_read(ber_socket_t s)
 
                        rc = dnX509peerNormalize( ssl, &authid );
                        if ( rc != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG( CONNECTION, INFO, 
-                                       "connection_read: conn %lu unable to get TLS client DN, "
-                                       "error %d\n", c->c_connid, rc, 0 );
-#else
-                               Debug( LDAP_DEBUG_TRACE,
-                               "connection_read(%d): unable to get TLS client DN "
-                               "error=%d id=%lu\n",
-                               s, rc, c->c_connid );
-#endif
+                               Debug( LDAP_DEBUG_TRACE, "connection_read(%d): "
+                                       "unable to get TLS client DN, error=%d id=%lu\n",
+                                       s, rc, c->c_connid );
                        }
-                       slap_sasl_external( c, c->c_tls_ssf, authid.bv_val );
-                       if ( authid.bv_val )    free( authid.bv_val );
+                       slap_sasl_external( c, c->c_tls_ssf, &authid );
+                       if ( authid.bv_val ) free( authid.bv_val );
                }
 
                /* if success and data is ready, fall thru to data input loop */
@@ -1236,21 +1264,22 @@ int connection_read(ber_socket_t s)
 
 #ifdef HAVE_CYRUS_SASL
        if ( c->c_sasl_layers ) {
+               /* If previous layer is not removed yet, give up for now */
+               if ( !c->c_sasl_sockctx ) {
+                       connection_return( c );
+                       ldap_pvt_thread_mutex_unlock( &connections_mutex );
+                       return 0;
+               }
+
                c->c_sasl_layers = 0;
 
-               rc = ldap_pvt_sasl_install( c->c_sb,  c->c_sasl_context );
+               rc = ldap_pvt_sasl_install( c->c_sb, c->c_sasl_sockctx );
 
                if( rc != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, ERR, 
-                               "connection_read: conn %lu SASL install error %d, closing\n",
-                               c->c_connid, rc, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                                "connection_read(%d): SASL install error "
                                "error=%d id=%lu, closing\n",
                                s, rc, c->c_connid );
-#endif
                        /* connections_mutex and c_mutex are locked */
                        connection_closing( c );
                        connection_close( c );
@@ -1264,13 +1293,12 @@ int connection_read(ber_socket_t s)
 #define CONNECTION_INPUT_LOOP 1
 /* #define     DATA_READY_LOOP 1 */
 
-       do
-       {
+       do {
                /* How do we do this without getting into a busy loop ? */
                rc = connection_input( c );
        }
 #ifdef DATA_READY_LOOP
-       while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ) );
+       while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ));
 #elif CONNECTION_INPUT_LOOP
        while(!rc);
 #else
@@ -1278,15 +1306,9 @@ int connection_read(ber_socket_t s)
 #endif
 
        if( rc < 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_read: conn %lu  input error %d, closing.\n",
-                       c->c_connid, rc, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "connection_read(%d): input error=%d id=%lu, closing.\n",
                        s, rc, c->c_connid );
-#endif
                /* connections_mutex and c_mutex are locked */
                connection_closing( c );
                connection_close( c );
@@ -1310,8 +1332,7 @@ int connection_read(ber_socket_t s)
 
 static int
 connection_input(
-    Connection *conn
-)
+       Connection *conn )
 {
        Operation *op;
        ber_tag_t       tag;
@@ -1323,17 +1344,12 @@ connection_input(
        Sockaddr        peeraddr;
        char            *cdn = NULL;
 #endif
+       char *defer = NULL;
 
        if ( conn->c_currentber == NULL &&
                ( conn->c_currentber = ber_alloc()) == NULL )
        {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_input: conn %lu  ber_alloc failed.\n", 
-                       conn->c_connid, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "ber_alloc failed\n", 0, 0, 0 );
-#endif
                return -1;
        }
 
@@ -1361,15 +1377,9 @@ connection_input(
 
                ber_sockbuf_ctrl( conn->c_sb, LBER_SB_OPT_GET_FD, &sd );
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_input: conn %lu  ber_get_next failed, errno %d (%s).\n",
-                       conn->c_connid, err, sock_errstr(err) );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "ber_get_next on fd %d failed errno=%d (%s)\n",
                        sd, err, sock_errstr(err) );
-#endif
                if ( err != EWOULDBLOCK && err != EAGAIN ) {
                        /* log, close and send error */
                        ber_free( conn->c_currentber, 1 );
@@ -1385,28 +1395,16 @@ connection_input(
 
        if ( (tag = ber_get_int( ber, &msgid )) != LDAP_TAG_MSGID ) {
                /* log, close and send error */
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_input: conn %lu  ber_get_int returns 0x%lx.\n",
-                       conn->c_connid, tag, 0 );
-#else
-               Debug( LDAP_DEBUG_ANY, "ber_get_int returns 0x%lx\n", tag, 0,
-                   0 );
-#endif
+               Debug( LDAP_DEBUG_ANY, "ber_get_int returns 0x%lx\n",
+                       tag, 0, 0 );
                ber_free( ber, 1 );
                return -1;
        }
 
        if ( (tag = ber_peek_tag( ber, &len )) == LBER_ERROR ) {
                /* log, close and send error */
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                          "connection_input: conn %lu  ber_peek_tag returns 0x%lx.\n",
-                          conn->c_connid, tag, 0 );
-#else
-               Debug( LDAP_DEBUG_ANY, "ber_peek_tag returns 0x%lx\n", tag, 0,
-                   0 );
-#endif
+               Debug( LDAP_DEBUG_ANY, "ber_peek_tag returns 0x%lx\n",
+                       tag, 0, 0 );
                ber_free( ber, 1 );
 
                return -1;
@@ -1419,64 +1417,48 @@ connection_input(
                        tag = ber_peek_tag(ber, &len);
                }
                if( tag != LDAP_REQ_ABANDON && tag != LDAP_REQ_SEARCH ) {
-#ifdef NEW_LOGGING
-                   LDAP_LOG( CONNECTION, ERR, 
-                              "connection_input: conn %lu  invalid req for UDP 0x%lx.\n",
-                              conn->c_connid, tag, 0 );
-#else
-                   Debug( LDAP_DEBUG_ANY, "invalid req for UDP 0x%lx\n", tag, 0,
-                       0 );
-#endif
-                   ber_free( ber, 1 );
-                   return 0;
+                       Debug( LDAP_DEBUG_ANY, "invalid req for UDP 0x%lx\n", tag, 0, 0 );
+                       ber_free( ber, 1 );
+                       return 0;
                }
        }
 #endif
        if(tag == LDAP_REQ_BIND) {
-               /* immediately abandon all exiting operations upon BIND */
+               /* immediately abandon all existing operations upon BIND */
                connection_abandon( conn );
        }
 
        op = slap_op_alloc( ber, msgid, tag, conn->c_n_ops_received++ );
 
        op->o_conn = conn;
-       op->vrFilter = NULL;
-#ifdef LDAP_CONTROL_PAGEDRESULTS
-       op->o_pagedresults_state = conn->c_pagedresults_state;
-#endif
+       /* clear state if the connection is being reused from inactive */
+       if ( conn->c_conn_state == SLAP_C_INACTIVE ) {
+               memset( &conn->c_pagedresults_state, 0, sizeof( conn->c_pagedresults_state ) );
+       }
+
+       op->o_res_ber = NULL;
+
 #ifdef LDAP_CONNECTIONLESS
        if (conn->c_is_udp) {
-
                if ( cdn ) {
-                   ber_str2bv( cdn, 0, 1, &op->o_dn );
-                   op->o_protocol = LDAP_VERSION2;
+                       ber_str2bv( cdn, 0, 1, &op->o_dn );
+                       op->o_protocol = LDAP_VERSION2;
                }
                op->o_res_ber = ber_alloc_t( LBER_USE_DER );
-               if (op->o_res_ber == NULL)
-                       return 1;
+               if (op->o_res_ber == NULL) return 1;
+
+               rc = ber_write( op->o_res_ber, (char *)&peeraddr,
+                       sizeof(struct sockaddr), 0 );
 
-               rc = ber_write(op->o_res_ber, (char *)&peeraddr, sizeof(struct sockaddr), 0);
                if (rc != sizeof(struct sockaddr)) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, INFO, 
-                               "connection_input: conn %lu  ber_write failed\n",
-                               conn->c_connid, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 );
-#endif
                        return 1;
                }
 
                if (op->o_protocol == LDAP_VERSION2) {
                        rc = ber_printf(op->o_res_ber, "{is{" /*}}*/, op->o_msgid, "");
                        if (rc == -1) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG( CONNECTION, INFO, 
-                                       "connection_input: conn %lu  put outer sequence failed\n",
-                                       conn->c_connid, 0, 0 );
-#else
                                Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 );
-#endif
                                return rc;
                        }
                }
@@ -1489,23 +1471,45 @@ connection_input(
         * Bind, or if it's closing. Also, don't let any single conn
         * use up all the available threads, and don't execute if we're
         * currently blocked on output. And don't execute if there are
-        * already pending ops, let them go first.
+        * already pending ops, let them go first.  Abandon operations
+        * get exceptions to some, but not all, cases.
         */
-       if ( conn->c_conn_state == SLAP_C_BINDING
-               || conn->c_conn_state == SLAP_C_CLOSING
-               || conn->c_n_ops_executing >= connection_pool_max/2
-               || conn->c_n_ops_pending
-               || conn->c_writewaiter)
-       {
-               int max = conn->c_dn.bv_len ? slap_conn_max_pending_auth
-                        : slap_conn_max_pending;
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                       "connection_input: conn %lu  deferring operation\n",
-                       conn->c_connid, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_ANY, "deferring operation\n", 0, 0, 0 );
-#endif
+       switch( tag ){
+       default:
+               /* Abandon and Unbind are exempt from these checks */
+               if (conn->c_conn_state == SLAP_C_CLOSING) {
+                       defer = "closing";
+                       break;
+               } else if (conn->c_writewaiter) {
+                       defer = "awaiting write";
+                       break;
+               } else if (conn->c_n_ops_pending) {
+                       defer = "pending operations";
+                       break;
+               }
+               /* FALLTHRU */
+       case LDAP_REQ_ABANDON:
+               /* Unbind is exempt from these checks */
+               if (conn->c_n_ops_executing >= connection_pool_max/2) {
+                       defer = "too many executing";
+                       break;
+               } else if (conn->c_conn_state == SLAP_C_BINDING) {
+                       defer = "binding";
+                       break;
+               }
+               /* FALLTHRU */
+       case LDAP_REQ_UNBIND:
+               break;
+       }
+
+       if( defer ) {
+               int max = conn->c_dn.bv_len
+                       ? slap_conn_max_pending_auth
+                       : slap_conn_max_pending;
+
+               Debug( LDAP_DEBUG_ANY,
+                       "connection_input: conn=%lu deferring operation: %s\n",
+                       conn->c_connid, defer, 0 );
                conn->c_n_ops_pending++;
                LDAP_STAILQ_INSERT_TAIL( &conn->c_pending_ops, op, o_next );
                if ( conn->c_n_ops_pending > max ) {
@@ -1539,19 +1543,13 @@ connection_resched( Connection *conn )
                ber_socket_t    sd;
                ber_sockbuf_ctrl( conn->c_sb, LBER_SB_OPT_GET_FD, &sd );
 
-               /* us trylock to avoid possible deadlock */
+               /* use trylock to avoid possible deadlock */
                rc = ldap_pvt_thread_mutex_trylock( &connections_mutex );
 
                if( rc ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, DETAIL1, 
-                               "connection_resched: conn %lu  reaquiring locks.\n",
-                               conn->c_connid, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                                "connection_resched: reaquiring locks conn=%lu sd=%d\n",
                                conn->c_connid, sd, 0 );
-#endif
                        /*
                         * reaquire locks in the right order...
                         * this may allow another thread to close this connection,
@@ -1563,25 +1561,13 @@ connection_resched( Connection *conn )
                }
 
                if( conn->c_conn_state != SLAP_C_CLOSING ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, INFO, 
-                               "connection_resched: conn %lu  closed by other thread.\n",
-                               conn->c_connid, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE, "connection_resched: "
                                "closed by other thread conn=%lu sd=%d\n",
                                conn->c_connid, sd, 0 );
-#endif
                } else {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( CONNECTION, DETAIL1, 
-                               "connection_resched: conn %lu  attempting closing.\n",
-                               conn->c_connid, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE, "connection_resched: "
                                "attempting closing conn=%lu sd=%d\n",
                                conn->c_connid, sd, 0 );
-#endif
                        connection_close( conn );
                }
 
@@ -1615,6 +1601,19 @@ connection_resched( Connection *conn )
        return 0;
 }
 
+static void
+connection_init_log_prefix( Operation *op )
+{
+       if ( op->o_connid == (unsigned long)(-1) ) {
+               snprintf( op->o_log_prefix, sizeof( op->o_log_prefix ),
+                               "conn=-1 op=%lu", op->o_opid );
+
+       } else {
+               snprintf( op->o_log_prefix, sizeof( op->o_log_prefix ),
+                               "conn=%lu op=%lu", op->o_connid, op->o_opid );
+       }
+}
+
 static int connection_op_activate( Operation *op )
 {
        int status;
@@ -1625,23 +1624,30 @@ static int connection_op_activate( Operation *op )
        }
 
        if (!op->o_dn.bv_len) {
-           op->o_authz = op->o_conn->c_authz;
-           ber_dupbv( &op->o_dn, &op->o_conn->c_dn );
-           ber_dupbv( &op->o_ndn, &op->o_conn->c_ndn );
+               op->o_authz = op->o_conn->c_authz;
+               if ( BER_BVISNULL( &op->o_conn->c_sasl_authz_dn )) {
+                       ber_dupbv( &op->o_dn, &op->o_conn->c_dn );
+                       ber_dupbv( &op->o_ndn, &op->o_conn->c_ndn );
+               } else {
+                       ber_dupbv( &op->o_dn, &op->o_conn->c_sasl_authz_dn );
+                       ber_dupbv( &op->o_ndn, &op->o_conn->c_sasl_authz_dn );
+               }
        }
        op->o_authtype = op->o_conn->c_authtype;
        ber_dupbv( &op->o_authmech, &op->o_conn->c_authmech );
        
        if (!op->o_protocol) {
-           op->o_protocol = op->o_conn->c_protocol
-               ? op->o_conn->c_protocol : LDAP_VERSION3;
+               op->o_protocol = op->o_conn->c_protocol
+                       ? op->o_conn->c_protocol : LDAP_VERSION3;
        }
        if (op->o_conn->c_conn_state == SLAP_C_INACTIVE
-               && op->o_protocol > LDAP_VERSION2) {
+               && op->o_protocol > LDAP_VERSION2)
+       {
                op->o_conn->c_conn_state = SLAP_C_ACTIVE;
        }
 
        op->o_connid = op->o_conn->c_connid;
+       connection_init_log_prefix( op );
 
        LDAP_STAILQ_INSERT_TAIL( &op->o_conn->c_ops, op, o_next );
 
@@ -1649,14 +1655,9 @@ static int connection_op_activate( Operation *op )
                connection_operation, (void *) op );
 
        if ( status != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_op_activate: conn %lu        thread pool submit failed.\n",
-                       op->o_connid, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
-               "ldap_pvt_thread_pool_submit failed (%d)\n", status, 0, 0 );
-#endif
+                       "ldap_pvt_thread_pool_submit: failed (%d) for conn=%lu\n",
+                       status, op->o_connid, 0 );
                /* should move op to pending list */
        }
 
@@ -1666,6 +1667,7 @@ static int connection_op_activate( Operation *op )
 int connection_write(ber_socket_t s)
 {
        Connection *c;
+       Operation *op;
 
        assert( connections != NULL );
 
@@ -1673,40 +1675,89 @@ int connection_write(ber_socket_t s)
 
        c = connection_get( s );
 
-       slapd_clr_write( s, 0);
-
        if( c == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, ERR, 
-                       "connection_write: sock %ld  no connection!\n", (long)s, 0, 0);
-#else
                Debug( LDAP_DEBUG_ANY,
                        "connection_write(%ld): no connection!\n",
-                       (long) s, 0, 0 );
-#endif
-               slapd_remove(s, 0);
+                       (long)s, 0, 0 );
+               slapd_remove(s, 1, 0);
                ldap_pvt_thread_mutex_unlock( &connections_mutex );
                return -1;
        }
 
+       slapd_clr_write( s, 0);
+
        c->c_n_write++;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( CONNECTION, DETAIL1, 
-               "connection_write conn %lu  waking output.\n", c->c_connid, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE,
                "connection_write(%d): waking output for id=%lu\n",
                s, c->c_connid, 0 );
-#endif
        ldap_pvt_thread_cond_signal( &c->c_write_cv );
 
-       if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_READ, NULL ) )
+       if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_READ, NULL ) ) {
                slapd_set_read( s, 1 );
-       if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_WRITE, NULL ) )
+       }
+       if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_WRITE, NULL ) ) {
                slapd_set_write( s, 1 );
+       }
+       /* If there are ops pending because of a writewaiter, start
+        * one up.
+        */
+       while ((op = LDAP_STAILQ_FIRST( &c->c_pending_ops )) != NULL) {
+               if ( !c->c_writewaiter ) break;
+               if ( c->c_n_ops_executing > connection_pool_max/2 ) {
+                       break;
+               }
+               LDAP_STAILQ_REMOVE_HEAD( &c->c_pending_ops, o_next );
+               LDAP_STAILQ_NEXT(op, o_next) = NULL;
+               /* pending operations should not be marked for abandonment */
+               assert(!op->o_abandon);
+
+               c->c_n_ops_pending--;
+               c->c_n_ops_executing++;
+
+               connection_op_activate( op );
+
+               break;
+       }
        connection_return( c );
        ldap_pvt_thread_mutex_unlock( &connections_mutex );
        return 0;
 }
 
+void
+connection_fake_init(
+       Connection *conn,
+       Operation *op,
+       void *ctx )
+{
+       conn->c_connid = -1;
+       conn->c_send_ldap_result = slap_send_ldap_result;
+       conn->c_send_search_entry = slap_send_search_entry;
+       conn->c_send_search_reference = slap_send_search_reference;
+       conn->c_listener = (Listener *)&dummy_list;
+       conn->c_peer_domain = slap_empty_bv;
+       conn->c_peer_name = slap_empty_bv;
+
+       memset(op, 0, OPERATION_BUFFER_SIZE);
+       op->o_hdr = (Opheader *)(op+1);
+       op->o_controls = (void **)(op->o_hdr+1);
+       /* set memory context */
+       op->o_tmpmemctx = slap_sl_mem_create(SLAP_SLAB_SIZE, SLAP_SLAB_STACK, ctx);
+       op->o_tmpmfuncs = &slap_sl_mfuncs;
+       op->o_threadctx = ctx;
+
+       op->o_conn = conn;
+       op->o_connid = op->o_conn->c_connid;
+       connection_init_log_prefix( op );
+
+       op->o_time = slap_get_time();
+}
+
+void
+connection_assign_nextid( Connection *conn )
+{
+       ldap_pvt_thread_mutex_lock( &conn_nextid_mutex );
+       conn->c_connid = conn_nextid++;
+       ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex );
+}
+