]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/connection.c
fix previous commit (ITS#5819)
[openldap] / servers / slapd / connection.c
index d1794964979b55e22fef6be199d34899ad900dae..22dbd8513e4e1cb913f44cb3ebbe5ada9933fa53 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2007 The OpenLDAP Foundation.
+ * Copyright 1998-2008 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -83,8 +83,6 @@ connection_state2str( int state )
 
 static Connection* connection_get( ber_socket_t s );
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-
 typedef struct conn_readinfo {
        Operation *op;
        ldap_pvt_thread_start_t *func;
@@ -94,15 +92,10 @@ typedef struct conn_readinfo {
 } conn_readinfo;
 
 static int connection_input( Connection *c, conn_readinfo *cri );
-#else
-static int connection_input( Connection *c );
-#endif
 static void connection_close( Connection *c );
 
 static int connection_op_activate( Operation *op );
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
 static void connection_op_queue( Operation *op );
-#endif
 static int connection_resched( Connection *conn );
 static void connection_abandon( Connection *conn );
 static void connection_destroy( Connection *c );
@@ -261,57 +254,14 @@ static Connection* connection_get( ber_socket_t s )
 
        if(s == AC_SOCKET_INVALID) return NULL;
 
-#ifndef HAVE_WINSOCK
        assert( s < dtblsize );
        c = &connections[s];
 
-#else
-       c = NULL;
-       {
-               ldap_pvt_thread_mutex_lock( &connections_mutex );
-               for(i=0; i<dtblsize; i++) {
-                       if( connections[i].c_struct_state == SLAP_C_PENDING )
-                               continue;
-
-                       if( connections[i].c_struct_state == SLAP_C_UNINITIALIZED ) {
-                               assert( connections[i].c_conn_state == SLAP_C_INVALID );
-                               assert( connections[i].c_sb == 0 );
-                               break;
-                       }
-
-                       if( connections[i].c_struct_state == SLAP_C_UNUSED ) {
-                               assert( connections[i].c_conn_state == SLAP_C_INVALID );
-                               assert( connections[i].c_sd == AC_SOCKET_INVALID );
-                               continue;
-                       }
-
-                       /* state can actually change from used -> unused by resched,
-                        * so don't assert details here.
-                        */
-
-                       if( connections[i].c_sd == s ) {
-                               c = &connections[i];
-                               break;
-                       }
-               }
-               ldap_pvt_thread_mutex_unlock( &connections_mutex );
-       }
-#endif
-
        if( c != NULL ) {
                ldap_pvt_thread_mutex_lock( &c->c_mutex );
 
                assert( c->c_struct_state != SLAP_C_UNINITIALIZED );
 
-#ifdef HAVE_WINSOCK
-               /* Avoid race condition after releasing
-                * connections_mutex
-                */
-               if ( c->c_sd != s ) {
-                       ldap_pvt_thread_mutex_unlock( &c->c_mutex );
-                       return NULL;
-               }
-#endif
                if( c->c_struct_state != SLAP_C_USED ) {
                        /* connection must have been closed due to resched */
 
@@ -365,6 +315,7 @@ Connection * connection_init(
        unsigned long id;
        Connection *c;
        int doinit = 0;
+       ber_socket_t sfd = SLAP_FD2SOCK(s);
 
        assert( connections != NULL );
 
@@ -383,7 +334,6 @@ Connection * connection_init(
        }
 
        assert( s >= 0 );
-#ifndef HAVE_WINSOCK
        assert( s < dtblsize );
        c = &connections[s];
        if( c->c_struct_state == SLAP_C_UNINITIALIZED ) {
@@ -391,45 +341,6 @@ Connection * connection_init(
        } else {
                assert( c->c_struct_state == SLAP_C_UNUSED );
        }
-#else
-       {
-               ber_socket_t i;
-               c = NULL;
-
-               ldap_pvt_thread_mutex_lock( &connections_mutex );
-               for( i=0; i < dtblsize; i++) {
-                       if ( connections[i].c_struct_state == SLAP_C_PENDING )
-                               continue;
-
-                       if( connections[i].c_struct_state == SLAP_C_UNINITIALIZED ) {
-                               assert( connections[i].c_sb == 0 );
-                               c = &connections[i];
-                               c->c_struct_state = SLAP_C_PENDING;
-                               doinit = 1;
-                               break;
-                       }
-
-                       if( connections[i].c_struct_state == SLAP_C_UNUSED ) {
-                               c = &connections[i];
-                               c->c_struct_state = SLAP_C_PENDING;
-                               break;
-                       }
-
-                       if( connections[i].c_conn_state == SLAP_C_CLIENT ) continue;
-
-                       assert( connections[i].c_struct_state == SLAP_C_USED );
-                       assert( connections[i].c_conn_state != SLAP_C_INVALID );
-               }
-               ldap_pvt_thread_mutex_unlock( &connections_mutex );
-
-               if( c == NULL ) {
-                       Debug( LDAP_DEBUG_ANY,
-                               "connection_init(%d): connection table full "
-                               "(%d/%d)\n", s, i, dtblsize);
-                       return NULL;
-               }
-       }
-#endif
 
        if( doinit ) {
                c->c_send_ldap_result = slap_send_ldap_result;
@@ -512,10 +423,12 @@ Connection * connection_init(
 
        if ( flags & CONN_IS_CLIENT ) {
                c->c_connid = 0;
+               ldap_pvt_thread_mutex_lock( &connections_mutex );
                c->c_conn_state = SLAP_C_CLIENT;
                c->c_struct_state = SLAP_C_USED;
+               ldap_pvt_thread_mutex_unlock( &connections_mutex );
                c->c_close_reason = "?";                        /* should never be needed */
-               ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_FD, &s );
+               ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_FD, &sfd );
                ldap_pvt_thread_mutex_unlock( &c->c_mutex );
 
                return c;
@@ -552,7 +465,7 @@ Connection * connection_init(
                        LBER_SBIOD_LEVEL_PROVIDER, (void*)"udp_" );
 #endif
                ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_udp,
-                       LBER_SBIOD_LEVEL_PROVIDER, (void *)&s );
+                       LBER_SBIOD_LEVEL_PROVIDER, (void *)&sfd );
                ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_readahead,
                        LBER_SBIOD_LEVEL_PROVIDER, NULL );
        } else
@@ -564,7 +477,7 @@ Connection * connection_init(
                        LBER_SBIOD_LEVEL_PROVIDER, (void*)"ipc_" );
 #endif
                ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_fd,
-                       LBER_SBIOD_LEVEL_PROVIDER, (void *)&s );
+                       LBER_SBIOD_LEVEL_PROVIDER, (void *)&sfd );
 #ifdef LDAP_PF_LOCAL_SENDMSG
                if ( !BER_BVISEMPTY( peerbv ))
                        ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_UNGET_BUF, peerbv );
@@ -577,7 +490,7 @@ Connection * connection_init(
                        LBER_SBIOD_LEVEL_PROVIDER, (void*)"tcp_" );
 #endif
                ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_tcp,
-                       LBER_SBIOD_LEVEL_PROVIDER, (void *)&s );
+                       LBER_SBIOD_LEVEL_PROVIDER, (void *)&sfd );
        }
 
 #ifdef LDAP_DEBUG
@@ -597,8 +510,10 @@ Connection * connection_init(
        id = c->c_connid = conn_nextid++;
        ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex );
 
+       ldap_pvt_thread_mutex_lock( &connections_mutex );
        c->c_conn_state = SLAP_C_INACTIVE;
        c->c_struct_state = SLAP_C_USED;
+       ldap_pvt_thread_mutex_unlock( &connections_mutex );
        c->c_close_reason = "?";                        /* should never be needed */
 
        c->c_ssf = c->c_transport_ssf = ssf;
@@ -664,6 +579,7 @@ connection_destroy( Connection *c )
        unsigned long   connid;
        const char              *close_reason;
        Sockbuf                 *sb;
+       ber_socket_t    sd;
 
        assert( connections != NULL );
        assert( c != NULL );
@@ -726,6 +642,8 @@ connection_destroy( Connection *c )
        }
 #endif
 
+       sd = c->c_sd;
+       c->c_sd = AC_SOCKET_INVALID;
        c->c_conn_state = SLAP_C_INVALID;
        c->c_struct_state = SLAP_C_UNUSED;
        c->c_close_reason = "?";                        /* should never be needed */
@@ -740,17 +658,16 @@ connection_destroy( Connection *c )
        /* c must be fully reset by this point; when we call slapd_remove
         * it may get immediately reused by a new connection.
         */
-       if ( c->c_sd != AC_SOCKET_INVALID ) {
-               slapd_remove( c->c_sd, sb, 1, 0, 0 );
+       if ( sd != AC_SOCKET_INVALID ) {
+               slapd_remove( sd, sb, 1, 0, 0 );
 
                if ( close_reason == NULL ) {
                        Statslog( LDAP_DEBUG_STATS, "conn=%lu fd=%ld closed\n",
-                               connid, (long) c->c_sd, 0, 0, 0 );
+                               connid, (long) sd, 0, 0, 0 );
                } else {
                        Statslog( LDAP_DEBUG_STATS, "conn=%lu fd=%ld closed (%s)\n",
-                               connid, (long) c->c_sd, close_reason, 0, 0 );
+                               connid, (long) sd, close_reason, 0, 0 );
                }
-               c->c_sd = AC_SOCKET_INVALID;
        }
 }
 
@@ -930,16 +847,12 @@ Connection* connection_next( Connection *c, ber_socket_t *index )
        for(; *index < dtblsize; (*index)++) {
                int c_struct;
                if( connections[*index].c_struct_state == SLAP_C_UNINITIALIZED ) {
+                       /* FIXME: accessing c_conn_state without locking c_mutex */
                        assert( connections[*index].c_conn_state == SLAP_C_INVALID );
-#ifdef HAVE_WINSOCK
-                       break;
-#else
                        continue;
-#endif
                }
 
                if( connections[*index].c_struct_state == SLAP_C_USED ) {
-                       assert( connections[*index].c_conn_state != SLAP_C_INVALID );
                        c = &connections[(*index)++];
                        if ( ldap_pvt_thread_mutex_trylock( &c->c_mutex )) {
                                /* avoid deadlock */
@@ -952,6 +865,7 @@ Connection* connection_next( Connection *c, ber_socket_t *index )
                                        continue;
                                }
                        }
+                       assert( c->c_conn_state != SLAP_C_INVALID );
                        break;
                }
 
@@ -959,6 +873,7 @@ Connection* connection_next( Connection *c, ber_socket_t *index )
                if ( c_struct == SLAP_C_PENDING )
                        continue;
                assert( c_struct == SLAP_C_UNUSED );
+               /* FIXME: accessing c_conn_state without locking c_mutex */
                assert( connections[*index].c_conn_state == SLAP_C_INVALID );
        }
 
@@ -983,24 +898,24 @@ void connection_done( Connection *c )
 /* FIXME: returns 0 in case of failure */
 #define INCR_OP_INITIATED(index) \
        do { \
-               ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex ); \
-               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_initiated_[(index)], 1); \
-               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex ); \
+               ldap_pvt_thread_mutex_lock( &op->o_counters->sc_mutex ); \
+               ldap_pvt_mp_add_ulong(op->o_counters->sc_ops_initiated_[(index)], 1); \
+               ldap_pvt_thread_mutex_unlock( &op->o_counters->sc_mutex ); \
        } while (0)
 #define INCR_OP_COMPLETED(index) \
        do { \
-               ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex ); \
-               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_completed, 1); \
-               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_completed_[(index)], 1); \
-               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex ); \
+               ldap_pvt_thread_mutex_lock( &op->o_counters->sc_mutex ); \
+               ldap_pvt_mp_add_ulong(op->o_counters->sc_ops_completed, 1); \
+               ldap_pvt_mp_add_ulong(op->o_counters->sc_ops_completed_[(index)], 1); \
+               ldap_pvt_thread_mutex_unlock( &op->o_counters->sc_mutex ); \
        } while (0)
 #else /* !SLAPD_MONITOR */
 #define INCR_OP_INITIATED(index) do { } while (0)
 #define INCR_OP_COMPLETED(index) \
        do { \
-               ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex ); \
-               ldap_pvt_mp_add_ulong(slap_counters.sc_ops_completed, 1); \
-               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex ); \
+               ldap_pvt_thread_mutex_lock( &op->o_counters->sc_mutex ); \
+               ldap_pvt_mp_add_ulong(op->o_counters->sc_ops_completed, 1); \
+               ldap_pvt_thread_mutex_unlock( &op->o_counters->sc_mutex ); \
        } while (0)
 #endif /* !SLAPD_MONITOR */
 
@@ -1021,6 +936,63 @@ static BI_op_func *opfun[] = {
        NULL
 };
 
+/* Counters are per-thread, not per-connection.
+ */
+static void
+conn_counter_destroy( void *key, void *data )
+{
+       slap_counters_t **prev, *sc;
+
+       ldap_pvt_thread_mutex_lock( &slap_counters.sc_mutex );
+       for ( prev = &slap_counters.sc_next, sc = slap_counters.sc_next; sc;
+               prev = &sc->sc_next, sc = sc->sc_next ) {
+               if ( sc == data ) {
+                       int i;
+
+                       *prev = sc->sc_next;
+                       /* Copy data to main counter */
+                       ldap_pvt_mp_add( slap_counters.sc_bytes, sc->sc_bytes );
+                       ldap_pvt_mp_add( slap_counters.sc_pdu, sc->sc_pdu );
+                       ldap_pvt_mp_add( slap_counters.sc_entries, sc->sc_entries );
+                       ldap_pvt_mp_add( slap_counters.sc_refs, sc->sc_refs );
+                       ldap_pvt_mp_add( slap_counters.sc_ops_initiated, sc->sc_ops_initiated );
+                       ldap_pvt_mp_add( slap_counters.sc_ops_completed, sc->sc_ops_completed );
+#ifdef SLAPD_MONITOR
+                       for ( i = 0; i < SLAP_OP_LAST; i++ ) {
+                               ldap_pvt_mp_add( slap_counters.sc_ops_initiated_[ i ], sc->sc_ops_initiated_[ i ] );
+                               ldap_pvt_mp_add( slap_counters.sc_ops_initiated_[ i ], sc->sc_ops_completed_[ i ] );
+                       }
+#endif /* SLAPD_MONITOR */
+                       slap_counters_destroy( sc );
+                       ber_memfree_x( data, NULL );
+                       break;
+               }
+       }
+       ldap_pvt_thread_mutex_unlock( &slap_counters.sc_mutex );
+}
+
+static void
+conn_counter_init( Operation *op, void *ctx )
+{
+       slap_counters_t *sc;
+       void *vsc = NULL;
+
+       if ( ldap_pvt_thread_pool_getkey(
+                       ctx, (void *)conn_counter_init, &vsc, NULL ) || !vsc ) {
+               vsc = ch_malloc( sizeof( slap_counters_t ));
+               sc = vsc;
+               slap_counters_init( sc );
+               ldap_pvt_thread_pool_setkey( ctx, (void*)conn_counter_init, vsc,
+                       conn_counter_destroy, NULL, NULL );
+
+               ldap_pvt_thread_mutex_lock( &slap_counters.sc_mutex );
+               sc->sc_next = slap_counters.sc_next;
+               slap_counters.sc_next = sc;
+               ldap_pvt_thread_mutex_unlock( &slap_counters.sc_mutex );
+       }
+       op->o_counters = vsc;
+}
+
 static void *
 connection_operation( void *ctx, void *arg_v )
 {
@@ -1034,10 +1006,11 @@ connection_operation( void *ctx, void *arg_v )
        void *memctx_null = NULL;
        ber_len_t memsiz;
 
-       ldap_pvt_thread_mutex_lock( &slap_counters.sc_ops_mutex );
+       conn_counter_init( op, ctx );
+       ldap_pvt_thread_mutex_lock( &op->o_counters->sc_mutex );
        /* FIXME: returns 0 in case of failure */
-       ldap_pvt_mp_add_ulong(slap_counters.sc_ops_initiated, 1);
-       ldap_pvt_thread_mutex_unlock( &slap_counters.sc_ops_mutex );
+       ldap_pvt_mp_add_ulong(op->o_counters->sc_ops_initiated, 1);
+       ldap_pvt_thread_mutex_unlock( &op->o_counters->sc_mutex );
 
        op->o_threadctx = ctx;
        op->o_tid = ldap_pvt_thread_pool_tid( ctx );
@@ -1167,37 +1140,37 @@ operations_error:
 
 static const Listener dummy_list = { BER_BVC(""), BER_BVC("") };
 
-int connection_client_setup(
+Connection *connection_client_setup(
        ber_socket_t s,
        ldap_pvt_thread_start_t *func,
        void *arg )
 {
        Connection *c;
+       ber_socket_t sfd = SLAP_SOCKNEW( s );
 
-       c = connection_init( s, (Listener *)&dummy_list, "", "",
+       c = connection_init( sfd, (Listener *)&dummy_list, "", "",
                CONN_IS_CLIENT, 0, NULL
                LDAP_PF_LOCAL_SENDMSG_ARG(NULL));
-       if ( !c ) return -1;
+       if ( c ) {
+               c->c_clientfunc = func;
+               c->c_clientarg = arg;
 
-       c->c_clientfunc = func;
-       c->c_clientarg = arg;
-
-       slapd_add_internal( s, 0 );
-       slapd_set_read( s, 1 );
-       return 0;
+               slapd_add_internal( sfd, 0 );
+       }
+       return c;
 }
 
 void connection_client_enable(
-       ber_socket_t s )
+       Connection *c )
 {
-       slapd_set_read( s, 1 );
+       slapd_set_read( c->c_sd, 1 );
 }
 
 void connection_client_stop(
-       ber_socket_t s )
+       Connection *c )
 {
-       Connection *c;
        Sockbuf *sb;
+       ber_socket_t s = c->c_sd;
 
        /* get (locked) connection */
        c = connection_get( s );
@@ -1207,6 +1180,7 @@ void connection_client_stop(
        c->c_listener = NULL;
        c->c_conn_state = SLAP_C_INVALID;
        c->c_struct_state = SLAP_C_UNUSED;
+       c->c_sd = AC_SOCKET_INVALID;
        c->c_close_reason = "?";                        /* should never be needed */
        sb = c->c_sb;
        c->c_sb = ber_sockbuf_alloc( );
@@ -1219,14 +1193,12 @@ void connection_client_stop(
        connection_return( c );
 }
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-
 static int connection_read( ber_socket_t s, conn_readinfo *cri );
 
 static void* connection_read_thread( void* ctx, void* argv )
 {
        int rc ;
-       conn_readinfo cri = { NULL, NULL, NULL, 0 };
+       conn_readinfo cri = { NULL, NULL, NULL, NULL, 0 };
        ber_socket_t s = (long)argv;
 
        /*
@@ -1273,14 +1245,9 @@ int connection_read_activate( ber_socket_t s )
 
        return rc;
 }
-#endif
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
 static int
 connection_read( ber_socket_t s, conn_readinfo *cri )
-#else
-int connection_read(ber_socket_t s)
-#endif
 {
        int rc = 0;
        Connection *c;
@@ -1309,15 +1276,9 @@ int connection_read(ber_socket_t s)
        }
 
        if ( c->c_conn_state == SLAP_C_CLIENT ) {
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
                cri->func = c->c_clientfunc;
                cri->arg = c->c_clientarg;
                /* read should already be cleared */
-#else
-               slapd_clr_read( s, 0 );
-               ldap_pvt_thread_pool_submit( &connection_pool,
-                       c->c_clientfunc, c->c_clientarg );
-#endif
                connection_return( c );
                return 0;
        }
@@ -1372,10 +1333,7 @@ int connection_read(ber_socket_t s)
                /* if success and data is ready, fall thru to data input loop */
                if( !ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ) )
                {
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
                        slapd_set_read( s, 1 );
-#endif
-
                        connection_return( c );
                        return 0;
                }
@@ -1386,10 +1344,7 @@ int connection_read(ber_socket_t s)
        if ( c->c_sasl_layers ) {
                /* If previous layer is not removed yet, give up for now */
                if ( !c->c_sasl_sockctx ) {
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
                        slapd_set_read( s, 1 );
-#endif
-
                        connection_return( c );
                        return 0;
                }
@@ -1417,11 +1372,7 @@ int connection_read(ber_socket_t s)
 
        do {
                /* How do we do this without getting into a busy loop ? */
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
                rc = connection_input( c, cri );
-#else
-               rc = connection_input( c );
-#endif
        }
 #ifdef DATA_READY_LOOP
        while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ));
@@ -1443,33 +1394,18 @@ int connection_read(ber_socket_t s)
                return 0;
        }
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
        if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_WRITE, NULL ) ) {
                slapd_set_write( s, 0 );
        }
 
        slapd_set_read( s, 1 );
-#else
-       if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_READ, NULL ) ) {
-               slapd_set_read( s, 1 );
-       }
-
-       if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_WRITE, NULL ) ) {
-               slapd_set_write( s, 1 );
-       }
-#endif
-
        connection_return( c );
 
        return 0;
 }
 
 static int
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
 connection_input( Connection *conn , conn_readinfo *cri )
-#else
-connection_input( Connection *conn )
-#endif
 {
        Operation *op;
        ber_tag_t       tag;
@@ -1563,11 +1499,7 @@ connection_input( Connection *conn )
                connection_abandon( conn );
        }
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
        ctx = cri->ctx;
-#else
-       ctx = NULL;
-#endif
        op = slap_op_alloc( ber, msgid, tag, conn->c_n_ops_received++, ctx );
 
        op->o_conn = conn;
@@ -1658,7 +1590,6 @@ connection_input( Connection *conn )
        } else {
                conn->c_n_ops_executing++;
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
                /*
                 * The first op will be processed in the same thread context,
                 * as long as there is only one op total.
@@ -1677,9 +1608,6 @@ connection_input( Connection *conn )
                        }
                        connection_op_activate( op );
                }
-#else
-               connection_op_activate( op );
-#endif
        }
 
 #ifdef NO_THREADS
@@ -1698,6 +1626,9 @@ connection_resched( Connection *conn )
 {
        Operation *op;
 
+       if( conn->c_writewaiter )
+               return 0;
+
        if( conn->c_conn_state == SLAP_C_CLOSING ) {
                Debug( LDAP_DEBUG_TRACE, "connection_resched: "
                        "attempting closing conn=%lu sd=%d\n",
@@ -1706,7 +1637,7 @@ connection_resched( Connection *conn )
                return 0;
        }
 
-       if( conn->c_conn_state != SLAP_C_ACTIVE || conn->c_writewaiter ) {
+       if( conn->c_conn_state != SLAP_C_ACTIVE ) {
                /* other states need different handling */
                return 0;
        }
@@ -1973,6 +1904,27 @@ connection_fake_init(
        connection_fake_init2( conn, opbuf, ctx, 1 );
 }
 
+void
+operation_fake_init(
+       Connection *conn,
+       Operation *op,
+       void *ctx,
+       int newmem )
+{
+       /* set memory context */
+       op->o_tmpmemctx = slap_sl_mem_create(SLAP_SLAB_SIZE, SLAP_SLAB_STACK, ctx,
+               newmem );
+       op->o_tmpmfuncs = &slap_sl_mfuncs;
+       op->o_threadctx = ctx;
+       op->o_tid = ldap_pvt_thread_pool_tid( ctx );
+
+       op->o_counters = &slap_counters;
+       op->o_conn = conn;
+       op->o_connid = op->o_conn->c_connid;
+       connection_init_log_prefix( op );
+}
+
+
 void
 connection_fake_init2(
        Connection *conn,
@@ -1995,16 +1947,7 @@ connection_fake_init2(
        op->o_hdr = &opbuf->ob_hdr;
        op->o_controls = opbuf->ob_controls;
 
-       /* set memory context */
-       op->o_tmpmemctx = slap_sl_mem_create(SLAP_SLAB_SIZE, SLAP_SLAB_STACK, ctx,
-               newmem );
-       op->o_tmpmfuncs = &slap_sl_mfuncs;
-       op->o_threadctx = ctx;
-       op->o_tid = ldap_pvt_thread_pool_tid( ctx );
-
-       op->o_conn = conn;
-       op->o_connid = op->o_conn->c_connid;
-       connection_init_log_prefix( op );
+       operation_fake_init( conn, op, ctx, newmem );
 
 #ifdef LDAP_SLAPI
        if ( slapi_plugins_used ) {
@@ -2012,15 +1955,15 @@ connection_fake_init2(
                void *ebx = NULL;
 
                /* Use thread keys to make sure these eventually get cleaned up */
-               if ( ldap_pvt_thread_pool_getkey( ctx, connection_fake_init, &ebx,
-                       NULL )) {
+               if ( ldap_pvt_thread_pool_getkey( ctx, (void *)connection_fake_init,
+                               &ebx, NULL )) {
                        eb = ch_malloc( sizeof( *eb ));
                        slapi_int_create_object_extensions( SLAPI_X_EXT_CONNECTION, conn );
                        slapi_int_create_object_extensions( SLAPI_X_EXT_OPERATION, op );
                        eb->eb_conn = conn->c_extensions;
                        eb->eb_op = op->o_hdr->oh_extensions;
-                       ldap_pvt_thread_pool_setkey( ctx, connection_fake_init, eb,
-                               connection_fake_destroy );
+                       ldap_pvt_thread_pool_setkey( ctx, (void *)connection_fake_init,
+                               eb, connection_fake_destroy, NULL, NULL );
                } else {
                        eb = ebx;
                        conn->c_extensions = eb->eb_conn;