]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/connection.c
Use recursive mutex to avoid deadlocks
[openldap] / servers / slapd / connection.c
index 385186f882f8885537926318e972e79ff845e83b..46c28dfc1e358f0e71928b5f577f952614cfd2ab 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2005 The OpenLDAP Foundation.
+ * Copyright 1998-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -43,7 +43,6 @@
 #include "slapi/slapi.h"
 #endif
 
-
 #ifdef SLAP_MULTI_CONN_ARRAY
 /* for Multiple Connection Arrary (MCA) Support */
 static ldap_pvt_thread_mutex_t* connections_mutex;
@@ -55,6 +54,8 @@ static Connection **connections = NULL;
 /* partition the array in a modulo manner */
 #      define MCA_conn_array_id(fd)            ((int)(fd)%NUM_CONNECTION_ARRAY)
 #      define MCA_conn_array_element_id(fd)    ((int)(fd)/NUM_CONNECTION_ARRAY)
+#      define MCA_ARRAY_SIZE                   ((int)(MCA_conn_array_element_id(dtblsize) + (MCA_conn_array_id(dtblsize) ? 1 : 0)))
+#      define MCA_conn_check(fd)               (dtblsize > 0 && (fd) >= 0 && (fd) < (MCA_ARRAY_SIZE*NUM_CONNECTION_ARRAY))
 #      define MCA_GET_CONNECTION(fd) (&(connections[MCA_conn_array_id(fd)]) \
                [MCA_conn_array_element_id(fd)])
 #      define MCA_GET_CONN_MUTEX(fd) (&connections_mutex[MCA_conn_array_id(fd)])
@@ -64,6 +65,7 @@ static Connection **connections = NULL;
 static ldap_pvt_thread_mutex_t connections_mutex;
 static Connection *connections = NULL;
 
+#      define MCA_conn_check(fd)               (dtblsize > 0 && (fd) < dtblsize)
 #      define MCA_GET_CONNECTION(fd) (&connections[s])
 #      define MCA_GET_CONN_MUTEX(fd) (&connections_mutex)
 #endif
@@ -104,7 +106,15 @@ connection_state2str( int state )
 static Connection* connection_get( ber_socket_t s );
 
 #ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-static int connection_input( Connection *c, Operation** op );
+
+typedef struct conn_readinfo {
+       Operation *op;
+       ldap_pvt_thread_start_t *func;
+       void *arg;
+       int nullop;
+} conn_readinfo;
+
+static int connection_input( Connection *c, conn_readinfo *cri );
 #else
 static int connection_input( Connection *c );
 #endif
@@ -126,8 +136,8 @@ static ldap_pvt_thread_start_t connection_operation;
 int connections_init(void)
 #ifdef SLAP_MULTI_CONN_ARRAY
 {
-       int i, j;
-       Connection* conn;
+       int             i, j;
+       Connection*     conn;
 
        assert( connections == NULL );
 
@@ -141,7 +151,7 @@ int connections_init(void)
                NUM_CONNECTION_ARRAY, sizeof(ldap_pvt_thread_mutex_t) );
        if( connections_mutex == NULL ) {
                Debug( LDAP_DEBUG_ANY, "connections_init: "
-                       "allocation of connection mutex[%d] failed\n", i, 0, 0 );
+                       "allocation of connection mutexes failed\n", 0, 0, 0 );
                return -1;
        }
 
@@ -156,7 +166,7 @@ int connections_init(void)
        for ( i = 0; i < NUM_CONNECTION_ARRAY; i++ ) {
                ldap_pvt_thread_mutex_init( connections_mutex+i );
                connections[i] = (Connection*) ch_calloc(
-                       dtblsize/NUM_CONNECTION_ARRAY, sizeof(Connection) );
+                       MCA_ARRAY_SIZE, sizeof(Connection) );
                if( connections[i] == NULL ) {
                        Debug( LDAP_DEBUG_ANY, "connections_init: "
                                "allocation (%d*%ld) of connection array[%d] failed\n",
@@ -174,7 +184,7 @@ int connections_init(void)
 
        for ( i = 0; i < NUM_CONNECTION_ARRAY; i++ ) {
                conn = connections[i];
-               for ( j = 0; j < (dtblsize/NUM_CONNECTION_ARRAY); j++ ) {
+               for ( j = 0; j < MCA_ARRAY_SIZE; j++ ) {
                        conn[j].c_conn_idx = j;
                }
        }
@@ -243,7 +253,7 @@ int connections_destroy(void)
 
     for ( i = 0; i < NUM_CONNECTION_ARRAY; i++ ) {
                Connection* conn = connections[i];
-               for ( j = 0; j < (dtblsize/NUM_CONNECTION_ARRAY); j++ ) {
+               for ( j = 0; j < MCA_ARRAY_SIZE; j++ ) {
                        if( conn[j].c_struct_state != SLAP_C_UNINITIALIZED ) {
                                ber_sockbuf_free( conn[j].c_sb );
                                ldap_pvt_thread_mutex_destroy( &conn[j].c_mutex );
@@ -266,6 +276,9 @@ int connections_destroy(void)
                ldap_pvt_thread_mutex_destroy( &connections_mutex[i] );
        }
 
+       free( connections );
+       free( connections_mutex );
+
        ldap_pvt_thread_mutex_destroy( &conn_nextid_mutex );
 
        return 0;
@@ -319,7 +332,7 @@ int connections_shutdown(void)
        for ( i = 0; i < NUM_CONNECTION_ARRAY; i++ ) {
                Connection* conn = connections[i];
                ldap_pvt_thread_mutex_lock( &connections_mutex[i] );
-               for ( j = 0; j < (dtblsize/NUM_CONNECTION_ARRAY); j++ ) {
+               for ( j = 0; j < MCA_ARRAY_SIZE; j++ ) {
                        if( conn[j].c_struct_state != SLAP_C_USED ) {
                                continue;
                        }
@@ -421,10 +434,9 @@ static Connection* connection_get( ber_socket_t s )
        if(s == AC_SOCKET_INVALID) return NULL;
 
 #ifndef HAVE_WINSOCK
+       assert( MCA_conn_check( s ) );
        c = MCA_GET_CONNECTION(s);
 
-       assert( c->c_struct_state != SLAP_C_UNINITIALIZED );
-
 #else
        c = NULL;
        {
@@ -461,6 +473,8 @@ static Connection* connection_get( ber_socket_t s )
        if( c != NULL ) {
                ber_socket_t    sd;
 
+               assert( c->c_struct_state != SLAP_C_UNINITIALIZED );
+
                ldap_pvt_thread_mutex_lock( &c->c_mutex );
 
                ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd );
@@ -540,6 +554,7 @@ long connection_init(
        ldap_pvt_thread_mutex_lock( MCA_GET_CONN_MUTEX(s) );
 
 #ifndef HAVE_WINSOCK
+       assert( MCA_conn_check( s ) );
        c = MCA_GET_CONNECTION(s);
 #else
        {
@@ -591,9 +606,7 @@ long connection_init(
                c->c_send_search_entry = slap_send_search_entry;
                c->c_send_search_reference = slap_send_search_reference;
                c->c_send_ldap_extended = slap_send_ldap_extended;
-#ifdef LDAP_RES_INTERMEDIATE
                c->c_send_ldap_intermediate = slap_send_ldap_intermediate;
-#endif
 
                BER_BVZERO( &c->c_authmech );
                BER_BVZERO( &c->c_dn );
@@ -606,6 +619,12 @@ long connection_init(
                LDAP_STAILQ_INIT(&c->c_ops);
                LDAP_STAILQ_INIT(&c->c_pending_ops);
 
+#ifdef LDAP_X_TXN
+               c->c_txn = CONN_TXN_INACTIVE;
+               c->c_txn_backend = NULL;
+               LDAP_STAILQ_INIT(&c->c_txn_ops);
+#endif
+
                BER_BVZERO( &c->c_sasl_bind_mech );
                c->c_sasl_done = 0;
                c->c_sasl_authctx = NULL;
@@ -647,6 +666,11 @@ long connection_init(
        assert( BER_BVISNULL( &c->c_peer_name ) );
        assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
        assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) );
+#ifdef LDAP_X_TXN
+       assert( c->c_txn == CONN_TXN_INACTIVE );
+       assert( c->c_txn_backend == NULL );
+       assert( LDAP_STAILQ_EMPTY(&c->c_txn_ops) );
+#endif
        assert( BER_BVISNULL( &c->c_sasl_bind_mech ) );
        assert( c->c_sasl_done == 0 );
        assert( c->c_sasl_authctx == NULL );
@@ -806,6 +830,12 @@ connection_destroy( Connection *c )
        assert( c->c_struct_state != SLAP_C_UNUSED );
        assert( c->c_conn_state != SLAP_C_INVALID );
        assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
+       assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) );
+#ifdef LDAP_X_TXN
+       assert( c->c_txn == CONN_TXN_INACTIVE );
+       assert( c->c_txn_backend == NULL );
+       assert( LDAP_STAILQ_EMPTY(&c->c_txn_ops) );
+#endif
        assert( c->c_writewaiter == 0);
 
        /* only for stats (print -1 as "%lu" may give unexpected results ;) */
@@ -904,6 +934,7 @@ static void connection_abandon( Connection *c )
        op.o_conn = c;
        op.o_connid = c->c_connid;
        op.o_tag = LDAP_REQ_ABANDON;
+
        for ( o = LDAP_STAILQ_FIRST( &c->c_ops ); o; o=next ) {
                next = LDAP_STAILQ_NEXT( o, o_next );
                op.orn_msgid = o->o_msgid;
@@ -912,6 +943,19 @@ static void connection_abandon( Connection *c )
                frontendDB->be_abandon( &op, &rs );
        }
 
+#ifdef LDAP_X_TXN
+       /* remove operations in pending transaction */
+       while ( (o = LDAP_STAILQ_FIRST( &c->c_txn_ops )) != NULL) {
+               LDAP_STAILQ_REMOVE_HEAD( &c->c_txn_ops, o_next );
+               LDAP_STAILQ_NEXT(o, o_next) = NULL;
+               slap_op_free( o );
+       }
+
+       /* clear transaction */
+       c->c_txn_backend = NULL;
+       c->c_txn = CONN_TXN_INACTIVE;
+#endif
+
        /* remove pending operations */
        while ( (o = LDAP_STAILQ_FIRST( &c->c_pending_ops )) != NULL) {
                LDAP_STAILQ_REMOVE_HEAD( &c->c_pending_ops, o_next );
@@ -954,6 +998,7 @@ void connection_closing( Connection *c, const char *why )
                        ldap_pvt_thread_yield();
                        ldap_pvt_thread_mutex_lock( &c->c_mutex );
                }
+
        } else if( why == NULL && c->c_close_reason == conn_lost_str ) {
                /* Client closed connection after doing Unbind. */
                c->c_close_reason = NULL;
@@ -1030,13 +1075,14 @@ Connection* connection_next( Connection *c, ber_socket_t *index )
 
        assert( connections != NULL );
        assert( index != NULL );
-       assert( *index <= (dtblsize/NUM_CONNECTION_ARRAY) );
+       assert( *index >= 0 && *index <= dtblsize );
 
        if( c != NULL ) ldap_pvt_thread_mutex_unlock( &c->c_mutex );
 
        c = NULL;
 
        for(; *index < dtblsize; (*index)++) {
+               assert( MCA_conn_check( *index ) );
                conn = MCA_GET_CONNECTION(*index);
                if( conn->c_struct_state == SLAP_C_UNINITIALIZED ) {
                        assert( conn->c_conn_state == SLAP_C_INVALID );
@@ -1222,6 +1268,20 @@ connection_operation( void *ctx, void *arg_v )
                goto operations_error;
        }
 
+#ifdef LDAP_X_TXN
+       if (( conn->c_txn == CONN_TXN_SPECIFY ) && (
+               ( tag == LDAP_REQ_ADD ) ||
+               ( tag == LDAP_REQ_DELETE ) ||
+               ( tag == LDAP_REQ_MODIFY ) ||
+               ( tag == LDAP_REQ_MODRDN )))
+       {
+               /* Disable SLAB allocator for all update operations
+                       issued inside of a transaction */
+               op->o_tmpmemctx = NULL;
+               op->o_tmpmfuncs = &ch_mfuncs;
+       } else
+#endif
+       {
        /* We can use Thread-Local storage for most mallocs. We can
         * also use TL for ber parsing, but not on Add or Modify.
         */
@@ -1241,6 +1301,7 @@ connection_operation( void *ctx, void *arg_v )
                 */
                ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, &memctx );
        }
+       }
 
        switch ( tag ) {
        case LDAP_REQ_BIND:
@@ -1333,14 +1394,6 @@ operations_error:
                connection_closing( conn,
                        tag == LDAP_REQ_UNBIND ? NULL : "operations error" );
                break;
-
-       case LDAP_REQ_BIND:
-               conn->c_sasl_bind_in_progress =
-                       rc == LDAP_SASL_BIND_IN_PROGRESS ? 1 : 0;
-
-               if( conn->c_conn_state == SLAP_C_BINDING) {
-                       conn->c_conn_state = SLAP_C_ACTIVE;
-               }
        }
 
        connection_resched( conn );
@@ -1405,26 +1458,29 @@ void connection_client_stop(
 }
 
 #ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-static int connection_read( ber_socket_t s, Operation** op );
+
+static int connection_read( ber_socket_t s, conn_readinfo *cri );
 
 static void* connection_read_thread( void* ctx, void* argv )
 {
        int rc ;
-       Operation* new_op = NULL;
+       conn_readinfo cri = { NULL, NULL, NULL, 0 };
        ber_socket_t s = (long)argv;
 
        /*
         * read incoming LDAP requests. If there is more than one,
         * the first one is returned with new_op
         */
-       if( ( rc = connection_read( s, &new_op ) ) < 0 ) {
+       if( ( rc = connection_read( s, &cri ) ) < 0 ) {
                Debug( LDAP_DEBUG_CONNS, "connection_read(%d) error\n", s, 0, 0 );
                return (void*)(long)rc;
        }
 
-       /* execute the queued request in the same thread */
-       if( new_op ) {
-               rc = (long)connection_operation( ctx, new_op );
+       /* execute a single queued request in the same thread */
+       if( cri.op && !cri.nullop ) {
+               rc = (long)connection_operation( ctx, cri.op );
+       } else if ( cri.func ) {
+               rc = (long)cri.func( ctx, cri.arg );
        }
 
        return (void*)(long)rc;
@@ -1458,7 +1514,7 @@ int connection_read_activate( ber_socket_t s )
 
 #ifdef SLAP_LIGHTWEIGHT_DISPATCHER
 static int
-connection_read( ber_socket_t s, Operation** op )
+connection_read( ber_socket_t s, conn_readinfo *cri )
 #else
 int connection_read(ber_socket_t s)
 #endif
@@ -1499,13 +1555,14 @@ int connection_read(ber_socket_t s)
 
        if ( c->c_conn_state == SLAP_C_CLIENT ) {
 #ifdef SLAP_LIGHTWEIGHT_DISPATCHER
+               cri->func = c->c_clientfunc;
+               cri->arg = c->c_clientarg;
                /* read should already be cleared */
 #else
                slapd_clr_read( s, 0 );
-#endif
                ldap_pvt_thread_pool_submit( &connection_pool,
                        c->c_clientfunc, c->c_clientarg );
-
+#endif
                connection_return( c );
                ldap_pvt_thread_mutex_unlock( MCA_GET_CONN_MUTEX(s) );
                return 0;
@@ -1632,7 +1689,7 @@ int connection_read(ber_socket_t s)
        do {
                /* How do we do this without getting into a busy loop ? */
 #ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-               rc = connection_input( c, op );
+               rc = connection_input( c, cri );
 #else
                rc = connection_input( c );
 #endif
@@ -1682,7 +1739,7 @@ int connection_read(ber_socket_t s)
 
 static int
 #ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-connection_input( Connection *conn , Operation** c_op )
+connection_input( Connection *conn , conn_readinfo *cri )
 #else
 connection_input( Connection *conn )
 #endif
@@ -1871,21 +1928,28 @@ connection_input( Connection *conn )
        } else {
                conn->c_n_ops_executing++;
 
-#if 0
+#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
                /*
                 * The first op will be processed in the same thread context,
+                * as long as there is only one op total.
                 * Subsequent ops will be submitted to the pool by
                 * calling connection_op_activate()
                 */
-               if ( *c_op == NULL ) {
+               if ( cri->op == NULL ) {
                        /* the first incoming request */
                        connection_op_queue( op );
-                       *c_op = op;
-               } else
-#endif
-               {
+                       cri->op = op;
+               } else {
+                       if ( !cri->nullop ) {
+                               cri->nullop = 1;
+                               rc = ldap_pvt_thread_pool_submit( &connection_pool,
+                                       connection_operation, (void *) cri->op );
+                       }
                        connection_op_activate( op );
                }
+#else
+               connection_op_activate( op );
+#endif
        }
 
 #ifdef NO_THREADS
@@ -1978,12 +2042,83 @@ connection_init_log_prefix( Operation *op )
        }
 }
 
+static int connection_bind_cleanup_cb( Operation *op, SlapReply *rs )
+{
+       op->o_conn->c_sasl_bindop = NULL;
+
+       return SLAP_CB_CONTINUE;
+}
+
+static int connection_bind_cb( Operation *op, SlapReply *rs )
+{
+       ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
+       op->o_conn->c_conn_state = SLAP_C_ACTIVE;
+       op->o_conn->c_sasl_bind_in_progress =
+               ( rs->sr_err == LDAP_SASL_BIND_IN_PROGRESS );
+
+       /* Moved here from bind.c due to ITS#4158 */
+       op->o_conn->c_sasl_bindop = NULL;
+       if ( op->orb_method == LDAP_AUTH_SASL ) {
+               if( rs->sr_err == LDAP_SUCCESS ) {
+                       ber_dupbv(&op->o_conn->c_dn, &op->orb_edn);
+                       if( !BER_BVISEMPTY( &op->orb_edn ) ) {
+                               /* edn is always normalized already */
+                               ber_dupbv( &op->o_conn->c_ndn, &op->o_conn->c_dn );
+                       }
+                       op->o_tmpfree( op->orb_edn.bv_val, op->o_tmpmemctx );
+                       BER_BVZERO( &op->orb_edn );
+                       op->o_conn->c_authmech = op->o_conn->c_sasl_bind_mech;
+                       BER_BVZERO( &op->o_conn->c_sasl_bind_mech );
+
+                       op->o_conn->c_sasl_ssf = op->orb_ssf;
+                       if( op->orb_ssf > op->o_conn->c_ssf ) {
+                               op->o_conn->c_ssf = op->orb_ssf;
+                       }
+
+                       if( !BER_BVISEMPTY( &op->o_conn->c_dn ) ) {
+                               ber_len_t max = sockbuf_max_incoming_auth;
+                               ber_sockbuf_ctrl( op->o_conn->c_sb,
+                                       LBER_SB_OPT_SET_MAX_INCOMING, &max );
+                       }
+
+                       /* log authorization identity */
+                       Statslog( LDAP_DEBUG_STATS,
+                               "%s BIND dn=\"%s\" mech=%s ssf=%d\n",
+                               op->o_log_prefix,
+                               BER_BVISNULL( &op->o_conn->c_dn ) ? "<empty>" : op->o_conn->c_dn.bv_val,
+                               op->o_conn->c_authmech.bv_val, op->orb_ssf, 0 );
+
+                       Debug( LDAP_DEBUG_TRACE,
+                               "do_bind: SASL/%s bind: dn=\"%s\" ssf=%d\n",
+                               op->o_conn->c_authmech.bv_val,
+                               BER_BVISNULL( &op->o_conn->c_dn ) ? "<empty>" : op->o_conn->c_dn.bv_val,
+                               op->orb_ssf );
+
+               } else if ( rs->sr_err != LDAP_SASL_BIND_IN_PROGRESS ) {
+                       if ( !BER_BVISNULL( &op->o_conn->c_sasl_bind_mech ) ) {
+                               free( op->o_conn->c_sasl_bind_mech.bv_val );
+                               BER_BVZERO( &op->o_conn->c_sasl_bind_mech );
+                       }
+               }
+       }
+       ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
+
+       ch_free( op->o_callback );
+       op->o_callback = NULL;
+
+       return SLAP_CB_CONTINUE;
+}
+
 static void connection_op_queue( Operation *op )
 {
-       int status;
        ber_tag_t tag = op->o_tag;
 
        if (tag == LDAP_REQ_BIND) {
+               slap_callback *sc = ch_calloc( 1, sizeof( slap_callback ));
+               sc->sc_response = connection_bind_cb;
+               sc->sc_cleanup = connection_bind_cleanup_cb;
+               sc->sc_next = op->o_callback;
+               op->o_callback = sc;
                op->o_conn->c_conn_state = SLAP_C_BINDING;
        }
 
@@ -2021,7 +2156,6 @@ static void connection_op_queue( Operation *op )
 static int connection_op_activate( Operation *op )
 {
        int rc;
-       ber_tag_t tag = op->o_tag;
 
        connection_op_queue( op );
 
@@ -2038,37 +2172,6 @@ static int connection_op_activate( Operation *op )
        return rc;
 }
 
-#ifdef SLAP_LIGHTWEIGHT_DISPATCHER
-static int connection_write( ber_socket_t s );
-static void *connection_write_thread( void *ctx, void *arg )
-{
-       return (void *)(long)connection_write((long)arg);
-}
-
-int connection_write_activate( ber_socket_t s )
-{
-       int rc;
-
-       /*
-        * suspend reading on this file descriptor until a connection processing
-        * thread write data on it. Otherwise the listener thread will repeatedly
-        * submit the same event on it to the pool.
-        */
-       slapd_clr_write( s, 0);
-
-       rc = ldap_pvt_thread_pool_submit( &connection_pool,
-               connection_write_thread, (void *)(long)s );
-
-       if( rc != 0 ) {
-               Debug( LDAP_DEBUG_ANY,
-                       "connection_write_activate(%d): submit failed (%d)\n",
-                       (int) s, rc, 0 );
-       }
-       return rc;
-}
-
-static
-#endif
 int connection_write(ber_socket_t s)
 {
        Connection *c;
@@ -2076,6 +2179,8 @@ int connection_write(ber_socket_t s)
 
        assert( connections != NULL );
 
+       slapd_clr_write( s, 0 );
+
        ldap_pvt_thread_mutex_lock( MCA_GET_CONN_MUTEX( s ) );
 
        c = connection_get( s );
@@ -2087,9 +2192,6 @@ int connection_write(ber_socket_t s)
                return -1;
        }
 
-#ifndef SLAP_LIGHTWEIGHT_DISPATCHER
-       slapd_clr_write( s, 0);
-#endif
        c->c_n_write++;
 
        Debug( LDAP_DEBUG_TRACE,
@@ -2156,6 +2258,11 @@ connection_fake_init(
        op->o_connid = op->o_conn->c_connid;
        connection_init_log_prefix( op );
 
+#ifdef LDAP_SLAPI
+       slapi_int_create_object_extensions( SLAPI_X_EXT_CONNECTION, conn );
+       slapi_int_create_object_extensions( SLAPI_X_EXT_OPERATION, op );
+#endif /* LDAP_SLAPI */
+
        slap_op_time( &op->o_time, &op->o_tincr );
 }