]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/connection.c
Referrals should not (except in special cases) be
[openldap] / servers / slapd / connection.c
index 9ee80e6d86c2a8183239daa30e690ebd3600ac56..ca7ad67580bbecbe83b288c0582903427ddd18f6 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2003 The OpenLDAP Foundation.
+ * Copyright 1998-2004 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 #include "slap.h"
 
 #ifdef LDAP_SLAPI
-#include "slapi.h"
+#include "slapi/slapi.h"
 #endif
 
 /* protected by connections_mutex */
 static ldap_pvt_thread_mutex_t connections_mutex;
 static Connection *connections = NULL;
+
+static ldap_pvt_thread_mutex_t conn_nextid_mutex;
 static unsigned long conn_nextid = 0;
 
 /* structure state (protected by connections_mutex) */
@@ -92,6 +94,8 @@ static ldap_pvt_thread_start_t connection_operation;
  */
 int connections_init(void)
 {
+       int i;
+
        assert( connections == NULL );
 
        if( connections != NULL) {
@@ -107,6 +111,7 @@ int connections_init(void)
 
        /* should check return of every call */
        ldap_pvt_thread_mutex_init( &connections_mutex );
+       ldap_pvt_thread_mutex_init( &conn_nextid_mutex );
 
        connections = (Connection *) ch_calloc( dtblsize, sizeof(Connection) );
 
@@ -126,6 +131,8 @@ int connections_init(void)
        assert( connections[0].c_struct_state == SLAP_C_UNINITIALIZED );
        assert( connections[dtblsize-1].c_struct_state == SLAP_C_UNINITIALIZED );
 
+       for (i=0; i<dtblsize; i++) connections[i].c_conn_idx = i;
+
        /*
         * per entry initialization of the Connection array initialization
         * will be done by connection_init()
@@ -162,7 +169,7 @@ int connections_destroy(void)
                        ldap_pvt_thread_cond_destroy( &connections[i].c_write_cv );
 #ifdef LDAP_SLAPI
                        if ( slapi_plugins_used ) {
-                               slapi_x_free_object_extensions( SLAPI_X_EXT_CONNECTION, &connections[i] );
+                               slapi_int_free_object_extensions( SLAPI_X_EXT_CONNECTION, &connections[i] );
                        }
 #endif
                }
@@ -172,6 +179,7 @@ int connections_destroy(void)
        connections = NULL;
 
        ldap_pvt_thread_mutex_destroy( &connections_mutex );
+       ldap_pvt_thread_mutex_destroy( &conn_nextid_mutex );
        return 0;
 }
 
@@ -321,7 +329,6 @@ static Connection* connection_get( ber_socket_t s )
                        ldap_pvt_thread_mutex_unlock( &c->c_mutex );
                        return NULL;
                }
-               if( c->c_conn_state == SLAP_C_CLIENT ) sd = 0;
 
 #ifdef NEW_LOGGING
                LDAP_LOG( CONNECTION, RESULTS, 
@@ -362,7 +369,7 @@ long connection_init(
        const char* peername,
        int flags,
        slap_ssf_t ssf,
-       const char *authid )
+       struct berval *authid )
 {
        unsigned long id;
        Connection *c;
@@ -424,6 +431,10 @@ long connection_init(
                                break;
                        }
 
+                       if( connections[i].c_conn_state == SLAP_C_CLIENT ) {
+                               continue;
+                       }
+
                        assert( connections[i].c_struct_state == SLAP_C_USED );
                        assert( connections[i].c_conn_state != SLAP_C_INVALID );
                        assert( sd != AC_SOCKET_INVALID );
@@ -456,24 +467,18 @@ long connection_init(
                c->c_send_ldap_intermediate = slap_send_ldap_intermediate;
 #endif
 
-               c->c_authmech.bv_val = NULL;
-               c->c_authmech.bv_len = 0;
-               c->c_dn.bv_val = NULL;
-               c->c_dn.bv_len = 0;
-               c->c_ndn.bv_val = NULL;
-               c->c_ndn.bv_len = 0;
+               BER_BVZERO( &c->c_authmech );
+               BER_BVZERO( &c->c_dn );
+               BER_BVZERO( &c->c_ndn );
 
                c->c_listener = NULL;
-               c->c_peer_domain.bv_val = NULL;
-               c->c_peer_domain.bv_len = 0;
-               c->c_peer_name.bv_val = NULL;
-               c->c_peer_name.bv_len = 0;
+               BER_BVZERO( &c->c_peer_domain );
+               BER_BVZERO( &c->c_peer_name );
 
                LDAP_STAILQ_INIT(&c->c_ops);
                LDAP_STAILQ_INIT(&c->c_pending_ops);
 
-               c->c_sasl_bind_mech.bv_val = NULL;
-               c->c_sasl_bind_mech.bv_len = 0;
+               BER_BVZERO( &c->c_sasl_bind_mech );
                c->c_sasl_done = 0;
                c->c_sasl_authctx = NULL;
                c->c_sasl_sockctx = NULL;
@@ -496,7 +501,7 @@ long connection_init(
 
 #ifdef LDAP_SLAPI
                if ( slapi_plugins_used ) {
-                       slapi_x_create_object_extensions( SLAPI_X_EXT_CONNECTION, c );
+                       slapi_int_create_object_extensions( SLAPI_X_EXT_CONNECTION, c );
                }
 #endif
 
@@ -506,15 +511,15 @@ long connection_init(
        ldap_pvt_thread_mutex_lock( &c->c_mutex );
 
        assert( c->c_struct_state == SLAP_C_UNUSED );
-       assert( c->c_authmech.bv_val == NULL );
-       assert( c->c_dn.bv_val == NULL );
-       assert( c->c_ndn.bv_val == NULL );
+       assert( BER_BVISNULL( &c->c_authmech ) );
+       assert( BER_BVISNULL( &c->c_dn ) );
+       assert( BER_BVISNULL( &c->c_ndn ) );
        assert( c->c_listener == NULL );
-       assert( c->c_peer_domain.bv_val == NULL );
-       assert( c->c_peer_name.bv_val == NULL );
+       assert( BER_BVISNULL( &c->c_peer_domain ) );
+       assert( BER_BVISNULL( &c->c_peer_name ) );
        assert( LDAP_STAILQ_EMPTY(&c->c_ops) );
        assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) );
-       assert( c->c_sasl_bind_mech.bv_val == NULL );
+       assert( BER_BVISNULL( &c->c_sasl_bind_mech ) );
        assert( c->c_sasl_done == 0 );
        assert( c->c_sasl_authctx == NULL );
        assert( c->c_sasl_sockctx == NULL );
@@ -528,6 +533,7 @@ long connection_init(
        if ( flags == CONN_IS_CLIENT ) {
                c->c_conn_state = SLAP_C_CLIENT;
                c->c_struct_state = SLAP_C_USED;
+               ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_FD, &s );
                ldap_pvt_thread_mutex_unlock( &c->c_mutex );
                ldap_pvt_thread_mutex_unlock( &connections_mutex );
 
@@ -599,7 +605,9 @@ long connection_init(
 #endif
        }
 
+       ldap_pvt_thread_mutex_lock( &conn_nextid_mutex );
        id = c->c_connid = conn_nextid++;
+       ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex );
 
        c->c_conn_state = SLAP_C_INACTIVE;
        c->c_struct_state = SLAP_C_USED;
@@ -640,20 +648,17 @@ void connection2anonymous( Connection *c )
 
        if(c->c_authmech.bv_val != NULL ) {
                free(c->c_authmech.bv_val);
-               c->c_authmech.bv_val = NULL;
        }
-       c->c_authmech.bv_len = 0;
+       BER_BVZERO( &c->c_authmech );
 
        if(c->c_dn.bv_val != NULL) {
                free(c->c_dn.bv_val);
-               c->c_dn.bv_val = NULL;
        }
-       c->c_dn.bv_len = 0;
+       BER_BVZERO( &c->c_dn );
        if(c->c_ndn.bv_val != NULL) {
                free(c->c_ndn.bv_val);
-               c->c_ndn.bv_val = NULL;
        }
-       c->c_ndn.bv_len = 0;
+       BER_BVZERO( &c->c_ndn );
 
        c->c_authz_backend = NULL;
 }
@@ -687,21 +692,18 @@ connection_destroy( Connection *c )
 
        if(c->c_peer_domain.bv_val != NULL) {
                free(c->c_peer_domain.bv_val);
-               c->c_peer_domain.bv_val = NULL;
        }
-       c->c_peer_domain.bv_len = 0;
+       BER_BVZERO( &c->c_peer_domain );
        if(c->c_peer_name.bv_val != NULL) {
                free(c->c_peer_name.bv_val);
-               c->c_peer_name.bv_val = NULL;
        }
-       c->c_peer_name.bv_len = 0;
+       BER_BVZERO( &c->c_peer_name );
 
        c->c_sasl_bind_in_progress = 0;
        if(c->c_sasl_bind_mech.bv_val != NULL) {
                free(c->c_sasl_bind_mech.bv_val);
-               c->c_sasl_bind_mech.bv_val = NULL;
        }
-       c->c_sasl_bind_mech.bv_len = 0;
+       BER_BVZERO( &c->c_sasl_bind_mech );
 
        slap_sasl_close( c );
 
@@ -734,7 +736,7 @@ connection_destroy( Connection *c )
 #ifdef LDAP_SLAPI
        /* call destructors, then constructors; avoids unnecessary allocation */
        if ( slapi_plugins_used ) {
-               slapi_x_clear_object_extensions( SLAPI_X_EXT_CONNECTION, c );
+               slapi_int_clear_object_extensions( SLAPI_X_EXT_CONNECTION, c );
        }
 #endif
 }
@@ -940,7 +942,7 @@ void connection_done( Connection *c )
 static void *
 connection_operation( void *ctx, void *arg_v )
 {
-       int rc = SLAPD_DISCONNECT;
+       int rc = LDAP_OTHER;
        Operation *op = arg_v;
        SlapReply rs = {REP_RESULT};
        ber_tag_t tag = op->o_tag;
@@ -958,6 +960,36 @@ connection_operation( void *ctx, void *arg_v )
 
        op->o_threadctx = ctx;
 
+       switch ( tag ) {
+       case LDAP_REQ_BIND:
+       case LDAP_REQ_UNBIND:
+       case LDAP_REQ_ADD:
+       case LDAP_REQ_DELETE:
+       case LDAP_REQ_MODRDN:
+       case LDAP_REQ_MODIFY:
+       case LDAP_REQ_COMPARE:
+       case LDAP_REQ_SEARCH:
+       case LDAP_REQ_ABANDON:
+       case LDAP_REQ_EXTENDED:
+               break;
+       default:
+#ifdef NEW_LOGGING
+               LDAP_LOG( CONNECTION, INFO, "connection_operation: "
+                       "conn %lu unknown LDAP request 0x%lx\n",
+                       conn->c_connid, tag, 0 );
+#else
+               Debug( LDAP_DEBUG_ANY, "connection_operation: "
+                       "conn %lu unknown LDAP request 0x%lx\n",
+                       conn->c_connid, tag, 0 );
+#endif
+               op->o_tag = LBER_ERROR;
+               rs.sr_err = LDAP_PROTOCOL_ERROR;
+               rs.sr_text = "unknown LDAP request";
+               send_ldap_disconnect( op, &rs );
+               rc = SLAPD_DISCONNECT;
+               goto operations_error;
+       }
+
        if( conn->c_sasl_bind_in_progress && tag != LDAP_REQ_BIND ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( CONNECTION, ERR, 
@@ -970,6 +1002,7 @@ connection_operation( void *ctx, void *arg_v )
 #endif
                send_ldap_error( op, &rs, LDAP_OPERATIONS_ERROR,
                        "SASL bind in progress" );
+               rc = LDAP_OPERATIONS_ERROR;
                goto operations_error;
        }
 
@@ -978,13 +1011,13 @@ connection_operation( void *ctx, void *arg_v )
         */
 #if 0
        memsiz = ber_len( op->o_ber ) * 64;
-       if ( SLMALLOC_SLAB_SIZE > memsiz ) memsiz = SLMALLOC_SLAB_SIZE;
+       if ( SLAP_SLAB_SIZE > memsiz ) memsiz = SLAP_SLAB_SIZE;
 #endif
-       memsiz = SLMALLOC_SLAB_SIZE;
+       memsiz = SLAP_SLAB_SIZE;
 
-       memctx = sl_mem_create( memsiz, ctx );
+       memctx = slap_sl_mem_create( memsiz, ctx );
        op->o_tmpmemctx = memctx;
-       op->o_tmpmfuncs = &sl_mfuncs;
+       op->o_tmpmfuncs = &slap_sl_mfuncs;
        if ( tag != LDAP_REQ_ADD && tag != LDAP_REQ_MODIFY ) {
                /* Note - the ber and its buffer are already allocated from
                 * regular memory; this only affects subsequent mallocs that
@@ -1045,29 +1078,15 @@ connection_operation( void *ctx, void *arg_v )
                break;
 
        default:
-#ifdef NEW_LOGGING
-               LDAP_LOG( CONNECTION, INFO, 
-                       "connection_operation: conn %lu unknown LDAP request 0x%lx\n",
-                       conn->c_connid, tag, 0 );
-#else
-               Debug( LDAP_DEBUG_ANY, "unknown LDAP request 0x%lx\n",
-                       tag, 0, 0 );
-#endif
-               op->o_tag = LBER_ERROR;
-               rs.sr_err = LDAP_PROTOCOL_ERROR;
-               rs.sr_text = "unknown LDAP request";
-               send_ldap_disconnect( op, &rs );
-               rc = -1;
-               break;
+               /* not reachable */
+               assert( 0 );
        }
 
-#ifdef SLAPD_MONITOR
-       oldtag = tag;
-#endif /* SLAPD_MONITOR */
+operations_error:
        if( rc == SLAPD_DISCONNECT ) tag = LBER_ERROR;
 
-operations_error:
        ldap_pvt_thread_mutex_lock( &num_ops_mutex );
+
        num_ops_completed++;
 #ifdef SLAPD_MONITOR
        switch (oldtag) {
@@ -1101,35 +1120,38 @@ operations_error:
        case LDAP_REQ_EXTENDED:
                num_ops_completed_[SLAP_OP_EXTENDED]++;
                break;
+       default:
+               /* not reachable */
+               assert( 0 );
        }
 #endif /* SLAPD_MONITOR */
        ldap_pvt_thread_mutex_unlock( &num_ops_mutex );
 
-#ifdef LDAP_EXOP_X_CANCEL
        if ( op->o_cancel == SLAP_CANCEL_REQ ) {
                op->o_cancel = LDAP_TOO_LATE;
        }
-
        while ( op->o_cancel != SLAP_CANCEL_NONE &&
                op->o_cancel != SLAP_CANCEL_DONE )
        {
                ldap_pvt_thread_yield();
        }
-#endif
 
        ldap_pvt_thread_mutex_lock( &conn->c_mutex );
 
        ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, &memctx_null );
 
        if ( op->o_cancel != SLAP_CANCEL_ACK &&
-                               ( op->o_sync_mode & SLAP_SYNC_PERSIST ) ) {
-               sl_mem_detach( ctx, memctx );
-       } else if (( op->o_sync_slog_size != -1 )) {
-               sl_mem_detach( ctx, memctx );
+               ( op->o_sync_mode & SLAP_SYNC_PERSIST ) )
+       {
+               slap_sl_mem_detach( ctx, memctx );
+
+       } else if ( op->o_sync_slog_size != -1 ) {
+               slap_sl_mem_detach( ctx, memctx );
                LDAP_STAILQ_REMOVE( &conn->c_ops, op, slap_op, o_next);
                LDAP_STAILQ_NEXT(op, o_next) = NULL;
                conn->c_n_ops_executing--;
                conn->c_n_ops_completed++;
+
        } else {
                LDAP_STAILQ_REMOVE( &conn->c_ops, op, slap_op, o_next);
                LDAP_STAILQ_NEXT(op, o_next) = NULL;
@@ -1155,23 +1177,23 @@ operations_error:
        }
 
        connection_resched( conn );
-
        ldap_pvt_thread_mutex_unlock( &conn->c_mutex );
-
        return NULL;
 }
 
+static const Listener dummy_list = { BER_BVC(""), BER_BVC("") };
+
 int connection_client_setup(
        ber_socket_t s,
-       Listener *l,
        ldap_pvt_thread_start_t *func,
        void *arg )
 {
+       int rc;
        Connection *c;
 
-       if ( connection_init( s, l, "", "", CONN_IS_CLIENT, 0, "" ) < 0 ) {
-               return -1;
-       }
+       rc = connection_init( s, (Listener *)&dummy_list, "", "",
+               CONN_IS_CLIENT, 0, NULL );
+       if ( rc < 0 ) return -1;
 
        c = connection_get( s );
        c->c_clientfunc = func;
@@ -1183,15 +1205,13 @@ int connection_client_setup(
 }
 
 void connection_client_enable(
-       ber_socket_t s
-)
+       ber_socket_t s )
 {
        slapd_set_read( s, 1 );
 }
 
 void connection_client_stop(
-       ber_socket_t s
-)
+       ber_socket_t s )
 {
        Connection *c;
 
@@ -1272,7 +1292,7 @@ int connection_read(ber_socket_t s)
 
 #ifdef HAVE_TLS
        if ( c->c_is_tls && c->c_needs_tls_accept ) {
-               rc = ldap_pvt_tls_accept( c->c_sb, NULL );
+               rc = ldap_pvt_tls_accept( c->c_sb, slap_tls_ctx );
                if ( rc < 0 ) {
 #if 0 /* required by next #if 0 */
                        struct timeval tv;
@@ -1311,7 +1331,7 @@ int connection_read(ber_socket_t s)
 
                } else if ( rc == 0 ) {
                        void *ssl;
-                       struct berval authid = { 0, NULL };
+                       struct berval authid = BER_BVNULL;
 
                        c->c_needs_tls_accept = 0;
 
@@ -1326,18 +1346,17 @@ int connection_read(ber_socket_t s)
                        rc = dnX509peerNormalize( ssl, &authid );
                        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG( CONNECTION, INFO, 
-                                       "connection_read: conn %lu unable to get TLS client DN, "
-                                       "error %d\n", c->c_connid, rc, 0 );
+                               LDAP_LOG( CONNECTION, INFO, "connection_read: "
+                                       "conn %lu unable to get TLS client DN, error %d\n",
+                                       c->c_connid, rc, 0 );
 #else
-                               Debug( LDAP_DEBUG_TRACE,
-                               "connection_read(%d): unable to get TLS client DN "
-                               "error=%d id=%lu\n",
-                               s, rc, c->c_connid );
+                               Debug( LDAP_DEBUG_TRACE, "connection_read(%d): "
+                                       "unable to get TLS client DN, error=%d id=%lu\n",
+                                       s, rc, c->c_connid );
 #endif
                        }
-                       slap_sasl_external( c, c->c_tls_ssf, authid.bv_val );
-                       if ( authid.bv_val )    free( authid.bv_val );
+                       slap_sasl_external( c, c->c_tls_ssf, &authid );
+                       if ( authid.bv_val ) free( authid.bv_val );
                }
 
                /* if success and data is ready, fall thru to data input loop */
@@ -1388,13 +1407,12 @@ int connection_read(ber_socket_t s)
 #define CONNECTION_INPUT_LOOP 1
 /* #define     DATA_READY_LOOP 1 */
 
-       do
-       {
+       do {
                /* How do we do this without getting into a busy loop ? */
                rc = connection_input( c );
        }
 #ifdef DATA_READY_LOOP
-       while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ) );
+       while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ));
 #elif CONNECTION_INPUT_LOOP
        while(!rc);
 #else
@@ -1434,8 +1452,7 @@ int connection_read(ber_socket_t s)
 
 static int
 connection_input(
-       Connection *conn
-)
+       Connection *conn )
 {
        Operation *op;
        ber_tag_t       tag;
@@ -1447,6 +1464,7 @@ connection_input(
        Sockaddr        peeraddr;
        char            *cdn = NULL;
 #endif
+       char *defer = NULL;
 
        if ( conn->c_currentber == NULL &&
                ( conn->c_currentber = ber_alloc()) == NULL )
@@ -1567,10 +1585,11 @@ connection_input(
        op->o_preread_attrs = NULL;
        op->o_postread_attrs = NULL;
        op->o_vrFilter = NULL;
-
-#ifdef LDAP_CONTROL_PAGEDRESULTS
+       /* clear state if the connection is being reused from inactive */
+       if ( conn->c_conn_state == SLAP_C_INACTIVE ) {
+               memset( &conn->c_pagedresults_state, 0, sizeof( conn->c_pagedresults_state ) );
+       }
        op->o_pagedresults_state = conn->c_pagedresults_state;
-#endif
 
        op->o_res_ber = NULL;
 
@@ -1619,28 +1638,34 @@ connection_input(
         * Bind, or if it's closing. Also, don't let any single conn
         * use up all the available threads, and don't execute if we're
         * currently blocked on output. And don't execute if there are
-        * already pending ops, let them go first.
-        *
-        * But always allow Abandon through; it won't cost much.
+        * already pending ops, let them go first.  Abandon operations
+        * get exceptions to some, but not all, cases.
         */
-       if ( tag != LDAP_REQ_ABANDON && (conn->c_conn_state == SLAP_C_BINDING
-               || conn->c_conn_state == SLAP_C_CLOSING
-               || conn->c_n_ops_executing >= connection_pool_max/2
-               || conn->c_n_ops_pending
-               || conn->c_writewaiter))
-       {
+       if (tag != LDAP_REQ_ABANDON && conn->c_conn_state == SLAP_C_CLOSING) {
+               defer = "closing";
+       } else if (tag != LDAP_REQ_ABANDON && conn->c_writewaiter) {
+               defer = "awaiting write";
+       } else if (conn->c_n_ops_executing >= connection_pool_max/2) {
+               defer = "too many executing";
+       } else if (conn->c_conn_state == SLAP_C_BINDING) {
+               defer = "binding";
+       } else if (tag != LDAP_REQ_ABANDON && conn->c_n_ops_pending) {
+               defer = "pending operations";
+       }
+
+       if( defer ) {
                int max = conn->c_dn.bv_len
                        ? slap_conn_max_pending_auth
                        : slap_conn_max_pending;
 
 #ifdef NEW_LOGGING
                LDAP_LOG( CONNECTION, INFO, 
-                       "connection_input: conn %lu deferring operation\n",
-                       conn->c_connid, 0, 0 );
+                       "connection_input: conn %lu deferring operation: %s\n",
+                       conn->c_connid, defer, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
-                       "connection_input: conn=%lu deferring operation\n",
-                       conn->c_connid, 0, 0 );
+                       "connection_input: conn=%lu deferring operation: %s\n",
+                       conn->c_connid, defer, 0 );
 #endif
                conn->c_n_ops_pending++;
                LDAP_STAILQ_INSERT_TAIL( &conn->c_pending_ops, op, o_next );
@@ -1850,3 +1875,36 @@ int connection_write(ber_socket_t s)
        return 0;
 }
 
+void
+connection_fake_init(
+       Connection *conn,
+       Operation *op,
+       void *ctx )
+{
+       conn->c_connid = -1;
+       conn->c_send_ldap_result = slap_send_ldap_result;
+       conn->c_send_search_entry = slap_send_search_entry;
+       conn->c_send_search_reference = slap_send_search_reference;
+       conn->c_listener = (Listener *)&dummy_list;
+       conn->c_peer_domain = slap_empty_bv;
+       conn->c_peer_name = slap_empty_bv;
+
+       /* set memory context */
+       op->o_tmpmemctx = slap_sl_mem_create( SLAP_SLAB_SIZE, ctx );
+       op->o_tmpmfuncs = &slap_sl_mfuncs;
+       op->o_threadctx = ctx;
+
+       op->o_conn = conn;
+       op->o_connid = op->o_conn->c_connid;
+
+       op->o_time = slap_get_time();
+}
+
+void
+connection_assign_nextid( Connection *conn )
+{
+       ldap_pvt_thread_mutex_lock( &conn_nextid_mutex );
+       conn->c_connid = conn_nextid++;
+       ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex );
+}
+