Fix corrupted CSN issue

[openldap] / servers / slapd / ctxcsn.c

diff --git a/servers/slapd/ctxcsn.c b/servers/slapd/ctxcsn.c
index 772bfa17fba9641ec6872bdf1687819aa9494ab2..873721600fcf8963f559d9fd8a95a054a0594806 100644 (file)
--- a/servers/slapd/ctxcsn.c
+++ b/servers/slapd/ctxcsn.c
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2003-2008 The OpenLDAP Foundation.
+ * Copyright 2003-2009 The OpenLDAP Foundation.
  * Portions Copyright 2003 IBM Corporation.
  * All rights reserved.
  *
@@ -30,24 +30,31 @@ const struct berval slap_ldapsync_bv = BER_BVC("ldapsync");
 const struct berval slap_ldapsync_cn_bv = BER_BVC("cn=ldapsync");
 int slap_serverID;
 
+/* maxcsn->bv_val must point to a char buf[LDAP_LUTIL_CSNSTR_BUFSIZE] */
 void
 slap_get_commit_csn(
        Operation *op,
-       struct berval *maxcsn
+       struct berval *maxcsn,
+       int *foundit
 )
 {
        struct slap_csn_entry *csne, *committed_csne = NULL;
        BackendDB *be = op->o_bd->bd_self;
 
        if ( maxcsn ) {
-               BER_BVZERO( maxcsn );
+               assert( maxcsn->bv_val != NULL );
+               assert( maxcsn->bv_len >= LDAP_LUTIL_CSNSTR_BUFSIZE );
+       }
+       if ( foundit ) {
+               *foundit = 0;
        }
 
-       ldap_pvt_thread_mutex_lock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_lock( &be->be_pcl_mutex );
 
        LDAP_TAILQ_FOREACH( csne, be->be_pending_csn_list, ce_csn_link ) {
                if ( csne->ce_opid == op->o_opid && csne->ce_connid == op->o_connid ) {
                        csne->ce_state = SLAP_CSN_COMMIT;
+                       if ( foundit ) *foundit = 1;
                        break;
                }
        }
@@ -57,8 +64,18 @@ slap_get_commit_csn(
                if ( csne->ce_state == SLAP_CSN_PENDING ) break;
        }
 
-       if ( committed_csne && maxcsn ) *maxcsn = committed_csne->ce_csn;
-       ldap_pvt_thread_mutex_unlock( be->be_pcl_mutexp );
+       if ( maxcsn ) {
+               if ( committed_csne ) {
+                       if ( committed_csne->ce_csn.bv_len < maxcsn->bv_len )
+                               maxcsn->bv_len = committed_csne->ce_csn.bv_len;
+                       AC_MEMCPY( maxcsn->bv_val, committed_csne->ce_csn.bv_val,
+                               maxcsn->bv_len+1 );
+               } else {
+                       maxcsn->bv_len = 0;
+                       maxcsn->bv_val[0] = 0;
+               }
+       }
+       ldap_pvt_thread_mutex_unlock( &be->be_pcl_mutex );
 }
 
 void
@@ -67,7 +84,7 @@ slap_rewind_commit_csn( Operation *op )
        struct slap_csn_entry *csne;
        BackendDB *be = op->o_bd->bd_self;
 
-       ldap_pvt_thread_mutex_lock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_lock( &be->be_pcl_mutex );
 
        LDAP_TAILQ_FOREACH( csne, be->be_pending_csn_list, ce_csn_link ) {
                if ( csne->ce_opid == op->o_opid && csne->ce_connid == op->o_connid ) {
@@ -76,7 +93,7 @@ slap_rewind_commit_csn( Operation *op )
                }
        }
 
-       ldap_pvt_thread_mutex_unlock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_unlock( &be->be_pcl_mutex );
 }
 
 void
@@ -89,15 +106,7 @@ slap_graduate_commit_csn( Operation *op )
        if ( op->o_bd == NULL ) return;
        be = op->o_bd->bd_self;
 
-#if 0
-       /* it is NULL when we get here from the frontendDB;
-        * alternate fix: initialize frontendDB like all other backends */
-       assert( op->o_bd->be_pcl_mutexp != NULL );
-#endif
-       
-       if ( be->be_pcl_mutexp == NULL ) return;
-
-       ldap_pvt_thread_mutex_lock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_lock( &be->be_pcl_mutex );
 
        LDAP_TAILQ_FOREACH( csne, be->be_pending_csn_list, ce_csn_link ) {
                if ( csne->ce_opid == op->o_opid && csne->ce_connid == op->o_connid ) {
@@ -114,7 +123,7 @@ slap_graduate_commit_csn( Operation *op )
                }
        }
 
-       ldap_pvt_thread_mutex_unlock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_unlock( &be->be_pcl_mutex );
 
        return;
 }
@@ -172,7 +181,7 @@ slap_queue_csn(
 
        Debug( LDAP_DEBUG_SYNC, "slap_queue_csn: queing %p %s\n", csn->bv_val, csn->bv_val, 0 );
 
-       ldap_pvt_thread_mutex_lock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_lock( &be->be_pcl_mutex );
 
        ber_dupbv( &pending->ce_csn, csn );
        ber_bvreplace_x( &op->o_csn, &pending->ce_csn, op->o_tmpmemctx );
@@ -181,7 +190,7 @@ slap_queue_csn(
        pending->ce_state = SLAP_CSN_PENDING;
        LDAP_TAILQ_INSERT_TAIL( be->be_pending_csn_list,
                pending, ce_csn_link );
-       ldap_pvt_thread_mutex_unlock( be->be_pcl_mutexp );
+       ldap_pvt_thread_mutex_unlock( &be->be_pcl_mutex );
 }
 
 int
@@ -195,10 +204,10 @@ slap_get_csn(
        /* gmtime doesn't always need a mutex, but lutil_csnstr does */
        ldap_pvt_thread_mutex_lock( &gmtime_mutex );
        csn->bv_len = lutil_csnstr( csn->bv_val, csn->bv_len, slap_serverID, 0 );
-       ldap_pvt_thread_mutex_unlock( &gmtime_mutex );
-
        if ( manage_ctxcsn )
                slap_queue_csn( op, csn );
 
+       ldap_pvt_thread_mutex_unlock( &gmtime_mutex );
+
        return LDAP_SUCCESS;
 }