]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/daemon.c
Fix for ITS#1842 (applied blindly)
[openldap] / servers / slapd / daemon.c
index aca6614a0e5d108d0ead99bb89e73bf45ccfd909..137734c104b8d3a3d2fb8557cd4d137c911d21e1 100644 (file)
@@ -10,7 +10,6 @@
 
 #include <ac/ctype.h>
 #include <ac/errno.h>
-#include <ac/signal.h>
 #include <ac/socket.h>
 #include <ac/string.h>
 #include <ac/time.h>
@@ -56,12 +55,12 @@ do { if (w) tcp_write( wake_sds[1], "0", 1 ); } while(0)
 #ifndef HAVE_WINSOCK
 static
 #endif
-volatile sig_atomic_t slapd_shutdown = 0;
+volatile sig_atomic_t slapd_shutdown = 0, slapd_gentle_shutdown = 0;
 
 static struct slap_daemon {
        ldap_pvt_thread_mutex_t sd_mutex;
 
-       int sd_nactives;
+       ber_socket_t sd_nactives;
 
 #ifndef HAVE_WINSOCK
        /* In winsock, accept() returns values higher than dtblsize
@@ -193,6 +192,8 @@ static void slapd_add(ber_socket_t s) {
        }
 #endif
 
+       slap_daemon.sd_nactives++;
+
        FD_SET( s, &slap_daemon.sd_actives );
        FD_SET( s, &slap_daemon.sd_readers );
 
@@ -217,6 +218,8 @@ static void slapd_add(ber_socket_t s) {
 void slapd_remove(ber_socket_t s, int wake) {
        ldap_pvt_thread_mutex_lock( &slap_daemon.sd_mutex );
 
+       slap_daemon.sd_nactives--;
+
 #ifdef NEW_LOGGING
        LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
                   "slapd_remove: removing %ld%s%s\n",
@@ -234,7 +237,7 @@ void slapd_remove(ber_socket_t s, int wake) {
        FD_CLR( s, &slap_daemon.sd_writers );
 
        ldap_pvt_thread_mutex_unlock( &slap_daemon.sd_mutex );
-       WAKE_LISTENER(wake);
+       WAKE_LISTENER(wake || slapd_gentle_shutdown < 0);
 }
 
 void slapd_clr_write(ber_socket_t s, int wake) {
@@ -330,136 +333,26 @@ static int get_url_perms(
                if ( strncasecmp( type, LDAPI_MOD_URLEXT "=", sizeof(LDAPI_MOD_URLEXT "=") - 1 ) == 0 ) {
                        char    *value = type + sizeof(LDAPI_MOD_URLEXT "=") - 1;
                        mode_t  p = 0;
+                       int     j;
 
-#if 0
-                       if ( strlen( value ) != 9 ) {
-                               return LDAP_OTHER;
-                       }
-
-                       switch ( value[ 0 ] ) {
-                       case 'r':
-                               p |= S_IRUSR;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 1 ] ) {
-                       case 'w':
-                               p |= S_IWUSR;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 2 ] ) {
-                       case 'x':
-                               p |= S_IXUSR;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 3 ] ) {
-                       case 'r':
-                               p |= S_IRGRP;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 4 ] ) {
-                       case 'w':
-                               p |= S_IWGRP;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 5 ] ) {
-                       case 'x':
-                               p |= S_IXGRP;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 6 ] ) {
-                       case 'r':
-                               p |= S_IROTH;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 7 ] ) {
-                       case 'w':
-                               p |= S_IWOTH;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 8 ] ) {
-                       case 'x':
-                               p |= S_IXOTH;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-#else
                        if ( strlen(value) != 3 ) {
                                return LDAP_OTHER;
                        } 
 
-                       switch ( value[ 0 ] ) {
-                       case 'w':
-                               p |= S_IRWXU;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
+                       for ( j = 0; j < 3; j++ ) {
+                               static mode_t   m[ 3 ] 
+                                       = { S_IRWXU, S_IRWXG, S_IRWXO };
 
-                       switch ( value[ 1 ] ) {
-                       case 'w':
-                               p |= S_IRWXG;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
-                       } 
-
-                       switch ( value[ 2 ] ) {
-                       case 'w':
-                               p |= S_IRWXO;
-                               break;
-                       case '-':
-                               break;
-                       default:
-                               return LDAP_OTHER;
+                               switch ( value[ j ] ) {
+                               case 'w':
+                                       p |= m[ j ];
+                                       break;
+                               case '-':
+                                       break;
+                               default:
+                                       return LDAP_OTHER;
+                               }
                        } 
-#endif
 
                        *crit = c;
                        *perms = p;
@@ -467,6 +360,8 @@ static int get_url_perms(
                        return LDAP_SUCCESS;
                }
        }
+
+       return LDAP_OTHER;
 }
 #endif /* LDAP_PF_LOCAL */
 
@@ -595,13 +490,15 @@ static int slap_get_listener_addresses(
 
                freeaddrinfo(res);
 #else
+               int i, n = 1;
                struct in_addr in;
+               struct hostent *he = NULL;
 
                if ( host == NULL ) {
                        in.s_addr = htonl(INADDR_ANY);
 
                } else if ( !inet_aton( host, &in ) ) {
-                       struct hostent *he = gethostbyname( host );
+                       he = gethostbyname( host );
                        if( he == NULL ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
@@ -613,25 +510,30 @@ static int slap_get_listener_addresses(
 #endif
                                return -1;
                        }
-                       AC_MEMCPY( &in, he->h_addr, sizeof( in ) );
+                       for (n = 0; he->h_addr_list[n]; n++) ;
                }
 
-               *sal = ch_malloc(2 * sizeof(void *));
+               *sal = ch_malloc((n+1) * sizeof(void *));
                if (*sal == NULL) {
                        return -1;
                }
 
                sap = *sal;
-               *sap = ch_malloc(sizeof(struct sockaddr_in));
-               if (*sap == NULL) {
-                       goto errexit;
+               for ( i = 0; i<n; i++ ) {
+                       sap[i] = ch_malloc(sizeof(struct sockaddr_in));
+                       if (*sap == NULL) {
+                               goto errexit;
+                       }
+                       (void)memset( (void *)sap[i], '\0', sizeof(struct sockaddr_in) );
+                       sap[i]->sa_family = AF_INET;
+                       ((struct sockaddr_in *)sap[i])->sin_port = htons(port);
+                       if (he) {
+                               AC_MEMCPY( &((struct sockaddr_in *)sap[i])->sin_addr, he->h_addr_list[i], sizeof(struct in_addr) );
+                       } else {
+                               AC_MEMCPY( &((struct sockaddr_in *)sap[i])->sin_addr, &in, sizeof(struct in_addr) );
+                       }
                }
-               sap[1] = NULL;
-
-               (void)memset( (void *)*sap, '\0', sizeof(struct sockaddr_in) );
-               (*sap)->sa_family = AF_INET;
-               ((struct sockaddr_in *)*sap)->sin_port = htons(port);
-               ((struct sockaddr_in *)*sap)->sin_addr = in;
+               sap[i] = NULL;
 #endif
        }
 
@@ -642,10 +544,13 @@ errexit:
        return -1;
 }
 
-static Listener * slap_open_listener(
-       const char* url )
+static int slap_open_listener(
+       const char* url,
+       int *listeners,
+       int *cur
+       )
 {
-       int     tmp, rc;
+       int     num, tmp, rc;
        Listener l;
        Listener *li;
        LDAPURLDesc *lud;
@@ -670,7 +575,7 @@ static Listener * slap_open_listener(
                        "daemon: listen URL \"%s\" parse error=%d\n",
                        url, rc, 0 );
 #endif
-               return NULL;
+               return rc;
        }
 
 #ifndef HAVE_TLS
@@ -685,7 +590,7 @@ static Listener * slap_open_listener(
                        url, 0, 0 );
 #endif
                ldap_free_urldesc( lud );
-               return NULL;
+               return -1;
        }
 
        if(! lud->lud_port ) {
@@ -725,7 +630,7 @@ static Listener * slap_open_listener(
                        url, 0, 0);
 #endif
                ldap_free_urldesc( lud );
-               return NULL;
+               return -1;
 #endif
        } else {
 #ifdef LDAP_CONNECTIONLESS
@@ -742,7 +647,16 @@ static Listener * slap_open_listener(
 
        ldap_free_urldesc( lud );
        if ( err ) {
-               return NULL;
+               return -1;
+       }
+
+       /* If we got more than one address returned, we need to make space
+        * for it in the slap_listeners array.
+        */
+       for ( num=0; sal[num]; num++ );
+       if ( num > 1 ) {
+               *listeners += num-1;
+               slap_listeners = ch_realloc( slap_listeners, (*listeners + 1) * sizeof(Listener *) );
        }
 
        psal = sal;
@@ -837,9 +751,8 @@ static Listener * slap_open_listener(
 #endif
                }
 
-               if (!bind(l.sl_sd, *sal, addrlen))
-                       break;
-               err = sock_errno();
+               if (bind(l.sl_sd, *sal, addrlen)) {
+                       err = sock_errno();
 #ifdef NEW_LOGGING
                LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
                           "slap_open_listener: bind(%ld) failed errno=%d (%s)\n",
@@ -848,21 +761,10 @@ static Listener * slap_open_listener(
                Debug( LDAP_DEBUG_ANY, "daemon: bind(%ld) failed errno=%d (%s)\n",
                       (long) l.sl_sd, err, sock_errstr(err) );
 #endif
-               tcp_close( l.sl_sd );
-               sal++;
-       } /* while ( *sal != NULL ) */
-
-       if ( *sal == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                          "slap_open_listener: bind(%ld) failed.\n", (long)l.sl_sd ));
-#else
-               Debug( LDAP_DEBUG_ANY, "daemon: bind(%ld) failed\n",
-                       (long) l.sl_sd, 0, 0 );
-#endif
-               slap_free_listener_addresses(psal);
-               return NULL;
-       }
+                       tcp_close( l.sl_sd );
+                       sal++;
+                       continue;
+               }
 
        switch ( (*sal)->sa_family ) {
 #ifdef LDAP_PF_LOCAL
@@ -880,7 +782,7 @@ static Listener * slap_open_listener(
 #endif
                        tcp_close( l.sl_sd );
                        slap_free_listener_addresses(psal);
-                       return NULL;
+                       return -1;
                }
                l.sl_name = ch_malloc( strlen(addr) + sizeof("PATH=") );
                sprintf( l.sl_name, "PATH=%s", addr );
@@ -926,20 +828,27 @@ static Listener * slap_open_listener(
                break;
        }
 
-       slap_free_listener_addresses(psal);
-
+       AC_MEMCPY(&l.sl_sa, *sal, addrlen);
        l.sl_url = ch_strdup( url );
        li = ch_malloc( sizeof( Listener ) );
        *li = l;
+       slap_listeners[*cur] = li;
+       (*cur)++;
+       sal++;
+
+       } /* while ( *sal != NULL ) */
+
+       slap_free_listener_addresses(psal);
+
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "connection", LDAP_LEVEL_RESULTS,
-                  "slap_open_listener: daemon initialzed %s\n", l.sl_url ));
+                  "slap_open_listener: daemon initialized %s\n", l.sl_url ));
 #else
        Debug( LDAP_DEBUG_TRACE, "daemon: initialized %s\n",
                l.sl_url, 0, 0 );
 #endif
-       return li;
+       return 0;
 }
 
 static int sockinit(void);
@@ -947,7 +856,7 @@ static int sockdestroy(void);
 
 int slapd_daemon_init( const char *urls )
 {
-       int i, rc;
+       int i, j, n, rc;
        char **u;
 
 #ifdef NEW_LOGGING
@@ -1043,15 +952,13 @@ int slapd_daemon_init( const char *urls )
 #endif
        slap_listeners = ch_malloc( (i+1)*sizeof(Listener *) );
 
-       for(i = 0; u[i] != NULL; i++ ) {
-               slap_listeners[i] = slap_open_listener( u[i] );
-
-               if( slap_listeners[i] == NULL ) {
+       for(n = 0, j = 0; u[n]; n++ ) {
+               if ( slap_open_listener( u[n], &i, &j ) ) {
                        charray_free( u );
                        return -1;
                }
        }
-       slap_listeners[i] = NULL;
+       slap_listeners[j] = NULL;
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
@@ -1089,6 +996,34 @@ slapd_daemon_destroy(void)
 }
 
 
+static void
+close_listeners(
+       int remove
+)
+{
+       int l;
+
+       for ( l = 0; slap_listeners[l] != NULL; l++ ) {
+               if ( remove )
+                       slapd_remove( slap_listeners[l]->sl_sd, 0 );
+               if ( slap_listeners[l]->sl_sd != AC_SOCKET_INVALID ) {
+#ifdef LDAP_PF_LOCAL
+                       if ( slap_listeners[l]->sl_sa.sa_addr.sa_family == AF_LOCAL ) {
+                               unlink( slap_listeners[l]->sl_sa.sa_un_addr.sun_path );
+                       }
+#endif /* LDAP_PF_LOCAL */
+                       slapd_close( slap_listeners[l]->sl_sd );
+               }
+               if ( slap_listeners[l]->sl_url )
+                       free ( slap_listeners[l]->sl_url );
+               if ( slap_listeners[l]->sl_name )
+                       free ( slap_listeners[l]->sl_name );
+               free ( slap_listeners[l] );
+               slap_listeners[l] = NULL;
+       }
+}
+
+
 static void *
 slapd_daemon_task(
        void *ptr
@@ -1175,6 +1110,26 @@ slapd_daemon_task(
                        }
                }
 
+#ifdef SIGHUP
+               if( slapd_gentle_shutdown ) {
+                       ber_socket_t active;
+
+                       if( slapd_gentle_shutdown > 0 ) {
+                               Debug( LDAP_DEBUG_ANY, "slapd gentle shutdown\n", 0, 0, 0 );
+                               close_listeners( 1 );
+                               slapd_gentle_shutdown = -1;
+                       }
+
+                       ldap_pvt_thread_mutex_lock( &slap_daemon.sd_mutex );
+                       active = slap_daemon.sd_nactives;
+                       ldap_pvt_thread_mutex_unlock( &slap_daemon.sd_mutex );
+                       if( active == 0 ) {
+                               slapd_shutdown = -1;
+                               break;
+                       }
+               }
+#endif
+
                FD_ZERO( &writefds );
                FD_ZERO( &readfds );
 
@@ -1270,7 +1225,7 @@ slapd_daemon_task(
                                                "daemon: select failed (%d): %s\n",
                                                err, sock_errstr(err), 0 );
 #endif
-                                       slapd_shutdown = -1;
+                                       slapd_shutdown = 2;
                                }
                        }
                        continue;
@@ -1529,19 +1484,21 @@ slapd_daemon_task(
 #endif
                        ) {
 #ifdef SLAPD_RLOOKUPS
+                               if ( use_reverse_lookup ) {
 #  ifdef LDAP_PF_INET6
-                               if ( from.sa_addr.sa_family == AF_INET6 )
-                                       hp = gethostbyaddr(
-                                               (char *)&(from.sa_in6_addr.sin6_addr),
-                                               sizeof(from.sa_in6_addr.sin6_addr),
-                                               AF_INET6 );
-                               else
+                                       if ( from.sa_addr.sa_family == AF_INET6 )
+                                               hp = gethostbyaddr(
+                                                       (char *)&(from.sa_in6_addr.sin6_addr),
+                                                       sizeof(from.sa_in6_addr.sin6_addr),
+                                                       AF_INET6 );
+                                       else
 #  endif /* LDAP_PF_INET6 */
-                               hp = gethostbyaddr(
-                                       (char *) &(from.sa_in_addr.sin_addr),
-                                       sizeof(from.sa_in_addr.sin_addr),
-                                       AF_INET );
-                               dnsname = hp ? ldap_pvt_str2lower( hp->h_name ) : NULL;
+                                       hp = gethostbyaddr(
+                                               (char *) &(from.sa_in_addr.sin_addr),
+                                               sizeof(from.sa_in_addr.sin_addr),
+                                               AF_INET );
+                                       dnsname = hp ? ldap_pvt_str2lower( hp->h_name ) : NULL;
+                               }
 #else
                                dnsname = NULL;
 #endif /* SLAPD_RLOOKUPS */
@@ -1782,7 +1739,7 @@ slapd_daemon_task(
                ldap_pvt_thread_yield();
        }
 
-       if( slapd_shutdown > 0 ) {
+       if( slapd_shutdown == 1 ) {
 #ifdef NEW_LOGGING
                LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
                           "slapd_daemon_task: shutdown requested and initiated.\n"));
@@ -1792,10 +1749,8 @@ slapd_daemon_task(
                        0, 0, 0 );
 #endif
 
-       } else if ( slapd_shutdown < 0 ) {
+       } else if ( slapd_shutdown == 2 ) {
 #ifdef HAVE_NT_SERVICE_MANAGER
-               if (slapd_shutdown == -1)
-               {
 #ifdef NEW_LOGGING
                        LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
                                   "slapd_daemon_task: shutdown initiated by Service Manager.\n"));
@@ -1804,10 +1759,7 @@ slapd_daemon_task(
                               "daemon: shutdown initiated by Service Manager.\n",
                               0, 0, 0);
 #endif
-               }
-               else
-#endif
-               {
+#else /* !HAVE_NT_SERVICE_MANAGER */
 #ifdef NEW_LOGGING
                        LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
                                   "slapd_daemon_task: abnormal condition, shutdown initiated.\n" ));
@@ -1816,7 +1768,7 @@ slapd_daemon_task(
                               "daemon: abnormal condition, shutdown initiated.\n",
                               0, 0, 0 );
 #endif
-               }
+#endif /* !HAVE_NT_SERVICE_MANAGER */
        } else {
 #ifdef NEW_LOGGING
                LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
@@ -1828,21 +1780,8 @@ slapd_daemon_task(
 #endif
        }
 
-       for ( l = 0; slap_listeners[l] != NULL; l++ ) {
-               if ( slap_listeners[l]->sl_sd != AC_SOCKET_INVALID ) {
-#ifdef LDAP_PF_LOCAL
-                       if ( slap_listeners[l]->sl_sa.sa_addr.sa_family == AF_LOCAL ) {
-                               unlink( slap_listeners[l]->sl_sa.sa_un_addr.sun_path );
-                       }
-#endif /* LDAP_PF_LOCAL */
-                       slapd_close( slap_listeners[l]->sl_sd );
-               }
-               if ( slap_listeners[l]->sl_url )
-                       free ( slap_listeners[l]->sl_url );
-               if ( slap_listeners[l]->sl_name )
-                       free ( slap_listeners[l]->sl_name );
-               free ( slap_listeners[l] );
-       }
+       if( slapd_gentle_shutdown >= 0 )
+               close_listeners ( 0 );
        free ( slap_listeners );
        slap_listeners = NULL;
 
@@ -1975,7 +1914,12 @@ slap_sig_shutdown( int sig )
 #endif
        else
 #endif
-       slapd_shutdown = sig;
+#ifdef SIGHUP
+       if (sig == SIGHUP && global_gentlehup && slapd_gentle_shutdown == 0)
+               slapd_gentle_shutdown = 1;
+       else
+#endif
+       slapd_shutdown = 1;
 
        WAKE_LISTENER(1);