]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/daemon.c
Partial revert of f30269f5d2e4bb5ee7486fe6542078d1b59dba6d
[openldap] / servers / slapd / daemon.c
index 05cc6b69f4048f5c272684c9399d6912ed44e120..2a75f91753ac3fc152e2b735a0935ba63cb0e8ce 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2011 The OpenLDAP Foundation.
+ * Copyright 1998-2012 The OpenLDAP Foundation.
  * Portions Copyright 2007 by Howard Chu, Symas Corporation.
  * All rights reserved.
  *
@@ -83,6 +83,7 @@ int slapd_tcp_wmem;
 #endif /* LDAP_TCP_BUFFER */
 
 Listener **slap_listeners = NULL;
+static volatile sig_atomic_t listening = 1; /* 0 when slap_listeners closed */
 
 #ifndef SLAPD_LISTEN_BACKLOG
 #define SLAPD_LISTEN_BACKLOG 1024
@@ -556,8 +557,8 @@ static slap_daemon_st slap_daemon[MAX_DAEMON_THREADS];
        memset( slap_daemon[t].sd_flags, 0, dtblsize ); \
        slapd_ws_sockets[t*2] = wake_sds[t][0]; \
        slapd_ws_sockets[t*2+1] = wake_sds[t][1]; \
-       wake_sds[0] = t*2; \
-       wake_sds[1] = t*2+1; \
+       wake_sds[t][0] = t*2; \
+       wake_sds[t][1] = t*2+1; \
        slap_daemon[t].sd_nfds = t*2 + 2; \
        } while ( 0 )
 
@@ -907,7 +908,7 @@ slapd_remove(
         * the select() loop. Now that we're removing a session from our
         * control, we can try to resume a dropped listener to use.
         */
-       if ( emfile ) {
+       if ( emfile && listening ) {
                int i;
                for ( i = 0; slap_listeners[i] != NULL; i++ ) {
                        Listener *lr = slap_listeners[i];
@@ -1523,43 +1524,44 @@ slap_open_listener(
                switch ( (*sal)->sa_family ) {
 #ifdef LDAP_PF_LOCAL
                case AF_LOCAL: {
-                       char *addr = ((struct sockaddr_un *)*sal)->sun_path;
-                       l.sl_name.bv_len = strlen(addr) + sizeof("PATH=") - 1;
+                       char *path = ((struct sockaddr_un *)*sal)->sun_path;
+                       l.sl_name.bv_len = strlen(path) + STRLENOF("PATH=");
                        l.sl_name.bv_val = ber_memalloc( l.sl_name.bv_len + 1 );
                        snprintf( l.sl_name.bv_val, l.sl_name.bv_len + 1, 
-                               "PATH=%s", addr );
+                               "PATH=%s", path );
                } break;
 #endif /* LDAP_PF_LOCAL */
 
                case AF_INET: {
-                       char *s;
-#if defined( HAVE_GETADDRINFO ) && defined( HAVE_INET_NTOP )
                        char addr[INET_ADDRSTRLEN];
-                       inet_ntop( AF_INET, &((struct sockaddr_in *)*sal)->sin_addr,
+                       const char *s;
+#if defined( HAVE_GETADDRINFO ) && defined( HAVE_INET_NTOP )
+                       s = inet_ntop( AF_INET, &((struct sockaddr_in *)*sal)->sin_addr,
                                addr, sizeof(addr) );
-                       s = addr;
 #else /* ! HAVE_GETADDRINFO || ! HAVE_INET_NTOP */
                        s = inet_ntoa( ((struct sockaddr_in *) *sal)->sin_addr );
 #endif /* ! HAVE_GETADDRINFO || ! HAVE_INET_NTOP */
+                       if (!s) s = SLAP_STRING_UNKNOWN;
                        port = ntohs( ((struct sockaddr_in *)*sal) ->sin_port );
                        l.sl_name.bv_val =
                                ber_memalloc( sizeof("IP=255.255.255.255:65535") );
                        snprintf( l.sl_name.bv_val, sizeof("IP=255.255.255.255:65535"),
-                               "IP=%s:%d",
-                                s != NULL ? s : SLAP_STRING_UNKNOWN, port );
+                               "IP=%s:%d", s, port );
                        l.sl_name.bv_len = strlen( l.sl_name.bv_val );
                } break;
 
 #ifdef LDAP_PF_INET6
                case AF_INET6: {
                        char addr[INET6_ADDRSTRLEN];
-                       inet_ntop( AF_INET6, &((struct sockaddr_in6 *)*sal)->sin6_addr,
+                       const char *s;
+                       s = inet_ntop( AF_INET6, &((struct sockaddr_in6 *)*sal)->sin6_addr,
                                addr, sizeof addr);
+                       if (!s) s = SLAP_STRING_UNKNOWN;
                        port = ntohs( ((struct sockaddr_in6 *)*sal)->sin6_port );
-                       l.sl_name.bv_len = strlen(addr) + sizeof("IP=[]:65535");
+                       l.sl_name.bv_len = strlen(s) + sizeof("IP=[]:65535");
                        l.sl_name.bv_val = ber_memalloc( l.sl_name.bv_len );
                        snprintf( l.sl_name.bv_val, l.sl_name.bv_len, "IP=[%s]:%d", 
-                               addr, port );
+                               s, port );
                        l.sl_name.bv_len = strlen( l.sl_name.bv_val );
                } break;
 #endif /* LDAP_PF_INET6 */
@@ -1739,9 +1741,12 @@ close_listeners(
 {
        int l;
 
+       if ( !listening )
+               return;
+       listening = 0;
+
        for ( l = 0; slap_listeners[l] != NULL; l++ ) {
                Listener *lr = slap_listeners[l];
-               slap_listeners[l] = NULL;
 
                if ( lr->sl_sd != AC_SOCKET_INVALID ) {
                        int s = lr->sl_sd;
@@ -1756,7 +1761,18 @@ close_listeners(
 
                        slapd_close( s );
                }
+       }
+}
 
+static void
+destroy_listeners( void )
+{
+       Listener *lr, **ll = slap_listeners;
+
+       if ( ll == NULL )
+               return;
+
+       while ( (lr = *ll++) != NULL ) {
                if ( lr->sl_url.bv_val ) {
                        ber_memfree( lr->sl_url.bv_val );
                }
@@ -1767,6 +1783,9 @@ close_listeners(
 
                free( lr );
        }
+
+       free( slap_listeners );
+       slap_listeners = NULL;
 }
 
 static int
@@ -1785,7 +1804,9 @@ slap_listener(
 #endif /* SLAPD_RLOOKUPS */
 
        char    *dnsname = NULL;
-       char    *peeraddr = NULL;
+       const char *peeraddr = NULL;
+       /* we assume INET6_ADDRSTRLEN > INET_ADDRSTRLEN */
+       char addr[INET6_ADDRSTRLEN];
 #ifdef LDAP_PF_LOCAL
        char peername[MAXPATHLEN + sizeof("PATH=")];
 #ifdef LDAP_PF_LOCAL_SENDMSG
@@ -1953,30 +1974,39 @@ slap_listener(
 #  ifdef LDAP_PF_INET6
        case AF_INET6:
        if ( IN6_IS_ADDR_V4MAPPED(&from.sa_in6_addr.sin6_addr) ) {
+#if defined( HAVE_GETADDRINFO ) && defined( HAVE_INET_NTOP )
+               peeraddr = inet_ntop( AF_INET,
+                          ((struct in_addr *)&from.sa_in6_addr.sin6_addr.s6_addr[12]),
+                          addr, sizeof(addr) );
+#else /* ! HAVE_GETADDRINFO || ! HAVE_INET_NTOP */
                peeraddr = inet_ntoa( *((struct in_addr *)
                                        &from.sa_in6_addr.sin6_addr.s6_addr[12]) );
-               sprintf( peername, "IP=%s:%d",
-                        peeraddr != NULL ? peeraddr : SLAP_STRING_UNKNOWN,
+#endif /* ! HAVE_GETADDRINFO || ! HAVE_INET_NTOP */
+               if ( !peeraddr ) peeraddr = SLAP_STRING_UNKNOWN;
+               sprintf( peername, "IP=%s:%d", peeraddr,
                         (unsigned) ntohs( from.sa_in6_addr.sin6_port ) );
        } else {
-               char addr[INET6_ADDRSTRLEN];
-
-               peeraddr = (char *) inet_ntop( AF_INET6,
+               peeraddr = inet_ntop( AF_INET6,
                                      &from.sa_in6_addr.sin6_addr,
                                      addr, sizeof addr );
-               sprintf( peername, "IP=[%s]:%d",
-                        peeraddr != NULL ? peeraddr : SLAP_STRING_UNKNOWN,
+               if ( !peeraddr ) peeraddr = SLAP_STRING_UNKNOWN;
+               sprintf( peername, "IP=[%s]:%d", peeraddr,
                         (unsigned) ntohs( from.sa_in6_addr.sin6_port ) );
        }
        break;
 #  endif /* LDAP_PF_INET6 */
 
-       case AF_INET:
+       case AF_INET: {
+#if defined( HAVE_GETADDRINFO ) && defined( HAVE_INET_NTOP )
+               peeraddr = inet_ntop( AF_INET, &from.sa_in_addr.sin_addr,
+                          addr, sizeof(addr) );
+#else /* ! HAVE_GETADDRINFO || ! HAVE_INET_NTOP */
                peeraddr = inet_ntoa( from.sa_in_addr.sin_addr );
-               sprintf( peername, "IP=%s:%d",
-                       peeraddr != NULL ? peeraddr : SLAP_STRING_UNKNOWN,
+#endif /* ! HAVE_GETADDRINFO || ! HAVE_INET_NTOP */
+               if ( !peeraddr ) peeraddr = SLAP_STRING_UNKNOWN;
+               sprintf( peername, "IP=%s:%d", peeraddr,
                        (unsigned) ntohs( from.sa_in_addr.sin_port ) );
-               break;
+               break;
 
        default:
                slapd_close(sfd);
@@ -2007,7 +2037,7 @@ slap_listener(
                        ldap_pvt_thread_mutex_lock( &sd_tcpd_mutex );
                        rc = hosts_ctl("slapd",
                                dnsname != NULL ? dnsname : SLAP_STRING_UNKNOWN,
-                               peeraddr != NULL ? peeraddr : SLAP_STRING_UNKNOWN,
+                               peeraddr,
                                SLAP_STRING_UNKNOWN );
                        ldap_pvt_thread_mutex_unlock( &sd_tcpd_mutex );
                        if ( !rc ) {
@@ -2016,8 +2046,7 @@ slap_listener(
                                        "fd=%ld DENIED from %s (%s)\n",
                                        (long) sfd,
                                        dnsname != NULL ? dnsname : SLAP_STRING_UNKNOWN,
-                                       peeraddr != NULL ? peeraddr : SLAP_STRING_UNKNOWN,
-                                       0, 0 );
+                                       peeraddr, 0, 0 );
                                slapd_close(sfd);
                                return 0;
                        }
@@ -2080,7 +2109,7 @@ slap_listener_activate(
        Debug( LDAP_DEBUG_TRACE, "slap_listener_activate(%d): %s\n",
                sl->sl_sd, sl->sl_busy ? "busy" : "", 0 );
 
-       sl->sl_busy++;
+       sl->sl_busy = 1;
 
        rc = ldap_pvt_thread_pool_submit( &connection_pool,
                slap_listener_thread, (void *) sl );
@@ -2100,7 +2129,7 @@ slapd_daemon_task(
        int l;
        time_t last_idle_check = 0;
        int ebadf = 0;
-       int tid = (int)ptr;
+       int tid = *(int *)ptr;
 
 #define SLAPD_IDLE_CHECK_LIMIT 4
 
@@ -2408,6 +2437,7 @@ loop:
 
                nwriters = slap_daemon[tid].sd_nwriters;
 
+               if ( listening )
                for ( l = 0; slap_listeners[l] != NULL; l++ ) {
                        Listener *lr = slap_listeners[l];
 
@@ -2566,6 +2596,7 @@ loop:
                 * true for Unix select and poll. We treat Windows select
                 * like this too, even though it's a kludge.
                 */
+               if ( listening )
                for ( l = 0; slap_listeners[l] != NULL; l++ ) {
                        int rc;
 
@@ -2753,25 +2784,22 @@ loop:
                                        }
                                }
                                /* If event is a read */
-                               if ( SLAP_EVENT_IS_READ( i ))
+                               if ( SLAP_EVENT_IS_READ( i )) {
                                        r = 1;
-                               if ( r || !w ) {
                                        Debug( LDAP_DEBUG_CONNS,
                                                "daemon: read active on %d\n",
                                                fd, 0, 0 );
 
-                                       if ( r ) {
-                                               SLAP_EVENT_CLR_READ( i );
-                                       } else {
+                                       SLAP_EVENT_CLR_READ( i );
+                                       connection_read_activate( fd );
+                               } else if ( !w ) {
 #ifdef HAVE_EPOLL
-                                               /* Don't keep reporting the hangup
-                                                */
-                                               if ( SLAP_SOCK_IS_ACTIVE( tid, fd )) {
-                                                       SLAP_EPOLL_SOCK_SET( tid, fd, EPOLLET );
-                                               }
-#endif
+                                       /* Don't keep reporting the hangup
+                                        */
+                                       if ( SLAP_SOCK_IS_ACTIVE( tid, fd )) {
+                                               SLAP_EPOLL_SOCK_SET( tid, fd, EPOLLET );
                                        }
-                                       connection_read_activate( fd );
+#endif
                                }
                        }
                }
@@ -2807,7 +2835,7 @@ loop:
                       0, 0, 0 );
        }
 
-       if ( slapd_gentle_shutdown != 2 ) close_listeners ( 0 );
+       close_listeners( 0 );
 
        if ( !slapd_gentle_shutdown ) {
                slapd_abrupt_shutdown = 1;
@@ -2822,9 +2850,6 @@ loop:
        }
        ldap_pvt_thread_pool_destroy( &connection_pool, 1 );
 
-       free( slap_listeners );
-       slap_listeners = NULL;
-
        return NULL;
 }
 
@@ -2891,7 +2916,7 @@ slapd_daemon( void )
        {
                /* listener as a separate THREAD */
                rc = ldap_pvt_thread_create( &listener_tid[i],
-                       0, slapd_daemon_task, (void *)i );
+                       0, slapd_daemon_task, (void *)&i );
 
                if ( rc != 0 ) {
                        Debug( LDAP_DEBUG_ANY,
@@ -2904,6 +2929,7 @@ slapd_daemon( void )
        for ( i=0; i<slapd_daemon_threads; i++ )
                ldap_pvt_thread_join( listener_tid[i], (void *)NULL );
 
+       destroy_listeners();
        ch_free( listener_tid );
 
        return 0;
@@ -3023,9 +3049,35 @@ slapd_add_internal( ber_socket_t s, int isactive )
 Listener **
 slapd_get_listeners( void )
 {
+       /* Could return array with no listeners if !listening, but current
+        * callers mostly look at the URLs.  E.g. syncrepl uses this to
+        * identify the server, which means it wants the startup arguments.
+        */
        return slap_listeners;
 }
 
+/* Reject all incoming requests */
+void
+slap_suspend_listeners( void )
+{
+       int i;
+       for (i=0; slap_listeners[i]; i++) {
+               slap_listeners[i]->sl_mute = 1;
+               listen( slap_listeners[i]->sl_sd, 0 );
+       }
+}
+
+/* Resume after a suspend */
+void
+slap_resume_listeners( void )
+{
+       int i;
+       for (i=0; slap_listeners[i]; i++) {
+               slap_listeners[i]->sl_mute = 0;
+               listen( slap_listeners[i]->sl_sd, SLAPD_LISTEN_BACKLOG );
+       }
+}
+
 void
 slap_wake_listener()
 {