]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/daemon.c
trace illegal condition in backsql_strfcat
[openldap] / servers / slapd / daemon.c
index d60f875f3a79dff6e019fc9f55f4b2ce05a8c534..f4022fc27c4be7f938cb624a53c4b80159e3138e 100644 (file)
@@ -33,7 +33,11 @@ int deny_severity = LOG_NOTICE;
 #define LDAPI_MOD_URLEXT               "x-mod"
 #endif /* LDAP_PF_LOCAL */
 
+#ifdef LDAP_PF_INET6
 int slap_inet4or6 = AF_UNSPEC;
+#else
+int slap_inet4or6 = AF_INET;
+#endif
 
 /* globals */
 time_t starttime;
@@ -91,7 +95,7 @@ static SLPHandle slapd_hslp = 0;
 void slapd_slp_init( const char* urls ) {
        int i;
 
-       slapd_srvurls = str2charray( urls, " " );
+       slapd_srvurls = ldap_str2charray( urls, " " );
 
        if( slapd_srvurls == NULL ) return;
 
@@ -103,7 +107,7 @@ void slapd_slp_init( const char* urls ) {
                                slapd_srvurls[i] = (char *) realloc( slapd_srvurls[i],
                                        strlen( host ) +
                                        sizeof( LDAP_SRVTYPE_PREFIX ) );
-                               strcpy( slap_strcopy(slapd_srvurls[i],
+                               strcpy( lutil_strcopy(slapd_srvurls[i],
                                        LDAP_SRVTYPE_PREFIX ), host );
 
                                ch_free( host );
@@ -115,7 +119,7 @@ void slapd_slp_init( const char* urls ) {
                                slapd_srvurls[i] = (char *) realloc( slapd_srvurls[i],
                                        strlen( host ) +
                                        sizeof( LDAPS_SRVTYPE_PREFIX ) );
-                               strcpy( slap_strcopy(slapd_srvurls[i],
+                               strcpy( lutil_strcopy(slapd_srvurls[i],
                                        LDAPS_SRVTYPE_PREFIX ), host );
 
                                ch_free( host );
@@ -130,7 +134,7 @@ void slapd_slp_init( const char* urls ) {
 void slapd_slp_deinit() {
        if( slapd_srvurls == NULL ) return;
 
-       charray_free( slapd_srvurls );
+       ldap_charray_free( slapd_srvurls );
        slapd_srvurls = NULL;
 
        /* close the SLP handle */
@@ -200,11 +204,10 @@ static void slapd_add(ber_socket_t s) {
        FD_SET( s, &slap_daemon.sd_readers );
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                  "slapd_add: added %ld%s%s\n",
-                  (long)s,
-                  FD_ISSET(s, &slap_daemon.sd_readers) ? "r" : "",
-                  FD_ISSET(s, &slap_daemon.sd_writers) ? "w" : "" ));
+       LDAP_LOG( CONNECTION, DETAIL1, 
+               "slapd_add: added %ld%s%s\n", (long)s,
+               FD_ISSET(s, &slap_daemon.sd_readers) ? "r" : "",
+               FD_ISSET(s, &slap_daemon.sd_writers) ? "w" : "" );
 #else
        Debug( LDAP_DEBUG_CONNS, "daemon: added %ld%s%s\n",
                (long) s,
@@ -223,11 +226,10 @@ void slapd_remove(ber_socket_t s, int wake) {
        slap_daemon.sd_nactives--;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                  "slapd_remove: removing %ld%s%s\n",
-                  (long) s,
-                  FD_ISSET(s, &slap_daemon.sd_readers) ? "r" : "",
-                  FD_ISSET(s, &slap_daemon.sd_writers) ? "w" : ""  ));
+       LDAP_LOG( CONNECTION, DETAIL1, 
+               "slapd_remove: removing %ld%s%s\n", (long) s,
+               FD_ISSET(s, &slap_daemon.sd_readers) ? "r" : "",
+               FD_ISSET(s, &slap_daemon.sd_writers) ? "w" : ""  );
 #else
        Debug( LDAP_DEBUG_CONNS, "daemon: removing %ld%s%s\n",
                (long) s,
@@ -286,8 +288,7 @@ void slapd_set_read(ber_socket_t s, int wake) {
 
 static void slapd_close(ber_socket_t s) {
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                  "slapd_close: closing %ld\n", (long)s ));
+       LDAP_LOG( CONNECTION, DETAIL1, "slapd_close: closing %ld\n", (long)s, 0, 0);
 #else
        Debug( LDAP_DEBUG_CONNS, "daemon: closing %ld\n",
                (long) s, 0, 0 );
@@ -391,9 +392,9 @@ static int slap_get_listener_addresses(
                if ( strlen(host) >
                     (sizeof(((struct sockaddr_un *)*sap)->sun_path) - 1) ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                                  "slap_get_listener_addresses: domain socket path (%s) too long in URL\n",
-                                  host ));
+                       LDAP_LOG( CONNECTION, INFO, 
+                               "slap_get_listener_addresses: domain socket path (%s) "
+                               "too long in URL\n", host, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
                               "daemon: domain socket path (%s) too long in URL",
@@ -421,9 +422,9 @@ static int slap_get_listener_addresses(
 
                if ( (err = getaddrinfo(host, serv, &hints, &res)) ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
+                       LDAP_LOG( CONNECTION, INFO, 
                                   "slap_get_listener_addresses: getaddrinfo failed: %s\n",
-                                  AC_GAI_STRERROR(err) ));
+                                  AC_GAI_STRERROR(err), 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY, "daemon: getaddrinfo failed: %s\n",
                                AC_GAI_STRERROR(err), 0, 0);
@@ -446,9 +447,9 @@ static int slap_get_listener_addresses(
                for ( sai=res; sai; sai=sai->ai_next ) {
                        if( sai->ai_addr == NULL ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
+                               LDAP_LOG( CONNECTION, INFO,
                                        "slap_get_listener_addresses: "
-                                       "getaddrinfo ai_addr is NULL?\n" ));
+                                       "getaddrinfo ai_addr is NULL?\n", 0, 0, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY, "slap_get_listener_addresses: "
                                        "getaddrinfo ai_addr is NULL?\n", 0, 0, 0 );
@@ -503,9 +504,8 @@ static int slap_get_listener_addresses(
                        he = gethostbyname( host );
                        if( he == NULL ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                                          "slap_get_listener_addresses: invalid host %s\n",
-                                          host ));
+                               LDAP_LOG( CONNECTION, INFO, 
+                                       "slap_get_listener_addresses: invalid host %s\n", host, 0, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                       "daemon: invalid host %s", host, 0, 0);
@@ -560,6 +560,7 @@ static int slap_open_listener(
        int err, addrlen = 0;
        struct sockaddr **sal, **psal;
        int socktype = SOCK_STREAM;     /* default to COTS */
+
 #ifdef LDAP_PF_LOCAL
        mode_t  perms = S_IRWXU;
        int     crit = 1;
@@ -569,9 +570,9 @@ static int slap_open_listener(
 
        if( rc != LDAP_URL_SUCCESS ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                          "slap_open_listener: listen URL \"%s\" parse error %d\n",
-                          url, rc ));
+               LDAP_LOG( CONNECTION, ERR, 
+                       "slap_open_listener: listen URL \"%s\" parse error %d\n",
+                       url, rc , 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
                        "daemon: listen URL \"%s\" parse error=%d\n",
@@ -583,9 +584,8 @@ static int slap_open_listener(
 #ifndef HAVE_TLS
        if( ldap_pvt_url_scheme2tls( lud->lud_scheme ) ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                          "slap_open_listener: TLS is not supported (%s)\n",
-                          url ));
+               LDAP_LOG( CONNECTION, INFO, 
+                          "slap_open_listener: TLS is not supported (%s)\n", url, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
                        "daemon: TLS not supported (%s)\n",
@@ -624,9 +624,8 @@ static int slap_open_listener(
 #else
 
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                          "slap_open_listener: URL scheme is not supported: %s\n",
-                          url ));
+               LDAP_LOG( CONNECTION, INFO, 
+                       "slap_open_listener: URL scheme is not supported: %s\n", url, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "daemon: URL scheme not supported: %s",
                        url, 0, 0);
@@ -684,9 +683,9 @@ static int slap_open_listener(
                if ( l.sl_sd == AC_SOCKET_INVALID ) {
                        int err = sock_errno();
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                                  "slap_open_listener: socket() failed errno=%d (%s)\n",
-                                  err, sock_errstr(err) ));
+                       LDAP_LOG( CONNECTION, ERR, 
+                               "slap_open_listener: socket() failed errno=%d (%s)\n",
+                               err, sock_errstr(err), 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
                                "daemon: socket() failed errno=%d (%s)\n", err,
@@ -698,9 +697,9 @@ static int slap_open_listener(
 #ifndef HAVE_WINSOCK
                if ( l.sl_sd >= dtblsize ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                                  "slap_open_listener: listener descriptor %ld is too great %ld\n",
-                                  (long)l.sl_sd, (long)dtblsize ));
+                       LDAP_LOG( CONNECTION, ERR, 
+                               "slap_open_listener: listener descriptor %ld is too "
+                               "great %ld\n", (long)l.sl_sd, (long)dtblsize, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
                               "daemon: listener descriptor %ld is too great %ld\n",
@@ -725,9 +724,10 @@ static int slap_open_listener(
                        if ( rc == AC_SOCKET_ERROR ) {
                                int err = sock_errno();
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                                          "slap_open_listener: setsockopt( %ld, SO_REUSEADDR ) failed errno %d (%s)\n",
-                                          (long)l.sl_sd, err, sock_errstr(err) ));
+                               LDAP_LOG( CONNECTION, INFO, 
+                                       "slap_open_listener: setsockopt( %ld, SO_REUSEADDR ) "
+                                       "failed errno %d (%s)\n", (long)l.sl_sd, err, 
+                                       sock_errstr(err) );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                       "slapd(%ld): setsockopt(SO_REUSEADDR) failed errno=%d (%s)\n",
@@ -743,6 +743,24 @@ static int slap_open_listener(
                        break;
 #ifdef LDAP_PF_INET6
                case AF_INET6:
+#ifdef IPV6_V6ONLY
+                       /* Try to use IPv6 sockets for IPv6 only */
+                       tmp = 1;
+                       rc = setsockopt( l.sl_sd, IPPROTO_IPV6, IPV6_V6ONLY,
+                                        (char *) &tmp, sizeof(tmp) );
+                       if ( rc == AC_SOCKET_ERROR ) {
+                               int err = sock_errno();
+#ifdef NEW_LOGGING
+                               LDAP_LOG( CONNECTION, INFO,
+                                          "slap_open_listener: setsockopt( %ld, IPV6_V6ONLY ) failed errno %d (%s)\n",
+                                          (long)l.sl_sd, err, sock_errstr(err) );
+#else
+                               Debug( LDAP_DEBUG_ANY,
+                                      "slapd(%ld): setsockopt(IPV6_V6ONLY) failed errno=%d (%s)\n",
+                                      (long) l.sl_sd, err, sock_errstr(err) );
+#endif
+                       }
+#endif
                        addrlen = sizeof(struct sockaddr_in6);
                        break;
 #endif
@@ -756,9 +774,9 @@ static int slap_open_listener(
                if (bind(l.sl_sd, *sal, addrlen)) {
                        err = sock_errno();
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                          "slap_open_listener: bind(%ld) failed errno=%d (%s)\n",
-                          (long)l.sl_sd, err, sock_errstr(err) ));
+               LDAP_LOG( CONNECTION, INFO, 
+                       "slap_open_listener: bind(%ld) failed errno=%d (%s)\n",
+                       (long)l.sl_sd, err, sock_errstr(err) );
 #else
                Debug( LDAP_DEBUG_ANY, "daemon: bind(%ld) failed errno=%d (%s)\n",
                       (long) l.sl_sd, err, sock_errstr(err) );
@@ -775,9 +793,9 @@ static int slap_open_listener(
                if ( chmod( addr, perms ) < 0 && crit ) {
                        int err = sock_errno();
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                                  "slap_open_listener: fchmod(%ld) failed errno=%d (%s)\n",
-                                  (long)l.sl_sd, err, sock_errstr(err) ));
+                       LDAP_LOG( CONNECTION, INFO, 
+                               "slap_open_listener: fchmod(%ld) failed errno=%d (%s)\n",
+                               (long)l.sl_sd, err, sock_errstr(err) );
 #else
                        Debug( LDAP_DEBUG_ANY, "daemon: fchmod(%ld) failed errno=%d (%s)",
                               (long) l.sl_sd, err, sock_errstr(err) );
@@ -820,9 +838,9 @@ static int slap_open_listener(
 
        default:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                          "slap_open_listener: unsupported address family (%d)\n",
-                          (int)(*sal)->sa_family ));
+               LDAP_LOG( CONNECTION, INFO, 
+                       "slap_open_listener: unsupported address family (%d)\n",
+                       (int)(*sal)->sa_family, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "daemon: unsupported address family (%d)\n",
                        (int) (*sal)->sa_family, 0, 0 );
@@ -844,8 +862,8 @@ static int slap_open_listener(
 
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_RESULTS,
-                  "slap_open_listener: daemon initialized %s\n", l.sl_url ));
+       LDAP_LOG( CONNECTION, RESULTS, 
+                       "slap_open_listener: daemon initialzed %s\n", l.sl_url, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "daemon: initialized %s\n",
                l.sl_url, 0, 0 );
@@ -862,9 +880,8 @@ int slapd_daemon_init( const char *urls )
        char **u;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_ARGS,
-                  "slapd_daemon_init: %s\n",
-                  urls ? urls : "<null>" ));
+       LDAP_LOG( CONNECTION, ARGS, 
+               "slapd_daemon_init: %s\n", urls ? urls : "<null>", 0, 0 );
 #else
        Debug( LDAP_DEBUG_ARGS, "daemon_init: %s\n",
                urls ? urls : "<null>", 0, 0 );
@@ -894,8 +911,8 @@ int slapd_daemon_init( const char *urls )
         */
        if( (rc = lutil_pair( wake_sds )) < 0 ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                          "slap_daemon_init: lutil_pair() failed rc=%d\n", rc ));
+               LDAP_LOG( CONNECTION, ERR, 
+                       "slap_daemon_init: lutil_pair() failed rc=%d\n", rc, 0, 0);
 #else
                Debug( LDAP_DEBUG_ANY,
                        "daemon: lutil_pair() failed rc=%d\n", rc, 0, 0 );
@@ -910,12 +927,12 @@ int slapd_daemon_init( const char *urls )
                urls = "ldap:///";
        }
 
-       u = str2charray( urls, " " );
+       u = ldap_str2charray( urls, " " );
 
        if( u == NULL || u[0] == NULL ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                          "slap_daemon_init: no urls (%s) provided.\n", urls ));
+               LDAP_LOG( CONNECTION, ERR, 
+                       "slap_daemon_init: no urls (%s) provided.\n", urls, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "daemon_init: no urls (%s) provided.\n",
                        urls, 0, 0 );
@@ -925,8 +942,8 @@ int slapd_daemon_init( const char *urls )
 
        for( i=0; u[i] != NULL; i++ ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                          "slap_daemon_init: listen on %s\n.", u[i] ));
+               LDAP_LOG( CONNECTION, DETAIL1, 
+                       "slap_daemon_init: listen on %s\n.", u[i], 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "daemon_init: listen on %s\n",
                        u[i], 0, 0 );
@@ -935,19 +952,19 @@ int slapd_daemon_init( const char *urls )
 
        if( i == 0 ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                          "slap_daemon_init: no listeners to open (%s)\n", urls ));
+               LDAP_LOG( CONNECTION, INFO, 
+                        "slap_daemon_init: no listeners to open (%s)\n", urls, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "daemon_init: no listeners to open (%s)\n",
                        urls, 0, 0 );
 #endif
-               charray_free( u );
+               ldap_charray_free( u );
                return -1;
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                  "slap_daemon_init: %d listeners to open...\n", i ));
+       LDAP_LOG( CONNECTION, INFO, 
+               "slap_daemon_init: %d listeners to open...\n", i, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "daemon_init: %d listeners to open...\n",
                i, 0, 0 );
@@ -956,15 +973,15 @@ int slapd_daemon_init( const char *urls )
 
        for(n = 0, j = 0; u[n]; n++ ) {
                if ( slap_open_listener( u[n], &i, &j ) ) {
-                       charray_free( u );
+                       ldap_charray_free( u );
                        return -1;
                }
        }
        slap_listeners[j] = NULL;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                  "slap_daemon_init: %d listeners opened\n", i ));
+       LDAP_LOG( CONNECTION, DETAIL1, 
+               "slap_daemon_init: %d listeners opened\n", i, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "daemon_init: %d listeners opened\n",
                i, 0, 0 );
@@ -975,7 +992,7 @@ int slapd_daemon_init( const char *urls )
        slapd_slp_reg();
 #endif
 
-       charray_free( u );
+       ldap_charray_free( u );
        ldap_pvt_thread_mutex_init( &slap_daemon.sd_mutex );
        return !i;
 }
@@ -1078,8 +1095,8 @@ slapd_daemon_task(
                                        if ( i < l ) {
                                                /* We are already listening to in6addr_any */
 #ifdef NEW_LOGGING
-                                               LDAP_LOG(( "connection", LDAP_LEVEL_WARNING,
-                                                          "slapd_daemon_task: Attempt to listen to 0.0.0.0 failed, already listening on ::, assuming IPv4 included\n" ));
+                                               LDAP_LOG(CONNECTION, WARNING,
+                                                          "slapd_daemon_task: Attempt to listen to 0.0.0.0 failed, already listening on ::, assuming IPv4 included\n", 0, 0, 0 );
 #else
                                                Debug( LDAP_DEBUG_CONNS,
                                                       "daemon: Attempt to listen to 0.0.0.0 failed, already listening on ::, assuming IPv4 included\n",
@@ -1093,9 +1110,9 @@ slapd_daemon_task(
                        }
 #endif                         
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                                  "slapd_daemon_task: listen( %s, 5 ) failed errno=%d (%s)\n",
-                                  slap_listeners[l]->sl_url, err, sock_errstr(err) ));
+                       LDAP_LOG( CONNECTION, ERR, 
+                               "slapd_daemon_task: listen( %s, 5 ) failed errno=%d (%s)\n",
+                               slap_listeners[l]->sl_url, err, sock_errstr(err) );
 #else
                        Debug( LDAP_DEBUG_ANY,
                                "daemon: listen(%s, 5) failed errno=%d (%s)\n",
@@ -1222,9 +1239,10 @@ slapd_daemon_task(
                                continue;
 
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                                  "slapd_daemon_task: select: listen=%d active_threads=%d tvp=%s\n",
-                                  slap_listeners[l]->sl_sd, at, tvp == NULL ? "NULL" : "zero" ));
+                       LDAP_LOG( CONNECTION, DETAIL1, 
+                               "slapd_daemon_task: select: listen=%d "
+                               "active_threads=%d tvp=%s\n",
+                               slap_listeners[l]->sl_sd, at, tvp == NULL ? "NULL" : "zero" );
 #else
                        Debug( LDAP_DEBUG_CONNS,
                                "daemon: select: listen=%d active_threads=%d tvp=%s\n",
@@ -1257,9 +1275,9 @@ slapd_daemon_task(
 
                                if( err != EINTR ) {
 #ifdef NEW_LOGGING
-                                       LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                                                  "slapd_daemon_task: select failed (%d): %s\n",
-                                                  err, sock_errstr(err) ));
+                                       LDAP_LOG( CONNECTION, INFO, 
+                                               "slapd_daemon_task: select failed (%d): %s\n",
+                                               err, sock_errstr(err), 0 );
 #else
                                        Debug( LDAP_DEBUG_CONNS,
                                                "daemon: select failed (%d): %s\n",
@@ -1273,8 +1291,8 @@ slapd_daemon_task(
                case 0:         /* timeout - let threads run */
                        ebadf = 0;
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                  "slapd_daemon_task: select timeout - yielding\n" ));
+                       LDAP_LOG( CONNECTION, DETAIL2,
+                                  "slapd_daemon_task: select timeout - yielding\n", 0, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_CONNS, "daemon: select timeout - yielding\n",
                            0, 0, 0 );
@@ -1287,8 +1305,8 @@ slapd_daemon_task(
 
                        ebadf = 0;
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                  "slapd_daemon_task: activity on %d descriptors\n", ns ));
+                       LDAP_LOG( CONNECTION, DETAIL2, 
+                                  "slapd_daemon_task: activity on %d descriptors\n", ns, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_CONNS, "daemon: activity on %d descriptors\n",
                                ns, 0, 0 );
@@ -1371,9 +1389,10 @@ slapd_daemon_task(
 
                                if( emfile < 3 ) {
 #ifdef NEW_LOGGING
-                                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
+                                       LDAP_LOG( CONNECTION, ERR, 
                                                "slapd_daemon_task: accept(%ld) failed errno=%d (%s)\n",
-                                               (long)slap_listeners[l]->sl_sd, err, sock_errstr(err) ));
+                                               (long)slap_listeners[l]->sl_sd, 
+                                               err, sock_errstr(err) );
 #else
                                        Debug( LDAP_DEBUG_ANY,
                                            "daemon: accept(%ld) failed errno=%d (%s)\n",
@@ -1398,9 +1417,9 @@ slapd_daemon_task(
                        /* make sure descriptor number isn't too great */
                        if ( s >= dtblsize ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
+                               LDAP_LOG( CONNECTION, ERR, 
                                   "slapd_daemon_task: %ld beyond descriptor table size %ld\n",
-                                  (long)s, (long)dtblsize ));
+                                  (long)s, (long)dtblsize, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "daemon: %ld beyond descriptor table size %ld\n",
@@ -1440,9 +1459,10 @@ slapd_daemon_task(
                                if ( rc == AC_SOCKET_ERROR ) {
                                        int err = sock_errno();
 #ifdef NEW_LOGGING
-                                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                                                  "slapd_daemon_task: setsockopt( %ld, SO_KEEPALIVE) failed errno=%d (%s)\n",
-                                                  (long)s, err, sock_errstr(err) ));
+                                       LDAP_LOG( CONNECTION, ERR, 
+                                               "slapd_daemon_task: setsockopt( %ld, SO_KEEPALIVE)"
+                                          " failed errno=%d (%s)\n",
+                                               (long)s, err, sock_errstr(err) );
 #else
                                        Debug( LDAP_DEBUG_ANY,
                                                "slapd(%ld): setsockopt(SO_KEEPALIVE) failed "
@@ -1458,9 +1478,10 @@ slapd_daemon_task(
                                if ( rc == AC_SOCKET_ERROR ) {
                                        int err = sock_errno();
 #ifdef NEW_LOGGING
-                                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                                                  "slapd_daemon_task: setsockopt( %ld, TCP_NODELAY) failed errno=%d (%s)\n",
-                                                  (long)s, err, sock_errstr(err) ));
+                                       LDAP_LOG( CONNECTION, ERR, 
+                                               "slapd_daemon_task: setsockopt( %ld, "
+                                               "TCP_NODELAY) failed errno=%d (%s)\n",
+                                               (long)s, err, sock_errstr(err) );
 #else
                                        Debug( LDAP_DEBUG_ANY,
                                                "slapd(%ld): setsockopt(TCP_NODELAY) failed "
@@ -1472,8 +1493,8 @@ slapd_daemon_task(
 #endif
 
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1,
-                                  "slapd_daemon_task: new connection on %ld\n", (long)s ));
+                       LDAP_LOG( CONNECTION, DETAIL1, 
+                               "slapd_daemon_task: new connection on %ld\n", (long)s, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_CONNS, "daemon: new connection on %ld\n",
                                (long) s, 0, 0 );
@@ -1497,10 +1518,12 @@ slapd_daemon_task(
                                         (unsigned) ntohs( from.sa_in6_addr.sin6_port ) );
                        } else {
                                char addr[INET6_ADDRSTRLEN];
+
+                               peeraddr = (char *) inet_ntop( AF_INET6,
+                                                     &from.sa_in6_addr.sin6_addr,
+                                                     addr, sizeof addr );
                                sprintf( peername, "IP=%s %d",
-                                        inet_ntop( AF_INET6,
-                                                   &from.sa_in6_addr.sin6_addr,
-                                                   addr, sizeof addr) ? addr : "unknown",
+                                        peeraddr != NULL ? peeraddr : "unknown",
                                         (unsigned) ntohs( from.sa_in6_addr.sin6_port ) );
                        }
                        break;
@@ -1579,9 +1602,9 @@ slapd_daemon_task(
 
                        if( id < 0 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "connection", LDAP_LEVEL_INFO,
-                                          "slapd_daemon_task: connection_init(%ld, %s, %s) failed.\n",
-                                          (long)s, peername, slap_listeners[l]->sl_name ));
+                               LDAP_LOG( CONNECTION, INFO, 
+                                       "slapd_daemon_task: connection_init(%ld, %s, %s) failed.\n",
+                                       (long)s, peername, slap_listeners[l]->sl_name );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "daemon: connection_init(%ld, %s, %s) failed.\n",
@@ -1606,16 +1629,16 @@ slapd_daemon_task(
 
 #ifdef LDAP_DEBUG
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                          "slapd_daemon_task: activity on " ));
+               LDAP_LOG( CONNECTION, DETAIL2,
+                          "slapd_daemon_task: activity on ", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_CONNS, "daemon: activity on:", 0, 0, 0 );
 #endif
 #ifdef HAVE_WINSOCK
                for ( i = 0; i < readfds.fd_count; i++ ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                  " %d%s", readfds.fd_array[i], "r", 0 ));
+                       LDAP_LOG( CONNECTION, DETAIL2, 
+                               " %d%s", readfds.fd_array[i], "r", 0, 0 );
 #else
                        Debug( LDAP_DEBUG_CONNS, " %d%s",
                                readfds.fd_array[i], "r", 0 );
@@ -1623,8 +1646,8 @@ slapd_daemon_task(
                }
                for ( i = 0; i < writefds.fd_count; i++ ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                  " %d%s", writefds.fd_array[i], "w" ));
+                       LDAP_LOG( CONNECTION, DETAIL2, 
+                               " %d%s", writefds.fd_array[i], "w" , 0 );
 #else
                        Debug( LDAP_DEBUG_CONNS, " %d%s",
                                writefds.fd_array[i], "w", 0 );
@@ -1656,9 +1679,8 @@ slapd_daemon_task(
                        w = FD_ISSET( i, &writefds );
                        if ( r || w ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                          " %d%s%s", i,
-                                          r ? "r" : "", w ? "w" : "" ));
+                               LDAP_LOG( CONNECTION, DETAIL2, 
+                                       " %d%s%s", i, r ? "r" : "", w ? "w" : "" );
 #else
                                Debug( LDAP_DEBUG_CONNS, " %d%s%s", i,
                                    r ? "r" : "", w ? "w" : "" );
@@ -1667,7 +1689,7 @@ slapd_daemon_task(
                }
 #endif
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2, "\n" ));
+               LDAP_LOG( CONNECTION, DETAIL2, "\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_CONNS, "\n", 0, 0, 0 );
 #endif
@@ -1706,8 +1728,8 @@ slapd_daemon_task(
                                continue;
                        }
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                  "slapd_daemon_task: write active on %d\n", wd ));
+                       LDAP_LOG( CONNECTION, DETAIL2, 
+                               "slapd_daemon_task: write active on %d\n", wd, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_CONNS,
                                "daemon: write active on %d\n",
@@ -1759,8 +1781,8 @@ slapd_daemon_task(
                        }
 
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL2,
-                                  "slapd_daemon_task: read activity on %d\n", rd ));
+                       LDAP_LOG( CONNECTION, DETAIL2, 
+                               "slapd_daemon_task: read activity on %d\n", rd, 0, 0 );
 #else
                        Debug ( LDAP_DEBUG_CONNS,
                                "daemon: read activity on %d\n", rd, 0, 0 );
@@ -1781,8 +1803,8 @@ slapd_daemon_task(
 
        if( slapd_shutdown == 1 ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                          "slapd_daemon_task: shutdown requested and initiated.\n"));
+               LDAP_LOG( CONNECTION, CRIT,
+                  "slapd_daemon_task: shutdown requested and initiated.\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE,
                        "daemon: shutdown requested and initiated.\n",
@@ -1792,8 +1814,9 @@ slapd_daemon_task(
        } else if ( slapd_shutdown == 2 ) {
 #ifdef HAVE_NT_SERVICE_MANAGER
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                                  "slapd_daemon_task: shutdown initiated by Service Manager.\n"));
+                       LDAP_LOG( CONNECTION, CRIT,
+                          "slapd_daemon_task: shutdown initiated by Service Manager.\n",
+                          0, 0, 0);
 #else
                        Debug( LDAP_DEBUG_TRACE,
                               "daemon: shutdown initiated by Service Manager.\n",
@@ -1801,8 +1824,9 @@ slapd_daemon_task(
 #endif
 #else /* !HAVE_NT_SERVICE_MANAGER */
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                                  "slapd_daemon_task: abnormal condition, shutdown initiated.\n" ));
+                       LDAP_LOG( CONNECTION, CRIT,
+                          "slapd_daemon_task: abnormal condition, "
+                          "shutdown initiated.\n", 0, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_TRACE,
                               "daemon: abnormal condition, shutdown initiated.\n",
@@ -1811,8 +1835,9 @@ slapd_daemon_task(
 #endif /* !HAVE_NT_SERVICE_MANAGER */
        } else {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                          "slapd_daemon_task: no active streams, shutdown initiated.\n" ));
+               LDAP_LOG( CONNECTION, CRIT,
+                  "slapd_daemon_task: no active streams, shutdown initiated.\n", 
+                  0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE,
                       "daemon: no active streams, shutdown initiated.\n",
@@ -1826,9 +1851,9 @@ slapd_daemon_task(
        slap_listeners = NULL;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                  "slapd_daemon_task: shutdown waiting for %d threads to terminate.\n",
-                  ldap_pvt_thread_pool_backload(&connection_pool) ));
+       LDAP_LOG( CONNECTION, CRIT, 
+               "slapd_daemon_task: shutdown waiting for %d threads to terminate.\n",
+               ldap_pvt_thread_pool_backload(&connection_pool), 0, 0 );
 #else
        Debug( LDAP_DEBUG_ANY,
            "slapd shutdown: waiting for %d threads to terminate\n",
@@ -1857,8 +1882,9 @@ int slapd_daemon( void )
 
                if ( rc != 0 ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "connection", LDAP_LEVEL_ERR,
-                                  "slapd_daemon: listener ldap_pvt_thread_create failed (%d).\n", rc ));
+                       LDAP_LOG( CONNECTION, ERR, 
+                               "slapd_daemon: listener ldap_pvt_thread_create failed (%d).\n",
+                               rc, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
                        "listener ldap_pvt_thread_create failed (%d)\n", rc, 0, 0 );
@@ -1931,8 +1957,8 @@ RETSIGTYPE
 slap_sig_shutdown( int sig )
 {
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                  "slap_sig_shutdown: signal %d\n", sig ));
+       LDAP_LOG( CONNECTION, CRIT, 
+               "slap_sig_shutdown: signal %d\n", sig, 0, 0 );
 #else
        Debug(LDAP_DEBUG_TRACE, "slap_sig_shutdown: signal %d\n", sig, 0, 0);
 #endif
@@ -1946,8 +1972,8 @@ slap_sig_shutdown( int sig )
 #if HAVE_NT_SERVICE_MANAGER && SIGBREAK
        if (is_NT_Service && sig == SIGBREAK)
 #ifdef NEW_LOGGING
-           LDAP_LOG(( "connection", LDAP_LEVEL_CRIT,
-                      "slap_sig_shutdown: SIGBREAK ignored.\n" ));
+           LDAP_LOG( CONNECTION, CRIT,
+                   "slap_sig_shutdown: SIGBREAK ignored.\n", 0, 0, 0 );
 #else
            Debug(LDAP_DEBUG_TRACE, "slap_sig_shutdown: SIGBREAK ignored.\n",
                  0, 0, 0);