]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/dn.c
patch for ITS#3173
[openldap] / servers / slapd / dn.c
index ab49adeb401959ec5108f70948981059cc168912..6702e8dc18816938c6e106dfdc6ca184257aa2f2 100644 (file)
@@ -1,8 +1,27 @@
 /* dn.c - routines for dealing with distinguished names */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms are permitted
+ * provided that this notice is preserved and that due credit is given
+ * to the University of Michigan at Ann Arbor. The name of the University
+ * may not be used to endorse or promote products derived from this
+ * software without specific prior written permission. This software
+ * is provided ``as is'' without express or implied warranty.
  */
 
 #include "portable.h"
 #include <ac/string.h>
 #include <ac/time.h>
 
-#include "ldap_pvt.h"
-
 #include "slap.h"
-
-#define SLAP_LDAPDN_PRETTY 0x1
+#include "ldap_pvt.h" /* must be after slap.h, to get ldap_bv2dn_x() & co */
+#include "lutil.h"
 
 /*
  * The DN syntax-related functions take advantage of the dn representation
@@ -42,7 +59,7 @@
  * structural representation of a distinguished name.
  */
 static int
-LDAPDN_validate( LDAPDN *dn )
+LDAPDN_validate( LDAPDN dn )
 {
        int             iRDN;
        int             rc;
@@ -50,13 +67,13 @@ LDAPDN_validate( LDAPDN *dn )
        assert( dn );
 
        for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
-               LDAPRDN         *rdn = dn[ iRDN ][ 0 ];
+               LDAPRDN         rdn = dn[ iRDN ];
                int             iAVA;
 
                assert( rdn );
 
                for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
-                       LDAPAVA                 *ava = rdn[ iAVA ][ 0 ];
+                       LDAPAVA                 *ava = rdn[ iAVA ];
                        AttributeDescription    *ad;
                        slap_syntax_validate_func *validate = NULL;
 
@@ -65,7 +82,7 @@ LDAPDN_validate( LDAPDN *dn )
                        if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
                                const char      *text = NULL;
 
-                               rc = slap_bv2ad( ava->la_attr, &ad, &text );
+                               rc = slap_bv2ad( &ava->la_attr, &ad, &text );
                                if ( rc != LDAP_SUCCESS ) {
                                        return LDAP_INVALID_SYNTAX;
                                }
@@ -76,8 +93,7 @@ LDAPDN_validate( LDAPDN *dn )
                        /* 
                         * Replace attr oid/name with the canonical name
                         */
-                       ber_bvfree( ava->la_attr );
-                       ava->la_attr = ber_bvdup( &ad->ad_cname );
+                       ava->la_attr = ad->ad_cname;
 
                        validate = ad->ad_type->sat_syntax->ssyn_validate;
 
@@ -86,7 +102,7 @@ LDAPDN_validate( LDAPDN *dn )
                                 * validate value by validate function
                                 */
                                rc = ( *validate )( ad->ad_type->sat_syntax,
-                                       ava->la_value );
+                                       &ava->la_value );
                        
                                if ( rc != LDAP_SUCCESS ) {
                                        return LDAP_INVALID_SYNTAX;
@@ -107,30 +123,35 @@ dnValidate(
        struct berval *in )
 {
        int             rc;
-       LDAPDN          *dn = NULL;
+       LDAPDN          dn = NULL;
 
        assert( in );
 
        if ( in->bv_len == 0 ) {
-               return( LDAP_SUCCESS );
+               return LDAP_SUCCESS;
+
+       } else if ( in->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
+       }
+
+       rc = ldap_bv2dn( in, &dn, LDAP_DN_FORMAT_LDAP );
+       if ( rc != LDAP_SUCCESS ) {
+               return LDAP_INVALID_SYNTAX;
        }
 
-       rc = ldap_str2dn( in->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+       assert( strlen( in->bv_val ) == in->bv_len );
 
        /*
         * Schema-aware validate
         */
-       if ( rc == LDAP_SUCCESS ) {
-               rc = LDAPDN_validate( dn );
-       }
-       
-       ldapava_free_dn( dn );
-       
+       rc = LDAPDN_validate( dn );
+       ldap_dnfree( dn );
+
        if ( rc != LDAP_SUCCESS ) {
-               return( LDAP_INVALID_SYNTAX );
+               return LDAP_INVALID_SYNTAX;
        }
 
-       return( LDAP_SUCCESS );
+       return LDAP_SUCCESS;
 }
 
 /*
@@ -141,25 +162,28 @@ dnValidate(
  * (use memcmp, which implies alphabetical order in case of IA5 value;
  * this should guarantee the repeatability of the operation).
  *
+ * Note: the sorting can be slightly improved by sorting first
+ * by attribute type length, then by alphabetical order.
+ *
  * uses a linear search; should be fine since the number of AVAs in
  * a RDN should be limited.
  */
 static void
-AVA_Sort( LDAPRDN *rdn, int iAVA )
+AVA_Sort( LDAPRDN rdn, int iAVA )
 {
        int             i;
-       LDAPAVA         *ava_in = rdn[ iAVA ][ 0 ];
+       LDAPAVA         *ava_in = rdn[ iAVA ];
 
        assert( rdn );
        assert( ava_in );
        
        for ( i = 0; i < iAVA; i++ ) {
-               LDAPAVA         *ava = rdn[ i ][ 0 ];
+               LDAPAVA         *ava = rdn[ i ];
                int             a, j;
 
                assert( ava );
 
-               a = strcmp( ava_in->la_attr->bv_val, ava->la_attr->bv_val );
+               a = strcmp( ava_in->la_attr.bv_val, ava->la_attr.bv_val );
 
                if ( a > 0 ) {
                        break;
@@ -168,12 +192,12 @@ AVA_Sort( LDAPRDN *rdn, int iAVA )
                while ( a == 0 ) {
                        int             v, d;
 
-                       d = ava_in->la_value->bv_len - ava->la_value->bv_len;
+                       d = ava_in->la_value.bv_len - ava->la_value.bv_len;
 
-                       v = memcmp( ava_in->la_value->bv_val, 
-                                       ava->la_value->bv_val,
-                                       d <= 0 ? ava_in->la_value->bv_len 
-                                               : ava->la_value->bv_len );
+                       v = memcmp( ava_in->la_value.bv_val, 
+                                       ava->la_value.bv_val,
+                                       d <= 0 ? ava_in->la_value.bv_len 
+                                               : ava->la_value.bv_len );
 
                        if ( v == 0 && d != 0 ) {
                                v = d;
@@ -193,18 +217,18 @@ AVA_Sort( LDAPRDN *rdn, int iAVA )
                                return;
                        }
 
-                       ava = rdn[ i ][ 0 ];
-                       a = strcmp( ava_in->la_value->bv_val, 
-                                       ava->la_value->bv_val );
+                       ava = rdn[ i ];
+                       a = strcmp( ava_in->la_attr.bv_val, 
+                                       ava->la_attr.bv_val );
                }
 
                /*
                 * move ahead
                 */
                for ( j = iAVA; j > i; j-- ) {
-                       rdn[ j ][ 0 ] = rdn[ j - 1 ][ 0 ];
+                       rdn[ j ] = rdn[ j - 1 ];
                }
-               rdn[ i ][ 0 ] = ava_in;
+               rdn[ i ] = ava_in;
 
                return;
        }
@@ -215,7 +239,7 @@ AVA_Sort( LDAPRDN *rdn, int iAVA )
  * structural representation of a distinguished name.
  */
 static int
-LDAPDN_rewrite( LDAPDN *dn, unsigned flags )
+LDAPDN_rewrite( LDAPDN dn, unsigned flags, void *ctx )
 {
        int             iRDN;
        int             rc;
@@ -223,171 +247,215 @@ LDAPDN_rewrite( LDAPDN *dn, unsigned flags )
        assert( dn );
 
        for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
-               LDAPRDN         *rdn = dn[ iRDN ][ 0 ];
+               LDAPRDN         rdn = dn[ iRDN ];
                int             iAVA;
 
                assert( rdn );
 
                for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
-                       LDAPAVA                 *ava = rdn[ iAVA ][ 0 ];
+                       LDAPAVA                 *ava = rdn[ iAVA ];
                        AttributeDescription    *ad;
+                       slap_syntax_validate_func *validf = NULL;
+                       slap_mr_normalize_func *normf = NULL;
                        slap_syntax_transform_func *transf = NULL;
-                       MatchingRule *mr;
-                       struct berval           *bv = NULL;
+                       MatchingRule *mr = NULL;
+                       struct berval           bv = BER_BVNULL;
+                       int                     do_sort = 0;
 
                        assert( ava );
 
                        if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
                                const char      *text = NULL;
 
-                               rc = slap_bv2ad( ava->la_attr, &ad, &text );
+                               rc = slap_bv2ad( &ava->la_attr, &ad, &text );
                                if ( rc != LDAP_SUCCESS ) {
                                        return LDAP_INVALID_SYNTAX;
                                }
                                
                                ava->la_private = ( void * )ad;
+                               do_sort = 1;
                        }
 
                        /* 
                         * Replace attr oid/name with the canonical name
                         */
-                       ber_bvfree( ava->la_attr );
-                       ava->la_attr = ber_bvdup( &ad->ad_cname );
+                       ava->la_attr = ad->ad_cname;
 
-                       if( flags & SLAP_LDAPDN_PRETTY ) {
+                       if( ava->la_flags & LDAP_AVA_BINARY ) {
+                               if( ava->la_value.bv_len == 0 ) {
+                                       /* BER encoding is empty */
+                                       return LDAP_INVALID_SYNTAX;
+                               }
+
+                               /* AVA is binary encoded, don't muck with it */
+                       } else if( flags & SLAP_LDAPDN_PRETTY ) {
                                transf = ad->ad_type->sat_syntax->ssyn_pretty;
-                               mr = NULL;
-                       } else {
-                               transf = ad->ad_type->sat_syntax->ssyn_normalize;
+                               if( !transf ) {
+                                       validf = ad->ad_type->sat_syntax->ssyn_validate;
+                               }
+                       } else { /* normalization */
+                               validf = ad->ad_type->sat_syntax->ssyn_validate;
                                mr = ad->ad_type->sat_equality;
+                               if( mr ) normf = mr->smr_normalize;
+                       }
+
+                       if ( validf ) {
+                               /* validate value before normalization */
+                               rc = ( *validf )( ad->ad_type->sat_syntax,
+                                       ava->la_value.bv_len
+                                               ? &ava->la_value
+                                               : (struct berval *) &slap_empty_bv );
+
+                               if ( rc != LDAP_SUCCESS ) {
+                                       return LDAP_INVALID_SYNTAX;
+                               }
                        }
 
                        if ( transf ) {
                                /*
-                                * transform value by normalize/pretty function
+                                * transform value by pretty function
+                                *      if value is empty, use empty_bv
                                 */
                                rc = ( *transf )( ad->ad_type->sat_syntax,
-                                       ava->la_value, &bv );
+                                       ava->la_value.bv_len
+                                               ? &ava->la_value
+                                               : (struct berval *) &slap_empty_bv,
+                                       &bv, ctx );
                        
                                if ( rc != LDAP_SUCCESS ) {
                                        return LDAP_INVALID_SYNTAX;
                                }
                        }
 
-                       if( mr && ( mr->smr_usage & SLAP_MR_DN_FOLD ) ) {
-                               struct berval *s = bv;
-
-                               bv = ber_bvstr( UTF8normalize( bv ? bv : ava->la_value, 
-                                       UTF8_CASEFOLD ) );
-
-                               ber_bvfree( s );
+                       if ( normf ) {
+                               /*
+                                * normalize value
+                                *      if value is empty, use empty_bv
+                                */
+                               rc = ( *normf )(
+                                       SLAP_MR_VALUE_OF_ASSERTION_SYNTAX,
+                                       ad->ad_type->sat_syntax,
+                                       mr,
+                                       ava->la_value.bv_len
+                                               ? &ava->la_value
+                                               : (struct berval *) &slap_empty_bv,
+                                       &bv, ctx );
+                       
+                               if ( rc != LDAP_SUCCESS ) {
+                                       return LDAP_INVALID_SYNTAX;
+                               }
                        }
 
-                       if( bv ) {
-                               ber_bvfree( ava->la_value );
+
+                       if( bv.bv_val ) {
+                               if ( ava->la_flags & LDAP_AVA_FREE_VALUE )
+                                       ber_memfree_x( ava->la_value.bv_val, ctx );
                                ava->la_value = bv;
+                               ava->la_flags |= LDAP_AVA_FREE_VALUE;
                        }
 
-                       AVA_Sort( rdn, iAVA );
+                       if( do_sort ) AVA_Sort( rdn, iAVA );
                }
        }
 
        return LDAP_SUCCESS;
 }
 
-/*
- * dn normalize routine
- */
 int
 dnNormalize(
-       Syntax *syntax,
-       struct berval *val,
-       struct berval **normalized )
+    slap_mask_t use,
+    Syntax *syntax,
+    MatchingRule *mr,
+    struct berval *val,
+    struct berval *out,
+    void *ctx)
 {
-       struct berval *out = NULL;
+       assert( val );
+       assert( out );
 
        Debug( LDAP_DEBUG_TRACE, ">>> dnNormalize: <%s>\n", val->bv_val, 0, 0 );
 
-       assert( val );
-       assert( normalized );
-
        if ( val->bv_len != 0 ) {
-               LDAPDN          *dn = NULL;
-               char            *dn_out = NULL;
+               LDAPDN          dn = NULL;
                int             rc;
 
                /*
                 * Go to structural representation
                 */
-               rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+               rc = ldap_bv2dn_x( val, &dn, LDAP_DN_FORMAT_LDAP, ctx );
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
 
+               assert( strlen( val->bv_val ) == val->bv_len );
+
                /*
                 * Schema-aware rewrite
                 */
-               if ( LDAPDN_rewrite( dn, 0 ) != LDAP_SUCCESS ) {
-                       ldapava_free_dn( dn );
+               if ( LDAPDN_rewrite( dn, 0, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
                /*
                 * Back to string representation
                 */
-               rc = ldap_dn2str( dn, &dn_out, LDAP_DN_FORMAT_LDAPV3 );
+               rc = ldap_dn2bv_x( dn, out,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
-               ldapava_free_dn( dn );
+               ldap_dnfree_x( dn, ctx );
 
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
-
-               out = ber_bvstr( dn_out );
-
        } else {
-               out = ber_bvdup( val );
+               ber_dupbv_x( out, val, ctx );
        }
 
        Debug( LDAP_DEBUG_TRACE, "<<< dnNormalize: <%s>\n", out->bv_val, 0, 0 );
 
-       *normalized = out;
-
        return LDAP_SUCCESS;
 }
 
-/*
- * dn "pretty"ing routine
- */
 int
 dnPretty(
        Syntax *syntax,
        struct berval *val,
-       struct berval **pretty)
+       struct berval *out,
+       void *ctx)
 {
-       struct berval *out = NULL;
+       assert( val );
+       assert( out );
 
+#ifdef NEW_LOGGING
+       LDAP_LOG( OPERATION, ARGS, ">>> dnPretty: <%s>\n", val->bv_val, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, ">>> dnPretty: <%s>\n", val->bv_val, 0, 0 );
+#endif
 
-       assert( val );
-       assert( pretty );
+       if ( val->bv_len == 0 ) {
+               ber_dupbv_x( out, val, ctx );
 
-       if ( val->bv_len != 0 ) {
-               LDAPDN          *dn = NULL;
-               char            *dn_out = NULL;
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
+
+       } else {
+               LDAPDN          dn = NULL;
                int             rc;
 
                /* FIXME: should be liberal in what we accept */
-               rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+               rc = ldap_bv2dn_x( val, &dn, LDAP_DN_FORMAT_LDAP, ctx );
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
 
+               assert( strlen( val->bv_val ) == val->bv_len );
+
                /*
                 * Schema-aware rewrite
                 */
-               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY ) != LDAP_SUCCESS ) {
-                       ldapava_free_dn( dn );
+               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
@@ -395,33 +463,175 @@ dnPretty(
                /* RE: the default is the form that is used as
                 * an internal representation; the pretty form
                 * is a variant */
-               rc = ldap_dn2str( dn, &dn_out,
-                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
+               rc = ldap_dn2bv_x( dn, out,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
-               ldapava_free_dn( dn );
+               ldap_dnfree_x( dn, ctx );
 
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
+       }
 
-               out = ber_bvstr( dn_out );
+#ifdef NEW_LOGGING
+       LDAP_LOG( OPERATION, ARGS, "<<< dnPretty: <%s>\n", out->bv_val, 0, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val, 0, 0 );
+#endif
+
+       return LDAP_SUCCESS;
+}
+
+int
+dnPrettyNormalDN(
+       Syntax *syntax,
+       struct berval *val,
+       LDAPDN *dn,
+       int flags,
+       void *ctx )
+{
+       assert( val );
+       assert( dn );
+
+#ifdef NEW_LOGGING
+       LDAP_LOG( OPERATION, ARGS, ">>> dn%sDN: <%s>\n", 
+                       flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal", 
+                       val->bv_val, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, ">>> dn%sDN: <%s>\n", 
+                       flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal", 
+                       val->bv_val, 0 );
+#endif
+
+       if ( val->bv_len == 0 ) {
+               return LDAP_SUCCESS;
+
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
 
        } else {
-               out = ber_bvdup( val );
+               int             rc;
+
+               /* FIXME: should be liberal in what we accept */
+               rc = ldap_bv2dn_x( val, dn, LDAP_DN_FORMAT_LDAP, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               assert( strlen( val->bv_val ) == val->bv_len );
+
+               /*
+                * Schema-aware rewrite
+                */
+               if ( LDAPDN_rewrite( *dn, flags, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( *dn, ctx );
+                       *dn = NULL;
+                       return LDAP_INVALID_SYNTAX;
+               }
        }
 
-       Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val, 0, 0 );
+       Debug( LDAP_DEBUG_TRACE, "<<< dn%sDN\n", 
+                       flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal",
+                       0, 0 );
+
+       return LDAP_SUCCESS;
+}
+
+/*
+ * Combination of both dnPretty and dnNormalize
+ */
+int
+dnPrettyNormal(
+       Syntax *syntax,
+       struct berval *val,
+       struct berval *pretty,
+       struct berval *normal,
+       void *ctx)
+{
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, ">>> dnPrettyNormal: <%s>\n", val->bv_val, 0, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, ">>> dnPrettyNormal: <%s>\n", val->bv_val, 0, 0 );
+#endif
+
+       assert( val );
+       assert( pretty );
+       assert( normal );
+
+       if ( val->bv_len == 0 ) {
+               ber_dupbv_x( pretty, val, ctx );
+               ber_dupbv_x( normal, val, ctx );
+
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               /* too big */
+               return LDAP_INVALID_SYNTAX;
+
+       } else {
+               LDAPDN          dn = NULL;
+               int             rc;
+
+               pretty->bv_val = NULL;
+               normal->bv_val = NULL;
+               pretty->bv_len = 0;
+               normal->bv_len = 0;
+
+               /* FIXME: should be liberal in what we accept */
+               rc = ldap_bv2dn_x( val, &dn, LDAP_DN_FORMAT_LDAP, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               assert( strlen( val->bv_val ) == val->bv_len );
+
+               /*
+                * Schema-aware rewrite
+                */
+               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               rc = ldap_dn2bv_x( dn, pretty,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
+
+               if ( rc != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               if ( LDAPDN_rewrite( dn, 0, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
+                       ber_memfree_x( pretty->bv_val, ctx );
+                       pretty->bv_val = NULL;
+                       pretty->bv_len = 0;
+                       return LDAP_INVALID_SYNTAX;
+               }
 
-       *pretty = out;
+               rc = ldap_dn2bv_x( dn, normal,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
+
+               ldap_dnfree_x( dn, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       ber_memfree_x( pretty->bv_val, ctx );
+                       pretty->bv_val = NULL;
+                       pretty->bv_len = 0;
+                       return LDAP_INVALID_SYNTAX;
+               }
+       }
+
+#ifdef NEW_LOGGING
+       LDAP_LOG (OPERATION, RESULTS, "<<< dnPrettyNormal: <%s>, <%s>\n",
+               pretty->bv_val, normal->bv_val, 0  );
+#else
+       Debug( LDAP_DEBUG_TRACE, "<<< dnPrettyNormal: <%s>, <%s>\n",
+               pretty->bv_val, normal->bv_val, 0 );
+#endif
 
        return LDAP_SUCCESS;
 }
 
 /*
- * dn match routine
- *
- * note: uses exact string match (strcmp) because it is supposed to work
- * on normalized DNs.
+ * dnMatch routine
  */
 int
 dnMatch(
@@ -442,13 +652,13 @@ dnMatch(
        match = value->bv_len - asserted->bv_len;
 
        if ( match == 0 ) {
-               match = strcmp( value->bv_val, asserted->bv_val );
+               match = memcmp( value->bv_val, asserted->bv_val, 
+                               value->bv_len );
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "schema", LDAP_LEVEL_ENTRY,
-               "dnMatch: %d\n    %s\n    %s\n", match,
-               value->bv_val, asserted->bv_val ));
+       LDAP_LOG( CONFIG, ENTRY, "dnMatch: %d\n    %s\n    %s\n", 
+               match, value->bv_val, asserted->bv_val  );
 #else
        Debug( LDAP_DEBUG_ARGS, "dnMatch %d\n\t\"%s\"\n\t\"%s\"\n",
                match, value->bv_val, asserted->bv_val );
@@ -459,216 +669,202 @@ dnMatch(
 }
 
 /*
- * dn_validate - validate and compress dn.  the dn is
- * compressed in place are returned if valid.
+ * dnParent - dn's parent, in-place
+ *
+ * note: the incoming dn is assumed to be normalized/prettyfied,
+ * so that escaped rdn/ava separators are in '\'+hexpair form
  */
-
-char *
-dn_validate( char *dn_in )
+void
+dnParent( 
+       struct berval   *dn, 
+       struct berval   *pdn )
 {
-       struct berval   val, *normalized;
-       int             rc;
+       char    *p;
 
-       if ( dn_in == NULL || dn_in[ 0 ] == '\0' ) {
-               return( dn_in );
-       }
-
-       val.bv_val = dn_in;
-       val.bv_len = strlen( dn_in );
+       p = strchr( dn->bv_val, ',' );
 
-       rc = dnPretty( NULL, &val, &normalized );
-       if ( rc != LDAP_SUCCESS ) {
-               return( NULL );
+       /* one-level dn */
+       if ( p == NULL ) {
+               pdn->bv_len = 0;
+               pdn->bv_val = dn->bv_val + dn->bv_len;
+               return;
        }
 
-       if ( val.bv_len < normalized->bv_len ) {
-               ber_bvfree( normalized );
-               return( NULL );
-       }
+       assert( DN_SEPARATOR( p[ 0 ] ) );
+       p++;
 
-       AC_MEMCPY( dn_in, normalized->bv_val, normalized->bv_len + 1 );
-       ber_bvfree( normalized );
+       assert( ATTR_LEADCHAR( p[ 0 ] ) );
+       pdn->bv_val = p;
+       pdn->bv_len = dn->bv_len - (p - dn->bv_val);
 
-       return( dn_in );
+       return;
 }
 
-/*
- * dn_normalize - put dn into a canonical form suitable for storing
- * in a hash database. this involves normalizing the case as well as
- * the format. the dn is normalized in place as well as returned if valid.
- */
-
-char *
-dn_normalize( char *dn )
+int
+dnExtractRdn( 
+       struct berval   *dn, 
+       struct berval   *rdn,
+       void *ctx )
 {
-       struct berval   val, *normalized;
+       LDAPRDN         tmpRDN;
+       const char      *p;
        int             rc;
 
-       if ( dn == NULL || dn[ 0 ] == '\0' ) {
-               return( dn );
-       }
+       assert( dn );
+       assert( rdn );
 
-       val.bv_val = dn;
-       val.bv_len = strlen( dn );
+       if( dn->bv_len == 0 ) {
+               return LDAP_OTHER;
+       }
 
-       rc = dnNormalize( NULL, &val, &normalized );
+       rc = ldap_bv2rdn_x( dn, &tmpRDN, (char **)&p, LDAP_DN_FORMAT_LDAP, ctx );
        if ( rc != LDAP_SUCCESS ) {
-               return( NULL );
+               return rc;
        }
 
-       if ( val.bv_len < normalized->bv_len ) {
-               ber_bvfree( normalized );
-               return( NULL );
-       }
+       rc = ldap_rdn2bv_x( tmpRDN, rdn, LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
-       AC_MEMCPY( dn, normalized->bv_val, normalized->bv_len + 1 );
-       ber_bvfree( normalized );
+       ldap_rdnfree_x( tmpRDN, ctx );
+       if ( rc != LDAP_SUCCESS ) {
+               return rc;
+       }
 
-       return( dn );
+       return LDAP_SUCCESS;
 }
 
 /*
- * dn_parent - return the dn's parent, in-place
+ * We can assume the input is a prettied or normalized DN
  */
-char *
-dn_parent(
-       Backend *be,
-       const char      *dn )
+int 
+dn_rdnlen(
+       Backend         *be,
+       struct berval   *dn_in )
 {
-       const char      *s;
-       int     inquote;
+       const char      *p;
 
-       if( dn == NULL ) {
-               return NULL;
-       }
+       assert( dn_in );
 
-       while(*dn != '\0' && ASCII_SPACE(*dn)) {
-               dn++;
+       if ( dn_in == NULL ) {
+               return 0;
        }
 
-       if( *dn == '\0' ) {
-               return NULL;
+       if ( !dn_in->bv_len ) {
+               return 0;
        }
 
-       if ( be != NULL && be_issuffix( be, dn ) ) {
-               return NULL;
+       if ( be != NULL && be_issuffix( be, dn_in ) ) {
+               return 0;
        }
 
-       /*
-        * assume it is an X.500-style name, which looks like
-        * foo=bar,sha=baz,...
-        */
-
-       inquote = 0;
-       for ( s = dn; *s; s++ ) {
-               if ( *s == '\\' ) {
-                       if ( *(s + 1) ) {
-                               s++;
-                       }
-                       continue;
-               }
-               if ( inquote ) {
-                       if ( *s == '"' ) {
-                               inquote = 0;
-                       }
-               } else {
-                       if ( *s == '"' ) {
-                               inquote = 1;
-                       } else if ( DN_SEPARATOR( *s ) ) {
-                               return (char *)s + 1;
-                       }
-               }
-       }
+       p = strchr( dn_in->bv_val, ',' );
 
-       return "";
+       return p ? p - dn_in->bv_val : dn_in->bv_len;
 }
 
-int dn_rdnlen(
-       Backend *be,
-       const char      *dn_in )
-{
-       char    *s;
-       int     inquote;
 
-       if( dn_in == NULL ) {
-               return 0;
+/* rdnValidate:
+ *
+ * LDAP_SUCCESS if rdn is a legal rdn;
+ * LDAP_INVALID_SYNTAX otherwise (including a sequence of rdns)
+ */
+int
+rdnValidate( struct berval *rdn )
+{
+#if 1
+       /* Major cheat!
+        * input is a pretty or normalized DN
+        * hence, we can just search for ','
+        */
+       if( rdn == NULL || rdn->bv_len == 0 ||
+               rdn->bv_len > SLAP_LDAPDN_MAXLEN )
+       {
+               return LDAP_INVALID_SYNTAX;
        }
 
-       while(*dn_in && ASCII_SPACE(*dn_in)) {
-               dn_in++;
-       }
+       return strchr( rdn->bv_val, ',' ) == NULL
+               ? LDAP_SUCCESS : LDAP_INVALID_SYNTAX;
 
-       if( *dn_in == '\0' ) {
-               return( 0 );
+#else
+       LDAPRDN         *RDN, **DN[ 2 ] = { &RDN, NULL };
+       const char      *p;
+       int             rc;
+
+       /*
+        * must be non-empty
+        */
+       if ( rdn == NULL || rdn == '\0' ) {
+               return 0;
        }
 
-       if ( be != NULL && be_issuffix( be, dn_in ) ) {
-               return( 0 );
+       /*
+        * must be parsable
+        */
+       rc = ldap_bv2rdn( rdn, &RDN, (char **)&p, LDAP_DN_FORMAT_LDAP );
+       if ( rc != LDAP_SUCCESS ) {
+               return 0;
        }
 
-       inquote = 0;
+       /*
+        * Must be one-level
+        */
+       if ( p[ 0 ] != '\0' ) {
+               return 0;
+       }
 
-       for ( s = (char *)dn_in; *s; s++ ) {
-               if ( *s == '\\' ) {
-                       if ( *(s + 1) ) {
-                               s++;
-                       }
-                       continue;
-               }
-               if ( inquote ) {
-                       if ( *s == '"' ) {
-                               inquote = 0;
-                       }
-               } else {
-                       if ( *s == '"' ) {
-                               inquote = 1;
-                       } else if ( DN_SEPARATOR( *s ) ) {
-                               break;
-                       }
-               }
+       /*
+        * Schema-aware validate
+        */
+       if ( rc == LDAP_SUCCESS ) {
+               rc = LDAPDN_validate( DN );
        }
+       ldap_rdnfree( RDN );
 
-       return( s - dn_in );
+       /*
+        * Must validate (there's a repeated parsing ...)
+        */
+       return ( rc == LDAP_SUCCESS );
+#endif
 }
 
-char * dn_rdn(
-       Backend *be,
-       const char      *dn_in )
-{
-       char *rdn;
-       int i = dn_rdnlen( be, dn_in );
-
-       rdn = ch_malloc( i + 1 );
-       strncpy(rdn, dn_in, i);
-       rdn[i] = '\0';
-       return rdn;
-}
 
-/*
- * return a charray of all subtrees to which the DN resides in
+/* build_new_dn:
+ *
+ * Used by ldbm/bdb2 back_modrdn to create the new dn of entries being
+ * renamed.
+ *
+ * new_dn = parent (p_dn) + separator + rdn (newrdn) + null.
  */
-char **dn_subtree(
-       Backend *be,
-       const char      *dn )
+
+void
+build_new_dn( struct berval * new_dn,
+       struct berval * parent_dn,
+       struct berval * newrdn,
+       void *memctx )
 {
-       char **subtree = NULL;
-       
-       do {
-               charray_add( &subtree, dn );
+       char *ptr;
 
-               dn = dn_parent( be, dn );
+       if ( parent_dn == NULL || parent_dn->bv_len == 0 ) {
+               ber_dupbv( new_dn, newrdn );
+               return;
+       }
 
-       } while ( dn != NULL );
+       new_dn->bv_len = parent_dn->bv_len + newrdn->bv_len + 1;
+       new_dn->bv_val = (char *) slap_sl_malloc( new_dn->bv_len + 1, memctx );
 
-       return subtree;
+       ptr = lutil_strcopy( new_dn->bv_val, newrdn->bv_val );
+       *ptr++ = ',';
+       strcpy( ptr, parent_dn->bv_val );
 }
 
 
+/*
+ * dnIsSuffix - tells whether suffix is a suffix of dn.
+ * Both dn and suffix must be normalized.
+ */
 int
-dn_issuffixbv(
+dnIsSuffix(
        const struct berval *dn,
-       const struct berval *suffix
-)
+       const struct berval *suffix )
 {
        int     d = dn->bv_len - suffix->bv_len;
 
@@ -686,8 +882,7 @@ dn_issuffixbv(
        }
 
        /* no rdn separator or escaped rdn separator */
-       if ( d > 1 && ( !DN_SEPARATOR( dn->bv_val[ d - 1 ] ) 
-                               || DN_ESCAPE( dn->bv_val[ d - 2 ] ) ) ) {
+       if ( d > 1 && !DN_SEPARATOR( dn->bv_val[ d - 1 ] ) ) {
                return 0;
        }
 
@@ -700,263 +895,29 @@ dn_issuffixbv(
        return( strcmp( dn->bv_val + d, suffix->bv_val ) == 0 );
 }
 
+#ifdef HAVE_TLS
 /*
- * dn_issuffix - tells whether suffix is a suffix of dn. Both dn
- * and suffix must be normalized.
+ * Convert an X.509 DN into a normalized LDAP DN
  */
-
 int
-dn_issuffix(
-       const char      *dn,
-       const char      *suffix
-)
+dnX509normalize( void *x509_name, struct berval *out )
 {
-       struct berval   bvdn, bvsuffix;
-
-       assert( dn );
-       assert( suffix );
+       /* Invoke the LDAP library's converter with our schema-rewriter */
+       int rc = ldap_X509dn2bv( x509_name, out, LDAPDN_rewrite, 0 );
 
-       bvdn.bv_val = (char *) dn;
-       bvdn.bv_len = strlen( dn );
-       bvsuffix.bv_val = (char *) suffix;
-       bvsuffix.bv_len = strlen( suffix );
+       Debug( LDAP_DEBUG_TRACE,
+               "dnX509Normalize: <%s>\n", out->bv_val, 0, 0 );
 
-       return dn_issuffixbv( &bvdn, &bvsuffix );
+       return rc;
 }
 
 /*
- * get_next_substring(), rdn_attr_type(), rdn_attr_value(), and
- * build_new_dn().
- *
- * Copyright 1999, Juan C. Gomez, All rights reserved.
- * This software is not subject to any license of Silicon Graphics
- * Inc. or Purdue University.
- *
- * Redistribution and use in source and binary forms are permitted
- * without restriction or fee of any kind as long as this notice
- * is preserved.
- *
- */
-
-/* get_next_substring:
- *
- * Gets next substring in s, using d (or the end of the string '\0') as a
- * string delimiter, and places it in a duplicated memory space. Leading
- * spaces are ignored. String s **must** be null-terminated.
- */
-
-static char *
-get_next_substring( const char * s, char d )
-{
-
-       char    *str, *r;
-
-       r = str = ch_malloc( strlen(s) + 1 );
-
-       /* Skip leading spaces */
-       
-       while ( *s && ASCII_SPACE(*s) ) {
-               s++;
-       }
-       
-       /* Copy word */
-
-       while ( *s && (*s != d) ) {
-
-               /* Don't stop when you see trailing spaces may be a multi-word
-               * string, i.e. name=John Doe!
-               */
-
-               *str++ = *s++;
-       }
-       
-       *str = '\0';
-       
-       return r;
-       
-}
-
-
-/* rdn_attr_type:
- *
- * Given a string (i.e. an rdn) of the form:
- *      "attribute_type = attribute_value"
- * this function returns the type of an attribute, that is the
- * string "attribute_type" which is placed in newly allocated
- * memory. The returned string will be null-terminated.
- */
-
-char * rdn_attr_type( const char * s )
-{
-       return get_next_substring( s, '=' );
-}
-
-
-/* rdn_attr_value:
- *
- * Given a string (i.e. an rdn) of the form:
- *      "attribute_type = attribute_value"
- * this function returns "attribute_type" which is placed in newly allocated
- * memory. The returned string will be null-terminated and may contain
- * spaces (i.e. "John Doe\0").
- */
-
-char *
-rdn_attr_value( const char * rdn )
-{
-
-       const char      *str;
-
-       if ( (str = strchr( rdn, '=' )) != NULL ) {
-               return get_next_substring(++str, '\0');
-       }
-
-       return NULL;
-
-}
-
-
-/* rdn_attrs:
- *
- * Given a string (i.e. an rdn) of the form:
- *   "attribute_type=attribute_value[+attribute_type=attribute_value[...]]"
- * this function stores the types of the attributes in ptypes, that is the
- * array of strings "attribute_type" which is placed in newly allocated
- * memory, and the values of the attributes in pvalues, that is the
- * array of strings "attribute_value" which is placed in newly allocated
- * memory. Returns 0 on success, -1 on failure.
- *
- * note: got part of the code from dn_validate
- */
-
-int
-rdn_attrs( const char * rdn_in, char ***ptypes, char ***pvalues)
-{
-       char **parts, **p;
-
-       *ptypes = NULL;
-       *pvalues = NULL;
-
-       /*
-        * explode the rdn in parts
-        */
-       parts = ldap_explode_rdn( rdn_in, 0 );
-
-       if ( parts == NULL ) {
-               return( -1 );
-       }
-
-       for ( p = parts; p[0]; p++ ) {
-               char *s, *e, *d;
-               
-               /* split each rdn part in type value */
-               s = strchr( p[0], '=' );
-               if ( s == NULL ) {
-                       charray_free( *ptypes );
-                       charray_free( *pvalues );
-                       charray_free( parts );
-                       return( -1 );
-               }
-               
-               /* type should be fine */
-               charray_add_n( ptypes, p[0], ( s-p[0] ) );
-
-               /* value needs to be unescaped
-                * (maybe this should be moved to ldap_explode_rdn?) */
-               for ( e = d = s + 1; e[0]; e++ ) {
-                       if ( *e != '\\' ) {
-                               *d++ = *e;
-                       }
-               }
-               d[0] = '\0';
-               charray_add( pvalues, s + 1 );
-       }
-
-       /* free array */
-       charray_free( parts );
-
-       return( 0 );
-}
-
-
-/* rdn_validate:
- *
- * 1 if rdn is a legal rdn;
- * 0 otherwise (including a sequence of rdns)
- *
- * note: got it from dn_rdn; it should be rewritten
- * according to dn_validate
+ * Get the TLS session's peer's DN into a normalized LDAP DN
  */
 int
-rdn_validate( const char * rdn )
+dnX509peerNormalize( void *ssl, struct berval *dn )
 {
-       int     inquote;
-
-       if ( rdn == NULL ) {
-               return( 0 );
-       }
 
-       if ( strchr( rdn, '=' ) == NULL ) {
-               return( 0 );
-       }
-
-       while ( *rdn && ASCII_SPACE( *rdn ) ) {
-               rdn++;
-       }
-
-       if( *rdn == '\0' ) {
-               return( 0 );
-       }
-
-       inquote = 0;
-
-       for ( ; *rdn; rdn++ ) {
-               if ( *rdn == '\\' ) {
-                       if ( *(rdn + 1) ) {
-                               rdn++;
-                       }
-                       continue;
-               }
-               if ( inquote ) {
-                       if ( *rdn == '"' ) {
-                               inquote = 0;
-                       }
-               } else {
-                       if ( *rdn == '"' ) {
-                               inquote = 1;
-                       } else if ( DN_SEPARATOR( *rdn ) ) {
-                               return( 0 );
-                       }
-               }
-       }
-
-       return( 1 );
-}
-
-
-/* build_new_dn:
- *
- * Used by ldbm/bdb2 back_modrdn to create the new dn of entries being
- * renamed.
- *
- * new_dn = parent (p_dn) + separator(s) + rdn (newrdn) + null.
- */
-
-void
-build_new_dn( char ** new_dn,
-       const char *e_dn,
-       const char * p_dn,
-       const char * newrdn )
-{
-
-       if ( p_dn == NULL ) {
-               *new_dn = ch_strdup( newrdn );
-               return;
-       }
-
-       *new_dn = (char *) ch_malloc( strlen( p_dn ) + strlen( newrdn ) + 3 );
-
-       strcpy( *new_dn, newrdn );
-       strcat( *new_dn, "," );
-       strcat( *new_dn, p_dn );
+       return ldap_pvt_tls_get_peer_dn( ssl, dn, (LDAPDN_rewrite_dummy *)LDAPDN_rewrite, 0 );
 }
+#endif