]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/dn.c
ITS#6932: Clean up strange asserts & nearby code.
[openldap] / servers / slapd / dn.c
index f871e38ce7526289fbd467303ca77840cbff3e0e..cb4c6951655718bf4b97b278512bea16fa2ec61b 100644 (file)
@@ -1,8 +1,27 @@
 /* dn.c - routines for dealing with distinguished names */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2011 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms are permitted
+ * provided that this notice is preserved and that due credit is given
+ * to the University of Michigan at Ann Arbor. The name of the University
+ * may not be used to endorse or promote products derived from this
+ * software without specific prior written permission. This software
+ * is provided ``as is'' without express or implied warranty.
  */
 
 #include "portable.h"
 #include <ac/string.h>
 #include <ac/time.h>
 
-#include "ldap_pvt.h"
-
 #include "slap.h"
-
-const struct berval slap_empty_bv = { 0, "" };
-
-#define SLAP_LDAPDN_PRETTY 0x1
+#include "lutil.h"
 
 /*
  * The DN syntax-related functions take advantage of the dn representation
@@ -39,59 +53,62 @@ const struct berval slap_empty_bv = { 0, "" };
 
 #define        AVA_PRIVATE( ava ) ( ( AttributeDescription * )(ava)->la_private )
 
-/*
- * In-place, schema-aware validation of the
- * structural representation of a distinguished name.
- */
+int slap_DN_strict = SLAP_AD_NOINSERT;
+
 static int
-LDAPDN_validate( LDAPDN *dn )
+LDAPRDN_validate( LDAPRDN rdn )
 {
-       int             iRDN;
+       int             iAVA;
        int             rc;
 
-       assert( dn );
-
-       for ( iRDN = 0; dn[ 0 ][ iRDN ]; iRDN++ ) {
-               LDAPRDN         *rdn = dn[ 0 ][ iRDN ];
-               int             iAVA;
+       assert( rdn != NULL );
 
-               assert( rdn );
+       for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
+               LDAPAVA                 *ava = rdn[ iAVA ];
+               AttributeDescription    *ad;
+               slap_syntax_validate_func *validate = NULL;
 
-               for ( iAVA = 0; rdn[ 0 ][ iAVA ]; iAVA++ ) {
-                       LDAPAVA                 *ava = rdn[ 0 ][ iAVA ];
-                       AttributeDescription    *ad;
-                       slap_syntax_validate_func *validate = NULL;
-
-                       assert( ava );
-                       
-                       if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
-                               const char      *text = NULL;
+               assert( ava != NULL );
+               
+               if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
+                       const char      *text = NULL;
 
-                               rc = slap_bv2ad( &ava->la_attr, &ad, &text );
+                       rc = slap_bv2ad( &ava->la_attr, &ad, &text );
+                       if ( rc != LDAP_SUCCESS ) {
+                               rc = slap_bv2undef_ad( &ava->la_attr,
+                                       &ad, &text,
+                                       SLAP_AD_PROXIED|slap_DN_strict );
                                if ( rc != LDAP_SUCCESS ) {
                                        return LDAP_INVALID_SYNTAX;
                                }
-
-                               ava->la_private = ( void * )ad;
                        }
 
-                       /* 
-                        * Replace attr oid/name with the canonical name
-                        */
-                       ava->la_attr = ad->ad_cname;
+                       ava->la_private = ( void * )ad;
+               }
+
+               /*
+                * Do not allow X-ORDERED 'VALUES' naming attributes
+                */
+               if ( ad->ad_type->sat_flags & SLAP_AT_ORDERED_VAL ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               /* 
+                * Replace attr oid/name with the canonical name
+                */
+               ava->la_attr = ad->ad_cname;
 
-                       validate = ad->ad_type->sat_syntax->ssyn_validate;
+               validate = ad->ad_type->sat_syntax->ssyn_validate;
 
-                       if ( validate ) {
-                               /*
-                                * validate value by validate function
-                                */
-                               rc = ( *validate )( ad->ad_type->sat_syntax,
-                                       &ava->la_value );
+               if ( validate ) {
+                       /*
+                        * validate value by validate function
+                        */
+                       rc = ( *validate )( ad->ad_type->sat_syntax,
+                               &ava->la_value );
                        
-                               if ( rc != LDAP_SUCCESS ) {
-                                       return LDAP_INVALID_SYNTAX;
-                               }
+                       if ( rc != LDAP_SUCCESS ) {
+                               return LDAP_INVALID_SYNTAX;
                        }
                }
        }
@@ -99,6 +116,28 @@ LDAPDN_validate( LDAPDN *dn )
        return LDAP_SUCCESS;
 }
 
+/*
+ * In-place, schema-aware validation of the
+ * structural representation of a distinguished name.
+ */
+static int
+LDAPDN_validate( LDAPDN dn )
+{
+       int             iRDN;
+       int             rc;
+
+       assert( dn != NULL );
+
+       for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
+               rc = LDAPRDN_validate( dn[ iRDN ] );
+               if ( rc != LDAP_SUCCESS ) {
+                       return rc;
+               }
+       }
+
+       return LDAP_SUCCESS;
+}
+
 /*
  * dn validate routine
  */
@@ -108,338 +147,479 @@ dnValidate(
        struct berval *in )
 {
        int             rc;
-       LDAPDN          *dn = NULL;
+       LDAPDN          dn = NULL;
 
-       assert( in );
+       assert( in != NULL );
 
        if ( in->bv_len == 0 ) {
-               return( LDAP_SUCCESS );
+               return LDAP_SUCCESS;
+
+       } else if ( in->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
        }
 
-       /* FIXME: str2dn should take a bv and handle this */
-       if( strlen( in->bv_val ) != in->bv_len ) {
+       rc = ldap_bv2dn( in, &dn, LDAP_DN_FORMAT_LDAP );
+       if ( rc != LDAP_SUCCESS ) {
                return LDAP_INVALID_SYNTAX;
        }
 
-       rc = ldap_str2dn( in->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+       assert( strlen( in->bv_val ) == in->bv_len );
 
        /*
         * Schema-aware validate
         */
-       if ( rc == LDAP_SUCCESS ) {
-               rc = LDAPDN_validate( dn );
-               ldap_dnfree( dn );
+       rc = LDAPDN_validate( dn );
+       ldap_dnfree( dn );
+
+       if ( rc != LDAP_SUCCESS ) {
+               return LDAP_INVALID_SYNTAX;
        }
-       
+
+       return LDAP_SUCCESS;
+}
+
+int
+rdnValidate(
+       Syntax *syntax,
+       struct berval *in )
+{
+       int             rc;
+       LDAPRDN         rdn;
+       char*           p;
+
+       assert( in != NULL );
+       if ( in->bv_len == 0 ) {
+               return LDAP_SUCCESS;
+
+       } else if ( in->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
+       }
+
+       rc = ldap_bv2rdn_x( in , &rdn, (char **) &p,
+                               LDAP_DN_FORMAT_LDAP, NULL);
        if ( rc != LDAP_SUCCESS ) {
-               return( LDAP_INVALID_SYNTAX );
+               return LDAP_INVALID_SYNTAX;
        }
 
-       return( LDAP_SUCCESS );
+       assert( strlen( in->bv_val ) == in->bv_len );
+
+       /*
+        * Schema-aware validate
+        */
+       rc = LDAPRDN_validate( rdn );
+       ldap_rdnfree( rdn );
+
+       if ( rc != LDAP_SUCCESS ) {
+               return LDAP_INVALID_SYNTAX;
+       }
+
+       return LDAP_SUCCESS;
 }
 
+
 /*
  * AVA sorting inside a RDN
  *
- * rule: sort attributeTypes in alphabetical order; in case of multiple
- * occurrences of the same attributeType, sort values in byte order
- * (use memcmp, which implies alphabetical order in case of IA5 value;
- * this should guarantee the repeatability of the operation).
+ * Rule: sort attributeTypes in alphabetical order.
  *
  * Note: the sorting can be slightly improved by sorting first
  * by attribute type length, then by alphabetical order.
  *
- * uses a linear search; should be fine since the number of AVAs in
+ * uses an insertion sort; should be fine since the number of AVAs in
  * a RDN should be limited.
  */
-static void
-AVA_Sort( LDAPRDN *rdn, int iAVA )
+static int
+AVA_Sort( LDAPRDN rdn, int nAVAs )
 {
+       LDAPAVA *ava_i;
        int             i;
-       LDAPAVA         *ava_in = rdn[ 0 ][ iAVA ];
 
-       assert( rdn );
-       assert( ava_in );
-       
-       for ( i = 0; i < iAVA; i++ ) {
-               LDAPAVA         *ava = rdn[ 0 ][ i ];
-               int             a, j;
-
-               assert( ava );
+       assert( rdn != NULL );
 
-               a = strcmp( ava_in->la_attr.bv_val, ava->la_attr.bv_val );
+       for ( i = 1; i < nAVAs; i++ ) {
+               LDAPAVA *ava_j;
+               int j;
 
-               if ( a > 0 ) {
-                       break;
-               }
+               ava_i = rdn[ i ];
+               for ( j = i-1; j >=0; j-- ) {
+                       int a;
 
-               while ( a == 0 ) {
-                       int             v, d;
+                       ava_j = rdn[ j ];
+                       a = strcmp( ava_i->la_attr.bv_val, ava_j->la_attr.bv_val );
 
-                       d = ava_in->la_value.bv_len - ava->la_value.bv_len;
+                       /* RFC4512 does not allow multiple AVAs
+                        * with the same attribute type in RDN (ITS#5968) */
+                       if ( a == 0 )
+                               return LDAP_INVALID_DN_SYNTAX;
 
-                       v = memcmp( ava_in->la_value.bv_val, 
-                                       ava->la_value.bv_val,
-                                       d <= 0 ? ava_in->la_value.bv_len 
-                                               : ava->la_value.bv_len );
-
-                       if ( v == 0 && d != 0 ) {
-                               v = d;
-                       }
-
-                       if ( v <= 0 ) {
-                               /* 
-                                * got it!
-                                */
+                       if ( a > 0 )
                                break;
-                       }
-
-                       if ( ++i == iAVA ) {
-                               /*
-                                * already sorted
-                                */
-                               return;
-                       }
 
-                       ava = rdn[ 0 ][ i ];
-                       a = strcmp( ava_in->la_attr.bv_val, 
-                                       ava->la_attr.bv_val );
+                       rdn[ j+1 ] = rdn[ j ];
                }
-
-               /*
-                * move ahead
-                */
-               for ( j = iAVA; j > i; j-- ) {
-                       rdn[ 0 ][ j ] = rdn[ 0 ][ j - 1 ];
-               }
-               rdn[ 0 ][ i ] = ava_in;
-
-               return;
+               rdn[ j+1 ] = ava_i;
        }
+       return LDAP_SUCCESS;
 }
 
-/*
- * In-place, schema-aware normalization / "pretty"ing of the
- * structural representation of a distinguished name.
- */
 static int
-LDAPDN_rewrite( LDAPDN *dn, unsigned flags )
+LDAPRDN_rewrite( LDAPRDN rdn, unsigned flags, void *ctx )
 {
-       int             iRDN;
-       int             rc;
 
-       assert( dn );
+       int rc, iAVA, do_sort = 0;
 
-       for ( iRDN = 0; dn[ 0 ][ iRDN ]; iRDN++ ) {
-               LDAPRDN         *rdn = dn[ 0 ][ iRDN ];
-               int             iAVA;
+       for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
+               LDAPAVA                 *ava = rdn[ iAVA ];
+               AttributeDescription    *ad;
+               slap_syntax_validate_func *validf = NULL;
+               slap_mr_normalize_func *normf = NULL;
+               slap_syntax_transform_func *transf = NULL;
+               MatchingRule *mr = NULL;
+               struct berval           bv = BER_BVNULL;
 
-               assert( rdn );
+               assert( ava != NULL );
 
-               for ( iAVA = 0; rdn[ 0 ][ iAVA ]; iAVA++ ) {
-                       LDAPAVA                 *ava = rdn[ 0 ][ iAVA ];
-                       AttributeDescription    *ad;
-                       slap_syntax_transform_func *transf = NULL;
-                       MatchingRule *mr;
-                       struct berval           bv = { 0, NULL };
-                       int                     do_sort = 0;
+               if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
+                       const char      *text = NULL;
 
-                       assert( ava );
-
-                       if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
-                               const char      *text = NULL;
-
-                               rc = slap_bv2ad( &ava->la_attr, &ad, &text );
+                       rc = slap_bv2ad( &ava->la_attr, &ad, &text );
+                       if ( rc != LDAP_SUCCESS ) {
+                               rc = slap_bv2undef_ad( &ava->la_attr,
+                                       &ad, &text,
+                                       SLAP_AD_PROXIED|slap_DN_strict );
                                if ( rc != LDAP_SUCCESS ) {
                                        return LDAP_INVALID_SYNTAX;
                                }
-                               
-                               ava->la_private = ( void * )ad;
-                               do_sort = 1;
                        }
+                       
+                       ava->la_private = ( void * )ad;
+                       do_sort = 1;
+               }
 
-                       /* 
-                        * Replace attr oid/name with the canonical name
-                        */
-                       ava->la_attr = ad->ad_cname;
+               /* 
+                * Replace attr oid/name with the canonical name
+                */
+               ava->la_attr = ad->ad_cname;
 
-                       if( ava->la_flags & LDAP_AVA_BINARY ) {
-                               /* AVA is binary encoded, don't muck with it */
-                               transf = NULL;
-                               mr = NULL;
+               if( ava->la_flags & LDAP_AVA_BINARY ) {
+                       /* AVA is binary encoded, not supported */
+                       return LDAP_INVALID_SYNTAX;
 
-                       } else if( flags & SLAP_LDAPDN_PRETTY ) {
-                               transf = ad->ad_type->sat_syntax->ssyn_pretty;
-                               mr = NULL;
-                       } else {
-                               transf = ad->ad_type->sat_syntax->ssyn_normalize;
-                               mr = ad->ad_type->sat_equality;
-                       }
+                       /* Do not allow X-ORDERED 'VALUES' naming attributes */
+               } else if( ad->ad_type->sat_flags & SLAP_AT_ORDERED_VAL ) {
+                       return LDAP_INVALID_SYNTAX;
 
-                       if ( transf ) {
-                               /*
-                                * transform value by normalize/pretty function
-                                *      if value is empty, use empty_bv
-                                */
-                               rc = ( *transf )( ad->ad_type->sat_syntax,
-                                       ava->la_value.bv_len
-                                               ? &ava->la_value
-                                               : (struct berval *) &slap_empty_bv,
-                                       &bv );
-                       
-                               if ( rc != LDAP_SUCCESS ) {
-                                       return LDAP_INVALID_SYNTAX;
-                               }
+               } else if( flags & SLAP_LDAPDN_PRETTY ) {
+                       transf = ad->ad_type->sat_syntax->ssyn_pretty;
+                       if( !transf ) {
+                               validf = ad->ad_type->sat_syntax->ssyn_validate;
                        }
+               } else { /* normalization */
+                       validf = ad->ad_type->sat_syntax->ssyn_validate;
+                       mr = ad->ad_type->sat_equality;
+                       if( mr && (!( mr->smr_usage & SLAP_MR_MUTATION_NORMALIZER ))) {
+                               normf = mr->smr_normalize;
+                       }
+               }
 
-                       if( mr && ( mr->smr_usage & SLAP_MR_DN_FOLD ) ) {
-                               char *s = bv.bv_val;
+               if ( validf ) {
+                       /* validate value before normalization */
+                       rc = ( *validf )( ad->ad_type->sat_syntax,
+                               ava->la_value.bv_len
+                                       ? &ava->la_value
+                                       : (struct berval *) &slap_empty_bv );
 
-                               ber_str2bv( UTF8normalize( bv.bv_val ? &bv
-                                       : &ava->la_value, LDAP_UTF8_CASEFOLD ),
-                                       0, 0, &bv );
-                               free( s );
+                       if ( rc != LDAP_SUCCESS ) {
+                               return LDAP_INVALID_SYNTAX;
                        }
+               }
 
-                       if( bv.bv_val ) {
-                               free( ava->la_value.bv_val );
-                               ava->la_value = bv;
+               if ( transf ) {
+                       /*
+                        * transform value by pretty function
+                        *      if value is empty, use empty_bv
+                        */
+                       rc = ( *transf )( ad->ad_type->sat_syntax,
+                               ava->la_value.bv_len
+                                       ? &ava->la_value
+                                       : (struct berval *) &slap_empty_bv,
+                               &bv, ctx );
+               
+                       if ( rc != LDAP_SUCCESS ) {
+                               return LDAP_INVALID_SYNTAX;
                        }
+               }
 
-                       if( do_sort ) AVA_Sort( rdn, iAVA );
+               if ( normf ) {
+                       /*
+                        * normalize value
+                        *      if value is empty, use empty_bv
+                        */
+                       rc = ( *normf )(
+                               SLAP_MR_VALUE_OF_ASSERTION_SYNTAX,
+                               ad->ad_type->sat_syntax,
+                               mr,
+                               ava->la_value.bv_len
+                                       ? &ava->la_value
+                                       : (struct berval *) &slap_empty_bv,
+                               &bv, ctx );
+               
+                       if ( rc != LDAP_SUCCESS ) {
+                               return LDAP_INVALID_SYNTAX;
+                       }
+               }
+
+
+               if( bv.bv_val ) {
+                       if ( ava->la_flags & LDAP_AVA_FREE_VALUE )
+                               ber_memfree_x( ava->la_value.bv_val, ctx );
+                       ava->la_value = bv;
+                       ava->la_flags |= LDAP_AVA_FREE_VALUE;
+               }
+               /* reject empty values */
+               if (!ava->la_value.bv_len) {
+                       return LDAP_INVALID_SYNTAX;
                }
        }
+       rc = LDAP_SUCCESS;
 
-       return LDAP_SUCCESS;
+       if ( do_sort ) {
+               rc = AVA_Sort( rdn, iAVA );
+       }
+
+       return rc;
 }
 
 /*
- * dn normalize routine
+ * In-place, schema-aware normalization / "pretty"ing of the
+ * structural representation of a distinguished name.
  */
+static int
+LDAPDN_rewrite( LDAPDN dn, unsigned flags, void *ctx )
+{
+       int             iRDN;
+       int             rc;
+
+       assert( dn != NULL );
+
+       for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
+               rc = LDAPRDN_rewrite( dn[ iRDN ], flags, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return rc;
+               }
+       }
+
+       return LDAP_SUCCESS;
+}
+
 int
 dnNormalize(
-       Syntax *syntax,
-       struct berval *val,
-       struct berval **normalized )
+    slap_mask_t use,
+    Syntax *syntax,
+    MatchingRule *mr,
+    struct berval *val,
+    struct berval *out,
+    void *ctx)
 {
-       struct berval *out;
-       int rc;
+       assert( val != NULL );
+       assert( out != NULL );
 
-       assert( normalized && *normalized == NULL );
+       Debug( LDAP_DEBUG_TRACE, ">>> dnNormalize: <%s>\n", val->bv_val ? val->bv_val : "", 0, 0 );
 
-       out = ch_malloc( sizeof( struct berval ) );
-       rc = dnNormalize2( syntax, val, out );
-       if ( rc != LDAP_SUCCESS )
-               free( out );
-       else
-               *normalized = out;
-       return rc;
+       if ( val->bv_len != 0 ) {
+               LDAPDN          dn = NULL;
+               int             rc;
+
+               /*
+                * Go to structural representation
+                */
+               rc = ldap_bv2dn_x( val, &dn, LDAP_DN_FORMAT_LDAP, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               assert( strlen( val->bv_val ) == val->bv_len );
+
+               /*
+                * Schema-aware rewrite
+                */
+               if ( LDAPDN_rewrite( dn, 0, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               /*
+                * Back to string representation
+                */
+               rc = ldap_dn2bv_x( dn, out,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
+
+               ldap_dnfree_x( dn, ctx );
+
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+       } else {
+               ber_dupbv_x( out, val, ctx );
+       }
+
+       Debug( LDAP_DEBUG_TRACE, "<<< dnNormalize: <%s>\n", out->bv_val ? out->bv_val : "", 0, 0 );
+
+       return LDAP_SUCCESS;
 }
 
 int
-dnNormalize2(
-       Syntax *syntax,
-       struct berval *val,
-       struct berval *out )
+rdnNormalize(
+    slap_mask_t use,
+    Syntax *syntax,
+    MatchingRule *mr,
+    struct berval *val,
+    struct berval *out,
+    void *ctx)
 {
-       assert( val );
-       assert( out );
-
-       Debug( LDAP_DEBUG_TRACE, ">>> dnNormalize: <%s>\n", val->bv_val, 0, 0 );
+       assert( val != NULL );
+       assert( out != NULL );
 
+       Debug( LDAP_DEBUG_TRACE, ">>> dnNormalize: <%s>\n", val->bv_val ? val->bv_val : "", 0, 0 );
        if ( val->bv_len != 0 ) {
-               LDAPDN          *dn = NULL;
+               LDAPRDN         rdn = NULL;
                int             rc;
+               char*           p;
 
                /*
                 * Go to structural representation
                 */
-               rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+               rc = ldap_bv2rdn_x( val , &rdn, (char **) &p,
+                                       LDAP_DN_FORMAT_LDAP, ctx);
+
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
 
+               assert( strlen( val->bv_val ) == val->bv_len );
+
                /*
                 * Schema-aware rewrite
                 */
-               if ( LDAPDN_rewrite( dn, 0 ) != LDAP_SUCCESS ) {
-                       ldap_dnfree( dn );
+               if ( LDAPRDN_rewrite( rdn, 0, ctx ) != LDAP_SUCCESS ) {
+                       ldap_rdnfree_x( rdn, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
                /*
                 * Back to string representation
                 */
-               rc = ldap_dn2bv( dn, out, LDAP_DN_FORMAT_LDAPV3 );
+               rc = ldap_rdn2bv_x( rdn, out,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
-               ldap_dnfree( dn );
+               ldap_rdnfree_x( rdn, ctx );
 
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
        } else {
-               ber_dupbv( out, val );
+               ber_dupbv_x( out, val, ctx );
        }
 
-       Debug( LDAP_DEBUG_TRACE, "<<< dnNormalize: <%s>\n", out->bv_val, 0, 0 );
+       Debug( LDAP_DEBUG_TRACE, "<<< dnNormalize: <%s>\n", out->bv_val ? out->bv_val : "", 0, 0 );
 
        return LDAP_SUCCESS;
 }
 
-/*
- * dn "pretty"ing routine
- */
 int
 dnPretty(
        Syntax *syntax,
        struct berval *val,
-       struct berval **pretty)
+       struct berval *out,
+       void *ctx)
 {
-       struct berval *out;
-       int rc;
+       assert( val != NULL );
+       assert( out != NULL );
 
-       assert( pretty && *pretty == NULL );
+       Debug( LDAP_DEBUG_TRACE, ">>> dnPretty: <%s>\n", val->bv_val ? val->bv_val : "", 0, 0 );
 
-       out = ch_malloc( sizeof( struct berval ) );
-       rc = dnPretty2( syntax, val, out );
-       if ( rc != LDAP_SUCCESS )
-               free( out );
-       else
-               *pretty = out;
-       return rc;
+       if ( val->bv_len == 0 ) {
+               ber_dupbv_x( out, val, ctx );
+
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
+
+       } else {
+               LDAPDN          dn = NULL;
+               int             rc;
+
+               /* FIXME: should be liberal in what we accept */
+               rc = ldap_bv2dn_x( val, &dn, LDAP_DN_FORMAT_LDAP, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               assert( strlen( val->bv_val ) == val->bv_len );
+
+               /*
+                * Schema-aware rewrite
+                */
+               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               /* FIXME: not sure why the default isn't pretty */
+               /* RE: the default is the form that is used as
+                * an internal representation; the pretty form
+                * is a variant */
+               rc = ldap_dn2bv_x( dn, out,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
+
+               ldap_dnfree_x( dn, ctx );
+
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+       }
+
+       Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val ? out->bv_val : "", 0, 0 );
+
+       return LDAP_SUCCESS;
 }
 
 int
-dnPretty2(
+rdnPretty(
        Syntax *syntax,
        struct berval *val,
-       struct berval *out)
+       struct berval *out,
+       void *ctx)
 {
-       assert( val );
-       assert( out );
+       assert( val != NULL );
+       assert( out != NULL );
 
-       Debug( LDAP_DEBUG_TRACE, ">>> dnPretty: <%s>\n", val->bv_val, 0, 0 );
+       Debug( LDAP_DEBUG_TRACE, ">>> rdnPretty: <%s>\n", val->bv_val ? val->bv_val : "", 0, 0 );
 
-       if ( val->bv_len != 0 ) {
-               LDAPDN          *dn = NULL;
-               int             rc;
+       if ( val->bv_len == 0 ) {
+               ber_dupbv_x( out, val, ctx );
 
-               /* FIXME: str2dn should take a bv and handle this */
-               if( strlen( val->bv_val ) != val->bv_len ) {
-                       return LDAP_INVALID_SYNTAX;
-               }
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
+
+       } else {
+               LDAPRDN         rdn = NULL;
+               int             rc;
+               char*           p;
 
                /* FIXME: should be liberal in what we accept */
-               rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+               rc = ldap_bv2rdn_x( val , &rdn, (char **) &p,
+                                       LDAP_DN_FORMAT_LDAP, ctx);
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
 
+               assert( strlen( val->bv_val ) == val->bv_len );
+
                /*
                 * Schema-aware rewrite
                 */
-               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY ) != LDAP_SUCCESS ) {
-                       ldap_dnfree( dn );
+               if ( LDAPRDN_rewrite( rdn, SLAP_LDAPDN_PRETTY, ctx ) != LDAP_SUCCESS ) {
+                       ldap_rdnfree_x( rdn, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
@@ -447,19 +627,67 @@ dnPretty2(
                /* RE: the default is the form that is used as
                 * an internal representation; the pretty form
                 * is a variant */
-               rc = ldap_dn2bv( dn, out,
-                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
+               rc = ldap_rdn2bv_x( rdn, out,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
-               ldap_dnfree( dn );
+               ldap_rdnfree_x( rdn, ctx );
 
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
+       }
+
+       Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val ? out->bv_val : "", 0, 0 );
+
+       return LDAP_SUCCESS;
+}
+
+
+int
+dnPrettyNormalDN(
+       Syntax *syntax,
+       struct berval *val,
+       LDAPDN *dn,
+       int flags,
+       void *ctx )
+{
+       assert( val != NULL );
+       assert( dn != NULL );
+
+       Debug( LDAP_DEBUG_TRACE, ">>> dn%sDN: <%s>\n", 
+                       flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal", 
+                       val->bv_val ? val->bv_val : "", 0 );
+
+       if ( val->bv_len == 0 ) {
+               return LDAP_SUCCESS;
+
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               return LDAP_INVALID_SYNTAX;
+
        } else {
-               ber_dupbv( out, val );
+               int             rc;
+
+               /* FIXME: should be liberal in what we accept */
+               rc = ldap_bv2dn_x( val, dn, LDAP_DN_FORMAT_LDAP, ctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               assert( strlen( val->bv_val ) == val->bv_len );
+
+               /*
+                * Schema-aware rewrite
+                */
+               if ( LDAPDN_rewrite( *dn, flags, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( *dn, ctx );
+                       *dn = NULL;
+                       return LDAP_INVALID_SYNTAX;
+               }
        }
 
-       Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val, 0, 0 );
+       Debug( LDAP_DEBUG_TRACE, "<<< dn%sDN\n", 
+                       flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal",
+                       0, 0 );
 
        return LDAP_SUCCESS;
 }
@@ -472,16 +700,24 @@ dnPrettyNormal(
        Syntax *syntax,
        struct berval *val,
        struct berval *pretty,
-       struct berval *normal)
+       struct berval *normal,
+       void *ctx)
 {
-       Debug( LDAP_DEBUG_TRACE, ">>> dnPrettyNormal: <%s>\n", val->bv_val, 0, 0 );
+       assert( val != NULL );
+       assert( pretty != NULL );
+       assert( normal != NULL );
+       Debug( LDAP_DEBUG_TRACE, ">>> dnPrettyNormal: <%s>\n", val->bv_val ? val->bv_val : "", 0, 0 );
 
-       assert( val );
-       assert( pretty );
-       assert( normal );
+       if ( val->bv_len == 0 ) {
+               ber_dupbv_x( pretty, val, ctx );
+               ber_dupbv_x( normal, val, ctx );
 
-       if ( val->bv_len != 0 ) {
-               LDAPDN          *dn = NULL;
+       } else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+               /* too big */
+               return LDAP_INVALID_SYNTAX;
+
+       } else {
+               LDAPDN          dn = NULL;
                int             rc;
 
                pretty->bv_val = NULL;
@@ -489,57 +725,53 @@ dnPrettyNormal(
                pretty->bv_len = 0;
                normal->bv_len = 0;
 
-               /* FIXME: str2dn should take a bv and handle this */
-               if( strlen( val->bv_val ) != val->bv_len ) {
-                       return LDAP_INVALID_SYNTAX;
-               }
-
                /* FIXME: should be liberal in what we accept */
-               rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+               rc = ldap_bv2dn_x( val, &dn, LDAP_DN_FORMAT_LDAP, ctx );
                if ( rc != LDAP_SUCCESS ) {
                        return LDAP_INVALID_SYNTAX;
                }
 
+               assert( strlen( val->bv_val ) == val->bv_len );
+
                /*
                 * Schema-aware rewrite
                 */
-               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY ) != LDAP_SUCCESS ) {
-                       ldap_dnfree( dn );
+               if ( LDAPDN_rewrite( dn, SLAP_LDAPDN_PRETTY, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
-               rc = ldap_dn2bv( dn, pretty,
-                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
+               rc = ldap_dn2bv_x( dn, pretty,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
                if ( rc != LDAP_SUCCESS ) {
-                       ldap_dnfree( dn );
+                       ldap_dnfree_x( dn, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
-               if ( LDAPDN_rewrite( dn, 0 ) != LDAP_SUCCESS ) {
-                       ldap_dnfree( dn );
-                       free( pretty->bv_val );
+               if ( LDAPDN_rewrite( dn, 0, ctx ) != LDAP_SUCCESS ) {
+                       ldap_dnfree_x( dn, ctx );
+                       ber_memfree_x( pretty->bv_val, ctx );
                        pretty->bv_val = NULL;
                        pretty->bv_len = 0;
                        return LDAP_INVALID_SYNTAX;
                }
 
-               rc = ldap_dn2bv( dn, normal, LDAP_DN_FORMAT_LDAPV3 );
+               rc = ldap_dn2bv_x( dn, normal,
+                       LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY, ctx );
 
-               ldap_dnfree( dn );
+               ldap_dnfree_x( dn, ctx );
                if ( rc != LDAP_SUCCESS ) {
-                       free( pretty->bv_val );
+                       ber_memfree_x( pretty->bv_val, ctx );
                        pretty->bv_val = NULL;
                        pretty->bv_len = 0;
                        return LDAP_INVALID_SYNTAX;
                }
-       } else {
-               ber_dupbv( pretty, val );
-               ber_dupbv( normal, val );
        }
 
        Debug( LDAP_DEBUG_TRACE, "<<< dnPrettyNormal: <%s>, <%s>\n",
-               pretty->bv_val, normal->bv_val, 0 );
+               pretty->bv_val ? pretty->bv_val : "",
+               normal->bv_val ? normal->bv_val : "", 0 );
 
        return LDAP_SUCCESS;
 }
@@ -559,34 +791,167 @@ dnMatch(
        int match;
        struct berval *asserted = (struct berval *) assertedValue;
 
-       assert( matchp );
-       assert( value );
-       assert( assertedValue );
+       assert( matchp != NULL );
+       assert( value != NULL );
+       assert( assertedValue != NULL );
+       assert( !BER_BVISNULL( value ) );
+       assert( !BER_BVISNULL( asserted ) );
        
        match = value->bv_len - asserted->bv_len;
 
        if ( match == 0 ) {
-               match = strcmp( value->bv_val, asserted->bv_val );
+               match = memcmp( value->bv_val, asserted->bv_val, 
+                               value->bv_len );
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG(( "schema", LDAP_LEVEL_ENTRY,
-               "dnMatch: %d\n    %s\n    %s\n", match,
-               value->bv_val, asserted->bv_val ));
-#else
        Debug( LDAP_DEBUG_ARGS, "dnMatch %d\n\t\"%s\"\n\t\"%s\"\n",
                match, value->bv_val, asserted->bv_val );
-#endif
 
        *matchp = match;
-       return( LDAP_SUCCESS );
+       return LDAP_SUCCESS;
 }
 
+/*
+ * dnRelativeMatch routine
+ */
+int
+dnRelativeMatch(
+       int *matchp,
+       slap_mask_t flags,
+       Syntax *syntax,
+       MatchingRule *mr,
+       struct berval *value,
+       void *assertedValue )
+{
+       int match;
+       struct berval *asserted = (struct berval *) assertedValue;
+
+       assert( matchp != NULL );
+       assert( value != NULL );
+       assert( assertedValue != NULL );
+       assert( !BER_BVISNULL( value ) );
+       assert( !BER_BVISNULL( asserted ) );
+
+       if( mr == slap_schema.si_mr_dnSubtreeMatch ) {
+               if( asserted->bv_len > value->bv_len ) {
+                       match = -1;
+               } else if ( asserted->bv_len == value->bv_len ) {
+                       match = memcmp( value->bv_val, asserted->bv_val, 
+                               value->bv_len );
+               } else {
+                       if( DN_SEPARATOR(
+                               value->bv_val[value->bv_len - asserted->bv_len - 1] ))
+                       {
+                               match = memcmp(
+                                       &value->bv_val[value->bv_len - asserted->bv_len],
+                                       asserted->bv_val, 
+                                       asserted->bv_len );
+                       } else {
+                               match = 1;
+                       }
+               }
+
+               *matchp = match;
+               return LDAP_SUCCESS;
+       }
+
+       if( mr == slap_schema.si_mr_dnSuperiorMatch ) {
+               asserted = value;
+               value = (struct berval *) assertedValue;
+               mr = slap_schema.si_mr_dnSubordinateMatch;
+       }
+
+       if( mr == slap_schema.si_mr_dnSubordinateMatch ) {
+               if( asserted->bv_len >= value->bv_len ) {
+                       match = -1;
+               } else {
+                       if( DN_SEPARATOR(
+                               value->bv_val[value->bv_len - asserted->bv_len - 1] ))
+                       {
+                               match = memcmp(
+                                       &value->bv_val[value->bv_len - asserted->bv_len],
+                                       asserted->bv_val, 
+                                       asserted->bv_len );
+                       } else {
+                               match = 1;
+                       }
+               }
+
+               *matchp = match;
+               return LDAP_SUCCESS;
+       }
+
+       if( mr == slap_schema.si_mr_dnOneLevelMatch ) {
+               if( asserted->bv_len >= value->bv_len ) {
+                       match = -1;
+               } else {
+                       if( DN_SEPARATOR(
+                               value->bv_val[value->bv_len - asserted->bv_len - 1] ))
+                       {
+                               match = memcmp(
+                                       &value->bv_val[value->bv_len - asserted->bv_len],
+                                       asserted->bv_val, 
+                                       asserted->bv_len );
+
+                               if( !match ) {
+                                       struct berval rdn;
+                                       rdn.bv_val = value->bv_val;
+                                       rdn.bv_len = value->bv_len - asserted->bv_len - 1;
+                                       match = dnIsOneLevelRDN( &rdn ) ? 0 : 1;
+                               }
+                       } else {
+                               match = 1;
+                       }
+               }
+
+               *matchp = match;
+               return LDAP_SUCCESS;
+       }
+
+       /* should not be reachable */
+       assert( 0 );
+       return LDAP_OTHER;
+}
+
+int
+rdnMatch(
+       int *matchp,
+       slap_mask_t flags,
+       Syntax *syntax,
+       MatchingRule *mr,
+       struct berval *value,
+       void *assertedValue )
+{
+       int match;
+       struct berval *asserted = (struct berval *) assertedValue;
+
+       assert( matchp != NULL );
+       assert( value != NULL );
+       assert( assertedValue != NULL );
+       
+       match = value->bv_len - asserted->bv_len;
+
+       if ( match == 0 ) {
+               match = memcmp( value->bv_val, asserted->bv_val, 
+                               value->bv_len );
+       }
+
+       Debug( LDAP_DEBUG_ARGS, "rdnMatch %d\n\t\"%s\"\n\t\"%s\"\n",
+               match, value->bv_val, asserted->bv_val );
+
+       *matchp = match;
+       return LDAP_SUCCESS;
+}
+
+
 /*
  * dnParent - dn's parent, in-place
- *
  * note: the incoming dn is assumed to be normalized/prettyfied,
  * so that escaped rdn/ava separators are in '\'+hexpair form
+ *
+ * note: "dn" and "pdn" can point to the same berval;
+ * beware that, in this case, the pointer to the original buffer
+ * will get lost.
  */
 void
 dnParent( 
@@ -595,11 +960,12 @@ dnParent(
 {
        char    *p;
 
-       p = strchr( dn->bv_val, ',' );
+       p = ber_bvchr( dn, ',' );
 
        /* one-level dn */
        if ( p == NULL ) {
-               *pdn = slap_empty_bv;
+               pdn->bv_val = dn->bv_val + dn->bv_len;
+               pdn->bv_len = 0;
                return;
        }
 
@@ -607,8 +973,35 @@ dnParent(
        p++;
 
        assert( ATTR_LEADCHAR( p[ 0 ] ) );
-       pdn->bv_val = p;
        pdn->bv_len = dn->bv_len - (p - dn->bv_val);
+       pdn->bv_val = p;
+
+       return;
+}
+
+/*
+ * dnRdn - dn's rdn, in-place
+ * note: the incoming dn is assumed to be normalized/prettyfied,
+ * so that escaped rdn/ava separators are in '\'+hexpair form
+ */
+void
+dnRdn( 
+       struct berval   *dn, 
+       struct berval   *rdn )
+{
+       char    *p;
+
+       *rdn = *dn;
+       p = ber_bvchr( dn, ',' );
+
+       /* one-level dn */
+       if ( p == NULL ) {
+               return;
+       }
+
+       assert( DN_SEPARATOR( p[ 0 ] ) );
+       assert( ATTR_LEADCHAR( p[ 1 ] ) );
+       rdn->bv_len = p - dn->bv_val;
 
        return;
 }
@@ -616,44 +1009,43 @@ dnParent(
 int
 dnExtractRdn( 
        struct berval   *dn, 
-       struct berval   *rdn )
+       struct berval   *rdn,
+       void *ctx )
 {
-       LDAPRDN         *tmpRDN;
+       LDAPRDN         tmpRDN;
        const char      *p;
        int             rc;
 
-       assert( dn );
-       assert( rdn );
+       assert( dn != NULL );
+       assert( rdn != NULL );
 
        if( dn->bv_len == 0 ) {
                return LDAP_OTHER;
        }
 
-       rc = ldap_str2rdn( dn->bv_val, &tmpRDN, (char **)&p, LDAP_DN_FORMAT_LDAP );
+       rc = ldap_bv2rdn_x( dn, &tmpRDN, (char **)&p, LDAP_DN_FORMAT_LDAP, ctx );
        if ( rc != LDAP_SUCCESS ) {
                return rc;
        }
 
-       rc = ldap_rdn2bv( tmpRDN, rdn, LDAP_DN_FORMAT_LDAPV3 );
-       ldap_rdnfree( tmpRDN );
-       if ( rc != LDAP_SUCCESS ) {
-               return rc;
-       }
+       rc = ldap_rdn2bv_x( tmpRDN, rdn, LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY,
+               ctx );
 
-       return LDAP_SUCCESS;
+       ldap_rdnfree_x( tmpRDN, ctx );
+       return rc;
 }
 
 /*
  * We can assume the input is a prettied or normalized DN
  */
-int 
+ber_len_t
 dn_rdnlen(
        Backend         *be,
        struct berval   *dn_in )
 {
        const char      *p;
 
-       assert( dn_in );
+       assert( dn_in != NULL );
 
        if ( dn_in == NULL ) {
                return 0;
@@ -667,9 +1059,9 @@ dn_rdnlen(
                return 0;
        }
 
-       p = strchr( dn_in->bv_val, ',' );
+       p = ber_bvchr( dn_in, ',' );
 
-       return p ? p - dn_in->bv_val : dn_in->bv_len;
+       return p ? (ber_len_t) (p - dn_in->bv_val) : dn_in->bv_len;
 }
 
 
@@ -679,18 +1071,19 @@ dn_rdnlen(
  * LDAP_INVALID_SYNTAX otherwise (including a sequence of rdns)
  */
 int
-rdnValidate( struct berval *rdn )
+rdn_validate( struct berval *rdn )
 {
 #if 1
        /* Major cheat!
         * input is a pretty or normalized DN
         * hence, we can just search for ','
         */
-       if( rdn == NULL || rdn->bv_len == 0 ) {
+       if( rdn == NULL || rdn->bv_len == 0 ||
+               rdn->bv_len > SLAP_LDAPDN_MAXLEN )
+       {
                return LDAP_INVALID_SYNTAX;
        }
-
-       return strchr( rdn->bv_val, ',' ) == NULL
+       return ber_bvchr( rdn, ',' ) == NULL
                ? LDAP_SUCCESS : LDAP_INVALID_SYNTAX;
 
 #else
@@ -708,7 +1101,7 @@ rdnValidate( struct berval *rdn )
        /*
         * must be parsable
         */
-       rc = ldap_str2rdn( rdn, &RDN, (char **)&p, LDAP_DN_FORMAT_LDAP );
+       rc = ldap_bv2rdn( rdn, &RDN, (char **)&p, LDAP_DN_FORMAT_LDAP );
        if ( rc != LDAP_SUCCESS ) {
                return 0;
        }
@@ -738,7 +1131,7 @@ rdnValidate( struct berval *rdn )
 
 /* build_new_dn:
  *
- * Used by ldbm/bdb2 back_modrdn to create the new dn of entries being
+ * Used by back-bdb back_modrdn to create the new dn of entries being
  * renamed.
  *
  * new_dn = parent (p_dn) + separator + rdn (newrdn) + null.
@@ -747,19 +1140,20 @@ rdnValidate( struct berval *rdn )
 void
 build_new_dn( struct berval * new_dn,
        struct berval * parent_dn,
-       struct berval * newrdn )
+       struct berval * newrdn,
+       void *memctx )
 {
        char *ptr;
 
-       if ( parent_dn == NULL ) {
-               ber_dupbv( new_dn, newrdn );
+       if ( parent_dn == NULL || parent_dn->bv_len == 0 ) {
+               ber_dupbv_x( new_dn, newrdn, memctx );
                return;
        }
 
        new_dn->bv_len = parent_dn->bv_len + newrdn->bv_len + 1;
-       new_dn->bv_val = (char *) ch_malloc( new_dn->bv_len + 1 );
+       new_dn->bv_val = (char *) slap_sl_malloc( new_dn->bv_len + 1, memctx );
 
-       ptr = slap_strcopy( new_dn->bv_val, newrdn->bv_val );
+       ptr = lutil_strncopy( new_dn->bv_val, newrdn->bv_val, newrdn->bv_len );
        *ptr++ = ',';
        strcpy( ptr, parent_dn->bv_val );
 }
@@ -774,10 +1168,12 @@ dnIsSuffix(
        const struct berval *dn,
        const struct berval *suffix )
 {
-       int     d = dn->bv_len - suffix->bv_len;
+       int     d;
 
-       assert( dn );
-       assert( suffix );
+       assert( dn != NULL );
+       assert( suffix != NULL );
+
+       d = dn->bv_len - suffix->bv_len;
 
        /* empty suffix matches any dn */
        if ( suffix->bv_len == 0 ) {
@@ -800,5 +1196,135 @@ dnIsSuffix(
        }
 
        /* compare */
-       return( strcmp( dn->bv_val + d, suffix->bv_val ) == 0 );
+       return( strncmp( dn->bv_val + d, suffix->bv_val, suffix->bv_len ) == 0 );
+}
+
+/*
+ * In place; assumes:
+ * - ndn is normalized
+ * - nbase is normalized
+ * - dnIsSuffix( ndn, nbase ) == TRUE
+ * - LDAP_SCOPE_DEFAULT == LDAP_SCOPE_SUBTREE
+ */
+int
+dnIsWithinScope( struct berval *ndn, struct berval *nbase, int scope )
+{
+       assert( ndn != NULL );
+       assert( nbase != NULL );
+       assert( !BER_BVISNULL( ndn ) );
+       assert( !BER_BVISNULL( nbase ) );
+
+       switch ( scope ) {
+       case LDAP_SCOPE_DEFAULT:
+       case LDAP_SCOPE_SUBTREE:
+               break;
+
+       case LDAP_SCOPE_BASE:
+               if ( ndn->bv_len != nbase->bv_len ) {
+                       return 0;
+               }
+               break;
+
+       case LDAP_SCOPE_ONELEVEL: {
+               struct berval pndn;
+               dnParent( ndn, &pndn );
+               if ( pndn.bv_len != nbase->bv_len ) {
+                       return 0;
+               }
+               } break;
+
+       case LDAP_SCOPE_SUBORDINATE:
+               if ( ndn->bv_len == nbase->bv_len ) {
+                       return 0;
+               }
+               break;
+
+       /* unknown scope */
+       default:
+               return -1;
+       }
+
+       return 1;
 }
+
+/*
+ * In place; assumes:
+ * - ndn is normalized
+ * - nbase is normalized
+ * - LDAP_SCOPE_DEFAULT == LDAP_SCOPE_SUBTREE
+ */
+int
+dnIsSuffixScope( struct berval *ndn, struct berval *nbase, int scope )
+{
+       if ( !dnIsSuffix( ndn, nbase ) ) {
+               return 0;
+       }
+
+       return dnIsWithinScope( ndn, nbase, scope );
+}
+
+int
+dnIsOneLevelRDN( struct berval *rdn )
+{
+       ber_len_t       len = rdn->bv_len;
+       for ( ; len--; ) {
+               if ( DN_SEPARATOR( rdn->bv_val[ len ] ) ) {
+                       return 0;
+               }
+       }
+
+       return 1;
+}
+
+#ifdef HAVE_TLS
+static SLAP_CERT_MAP_FN *DNX509PeerNormalizeCertMap = NULL;
+#endif
+
+int register_certificate_map_function(SLAP_CERT_MAP_FN *fn)
+{
+#ifdef HAVE_TLS
+       if ( DNX509PeerNormalizeCertMap == NULL ) {
+               DNX509PeerNormalizeCertMap = fn;
+               return 0;
+       }
+#endif
+
+       return -1;
+}
+
+/*
+ * Convert an X.509 DN into a normalized LDAP DN
+ */
+int
+dnX509normalize( void *x509_name, struct berval *out )
+{
+       /* Invoke the LDAP library's converter with our schema-rewriter */
+       int rc = ldap_X509dn2bv( x509_name, out, LDAPDN_rewrite, 0 );
+
+       Debug( LDAP_DEBUG_TRACE,
+               "dnX509Normalize: <%s> (%d)\n",
+               BER_BVISNULL( out ) ? "(null)" : out->bv_val, rc, 0 );
+
+       return rc;
+}
+
+#ifdef HAVE_TLS
+/*
+ * Get the TLS session's peer's DN into a normalized LDAP DN
+ */
+int
+dnX509peerNormalize( void *ssl, struct berval *dn )
+{
+       int rc = LDAP_INVALID_CREDENTIALS;
+
+       if ( DNX509PeerNormalizeCertMap != NULL )
+               rc = (*DNX509PeerNormalizeCertMap)( ssl, dn );
+
+       if ( rc != LDAP_SUCCESS ) {
+               rc = ldap_pvt_tls_get_peer_dn( ssl, dn,
+                       (LDAPDN_rewrite_dummy *)LDAPDN_rewrite, 0 );
+       }
+
+       return rc;
+}
+#endif