]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/entry.c
if continuation line starts with a tab, rewrite it to a space
[openldap] / servers / slapd / entry.c
index cd8afb0f29add6b67dabf51c54743853f43f8a13..bf59a51f1e4e37efa99fea69ea589dcb5f768e13 100644 (file)
@@ -16,9 +16,9 @@
 
 #include "slap.h"
 
-static unsigned char   *ebuf;  /* buf returned by entry2str             */
+static unsigned char   *ebuf;  /* buf returned by entry2str             */
 static unsigned char   *ecur;  /* pointer to end of currently used ebuf */
-static int             emaxsize;/* max size of ebuf                     */
+static int             emaxsize;/* max size of ebuf                     */
 
 int entry_destroy(void)
 {
@@ -58,16 +58,26 @@ str2entry( char *s )
         * or newline.
         */
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                  "str2entry: \"%s\"\n", s ? s : "NULL" ));
+#else
        Debug( LDAP_DEBUG_TRACE, "=> str2entry\n",
                s ? s : "NULL", 0, 0 );
+#endif
 
        /* initialize reader/writer lock */
        e = (Entry *) ch_malloc( sizeof(Entry) );
 
        if( e == NULL ) {
-               Debug( LDAP_DEBUG_TRACE,
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "str2entry: entry allocation failed.\n" ));
+#else
+               Debug( LDAP_DEBUG_ANY,
                    "<= str2entry NULL (entry allocation failed)\n",
                    0, 0, 0 );
+#endif
                return( NULL );
        }
 
@@ -89,8 +99,13 @@ str2entry( char *s )
                }
 
                if ( ldif_parse_line( s, &type, &value.bv_val, &value.bv_len ) != 0 ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                                  "str2entry:  NULL (parse_line)\n" ));
+#else
                        Debug( LDAP_DEBUG_TRACE,
                            "<= str2entry NULL (parse_line)\n", 0, 0, 0 );
+#endif
                        continue;
                }
 
@@ -98,10 +113,16 @@ str2entry( char *s )
                        free( type );
 
                        if ( e->e_dn != NULL ) {
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                                          "str2entry: entry %ld has multiple dns \"%s\" and \"%s\" (second ignored)\n",
+                                          e->e_id, e->e_dn, value.bv_val != NULL ? value.bv_val : "" ));
+#else
                                Debug( LDAP_DEBUG_ANY,
  "str2entry: entry %ld has multiple dns \"%s\" and \"%s\" (second ignored)\n",
                                    e->e_id, e->e_dn,
                                        value.bv_val != NULL ? value.bv_val : "" );
+#endif
                                if( value.bv_val != NULL ) free( value.bv_val );
                                continue;
                        }
@@ -114,9 +135,14 @@ str2entry( char *s )
                rc = slap_str2ad( type, &ad, &text );
 
                if( rc != LDAP_SUCCESS ) {
-                       Debug( LDAP_DEBUG_TRACE,
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                                  "str2entry:  str2ad(%s):      %s\n", type, text ));
+#else
+                       Debug( slapMode & SLAP_TOOL_MODE
+                               ? LDAP_DEBUG_ANY : LDAP_DEBUG_TRACE,
                                "<= str2entry: str2ad(%s): %s\n", type, text, 0 );
-
+#endif
                        if( slapMode & SLAP_TOOL_MODE ) {
                                entry_free( e );
                                free( value.bv_val );
@@ -127,9 +153,14 @@ str2entry( char *s )
                        rc = slap_str2undef_ad( type, &ad, &text );
 
                        if( rc != LDAP_SUCCESS ) {
-                               Debug( LDAP_DEBUG_TRACE,
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                                          "str2entry:  str2undef_ad(%s):  %s\n", type, text ));
+#else
+                               Debug( LDAP_DEBUG_ANY,
                                        "<= str2entry: str2undef_ad(%s): %s\n",
                                                type, text, 0 );
+#endif
                                entry_free( e );
                                free( value.bv_val );
                                free( type );
@@ -142,9 +173,15 @@ str2entry( char *s )
                                ad->ad_type->sat_syntax->ssyn_validate;
 
                        if( !validate ) {
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                                          "str2entry: no validator for syntax %s\n", 
+                                          ad->ad_type->sat_syntax->ssyn_oid ));
+#else
                                Debug( LDAP_DEBUG_ANY,
                                        "str2entry: no validator for syntax %s\n",
                                        ad->ad_type->sat_syntax->ssyn_oid, 0, 0 );
+#endif
                                entry_free( e );
                                free( value.bv_val );
                                free( type );
@@ -157,9 +194,15 @@ str2entry( char *s )
                        rc = validate( ad->ad_type->sat_syntax, &value );
 
                        if( rc != 0 ) {
-                               Debug( LDAP_DEBUG_TRACE,
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                          "str2entry:  invalid value for syntax %s\n",
+                                          ad->ad_type->sat_syntax->ssyn_oid ));
+#else
+                               Debug( LDAP_DEBUG_ANY,
                                        "str2entry: invalid value for syntax %s\n",
                                        ad->ad_type->sat_syntax->ssyn_oid, 0, 0 );
+#endif
                                entry_free( e );
                                free( value.bv_val );
                                free( type );
@@ -172,8 +215,13 @@ str2entry( char *s )
                ad_free( ad, 1 );
 
                if( rc != 0 ) {
-                       Debug( LDAP_DEBUG_TRACE,
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                                  "str2entry:  NULL (attr_merge)\n" ));
+#else
+                       Debug( LDAP_DEBUG_ANY,
                            "<= str2entry NULL (attr_merge)\n", 0, 0, 0 );
+#endif
                        entry_free( e );
                        free( value.bv_val );
                        free( type );
@@ -186,8 +234,13 @@ str2entry( char *s )
 
        /* check to make sure there was a dn: line */
        if ( e->e_dn == NULL ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                          "str2entry:  entry %ld has no dn.\n", e->e_id ));
+#else
                Debug( LDAP_DEBUG_ANY, "str2entry: entry %ld has no dn\n",
                    e->e_id, 0, 0 );
+#endif
                entry_free( e );
                return( NULL );
        }
@@ -196,9 +249,13 @@ str2entry( char *s )
        e->e_ndn = ch_strdup( e->e_dn );
        (void) dn_normalize( e->e_ndn );
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL2,
+                  "str2entry(%s) -> 0x%lx\n", e->e_dn, (unsigned long)e ));
+#else
        Debug(LDAP_DEBUG_TRACE, "<= str2entry(%s) -> 0x%lx\n",
                e->e_dn, (unsigned long) e, 0 );
-
+#endif
        return( e );
 }
 
@@ -263,8 +320,14 @@ entry2str(
 void
 entry_free( Entry *e )
 {
-       Attribute       *a, *next;
+       /* free an entry structure */
+       assert( e != NULL );
 
+       /* e_private must be freed by the caller */
+       assert( e->e_private == NULL );
+       e->e_private = NULL;
+
+       /* free DNs */
        if ( e->e_dn != NULL ) {
                free( e->e_dn );
                e->e_dn = NULL;
@@ -273,12 +336,11 @@ entry_free( Entry *e )
                free( e->e_ndn );
                e->e_ndn = NULL;
        }
-       for ( a = e->e_attrs; a != NULL; a = next ) {
-               next = a->a_next;
-               attr_free( a );
-       }
+
+       /* free attributes */
+       attrs_free( e->e_attrs );
        e->e_attrs = NULL;
-       e->e_private = NULL;
+
        free( e );
 }
 
@@ -287,7 +349,7 @@ entry_free( Entry *e )
  *
  * the Entry has three entry points (ways to find things):
  *
- *     by entry        e.g., if you already have an entry from the cache
+ *     by entry        e.g., if you already have an entry from the cache
  *                     and want to delete it. (really by entry ptr)
  *     by dn           e.g., when looking for the base object of a search
  *     by id           e.g., for search candidates
@@ -340,14 +402,16 @@ int entry_decode( struct berval *bv, Entry **entry )
        ber_len_t       len;
        char *last;
 
-       Debug( LDAP_DEBUG_TRACE, "=> entry_decode\n",
-               0, 0, 0 );
-
        ber = ber_init( bv );
        if( ber == NULL ) {
-               Debug( LDAP_DEBUG_TRACE,
-                   "<= entry_encode: ber_init failed\n",
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "entry_decode: ber_init failed\n" ));
+#else
+               Debug( LDAP_DEBUG_ANY,
+                   "<= entry_decode: ber_init failed\n",
                    0, 0, 0 );
+#endif
                return LDAP_LOCAL_ERROR;
        }
 
@@ -355,9 +419,14 @@ int entry_decode( struct berval *bv, Entry **entry )
        e = (Entry *) ch_malloc( sizeof(Entry) );
 
        if( e == NULL ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "entry_decode: entry allocation failed.\n" ));
+#else
                Debug( LDAP_DEBUG_ANY,
-                   "<= entry_encode: entry allocation failed\n",
+                   "<= entry_decode: entry allocation failed\n",
                    0, 0, 0 );
+#endif
                return LDAP_LOCAL_ERROR;
        }
 
@@ -374,10 +443,14 @@ int entry_decode( struct berval *bv, Entry **entry )
                return LDAP_PROTOCOL_ERROR;
        }
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL2,
+                  "entry_decode: \"%s\"\n", e->e_dn ));
+#else
        Debug( LDAP_DEBUG_TRACE,
-           "entry_encode: \"%s\"\n",
+           "entry_decode: \"%s\"\n",
            e->e_dn, 0, 0 );
-
+#endif
        /* get the attrs */
        for ( tag = ber_first_element( ber, &len, &last );
                tag != LBER_DEFAULT;
@@ -391,14 +464,24 @@ int entry_decode( struct berval *bv, Entry **entry )
                tag = ber_scanf( ber, "{O{V}}", &type, &vals );
 
                if ( tag == LBER_ERROR ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                  "entry_decode: decoding error (%s)\n", e->e_dn ));
+#else
                        Debug( LDAP_DEBUG_ANY, "entry_decode: decoding error\n", 0, 0, 0 );
+#endif
                        entry_free( e );
                        return LDAP_PROTOCOL_ERROR;
                }
 
                if ( vals == NULL ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                  "entry_decode: no values for type %s\n", type ));
+#else
                        Debug( LDAP_DEBUG_ANY, "entry_decode: no values for type %s\n",
                                type, 0, 0 );
+#endif
                        ber_bvfree( type );
                        entry_free( e );
                        return LDAP_PROTOCOL_ERROR;
@@ -408,15 +491,24 @@ int entry_decode( struct berval *bv, Entry **entry )
                rc = slap_bv2ad( type, &ad, &text );
 
                if( rc != LDAP_SUCCESS ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                                  "entry_decode: str2ad(%s): %s\n", type, text ));
+#else
                        Debug( LDAP_DEBUG_TRACE,
                                "<= entry_decode: str2ad(%s): %s\n", type, text, 0 );
-
+#endif
                        rc = slap_bv2undef_ad( type, &ad, &text );
 
                        if( rc != LDAP_SUCCESS ) {
-                               Debug( LDAP_DEBUG_TRACE,
-                                       "<= str2entry: str2undef_ad(%s): %s\n",
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                                          "entry_decode:  str2undef_ad(%s): %s\n", type, text));
+#else
+                               Debug( LDAP_DEBUG_ANY,
+                                       "<= entry_decode: str2undef_ad(%s): %s\n",
                                                type, text, 0 );
+#endif
                                ber_bvfree( type );
                                ber_bvecfree( vals );
                                entry_free( e );
@@ -428,8 +520,13 @@ int entry_decode( struct berval *bv, Entry **entry )
                ad_free( ad, 1 );
 
                if( rc != 0 ) {
-                       Debug( LDAP_DEBUG_TRACE,
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                                  "entry_decode:  attr_merge failed\n"));
+#else
+                       Debug( LDAP_DEBUG_ANY,
                            "<= entry_decode: attr_merge failed\n", 0, 0, 0 );
+#endif
                        ber_bvfree( type );
                        ber_bvecfree( vals );
                        entry_free( e );
@@ -446,8 +543,13 @@ int entry_decode( struct berval *bv, Entry **entry )
                return LDAP_PROTOCOL_ERROR;
        }
 
-       Debug(LDAP_DEBUG_TRACE, "<= entry_decode(%s) -> 0x%lx\n",
-               e->e_dn, (unsigned long) e, 0 );
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                  "entry_decode:  %s\n", e->e_dn ));
+#else
+       Debug(LDAP_DEBUG_TRACE, "<= entry_decode(%s)\n",
+               e->e_dn, 0, 0 );
+#endif
 
        *entry = e;
        return LDAP_SUCCESS;
@@ -461,9 +563,14 @@ int entry_encode(
        Attribute *a;
        BerElement *ber;
        
-       Debug( LDAP_DEBUG_TRACE, "=> entry_encode\n",
-               0, 0, 0 );
-
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_DETAIL1,
+                  "entry_encode: id: 0x%08lx  \"%s\"\n",
+                  e->e_id, e->e_dn ));
+#else
+       Debug( LDAP_DEBUG_TRACE, "=> entry_encode(0x%08lx): %s\n",
+               e->e_id, e->e_dn, 0 );
+#endif
        ber = ber_alloc_t( LBER_USE_DER );
        if( ber == NULL ) {
                goto done;
@@ -492,6 +599,15 @@ int entry_encode(
 
 done:
        ber_free( ber, 1 );
+       if( rc ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                          "entry_encode: id=0x%08lx  failed (%d)\n", e->e_id, rc ));
+#else
+               Debug( LDAP_DEBUG_ANY, "=> entry_encode(0x%08lx): failed (%d)\n",
+                       e->e_id, rc, 0 );
+#endif
+       }
        return rc;
 }
 #endif