]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/filter.c
Ignore attempts to Add cn=schema,cn=config
[openldap] / servers / slapd / filter.c
index 87cfd7193730c6672e6859cd389e18836fcce2e1..02467fb301e45431ad92f9d3a5c8dd16b23327ad 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2006 The OpenLDAP Foundation.
+ * Copyright 1998-2009 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 #include <ac/string.h>
 
 #include "slap.h"
+#include "lutil.h"
+
+const Filter *slap_filter_objectClass_pres;
+const struct berval *slap_filterstr_objectClass_pres;
 
 static int     get_filter_list(
        Operation *op,
@@ -42,7 +46,7 @@ static int    get_filter_list(
 static int     get_ssa(
        Operation *op,
        BerElement *ber,
-       SubstringsAssertion **s,
+       Filter *f,
        const char **text );
 
 static void simple_vrFilter2bv(
@@ -56,6 +60,26 @@ static int   get_simple_vrFilter(
        ValuesReturnFilter **f,
        const char **text );
 
+int
+filter_init( void )
+{
+       static Filter filter_objectClass_pres = { LDAP_FILTER_PRESENT };
+       static struct berval filterstr_objectClass_pres = BER_BVC("(objectClass=*)");
+
+       filter_objectClass_pres.f_desc = slap_schema.si_ad_objectClass;
+
+       slap_filter_objectClass_pres = &filter_objectClass_pres;
+       slap_filterstr_objectClass_pres = &filterstr_objectClass_pres;
+
+       return 0;
+}
+
+void
+filter_destroy( void )
+{
+       return;
+}
+
 int
 get_filter(
        Operation *op,
@@ -79,8 +103,8 @@ get_filter(
         *              substrings      [4]     SubstringFilter,
         *              greaterOrEqual  [5]     AttributeValueAssertion,
         *              lessOrEqual     [6]     AttributeValueAssertion,
-        *              present         [7]     AttributeType,,
-        *              approxMatch     [8]     AttributeValueAssertion
+        *              present         [7]     AttributeType,
+        *              approxMatch     [8]     AttributeValueAssertion,
         *              extensibleMatch [9]     MatchingRuleAssertion
         *      }
         *
@@ -117,7 +141,7 @@ get_filter(
        switch ( f.f_choice ) {
        case LDAP_FILTER_EQUALITY:
                Debug( LDAP_DEBUG_FILTER, "EQUALITY\n", 0, 0, 0 );
-               err = get_ava( op, ber, &f.f_ava, SLAP_MR_EQUALITY, text );
+               err = get_ava( op, ber, &f, SLAP_MR_EQUALITY, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -127,7 +151,7 @@ get_filter(
 
        case LDAP_FILTER_SUBSTRINGS:
                Debug( LDAP_DEBUG_FILTER, "SUBSTRINGS\n", 0, 0, 0 );
-               err = get_ssa( op, ber, &f.f_sub, text );
+               err = get_ssa( op, ber, &f, text );
                if( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -136,7 +160,7 @@ get_filter(
 
        case LDAP_FILTER_GE:
                Debug( LDAP_DEBUG_FILTER, "GE\n", 0, 0, 0 );
-               err = get_ava( op, ber, &f.f_ava, SLAP_MR_ORDERING, text );
+               err = get_ava( op, ber, &f, SLAP_MR_ORDERING, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -145,7 +169,7 @@ get_filter(
 
        case LDAP_FILTER_LE:
                Debug( LDAP_DEBUG_FILTER, "LE\n", 0, 0, 0 );
-               err = get_ava( op, ber, &f.f_ava, SLAP_MR_ORDERING, text );
+               err = get_ava( op, ber, &f, SLAP_MR_ORDERING, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -166,6 +190,7 @@ get_filter(
                err = slap_bv2ad( &type, &f.f_desc, text );
 
                if( err != LDAP_SUCCESS ) {
+                       f.f_choice |= SLAPD_FILTER_UNDEFINED;
                        err = slap_bv2undef_ad( &type, &f.f_desc, text,
                                SLAP_AD_PROXIED|SLAP_AD_NOINSERT );
 
@@ -176,12 +201,10 @@ get_filter(
                                        "type=%s (%d)\n",
                                        op->o_connid, type.bv_val, err );
 
-                               f.f_choice = SLAPD_FILTER_COMPUTED;
-                               f.f_result = LDAP_COMPARE_FALSE;
                                err = LDAP_SUCCESS;
-                               *text = NULL;
-                               break;
+                               f.f_desc = slap_bv2tmp_ad( &type, op->o_tmpmemctx );
                        }
+                       *text = NULL;
                }
 
                assert( f.f_desc != NULL );
@@ -189,7 +212,7 @@ get_filter(
 
        case LDAP_FILTER_APPROX:
                Debug( LDAP_DEBUG_FILTER, "APPROX\n", 0, 0, 0 );
-               err = get_ava( op, ber, &f.f_ava, SLAP_MR_EQUALITY_APPROX, text );
+               err = get_ava( op, ber, &f, SLAP_MR_EQUALITY_APPROX, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -253,7 +276,7 @@ get_filter(
        case LDAP_FILTER_EXT:
                Debug( LDAP_DEBUG_FILTER, "EXTENSIBLE\n", 0, 0, 0 );
 
-               err = get_mra( op, ber, &f.f_mra, text );
+               err = get_mra( op, ber, &f, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -320,18 +343,17 @@ static int
 get_ssa(
        Operation *op,
        BerElement      *ber,
-       SubstringsAssertion     **out,
+       Filter          *f,
        const char      **text )
 {
        ber_tag_t       tag;
        ber_len_t       len;
-       ber_tag_t       rc;
+       int     rc;
        struct berval desc, value, nvalue;
        char            *last;
        SubstringsAssertion ssa;
 
        *text = "error decoding filter";
-       *out = NULL;
 
        Debug( LDAP_DEBUG_FILTER, "begin get_ssa\n", 0, 0, 0 );
        if ( ber_scanf( ber, "{m" /*}*/, &desc ) == LBER_ERROR ) {
@@ -348,6 +370,7 @@ get_ssa(
        rc = slap_bv2ad( &desc, &ssa.sa_desc, text );
 
        if( rc != LDAP_SUCCESS ) {
+               f->f_choice |= SLAPD_FILTER_UNDEFINED;
                rc = slap_bv2undef_ad( &desc, &ssa.sa_desc, text,
                        SLAP_AD_PROXIED|SLAP_AD_NOINSERT );
 
@@ -356,18 +379,23 @@ get_ssa(
                                "get_ssa: conn %lu unknown attribute type=%s (%ld)\n",
                                op->o_connid, desc.bv_val, (long) rc );
        
-                       /* skip over the rest of this filter */
-                       for ( tag = ber_first_element( ber, &len, &last );
-                               tag != LBER_DEFAULT;
-                               tag = ber_next_element( ber, &len, last ) ) {
-                               ber_scanf( ber, "x" );
-                       }
-                       return rc;
+                       ssa.sa_desc = slap_bv2tmp_ad( &desc, op->o_tmpmemctx );
                }
        }
 
        rc = LDAP_PROTOCOL_ERROR;
 
+       /* If there is no substring matching rule, there's nothing
+        * we can do with this filter. But we continue to parse it
+        * for logging purposes.
+        */
+       if ( ssa.sa_desc->ad_type->sat_substr == NULL ) {
+               f->f_choice |= SLAPD_FILTER_UNDEFINED;
+               Debug( LDAP_DEBUG_FILTER,
+               "get_ssa: no substring matching rule for attributeType %s\n",
+                       desc.bv_val, 0, 0 );
+       }
+
        for ( tag = ber_first_element( ber, &len, &last );
                tag != LBER_DEFAULT;
                tag = ber_next_element( ber, &len, last ) )
@@ -427,7 +455,13 @@ get_ssa(
                rc = asserted_value_validate_normalize(
                        ssa.sa_desc, ssa.sa_desc->ad_type->sat_equality,
                        usage, &value, &nvalue, text, op->o_tmpmemctx );
-               if( rc != LDAP_SUCCESS ) goto return_error;
+               if( rc != LDAP_SUCCESS ) {
+                       f->f_choice |= SLAPD_FILTER_UNDEFINED;
+                       Debug( LDAP_DEBUG_FILTER,
+                       "get_ssa: illegal value for attributeType %s (%d) %s\n",
+                               desc.bv_val, rc, *text );
+                       ber_dupbv_x( &nvalue, &value, op->o_tmpmemctx );
+               }
 
                switch ( tag ) {
                case LDAP_SUBSTRING_INITIAL:
@@ -455,16 +489,19 @@ return_error:
                                (long) rc, 0, 0 );
                        slap_sl_free( ssa.sa_initial.bv_val, op->o_tmpmemctx );
                        ber_bvarray_free_x( ssa.sa_any, op->o_tmpmemctx );
+                       if ( ssa.sa_desc->ad_flags & SLAP_DESC_TEMPORARY )
+                               op->o_tmpfree( ssa.sa_desc, op->o_tmpmemctx );
                        slap_sl_free( ssa.sa_final.bv_val, op->o_tmpmemctx );
                        return rc;
                }
 
+               *text = NULL;
                rc = LDAP_SUCCESS;
        }
 
        if( rc == LDAP_SUCCESS ) {
-               *out = op->o_tmpalloc( sizeof( ssa ), op->o_tmpmemctx );
-               **out = ssa;
+               f->f_sub = op->o_tmpalloc( sizeof( ssa ), op->o_tmpmemctx );
+               *f->f_sub = ssa;
        }
 
        Debug( LDAP_DEBUG_FILTER, "end get_ssa\n", 0, 0, 0 );
@@ -472,7 +509,7 @@ return_error:
 }
 
 void
-filter_free_x( Operation *op, Filter *f )
+filter_free_x( Operation *op, Filter *f, int freeme )
 {
        Filter  *p, *next;
 
@@ -480,6 +517,8 @@ filter_free_x( Operation *op, Filter *f )
                return;
        }
 
+       f->f_choice &= SLAPD_FILTER_MASK;
+
        switch ( f->f_choice ) {
        case LDAP_FILTER_PRESENT:
                break;
@@ -499,6 +538,8 @@ filter_free_x( Operation *op, Filter *f )
                if ( f->f_sub_final.bv_val != NULL ) {
                        op->o_tmpfree( f->f_sub_final.bv_val, op->o_tmpmemctx );
                }
+               if ( f->f_sub->sa_desc->ad_flags & SLAP_DESC_TEMPORARY )
+                       op->o_tmpfree( f->f_sub->sa_desc, op->o_tmpmemctx );
                op->o_tmpfree( f->f_sub, op->o_tmpmemctx );
                break;
 
@@ -507,7 +548,7 @@ filter_free_x( Operation *op, Filter *f )
        case LDAP_FILTER_NOT:
                for ( p = f->f_list; p != NULL; p = next ) {
                        next = p->f_next;
-                       filter_free_x( op, p );
+                       filter_free_x( op, p, 1 );
                }
                break;
 
@@ -524,7 +565,9 @@ filter_free_x( Operation *op, Filter *f )
                break;
        }
 
-       op->o_tmpfree( f, op->o_tmpmemctx );
+       if ( freeme ) {
+               op->o_tmpfree( f, op->o_tmpmemctx );
+       }
 }
 
 void
@@ -536,7 +579,7 @@ filter_free( Filter *f )
        op.o_hdr = &ohdr;
        op.o_tmpmemctx = slap_sl_context( f );
        op.o_tmpmfuncs = &slap_sl_mfuncs;
-       filter_free_x( &op, f );
+       filter_free_x( &op, f, 1 );
 }
 
 void
@@ -544,7 +587,7 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
 {
        int             i;
        Filter          *p;
-       struct berval   tmp;
+       struct berval   tmp, value;
        static struct berval
                        ber_bvfalse = BER_BVC( "(?=false)" ),
                        ber_bvtrue = BER_BVC( "(?=true)" ),
@@ -553,90 +596,78 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        ber_bvunknown = BER_BVC( "(?=unknown)" ),
                        ber_bvnone = BER_BVC( "(?=none)" );
        ber_len_t       len;
+       ber_tag_t       choice;
+       int undef;
+       char *sign;
 
        if ( f == NULL ) {
                ber_dupbv_x( fstr, &ber_bvnone, op->o_tmpmemctx );
                return;
        }
 
-       switch ( f->f_choice ) {
-       case LDAP_FILTER_EQUALITY:
-               filter_escape_value_x( &f->f_av_value, &tmp, op->o_tmpmemctx );
-               /* NOTE: tmp can legitimately be NULL (meaning empty) 
-                * since in a Filter values in AVAs are supposed
-                * to have been normalized, meaning that an empty value
-                * is legal for that attribute's syntax */
-
-               fstr->bv_len = f->f_av_desc->ad_cname.bv_len +
-                       tmp.bv_len + STRLENOF("(=)");
-               fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
-
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=%s)",
-                       f->f_av_desc->ad_cname.bv_val,
-                       tmp.bv_len ? tmp.bv_val : "" );
-
-               ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
-               break;
+       undef = f->f_choice & SLAPD_FILTER_UNDEFINED;
+       choice = f->f_choice & SLAPD_FILTER_MASK;
 
+       switch ( choice ) {
+       case LDAP_FILTER_EQUALITY:
+               fstr->bv_len = STRLENOF("(=)");
+               sign = "=";
+               goto simple;
        case LDAP_FILTER_GE:
-               filter_escape_value_x( &f->f_av_value, &tmp, op->o_tmpmemctx );
-               /* NOTE: tmp can legitimately be NULL (meaning empty) 
-                * since in a Filter values in AVAs are supposed
-                * to have been normalized, meaning that an empty value
-                * is legal for that attribute's syntax */
-
-               fstr->bv_len = f->f_av_desc->ad_cname.bv_len +
-                       tmp.bv_len + STRLENOF("(>=)");
-               fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
-
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s>=%s)",
-                       f->f_av_desc->ad_cname.bv_val,
-                       tmp.bv_len ? tmp.bv_val : "");
-
-               ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
-               break;
-
+               fstr->bv_len = STRLENOF("(>=)");
+               sign = ">=";
+               goto simple;
        case LDAP_FILTER_LE:
-               filter_escape_value_x( &f->f_av_value, &tmp, op->o_tmpmemctx );
+               fstr->bv_len = STRLENOF("(<=)");
+               sign = "<=";
+               goto simple;
+       case LDAP_FILTER_APPROX:
+               fstr->bv_len = STRLENOF("(~=)");
+               sign = "~=";
+
+simple:
+               value = f->f_av_value;
+               if ( f->f_av_desc->ad_type->sat_equality &&
+                       !undef &&
+                       ( f->f_av_desc->ad_type->sat_equality->smr_usage & SLAP_MR_MUTATION_NORMALIZER ))
+               {
+                       f->f_av_desc->ad_type->sat_equality->smr_normalize(
+                               (SLAP_MR_DENORMALIZE|SLAP_MR_VALUE_OF_ASSERTION_SYNTAX),
+                               NULL, NULL, &f->f_av_value, &value, op->o_tmpmemctx );
+               }
+
+               filter_escape_value_x( &value, &tmp, op->o_tmpmemctx );
                /* NOTE: tmp can legitimately be NULL (meaning empty) 
                 * since in a Filter values in AVAs are supposed
                 * to have been normalized, meaning that an empty value
                 * is legal for that attribute's syntax */
 
-               fstr->bv_len = f->f_av_desc->ad_cname.bv_len +
-                       tmp.bv_len + STRLENOF("(<=)");
+               fstr->bv_len += f->f_av_desc->ad_cname.bv_len + tmp.bv_len;
+               if ( undef )
+                       fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s<=%s)",
-                       f->f_av_desc->ad_cname.bv_val,
-                       tmp.bv_len ? tmp.bv_val : "");
-
-               ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
-               break;
-
-       case LDAP_FILTER_APPROX:
-               filter_escape_value_x( &f->f_av_value, &tmp, op->o_tmpmemctx );
-               /* NOTE: tmp can legitimately be NULL (meaning empty) 
-                * since in a Filter values in AVAs are supposed
-                * to have been normalized, meaning that an empty value
-                * is legal for that attribute's syntax */
+               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s)",
+                       undef ? "?" : "",
+                       f->f_av_desc->ad_cname.bv_val, sign,
+                       tmp.bv_len ? tmp.bv_val : "" );
 
-               fstr->bv_len = f->f_av_desc->ad_cname.bv_len +
-                       tmp.bv_len + STRLENOF("(~=)");
-               fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
+               if ( value.bv_val != f->f_av_value.bv_val ) {
+                       ber_memfree_x( value.bv_val, op->o_tmpmemctx );
+               }
 
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s~=%s)",
-                       f->f_av_desc->ad_cname.bv_val,
-                       tmp.bv_len ? tmp.bv_val : "");
                ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
                break;
 
        case LDAP_FILTER_SUBSTRINGS:
                fstr->bv_len = f->f_sub_desc->ad_cname.bv_len +
                        STRLENOF("(=*)");
+               if ( undef )
+                       fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 128, op->o_tmpmemctx );
 
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=*)",
+               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s=*)",
+                       undef ? "?" : "",
                        f->f_sub_desc->ad_cname.bv_val );
 
                if ( f->f_sub_initial.bv_val != NULL ) {
@@ -645,16 +676,16 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        len = fstr->bv_len;
 
                        filter_escape_value_x( &f->f_sub_initial, &tmp, op->o_tmpmemctx );
-                       tmplen = tmp.bv_len ? tmp.bv_len : STRLENOF( "(null)" );
+                       tmplen = tmp.bv_len;
 
                        fstr->bv_len += tmplen;
                        fstr->bv_val = op->o_tmprealloc( fstr->bv_val,
                                fstr->bv_len + 1, op->o_tmpmemctx );
 
-                       snprintf( &fstr->bv_val[len-2],
+                       snprintf( &fstr->bv_val[len - 2],
                                tmplen + STRLENOF( /*(*/ "*)" ) + 1,
                                /* "(attr=" */ "%s*)",
-                               tmp.bv_len ? tmp.bv_val : "(null)");
+                               tmp.bv_len ? tmp.bv_val : "");
 
                        ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
                }
@@ -666,16 +697,16 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                                len = fstr->bv_len;
                                filter_escape_value_x( &f->f_sub_any[i],
                                        &tmp, op->o_tmpmemctx );
-                               tmplen = tmp.bv_len ? tmp.bv_len : STRLENOF( "(null)" );
+                               tmplen = tmp.bv_len;
 
                                fstr->bv_len += tmplen + STRLENOF( /*(*/ ")" );
                                fstr->bv_val = op->o_tmprealloc( fstr->bv_val,
                                        fstr->bv_len + 1, op->o_tmpmemctx );
 
-                               snprintf( &fstr->bv_val[len-1],
+                               snprintf( &fstr->bv_val[len - 1],
                                        tmplen + STRLENOF( /*(*/ "*)" ) + 1,
                                        /* "(attr=[init]*[any*]" */ "%s*)",
-                                       tmp.bv_len ? tmp.bv_val : "(null)");
+                                       tmp.bv_len ? tmp.bv_val : "");
                                ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
                        }
                }
@@ -686,16 +717,16 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        len = fstr->bv_len;
 
                        filter_escape_value_x( &f->f_sub_final, &tmp, op->o_tmpmemctx );
-                       tmplen = tmp.bv_len ? tmp.bv_len : STRLENOF( "(null)" );
+                       tmplen = tmp.bv_len;
 
                        fstr->bv_len += tmplen;
                        fstr->bv_val = op->o_tmprealloc( fstr->bv_val,
                                fstr->bv_len + 1, op->o_tmpmemctx );
 
-                       snprintf( &fstr->bv_val[len-1],
+                       snprintf( &fstr->bv_val[len - 1],
                                tmplen + STRLENOF( /*(*/ ")" ) + 1,
                                /* "(attr=[init*][any*]" */ "%s)",
-                               tmp.bv_len ? tmp.bv_val : "(null)");
+                               tmp.bv_len ? tmp.bv_val : "");
 
                        ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
                }
@@ -705,9 +736,13 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
        case LDAP_FILTER_PRESENT:
                fstr->bv_len = f->f_desc->ad_cname.bv_len +
                        STRLENOF("(=*)");
+               if ( undef )
+                       fstr->bv_len++;
+
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=*)",
+               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s=*)",
+                       undef ? "?" : "",
                        f->f_desc->ad_cname.bv_val );
                break;
 
@@ -761,7 +796,8 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        tmp.bv_len + STRLENOF("(:=)");
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s:=%s)",
+               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s%s:=%s)",
+                       undef ? "?" : "",
                        ad.bv_val,
                        f->f_mr_dnattrs ? ":dn" : "",
                        f->f_mr_rule_text.bv_len ? ":" : "",
@@ -824,12 +860,15 @@ filter_dup( Filter *f, void *memctx )
        n->f_choice = f->f_choice;
        n->f_next = NULL;
 
-       switch( f->f_choice ) {
+       switch( f->f_choice & SLAPD_FILTER_MASK ) {
        case SLAPD_FILTER_COMPUTED:
                n->f_result = f->f_result;
                break;
        case LDAP_FILTER_PRESENT:
-               n->f_desc = f->f_desc;
+               if ( f->f_desc->ad_flags & SLAP_DESC_TEMPORARY )
+                       n->f_desc = slap_bv2tmp_ad( &f->f_desc->ad_cname, memctx );
+               else
+                       n->f_desc = f->f_desc;
                break;
        case LDAP_FILTER_EQUALITY:
        case LDAP_FILTER_GE:
@@ -838,11 +877,16 @@ filter_dup( Filter *f, void *memctx )
                /* Should this be ava_dup() ? */
                n->f_ava = mf->bmf_calloc( 1, sizeof(AttributeAssertion), memctx );
                *n->f_ava = *f->f_ava;
+               if ( f->f_av_desc->ad_flags & SLAP_DESC_TEMPORARY )
+                       n->f_av_desc = slap_bv2tmp_ad( &f->f_av_desc->ad_cname, memctx );
                ber_dupbv_x( &n->f_av_value, &f->f_av_value, memctx );
                break;
        case LDAP_FILTER_SUBSTRINGS:
                n->f_sub = mf->bmf_calloc( 1, sizeof(SubstringsAssertion), memctx );
-               n->f_sub_desc = f->f_sub_desc;
+               if ( f->f_sub_desc->ad_flags & SLAP_DESC_TEMPORARY )
+                       n->f_sub_desc = slap_bv2tmp_ad( &f->f_sub_desc->ad_cname, memctx );
+               else
+                       n->f_sub_desc = f->f_sub_desc;
                if ( !BER_BVISNULL( &f->f_sub_initial ))
                        ber_dupbv_x( &n->f_sub_initial, &f->f_sub_initial, memctx );
                if ( f->f_sub_any ) {
@@ -866,6 +910,8 @@ filter_dup( Filter *f, void *memctx )
                        length += f->f_mr_rule_text.bv_len + 1;
                n->f_mra = mf->bmf_calloc( 1, length, memctx );
                *n->f_mra = *f->f_mra;
+               if ( f->f_mr_desc && ( f->f_sub_desc->ad_flags & SLAP_DESC_TEMPORARY ))
+                       n->f_mr_desc = slap_bv2tmp_ad( &f->f_mr_desc->ad_cname, memctx );
                ber_dupbv_x( &n->f_mr_value, &f->f_mr_value, memctx );
                if ( !BER_BVISNULL( &f->f_mr_rule_text )) {
                        n->f_mr_rule_text.bv_val = (char *)(n->f_mra+1);
@@ -915,7 +961,7 @@ get_simple_vrFilter(
        switch ( vrf.vrf_choice ) {
        case LDAP_FILTER_EQUALITY:
                Debug( LDAP_DEBUG_FILTER, "EQUALITY\n", 0, 0, 0 );
-               err = get_ava( op, ber, &vrf.vrf_ava, SLAP_MR_EQUALITY, text );
+               err = get_ava( op, ber, (Filter *)&vrf, SLAP_MR_EQUALITY, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -925,12 +971,12 @@ get_simple_vrFilter(
 
        case LDAP_FILTER_SUBSTRINGS:
                Debug( LDAP_DEBUG_FILTER, "SUBSTRINGS\n", 0, 0, 0 );
-               err = get_ssa( op, ber, &vrf.vrf_sub, text );
+               err = get_ssa( op, ber, (Filter *)&vrf, text );
                break;
 
        case LDAP_FILTER_GE:
                Debug( LDAP_DEBUG_FILTER, "GE\n", 0, 0, 0 );
-               err = get_ava( op, ber, &vrf.vrf_ava, SLAP_MR_ORDERING, text );
+               err = get_ava( op, ber, (Filter *)&vrf, SLAP_MR_ORDERING, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -938,7 +984,7 @@ get_simple_vrFilter(
 
        case LDAP_FILTER_LE:
                Debug( LDAP_DEBUG_FILTER, "LE\n", 0, 0, 0 );
-               err = get_ava( op, ber, &vrf.vrf_ava, SLAP_MR_ORDERING, text );
+               err = get_ava( op, ber, (Filter *)&vrf, SLAP_MR_ORDERING, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -958,8 +1004,9 @@ get_simple_vrFilter(
                err = slap_bv2ad( &type, &vrf.vrf_desc, text );
 
                if( err != LDAP_SUCCESS ) {
+                       vrf.vrf_choice |= SLAPD_FILTER_UNDEFINED;
                        err = slap_bv2undef_ad( &type, &vrf.vrf_desc, text,
-                               SLAP_AD_PROXIED|SLAP_AD_NOINSERT );
+                               SLAP_AD_PROXIED);
 
                        if( err != LDAP_SUCCESS ) {
                                /* unrecognized attribute description or other error */
@@ -978,7 +1025,7 @@ get_simple_vrFilter(
 
        case LDAP_FILTER_APPROX:
                Debug( LDAP_DEBUG_FILTER, "APPROX\n", 0, 0, 0 );
-               err = get_ava( op, ber, &vrf.vrf_ava, SLAP_MR_EQUALITY_APPROX, text );
+               err = get_ava( op, ber, (Filter *)&vrf, SLAP_MR_EQUALITY_APPROX, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -987,7 +1034,7 @@ get_simple_vrFilter(
        case LDAP_FILTER_EXT:
                Debug( LDAP_DEBUG_FILTER, "EXTENSIBLE\n", 0, 0, 0 );
 
-               err = get_mra( op, ber, &vrf.vrf_mra, text );
+               err = get_mra( op, ber, (Filter *)&vrf, text );
                if ( err != LDAP_SUCCESS ) {
                        break;
                }
@@ -1012,7 +1059,7 @@ get_simple_vrFilter(
        }
 
        if ( err == LDAP_SUCCESS ) {
-               *filt = ch_malloc( sizeof vrf );
+               *filt = op->o_tmpalloc( sizeof vrf, op->o_tmpmemctx );
                **filt = vrf;
        }
 
@@ -1103,7 +1150,7 @@ vrFilter_free( Operation *op, ValuesReturnFilter *vrf )
        for ( p = vrf; p != NULL; p = next ) {
                next = p->vrf_next;
 
-               switch ( vrf->vrf_choice ) {
+               switch ( vrf->vrf_choice & SLAPD_FILTER_MASK ) {
                case LDAP_FILTER_PRESENT:
                        break;
 
@@ -1181,19 +1228,22 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
 {
        struct berval tmp;
        ber_len_t len;
+       int undef;
 
        if ( vrf == NULL ) {
                ber_str2bv_x( "No filter!", STRLENOF("No filter!"), 1, fstr,
                        op->o_tmpmemctx );
                return;
        }
+       undef = vrf->vrf_choice & SLAPD_FILTER_UNDEFINED;
 
-       switch ( vrf->vrf_choice ) {
+       switch ( vrf->vrf_choice & SLAPD_FILTER_MASK ) {
        case LDAP_FILTER_EQUALITY:
                filter_escape_value_x( &vrf->vrf_av_value, &tmp, op->o_tmpmemctx );
 
                fstr->bv_len = vrf->vrf_av_desc->ad_cname.bv_len +
                        tmp.bv_len + STRLENOF("(=)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=%s)",
@@ -1208,6 +1258,7 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
 
                fstr->bv_len = vrf->vrf_av_desc->ad_cname.bv_len +
                        tmp.bv_len + STRLENOF("(>=)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s>=%s)",
@@ -1222,6 +1273,7 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
 
                fstr->bv_len = vrf->vrf_av_desc->ad_cname.bv_len +
                        tmp.bv_len + STRLENOF("(<=)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s<=%s)",
@@ -1236,6 +1288,7 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
 
                fstr->bv_len = vrf->vrf_av_desc->ad_cname.bv_len +
                        tmp.bv_len + STRLENOF("(~=)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s~=%s)",
@@ -1247,6 +1300,7 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
        case LDAP_FILTER_SUBSTRINGS:
                fstr->bv_len = vrf->vrf_sub_desc->ad_cname.bv_len +
                        STRLENOF("(=*)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 128, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=*)",
@@ -1307,6 +1361,7 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
        case LDAP_FILTER_PRESENT:
                fstr->bv_len = vrf->vrf_desc->ad_cname.bv_len +
                        STRLENOF("(=*)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=*)",
@@ -1329,6 +1384,7 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
                        ( vrf->vrf_mr_rule_text.bv_len
                                ? vrf->vrf_mr_rule_text.bv_len+1 : 0 ) +
                        tmp.bv_len + STRLENOF("(:=)");
+               if ( undef ) fstr->bv_len++;
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s:=%s)",