]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/filter.c
Cleanup and SIGTRAP
[openldap] / servers / slapd / filter.c
index 38f99a7f610931d401b6663eae6f126e62ee2b51..fe1db8995c6e2d26bcaa1a7f7b27ae3632aa2a8c 100644 (file)
@@ -1,8 +1,27 @@
 /* filter.c - routines for parsing and dealing with filters */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms are permitted
+ * provided that this notice is preserved and that due credit is given
+ * to the University of Michigan at Ann Arbor. The name of the University
+ * may not be used to endorse or promote products derived from this
+ * software without specific prior written permission. This software
+ * is provided ``as is'' without express or implied warranty.
  */
 
 #include "portable.h"
@@ -26,6 +45,11 @@ static int   get_ssa(
        SubstringsAssertion **s,
        const char **text );
 
+static int filter_escape_value_x(
+       struct berval *in,
+       struct berval *out,
+       void *ctx );
+
 static void simple_vrFilter2bv(
        Operation *op,
        ValuesReturnFilter *f,
@@ -177,6 +201,18 @@ get_filter(
 
                if( err != LDAP_SUCCESS ) {
                        /* unrecognized attribute description or other error */
+#ifdef NEW_LOGGING
+                       LDAP_LOG( FILTER, ERR, 
+                               "get_filter: conn %d unknown attribute "
+                               "type=%s (%d)\n",
+                               op->o_connid, type.bv_val, err );
+#else
+                       Debug( LDAP_DEBUG_ANY, 
+                               "get_filter: conn %d unknown attribute "
+                               "type=%s (%d)\n",
+                               op->o_connid, type.bv_val, err );
+#endif
+
                        f.f_choice = SLAPD_FILTER_COMPUTED;
                        f.f_result = LDAP_COMPARE_FALSE;
                        err = LDAP_SUCCESS;
@@ -252,20 +288,22 @@ get_filter(
 
                assert( f.f_not != NULL );
                if ( f.f_not->f_choice == SLAPD_FILTER_COMPUTED ) {
-                       if ( f.f_not->f_result == LDAP_COMPARE_TRUE ) {
-                               op->o_tmpfree( f.f_not, op->o_tmpmemctx );
-                               f.f_not = NULL;
-                               f.f_choice = SLAPD_FILTER_COMPUTED;
+                       int fresult = f.f_not->f_result;
+                       f.f_choice = SLAPD_FILTER_COMPUTED;
+                       op->o_tmpfree( f.f_not, op->o_tmpmemctx );
+                       f.f_not = NULL;
+
+                       switch( fresult ) {
+                       case LDAP_COMPARE_TRUE:
                                f.f_result = LDAP_COMPARE_FALSE;
-                       } else if ( f.f_not->f_result == LDAP_COMPARE_FALSE ) {
-                               op->o_tmpfree( f.f_not, op->o_tmpmemctx );
-                               f.f_not = NULL;
-                               f.f_choice = SLAPD_FILTER_COMPUTED;
+                               break;
+                       case LDAP_COMPARE_FALSE:
                                f.f_result = LDAP_COMPARE_TRUE;
+                               break;
+                       default: ;
+                               /* (!Undefined) is Undefined */
                        }
-                       /* Leave UNDEFINED alone */
                }
-                               
                break;
 
        case LDAP_FILTER_EXT:
@@ -375,6 +413,7 @@ get_ssa(
        SubstringsAssertion ssa;
 
        *text = "error decoding filter";
+       *out = NULL;
 
 #ifdef NEW_LOGGING
        LDAP_LOG( FILTER, ENTRY, 
@@ -396,6 +435,16 @@ get_ssa(
        rc = slap_bv2ad( &desc, &ssa.sa_desc, text );
 
        if( rc != LDAP_SUCCESS ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG( FILTER, ERR, 
+                       "get_ssa: conn %d d unknown attribute type=%s (%d)\n",
+                       op->o_connid, desc.bv_val, rc );
+#else
+               Debug( LDAP_DEBUG_ANY, 
+                       "get_ssa: conn %d unknown attribute type=%s (%d)\n",
+                       op->o_connid, desc.bv_val, rc );
+#endif
+
                /* skip over the rest of this filter */
                for ( tag = ber_first_element( ber, &len, &last );
                        tag != LBER_DEFAULT;
@@ -563,7 +612,7 @@ return_error:
        Debug( LDAP_DEBUG_FILTER, "end get_ssa\n", 0, 0, 0 );
 #endif
 
-       return LDAP_SUCCESS;
+       return rc /* LDAP_SUCCESS */ ;
 }
 
 void
@@ -640,13 +689,20 @@ filter_free( Filter *f )
 void
 filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
 {
-       int     i;
-       Filter  *p;
-       struct berval tmp;
-       ber_len_t len;
+       int             i;
+       Filter          *p;
+       struct berval   tmp;
+       static struct berval
+                       ber_bvfalse = BER_BVC( "(?=false)" ),
+                       ber_bvtrue = BER_BVC( "(?=true)" ),
+                       ber_bvundefined = BER_BVC( "(?=undefined)" ),
+                       ber_bverror = BER_BVC( "(?=error)" ),
+                       ber_bvunknown = BER_BVC( "(?=unknown)" ),
+                       ber_bvnone = BER_BVC( "(?=none)" );
+       ber_len_t       len;
 
        if ( f == NULL ) {
-               ber_str2bv_x( "No filter!", sizeof("No filter!")-1, 1, fstr, op->o_tmpmemctx );
+               ber_dupbv_x( fstr, &ber_bvnone, op->o_tmpmemctx );
                return;
        }
 
@@ -720,7 +776,8 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        filter_escape_value_x( &f->f_sub_initial, &tmp, op->o_tmpmemctx );
 
                        fstr->bv_len += tmp.bv_len;
-                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                               op->o_tmpmemctx );
 
                        snprintf( &fstr->bv_val[len-2], tmp.bv_len+3,
                                /* "(attr=" */ "%s*)",
@@ -732,10 +789,12 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                if ( f->f_sub_any != NULL ) {
                        for ( i = 0; f->f_sub_any[i].bv_val != NULL; i++ ) {
                                len = fstr->bv_len;
-                               filter_escape_value_x( &f->f_sub_any[i], &tmp, op->o_tmpmemctx );
+                               filter_escape_value_x( &f->f_sub_any[i],
+                                       &tmp, op->o_tmpmemctx );
 
                                fstr->bv_len += tmp.bv_len + 1;
-                               fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                               fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                                       op->o_tmpmemctx );
 
                                snprintf( &fstr->bv_val[len-1], tmp.bv_len+3,
                                        /* "(attr=[init]*[any*]" */ "%s*)",
@@ -750,7 +809,8 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        filter_escape_value_x( &f->f_sub_final, &tmp, op->o_tmpmemctx );
 
                        fstr->bv_len += tmp.bv_len;
-                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                               op->o_tmpmemctx );
 
                        snprintf( &fstr->bv_val[len-1], tmp.bv_len+3,
                                /* "(attr=[init*][any*]" */ "%s)",
@@ -786,7 +846,8 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                        filter2bv_x( op, p, &tmp );
                        
                        fstr->bv_len += tmp.bv_len;
-                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                               op->o_tmpmemctx );
 
                        snprintf( &fstr->bv_val[len-1], tmp.bv_len + 2, 
                                /*"("*/ "%s)", tmp.bv_val );
@@ -797,46 +858,55 @@ filter2bv_x( Operation *op, Filter *f, struct berval *fstr )
                break;
 
        case LDAP_FILTER_EXT: {
-               struct berval ad;
-               filter_escape_value_x( &f->f_mr_value, &tmp, op->o_tmpmemctx );
-
-               if ( f->f_mr_desc ) {
-                       ad = f->f_mr_desc->ad_cname;
-               } else {
-                       ad.bv_len = 0;
-                       ad.bv_val = "";
-               }
+                       struct berval ad;
+                       filter_escape_value_x( &f->f_mr_value, &tmp, op->o_tmpmemctx );
+
+                       if ( f->f_mr_desc ) {
+                               ad = f->f_mr_desc->ad_cname;
+                       } else {
+                               ad.bv_len = 0;
+                               ad.bv_val = "";
+                       }
                        
-               fstr->bv_len = ad.bv_len +
-                       ( f->f_mr_dnattrs ? sizeof(":dn")-1 : 0 ) +
-                       ( f->f_mr_rule_text.bv_len ? f->f_mr_rule_text.bv_len+1 : 0 ) +
-                       tmp.bv_len + ( sizeof("(:=)") - 1 );
-               fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
-
-               snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s:=%s)",
-                       ad.bv_val,
-                       f->f_mr_dnattrs ? ":dn" : "",
-                       f->f_mr_rule_text.bv_len ? ":" : "",
-                       f->f_mr_rule_text.bv_len ? f->f_mr_rule_text.bv_val : "",
-                       tmp.bv_val );
-               ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
+                       fstr->bv_len = ad.bv_len +
+                               ( f->f_mr_dnattrs ? sizeof(":dn")-1 : 0 ) +
+                               ( f->f_mr_rule_text.bv_len ? f->f_mr_rule_text.bv_len+1 : 0 ) +
+                               tmp.bv_len + ( sizeof("(:=)") - 1 );
+                       fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
+
+                       snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s:=%s)",
+                               ad.bv_val,
+                               f->f_mr_dnattrs ? ":dn" : "",
+                               f->f_mr_rule_text.bv_len ? ":" : "",
+                               f->f_mr_rule_text.bv_len ? f->f_mr_rule_text.bv_val : "",
+                               tmp.bv_val );
+                       ber_memfree_x( tmp.bv_val, op->o_tmpmemctx );
                } break;
 
        case SLAPD_FILTER_COMPUTED:
-               ber_str2bv_x(
-                       f->f_result == LDAP_COMPARE_FALSE ? "(?=false)" :
-                       f->f_result == LDAP_COMPARE_TRUE ? "(?=true)" :
-                       f->f_result == SLAPD_COMPARE_UNDEFINED ? "(?=undefined)" :
-                       "(?=error)",
-                       f->f_result == LDAP_COMPARE_FALSE ? sizeof("(?=false)")-1 :
-                       f->f_result == LDAP_COMPARE_TRUE ? sizeof("(?=true)")-1 :
-                       f->f_result == SLAPD_COMPARE_UNDEFINED ? sizeof("(?=undefined)")-1 :
-                       sizeof("(?=error)")-1,
-                       1, fstr, op->o_tmpmemctx );
-               break;
+               switch ( f->f_result ) {
+               case LDAP_COMPARE_FALSE:
+                       tmp = ber_bvfalse;
+                       break;
 
+               case LDAP_COMPARE_TRUE:
+                       tmp = ber_bvtrue;
+                       break;
+                       
+               case SLAPD_COMPARE_UNDEFINED:
+                       tmp = ber_bvundefined;
+                       break;
+                       
+               default:
+                       tmp = ber_bverror;
+                       break;
+               }
+
+               ber_dupbv_x( fstr, &tmp, op->o_tmpmemctx );
+               break;
+               
        default:
-               ber_str2bv_x( "(?=unknown)", sizeof("(?=unknown)")-1, 1, fstr, op->o_tmpmemctx );
+               ber_dupbv_x( fstr, &ber_bvunknown, op->o_tmpmemctx );
                break;
        }
 }
@@ -851,7 +921,7 @@ filter2bv( Filter *f, struct berval *fstr )
        filter2bv_x( &op, f, fstr );
 }
 
-int
+static int
 filter_escape_value_x(
        struct berval *in,
        struct berval *out,
@@ -990,6 +1060,18 @@ get_simple_vrFilter(
 
                if( err != LDAP_SUCCESS ) {
                        /* unrecognized attribute description or other error */
+#ifdef NEW_LOGGING
+                       LDAP_LOG( FILTER, ERR, 
+                               "get_simple_vrFilter: conn %d unknown "
+                               "attribute type=%s (%d)\n",
+                               op->o_connid, type.bv_val, err );
+#else
+                       Debug( LDAP_DEBUG_ANY, 
+                               "get_simple_vrFilter: conn %d unknown "
+                               "attribute type=%s (%d)\n",
+                               op->o_connid, type.bv_val, err );
+#endif
+
                        vrf.vrf_choice = SLAPD_FILTER_COMPUTED;
                        vrf.vrf_result = LDAP_COMPARE_FALSE;
                        err = LDAP_SUCCESS;
@@ -1186,8 +1268,8 @@ vrFilter_free( Operation *op, ValuesReturnFilter *vrf )
 
                default:
 #ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, ERR, 
-                               "filter_free: unknown filter type %lu\n", vrf->vrf_choice, 0, 0 );
+                       LDAP_LOG( FILTER, ERR, "filter_free: unknown filter type %lu\n",
+                               vrf->vrf_choice, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY, "filter_free: unknown filter type=%lu\n",
                                vrf->vrf_choice, 0, 0 );
@@ -1207,7 +1289,8 @@ vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr )
        ber_len_t len;
 
        if ( vrf == NULL ) {
-               ber_str2bv_x( "No filter!", sizeof("No filter!")-1, 1, fstr, op->o_tmpmemctx );
+               ber_str2bv_x( "No filter!", sizeof("No filter!")-1,
+                       1, fstr, op->o_tmpmemctx );
                return;
        }
 
@@ -1222,7 +1305,8 @@ vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr )
                simple_vrFilter2bv( op, p, &tmp );
                        
                fstr->bv_len += tmp.bv_len;
-               fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+               fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                       op->o_tmpmemctx );
 
                snprintf( &fstr->bv_val[len-1], tmp.bv_len + 2, 
                        /*"("*/ "%s)", tmp.bv_val );
@@ -1238,7 +1322,8 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
        ber_len_t len;
 
        if ( vrf == NULL ) {
-               ber_str2bv_x( "No filter!", sizeof("No filter!")-1, 1, fstr, op->o_tmpmemctx );
+               ber_str2bv_x( "No filter!", sizeof("No filter!")-1, 1, fstr,
+                       op->o_tmpmemctx );
                return;
        }
 
@@ -1312,7 +1397,8 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
                        filter_escape_value_x( &vrf->vrf_sub_initial, &tmp, op->o_tmpmemctx );
 
                        fstr->bv_len += tmp.bv_len;
-                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                               op->o_tmpmemctx );
 
                        snprintf( &fstr->bv_val[len-2], tmp.bv_len+3,
                                /* "(attr=" */ "%s*)",
@@ -1325,10 +1411,12 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
                        int i;
                        for ( i = 0; vrf->vrf_sub_any[i].bv_val != NULL; i++ ) {
                                len = fstr->bv_len;
-                               filter_escape_value_x( &vrf->vrf_sub_any[i], &tmp, op->o_tmpmemctx );
+                               filter_escape_value_x( &vrf->vrf_sub_any[i], &tmp,
+                                       op->o_tmpmemctx );
 
                                fstr->bv_len += tmp.bv_len + 1;
-                               fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                               fstr->bv_val = op->o_tmprealloc( fstr->bv_val,
+                                       fstr->bv_len + 1, op->o_tmpmemctx );
 
                                snprintf( &fstr->bv_val[len-1], tmp.bv_len+3,
                                        /* "(attr=[init]*[any*]" */ "%s*)",
@@ -1343,7 +1431,8 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
                        filter_escape_value_x( &vrf->vrf_sub_final, &tmp, op->o_tmpmemctx );
 
                        fstr->bv_len += tmp.bv_len;
-                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1, op->o_tmpmemctx );
+                       fstr->bv_val = op->o_tmprealloc( fstr->bv_val, fstr->bv_len + 1,
+                               op->o_tmpmemctx );
 
                        snprintf( &fstr->bv_val[len-1], tmp.bv_len+3,
                                /* "(attr=[init*][any*]" */ "%s)",
@@ -1376,7 +1465,8 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
                        
                fstr->bv_len = ad.bv_len +
                        ( vrf->vrf_mr_dnattrs ? sizeof(":dn")-1 : 0 ) +
-                       ( vrf->vrf_mr_rule_text.bv_len ? vrf->vrf_mr_rule_text.bv_len+1 : 0 ) +
+                       ( vrf->vrf_mr_rule_text.bv_len
+                               ? vrf->vrf_mr_rule_text.bv_len+1 : 0 ) +
                        tmp.bv_len + ( sizeof("(:=)") - 1 );
                fstr->bv_val = op->o_tmpalloc( fstr->bv_len + 1, op->o_tmpmemctx );
 
@@ -1394,208 +1484,18 @@ simple_vrFilter2bv( Operation *op, ValuesReturnFilter *vrf, struct berval *fstr
                ber_str2bv_x(
                        vrf->vrf_result == LDAP_COMPARE_FALSE ? "(?=false)" :
                        vrf->vrf_result == LDAP_COMPARE_TRUE ? "(?=true)" :
-                       vrf->vrf_result == SLAPD_COMPARE_UNDEFINED ? "(?=undefined)" :
-                       "(?=error)",
+                       vrf->vrf_result == SLAPD_COMPARE_UNDEFINED
+                               ? "(?=undefined)" : "(?=error)",
                        vrf->vrf_result == LDAP_COMPARE_FALSE ? sizeof("(?=false)")-1 :
                        vrf->vrf_result == LDAP_COMPARE_TRUE ? sizeof("(?=true)")-1 :
-                       vrf->vrf_result == SLAPD_COMPARE_UNDEFINED ? sizeof("(?=undefined)")-1 :
-                       sizeof("(?=error)")-1,
+                       vrf->vrf_result == SLAPD_COMPARE_UNDEFINED
+                               ? sizeof("(?=undefined)")-1 : sizeof("(?=error)")-1,
                        1, fstr, op->o_tmpmemctx );
                break;
 
        default:
-               ber_str2bv_x( "(?=unknown)", sizeof("(?=unknown)")-1, 1, fstr, op->o_tmpmemctx );
+               ber_str2bv_x( "(?=unknown)", sizeof("(?=unknown)")-1,
+                       1, fstr, op->o_tmpmemctx );
                break;
        }
 }
-
-#if 0 /* unused */
-static int
-get_substring_vrFilter(
-       Operation *op,
-       BerElement      *ber,
-       ValuesReturnFilter      *vrf,
-       const char      **text )
-{
-       ber_tag_t       tag;
-       ber_len_t       len;
-       ber_tag_t       rc;
-       struct berval value;
-       char            *last;
-       struct berval bv;
-       *text = "error decoding filter";
-
-#ifdef NEW_LOGGING
-       LDAP_LOG( FILTER, ENTRY, 
-               "get_substring_filter: conn %d  begin\n", op->o_connid, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_FILTER, "begin get_substring_filter\n", 0, 0, 0 );
-#endif
-       if ( ber_scanf( ber, "{m" /*}*/, &bv ) == LBER_ERROR ) {
-               return SLAPD_DISCONNECT;
-       }
-
-       vrf->vrf_sub = ch_calloc( 1, sizeof(SubstringsAssertion) );
-       vrf->vrf_sub_desc = NULL;
-       rc = slap_bv2ad( &bv, &vrf->vrf_sub_desc, text );
-
-       if( rc != LDAP_SUCCESS ) {
-               text = NULL;
-               ch_free( vrf->vrf_sub );
-               vrf->vrf_choice = SLAPD_FILTER_COMPUTED;
-               vrf->vrf_result = SLAPD_COMPARE_UNDEFINED;
-               return LDAP_SUCCESS;
-       }
-
-       vrf->vrf_sub_initial.bv_val = NULL;
-       vrf->vrf_sub_any = NULL;
-       vrf->vrf_sub_final.bv_val = NULL;
-
-       for ( tag = ber_first_element( ber, &len, &last ); tag != LBER_DEFAULT;
-               tag = ber_next_element( ber, &len, last ) )
-       {
-               unsigned usage;
-
-               rc = ber_scanf( ber, "m", &value );
-               if ( rc == LBER_ERROR ) {
-                       rc = SLAPD_DISCONNECT;
-                       goto return_error;
-               }
-
-               if ( value.bv_val == NULL || value.bv_len == 0 ) {
-                       rc = LDAP_INVALID_SYNTAX;
-                       goto return_error;
-               } 
-
-               switch ( tag ) {
-               case LDAP_SUBSTRING_INITIAL:
-                       usage = SLAP_MR_SUBSTR_INITIAL;
-                       break;
-
-               case LDAP_SUBSTRING_ANY:
-                       usage = SLAP_MR_SUBSTR_ANY;
-                       break;
-
-               case LDAP_SUBSTRING_FINAL:
-                       usage = SLAP_MR_SUBSTR_FINAL;
-                       break;
-
-               default:
-                       rc = LDAP_PROTOCOL_ERROR;
-
-#ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, ERR, 
-                               "get_filter_substring: conn %d  unknown substring choice=%ld\n",
-                               op->o_connid, (long)tag, 0 );
-#else
-                       Debug( LDAP_DEBUG_FILTER,
-                               "  unknown substring choice=%ld\n",
-                               (long) tag, 0, 0 );
-#endif
-                       goto return_error;
-               }
-
-               /* validate/normalize using equality matching rule validator! */
-               rc = asserted_value_validate_normalize(
-                       vrf->vrf_sub_desc, vrf->vrf_sub_desc->ad_type->sat_equality,
-                       usage, &value, &bv, text );
-               if( rc != LDAP_SUCCESS ) {
-                       goto return_error;
-               }
-
-               value = bv;
-
-               rc = LDAP_PROTOCOL_ERROR;
-
-               switch ( tag ) {
-               case LDAP_SUBSTRING_INITIAL:
-#ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, DETAIL1, 
-                               "get_substring_filter: conn %d  INITIAL\n", 
-                               op->o_connid, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_FILTER, "  INITIAL\n", 0, 0, 0 );
-#endif
-
-                       if ( vrf->vrf_sub_initial.bv_val != NULL
-                               || vrf->vrf_sub_any != NULL 
-                               || vrf->vrf_sub_final.bv_val != NULL )
-                       {
-                               free( value.bv_val );
-                               goto return_error;
-                       }
-
-                       vrf->vrf_sub_initial = value;
-                       break;
-
-               case LDAP_SUBSTRING_ANY:
-#ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, DETAIL1, 
-                               "get_substring_filter: conn %d  ANY\n", op->o_connid, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_FILTER, "  ANY\n", 0, 0, 0 );
-#endif
-
-                       if ( vrf->vrf_sub_final.bv_val != NULL ) {
-                               free( value.bv_val );
-                               goto return_error;
-                       }
-
-                       ber_bvarray_add( &vrf->vrf_sub_any, &value );
-                       break;
-
-               case LDAP_SUBSTRING_FINAL:
-#ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, DETAIL1, 
-                               "get_substring_filter: conn %d  FINAL\n", op->o_connid, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_FILTER, "  FINAL\n", 0, 0, 0 );
-#endif
-
-                       if ( vrf->vrf_sub_final.bv_val != NULL ) {
-                               free( value.bv_val );
-                               goto return_error;
-                       }
-
-                       vrf->vrf_sub_final = value;
-                       break;
-
-               default:
-#ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, INFO, 
-                               "get_substring_filter: conn %d  unknown substring type %ld\n",
-                               op->o_connid, (long)tag, 0 );
-#else
-                       Debug( LDAP_DEBUG_FILTER,
-                               "  unknown substring type=%ld\n",
-                               (long) tag, 0, 0 );
-#endif
-
-                       free( value.bv_val );
-
-return_error:
-#ifdef NEW_LOGGING
-                       LDAP_LOG( FILTER, INFO, 
-                               "get_substring_filter: conn %d  error %ld\n",
-                               op->o_connid, (long)rc, 0 );
-#else
-                       Debug( LDAP_DEBUG_FILTER, "  error=%ld\n",
-                               (long) rc, 0, 0 );
-#endif
-                       free( vrf->vrf_sub_initial.bv_val );
-                       ber_bvarray_free( vrf->vrf_sub_any );
-                       free( vrf->vrf_sub_final.bv_val );
-                       ch_free( vrf->vrf_sub );
-                       return rc;
-               }
-       }
-
-#ifdef NEW_LOGGING
-       LDAP_LOG( FILTER, ENTRY, 
-               "get_substring_filter: conn %d exit\n", op->o_connid, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_FILTER, "end get_substring_filter\n", 0, 0, 0 );
-#endif
-       return( LDAP_SUCCESS );
-}
-#endif /* unused */