]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/filterentry.c
document search disable feature (spin-off of limit on unchecked entries)
[openldap] / servers / slapd / filterentry.c
index d808ea71542aedba7d509adc4e429b6cf6ee0a9d..86a2db459dfcb135928fb68383a85d16df8713ae 100644 (file)
@@ -1,8 +1,27 @@
 /* filterentry.c - apply a filter to an entry */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms are permitted
+ * provided that this notice is preserved and that due credit is given
+ * to the University of Michigan at Ann Arbor. The name of the University
+ * may not be used to endorse or promote products derived from this
+ * software without specific prior written permission. This software
+ * is provided ``as is'' without express or implied warranty.
  */
 
 #include "portable.h"
 
 #include "slap.h"
 
-static int     test_filter_and( Backend *be,
-       Connection *conn, Operation *op,
-       Entry *e, Filter *flist );
-static int     test_filter_or( Backend *be,
-       Connection *conn, Operation *op,
-       Entry *e, Filter *flist );
-static int     test_substrings_filter( Backend *be,
-       Connection *conn, Operation *op,
-       Entry *e, Filter *f);
-static int     test_ava_filter( Backend *be,
-       Connection *conn, Operation *op,
-       Entry *e, AttributeAssertion *ava, int type );
-static int     test_mra_filter( Backend *be,
-       Connection *conn, Operation *op,
-       Entry *e, MatchingRuleAssertion *mra );
-static int     test_presence_filter( Backend *be,
-       Connection *conn, Operation *op,
-       Entry *e, AttributeDescription *desc );
+static int     test_filter_and( Operation *op, Entry *e, Filter *flist );
+static int     test_filter_or( Operation *op, Entry *e, Filter *flist );
+static int     test_substrings_filter( Operation *op, Entry *e, Filter *f);
+static int     test_ava_filter( Operation *op, Entry *e, AttributeAssertion *ava, int type );
+static int     test_mra_filter( Operation *op, Entry *e, MatchingRuleAssertion *mra );
+static int     test_presence_filter( Operation *op, Entry *e, AttributeDescription *desc );
 
 
 /*
@@ -46,33 +53,27 @@ static int  test_presence_filter( Backend *be,
 
 int
 test_filter(
-    Backend    *be,
-    Connection *conn,
     Operation  *op,
     Entry      *e,
     Filter     *f
 )
 {
        int     rc;
-
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_filter: begin\n" ));
+       LDAP_LOG( FILTER, ENTRY, "test_filter: begin\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "=> test_filter\n", 0, 0, 0 );
 #endif
 
-
        switch ( f->f_choice ) {
        case SLAPD_FILTER_COMPUTED:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:   COMPUTED %s (%d)\n",
-                          f->f_result == LDAP_COMPARE_FALSE ? "false" :
-                          f->f_result == LDAP_COMPARE_TRUE      ? "true"  :
-                          f->f_result == SLAPD_COMPARE_UNDEFINED ? "undefined" :
-                          "error",
-                          f->f_result ));
+               LDAP_LOG( FILTER, DETAIL1,
+                       "test_filter:   COMPUTED %s (%d)\n",
+                       f->f_result == LDAP_COMPARE_FALSE ? "false" :
+                       f->f_result == LDAP_COMPARE_TRUE         ? "true"  :
+                       f->f_result == SLAPD_COMPARE_UNDEFINED ? "undefined" :
+                       "error", f->f_result, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    COMPUTED %s (%d)\n",
                        f->f_result == LDAP_COMPARE_FALSE ? "false" :
@@ -86,90 +87,83 @@ test_filter(
 
        case LDAP_FILTER_EQUALITY:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:   EQUALITY\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter:   EQUALITY\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    EQUALITY\n", 0, 0, 0 );
 #endif
 
-               rc = test_ava_filter( be, conn, op, e, f->f_ava,
+               rc = test_ava_filter( op, e, f->f_ava,
                    LDAP_FILTER_EQUALITY );
                break;
 
        case LDAP_FILTER_SUBSTRINGS:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter  SUBSTRINGS\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter  SUBSTRINGS\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    SUBSTRINGS\n", 0, 0, 0 );
 #endif
 
-               rc = test_substrings_filter( be, conn, op, e, f );
+               rc = test_substrings_filter( op, e, f );
                break;
 
        case LDAP_FILTER_GE:
-               rc = test_ava_filter( be, conn, op, e, f->f_ava,
+               rc = test_ava_filter( op, e, f->f_ava,
                    LDAP_FILTER_GE );
                break;
 
        case LDAP_FILTER_LE:
-               rc = test_ava_filter( be, conn, op, e, f->f_ava,
+               rc = test_ava_filter( op, e, f->f_ava,
                    LDAP_FILTER_LE );
                break;
 
        case LDAP_FILTER_PRESENT:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:        PRESENT\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter:        PRESENT\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    PRESENT\n", 0, 0, 0 );
 #endif
 
-               rc = test_presence_filter( be, conn, op, e, f->f_desc );
+               rc = test_presence_filter( op, e, f->f_desc );
                break;
 
        case LDAP_FILTER_APPROX:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter: APPROX\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter: APPROX\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    APPROX\n", 0, 0, 0 );
 #endif
-               rc = test_ava_filter( be, conn, op, e, f->f_ava,
+               rc = test_ava_filter( op, e, f->f_ava,
                    LDAP_FILTER_APPROX );
                break;
 
        case LDAP_FILTER_AND:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:  AND\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter:  AND\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    AND\n", 0, 0, 0 );
 #endif
 
-               rc = test_filter_and( be, conn, op, e, f->f_and );
+               rc = test_filter_and( op, e, f->f_and );
                break;
 
        case LDAP_FILTER_OR:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:        OR\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter:        OR\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    OR\n", 0, 0, 0 );
 #endif
 
-               rc = test_filter_or( be, conn, op, e, f->f_or );
+               rc = test_filter_or( op, e, f->f_or );
                break;
 
        case LDAP_FILTER_NOT:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:        NOT\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter:        NOT\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    NOT\n", 0, 0, 0 );
 #endif
 
-               rc = test_filter( be, conn, op, e, f->f_not );
+               rc = test_filter( op, e, f->f_not );
 
                /* Flip true to false and false to true
                 * but leave Undefined alone.
@@ -186,20 +180,18 @@ test_filter(
 
        case LDAP_FILTER_EXT:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_DETAIL1,
-                          "test_filter:        EXT\n" ));
+               LDAP_LOG( FILTER, DETAIL1, "test_filter:        EXT\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_FILTER, "    EXT\n", 0, 0, 0 );
 #endif
 
-               rc = test_mra_filter( be, conn, op, e, f->f_mra );
+               rc = test_mra_filter( op, e, f->f_mra );
                break;
 
        default:
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "filter", LDAP_LEVEL_INFO,
-                          "test_filter:  unknown filter type %lu\n", 
-                      f->f_choice ));
+               LDAP_LOG( FILTER, INFO, 
+                       "test_filter:  unknown filter type %lu\n", f->f_choice, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "    unknown filter type %lu\n",
                    f->f_choice, 0, 0 );
@@ -209,8 +201,7 @@ test_filter(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_filter:  return=%d\n", rc ));
+       LDAP_LOG( FILTER, RESULTS, "test_filter:  return=%d\n", rc, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "<= test_filter %d\n", rc, 0, 0 );
 #endif
@@ -219,52 +210,179 @@ test_filter(
 }
 
 static int test_mra_filter(
-       Backend *be,
-       Connection *conn,
        Operation *op,
        Entry *e,
        MatchingRuleAssertion *mra )
 {
        Attribute       *a;
+       void *memctx = op ? op->o_tmpmemctx : NULL;
 
-       if( !access_allowed( be, conn, op, e,
-               mra->ma_desc, &mra->ma_value, ACL_SEARCH, NULL ) )
-       {
-               return LDAP_INSUFFICIENT_ACCESS;
-       }
+       if ( mra->ma_desc ) {
+               /*
+                * if ma_desc is available, then we're filtering for
+                * one attribute, and SEARCH permissions can be checked
+                * directly.
+                */
+               if( !access_allowed( op, e,
+                       mra->ma_desc, &mra->ma_value, ACL_SEARCH, NULL ) )
+               {
+                       return LDAP_INSUFFICIENT_ACCESS;
+               }
 
-       if( strcmp(mra->ma_rule->smr_syntax->ssyn_oid,
-               mra->ma_desc->ad_type->sat_syntax->ssyn_oid) != 0)
-       {
-               return LDAP_INVALID_SYNTAX;
-       }
+               for(a = attrs_find( e->e_attrs, mra->ma_desc );
+                       a != NULL;
+                       a = attrs_find( a->a_next, mra->ma_desc ) )
+               {
+                       struct berval *bv;
+                       /* If ma_rule is not the same as the attribute's
+                        * normal rule, then we can't use the a_nvals.
+                        */
+                       if (mra->ma_rule == a->a_desc->ad_type->sat_equality) {
+                               bv = a->a_nvals;
+                       } else {
+                               bv = a->a_vals;
+                       }
 
-       if( mra->ma_rule == NULL )
-       {
-               return LDAP_INAPPROPRIATE_MATCHING;
-       }
+                       for ( ; bv->bv_val != NULL; bv++ ) {
+                               int ret;
+                               int rc;
+                               const char *text;
+       
+                               rc = value_match( &ret, a->a_desc, mra->ma_rule, 0,
+                                       bv, &mra->ma_value, &text );
+       
+                               if( rc != LDAP_SUCCESS ) {
+                                       return rc;
+                               }
+       
+                               if ( ret == 0 ) {
+                                       return LDAP_COMPARE_TRUE;
+                               }
+                       }
+               }
+       } else {
 
-       for(a = attrs_find( e->e_attrs, mra->ma_desc );
-               a != NULL;
-               a = attrs_find( a->a_next, mra->ma_desc ) )
-       {
-               struct berval *bv;
-               for ( bv = a->a_vals; bv->bv_val != NULL; bv++ ) {
-                       int ret;
-                       int rc;
-                       const char *text;
+               /*
+                * No attribute description: test all
+                */
+               for ( a = e->e_attrs; a != NULL; a = a->a_next ) {
+                       struct berval   *bv, value;
+                       const char      *text = NULL;
+                       int             rc;
+
+                       /* check if matching is appropriate */
+                       if ( !mr_usable_with_at( mra->ma_rule, a->a_desc->ad_type )) {
+                               continue;
+                       }
 
-                       rc = value_match( &ret, a->a_desc, mra->ma_rule,
-                               SLAP_MR_ASSERTION_SYNTAX_MATCH,
-                               bv, &mra->ma_value,
-                               &text );
+                       /* normalize for equality */
+                       rc = asserted_value_validate_normalize( a->a_desc, mra->ma_rule,
+                               SLAP_MR_EXT|SLAP_MR_VALUE_OF_ASSERTION_SYNTAX,
+                               &mra->ma_value, &value, &text, memctx );
+                       if ( rc != LDAP_SUCCESS ) {
+                               continue;
+                       }
 
-                       if( rc != LDAP_SUCCESS ) {
-                               return rc;
+                       /* check search access */
+                       if ( !access_allowed( op, e,
+                               a->a_desc, &value, ACL_SEARCH, NULL ) ) {
+                               continue;
                        }
 
-                       if ( ret ) {
-                               return LDAP_COMPARE_TRUE;
+                       /* check match */
+                       if (mra->ma_rule == a->a_desc->ad_type->sat_equality)
+                               bv = a->a_nvals;
+                       else
+                               bv = a->a_vals;
+                       for ( ; bv->bv_val != NULL; bv++ )
+                       {
+                               int ret;
+                               int rc;
+       
+                               rc = value_match( &ret, a->a_desc, mra->ma_rule, 0,
+                                       bv, &value, &text );
+       
+                               if( rc != LDAP_SUCCESS ) {
+                                       return rc;
+                               }
+       
+                               if ( ret == 0 ) {
+                                       return LDAP_COMPARE_TRUE;
+                               }
+                       }
+               }
+       }
+
+       /* check attrs in DN AVAs if required */
+       if ( mra->ma_dnattrs ) {
+               LDAPDN          dn = NULL;
+               int             iRDN, iAVA;
+               int             rc;
+
+               /* parse and pretty the dn */
+               rc = dnPrettyDN( NULL, &e->e_name, &dn, memctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               /* for each AVA of each RDN ... */
+               for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
+                       LDAPRDN         rdn = dn[ iRDN ];
+
+                       for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
+                               LDAPAVA         *ava = rdn[ iAVA ];
+                               struct berval   *bv = &ava->la_value, value;
+                               AttributeDescription *ad = (AttributeDescription *)ava->la_private;
+                               int ret;
+                               int rc;
+                               const char *text;
+
+                               assert( ad );
+
+                               if ( mra->ma_desc ) {
+                                       /* have a mra type? check for subtype */
+                                       if ( !is_ad_subtype( ad, mra->ma_desc ) ) {
+                                               continue;
+                                       }
+                                       value = mra->ma_value;
+
+                               } else {
+                                       const char      *text = NULL;
+
+                                       /* check if matching is appropriate */
+                                       if ( !mr_usable_with_at( mra->ma_rule, ad->ad_type )) {
+                                               continue;
+                                       }
+
+                                       /* normalize for equality */
+                                       rc = asserted_value_validate_normalize( ad,
+                                               mra->ma_rule,
+                                               SLAP_MR_EXT|SLAP_MR_VALUE_OF_ASSERTION_SYNTAX,
+                                               &mra->ma_value, &value, &text, memctx );
+                                       if ( rc != LDAP_SUCCESS ) {
+                                               continue;
+                                       }
+
+                                       /* check search access */
+                                       if ( !access_allowed( op, e,
+                                               ad, &value, ACL_SEARCH, NULL ) ) {
+                                               continue;
+                                       }
+                               }
+
+                               /* check match */
+                               rc = value_match( &ret, ad, mra->ma_rule, 0,
+                                       bv, &value, &text );
+
+                               if( rc != LDAP_SUCCESS ) {
+                                       ldap_dnfree_x( dn, memctx );
+                                       return rc;
+                               }
+
+                               if ( ret == 0 ) {
+                                       ldap_dnfree_x( dn, memctx );
+                                       return LDAP_COMPARE_TRUE;
+                               }
                        }
                }
        }
@@ -274,17 +392,15 @@ static int test_mra_filter(
 
 static int
 test_ava_filter(
-    Backend    *be,
-    Connection *conn,
-    Operation  *op,
-    Entry      *e,
+       Operation       *op,
+       Entry           *e,
        AttributeAssertion *ava,
-    int                type
+       int             type
 )
 {
        Attribute       *a;
 
-       if ( !access_allowed( be, conn, op, e,
+       if ( !access_allowed( op, e,
                ava->aa_desc, &ava->aa_value, ACL_SEARCH, NULL ) )
        {
                return LDAP_INSUFFICIENT_ACCESS;
@@ -321,13 +437,13 @@ test_ava_filter(
                        continue;
                }
 
-               for ( bv = a->a_vals; bv->bv_val != NULL; bv++ ) {
+               for ( bv = a->a_nvals; bv->bv_val != NULL; bv++ )
+               {
                        int ret;
                        int rc;
                        const char *text;
 
-                       rc = value_match( &ret, a->a_desc, mr,
-                               SLAP_MR_ASSERTION_SYNTAX_MATCH,
+                       rc = value_match( &ret, a->a_desc, mr, 0,
                                bv, &ava->aa_value, &text );
 
                        if( rc != LDAP_SUCCESS ) {
@@ -357,51 +473,95 @@ test_ava_filter(
                }
        }
 
+       if ( ava->aa_desc == slap_schema.si_ad_hasSubordinates 
+                       && op && op->o_bd && op->o_bd->be_has_subordinates ) {
+               int             hasSubordinates;
+               struct berval   hs;
+
+               /*
+                * No other match should be allowed ...
+                */
+               assert( type == LDAP_FILTER_EQUALITY );
+               
+               if (op->o_bd->be_has_subordinates( op, e, &hasSubordinates ) != LDAP_SUCCESS) {
+                       return LDAP_OTHER;
+               }
+
+               if ( hasSubordinates == LDAP_COMPARE_TRUE ) {
+                       hs = slap_true_bv;
+
+               } else if ( hasSubordinates == LDAP_COMPARE_FALSE ) {
+                       hs = slap_false_bv;
+
+               } else {
+                       return LDAP_OTHER;
+               }
+
+               if ( bvmatch( &ava->aa_value, &hs ) ) {
+                       return LDAP_COMPARE_TRUE;
+               }
+
+               return LDAP_COMPARE_FALSE;
+       }
+
        return( LDAP_COMPARE_FALSE );
 }
 
 
 static int
 test_presence_filter(
-    Backend    *be,
-    Connection *conn,
-    Operation  *op,
-    Entry      *e,
+       Operation       *op,
+       Entry           *e,
        AttributeDescription *desc
 )
 {
-       if ( !access_allowed( be, conn, op, e, desc, NULL, ACL_SEARCH, NULL ) )
+       Attribute       *a;
+
+       if ( !access_allowed( op, e, desc, NULL, ACL_SEARCH, NULL ) )
        {
                return LDAP_INSUFFICIENT_ACCESS;
        }
 
-       return attrs_find( e->e_attrs, desc ) != NULL
-               ? LDAP_COMPARE_TRUE : LDAP_COMPARE_FALSE;
+       a = attrs_find( e->e_attrs, desc );
+
+       if ( a == NULL && desc == slap_schema.si_ad_hasSubordinates ) {
+
+               /*
+                * XXX: fairly optimistic: if the function is defined,
+                * then PRESENCE must succeed, because hasSubordinate
+                * is boolean-valued; I think we may live with this 
+                * simplification by now
+                */
+               if ( op && op->o_bd && op->o_bd->be_has_subordinates ) {
+                       return LDAP_COMPARE_TRUE;
+               }
+
+               return LDAP_COMPARE_FALSE;
+       }
+
+       return a != NULL ? LDAP_COMPARE_TRUE : LDAP_COMPARE_FALSE;
 }
 
 
 static int
 test_filter_and(
-    Backend    *be,
-    Connection *conn,
-    Operation  *op,
-    Entry      *e,
-    Filter     *flist
+       Operation       *op,
+       Entry   *e,
+       Filter  *flist
 )
 {
        Filter  *f;
        int rtn = LDAP_COMPARE_TRUE; /* True if empty */
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_filter_and: begin\n" ));
+       LDAP_LOG( FILTER, ENTRY, "test_filter_and: begin\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "=> test_filter_and\n", 0, 0, 0 );
 #endif
 
 
        for ( f = flist; f != NULL; f = f->f_next ) {
-               int rc = test_filter( be, conn, op, e, f );
+               int rc = test_filter( op, e, f );
 
                if ( rc == LDAP_COMPARE_FALSE ) {
                        /* filter is False */
@@ -416,8 +576,7 @@ test_filter_and(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_filter_and:  rc=%d\n", rtn ));
+       LDAP_LOG( FILTER, RESULTS, "test_filter_and:  rc=%d\n", rtn, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "<= test_filter_and %d\n", rtn, 0, 0 );
 #endif
@@ -427,26 +586,23 @@ test_filter_and(
 
 static int
 test_filter_or(
-    Backend    *be,
-    Connection *conn,
-    Operation  *op,
-    Entry      *e,
-    Filter     *flist
+       Operation       *op,
+       Entry   *e,
+       Filter  *flist
 )
 {
        Filter  *f;
        int rtn = LDAP_COMPARE_FALSE; /* False if empty */
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_filter_or: begin\n" ));
+       LDAP_LOG( FILTER, ENTRY, "test_filter_or: begin\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "=> test_filter_or\n", 0, 0, 0 );
 #endif
 
 
        for ( f = flist; f != NULL; f = f->f_next ) {
-               int rc = test_filter( be, conn, op, e, f );
+               int rc = test_filter( op, e, f );
 
                if ( rc == LDAP_COMPARE_TRUE ) {
                        /* filter is True */
@@ -461,8 +617,7 @@ test_filter_or(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_filter_or: result=%d\n", rtn ));
+       LDAP_LOG( FILTER, ENTRY, "test_filter_or: result=%d\n", rtn, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "<= test_filter_or %d\n", rtn, 0, 0 );
 #endif
@@ -473,24 +628,21 @@ test_filter_or(
 
 static int
 test_substrings_filter(
-    Backend    *be,
-    Connection *conn,
-    Operation  *op,
-    Entry      *e,
-    Filter     *f
+       Operation       *op,
+       Entry   *e,
+       Filter  *f
 )
 {
        Attribute       *a;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_substrings_filter: begin\n" ));
+       LDAP_LOG( FILTER, ENTRY, "test_substrings_filter: begin\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "begin test_substrings_filter\n", 0, 0, 0 );
 #endif
 
 
-       if ( !access_allowed( be, conn, op, e,
+       if ( !access_allowed( op, e,
                f->f_sub_desc, NULL, ACL_SEARCH, NULL ) )
        {
                return LDAP_INSUFFICIENT_ACCESS;
@@ -507,13 +659,13 @@ test_substrings_filter(
                        continue;
                }
 
-               for ( bv = a->a_vals; bv->bv_val != NULL; bv++ ) {
+               for ( bv = a->a_nvals; bv->bv_val != NULL; bv++ )
+               {
                        int ret;
                        int rc;
                        const char *text;
 
-                       rc = value_match( &ret, a->a_desc, mr,
-                               SLAP_MR_ASSERTION_SYNTAX_MATCH,
+                       rc = value_match( &ret, a->a_desc, mr, 0,
                                bv, f->f_sub, &text );
 
                        if( rc != LDAP_SUCCESS ) {
@@ -527,8 +679,7 @@ test_substrings_filter(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "filter", LDAP_LEVEL_ENTRY,
-                  "test_substrings_filter: return FALSE\n" ));
+       LDAP_LOG( FILTER, ENTRY, "test_substrings_filter: return FALSE\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_FILTER, "end test_substrings_filter 1\n", 0, 0, 0 );
 #endif