]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/filterentry.c
Happy New Year (belated)
[openldap] / servers / slapd / filterentry.c
index d70b640a260e7e69ce56e1b022fbcd81cfd1a6b9..93c78e75deb3a3234aaa4a6f7586032f173e1c8d 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2004 The OpenLDAP Foundation.
+ * Copyright 1998-2008 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 #include <ac/socket.h>
 #include <ac/string.h>
 
-
 #include "slap.h"
 
+#ifdef LDAP_COMP_MATCH
+#include "component.h"
+#endif
+
 static int     test_filter_and( Operation *op, Entry *e, Filter *flist );
 static int     test_filter_or( Operation *op, Entry *e, Filter *flist );
 static int     test_substrings_filter( Operation *op, Entry *e, Filter *f);
@@ -63,6 +66,12 @@ test_filter(
        int     rc;
        Debug( LDAP_DEBUG_FILTER, "=> test_filter\n", 0, 0, 0 );
 
+       if ( f->f_choice & SLAPD_FILTER_UNDEFINED ) {
+               Debug( LDAP_DEBUG_FILTER, "    UNDEFINED\n", 0, 0, 0 );
+               rc = SLAPD_COMPARE_UNDEFINED;
+               goto out;
+       }
+
        switch ( f->f_choice ) {
        case SLAPD_FILTER_COMPUTED:
                Debug( LDAP_DEBUG_FILTER, "    COMPUTED %s (%d)\n",
@@ -141,7 +150,7 @@ test_filter(
                    f->f_choice, 0, 0 );
                rc = LDAP_PROTOCOL_ERROR;
        }
-
+out:
        Debug( LDAP_DEBUG_FILTER, "<= test_filter %d\n", rc, 0, 0 );
        return( rc );
 }
@@ -154,6 +163,9 @@ static int test_mra_filter(
        Attribute       *a;
        void            *memctx;
        BER_MEMFREE_FN  *memfree;
+#ifdef LDAP_COMP_MATCH
+       int i, num_attr_vals = 0;
+#endif
 
        if ( op == NULL ) {
                memctx = NULL;
@@ -163,20 +175,13 @@ static int test_mra_filter(
                memfree = op->o_tmpfree;
        }
 
-#ifdef LDAP_COMP_MATCH
-       /* Component Matching */
-       if( mra->cf && mra->ma_rule->smr_usage & SLAP_MR_COMPONENT ) {
-               return test_comp_filter_entry( op, e, mra );
-       }
-#endif
-
        if ( mra->ma_desc ) {
                /*
                 * if ma_desc is available, then we're filtering for
                 * one attribute, and SEARCH permissions can be checked
                 * directly.
                 */
-               if( !access_allowed( op, e,
+               if ( !access_allowed( op, e,
                        mra->ma_desc, &mra->ma_value, ACL_SEARCH, NULL ) )
                {
                        return LDAP_INSUFFICIENT_ACCESS;
@@ -187,36 +192,133 @@ static int test_mra_filter(
                        const char *text;
 
                        rc = value_match( &ret, slap_schema.si_ad_entryDN, mra->ma_rule,
-                               0, &e->e_nname, &mra->ma_value, &text );
+                               SLAP_MR_EXT, &e->e_nname, &mra->ma_value, &text );
+       
        
                        if( rc != LDAP_SUCCESS ) return rc;
                        if ( ret == 0 ) return LDAP_COMPARE_TRUE;
                        return LDAP_COMPARE_FALSE;
                }
 
-               for(a = attrs_find( e->e_attrs, mra->ma_desc );
+               for ( a = attrs_find( e->e_attrs, mra->ma_desc );
                        a != NULL;
                        a = attrs_find( a->a_next, mra->ma_desc ) )
                {
-                       struct berval *bv;
+                       struct berval   *bv;
+                       int             normalize_attribute = 0;
+
+#ifdef LDAP_COMP_MATCH
+                       /* Component Matching */
+                       if ( mra->ma_cf && mra->ma_rule->smr_usage & SLAP_MR_COMPONENT ) {
+                               num_attr_vals = 0;
+                               if ( !a->a_comp_data ) {
+                                       num_attr_vals = a->a_numvals;
+                                       if ( num_attr_vals <= 0 ) {
+                                               /* no attribute value */
+                                               return LDAP_INAPPROPRIATE_MATCHING;
+                                       }
+                                       num_attr_vals++;
+
+                                       /* following malloced will be freed by comp_tree_free () */
+                                       a->a_comp_data = malloc( sizeof( ComponentData ) +
+                                               sizeof( ComponentSyntaxInfo* )*num_attr_vals );
+
+                                       if ( !a->a_comp_data ) return LDAP_NO_MEMORY;
+                                       a->a_comp_data->cd_tree = (ComponentSyntaxInfo**)
+                                               ((char*)a->a_comp_data + sizeof(ComponentData));
+                                       a->a_comp_data->cd_tree[num_attr_vals - 1] =
+                                               (ComponentSyntaxInfo*) NULL;
+                                       a->a_comp_data->cd_mem_op =
+                                               nibble_mem_allocator( 1024*16, 1024 );
+                               }
+                       }
+#endif
+
                        /* If ma_rule is not the same as the attribute's
                         * normal rule, then we can't use the a_nvals.
                         */
-                       if (mra->ma_rule == a->a_desc->ad_type->sat_equality) {
+                       if ( mra->ma_rule == a->a_desc->ad_type->sat_equality ) {
                                bv = a->a_nvals;
+
                        } else {
                                bv = a->a_vals;
+                               normalize_attribute = 1;
                        }
-
-                       for ( ; bv->bv_val != NULL; bv++ ) {
+#ifdef LDAP_COMP_MATCH
+                       i = 0;
+#endif
+                       for ( ; !BER_BVISNULL( bv ); bv++ ) {
                                int ret;
                                int rc;
                                const char *text;
        
-                               rc = value_match( &ret, a->a_desc, mra->ma_rule, 0,
-                                       bv, &mra->ma_value, &text );
-       
-                               if( rc != LDAP_SUCCESS ) return rc;
+#ifdef LDAP_COMP_MATCH
+                               if ( mra->ma_cf &&
+                                       mra->ma_rule->smr_usage & SLAP_MR_COMPONENT )
+                               {
+                                       /* Check if decoded component trees are already linked */
+                                       if ( num_attr_vals ) {
+                                               a->a_comp_data->cd_tree[i] = attr_converter(
+                                                       a, a->a_desc->ad_type->sat_syntax, bv );
+                                       }
+                                       /* decoding error */
+                                       if ( !a->a_comp_data->cd_tree[i] ) {
+                                               return LDAP_OPERATIONS_ERROR;
+                                       }
+                                       rc = value_match( &ret, a->a_desc, mra->ma_rule,
+                                               SLAP_MR_COMPONENT,
+                                               (struct berval*)a->a_comp_data->cd_tree[i++],
+                                               (void*)mra, &text );
+                               } else 
+#endif
+                               {
+                                       struct berval   nbv = BER_BVNULL;
+
+                                       if ( normalize_attribute && mra->ma_rule->smr_normalize ) {
+                                               /*
+                               
+                               Document: RFC 4511
+
+                                   4.5.1. Search Request 
+                                       ...
+                                   If the type field is present and the matchingRule is present, 
+                                   the matchValue is compared against entry attributes of the 
+                                   specified type. In this case, the matchingRule MUST be one 
+                                   suitable for use with the specified type (see [RFC4517]), 
+                                   otherwise the filter item is Undefined.  
+
+
+                               In this case, since the matchingRule requires the assertion
+                               value to be normalized, we normalize the attribute value
+                               according to the syntax of the matchingRule.
+
+                               This should likely be done inside value_match(), by passing
+                               the appropriate flags, but this is not done at present.
+                               See ITS#3406.
+                                                */
+                                               if ( mra->ma_rule->smr_normalize(
+                                                               SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
+                                                               mra->ma_rule->smr_syntax,
+                                                               mra->ma_rule,
+                                                               bv, &nbv, memctx ) != LDAP_SUCCESS )
+                                               {
+                                                       /* FIXME: stop processing? */
+                                                       continue;
+                                               }
+
+                                       } else {
+                                               nbv = *bv;
+                                       }
+
+                                       rc = value_match( &ret, a->a_desc, mra->ma_rule,
+                                               SLAP_MR_EXT, &nbv, &mra->ma_value, &text );
+
+                                       if ( nbv.bv_val != bv->bv_val ) {
+                                               memfree( nbv.bv_val, memctx );
+                                       }
+                               }
+
+                               if ( rc != LDAP_SUCCESS ) return rc;
                                if ( ret == 0 ) return LDAP_COMPARE_TRUE;
                        }
                }
@@ -229,9 +331,10 @@ static int test_mra_filter(
                        struct berval   *bv, value;
                        const char      *text = NULL;
                        int             rc;
+                       int             normalize_attribute = 0;
 
                        /* check if matching is appropriate */
-                       if ( !mr_usable_with_at( mra->ma_rule, a->a_desc->ad_type )) {
+                       if ( !mr_usable_with_at( mra->ma_rule, a->a_desc->ad_type ) ) {
                                continue;
                        }
 
@@ -243,25 +346,68 @@ static int test_mra_filter(
 
                        /* check search access */
                        if ( !access_allowed( op, e,
-                               a->a_desc, &value, ACL_SEARCH, NULL ) ) {
+                               a->a_desc, &value, ACL_SEARCH, NULL ) )
+                       {
                                memfree( value.bv_val, memctx );
                                continue;
                        }
+#ifdef LDAP_COMP_MATCH
+                       /* Component Matching */
+                       if ( mra->ma_cf &&
+                               mra->ma_rule->smr_usage & SLAP_MR_COMPONENT )
+                       {
+                               int ret;
+
+                               rc = value_match( &ret, a->a_desc, mra->ma_rule,
+                                       SLAP_MR_COMPONENT,
+                                       (struct berval*)a, (void*)mra, &text );
+                               if ( rc != LDAP_SUCCESS ) break;
+       
+                               if ( ret == 0 ) {
+                                       rc = LDAP_COMPARE_TRUE;
+                                       break;
+                               }
+
+                       }
+#endif
 
                        /* check match */
-                       if (mra->ma_rule == a->a_desc->ad_type->sat_equality) {
+                       if ( mra->ma_rule == a->a_desc->ad_type->sat_equality ) {
                                bv = a->a_nvals;
+
                        } else {
                                bv = a->a_vals;
+                               normalize_attribute = 1;
                        }
 
-                       for ( ; bv->bv_val != NULL; bv++ ) {
-                               int ret;
-       
-                               rc = value_match( &ret, a->a_desc, mra->ma_rule, 0,
-                                       bv, &value, &text );
-       
-                               if( rc != LDAP_SUCCESS ) break;
+                       for ( ; !BER_BVISNULL( bv ); bv++ ) {
+                               int             ret;
+                               struct berval   nbv = BER_BVNULL;
+
+                               if ( normalize_attribute && mra->ma_rule->smr_normalize ) {
+                                       /* see comment above */
+                                       if ( mra->ma_rule->smr_normalize(
+                                                       SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
+                                                       mra->ma_rule->smr_syntax,
+                                                       mra->ma_rule,
+                                                       bv, &nbv, memctx ) != LDAP_SUCCESS )
+                                       {
+                                               /* FIXME: stop processing? */
+                                               continue;
+                                       }
+
+                               } else {
+                                       nbv = *bv;
+                               }
+
+                               rc = value_match( &ret, a->a_desc, mra->ma_rule,
+                                       SLAP_MR_EXT, &nbv, &value, &text );
+
+                               if ( nbv.bv_val != bv->bv_val ) {
+                                       memfree( nbv.bv_val, memctx );
+                               }
+
+                               if ( rc != LDAP_SUCCESS ) break;
        
                                if ( ret == 0 ) {
                                        rc = LDAP_COMPARE_TRUE;
@@ -274,7 +420,7 @@ static int test_mra_filter(
        }
 
        /* check attrs in DN AVAs if required */
-       if ( mra->ma_dnattrs ) {
+       if ( mra->ma_dnattrs && !BER_BVISEMPTY( &e->e_nname ) ) {
                LDAPDN          dn = NULL;
                int             iRDN, iAVA;
                int             rc;
@@ -291,13 +437,15 @@ static int test_mra_filter(
 
                        for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
                                LDAPAVA         *ava = rdn[ iAVA ];
-                               struct berval   *bv = &ava->la_value, value;
+                               struct berval   *bv = &ava->la_value,
+                                               value = BER_BVNULL,
+                                               nbv = BER_BVNULL;
                                AttributeDescription *ad =
                                        (AttributeDescription *)ava->la_private;
-                               int ret;
-                               const char *text;
+                               int             ret;
+                               const char      *text;
 
-                               assert( ad );
+                               assert( ad != NULL );
 
                                if ( mra->ma_desc ) {
                                        /* have a mra type? check for subtype */
@@ -310,7 +458,7 @@ static int test_mra_filter(
                                        const char      *text = NULL;
 
                                        /* check if matching is appropriate */
-                                       if ( !mr_usable_with_at( mra->ma_rule, ad->ad_type )) {
+                                       if ( !mr_usable_with_at( mra->ma_rule, ad->ad_type ) ) {
                                                continue;
                                        }
 
@@ -330,17 +478,40 @@ static int test_mra_filter(
                                        }
                                }
 
+                               if ( mra->ma_rule->smr_normalize ) {
+                                       /* see comment above */
+                                       if ( mra->ma_rule->smr_normalize(
+                                                       SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
+                                                       mra->ma_rule->smr_syntax,
+                                                       mra->ma_rule,
+                                                       bv, &nbv, memctx ) != LDAP_SUCCESS )
+                                       {
+                                               /* FIXME: stop processing? */
+                                               rc = LDAP_SUCCESS;
+                                               ret = -1;
+                                               goto cleanup;
+                                       }
+
+                               } else {
+                                       nbv = *bv;
+                               }
+
                                /* check match */
-                               rc = value_match( &ret, ad, mra->ma_rule, 0,
-                                       bv, &value, &text );
+                               rc = value_match( &ret, ad, mra->ma_rule, SLAP_MR_EXT,
+                                       &nbv, &value, &text );
 
-                               if ( value.bv_val != mra->ma_value.bv_val ) {
+cleanup:;
+                               if ( !BER_BVISNULL( &value ) && value.bv_val != mra->ma_value.bv_val ) {
                                        memfree( value.bv_val, memctx );
                                }
 
+                               if ( !BER_BVISNULL( &nbv ) && nbv.bv_val != bv->bv_val ) {
+                                       memfree( nbv.bv_val, memctx );
+                               }
+
                                if ( rc == LDAP_SUCCESS && ret == 0 ) rc = LDAP_COMPARE_TRUE;
 
-                               if( rc != LDAP_SUCCESS ) {
+                               if ( rc != LDAP_SUCCESS ) {
                                        ldap_dnfree_x( dn, memctx );
                                        return rc;
                                }
@@ -361,6 +532,10 @@ test_ava_filter(
 {
        int rc;
        Attribute       *a;
+#ifdef LDAP_COMP_MATCH
+       int i, num_attr_vals = 0;
+       AttributeAliasing *a_alias = NULL;
+#endif
 
        if ( !access_allowed( op, e,
                ava->aa_desc, &ava->aa_value, ACL_SEARCH, NULL ) )
@@ -403,7 +578,7 @@ test_ava_filter(
 
        if ( ava->aa_desc == slap_schema.si_ad_entryDN ) {
                MatchingRule *mr;
-               int rc, ret;
+               int match;
                const char *text;
 
                if( type != LDAP_FILTER_EQUALITY &&
@@ -414,22 +589,34 @@ test_ava_filter(
                }
 
                mr = slap_schema.si_ad_entryDN->ad_type->sat_equality;
-               assert( mr );
+               assert( mr != NULL );
 
-               rc = value_match( &ret, slap_schema.si_ad_entryDN, mr, 0,
-                       &e->e_nname, &ava->aa_value, &text );
+               rc = value_match( &match, slap_schema.si_ad_entryDN, mr,
+                       SLAP_MR_EXT, &e->e_nname, &ava->aa_value, &text );
 
                if( rc != LDAP_SUCCESS ) return rc;
-               if( ret == 0 ) return LDAP_COMPARE_TRUE;
+               if( match == 0 ) return LDAP_COMPARE_TRUE;
                return LDAP_COMPARE_FALSE;
        }
 
        rc = LDAP_COMPARE_FALSE;
 
+#ifdef LDAP_COMP_MATCH
+       if ( is_aliased_attribute && ava->aa_cf )
+       {
+               a_alias = is_aliased_attribute ( ava->aa_desc );
+               if ( a_alias )
+                       ava->aa_desc = a_alias->aa_aliased_ad;
+               else
+                       ava->aa_cf = NULL;
+       }
+#endif
+
        for(a = attrs_find( e->e_attrs, ava->aa_desc );
                a != NULL;
                a = attrs_find( a->a_next, ava->aa_desc ) )
        {
+               int use;
                MatchingRule *mr;
                struct berval *bv;
 
@@ -440,19 +627,24 @@ test_ava_filter(
                        continue;
                }
 
+               use = SLAP_MR_EQUALITY;
+
                switch ( type ) {
                case LDAP_FILTER_APPROX:
+                       use = SLAP_MR_EQUALITY_APPROX;
                        mr = a->a_desc->ad_type->sat_approx;
                        if( mr != NULL ) break;
 
-                       /* use EQUALITY matching rule if no APPROX rule */
+                       /* fallthru: use EQUALITY matching rule if no APPROX rule */
 
                case LDAP_FILTER_EQUALITY:
+                       /* use variable set above so fall thru use is not clobbered */
                        mr = a->a_desc->ad_type->sat_equality;
                        break;
 
                case LDAP_FILTER_GE:
                case LDAP_FILTER_LE:
+                       use = SLAP_MR_ORDERING;
                        mr = a->a_desc->ad_type->sat_ordering;
                        break;
 
@@ -465,36 +657,154 @@ test_ava_filter(
                        continue;
                }
 
-               for ( bv = a->a_nvals; bv->bv_val != NULL; bv++ ) {
+               /* We have no Sort optimization for Approx matches */
+               if (( a->a_flags & SLAP_ATTR_SORTED_VALS ) && type != LDAP_FILTER_APPROX ) {
+                       unsigned slot;
                        int ret;
-                       int tmprc;
+
+                       /* For Ordering matches, we just need to do one comparison with
+                        * either the first (least) or last (greatest) value.
+                        */
+                       if ( use == SLAP_MR_ORDERING ) {
+                               const char *text;
+                               int match, which;
+                               which = (type == LDAP_FILTER_LE) ? 0 : a->a_numvals-1;
+                               ret = value_match( &match, a->a_desc, mr, use,
+                                       &a->a_nvals[which], &ava->aa_value, &text );
+                               if ( ret != LDAP_SUCCESS ) return ret;
+                               if (( type == LDAP_FILTER_LE && match <= 0 ) ||
+                                       ( type == LDAP_FILTER_GE && match >= 0 ))
+                                       return LDAP_COMPARE_TRUE;
+                               continue;
+                       }
+                       /* Only Equality will get here */
+                       ret = attr_valfind( a, use | SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH |
+                               SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH, 
+                               &ava->aa_value, &slot, NULL );
+                       if ( ret == LDAP_SUCCESS )
+                               return LDAP_COMPARE_TRUE;
+                       else if ( ret != LDAP_NO_SUCH_ATTRIBUTE )
+                               return ret;
+#if 0
+                       /* The following is useful if we want to know which values
+                        * matched an ordering test. But here we don't care, we just
+                        * want to know if any value did, and that is checked above.
+                        */
+                       if ( ret == LDAP_NO_SUCH_ATTRIBUTE ) {
+                               /* If insertion point is not the end of the list, there was
+                                * at least one value greater than the assertion.
+                                */
+                               if ( type == LDAP_FILTER_GE && slot < a->a_numvals )
+                                       return LDAP_COMPARE_TRUE;
+                               /* Likewise, if insertion point is not the head of the list,
+                                * there was at least one value less than the assertion.
+                                */
+                               if ( type == LDAP_FILTER_LE && slot > 0 )
+                                       return LDAP_COMPARE_TRUE;
+                               return LDAP_COMPARE_FALSE;
+                       }
+#endif
+                       continue;
+               }
+
+#ifdef LDAP_COMP_MATCH
+               if ( nibble_mem_allocator && ava->aa_cf && !a->a_comp_data ) {
+                       /* Component Matching */
+                       for ( num_attr_vals = 0; a->a_vals[num_attr_vals].bv_val != NULL; num_attr_vals++ );
+                       if ( num_attr_vals <= 0 )/* no attribute value */
+                               return LDAP_INAPPROPRIATE_MATCHING;
+                       num_attr_vals++;/* for NULL termination */
+
+                       /* following malloced will be freed by comp_tree_free () */
+                       a->a_comp_data = malloc( sizeof( ComponentData ) + sizeof( ComponentSyntaxInfo* )*num_attr_vals );
+
+                       if ( !a->a_comp_data ) {
+                               return LDAP_NO_MEMORY;
+                       }
+
+                       a->a_comp_data->cd_tree = (ComponentSyntaxInfo**)((char*)a->a_comp_data + sizeof(ComponentData));
+                       i = num_attr_vals;
+                       for ( ; i ; i-- ) {
+                               a->a_comp_data->cd_tree[ i-1 ] = (ComponentSyntaxInfo*)NULL;
+                       }
+
+                       a->a_comp_data->cd_mem_op = nibble_mem_allocator ( 1024*10*(num_attr_vals-1), 1024 );
+                       if ( a->a_comp_data->cd_mem_op == NULL ) {
+                               free ( a->a_comp_data );
+                               a->a_comp_data = NULL;
+                               return LDAP_OPERATIONS_ERROR;
+                       }
+               }
+
+               i = 0;
+#endif
+
+               for ( bv = a->a_nvals; !BER_BVISNULL( bv ); bv++ ) {
+                       int ret, match;
                        const char *text;
 
-                       tmprc = value_match( &ret, a->a_desc, mr, 0,
-                               bv, &ava->aa_value, &text );
+#ifdef LDAP_COMP_MATCH
+                       if( attr_converter && ava->aa_cf && a->a_comp_data ) {
+                               /* Check if decoded component trees are already linked */
+                               struct berval cf_bv = { 20, "componentFilterMatch" };
+                               MatchingRule* cf_mr = mr_bvfind( &cf_bv );
+                               MatchingRuleAssertion mra;
+                               mra.ma_cf = ava->aa_cf;
+
+                               if ( a->a_comp_data->cd_tree[i] == NULL )
+                                       a->a_comp_data->cd_tree[i] = attr_converter (a, a->a_desc->ad_type->sat_syntax, (a->a_vals + i));
+                               /* decoding error */
+                               if ( !a->a_comp_data->cd_tree[i] ) {
+                                       free_ComponentData ( a );
+                                       return LDAP_OPERATIONS_ERROR;
+                               }
+
+                               ret = value_match( &match, a->a_desc, cf_mr,
+                                       SLAP_MR_COMPONENT,
+                                       (struct berval*)a->a_comp_data->cd_tree[i++],
+                                       (void*)&mra, &text );
+                               if ( ret == LDAP_INAPPROPRIATE_MATCHING ) {
+                                       /* cached component tree is broken, just remove it */
+                                       free_ComponentData ( a );
+                                       return ret;
+                               }
+                               if ( a_alias )
+                                       ava->aa_desc = a_alias->aa_aliasing_ad;
+
+                       } else 
+#endif
+                       {
+                               ret = ordered_value_match( &match, a->a_desc, mr, use,
+                                       bv, &ava->aa_value, &text );
+                       }
 
-                       if( tmprc != LDAP_SUCCESS ) {
-                               rc = tmprc;
+                       if( ret != LDAP_SUCCESS ) {
+                               rc = ret;
                                break;
                        }
 
                        switch ( type ) {
                        case LDAP_FILTER_EQUALITY:
                        case LDAP_FILTER_APPROX:
-                               if ( ret == 0 ) return LDAP_COMPARE_TRUE;
+                               if ( match == 0 ) return LDAP_COMPARE_TRUE;
                                break;
 
                        case LDAP_FILTER_GE:
-                               if ( ret >= 0 ) return LDAP_COMPARE_TRUE;
+                               if ( match >= 0 ) return LDAP_COMPARE_TRUE;
                                break;
 
                        case LDAP_FILTER_LE:
-                               if ( ret <= 0 ) return LDAP_COMPARE_TRUE;
+                               if ( match <= 0 ) return LDAP_COMPARE_TRUE;
                                break;
                        }
                }
        }
 
+#ifdef LDAP_COMP_MATCH
+       if ( a_alias )
+               ava->aa_desc = a_alias->aa_aliasing_ad;
+#endif
+
        return rc;
 }
 
@@ -517,7 +827,7 @@ test_presence_filter(
                 * XXX: fairly optimistic: if the function is defined,
                 * then PRESENCE must succeed, because hasSubordinate
                 * is boolean-valued; I think we may live with this 
-                * simplification by now
+                * simplification by now.
                 */
                if ( op && op->o_bd && op->o_bd->be_has_subordinates ) {
                        return LDAP_COMPARE_TRUE;
@@ -655,19 +965,18 @@ test_substrings_filter(
                        continue;
                }
 
-               for ( bv = a->a_nvals; bv->bv_val != NULL; bv++ ) {
-                       int ret;
-                       int tmprc;
+               for ( bv = a->a_nvals; !BER_BVISNULL( bv ); bv++ ) {
+                       int ret, match;
                        const char *text;
 
-                       tmprc = value_match( &ret, a->a_desc, mr, 0,
+                       ret = value_match( &match, a->a_desc, mr, SLAP_MR_SUBSTR,
                                bv, f->f_sub, &text );
 
-                       if( tmprc != LDAP_SUCCESS ) {
-                               rc = tmprc;
+                       if( ret != LDAP_SUCCESS ) {
+                               rc = ret;
                                break;
                        }
-                       if ( ret == 0 ) return LDAP_COMPARE_TRUE;
+                       if ( match == 0 ) return LDAP_COMPARE_TRUE;
                }
        }