]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/ldapsync.c
ITS#5435 ConfigReply arg must be non-NULL
[openldap] / servers / slapd / ldapsync.c
index e2037811910ce622db318fd55ae87e720fb0cb0c..bd4680960944e4ce6adc8eb6184eb8f93c6a98b6 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2003-2005 The OpenLDAP Foundation.
+ * Copyright 2003-2008 The OpenLDAP Foundation.
  * Portions Copyright 2003 IBM Corporation.
  * All rights reserved.
  *
@@ -34,29 +34,58 @@ void
 slap_compose_sync_cookie(
        Operation *op,
        struct berval *cookie,
-       struct berval *csn,
-       int rid )
+       BerVarray csn,
+       int rid,
+       int sid )
 {
-       char cookiestr[ LDAP_LUTIL_CSNSTR_BUFSIZE + 20 ];
+       int len, numcsn = 0;
 
-       if ( BER_BVISNULL( csn )) {
+       if ( csn ) {
+               for (; !BER_BVISNULL( &csn[numcsn] ); numcsn++);
+       }
+
+       if ( numcsn == 0 || rid == -1 ) {
+               char cookiestr[ LDAP_LUTIL_CSNSTR_BUFSIZE + 20 ];
                if ( rid == -1 ) {
                        cookiestr[0] = '\0';
+                       len = 0;
                } else {
-                       snprintf( cookiestr, LDAP_LUTIL_CSNSTR_BUFSIZE + 20,
+                       len = snprintf( cookiestr, sizeof( cookiestr ),
                                        "rid=%03d", rid );
+                       if ( sid >= 0 ) {
+                               len += sprintf( cookiestr+len, ",sid=%03x", sid );
+                       }
                }
+               ber_str2bv_x( cookiestr, len, 1, cookie, 
+                       op ? op->o_tmpmemctx : NULL );
        } else {
-               if ( rid == -1 ) {
-                       snprintf( cookiestr, LDAP_LUTIL_CSNSTR_BUFSIZE + 20,
-                                       "csn=%s", csn->bv_val );
-               } else {
-                       snprintf( cookiestr, LDAP_LUTIL_CSNSTR_BUFSIZE + 20,
-                                       "csn=%s,rid=%03d", csn->bv_val, rid );
+               char *ptr;
+               int i;
+
+               len = 0;
+               for ( i=0; i<numcsn; i++)
+                       len += csn[i].bv_len + 1;
+
+               len += STRLENOF("rid=123,csn=");
+               if ( sid >= 0 )
+                       len += STRLENOF("sid=xxx,");
+
+               cookie->bv_val = slap_sl_malloc( len, op ? op->o_tmpmemctx : NULL );
+
+               len = sprintf( cookie->bv_val, "rid=%03d,", rid );
+               ptr = cookie->bv_val + len;
+               if ( sid >= 0 ) {
+                       ptr += sprintf( ptr, "sid=%03x,", sid );
+               }
+               ptr = lutil_strcopy( ptr, "csn=" );
+               for ( i=0; i<numcsn; i++) {
+                       ptr = lutil_strncopy( ptr, csn[i].bv_val, csn[i].bv_len );
+                       *ptr++ = ';';
                }
+               ptr--;
+               *ptr = '\0';
+               cookie->bv_len = ptr - cookie->bv_val;
        }
-       ber_str2bv_x( cookiestr, strlen(cookiestr), 1, cookie, 
-               op ? op->o_tmpmemctx : NULL );
 }
 
 void
@@ -68,11 +97,16 @@ slap_sync_cookie_free(
        if ( cookie == NULL )
                return;
 
-       if ( !BER_BVISNULL( &cookie->ctxcsn )) {
-               ch_free( cookie->ctxcsn.bv_val );
-               BER_BVZERO( &cookie->ctxcsn );
+       if ( cookie->sids ) {
+               ch_free( cookie->sids );
+               cookie->sids = NULL;
        }
 
+       if ( cookie->ctxcsn ) {
+               ber_bvarray_free( cookie->ctxcsn );
+               cookie->ctxcsn = NULL;
+       }
+       cookie->numcsns = 0;
        if ( !BER_BVISNULL( &cookie->octet_str )) {
                ch_free( cookie->octet_str.bv_val );
                BER_BVZERO( &cookie->octet_str );
@@ -85,6 +119,53 @@ slap_sync_cookie_free(
        return;
 }
 
+int
+slap_parse_csn_sid( struct berval *csnp )
+{
+       char *p, *q;
+       struct berval csn = *csnp;
+       int i;
+
+       p = ber_bvchr( &csn, '#' );
+       if ( !p )
+               return -1;
+       p++;
+       csn.bv_len -= p - csn.bv_val;
+       csn.bv_val = p;
+
+       p = ber_bvchr( &csn, '#' );
+       if ( !p )
+               return -1;
+       p++;
+       csn.bv_len -= p - csn.bv_val;
+       csn.bv_val = p;
+
+       q = ber_bvchr( &csn, '#' );
+       if ( !q )
+               return -1;
+
+       csn.bv_len = q - p;
+
+       i = strtol( p, &q, 16 );
+       if ( p == q || q != p + csn.bv_len || i < 0 || i > SLAP_SYNC_SID_MAX ) {
+               i = -1;
+       }
+
+       return i;
+}
+
+int *
+slap_parse_csn_sids( BerVarray csns, int numcsns, void *memctx )
+{
+       int i, *ret;
+
+       ret = slap_sl_malloc( numcsns * sizeof(int), memctx );
+       for ( i=0; i<numcsns; i++ ) {
+               ret[i] = slap_parse_csn_sid( &csns[i] );
+       }
+       return ret;
+}
+
 int
 slap_parse_sync_cookie(
        struct sync_cookie *cookie,
@@ -93,11 +174,9 @@ slap_parse_sync_cookie(
 {
        char *csn_ptr;
        char *csn_str;
-       int csn_str_len;
-       int valid = 0;
-       char *rid_ptr;
        char *cval;
-       char *next;
+       char *next, *end;
+       AttributeDescription *ad = slap_schema.si_ad_modifyTimestamp;
 
        if ( cookie == NULL )
                return -1;
@@ -106,58 +185,103 @@ slap_parse_sync_cookie(
                return -1;
 
        cookie->rid = -1;
-       /* FIXME: may read past end of cookie->octet_str.bv_val */
-       rid_ptr = strstr( cookie->octet_str.bv_val, "rid=" );
-       if ( rid_ptr == NULL 
-               || rid_ptr > &cookie->octet_str.bv_val[ cookie->octet_str.bv_len - STRLENOF( "rid=" ) ] )
-       {
-               return -1;
-
-       }
-
-       cookie->rid = strtoul( &rid_ptr[ STRLENOF( "rid=" ) ], &next, 10 );
-       if ( next == &rid_ptr[ STRLENOF( "rid=" ) ] || ( next[ 0 ] != ',' && next[ 0 ] != '\0' ) ) {
-               return -1;
-       }
-
-       while (( csn_ptr = strstr( cookie->octet_str.bv_val, "csn=" )) != NULL ) {
-               AttributeDescription *ad = slap_schema.si_ad_modifyTimestamp;
-               slap_syntax_validate_func *validate;
-               struct berval stamp;
-
-               /* This only happens when called from main */
-               if ( ad == NULL )
-                       break;
-
-               if ( csn_ptr >= &cookie->octet_str.bv_val[ cookie->octet_str.bv_len - STRLENOF( "csn=" ) ] ) {
-                       return -1;
+       cookie->sid = -1;
+       cookie->ctxcsn = NULL;
+       cookie->sids = NULL;
+       cookie->numcsns = 0;
+
+       end = cookie->octet_str.bv_val + cookie->octet_str.bv_len;
+
+       for ( next=cookie->octet_str.bv_val; next < end; ) {
+               if ( !strncmp( next, "rid=", STRLENOF("rid=") )) {
+                       char *rid_ptr = next;
+                       cookie->rid = strtol( &rid_ptr[ STRLENOF( "rid=" ) ], &next, 10 );
+                       if ( next == rid_ptr ||
+                               next > end ||
+                               ( *next && *next != ',' ) ||
+                               cookie->rid < 0 ||
+                               cookie->rid > SLAP_SYNC_RID_MAX )
+                       {
+                               return -1;
+                       }
+                       if ( *next == ',' ) {
+                               next++;
+                       }
+                       if ( !ad ) {
+                               break;
+                       }
+                       continue;
                }
-
-               csn_str = csn_ptr + STRLENOF("csn=");
-               cval = strchr( csn_str, ',' );
-               if ( cval && cval < &cookie->octet_str.bv_val[ cookie->octet_str.bv_len ] )
-                       csn_str_len = cval - csn_str;
-               else
-                       csn_str_len = 0;
-
-               /* FIXME use csnValidate when it gets implemented */
-               csn_ptr = strchr( csn_str, '#' );
-               if ( !csn_ptr || csn_str >= &cookie->octet_str.bv_val[ cookie->octet_str.bv_len ] ) break;
-
-               stamp.bv_val = csn_str;
-               stamp.bv_len = csn_ptr - csn_str;
-               validate = ad->ad_type->sat_syntax->ssyn_validate;
-               if ( validate( ad->ad_type->sat_syntax, &stamp ) != LDAP_SUCCESS )
-                       break;
-               valid = 1;
-               break;
+               if ( !strncmp( next, "sid=", STRLENOF("sid=") )) {
+                       char *sid_ptr = next;
+                       sid_ptr = next;
+                       cookie->sid = strtol( &sid_ptr[ STRLENOF( "sid=" ) ], &next, 16 );
+                       if ( next == sid_ptr ||
+                               next > end ||
+                               ( *next && *next != ',' ) ||
+                               cookie->sid < 0 ||
+                               cookie->sid > SLAP_SYNC_SID_MAX )
+                       {
+                               return -1;
+                       }
+                       if ( *next == ',' ) {
+                               next++;
+                       }
+                       continue;
+               }
+               if ( !strncmp( next, "csn=", STRLENOF("csn=") )) {
+                       slap_syntax_validate_func *validate;
+                       struct berval stamp;
+
+                       next += STRLENOF("csn=");
+                       while ( next < end ) {
+                               csn_str = next;
+                               /* FIXME use csnValidate when it gets implemented */
+                               csn_ptr = strchr( csn_str, '#' );
+                               if ( !csn_ptr || csn_ptr > end )
+                                       break;
+                               /* ad will be NULL when called from main. we just
+                                * want to parse the rid then. But we still iterate
+                                * through the string to find the end.
+                                */
+                               if ( ad ) {
+                                       stamp.bv_val = csn_str;
+                                       stamp.bv_len = csn_ptr - csn_str;
+                                       validate = ad->ad_type->sat_syntax->ssyn_validate;
+                                       if ( validate( ad->ad_type->sat_syntax, &stamp )
+                                               != LDAP_SUCCESS )
+                                               break;
+                               }
+                               cval = strchr( csn_ptr, ';' );
+                               if ( !cval )
+                                       cval = strchr(csn_ptr, ',' );
+                               if ( cval )
+                                       stamp.bv_len = cval - csn_str;
+                               else
+                                       stamp.bv_len = end - csn_str;
+                               if ( ad ) {
+                                       struct berval bv;
+                                       ber_dupbv_x( &bv, &stamp, memctx );
+                                       ber_bvarray_add_x( &cookie->ctxcsn, &bv, memctx );
+                                       cookie->numcsns++;
+                               }
+                               if ( cval ) {
+                                       next = cval + 1;
+                                       if ( *cval != ';' )
+                                               break;
+                               } else {
+                                       next = end;
+                                       break;
+                               }
+                       }
+                       continue;
+               }
+               next++;
        }
-       if ( valid ) {
-               ber_str2bv_x( csn_str, csn_str_len, 1, &cookie->ctxcsn, memctx );
-       } else {
-               BER_BVZERO( &cookie->ctxcsn );
+       if ( cookie->numcsns ) {
+               cookie->sids = slap_parse_csn_sids( cookie->ctxcsn, cookie->numcsns,
+                       memctx );
        }
-
        return 0;
 }
 
@@ -182,7 +306,10 @@ slap_init_sync_cookie_ctxcsn(
 
        ctxcsn.bv_val = octet_str.bv_val + 4;
        ctxcsn.bv_len = octet_str.bv_len - 4;
-       ber_dupbv( &cookie->ctxcsn, &ctxcsn );
+       cookie->ctxcsn = NULL;
+       value_add_one( &cookie->ctxcsn, &ctxcsn );
+       cookie->numcsns = 1;
+       cookie->sid = -1;
 
        return 0;
 }
@@ -194,14 +321,16 @@ slap_dup_sync_cookie(
 )
 {
        struct sync_cookie *new;
+       int i;
 
        if ( src == NULL )
                return NULL;
 
        if ( dst ) {
-               ch_free( dst->ctxcsn.bv_val );
+               ber_bvarray_free( dst->ctxcsn );
+               dst->ctxcsn = NULL;
+               dst->sids = NULL;
                ch_free( dst->octet_str.bv_val );
-               BER_BVZERO( &dst->ctxcsn );
                BER_BVZERO( &dst->octet_str );
                new = dst;
        } else {
@@ -210,9 +339,19 @@ slap_dup_sync_cookie(
        }
 
        new->rid = src->rid;
-
-       if ( !BER_BVISNULL( &src->ctxcsn )) {
-               ber_dupbv( &new->ctxcsn, &src->ctxcsn );
+       new->sid = src->sid;
+       new->numcsns = src->numcsns;
+
+       if ( src->numcsns ) {
+               if ( ber_bvarray_dup_x( &new->ctxcsn, src->ctxcsn, NULL )) {
+                       if ( !dst ) {
+                               ch_free( new );
+                       }
+                       return NULL;
+               }
+               new->sids = ch_malloc( src->numcsns * sizeof(int) );
+               for (i=0; i<src->numcsns; i++)
+                       new->sids[i] = src->sids[i];
        }
 
        if ( !BER_BVISNULL( &src->octet_str )) {