]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/modify.c
Merge remote branch 'origin/mdb.master' into OPENLDAP_REL_ENG_2_4
[openldap] / servers / slapd / modify.c
index becbd71310ac5e33408cafe88cb74644c3ad78d0..659527c31bebc1ff03ded9b5110e8b7f0eb3f562 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2005 The OpenLDAP Foundation.
+ * Copyright 1998-2012 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -41,17 +41,14 @@ do_modify(
     SlapReply  *rs )
 {
        struct berval dn = BER_BVNULL;
-       char            *last;
-       ber_tag_t       tag;
-       ber_len_t       len;
-       Modifications   *modlist = NULL;
-       Modifications   **modtail = &modlist;
-       int             increment = 0;
        char            textbuf[ SLAP_TEXT_BUFLEN ];
        size_t          textlen = sizeof( textbuf );
+#ifdef LDAP_DEBUG
+       Modifications   *tmp;
+#endif
 
-       Debug( LDAP_DEBUG_TRACE, "do_modify\n", 0, 0, 0 );
-
+       Debug( LDAP_DEBUG_TRACE, "%s do_modify\n",
+               op->o_log_prefix, 0, 0 );
        /*
         * Parse the modify request.  It looks like this:
         *
@@ -72,176 +69,46 @@ do_modify(
         */
 
        if ( ber_scanf( op->o_ber, "{m" /*}*/, &dn ) == LBER_ERROR ) {
-               Debug( LDAP_DEBUG_ANY, "do_modify: ber_scanf failed\n", 0, 0, 0 );
-
+               Debug( LDAP_DEBUG_ANY, "%s do_modify: ber_scanf failed\n",
+                       op->o_log_prefix, 0, 0 );
                send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" );
                return SLAPD_DISCONNECT;
        }
 
-       Debug( LDAP_DEBUG_ARGS, "do_modify: dn (%s)\n", dn.bv_val, 0, 0 );
-
-       /* collect modifications & save for later */
-       for ( tag = ber_first_element( op->o_ber, &len, &last );
-           tag != LBER_DEFAULT;
-           tag = ber_next_element( op->o_ber, &len, last ) )
-       {
-               ber_int_t mop;
-               Modifications tmp, *mod;
-
-               tmp.sml_nvalues = NULL;
-
-               if ( ber_scanf( op->o_ber, "{i{m[W]}}", &mop,
-                   &tmp.sml_type, &tmp.sml_values ) == LBER_ERROR )
-               {
-                       send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR,
-                               "decoding modlist error" );
-                       rs->sr_err = SLAPD_DISCONNECT;
-                       goto cleanup;
-               }
-
-               mod = (Modifications *) ch_malloc( sizeof(Modifications) );
-               mod->sml_op = mop;
-               mod->sml_flags = 0;
-               mod->sml_type = tmp.sml_type;
-               mod->sml_values = tmp.sml_values;
-               mod->sml_nvalues = NULL;
-               mod->sml_desc = NULL;
-               mod->sml_next = NULL;
-               *modtail = mod;
-
-               switch( mop ) {
-               case LDAP_MOD_ADD:
-                       if ( mod->sml_values == NULL ) {
-                               Debug( LDAP_DEBUG_ANY,
-                                       "do_modify: modify/add operation (%ld) requires values\n",
-                                       (long) mop, 0, 0 );
-
-                               send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
-                                       "modify/add operation requires values" );
-                               goto cleanup;
-                       }
-
-                       /* fall through */
+       Debug( LDAP_DEBUG_ARGS, "%s do_modify: dn (%s)\n",
+               op->o_log_prefix, dn.bv_val, 0 );
 
-               case LDAP_MOD_DELETE:
-               case LDAP_MOD_REPLACE:
-                       break;
-
-               case LDAP_MOD_INCREMENT:
-                       if( op->o_protocol >= LDAP_VERSION3 ) {
-                               increment++;
-                               if ( mod->sml_values == NULL ) {
-                                       Debug( LDAP_DEBUG_ANY, "do_modify: "
-                                               "modify/increment operation (%ld) requires value\n",
-                                               (long) mop, 0, 0 );
-
-                                       send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
-                                               "modify/increment operation requires value" );
-                                       goto cleanup;
-                               }
-
-                               if( mod->sml_values[1].bv_val ) {
-                                       Debug( LDAP_DEBUG_ANY, "do_modify: modify/increment "
-                                               "operation (%ld) requires single value\n",
-                                               (long) mop, 0, 0 );
-
-                                       send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
-                                               "modify/increment operation requires single value" );
-                                       goto cleanup;
-                               }
-
-                               break;
-                       }
-                       /* fall thru */
-
-               default: {
-                               Debug( LDAP_DEBUG_ANY,
-                                       "do_modify: unrecognized modify operation (%ld)\n",
-                                       (long) mop, 0, 0 );
-
-                               send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
-                                       "unrecognized modify operation" );
-                               goto cleanup;
-                       }
-               }
-
-               modtail = &mod->sml_next;
+       rs->sr_err = slap_parse_modlist( op, rs, op->o_ber, &op->oq_modify );
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               Debug( LDAP_DEBUG_ANY, "%s do_modify: slap_parse_modlist failed err=%d msg=%s\n",
+                       op->o_log_prefix, rs->sr_err, rs->sr_text );
+               send_ldap_result( op, rs );
+               goto cleanup;
        }
-       *modtail = NULL;
 
        if( get_ctrls( op, rs, 1 ) != LDAP_SUCCESS ) {
-               Debug( LDAP_DEBUG_ANY, "do_modify: get_ctrls failed\n", 0, 0, 0 );
-
+               Debug( LDAP_DEBUG_ANY, "%s do_modify: get_ctrls failed\n",
+                       op->o_log_prefix, 0, 0 );
+               /* get_ctrls has sent results.  Now clean up. */
                goto cleanup;
        }
 
        rs->sr_err = dnPrettyNormal( NULL, &dn, &op->o_req_dn, &op->o_req_ndn,
                op->o_tmpmemctx );
        if( rs->sr_err != LDAP_SUCCESS ) {
-               Debug( LDAP_DEBUG_ANY,
-                       "do_modify: invalid dn (%s)\n", dn.bv_val, 0, 0 );
+               Debug( LDAP_DEBUG_ANY, "%s do_modify: invalid dn (%s)\n",
+                       op->o_log_prefix, dn.bv_val, 0 );
                send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid DN" );
                goto cleanup;
        }
 
-       rs->sr_err = slap_mods_check( modlist, &rs->sr_text,
-               textbuf, textlen, NULL );
-
-       if ( rs->sr_err != LDAP_SUCCESS ) {
-               send_ldap_result( op, rs );
-               goto cleanup;
-       }
-
-       /* FIXME: needs review */
-       op->orm_modlist = modlist;
-       op->orm_increment = increment;
-
-       op->o_bd = frontendDB;
-       rs->sr_err = frontendDB->be_modify( op, rs );
-
-cleanup:
-       slap_graduate_commit_csn( op );
-
-       op->o_tmpfree( op->o_req_dn.bv_val, op->o_tmpmemctx );
-       op->o_tmpfree( op->o_req_ndn.bv_val, op->o_tmpmemctx );
-       if ( op->orm_modlist != NULL ) slap_mods_free( op->orm_modlist, 1 );
+       op->orm_no_opattrs = 0;
 
-       return rs->sr_err;
-}
-
-int
-fe_op_modify( Operation *op, SlapReply *rs )
-{
 #ifdef LDAP_DEBUG
-       Modifications   *tmp;
-#endif
-       int             manageDSAit;
-       Modifications   *modlist = op->orm_modlist;
-       Modifications   **modtail = &modlist;
-       int             increment = op->orm_increment;
-       BackendDB *op_be;
-       char            textbuf[ SLAP_TEXT_BUFLEN ];
-       size_t          textlen = sizeof( textbuf );
-       
-       if( op->o_req_ndn.bv_len == 0 ) {
-               Debug( LDAP_DEBUG_ANY, "do_modify: root dse!\n", 0, 0, 0 );
+       Debug( LDAP_DEBUG_ARGS, "%s modifications:\n",
+                       op->o_log_prefix, 0, 0 );
 
-               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
-                       "modify upon the root DSE not supported" );
-               goto cleanup;
-
-       } else if ( bvmatch( &op->o_req_ndn, &frontendDB->be_schemandn ) ) {
-               Debug( LDAP_DEBUG_ANY, "do_modify: subschema subentry!\n", 0, 0, 0 );
-
-               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
-                       "modification of subschema subentry not supported" );
-               goto cleanup;
-       }
-
-#ifdef LDAP_DEBUG
-       Debug( LDAP_DEBUG_ARGS, "modifications:\n", 0, 0, 0 );
-
-       for ( tmp = modlist; tmp != NULL; tmp = tmp->sml_next ) {
+       for ( tmp = op->orm_modlist; tmp != NULL; tmp = tmp->sml_next ) {
                Debug( LDAP_DEBUG_ARGS, "\t%s: %s\n",
                        tmp->sml_op == LDAP_MOD_ADD ? "add" :
                                (tmp->sml_op == LDAP_MOD_INCREMENT ? "increment" :
@@ -251,10 +118,10 @@ fe_op_modify( Operation *op, SlapReply *rs )
                if ( tmp->sml_values == NULL ) {
                        Debug( LDAP_DEBUG_ARGS, "%s\n",
                           "\t\tno values", NULL, NULL );
-               } else if ( tmp->sml_values[0].bv_val == NULL ) {
+               } else if ( BER_BVISNULL( &tmp->sml_values[ 0 ] ) ) {
                        Debug( LDAP_DEBUG_ARGS, "%s\n",
                           "\t\tzero values", NULL, NULL );
-               } else if ( tmp->sml_values[1].bv_val == NULL ) {
+               } else if ( BER_BVISNULL( &tmp->sml_values[ 1 ] ) ) {
                        Debug( LDAP_DEBUG_ARGS, "%s, length %ld\n",
                           "\t\tone value", (long) tmp->sml_values[0].bv_len, NULL );
                } else {
@@ -270,12 +137,12 @@ fe_op_modify( Operation *op, SlapReply *rs )
                Statslog( LDAP_DEBUG_STATS, "%s MOD dn=\"%s\"\n",
                        op->o_log_prefix, op->o_req_dn.bv_val, 0, 0, 0 );
 
-               for ( tmp = modlist; tmp != NULL; tmp = tmp->sml_next ) {
+               for ( tmp = op->orm_modlist; tmp != NULL; tmp = tmp->sml_next ) {
                        if (len + 1 + tmp->sml_type.bv_len > sizeof(abuf)) {
                                Statslog( LDAP_DEBUG_STATS, "%s MOD attr=%s\n",
                                    op->o_log_prefix, abuf, 0, 0, 0 );
 
-                               len = 0;
+                               len = 0;
                                ptr = abuf;
 
                                if( 1 + tmp->sml_type.bv_len > sizeof(abuf)) {
@@ -298,31 +165,79 @@ fe_op_modify( Operation *op, SlapReply *rs )
        }
 #endif /* LDAP_DEBUG */
 
-       manageDSAit = get_manageDSAit( op );
+       rs->sr_err = slap_mods_check( op, op->orm_modlist,
+               &rs->sr_text, textbuf, textlen, NULL );
+
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               send_ldap_result( op, rs );
+               goto cleanup;
+       }
+
+       op->o_bd = frontendDB;
+       rs->sr_err = frontendDB->be_modify( op, rs );
+
+#ifdef LDAP_X_TXN
+       if( rs->sr_err == LDAP_X_TXN_SPECIFY_OKAY ) {
+               /* skip cleanup */
+               return rs->sr_err;
+       }
+#endif
+
+cleanup:
+       op->o_tmpfree( op->o_req_dn.bv_val, op->o_tmpmemctx );
+       op->o_tmpfree( op->o_req_ndn.bv_val, op->o_tmpmemctx );
+       if ( op->orm_modlist != NULL ) slap_mods_free( op->orm_modlist, 1 );
+
+       return rs->sr_err;
+}
+
+int
+fe_op_modify( Operation *op, SlapReply *rs )
+{
+       BackendDB       *op_be, *bd = op->o_bd;
+       char            textbuf[ SLAP_TEXT_BUFLEN ];
+       size_t          textlen = sizeof( textbuf );
+       
+       if ( BER_BVISEMPTY( &op->o_req_ndn ) ) {
+               Debug( LDAP_DEBUG_ANY, "%s do_modify: root dse!\n",
+                       op->o_log_prefix, 0, 0 );
+               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+                       "modify upon the root DSE not supported" );
+               goto cleanup;
+
+       } else if ( bvmatch( &op->o_req_ndn, &frontendDB->be_schemandn ) ) {
+               Debug( LDAP_DEBUG_ANY, "%s do_modify: subschema subentry!\n",
+                       op->o_log_prefix, 0, 0 );
+               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+                       "modification of subschema subentry not supported" );
+               goto cleanup;
+       }
 
        /*
         * We could be serving multiple database backends.  Select the
         * appropriate one, or send a referral to our "referral server"
         * if we don't hold it.
         */
-       op->o_bd = select_backend( &op->o_req_ndn, manageDSAit, 1 );
+       op->o_bd = select_backend( &op->o_req_ndn, 1 );
        if ( op->o_bd == NULL ) {
+               op->o_bd = bd;
                rs->sr_ref = referral_rewrite( default_referral,
                        NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
-               if (!rs->sr_ref) rs->sr_ref = default_referral;
+               if ( !rs->sr_ref ) {
+                       rs->sr_ref = default_referral;
+               }
 
-               if (rs->sr_ref != NULL ) {
+               if ( rs->sr_ref != NULL ) {
                        rs->sr_err = LDAP_REFERRAL;
-                       op->o_bd = frontendDB;
                        send_ldap_result( op, rs );
-                       op->o_bd = NULL;
 
-                       if (rs->sr_ref != default_referral) ber_bvarray_free( rs->sr_ref );
+                       if ( rs->sr_ref != default_referral ) {
+                               ber_bvarray_free( rs->sr_ref );
+                       }
+
                } else {
-                       op->o_bd = frontendDB;
                        send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
                                "no global superior knowledge" );
-                       op->o_bd = NULL;
                }
                goto cleanup;
        }
@@ -330,33 +245,32 @@ fe_op_modify( Operation *op, SlapReply *rs )
        /* If we've got a glued backend, check the real backend */
        op_be = op->o_bd;
        if ( SLAP_GLUE_INSTANCE( op->o_bd )) {
-               op->o_bd = select_backend( &op->o_req_ndn, manageDSAit, 0 );
+               op->o_bd = select_backend( &op->o_req_ndn, 0 );
        }
 
        /* check restrictions */
-       if( backend_check_restrictions( op, rs, NULL ) != LDAP_SUCCESS ) {
+       if ( backend_check_restrictions( op, rs, NULL ) != LDAP_SUCCESS ) {
                send_ldap_result( op, rs );
                goto cleanup;
        }
 
        /* check for referrals */
-       if( backend_check_referrals( op, rs ) != LDAP_SUCCESS ) {
+       if ( backend_check_referrals( op, rs ) != LDAP_SUCCESS ) {
                goto cleanup;
        }
 
-       {
-               rs->sr_err = slap_mods_obsolete_check( op, modlist,
-                       &rs->sr_text, textbuf, textlen );
-               if ( rs->sr_err != LDAP_SUCCESS ) {
-                       send_ldap_result( op, rs );
-                       goto cleanup;
-               }
+       rs->sr_err = slap_mods_obsolete_check( op, op->orm_modlist,
+               &rs->sr_text, textbuf, textlen );
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               send_ldap_result( op, rs );
+               goto cleanup;
        }
 
        /* check for modify/increment support */
-       ifincrement && !SLAP_INCREMENT( op->o_bd ) ) {
+       if ( op->orm_increment && !SLAP_INCREMENT( op->o_bd ) ) {
                send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
                        "modify/increment not supported in context" );
+               goto cleanup;
        }
 
        /*
@@ -369,58 +283,26 @@ fe_op_modify( Operation *op, SlapReply *rs )
                /* do the update here */
                int repl_user = be_isupdate( op );
 
-               /* Multimaster slapd does not have to check for replicator dn
+               /*
+                * Multimaster slapd does not have to check for replicator dn
                 * because it accepts each modify request
                 */
-#ifndef SLAPD_MULTIMASTER
-               if ( !SLAP_SHADOW(op->o_bd) || repl_user )
-#endif
-               {
-                       int             update = !BER_BVISEMPTY( &op->o_bd->be_update_ndn );
-                       slap_callback   cb = { NULL, slap_replog_cb, NULL, NULL };
+               if ( !SLAP_SINGLE_SHADOW(op->o_bd) || repl_user ) {
+                       int update = !BER_BVISEMPTY( &op->o_bd->be_update_ndn );
 
                        op->o_bd = op_be;
 
                        if ( !update ) {
-                               rs->sr_err = slap_mods_no_user_mod_check( op, modlist,
+                               rs->sr_err = slap_mods_no_user_mod_check( op, op->orm_modlist,
                                        &rs->sr_text, textbuf, textlen );
                                if ( rs->sr_err != LDAP_SUCCESS ) {
                                        send_ldap_result( op, rs );
                                        goto cleanup;
                                }
                        }
-
-                       if ( !repl_user ) {
-                               for( modtail = &modlist;
-                                       *modtail != NULL;
-                                       modtail = &(*modtail)->sml_next )
-                               {
-                                       /* empty */
-                               }
-
-                               rs->sr_err = slap_mods_opattrs( op, modlist, modtail,
-                                       &rs->sr_text, textbuf, textlen, 1 );
-                               if( rs->sr_err != LDAP_SUCCESS ) {
-                                       send_ldap_result( op, rs );
-                                       goto cleanup;
-                               }
-                       }
-
-                       op->orm_modlist = modlist;
-#ifdef SLAPD_MULTIMASTER
-                       if ( !repl_user )
-#endif
-                       {
-                               /* but multimaster slapd logs only the ones 
-                                * not from a replicator user */
-                               cb.sc_next = op->o_callback;
-                               op->o_callback = &cb;
-                       }
                        op->o_bd->be_modify( op, rs );
 
-#ifndef SLAPD_MULTIMASTER
-               /* send a referral */
-               } else {
+               } else { /* send a referral */
                        BerVarray defref = op->o_bd->be_update_refs
                                ? op->o_bd->be_update_refs : default_referral;
                        if ( defref != NULL ) {
@@ -442,14 +324,15 @@ fe_op_modify( Operation *op, SlapReply *rs )
                                send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
                                        "shadow context; no update referral" );
                        }
-#endif
                }
+
        } else {
                send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
                    "operation not supported within namingContext" );
        }
 
 cleanup:;
+       op->o_bd = bd;
        return rs->sr_err;
 }
 
@@ -464,7 +347,7 @@ slap_mods_obsolete_check(
        char *textbuf,
        size_t textlen )
 {
-       if( get_manageDIT( op ) ) return LDAP_SUCCESS;
+       if( get_relax( op ) ) return LDAP_SUCCESS;
 
        for ( ; ml != NULL; ml = ml->sml_next ) {
                if ( is_at_obsolete( ml->sml_desc->ad_type ) &&
@@ -499,10 +382,17 @@ slap_mods_no_user_mod_check(
        size_t textlen )
 {
        for ( ; ml != NULL; ml = ml->sml_next ) {
-               if ( !is_at_no_user_mod( ml->sml_desc->ad_type ) ) continue;
+               if ( !is_at_no_user_mod( ml->sml_desc->ad_type ) ) {
+                       continue;
+               }
 
-               if( get_manageDIT( op )) {
+               if ( ml->sml_flags & SLAP_MOD_INTERNAL ) {
+                       continue;
+               }
+
+               if ( get_relax( op ) ) {
                        if ( ml->sml_desc->ad_type->sat_flags & SLAP_AT_MANAGEABLE ) {
+                               ml->sml_flags |= SLAP_MOD_MANAGING;
                                continue;
                        }
 
@@ -545,6 +435,7 @@ slap_mods_no_repl_user_mod_check(
                                snprintf( textbuf, textlen,
                                        "attribute '%s' provided more than once",
                                        mods->sml_desc->ad_cname.bv_val );
+                               *text = textbuf;
                                return LDAP_TYPE_OR_VALUE_EXISTS;
                        }
                }
@@ -557,6 +448,7 @@ slap_mods_no_repl_user_mod_check(
  * Do basic attribute type checking and syntax validation.
  */
 int slap_mods_check(
+       Operation *op,
        Modifications *ml,
        const char **text,
        char *textbuf,
@@ -571,6 +463,12 @@ int slap_mods_check(
                /* convert to attribute description */
                if ( ml->sml_desc == NULL ) {
                        rc = slap_bv2ad( &ml->sml_type, &ml->sml_desc, text );
+                       if( rc != LDAP_SUCCESS ) {
+                               if ( get_no_schema_check( op )) {
+                                       rc = slap_bv2undef_ad( &ml->sml_type, &ml->sml_desc,
+                                               text, 0 );
+                               }
+                       }
                        if( rc != LDAP_SUCCESS ) {
                                snprintf( textbuf, textlen, "%s: %s",
                                        ml->sml_type.bv_val, *text );
@@ -670,14 +568,15 @@ int slap_mods_check(
                         * check that each value is valid per syntax
                         *      and pretty if appropriate
                         */
-                       for( nvals = 0; ml->sml_values[nvals].bv_val; nvals++ ) {
+                       for ( nvals = 0; !BER_BVISNULL( &ml->sml_values[nvals] ); nvals++ ) {
                                struct berval pval;
-                               if( pretty ) {
-                                       rc = pretty( ad->ad_type->sat_syntax,
+
+                               if ( pretty ) {
+                                       rc = ordered_value_pretty( ad,
                                                &ml->sml_values[nvals], &pval, ctx );
                                } else {
-                                       rc = validate( ad->ad_type->sat_syntax,
-                                               &ml->sml_values[nvals] );
+                                       rc = ordered_value_validate( ad,
+                                               &ml->sml_values[nvals], ml->sml_op );
                                }
 
                                if( rc != 0 ) {
@@ -693,6 +592,8 @@ int slap_mods_check(
                                        ml->sml_values[nvals] = pval;
                                }
                        }
+                       ml->sml_values[nvals].bv_len = 0;
+                       ml->sml_numvals = nvals;
 
                        /*
                         * a rough single value check... an additional check is needed
@@ -722,13 +623,13 @@ int slap_mods_check(
                                ml->sml_nvalues = ber_memalloc_x(
                                        (nvals+1)*sizeof(struct berval), ctx );
 
-                               for( nvals = 0; ml->sml_values[nvals].bv_val; nvals++ ) {
-                                       rc = ad->ad_type->sat_equality->smr_normalize(
+                               for ( nvals = 0; !BER_BVISNULL( &ml->sml_values[nvals] ); nvals++ ) {
+                                       rc = ordered_value_normalize(
                                                SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
-                                               ad->ad_type->sat_syntax,
+                                               ad,
                                                ad->ad_type->sat_equality,
                                                &ml->sml_values[nvals], &ml->sml_nvalues[nvals], ctx );
-                                       if( rc ) {
+                                       if ( rc ) {
                                                Debug( LDAP_DEBUG_ANY,
                                                        "<= str2entry NULL (ssyn_normalize %d)\n",
                                                        rc, 0, 0 );
@@ -736,262 +637,462 @@ int slap_mods_check(
                                                        "%s: value #%ld normalization failed",
                                                        ml->sml_type.bv_val, (long) nvals );
                                                *text = textbuf;
+                                               BER_BVZERO( &ml->sml_nvalues[nvals] );
                                                return rc;
                                        }
                                }
 
-                               ml->sml_nvalues[nvals].bv_val = NULL;
-                               ml->sml_nvalues[nvals].bv_len = 0;
+                               BER_BVZERO( &ml->sml_nvalues[nvals] );
                        }
 
                        /* check for duplicates, but ignore Deletes.
                         */
                        if( nvals > 1 && ml->sml_op != LDAP_MOD_DELETE ) {
-                               int             i, j, rc, match;
-                               MatchingRule *mr = ad->ad_type->sat_equality;
-
-                               for ( i = 1; i < nvals ; i++ ) {
-                                       /* test asserted values against themselves */
-                                       for( j = 0; j < i; j++ ) {
-                                               rc = ordered_value_match( &match, ml->sml_desc, mr,
-                                                       SLAP_MR_EQUALITY
-                                                               | SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX
-                                                               | SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH
-                                                               | SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH,
-                                                       ml->sml_nvalues
-                                                               ? &ml->sml_nvalues[i]
-                                                               : &ml->sml_values[i],
-                                                       ml->sml_nvalues
-                                                               ? &ml->sml_nvalues[j]
-                                                               : &ml->sml_values[j],
-                                                       text );
-                                               if ( rc == LDAP_SUCCESS && match == 0 ) {
-                                                       /* value exists already */
-                                                       snprintf( textbuf, textlen,
-                                                               "%s: value #%d provided more than once",
-                                                               ml->sml_desc->ad_cname.bv_val, j );
-                                                       *text = textbuf;
-                                                       return LDAP_TYPE_OR_VALUE_EXISTS;
-
-                                               } else if ( rc != LDAP_SUCCESS ) {
-                                                       return rc;
-                                               }
-                                       }
+                               int i;
+                               rc = slap_sort_vals( ml, text, &i, ctx );
+                               if ( rc == LDAP_TYPE_OR_VALUE_EXISTS ) {
+                                       /* value exists already */
+                                       snprintf( textbuf, textlen,
+                                               "%s: value #%d provided more than once",
+                                               ml->sml_desc->ad_cname.bv_val, i );
+                                       *text = textbuf;
                                }
+                               if ( rc )
+                                       return rc;
                        }
-
+               } else {
+                       ml->sml_numvals = 0;
                }
        }
 
        return LDAP_SUCCESS;
 }
 
+/* Sort a set of values. An (Attribute *) may be used interchangeably here
+ * instead of a (Modifications *) structure.
+ *
+ * Uses Quicksort + Insertion sort for small arrays
+ */
+
+int
+slap_sort_vals(
+       Modifications *ml,
+       const char **text,
+       int *dup,
+       void *ctx )
+{
+       AttributeDescription *ad;
+       MatchingRule *mr;
+       int istack[sizeof(int)*16];
+       int i, j, k, l, ir, jstack, match, *ix, itmp, nvals, rc = LDAP_SUCCESS;
+       int is_norm;
+       struct berval a, *cv;
+
+#define SMALL  8
+#define        SWAP(a,b,tmp)   tmp=(a);(a)=(b);(b)=tmp
+#define        COMP(a,b)       match=0; rc = ordered_value_match( &match, \
+                                               ad, mr, SLAP_MR_EQUALITY \
+                                                               | SLAP_MR_VALUE_OF_ASSERTION_SYNTAX \
+                                                               | SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH \
+                                                               | SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH, \
+                                                               &(a), &(b), text );
+
+#define        IX(x)   ix[x]
+#define        EXCH(x,y)       SWAP(ix[x],ix[y],itmp)
+#define        SETA(x) itmp = ix[x]; a = cv[itmp]
+#define        GETA(x) ix[x] = itmp;
+#define        SET(x,y)        ix[x] = ix[y]
+
+       ad = ml->sml_desc;
+       nvals = ml->sml_numvals;
+       if ( nvals <= 1 )
+               goto ret;
+
+       /* For Modifications, sml_nvalues is NULL if normalization wasn't needed.
+        * For Attributes, sml_nvalues == sml_values when normalization isn't needed.
+        */
+       if ( ml->sml_nvalues && ml->sml_nvalues != ml->sml_values ) {
+               cv = ml->sml_nvalues;
+               is_norm = 1;
+       } else {
+               cv = ml->sml_values;
+               is_norm = 0;
+       }
+
+       if ( ad == slap_schema.si_ad_objectClass )
+               mr = NULL;      /* shortcut matching */
+       else
+               mr = ad->ad_type->sat_equality;
+
+       /* record indices to preserve input ordering */
+       ix = slap_sl_malloc( nvals * sizeof(int), ctx );
+       for (i=0; i<nvals; i++) ix[i] = i;
+
+       ir = nvals-1;
+       l = 0;
+       jstack = 0;
+
+       for(;;) {
+               if (ir - l < SMALL) {   /* Insertion sort */
+                       match=1;
+                       for (j=l+1;j<=ir;j++) {
+                               SETA(j);
+                               for (i=j-1;i>=0;i--) {
+                                       COMP(cv[IX(i)], a);
+                                       if ( match <= 0 )
+                                               break;
+                                       SET(i+1,i);
+                               }
+                               GETA(i+1);
+                               if ( match == 0 ) goto done;
+                       }
+                       if ( jstack == 0 ) break;
+                       if ( match == 0 ) break;
+                       ir = istack[jstack--];
+                       l = istack[jstack--];
+               } else {
+                       k = (l + ir) >> 1;      /* Choose median of left, center, right */
+                       EXCH(k, l+1);
+                       COMP( cv[IX(l)], cv[IX(ir)] );
+                       if ( match > 0 ) {
+                               EXCH(l, ir);
+                       } else if ( match == 0 ) {
+                               i = ir;
+                               break;
+                       }
+                       COMP( cv[IX(l+1)], cv[IX(ir)] );
+                       if ( match > 0 ) {
+                               EXCH(l+1, ir);
+                       } else if ( match == 0 ) {
+                               i = ir;
+                               break;
+                       }
+                       COMP( cv[IX(l)], cv[IX(l+1)] );
+                       if ( match > 0 ) {
+                               EXCH(l, l+1);
+                       } else if ( match == 0 ) {
+                               i = l;
+                               break;
+                       }
+                       i = l+1;
+                       j = ir;
+                       a = cv[IX(i)];
+                       for(;;) {
+                               do {
+                                       i++;
+                                       COMP( cv[IX(i)], a );
+                               } while( match < 0 );
+                               while( match > 0 ) {
+                                       j--;
+                                       COMP( cv[IX(j)], a );
+                               }
+                               if (j < i) {
+                                       match = 1;
+                                       break;
+                               }
+                               if ( match == 0 ) {
+                                       i = l+1;
+                                       break;
+                               }
+                               EXCH(i,j);
+                       }
+                       if ( match == 0 )
+                               break;
+                       EXCH(l+1,j);
+                       jstack += 2;
+                       if (ir-i+1 >= j) {
+                               istack[jstack] = ir;
+                               istack[jstack-1] = i;
+                               ir = j;
+                       } else {
+                               istack[jstack] = j;
+                               istack[jstack-1] = l;
+                               l = i;
+                       }
+               }
+       }
+       done:
+       if ( match == 0 && i >= 0 )
+               *dup = ix[i];
+
+       /* For sorted attributes, put the values in index order */
+       if ( rc == LDAP_SUCCESS && match &&
+               ( ad->ad_type->sat_flags & SLAP_AT_SORTED_VAL )) {
+               BerVarray tmpv = slap_sl_malloc( sizeof( struct berval ) * nvals, ctx );
+               for ( i = 0; i<nvals; i++ )
+                       tmpv[i] = cv[ix[i]];
+               for ( i = 0; i<nvals; i++ )
+                       cv[i] = tmpv[i];
+               /* Check if the non-normalized array needs to move too */
+               if ( is_norm ) {
+                       cv = ml->sml_values;
+                       for ( i = 0; i<nvals; i++ )
+                               tmpv[i] = cv[ix[i]];
+                       for ( i = 0; i<nvals; i++ )
+                               cv[i] = tmpv[i];
+               }
+               slap_sl_free( tmpv, ctx );
+       }
+
+       slap_sl_free( ix, ctx );
+
+       if ( rc == LDAP_SUCCESS && match == 0 ) {
+               /* value exists already */
+               assert( i >= 0 );
+               assert( i < nvals );
+               rc = LDAP_TYPE_OR_VALUE_EXISTS;
+       }
+ ret:
+       return rc;
+}
+
 /* Enter with bv->bv_len = sizeof buffer, returns with
  * actual length of string
  */
 void slap_timestamp( time_t *tm, struct berval *bv )
 {
-       struct tm *ltm;
-#ifdef HAVE_GMTIME_R
-       struct tm ltm_buf;
-
-       ltm = gmtime_r( tm, &ltm_buf );
-#else
-       ldap_pvt_thread_mutex_lock( &gmtime_mutex );
-       ltm = gmtime( tm );
-#endif
+       struct tm ltm;
 
-       bv->bv_len = lutil_gentime( bv->bv_val, bv->bv_len, ltm );
+       ldap_pvt_gmtime( tm, &ltm );
 
-#ifndef HAVE_GMTIME_R
-       ldap_pvt_thread_mutex_unlock( &gmtime_mutex );
-#endif
+       bv->bv_len = lutil_gentime( bv->bv_val, bv->bv_len, &ltm );
 }
 
-int slap_mods_opattrs(
+/* Called for all modify and modrdn ops. If the current op was replicated
+ * from elsewhere, all of the attrs should already be present.
+ */
+void slap_mods_opattrs(
        Operation *op,
-       Modifications *mods,
-       Modifications **modtail,
-       const char **text,
-       char *textbuf, size_t textlen,
+       Modifications **modsp,
        int manage_ctxcsn )
 {
-       struct berval name, timestamp, csn;
+       struct berval name, timestamp, csn = BER_BVNULL;
        struct berval nname;
        char timebuf[ LDAP_LUTIL_GENTIME_BUFSIZE ];
-       char csnbuf[ LDAP_LUTIL_CSNSTR_BUFSIZE ];
-       Modifications *mod;
+       char csnbuf[ LDAP_PVT_CSNSTR_BUFSIZE ];
+       Modifications *mod, **modtail, *modlast;
+       int gotcsn = 0, gotmname = 0, gotmtime = 0;
 
-       int mop = op->o_tag == LDAP_REQ_ADD
-               ? LDAP_MOD_ADD : LDAP_MOD_REPLACE;
+       if ( SLAP_LASTMOD( op->o_bd ) && !op->orm_no_opattrs ) {
+               char *ptr;
+               timestamp.bv_val = timebuf;
+               for ( modtail = modsp; *modtail; modtail = &(*modtail)->sml_next ) {
+                       if ( (*modtail)->sml_op != LDAP_MOD_ADD &&
+                               (*modtail)->sml_op != SLAP_MOD_SOFTADD &&
+                               (*modtail)->sml_op != SLAP_MOD_ADD_IF_NOT_PRESENT &&
+                               (*modtail)->sml_op != LDAP_MOD_REPLACE )
+                       {
+                               continue;
+                       }
 
-       assert( modtail != NULL );
-       assert( *modtail == NULL );
+                       if ( (*modtail)->sml_desc == slap_schema.si_ad_entryCSN )
+                       {
+                               csn = (*modtail)->sml_values[0];
+                               gotcsn = 1;
 
-       if ( SLAP_LASTMOD( op->o_bd )) {
-               time_t now = slap_get_time();
+                       } else if ( (*modtail)->sml_desc == slap_schema.si_ad_modifiersName )
+                       {
+                               gotmname = 1;
 
-               slap_get_csn( op, csnbuf, sizeof(csnbuf), &csn, manage_ctxcsn );
+                       } else if ( (*modtail)->sml_desc == slap_schema.si_ad_modifyTimestamp )
+                       {
+                               gotmtime = 1;
+                       }
+               }
 
-               timestamp.bv_val = timebuf;
-               timestamp.bv_len = sizeof(timebuf);
+               if ( BER_BVISEMPTY( &op->o_csn )) {
+                       if ( !gotcsn ) {
+                               csn.bv_val = csnbuf;
+                               csn.bv_len = sizeof( csnbuf );
+                               slap_get_csn( op, &csn, manage_ctxcsn );
 
-               slap_timestamp( &now, &timestamp );
+                       } else {
+                               if ( manage_ctxcsn ) {
+                                       slap_queue_csn( op, &csn );
+                               }
+                       }
 
-               if( op->o_dn.bv_len == 0 ) {
-                       BER_BVSTR( &name, SLAPD_ANONYMOUS );
-                       nname = name;
                } else {
-                       name = op->o_dn;
-                       nname = op->o_ndn;
+                       csn = op->o_csn;
                }
-       }
 
-       if( op->o_tag == LDAP_REQ_ADD ) {
-               struct berval tmpval;
+               ptr = ber_bvchr( &csn, '#' );
+               if ( ptr ) {
+                       timestamp.bv_len = STRLENOF("YYYYMMDDHHMMSSZ");
+                       AC_MEMCPY( timebuf, csn.bv_val, timestamp.bv_len );
+                       timebuf[timestamp.bv_len-1] = 'Z';
+                       timebuf[timestamp.bv_len] = '\0';
 
-               {
-                       int rc = mods_structural_class( mods, &tmpval,
-                               text, textbuf, textlen );
-                       if( rc != LDAP_SUCCESS ) return rc;
+               } else {
+                       time_t now = slap_get_time();
 
-                       mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-                       mod->sml_op = mop;
-                       mod->sml_flags = SLAP_MOD_INTERNAL;
-                       mod->sml_type.bv_val = NULL;
-                       mod->sml_desc = slap_schema.si_ad_structuralObjectClass;
-                       mod->sml_values =
-                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-                       ber_dupbv( &mod->sml_values[0], &tmpval );
-                       mod->sml_values[1].bv_len = 0;
-                       mod->sml_values[1].bv_val = NULL;
-                       assert( mod->sml_values[0].bv_val != NULL );
-                       mod->sml_nvalues =
-                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-                       ber_dupbv( &mod->sml_nvalues[0], &tmpval );
-                       mod->sml_nvalues[1].bv_len = 0;
-                       mod->sml_nvalues[1].bv_val = NULL;
-                       assert( mod->sml_nvalues[0].bv_val != NULL );
-                       *modtail = mod;
-                       modtail = &mod->sml_next;
+                       timestamp.bv_len = sizeof(timebuf);
+
+                       slap_timestamp( &now, &timestamp );
                }
 
-               if ( SLAP_LASTMOD( op->o_bd )) {
-                       char uuidbuf[ LDAP_LUTIL_UUIDSTR_BUFSIZE ];
+               if ( BER_BVISEMPTY( &op->o_dn ) ) {
+                       BER_BVSTR( &name, SLAPD_ANONYMOUS );
+                       nname = name;
 
-                       tmpval.bv_len = lutil_uuidstr( uuidbuf, sizeof( uuidbuf ) );
-                       tmpval.bv_val = uuidbuf;
-               
+               } else {
+                       name = op->o_dn;
+                       nname = op->o_ndn;
+               }
+
+               if ( !gotcsn ) {
                        mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-                       mod->sml_op = mop;
+                       mod->sml_op = LDAP_MOD_REPLACE;
                        mod->sml_flags = SLAP_MOD_INTERNAL;
-                       mod->sml_type.bv_val = NULL;
-                       mod->sml_desc = slap_schema.si_ad_entryUUID;
-                       mod->sml_values =
-                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-                       ber_dupbv( &mod->sml_values[0], &tmpval );
-                       mod->sml_values[1].bv_len = 0;
-                       mod->sml_values[1].bv_val = NULL;
-                       assert( mod->sml_values[0].bv_val != NULL );
-                       mod->sml_nvalues =
-                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-                       (*mod->sml_desc->ad_type->sat_equality->smr_normalize)(
-                                       SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
-                                       mod->sml_desc->ad_type->sat_syntax,
-                                       mod->sml_desc->ad_type->sat_equality,
-                                       mod->sml_values, mod->sml_nvalues, NULL );
-                       mod->sml_nvalues[1].bv_len = 0;
-                       mod->sml_nvalues[1].bv_val = NULL;
+                       mod->sml_next = NULL;
+                       BER_BVZERO( &mod->sml_type );
+                       mod->sml_desc = slap_schema.si_ad_entryCSN;
+                       mod->sml_numvals = 1;
+                       mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       ber_dupbv( &mod->sml_values[0], &csn );
+                       BER_BVZERO( &mod->sml_values[1] );
+                       assert( !BER_BVISNULL( &mod->sml_values[0] ) );
+                       mod->sml_nvalues = NULL;
                        *modtail = mod;
+                       modlast = mod;
                        modtail = &mod->sml_next;
+               }
 
+               if ( !gotmname ) {
                        mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-                       mod->sml_op = mop;
+                       mod->sml_op = LDAP_MOD_REPLACE;
                        mod->sml_flags = SLAP_MOD_INTERNAL;
-                       mod->sml_type.bv_val = NULL;
-                       mod->sml_desc = slap_schema.si_ad_creatorsName;
-                       mod->sml_values =
-                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       mod->sml_next = NULL;
+                       BER_BVZERO( &mod->sml_type );
+                       mod->sml_desc = slap_schema.si_ad_modifiersName;
+                       mod->sml_numvals = 1;
+                       mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
                        ber_dupbv( &mod->sml_values[0], &name );
-                       mod->sml_values[1].bv_len = 0;
-                       mod->sml_values[1].bv_val = NULL;
-                       assert( mod->sml_values[0].bv_val != NULL );
+                       BER_BVZERO( &mod->sml_values[1] );
+                       assert( !BER_BVISNULL( &mod->sml_values[0] ) );
                        mod->sml_nvalues =
                                (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
                        ber_dupbv( &mod->sml_nvalues[0], &nname );
-                       mod->sml_nvalues[1].bv_len = 0;
-                       mod->sml_nvalues[1].bv_val = NULL;
-                       assert( mod->sml_nvalues[0].bv_val != NULL );
+                       BER_BVZERO( &mod->sml_nvalues[1] );
+                       assert( !BER_BVISNULL( &mod->sml_nvalues[0] ) );
                        *modtail = mod;
                        modtail = &mod->sml_next;
+               }
 
+               if ( !gotmtime ) {
                        mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-                       mod->sml_op = mop;
+                       mod->sml_op = LDAP_MOD_REPLACE;
                        mod->sml_flags = SLAP_MOD_INTERNAL;
-                       mod->sml_type.bv_val = NULL;
-                       mod->sml_desc = slap_schema.si_ad_createTimestamp;
-                       mod->sml_values =
-                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       mod->sml_next = NULL;
+                       BER_BVZERO( &mod->sml_type );
+                       mod->sml_desc = slap_schema.si_ad_modifyTimestamp;
+                       mod->sml_numvals = 1;
+                       mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
                        ber_dupbv( &mod->sml_values[0], &timestamp );
-                       mod->sml_values[1].bv_len = 0;
-                       mod->sml_values[1].bv_val = NULL;
-                       assert( mod->sml_values[0].bv_val != NULL );
+                       BER_BVZERO( &mod->sml_values[1] );
+                       assert( !BER_BVISNULL( &mod->sml_values[0] ) );
                        mod->sml_nvalues = NULL;
                        *modtail = mod;
                        modtail = &mod->sml_next;
                }
        }
+}
 
-       if ( SLAP_LASTMOD( op->o_bd )) {
-               mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-               mod->sml_op = mop;
-               mod->sml_flags = SLAP_MOD_INTERNAL;
-               mod->sml_type.bv_val = NULL;
-               mod->sml_desc = slap_schema.si_ad_entryCSN;
-               mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-               ber_dupbv( &mod->sml_values[0], &csn );
-               mod->sml_values[1].bv_len = 0;
-               mod->sml_values[1].bv_val = NULL;
-               assert( mod->sml_values[0].bv_val != NULL );
-               mod->sml_nvalues = NULL;
-               *modtail = mod;
-               modtail = &mod->sml_next;
+int
+slap_parse_modlist(
+       Operation *op,
+       SlapReply *rs,
+       BerElement *ber,
+       req_modify_s *ms )
+{
+       ber_tag_t       tag;
+       ber_len_t       len;
+       char            *last;
+       Modifications   **modtail = &ms->rs_mods.rs_modlist;
 
-               mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-               mod->sml_op = mop;
-               mod->sml_flags = SLAP_MOD_INTERNAL;
-               mod->sml_type.bv_val = NULL;
-               mod->sml_desc = slap_schema.si_ad_modifiersName;
-               mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-               ber_dupbv( &mod->sml_values[0], &name );
-               mod->sml_values[1].bv_len = 0;
-               mod->sml_values[1].bv_val = NULL;
-               assert( mod->sml_values[0].bv_val != NULL );
-               mod->sml_nvalues =
-                       (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-               ber_dupbv( &mod->sml_nvalues[0], &nname );
-               mod->sml_nvalues[1].bv_len = 0;
-               mod->sml_nvalues[1].bv_val = NULL;
-               assert( mod->sml_nvalues[0].bv_val != NULL );
-               *modtail = mod;
-               modtail = &mod->sml_next;
+       ms->rs_mods.rs_modlist = NULL;
+       ms->rs_increment = 0;
+
+       rs->sr_err = LDAP_SUCCESS;
+
+       /* collect modifications & save for later */
+       for ( tag = ber_first_element( ber, &len, &last );
+               tag != LBER_DEFAULT;
+               tag = ber_next_element( ber, &len, last ) )
+       {
+               ber_int_t mop;
+               Modifications tmp, *mod;
+
+               tmp.sml_nvalues = NULL;
+
+               if ( ber_scanf( ber, "{e{m[W]}}", &mop,
+                   &tmp.sml_type, &tmp.sml_values ) == LBER_ERROR )
+               {
+                       rs->sr_text = "decoding modlist error";
+                       rs->sr_err = LDAP_PROTOCOL_ERROR;
+                       goto done;
+               }
 
-               mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
+               mod = (Modifications *) ch_malloc( sizeof(Modifications) );
                mod->sml_op = mop;
-               mod->sml_flags = SLAP_MOD_INTERNAL;
-               mod->sml_type.bv_val = NULL;
-               mod->sml_desc = slap_schema.si_ad_modifyTimestamp;
-               mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-               ber_dupbv( &mod->sml_values[0], &timestamp );
-               mod->sml_values[1].bv_len = 0;
-               mod->sml_values[1].bv_val = NULL;
-               assert( mod->sml_values[0].bv_val != NULL );
+               mod->sml_flags = 0;
+               mod->sml_type = tmp.sml_type;
+               mod->sml_values = tmp.sml_values;
                mod->sml_nvalues = NULL;
+               mod->sml_desc = NULL;
+               mod->sml_next = NULL;
                *modtail = mod;
+
+               switch( mop ) {
+               case LDAP_MOD_ADD:
+                       if ( mod->sml_values == NULL ) {
+                               rs->sr_text = "modify/add operation requires values";
+                               rs->sr_err = LDAP_PROTOCOL_ERROR;
+                               goto done;
+                       }
+
+                       /* fall through */
+
+               case LDAP_MOD_DELETE:
+               case LDAP_MOD_REPLACE:
+                       break;
+
+               case LDAP_MOD_INCREMENT:
+                       if( op->o_protocol >= LDAP_VERSION3 ) {
+                               ms->rs_increment++;
+                               if ( mod->sml_values == NULL ) {
+                                       rs->sr_text = "modify/increment operation requires value";
+                                       rs->sr_err = LDAP_PROTOCOL_ERROR;
+                                       goto done;
+                               }
+
+                               if ( !BER_BVISNULL( &mod->sml_values[ 1 ] ) ) {
+                                       rs->sr_text = "modify/increment operation requires single value";
+                                       rs->sr_err = LDAP_PROTOCOL_ERROR;
+                                       goto done;
+                               }
+
+                               break;
+                       }
+                       /* fall thru */
+
+               default:
+                       rs->sr_text = "unrecognized modify operation";
+                       rs->sr_err = LDAP_PROTOCOL_ERROR;
+                       goto done;
+               }
+
                modtail = &mod->sml_next;
        }
-
        *modtail = NULL;
-       return LDAP_SUCCESS;
+
+done:
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               slap_mods_free( ms->rs_mods.rs_modlist, 1 );
+               ms->rs_mods.rs_modlist = NULL;
+               ms->rs_increment = 0;
+       }
+
+       return rs->sr_err;
 }