]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/modify.c
Completely untested built-in EXTERNAL implementation
[openldap] / servers / slapd / modify.c
index 4cdb2898405c0e62f7975a516d92039c367e1dc1..9ab73b0725b944b6a92a721eaab0f8204f0712b0 100644 (file)
@@ -1,10 +1,18 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2003 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
-/*
- * Copyright (c) 1995 Regents of the University of Michigan.
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms are permitted
@@ -47,7 +55,6 @@ do_modify(
 #endif
 #ifdef LDAP_SLAPI
        LDAPMod         **modv = NULL;
-       Slapi_PBlock *pb = op->o_pb;
 #endif
        int manageDSAit;
        int increment = 0;
@@ -316,8 +323,15 @@ do_modify(
                        if (len + 1 + tmp->sml_type.bv_len > sizeof(abuf)) {
                                Statslog( LDAP_DEBUG_STATS, "conn=%lu op=%lu MOD attr=%s\n",
                                    op->o_connid, op->o_opid, abuf, 0, 0 );
-                               len = 0;
+
+                       len = 0;
                                ptr = abuf;
+
+                               if( 1 + tmp->sml_type.bv_len > sizeof(abuf)) {
+                                       Statslog( LDAP_DEBUG_STATS, "conn=%lu op=%lu MOD attr=%s\n",
+                                               op->o_connid, op->o_opid, tmp->sml_type.bv_val, 0, 0 );
+                                       continue;
+                               }
                        }
                        if (len) {
                                *ptr++ = ' ';
@@ -376,51 +390,54 @@ do_modify(
        }
 
 #if defined( LDAP_SLAPI )
-       slapi_x_pblock_set_operation( pb, op );
-       slapi_pblock_set( pb, SLAPI_MODIFY_TARGET, (void *)dn.bv_val );
-       slapi_pblock_set( pb, SLAPI_MANAGEDSAIT, (void *)manageDSAit );
-       modv = slapi_x_modifications2ldapmods( &modlist );
-       slapi_pblock_set( pb, SLAPI_MODIFY_MODS, (void *)modv );
-
-       rs->sr_err = doPluginFNs( op->o_bd, SLAPI_PLUGIN_PRE_MODIFY_FN, pb );
-       if ( rs->sr_err < 0 ) {
-               /*
-                * A preoperation plugin failure will abort the
-                * entire operation.
-                */
+#define pb     op->o_pb
+       if ( pb ) {
+               slapi_int_pblock_set_operation( pb, op );
+               slapi_pblock_set( pb, SLAPI_MODIFY_TARGET, (void *)dn.bv_val );
+               slapi_pblock_set( pb, SLAPI_MANAGEDSAIT, (void *)manageDSAit );
+               modv = slapi_int_modifications2ldapmods( &modlist );
+               slapi_pblock_set( pb, SLAPI_MODIFY_MODS, (void *)modv );
+
+               rs->sr_err = doPluginFNs( op->o_bd, SLAPI_PLUGIN_PRE_MODIFY_FN, pb );
+               if ( rs->sr_err < 0 ) {
+                       /*
+                        * A preoperation plugin failure will abort the
+                        * entire operation.
+                        */
 #ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, INFO, "do_modify: modify preoperation plugin "
-                               "failed\n", 0, 0, 0 );
+                       LDAP_LOG( OPERATION, INFO, "do_modify: modify preoperation plugin "
+                                       "failed\n", 0, 0, 0 );
 #else
-               Debug(LDAP_DEBUG_TRACE, "do_modify: modify preoperation plugin failed.\n",
-                               0, 0, 0);
+                       Debug(LDAP_DEBUG_TRACE, "do_modify: modify preoperation plugin failed.\n",
+                                       0, 0, 0);
 #endif
-               if ( ( slapi_pblock_get( op->o_pb, SLAPI_RESULT_CODE, (void *)&rs->sr_err ) != 0 )  ||
-                    rs->sr_err == LDAP_SUCCESS ) {
-                       rs->sr_err = LDAP_OTHER;
+                       if ( ( slapi_pblock_get( op->o_pb, SLAPI_RESULT_CODE, (void *)&rs->sr_err ) != 0 )  ||
+                                rs->sr_err == LDAP_SUCCESS ) {
+                               rs->sr_err = LDAP_OTHER;
+                       }
+                       slapi_int_free_ldapmods( modv );
+                       modv = NULL;
+                       goto cleanup;
                }
-               slapi_x_free_ldapmods( modv );
-               modv = NULL;
-               goto cleanup;
-       }
 
-       /*
-        * It's possible that the preoperation plugin changed the
-        * modification array, so we need to convert it back to
-        * a Modification list.
-        *
-        * Calling slapi_x_modifications2ldapmods() destroyed modlist so
-        * we don't need to free it.
-        */
-       slapi_pblock_get( pb, SLAPI_MODIFY_MODS, (void **)&modv );
-       modlist = slapi_x_ldapmods2modifications( modv );
+               /*
+                * It's possible that the preoperation plugin changed the
+                * modification array, so we need to convert it back to
+                * a Modification list.
+                *
+                * Calling slapi_int_modifications2ldapmods() destroyed modlist so
+                * we don't need to free it.
+                */
+               slapi_pblock_get( pb, SLAPI_MODIFY_MODS, (void **)&modv );
+               modlist = slapi_int_ldapmods2modifications( modv );
+       }
 
        /*
         * NB: it is valid for the plugin to return no modifications
         * (for example, a plugin might store some attributes elsewhere
         * and remove them from the modification list; if only those
         * attribute types were included in the modification request,
-        * then slapi_x_ldapmods2modifications() above will return
+        * then slapi_int_ldapmods2modifications() above will return
         * NULL).
         *
         * However, the post-operation plugin should still be 
@@ -445,13 +462,11 @@ do_modify(
                /* Multimaster slapd does not have to check for replicator dn
                 * because it accepts each modify request
                 */
-#if defined(LDAP_SYNCREPL) && !defined(SLAPD_MULTIMASTER)
-               if ( !op->o_bd->syncinfo &&
+#ifndef SLAPD_MULTIMASTER
+               if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo ) &&
                        ( !op->o_bd->be_update_ndn.bv_len || repl_user ))
-#elif defined(LDAP_SYNCREPL) && defined(SLAPD_MULTIMASTER)
-               if ( !op->o_bd->syncinfo )  /* LDAP_SYNCREPL overrides MM */
-#elif !defined(LDAP_SYNCREPL) && !defined(SLAPD_MULTIMASTER)
-               if ( !op->o_bd->be_update_ndn.bv_len || repl_user )
+#else
+               if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo ))
 #endif
                {
                        int update = op->o_bd->be_update_ndn.bv_len;
@@ -492,16 +507,18 @@ do_modify(
                                replog( op );
                        }
 
-#if defined(LDAP_SYNCREPL) || !defined(SLAPD_MULTIMASTER)
+#ifndef SLAPD_MULTIMASTER
                /* send a referral */
                } else {
                        BerVarray defref = NULL;
-#ifdef LDAP_SYNCREPL
-                       if ( op->o_bd->syncinfo ) {
-                               defref = op->o_bd->syncinfo->provideruri_bv;
-                       } else
-#endif
-                       {
+                       if ( !LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
+                               syncinfo_t *si;
+                               LDAP_STAILQ_FOREACH( si, &op->o_bd->be_syncinfo, si_next ) {
+                                       struct berval tmpbv;
+                                       ber_dupbv( &tmpbv, &si->si_provideruri_bv[0] );
+                                       ber_bvarray_add( &defref, &tmpbv );
+                               }
+                       } else {
                                defref = op->o_bd->be_update_refs
                                                ? op->o_bd->be_update_refs : default_referral;
                        }
@@ -530,7 +547,7 @@ do_modify(
 #if defined( LDAP_SLAPI )
        } /* modlist != NULL */
 
-       if ( doPluginFNs( op->o_bd, SLAPI_PLUGIN_POST_MODIFY_FN, pb ) < 0 ) {
+       if ( pb && doPluginFNs( op->o_bd, SLAPI_PLUGIN_POST_MODIFY_FN, pb ) < 0 ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, INFO, "do_modify: modify postoperation plugins "
                                "failed\n", 0, 0, 0 );
@@ -543,15 +560,13 @@ do_modify(
 
 cleanup:
 
-#ifdef LDAP_SYNC
-       graduate_commit_csn( op );
-#endif
+       slap_graduate_commit_csn( op );
 
        op->o_tmpfree( op->o_req_dn.bv_val, op->o_tmpmemctx );
        op->o_tmpfree( op->o_req_ndn.bv_val, op->o_tmpmemctx );
        if ( modlist != NULL ) slap_mods_free( modlist );
 #if defined( LDAP_SLAPI )
-       if ( modv != NULL ) slapi_x_free_ldapmods( modv );
+       if ( modv != NULL ) slapi_int_free_ldapmods( modv );
 #endif
        return rs->sr_err;
 }
@@ -718,6 +733,14 @@ int slap_mods_check(
                                return LDAP_CONSTRAINT_VIOLATION;
                        }
 
+                       /* if the type has a normalizer, generate the
+                        * normalized values. otherwise leave them NULL.
+                        *
+                        * this is different from the rule for attributes
+                        * in an entry - in an attribute list, the normalized
+                        * value is set equal to the non-normalized value
+                        * when there is no normalizer.
+                        */
                        if( nvals && ad->ad_type->sat_equality &&
                                ad->ad_type->sat_equality->smr_normalize )
                        {
@@ -726,7 +749,7 @@ int slap_mods_check(
 
                                for( nvals = 0; ml->sml_values[nvals].bv_val; nvals++ ) {
                                        rc = ad->ad_type->sat_equality->smr_normalize(
-                                               0,
+                                               SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
                                                ad->ad_type->sat_syntax,
                                                ad->ad_type->sat_equality,
                                                &ml->sml_values[nvals], &ml->sml_nvalues[nvals], ctx );
@@ -773,47 +796,29 @@ int slap_mods_opattrs(
        int mop = op->o_tag == LDAP_REQ_ADD
                ? LDAP_MOD_ADD : LDAP_MOD_REPLACE;
 
-#ifdef LDAP_SYNC
-       struct slap_csn_entry *pending;
-#endif
-
-#ifdef LDAP_SYNCREPL
-       syncinfo_t *si = op->o_si;
-#endif
-
        assert( modtail != NULL );
        assert( *modtail == NULL );
 
-#ifdef LDAP_SYNCREPL
-       if ( SLAP_LASTMOD(op->o_bd) && ( !si || si->lastmod == LASTMOD_GEN ))
-#else
-       if ( SLAP_LASTMOD(op->o_bd) )
-#endif
-       {
+       if ( SLAP_LASTMOD( op->o_bd )) {
                struct tm *ltm;
-               time_t now = slap_get_time();
-
-#ifdef LDAP_SYNC
-               pending = (struct slap_csn_entry *) ch_calloc( 1, sizeof( struct slap_csn_entry ));
+#ifdef HAVE_GMTIME_R
+               struct tm ltm_buf;
 #endif
+               time_t now = slap_get_time();
 
+#ifdef HAVE_GMTIME_R
+               ltm = gmtime_r( &now, &ltm_buf );
+#else
                ldap_pvt_thread_mutex_lock( &gmtime_mutex );
                ltm = gmtime( &now );
+#endif /* HAVE_GMTIME_R */
                lutil_gentime( timebuf, sizeof(timebuf), ltm );
 
-               csn.bv_len = lutil_csnstr( csnbuf, sizeof( csnbuf ), 0, 0 );
-               csn.bv_val = csnbuf;
-#ifdef LDAP_SYNC
-               ldap_pvt_thread_mutex_lock( &op->o_bd->be_pcl_mutex );
-               pending->csn = ber_dupbv( NULL, &csn );
-               pending->connid = op->o_connid;
-               pending->opid = op->o_opid;
-               pending->state = SLAP_CSN_PENDING;
-               LDAP_TAILQ_INSERT_TAIL( &op->o_bd->be_pending_csn_list, pending, csn_link );
-               ldap_pvt_thread_mutex_unlock( &op->o_bd->be_pcl_mutex );
-#endif
+               slap_get_csn( op, csnbuf, sizeof(csnbuf), &csn, 1 );
 
+#ifndef HAVE_GMTIME_R
                ldap_pvt_thread_mutex_unlock( &gmtime_mutex );
+#endif
 
                timestamp.bv_val = timebuf;
                timestamp.bv_len = strlen(timebuf);
@@ -856,42 +861,40 @@ int slap_mods_opattrs(
                        modtail = &mod->sml_next;
                }
 
-#ifdef LDAP_SYNCREPL
-               if ( SLAP_LASTMOD(op->o_bd) && ( !si || si->lastmod == LASTMOD_GEN ))
-#else
-               if ( SLAP_LASTMOD(op->o_bd) )
-#endif
-               {
+               if ( SLAP_LASTMOD( op->o_bd )) {
                        char uuidbuf[ LDAP_LUTIL_UUIDSTR_BUFSIZE ];
 
-#ifdef LDAP_SYNCREPL
-                       if ( !si ) {
-#endif
-                               tmpval.bv_len = lutil_uuidstr( uuidbuf, sizeof( uuidbuf ) );
-                               tmpval.bv_val = uuidbuf;
+                       tmpval.bv_len = lutil_uuidstr( uuidbuf, sizeof( uuidbuf ) );
+                       tmpval.bv_val = uuidbuf;
                
-                               mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
-                               mod->sml_op = mop;
-                               mod->sml_type.bv_val = NULL;
-                               mod->sml_desc = slap_schema.si_ad_entryUUID;
-                               mod->sml_values =
-                                       (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
-                               ber_dupbv( &mod->sml_values[0], &tmpval );
-                               mod->sml_values[1].bv_len = 0;
-                               mod->sml_values[1].bv_val = NULL;
-                               assert( mod->sml_values[0].bv_val );
-                               mod->sml_nvalues = NULL;
-                               *modtail = mod;
-                               modtail = &mod->sml_next;
-#ifdef LDAP_SYNCREPL
-                       }
-#endif
+                       mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
+                       mod->sml_op = mop;
+                       mod->sml_type.bv_val = NULL;
+                       mod->sml_desc = slap_schema.si_ad_entryUUID;
+                       mod->sml_values =
+                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       ber_dupbv( &mod->sml_values[0], &tmpval );
+                       mod->sml_values[1].bv_len = 0;
+                       mod->sml_values[1].bv_val = NULL;
+                       assert( mod->sml_values[0].bv_val );
+                       mod->sml_nvalues =
+                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       (*mod->sml_desc->ad_type->sat_equality->smr_normalize)(
+                                       SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
+                                       mod->sml_desc->ad_type->sat_syntax,
+                                       mod->sml_desc->ad_type->sat_equality,
+                                       mod->sml_values, mod->sml_nvalues, NULL );
+                       mod->sml_nvalues[1].bv_len = 0;
+                       mod->sml_nvalues[1].bv_val = NULL;
+                       *modtail = mod;
+                       modtail = &mod->sml_next;
 
                        mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
                        mod->sml_op = mop;
                        mod->sml_type.bv_val = NULL;
                        mod->sml_desc = slap_schema.si_ad_creatorsName;
-                       mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       mod->sml_values =
+                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
                        ber_dupbv( &mod->sml_values[0], &name );
                        mod->sml_values[1].bv_len = 0;
                        mod->sml_values[1].bv_val = NULL;
@@ -909,7 +912,8 @@ int slap_mods_opattrs(
                        mod->sml_op = mop;
                        mod->sml_type.bv_val = NULL;
                        mod->sml_desc = slap_schema.si_ad_createTimestamp;
-                       mod->sml_values = (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
+                       mod->sml_values =
+                               (BerVarray) ch_malloc( 2 * sizeof( struct berval ) );
                        ber_dupbv( &mod->sml_values[0], &timestamp );
                        mod->sml_values[1].bv_len = 0;
                        mod->sml_values[1].bv_val = NULL;
@@ -920,12 +924,7 @@ int slap_mods_opattrs(
                }
        }
 
-#ifdef LDAP_SYNCREPL
-       if ( SLAP_LASTMOD(op->o_bd) && ( !si || si->lastmod == LASTMOD_GEN ))
-#else
-       if ( SLAP_LASTMOD(op->o_bd) )
-#endif
-       {
+       if ( SLAP_LASTMOD( op->o_bd )) {
                mod = (Modifications *) ch_malloc( sizeof( Modifications ) );
                mod->sml_op = mop;
                mod->sml_type.bv_val = NULL;