]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/modrdn.c
fix substring_comp_candidates logic if intersection of candidates
[openldap] / servers / slapd / modrdn.c
index a38160f4f2a6790e24418a94600bb5ce82ac96b9..59ce22cdeabddeb812a12eae7602bdea3264a63c 100644 (file)
@@ -32,7 +32,7 @@
 
 #include "slap.h"
 
-void
+int
 do_modrdn(
     Connection *conn,
     Operation  *op
@@ -46,9 +46,18 @@ do_modrdn(
        char    *nnewSuperior = NULL;
        Backend *newSuperior_be = NULL;
        ber_len_t       length;
+       int rc;
 
        Debug( LDAP_DEBUG_TRACE, "do_modrdn\n", 0, 0, 0 );
 
+       if( op->o_bind_in_progress ) {
+               Debug( LDAP_DEBUG_ANY, "do_modrdn: SASL bind in progress.\n",
+                       0, 0, 0 );
+               send_ldap_result( conn, op, LDAP_SASL_BIND_IN_PROGRESS,
+                       NULL, "SASL bind in progress", NULL, NULL );
+               return LDAP_SASL_BIND_IN_PROGRESS;
+       }
+
        /*
         * Parse the modrdn request.  It looks like this:
         *
@@ -63,52 +72,73 @@ do_modrdn(
        if ( ber_scanf( op->o_ber, "{aab", &ndn, &newrdn, &deloldrdn )
            == LBER_ERROR ) {
                Debug( LDAP_DEBUG_ANY, "ber_scanf failed\n", 0, 0, 0 );
-               send_ldap_result( conn, op, LDAP_PROTOCOL_ERROR, NULL, "" );
-               return;
+               send_ldap_disconnect( conn, op,
+                       LDAP_PROTOCOL_ERROR, "decoding error" );
+               return -1;
        }
 
-       Debug( LDAP_DEBUG_ARGS,
-           "do_modrdn: dn (%s) newrdn (%s) deloldrdn (%d)\n", ndn, newrdn,
-           deloldrdn );
-
-
        /* Check for newSuperior parameter, if present scan it */
 
        if ( ber_peek_tag( op->o_ber, &length ) == LDAP_TAG_NEWSUPERIOR ) {
 
-               if ( conn->c_protocol ==  0 ) {
+               if ( op->o_protocol == 0 ) {
                        /*
                         * Promote to LDAPv3
                         */
+                       ldap_pvt_thread_mutex_lock( &conn->c_mutex );
                        conn->c_protocol = LDAP_VERSION3;
+                       ldap_pvt_thread_mutex_unlock( &conn->c_mutex );
+                       op->o_protocol = LDAP_VERSION3;
 
-               } else if ( conn->c_protocol < LDAP_VERSION3 ) {
+               } else if ( op->o_protocol < LDAP_VERSION3 ) {
                        /* Conection record indicates v2 but field 
                         * newSuperior is present: report error.
                         */
                        Debug( LDAP_DEBUG_ANY,
                               "modrdn(v2): invalid field newSuperior!\n",
                               0, 0, 0 );
-                       send_ldap_result( conn, op, LDAP_PROTOCOL_ERROR,
-                                         NULL, "" );
-                       return;
+                       send_ldap_disconnect( conn, op,
+                               LDAP_PROTOCOL_ERROR, "newSuperior requires LDAPv3" );
+                       return -1;
                }
 
-               if ( ber_scanf( op->o_ber, /*{*/ "a}", &newSuperior ) 
+               if ( ber_scanf( op->o_ber, "a", &newSuperior ) 
                     == LBER_ERROR ) {
 
                    Debug( LDAP_DEBUG_ANY, "ber_scanf(\"a\"}) failed\n",
                           0, 0, 0 );
-                   send_ldap_result( conn, op, LDAP_PROTOCOL_ERROR, NULL,
-                                     "" );
-                   return;
+                       send_ldap_disconnect( conn, op,
+                               LDAP_PROTOCOL_ERROR, "decoding error" );
+                   return -1;
+
+               }
+
+       }
 
-               }/* if ( ber_scanf( ber, { "a}", &newSuperior ) == ... ) */
+       Debug( LDAP_DEBUG_ARGS,
+           "do_modrdn: dn (%s) newrdn (%s) newsuperior (%s)\n",
+               ndn, newrdn,
+               newSuperior != NULL ? newSuperior : "" );
 
+       if ( ber_scanf( op->o_ber, /*{*/ "}") == LBER_ERROR ) {
+               free( ndn );
+               free( newrdn ); 
+               free( newSuperior );
+               Debug( LDAP_DEBUG_ANY, "do_modrdn: ber_scanf failed\n", 0, 0, 0 );
+               send_ldap_disconnect( conn, op,
+                               LDAP_PROTOCOL_ERROR, "decoding error" );
+               return -1;
+       }
 
-               Debug( LDAP_DEBUG_ARGS, "do_modrdn: newSuperior=(%s)\n",
-                      newSuperior, 0, 0 );
+       if( (rc = get_ctrls( conn, op, 1 )) != LDAP_SUCCESS ) {
+               free( ndn );
+               free( newrdn ); 
+               free( newSuperior );
+               Debug( LDAP_DEBUG_ANY, "do_modrdn: get_ctrls failed\n", 0, 0, 0 );
+               return rc;
+       } 
 
+       if( newSuperior != NULL ) {
                /* GET BACKEND FOR NEW SUPERIOR */
 
                nnewSuperior = strdup( newSuperior );
@@ -122,7 +152,6 @@ do_modrdn(
                         * XXX: We may need to do something else here, not sure
                         * what though.
                         */
-               
 
                        Debug( LDAP_DEBUG_ARGS,
                               "do_modrdn: cant find backend for=(%s)\n",
@@ -132,18 +161,16 @@ do_modrdn(
                        free( newrdn );
                        free( newSuperior );
                        free( nnewSuperior );
-                       send_ldap_result( conn, op, LDAP_PARTIAL_RESULTS, NULL,
-                                         default_referral );
-                       return;
-                       
+                       send_ldap_result( conn, op, LDAP_REFERRAL,
+                               NULL, NULL, default_referral, NULL );
+                       return 0;
                }
-
-       }/* if ( ber_peek_tag( op->o_ber, &length ) == LDAP_TAG_NEWSUPERIOR )*/
+       }
 
        dn_normalize_case( ndn );
 
        Statslog( LDAP_DEBUG_STATS, "conn=%d op=%d MODRDN dn=\"%s\"\n",
-           conn->c_connid, op->o_opid, ndn, 0, 0 );
+           op->o_connid, op->o_opid, ndn, 0, 0 );
 
        /*
         * We could be serving multiple database backends.  Select the
@@ -156,9 +183,9 @@ do_modrdn(
                free( newrdn ); 
                free( newSuperior );
                free( nnewSuperior );
-               send_ldap_result( conn, op, LDAP_PARTIAL_RESULTS, NULL,
-                   default_referral );
-               return;
+               send_ldap_result( conn, op, rc = LDAP_REFERRAL,
+                       NULL, NULL, default_referral, NULL );
+               return rc;
        }
 
        /* Make sure that the entry being changed and the newSuperior are in 
@@ -175,16 +202,12 @@ do_modrdn(
                free( newSuperior );
                free( nnewSuperior );
                
-               send_ldap_result( conn, op, LDAP_AFFECTS_MULTIPLE_DSAS,
-                                 NULL, "" );
+               send_ldap_result( conn, op, rc = LDAP_AFFECTS_MULTIPLE_DSAS,
+                       NULL, NULL, NULL, NULL );
            
-               return;
+               return rc;
 
-       }/* if ( (newSuperior_be != NULL) && ( be != newSuperior_be) ) */
-
-
-       /* alias suffix if approp */
-       ndn = suffixAlias( ndn, op, be );
+       }
 
        /*
         * do the add if 1 && (2 || 3)
@@ -199,21 +222,22 @@ do_modrdn(
                {
                        if ( (*be->be_modrdn)( be, conn, op, ndn, newrdn,
                            deloldrdn, newSuperior ) == 0 ) {
-                               /* XXX: MAY NEEED TO ADD newSuperior HERE */
+                               /* XXX: MAY NEED TO ADD newSuperior HERE */
                                replog( be, LDAP_REQ_MODRDN, ndn, newrdn,
                                    deloldrdn );
                        }
                } else {
-                       send_ldap_result( conn, op, LDAP_PARTIAL_RESULTS, NULL,
-                           default_referral );
+                       send_ldap_result( conn, op, rc = LDAP_REFERRAL, NULL, NULL,
+                               be->be_update_refs ? be->be_update_refs : default_referral, NULL );
                }
        } else {
-               send_ldap_result( conn, op, LDAP_UNWILLING_TO_PERFORM, NULL,
-                   "Function not implemented" );
+               send_ldap_result( conn, op, rc = LDAP_UNWILLING_TO_PERFORM,
+                       NULL, "Function not implemented", NULL, NULL );
        }
 
        free( ndn );
        free( newrdn ); 
        free( newSuperior );
        free( nnewSuperior );
+       return rc;
 }