]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/modrdn.c
cosmetic changes (the problem was not there)
[openldap] / servers / slapd / modrdn.c
index 0d71c39c981322a0cc07252878b2330f70ee2c93..f6157df780be6e913f897da7cc14af7062597bcf 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2004 The OpenLDAP Foundation.
+ * Copyright 1998-2005 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -38,7 +38,6 @@
 #include <ac/socket.h>
 #include <ac/string.h>
 
-#include "ldap_pvt.h"
 #include "slap.h"
 #ifdef LDAP_SLAPI
 #include "slapi/slapi.h"
@@ -61,11 +60,7 @@ do_modrdn(
 
        ber_len_t       length;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ENTRY, "do_modrdn: begin\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "do_modrdn\n", 0, 0, 0 );
-#endif
 
 
        /*
@@ -82,11 +77,7 @@ do_modrdn(
        if ( ber_scanf( op->o_ber, "{mmb", &dn, &newrdn, &deloldrdn )
            == LBER_ERROR )
        {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, ERR, "do_modrdn: ber_scanf failed\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "ber_scanf failed\n", 0, 0, 0 );
-#endif
 
                send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" );
                return SLAPD_DISCONNECT;
@@ -99,14 +90,9 @@ do_modrdn(
                        /* Conection record indicates v2 but field 
                         * newSuperior is present: report error.
                         */
-#ifdef NEW_LOGGING
-                       LDAP_LOG( OPERATION, ERR,
-                               "do_modrdn: (v2) invalid field newSuperior.\n", 0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY,
                            "modrdn(v2): invalid field newSuperior!\n",
                            0, 0, 0 );
-#endif
 
                        send_ldap_discon( op, rs,
                                LDAP_PROTOCOL_ERROR, "newSuperior requires LDAPv3" );
@@ -117,13 +103,8 @@ do_modrdn(
                if ( ber_scanf( op->o_ber, "m", &newSuperior ) 
                     == LBER_ERROR ) {
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG( OPERATION, ERR,
-                               "do_modrdn: ber_scanf(\"m\") failed\n", 0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY, "ber_scanf(\"m\") failed\n",
                                0, 0, 0 );
-#endif
 
                        send_ldap_discon( op, rs,
                                LDAP_PROTOCOL_ERROR, "decoding error" );
@@ -134,24 +115,13 @@ do_modrdn(
                op->orr_nnewSup = &nnewSuperior;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, 
-               "do_modrdn: dn (%s) newrdn (%s) newsuperior(%s)\n",
-               dn.bv_val, newrdn.bv_val,
-               newSuperior.bv_len ? newSuperior.bv_val : "" );
-#else
        Debug( LDAP_DEBUG_ARGS,
            "do_modrdn: dn (%s) newrdn (%s) newsuperior (%s)\n",
                dn.bv_val, newrdn.bv_val,
                newSuperior.bv_len ? newSuperior.bv_val : "" );
-#endif
 
        if ( ber_scanf( op->o_ber, /*{*/ "}") == LBER_ERROR ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, ERR, "do_modrdn: ber_scanf failed\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "do_modrdn: ber_scanf failed\n", 0, 0, 0 );
-#endif
 
                send_ldap_discon( op, rs,
                        LDAP_PROTOCOL_ERROR, "decoding error" );
@@ -160,11 +130,7 @@ do_modrdn(
        }
 
        if( get_ctrls( op, rs, 1 ) != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, ERR, "do_modrdn: get_ctrls failed\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "do_modrdn: get_ctrls failed\n", 0, 0, 0 );
-#endif
 
                /* get_ctrls has sent results.  Now clean up. */
                goto cleanup;
@@ -172,14 +138,8 @@ do_modrdn(
 
        rs->sr_err = dnPrettyNormal( NULL, &dn, &op->o_req_dn, &op->o_req_ndn, op->o_tmpmemctx );
        if( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, INFO, 
-                       "do_modrdn: conn %d  invalid dn (%s)\n",
-                       op->o_connid, dn.bv_val, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                        "do_modrdn: invalid dn (%s)\n", dn.bv_val, 0, 0 );
-#endif
                send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid DN" );
                goto cleanup;
        }
@@ -188,26 +148,15 @@ do_modrdn(
 
        rs->sr_err = dnPrettyNormal( NULL, &newrdn, &op->orr_newrdn, &op->orr_nnewrdn, op->o_tmpmemctx );
        if( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, INFO, 
-                       "do_modrdn: conn %d  invalid newrdn (%s)\n",
-                       op->o_connid, newrdn.bv_val, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                        "do_modrdn: invalid newrdn (%s)\n", newrdn.bv_val, 0, 0 );
-#endif
                send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid new RDN" );
                goto cleanup;
        }
 
        if( rdn_validate( &op->orr_newrdn ) != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, ERR, 
-                       "do_modrdn: invalid rdn (%s).\n", op->orr_newrdn.bv_val, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "do_modrdn: invalid rdn (%s)\n",
                        op->orr_newrdn.bv_val, 0, 0 );
-#endif
 
                send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid new RDN" );
                goto cleanup;
@@ -217,15 +166,9 @@ do_modrdn(
                rs->sr_err = dnPrettyNormal( NULL, &newSuperior, &pnewSuperior,
                        &nnewSuperior, op->o_tmpmemctx );
                if( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( OPERATION, INFO, 
-                               "do_modrdn: conn %d  invalid newSuperior (%s)\n",
-                               op->o_connid, newSuperior.bv_val, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY,
                                "do_modrdn: invalid newSuperior (%s)\n",
                                newSuperior.bv_val, 0, 0 );
-#endif
                        send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid newSuperior" );
                        goto cleanup;
                }
@@ -261,34 +204,23 @@ fe_op_modrdn( Operation *op, SlapReply *rs )
        struct berval   pdn = BER_BVNULL;
        
        if( op->o_req_ndn.bv_len == 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, ERR,
-                       "do_modrdn:  attempt to modify root DSE.\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "do_modrdn: root dse!\n", 0, 0, 0 );
-#endif
 
                send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
                        "cannot rename the root DSE" );
                goto cleanup;
 
        } else if ( bvmatch( &op->o_req_ndn, &frontendDB->be_schemandn ) ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, ERR,
-                       "do_modrdn: attempt to modify subschema subentry: %s (%ld)\n",
-                       frontendDB->be_schemandn.bv_val, (long)frontendDB->be_schemandn.bv_len, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "do_modrdn: subschema subentry: %s (%ld)\n",
                        frontendDB->be_schemandn.bv_val, (long)frontendDB->be_schemandn.bv_len, 0 );
-#endif
 
                send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
                        "cannot rename subschema subentry" );
                goto cleanup;
        }
 
-       Statslog( LDAP_DEBUG_STATS, "conn=%lu op=%lu MODRDN dn=\"%s\"\n",
-           op->o_connid, op->o_opid, op->o_req_dn.bv_val, 0, 0 );
+       Statslog( LDAP_DEBUG_STATS, "%s MODRDN dn=\"%s\"\n",
+           op->o_log_prefix, op->o_req_dn.bv_val, 0, 0, 0 );
 
        manageDSAit = get_manageDSAit( op );
 
@@ -297,7 +229,7 @@ fe_op_modrdn( Operation *op, SlapReply *rs )
         * appropriate one, or send a referral to our "referral server"
         * if we don't hold it.
         */
-       op->o_bd = select_backend( &op->o_req_ndn, manageDSAit, 0 );
+       op->o_bd = select_backend( &op->o_req_ndn, manageDSAit, 1 );
        if ( op->o_bd == NULL ) {
                rs->sr_ref = referral_rewrite( default_referral,
                        NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
@@ -358,13 +290,8 @@ fe_op_modrdn( Operation *op, SlapReply *rs )
                         * A preoperation plugin failure will abort the
                         * entire operation.
                         */
-#ifdef NEW_LOGGING
-                       LDAP_LOG( OPERATION, INFO, "do_modrdn: modrdn preoperation plugin "
-                                       "failed\n", 0, 0, 0 );
-#else
                        Debug(LDAP_DEBUG_TRACE, "do_modrdn: modrdn preoperation plugin "
                                        "failed.\n", 0, 0, 0);
-#endif
                        if ( ( slapi_pblock_get( pb, SLAPI_RESULT_CODE, (void *)&rs->sr_err ) != 0 ) ||
                                 rs->sr_err == LDAP_SUCCESS ) {
                                rs->sr_err = LDAP_OTHER;
@@ -411,7 +338,7 @@ fe_op_modrdn( Operation *op, SlapReply *rs )
                                org_managedsait = get_manageDSAit( op );
                                op->o_dn = op->o_bd->be_rootdn;
                                op->o_ndn = op->o_bd->be_rootndn;
-                               op->o_managedsait = 1;
+                               op->o_managedsait = SLAP_CONTROL_NONCRITICAL;
 
                                while ( rs->sr_err == LDAP_SUCCESS &&
                                                op->o_delete_glue_parent ) {
@@ -463,13 +390,8 @@ fe_op_modrdn( Operation *op, SlapReply *rs )
 
 #if defined( LDAP_SLAPI )
        if ( pb != NULL && slapi_int_call_plugins( op->o_bd, SLAPI_PLUGIN_POST_MODRDN_FN, pb ) < 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, INFO, "do_modrdn: modrdn postoperation plugins "
-                               "failed\n", 0, 0, 0 );
-#else
                Debug(LDAP_DEBUG_TRACE, "do_modrdn: modrdn postoperation plugins "
                                "failed.\n", 0, 0, 0);
-#endif
        }
 #endif /* defined( LDAP_SLAPI ) */
 
@@ -504,34 +426,21 @@ slap_modrdn2mods(
                rs->sr_err = slap_bv2ad( &new_rdn[a_cnt]->la_attr, &desc, &rs->sr_text );
 
                if ( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                               "slap_modrdn2modlist: %s: %s (new)\n", 
-                               rs->sr_text, 
-                               new_rdn[ a_cnt ]->la_attr.bv_val, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                                "slap_modrdn2modlist: %s: %s (new)\n",
                                rs->sr_text, 
                                new_rdn[ a_cnt ]->la_attr.bv_val, 0 );
-#endif
                        goto done;              
                }
 
                /* ACL check of newly added attrs */
                if ( op->o_bd && !access_allowed( op, e, desc,
                        &new_rdn[a_cnt]->la_value, ACL_WRITE, NULL ) ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                               "slap_modrdn2modlist: access to attr \"%s\" "
-                               "(new) not allowed\n", 
-                               new_rdn[a_cnt]->la_attr.bv_val, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                                "slap_modrdn2modlist: access to attr \"%s\" "
                                "(new) not allowed\n", 
                                new_rdn[ a_cnt ]->la_attr.bv_val, 0, 0 );
-#endif
+                       rs->sr_text = "access to naming attributes (new) not allowed";
                        rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
                        goto done;
                }
@@ -568,19 +477,11 @@ slap_modrdn2mods(
 
                        rs->sr_err = slap_bv2ad( &old_rdn[d_cnt]->la_attr, &desc, &rs->sr_text );
                        if ( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "slap_modrdn2modlist: %s: %s (old)\n", 
-                                       rs->sr_text, 
-                                       old_rdn[d_cnt]->la_attr.bv_val, 
-                                       0 );
-#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "slap_modrdn2modlist: %s: %s (old)\n",
                                        rs->sr_text, 
                                        old_rdn[d_cnt]->la_attr.bv_val, 
                                        0 );
-#endif
                                goto done;              
                        }
 
@@ -588,19 +489,12 @@ slap_modrdn2mods(
                        if ( op->o_bd && !access_allowed( op, e, desc,
                                &old_rdn[d_cnt]->la_value, ACL_WRITE, 
                                NULL ) ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "slap_modrdn2modlist: access "
-                                       "to attr \"%s\" (old) not allowed\n", 
-                                       old_rdn[ d_cnt ]->la_attr.bv_val, 
-                                       0, 0 );
-#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "slap_modrdn2modlist: access "
                                        "to attr \"%s\" (old) not allowed\n", 
                                        old_rdn[ d_cnt ]->la_attr.bv_val,
                                        0, 0 );
-#endif
+                               rs->sr_text = "access to naming attributes (old) not allowed";
                                rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
                                goto done;
                        }
@@ -632,7 +526,7 @@ slap_modrdn2mods(
        
 done:
 
-       if ( !repl_user ) {
+       if ( rs->sr_err == LDAP_SUCCESS && !repl_user ) {
                char textbuf[ SLAP_TEXT_BUFLEN ];
                size_t textlen = sizeof textbuf;
 
@@ -643,7 +537,8 @@ done:
                        /* empty */
                }
 
-               rs->sr_err = slap_mods_opattrs( op, mod, modtail, &rs->sr_text, textbuf, textlen );
+               rs->sr_err = slap_mods_opattrs( op, mod, modtail,
+                                               &rs->sr_text, textbuf, textlen, 1 );
        }
 
        /* LDAP v2 supporting correct attribute handling. */