]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/oc.c
ITS#7588 fix double-free for sorted paged search
[openldap] / servers / slapd / oc.c
index 651041f93486f8ca10dad35905cf2bb151373e85..b3d2d8a37c50483fe11fc1c307dc5849cb16f223 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2004 The OpenLDAP Foundation.
+ * Copyright 1998-2013 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -37,16 +37,16 @@ int is_object_subclass(
                sup->soc_oid, sub->soc_oid, sup == sub );
 #endif
 
-       if( sup == sub ) {
+       if ( sup == sub ) {
                return 1;
        }
 
-       if( sub->soc_sups == NULL ) {
+       if ( sub->soc_sups == NULL ) {
                return 0;
        }
 
-       for( i=0; sub->soc_sups[i] != NULL; i++ ) {
-               if( is_object_subclass( sup, sub->soc_sups[i] ) ) {
+       for ( i = 0; sub->soc_sups[i] != NULL; i++ ) {
+               if ( is_object_subclass( sup, sub->soc_sups[i] ) ) {
                        return 1;
                }
        }
@@ -57,7 +57,7 @@ int is_object_subclass(
 int is_entry_objectclass(
        Entry*  e,
        ObjectClass *oc,
-       int set_flags )
+       unsigned flags )
 {
        /*
         * set_flags should only be true if oc is one of operational
@@ -67,15 +67,16 @@ int is_entry_objectclass(
 
        Attribute *attr;
        struct berval *bv;
-       AttributeDescription *objectClass = slap_schema.si_ad_objectClass;
 
-       assert(!( e == NULL || oc == NULL ));
+       assert( !( e == NULL || oc == NULL ) );
+       assert( ( flags & SLAP_OCF_MASK ) != SLAP_OCF_MASK );
 
-       if( e == NULL || oc == NULL ) {
+       if ( e == NULL || oc == NULL ) {
                return 0;
        }
 
-       if( set_flags && ( e->e_ocflags & SLAP_OC__END )) {
+       if ( flags == SLAP_OCF_SET_FLAGS && ( e->e_ocflags & SLAP_OC__END ) )
+       {
                /* flags are set, use them */
                return (e->e_ocflags & oc->soc_flags & SLAP_OC__MASK) != 0;
        }
@@ -83,33 +84,47 @@ int is_entry_objectclass(
        /*
         * find objectClass attribute
         */
-       attr = attr_find(e->e_attrs, objectClass);
-       if( attr == NULL ) {
+       attr = attr_find( e->e_attrs, slap_schema.si_ad_objectClass );
+       if ( attr == NULL ) {
                /* no objectClass attribute */
                Debug( LDAP_DEBUG_ANY, "is_entry_objectclass(\"%s\", \"%s\") "
                        "no objectClass attribute\n",
                        e->e_dn == NULL ? "" : e->e_dn,
                        oc->soc_oclass.oc_oid, 0 );
 
+               /* mark flags as set */
+               e->e_ocflags |= SLAP_OC__END;
+
                return 0;
        }
 
-       for( bv=attr->a_vals; bv->bv_val; bv++ ) {
+       for ( bv = attr->a_vals; bv->bv_val; bv++ ) {
                ObjectClass *objectClass = oc_bvfind( bv );
 
-               if ( !set_flags && objectClass == oc ) {
-                       return 1;
+               if ( objectClass == NULL ) {
+                       /* FIXME: is this acceptable? */
+                       continue;
                }
-               
-               if ( objectClass != NULL ) {
-                       e->e_ocflags |= objectClass->soc_flags;
+
+               if ( !( flags & SLAP_OCF_SET_FLAGS ) ) {
+                       if ( objectClass == oc ) {
+                               return 1;
+                       }
+
+                       if ( ( flags & SLAP_OCF_CHECK_SUP )
+                               && is_object_subclass( oc, objectClass ) )
+                       {
+                               return 1;
+                       }
                }
+               
+               e->e_ocflags |= objectClass->soc_flags;
        }
 
        /* mark flags as set */
        e->e_ocflags |= SLAP_OC__END;
 
-       return (e->e_ocflags & oc->soc_flags & SLAP_OC__MASK) != 0;
+       return ( e->e_ocflags & oc->soc_flags & SLAP_OC__MASK ) != 0;
 }
 
 
@@ -119,8 +134,11 @@ struct oindexrec {
 };
 
 static Avlnode *oc_index = NULL;
-static LDAP_SLIST_HEAD(OCList, slap_object_class) oc_list
-       = LDAP_SLIST_HEAD_INITIALIZER(&oc_list);
+static Avlnode *oc_cache = NULL;
+static LDAP_STAILQ_HEAD(OCList, ObjectClass) oc_list
+       = LDAP_STAILQ_HEAD_INITIALIZER(oc_list);
+
+ObjectClass *oc_sys_tail;
 
 static int
 oc_index_cmp(
@@ -161,17 +179,25 @@ oc_bvfind( struct berval *ocname )
 {
        struct oindexrec        *oir;
 
+       if ( oc_cache ) {
+               oir = avl_find( oc_cache, ocname, oc_index_name_cmp );
+               if ( oir ) return oir->oir_oc;
+       }
        oir = avl_find( oc_index, ocname, oc_index_name_cmp );
 
        if ( oir != NULL ) {
+               if ( at_oc_cache ) {
+                       avl_insert( &oc_cache, (caddr_t) oir,
+                               oc_index_cmp, avl_dup_error );
+               }
                return( oir->oir_oc );
        }
 
        return( NULL );
 }
 
-static LDAP_SLIST_HEAD(OCUList, slap_object_class) oc_undef_list
-       = LDAP_SLIST_HEAD_INITIALIZER(&oc_undef_list);
+static LDAP_STAILQ_HEAD(OCUList, ObjectClass) oc_undef_list
+       = LDAP_STAILQ_HEAD_INITIALIZER(oc_undef_list);
 
 ObjectClass *
 oc_bvfind_undef( struct berval *ocname )
@@ -182,7 +208,7 @@ oc_bvfind_undef( struct berval *ocname )
                return oc;
        }
 
-       LDAP_SLIST_FOREACH( oc, &oc_undef_list, soc_next ) {
+       LDAP_STAILQ_FOREACH( oc, &oc_undef_list, soc_next ) {
                int     d = oc->soc_cname.bv_len - ocname->bv_len;
 
                if ( d ) {
@@ -204,19 +230,25 @@ oc_bvfind_undef( struct berval *ocname )
        oc->soc_cname.bv_len = ocname->bv_len;
        oc->soc_cname.bv_val = (char *)&oc[ 1 ];
        AC_MEMCPY( oc->soc_cname.bv_val, ocname->bv_val, ocname->bv_len );
+       oc->soc_cname.bv_val[ oc->soc_cname.bv_len ] = '\0';
+
+       /* canonical to upper case */
+       ldap_pvt_str2upper( oc->soc_cname.bv_val );
 
-       LDAP_SLIST_NEXT( oc, soc_next ) = NULL;
-       LDAP_SLIST_INSERT_HEAD( &oc_undef_list, oc, soc_next );
+       LDAP_STAILQ_NEXT( oc, soc_next ) = NULL;
+       ldap_pvt_thread_mutex_lock( &oc_undef_mutex );
+       LDAP_STAILQ_INSERT_HEAD( &oc_undef_list, oc, soc_next );
+       ldap_pvt_thread_mutex_unlock( &oc_undef_mutex );
 
        return oc;
 }
 
 static int
 oc_create_required(
-    ObjectClass                *soc,
-    char               **attrs,
+       ObjectClass             *soc,
+       char                    **attrs,
        int                     *op,
-    const char         **err )
+       const char              **err )
 {
        char            **attrs1;
        AttributeType   *sat;
@@ -244,7 +276,7 @@ oc_create_required(
                }
                /* Now delete duplicates from the allowed list */
                for ( satp = soc->soc_required; *satp; satp++ ) {
-                       i = at_find_in_list(*satp,soc->soc_allowed);
+                       i = at_find_in_list(*satp, soc->soc_allowed);
                        if ( i >= 0 ) {
                                at_delete_from_list(i, &soc->soc_allowed);
                        }
@@ -289,10 +321,10 @@ oc_create_allowed(
 
 static int
 oc_add_sups(
-    ObjectClass                *soc,
-    char                       **sups,
+       ObjectClass             *soc,
+       char                    **sups,
        int                     *op,
-    const char         **err )
+       const char              **err )
 {
        int             code;
        ObjectClass     *soc1;
@@ -363,63 +395,252 @@ oc_add_sups(
        return 0;
 }
 
+static void
+oc_delete_names( ObjectClass *oc )
+{
+       char                    **names = oc->soc_names;
+
+       if (!names) return;
+
+       while (*names) {
+               struct oindexrec        tmpoir, *oir;
+
+               ber_str2bv( *names, 0, 0, &tmpoir.oir_name );
+               tmpoir.oir_oc = oc;
+               oir = (struct oindexrec *)avl_delete( &oc_index,
+                       (caddr_t)&tmpoir, oc_index_cmp );
+               assert( oir != NULL );
+               ldap_memfree( oir );
+               names++;
+       }
+}
+
+/* Mark the ObjectClass as deleted, remove from list, and remove all its
+ * names from the AVL tree. Leave the OID in the tree.
+ */
+void
+oc_delete( ObjectClass *oc )
+{
+       oc->soc_flags |= SLAP_OC_DELETED;
+
+       LDAP_STAILQ_REMOVE(&oc_list, oc, ObjectClass, soc_next);
+
+       oc_delete_names( oc );
+}
+
+static void
+oc_clean( ObjectClass *o )
+{
+       if (o->soc_sups) {
+               ldap_memfree(o->soc_sups);
+               o->soc_sups = NULL;
+       }
+       if (o->soc_required) {
+               ldap_memfree(o->soc_required);
+               o->soc_required = NULL;
+       }
+       if (o->soc_allowed) {
+               ldap_memfree(o->soc_allowed);
+               o->soc_allowed = NULL;
+       }
+       if (o->soc_oidmacro) {
+               ldap_memfree(o->soc_oidmacro);
+               o->soc_oidmacro = NULL;
+       }
+}
+
+static void
+oc_destroy_one( void *v )
+{
+       struct oindexrec *oir = v;
+       ObjectClass *o = oir->oir_oc;
+
+       oc_clean( o );
+       ldap_objectclass_free((LDAPObjectClass *)o);
+       ldap_memfree(oir);
+}
+
 void
 oc_destroy( void )
 {
        ObjectClass *o;
 
-       avl_free(oc_index, ldap_memfree);
-       while( !LDAP_SLIST_EMPTY(&oc_list) ) {
-               o = LDAP_SLIST_FIRST(&oc_list);
-               LDAP_SLIST_REMOVE_HEAD(&oc_list, soc_next);
+       while( !LDAP_STAILQ_EMPTY(&oc_list) ) {
+               o = LDAP_STAILQ_FIRST(&oc_list);
+               LDAP_STAILQ_REMOVE_HEAD(&oc_list, soc_next);
 
-               if (o->soc_sups) ldap_memfree(o->soc_sups);
-               if (o->soc_required) ldap_memfree(o->soc_required);
-               if (o->soc_allowed) ldap_memfree(o->soc_allowed);
-               ldap_objectclass_free((LDAPObjectClass *)o);
+               oc_delete_names( o );
        }
        
-       while( !LDAP_SLIST_EMPTY(&oc_undef_list) ) {
-               o = LDAP_SLIST_FIRST(&oc_undef_list);
-               LDAP_SLIST_REMOVE_HEAD(&oc_undef_list, soc_next);
+       avl_free( oc_index, oc_destroy_one );
+
+       while( !LDAP_STAILQ_EMPTY(&oc_undef_list) ) {
+               o = LDAP_STAILQ_FIRST(&oc_undef_list);
+               LDAP_STAILQ_REMOVE_HEAD(&oc_undef_list, soc_next);
 
                ch_free( (ObjectClass *)o );
        }
 }
 
+int
+oc_start( ObjectClass **oc )
+{
+       assert( oc != NULL );
+
+       *oc = LDAP_STAILQ_FIRST(&oc_list);
+
+       return (*oc != NULL);
+}
+
+int
+oc_next( ObjectClass **oc )
+{
+       assert( oc != NULL );
+
+#if 0  /* pedantic check: breaks when deleting an oc, don't use it. */
+       {
+               ObjectClass *tmp = NULL;
+
+               LDAP_STAILQ_FOREACH(tmp,&oc_list,soc_next) {
+                       if ( tmp == *oc ) {
+                               break;
+                       }
+               }
+
+               assert( tmp != NULL );
+       }
+#endif
+
+       if ( *oc == NULL ) {
+               return 0;
+       }
+
+       *oc = LDAP_STAILQ_NEXT(*oc,soc_next);
+
+       return (*oc != NULL);
+}
+
+/*
+ * check whether the two ObjectClasses actually __are__ identical,
+ * or rather inconsistent
+ */
+static int
+oc_check_dup(
+       ObjectClass     *soc,
+       ObjectClass     *new_soc )
+{
+       if ( new_soc->soc_oid != NULL ) {
+               if ( soc->soc_oid == NULL ) {
+                       return SLAP_SCHERR_CLASS_INCONSISTENT;
+               }
+
+               if ( strcmp( soc->soc_oid, new_soc->soc_oid ) != 0 ) {
+                       return SLAP_SCHERR_CLASS_INCONSISTENT;
+               }
+
+       } else {
+               if ( soc->soc_oid != NULL ) {
+                       return SLAP_SCHERR_CLASS_INCONSISTENT;
+               }
+       }
+
+       if ( new_soc->soc_names ) {
+               int     i;
+
+               if ( soc->soc_names == NULL ) {
+                       return SLAP_SCHERR_CLASS_INCONSISTENT;
+               }
+
+               for ( i = 0; new_soc->soc_names[ i ]; i++ ) {
+                       if ( soc->soc_names[ i ] == NULL ) {
+                               return SLAP_SCHERR_CLASS_INCONSISTENT;
+                       }
+                       
+                       if ( strcasecmp( soc->soc_names[ i ],
+                                       new_soc->soc_names[ i ] ) != 0 )
+                       {
+                               return SLAP_SCHERR_CLASS_INCONSISTENT;
+                       }
+               }
+       } else {
+               if ( soc->soc_names != NULL ) {
+                       return SLAP_SCHERR_CLASS_INCONSISTENT;
+               }
+       }
+
+       return SLAP_SCHERR_CLASS_DUP;
+}
+
+static struct oindexrec *oir_old;
+
+static int
+oc_dup_error( void *left, void *right )
+{
+       oir_old = left;
+       return -1;
+}
+
 static int
 oc_insert(
-    ObjectClass                *soc,
+    ObjectClass                **roc,
+       ObjectClass             *prev,
     const char         **err )
 {
        struct oindexrec        *oir;
        char                    **names;
-
-       LDAP_SLIST_NEXT( soc, soc_next ) = NULL;
-       LDAP_SLIST_INSERT_HEAD( &oc_list, soc, soc_next );
+       ObjectClass             *soc = *roc;
 
        if ( soc->soc_oid ) {
                oir = (struct oindexrec *)
                        ch_calloc( 1, sizeof(struct oindexrec) );
-               oir->oir_name.bv_val = soc->soc_oid;
-               oir->oir_name.bv_len = strlen( soc->soc_oid );
+               ber_str2bv( soc->soc_oid, 0, 0, &oir->oir_name );
                oir->oir_oc = soc;
-
-               assert( oir->oir_name.bv_val );
-               assert( oir->oir_oc );
+               oir_old = NULL;
 
                if ( avl_insert( &oc_index, (caddr_t) oir,
-                       oc_index_cmp, avl_dup_error ) )
+                       oc_index_cmp, oc_dup_error ) )
                {
+                       ObjectClass     *old_soc;
+                       int             rc;
+
                        *err = soc->soc_oid;
-                       ldap_memfree(oir);
-                       return SLAP_SCHERR_CLASS_DUP;
+
+                       assert( oir_old != NULL );
+                       old_soc = oir_old->oir_oc;
+
+                       /* replacing a deleted definition? */
+                       if ( old_soc->soc_flags & SLAP_OC_DELETED ) {
+                               ObjectClass tmp;
+
+                               /* Keep old oid, free new oid;
+                                * Keep new everything else, free old
+                                */
+                               tmp = *old_soc;
+                               *old_soc = *soc;
+                               old_soc->soc_oid = tmp.soc_oid;
+                               tmp.soc_oid = soc->soc_oid;
+                               *soc = tmp;
+
+                               oc_clean( soc );
+                               oc_destroy_one( oir );
+
+                               oir = oir_old;
+                               soc = old_soc;
+                               *roc = soc;
+                       } else {
+                               rc = oc_check_dup( old_soc, soc );
+
+                               ldap_memfree( oir );
+                               return rc;
+                       }
                }
 
                /* FIX: temporal consistency check */
-               assert( oc_bvfind(&oir->oir_name) != NULL );
+               assert( oc_bvfind( &oir->oir_name ) != NULL );
        }
 
+       assert( soc != NULL );
+
        if ( (names = soc->soc_names) ) {
                while ( *names ) {
                        oir = (struct oindexrec *)
@@ -428,15 +649,44 @@ oc_insert(
                        oir->oir_name.bv_len = strlen( *names );
                        oir->oir_oc = soc;
 
-                       assert( oir->oir_name.bv_val );
-                       assert( oir->oir_oc );
-
                        if ( avl_insert( &oc_index, (caddr_t) oir,
                                oc_index_cmp, avl_dup_error ) )
                        {
+                               ObjectClass     *old_soc;
+                               int             rc;
+
                                *err = *names;
-                               ldap_memfree(oir);
-                               return SLAP_SCHERR_CLASS_DUP;
+
+                               old_soc = oc_bvfind( &oir->oir_name );
+                               assert( old_soc != NULL );
+                               rc = oc_check_dup( old_soc, soc );
+
+                               ldap_memfree( oir );
+
+                               while ( names > soc->soc_names ) {
+                                       struct oindexrec        tmpoir;
+
+                                       names--;
+                                       ber_str2bv( *names, 0, 0, &tmpoir.oir_name );
+                                       tmpoir.oir_oc = soc;
+                                       oir = (struct oindexrec *)avl_delete( &oc_index,
+                                               (caddr_t)&tmpoir, oc_index_cmp );
+                                       assert( oir != NULL );
+                                       ldap_memfree( oir );
+                               }
+
+                               if ( soc->soc_oid ) {
+                                       struct oindexrec        tmpoir;
+
+                                       ber_str2bv( soc->soc_oid, 0, 0, &tmpoir.oir_name );
+                                       tmpoir.oir_oc = soc;
+                                       oir = (struct oindexrec *)avl_delete( &oc_index,
+                                               (caddr_t)&tmpoir, oc_index_cmp );
+                                       assert( oir != NULL );
+                                       ldap_memfree( oir );
+                               }
+
+                               return rc;
                        }
 
                        /* FIX: temporal consistency check */
@@ -445,6 +695,15 @@ oc_insert(
                        names++;
                }
        }
+       if ( soc->soc_flags & SLAP_OC_HARDCODE ) {
+               prev = oc_sys_tail;
+               oc_sys_tail = soc;
+       }
+       if ( prev ) {
+               LDAP_STAILQ_INSERT_AFTER( &oc_list, prev, soc, soc_next );
+       } else {
+               LDAP_STAILQ_INSERT_TAIL( &oc_list, soc, soc_next );
+       }
 
        return 0;
 }
@@ -453,11 +712,14 @@ int
 oc_add(
     LDAPObjectClass    *oc,
        int user,
+       ObjectClass             **rsoc,
+       ObjectClass             *prev,
     const char         **err )
 {
        ObjectClass     *soc;
        int             code;
        int             op = 0;
+       char    *oidm = NULL;
 
        if ( oc->oc_names != NULL ) {
                int i;
@@ -477,7 +739,7 @@ oc_add(
                        return SLAP_SCHERR_OIDM;
                }
                if ( oid != oc->oc_oid ) {
-                       ldap_memfree( oc->oc_oid );
+                       oidm = oc->oc_oid;
                        oc->oc_oid = oid;
                }
        }
@@ -485,6 +747,7 @@ oc_add(
        soc = (ObjectClass *) ch_calloc( 1, sizeof(ObjectClass) );
        AC_MEMCPY( &soc->soc_oclass, oc, sizeof(LDAPObjectClass) );
 
+       soc->soc_oidmacro = oidm;
        if( oc->oc_names != NULL ) {
                soc->soc_cname.bv_val = soc->soc_names[0];
        } else {
@@ -502,21 +765,118 @@ oc_add(
                code = oc_add_sups( soc, soc->soc_sup_oids, &op, err );
        }
 
-       if ( code != 0 ) return code;
-       if( user && op ) return SLAP_SCHERR_CLASS_BAD_SUP;
+       if ( code != 0 ) {
+               goto done;
+       }
+
+       if ( user && op ) {
+               code = SLAP_SCHERR_CLASS_BAD_SUP;
+               goto done;
+       }
 
        code = oc_create_required( soc, soc->soc_at_oids_must, &op, err );
-       if ( code != 0 ) return code;
+       if ( code != 0 ) {
+               goto done;
+       }
 
        code = oc_create_allowed( soc, soc->soc_at_oids_may, &op, err );
-       if ( code != 0 ) return code;
+       if ( code != 0 ) {
+               goto done;
+       }
+
+       if ( user && op ) {
+               code = SLAP_SCHERR_CLASS_BAD_USAGE;
+               goto done;
+       }
+
+       if ( !user ) {
+               soc->soc_flags |= SLAP_OC_HARDCODE;
+       }
+
+       code = oc_insert(&soc,prev,err);
+done:;
+       if ( code != 0 ) {
+               if ( soc->soc_sups ) {
+                       ch_free( soc->soc_sups );
+               }
+
+               if ( soc->soc_required ) {
+                       ch_free( soc->soc_required );
+               }
 
-       if( user && op ) return SLAP_SCHERR_CLASS_BAD_USAGE;
+               if ( soc->soc_allowed ) {
+                       ch_free( soc->soc_allowed );
+               }
+
+               if ( soc->soc_oidmacro ) {
+                       ch_free( soc->soc_oidmacro );
+               }
 
-       code = oc_insert(soc,err);
+               ch_free( soc );
+
+       } else if ( rsoc ) {
+               *rsoc = soc;
+       }
        return code;
 }
 
+void
+oc_unparse( BerVarray *res, ObjectClass *start, ObjectClass *end, int sys )
+{
+       ObjectClass *oc;
+       int i, num;
+       struct berval bv, *bva = NULL, idx;
+       char ibuf[32];
+
+       if ( !start )
+               start = LDAP_STAILQ_FIRST( &oc_list );
+
+       /* count the result size */
+       i = 0;
+       for ( oc=start; oc; oc=LDAP_STAILQ_NEXT(oc, soc_next)) {
+               if ( sys && !(oc->soc_flags & SLAP_OC_HARDCODE)) break;
+               i++;
+               if ( oc == end ) break;
+       }
+       if (!i) return;
+
+       num = i;
+       bva = ch_malloc( (num+1) * sizeof(struct berval) );
+       BER_BVZERO( bva );
+       idx.bv_val = ibuf;
+       if ( sys ) {
+               idx.bv_len = 0;
+               ibuf[0] = '\0';
+       }
+       i = 0;
+       for ( oc=start; oc; oc=LDAP_STAILQ_NEXT(oc, soc_next)) {
+               LDAPObjectClass loc, *locp;
+               if ( sys && !(oc->soc_flags & SLAP_OC_HARDCODE)) break;
+               if ( oc->soc_oidmacro ) {
+                       loc = oc->soc_oclass;
+                       loc.oc_oid = oc->soc_oidmacro;
+                       locp = &loc;
+               } else {
+                       locp = &oc->soc_oclass;
+               }
+               if ( ldap_objectclass2bv( locp, &bv ) == NULL ) {
+                       ber_bvarray_free( bva );
+               }
+               if ( !sys ) {
+                       idx.bv_len = sprintf(idx.bv_val, "{%d}", i);
+               }
+               bva[i].bv_len = idx.bv_len + bv.bv_len;
+               bva[i].bv_val = ch_malloc( bva[i].bv_len + 1 );
+               strcpy( bva[i].bv_val, ibuf );
+               strcpy( bva[i].bv_val + idx.bv_len, bv.bv_val );
+               i++;
+               bva[i].bv_val = NULL;
+               ldap_memfree( bv.bv_val );
+               if ( oc == end ) break;
+       }
+       *res = bva;
+}
+
 int
 oc_schema_info( Entry *e )
 {
@@ -525,7 +885,7 @@ oc_schema_info( Entry *e )
        struct berval   val;
        struct berval   nval;
 
-       LDAP_SLIST_FOREACH( oc, &oc_list, soc_next ) {
+       LDAP_STAILQ_FOREACH( oc, &oc_list, soc_next ) {
                if( oc->soc_flags & SLAP_OC_HIDE ) continue;
 
                if ( ldap_objectclass2bv( &oc->soc_oclass, &val ) == NULL ) {
@@ -546,3 +906,35 @@ oc_schema_info( Entry *e )
        }
        return 0;
 }
+
+int
+register_oc( const char *def, ObjectClass **soc, int dupok )
+{
+       LDAPObjectClass *oc;
+       int code;
+       const char *err;
+
+       oc = ldap_str2objectclass( def, &code, &err, LDAP_SCHEMA_ALLOW_ALL );
+       if ( !oc ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "register_oc: objectclass \"%s\": %s, %s\n",
+                       def, ldap_scherr2str(code), err );
+               return code;
+       }
+       code = oc_add(oc,0,NULL,NULL,&err);
+       if ( code && ( code != SLAP_SCHERR_CLASS_DUP || !dupok )) {
+               Debug( LDAP_DEBUG_ANY,
+                       "register_oc: objectclass \"%s\": %s, %s\n",
+                       def, scherr2str(code), err );
+               ldap_objectclass_free(oc);
+               return code;
+       }
+       if ( soc )
+               *soc = oc_find(oc->oc_names[0]);
+       if ( code ) {
+               ldap_objectclass_free(oc);
+       } else {
+               ldap_memfree(oc);
+       }
+       return 0;
+}