Fix -USLAPD_RLOOKUPS

[openldap] / servers / slapd / operation.c

diff --git a/servers/slapd/operation.c b/servers/slapd/operation.c
index bf9590de98cdc8cc558600900cf53595fa17bf33..4ca92d801b7ac8a5b48242b4fcf97f1c23d167cb 100644 (file)
--- a/servers/slapd/operation.c
+++ b/servers/slapd/operation.c
@@ -13,27 +13,63 @@
 void
 slap_op_free( Operation *op )
 {
-       if ( op->o_ber != NULL )
+       assert( op->o_next == NULL );
+
+       if ( op->o_ber != NULL ) {
                ber_free( op->o_ber, 1 );
+       }
        if ( op->o_dn != NULL ) {
                free( op->o_dn );
        }
        if ( op->o_ndn != NULL ) {
                free( op->o_ndn );
        }
-       /* ldap_pvt_thread_mutex_destroy( &op->o_abandonmutex ); */
+       if ( op->o_authmech != NULL ) {
+               free( op->o_authmech );
+       }
+       if ( op->o_ctrls != NULL ) {
+               ldap_controls_free( op->o_ctrls );
+       }
+
+       ldap_pvt_thread_mutex_destroy( &op->o_abandonmutex );
+
        free( (char *) op );
 }
 
 Operation *
-slap_op_add(
-    Operation          **olist,
+slap_op_alloc(
     BerElement         *ber,
-    unsigned long      msgid,
-    unsigned long      tag,
-    char                       *dn,
-    int                                id,
-    int                                connid
+    ber_int_t  msgid,
+    ber_tag_t  tag,
+    ber_int_t  id
+)
+{
+       Operation       *op;
+
+       op = (Operation *) ch_calloc( 1, sizeof(Operation) );
+
+       ldap_pvt_thread_mutex_init( &op->o_abandonmutex );
+       op->o_abandon = 0;
+
+       op->o_ber = ber;
+       op->o_msgid = msgid;
+       op->o_tag = tag;
+
+       op->o_dn = NULL;
+       op->o_ndn = NULL;
+       op->o_authmech = NULL;
+       op->o_ctrls = NULL;
+
+       op->o_time = slap_get_time();
+       op->o_opid = id;
+       op->o_next = NULL;
+
+       return( op );
+}
+
+int slap_op_add(
+    Operation          **olist,
+       Operation               *op
 )
 {
        Operation       **tmp;
@@ -41,28 +77,13 @@ slap_op_add(
        for ( tmp = olist; *tmp != NULL; tmp = &(*tmp)->o_next )
                ;       /* NULL */
 
-       *tmp = (Operation *) calloc( 1, sizeof(Operation) );
-       ldap_pvt_thread_mutex_init( &(*tmp)->o_abandonmutex );
-       (*tmp)->o_ber = ber;
-       (*tmp)->o_msgid = msgid;
-       (*tmp)->o_tag = tag;
-       (*tmp)->o_abandon = 0;
-
-       (*tmp)->o_dn = ch_strdup( dn != NULL ? dn : "" );
-       (*tmp)->o_ndn = dn_normalize_case( ch_strdup( (*tmp)->o_dn ) );
+       *tmp = op;
 
-       ldap_pvt_thread_mutex_lock( &currenttime_mutex );
-       (*tmp)->o_time = currenttime;
-       ldap_pvt_thread_mutex_unlock( &currenttime_mutex );
-       (*tmp)->o_opid = id;
-       (*tmp)->o_connid = connid;
-       (*tmp)->o_next = NULL;
-
-       return( *tmp );
+       return 0;
 }
 
-void
-slap_op_delete( Operation **olist, Operation *op )
+int
+slap_op_remove( Operation **olist, Operation *op )
 {
        Operation       **tmp;
 
@@ -72,9 +93,24 @@ slap_op_delete( Operation **olist, Operation *op )
        if ( *tmp == NULL ) {
                Debug( LDAP_DEBUG_ANY, "op_delete: can't find op %ld\n",
                    op->o_msgid, 0, 0 );
-               return; 
+               return -1; 
        }
 
        *tmp = (*tmp)->o_next;
-       slap_op_free( op );
+       op->o_next = NULL;
+
+       return 0;
 }
+
+Operation * slap_op_pop( Operation **olist )
+{
+       Operation *tmp = *olist;
+
+       if(tmp != NULL) {
+               *olist = tmp->o_next;
+               tmp->o_next = NULL;
+       }
+
+       return tmp;
+}
+