]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/overlays/pcache.c
Fix for CB_TAIL with cached results
[openldap] / servers / slapd / overlays / pcache.c
index 198b9a08c90cfdaf8b339c3d283681e701da3cba..1b75814fba5899415d76003168e60a06f72556c7 100644 (file)
@@ -251,6 +251,7 @@ static int privDB_cid;
 static AttributeDescription    *ad_queryId, *ad_cachedQueryURL;
 
 #ifdef PCACHE_MONITOR
+static AttributeDescription    *ad_numQueries, *ad_numEntries;
 static ObjectClass             *oc_olmPCache;
 #endif /* PCACHE_MONITOR */
 
@@ -285,6 +286,24 @@ static struct {
                "NO-USER-MODIFICATION "
                "USAGE directoryOperation )",
                &ad_cachedQueryURL },
+#ifdef PCACHE_MONITOR
+       { "( PCacheAttributes:3 "
+               "NAME 'pcacheNumQueries' "
+               "DESC 'Number of cached queries' "
+               "EQUALITY integerMatch "
+               "SYNTAX 1.3.6.1.4.1.1466.115.121.1.27 "
+               "NO-USER-MODIFICATION "
+               "USAGE directoryOperation )",
+               &ad_numQueries },
+       { "( PCacheAttributes:4 "
+               "NAME 'pcacheNumEntries' "
+               "DESC 'Number of cached entries' "
+               "EQUALITY integerMatch "
+               "SYNTAX 1.3.6.1.4.1.1466.115.121.1.27 "
+               "NO-USER-MODIFICATION "
+               "USAGE directoryOperation )",
+               &ad_numEntries },
+#endif /* PCACHE_MONITOR */
 
        { NULL }
 };
@@ -299,8 +318,10 @@ static struct {
                "NAME ( 'olmPCache' ) "
                "SUP top AUXILIARY "
                "MAY ( "
-                       "pcacheQueryURL"
-                       ") )",
+                       "pcacheQueryURL "
+                       "$ pcacheNumQueries "
+                       "$ pcacheNumEntries "
+                       " ) )",
                &oc_olmPCache },
 #endif /* PCACHE_MONITOR */
 
@@ -494,7 +515,7 @@ template_attrs( char *template, struct attr_set *set, AttributeName **ret,
 
        *ret = NULL;
 
-       attrs = ch_malloc(( set->count+1 )*sizeof(AttributeName));
+       attrs = ch_calloc( set->count + 1, sizeof(AttributeName) );
        for ( i=0; i < set->count; i++ )
                attrs[i] = set->attrs[i];
        attr_cnt = i;
@@ -747,6 +768,10 @@ url2query(
                }
                query.scope = lud->lud_scope;
                query.filter = str2filter( lud->lud_filter );
+               if ( query.filter == NULL ) {
+                       rc = -1;
+                       goto error;
+               }
 
                tempstr.bv_val = ch_malloc( strlen( lud->lud_filter ) + 1 );
                tempstr.bv_len = 0;
@@ -802,6 +827,7 @@ static int
 merge_entry(
        Operation               *op,
        Entry                   *e,
+       int                     dup,
        struct berval*          query_uuid )
 {
        int             rc;
@@ -815,6 +841,8 @@ merge_entry(
 
        slap_callback cb = { NULL, slap_null_cb, NULL, NULL };
 
+       if ( dup )
+               e = entry_dup( e );
        attr = e->e_attrs;
        e->e_attrs = NULL;
 
@@ -841,6 +869,7 @@ merge_entry(
                        modlist->sml_op = LDAP_MOD_ADD;
                        op->o_tag = LDAP_REQ_MODIFY;
                        op->orm_modlist = modlist;
+                       op->o_managedsait = SLAP_CONTROL_CRITICAL;
                        op->o_bd->be_modify( op, &sreply );
                        slap_mods_free( modlist, 1 );
                } else if ( rc == LDAP_REFERRAL ||
@@ -855,7 +884,7 @@ merge_entry(
                }
        } else {
                if ( op->ora_e == e )
-                       be_entry_release_w( op, e );
+                       entry_free( e );
                rc = 1;
        }
 
@@ -1721,7 +1750,7 @@ remove_query_data(
        struct berval   *query_uuid )
 {
        struct query_info       *qi, *qnext;
-       char                    filter_str[ LDAP_LUTIL_UUIDSTR_BUFSIZE + STRLENOF( "(queryId=)" ) ];
+       char                    filter_str[ LDAP_LUTIL_UUIDSTR_BUFSIZE + STRLENOF( "(pcacheQueryID=)" ) ];
        AttributeAssertion      ava = ATTRIBUTEASSERTION_INIT;
        Filter                  filter = {LDAP_FILTER_EQUALITY};
        SlapReply               sreply = {REP_RESULT};
@@ -2144,7 +2173,7 @@ pcache_remove_entry_queries_from_cache(
        slap_callback           sc = { 0 };
        SlapReply               rs = { REP_RESULT };
        Filter                  f = { 0 };
-       char                    filter_str[ LDAP_LUTIL_UUIDSTR_BUFSIZE + STRLENOF( "(queryId=)" ) ];
+       char                    filter_str[ LDAP_LUTIL_UUIDSTR_BUFSIZE + STRLENOF( "(pcacheQueryID=)" ) ];
        AttributeAssertion      ava = ATTRIBUTEASSERTION_INIT;
        AttributeName           attrs[ 2 ] = {{{ 0 }}};
        int                     rc;
@@ -2263,7 +2292,7 @@ cache_entries(
                        remove_query_and_data( op_tmp, rs, cm, &crp_uuid );
                }
 
-               return_val = merge_entry(op_tmp, e, query_uuid);
+               return_val = merge_entry(op_tmp, e, 0, query_uuid);
                ldap_pvt_thread_mutex_lock(&cm->cache_mutex);
                cm->cur_entries += return_val;
                Debug( pcache_debug,
@@ -2449,7 +2478,14 @@ pcache_response(
                        } else if ( rs->sr_err == LDAP_SIZELIMIT_EXCEEDED
                                && si->qtemp->limitttl )
                        {
+                               Entry *e;
+
                                si->caching_reason = PC_SIZELIMIT;
+                               for (;si->head; si->head=e) {
+                                       e = si->head->e_private;
+                                       si->head->e_private = NULL;
+                                       entry_free(si->head);
+                               }
                        }
 
                } else if ( si->qtemp->negttl && !si->count && !si->over &&
@@ -2503,11 +2539,58 @@ pcache_chk_controls(
        return rs->sr_err;
 }
 
+static int
+pc_setpw( Operation *op, struct berval *pwd, cache_manager *cm )
+{
+       struct berval vals[2];
+
+       {
+               const char *text = NULL;
+               BER_BVZERO( &vals[0] );
+               slap_passwd_hash( pwd, &vals[0], &text );
+               if ( BER_BVISEMPTY( &vals[0] )) {
+                       Debug( pcache_debug, "pc_setpw: hash failed %s\n",
+                               text, 0, 0 );
+                       return LDAP_OTHER;
+               }
+       }
+
+       BER_BVZERO( &vals[1] );
+
+       {
+               Modifications mod;
+               SlapReply sr = { REP_RESULT };
+               slap_callback cb = { 0, slap_null_cb, 0, 0 };
+               int rc;
+
+               mod.sml_op = LDAP_MOD_REPLACE;
+               mod.sml_flags = 0;
+               mod.sml_desc = slap_schema.si_ad_userPassword;
+               mod.sml_type = mod.sml_desc->ad_cname;
+               mod.sml_values = vals;
+               mod.sml_nvalues = NULL;
+               mod.sml_numvals = 1;
+               mod.sml_next = NULL;
+
+               op->o_tag = LDAP_REQ_MODIFY;
+               op->orm_modlist = &mod;
+               op->o_bd = &cm->db;
+               op->o_dn = op->o_bd->be_rootdn;
+               op->o_ndn = op->o_bd->be_rootndn;
+               op->o_callback = &cb;
+               Debug( pcache_debug, "pc_setpw: CACHING BIND for %s\n",
+                       op->o_req_dn.bv_val, 0, 0 );
+               rc = op->o_bd->be_modify( op, &sr );
+               ch_free( vals[0].bv_val );
+               return rc;
+       }
+}
+
 typedef struct bindcacheinfo {
        slap_overinst *on;
        CachedQuery *qc;
 } bindcacheinfo;
-       
+
 static int
 pc_bind_save( Operation *op, SlapReply *rs )
 {
@@ -2515,42 +2598,10 @@ pc_bind_save( Operation *op, SlapReply *rs )
                bindcacheinfo *bci = op->o_callback->sc_private;
                slap_overinst *on = bci->on;
                cache_manager *cm = on->on_bi.bi_private;
-               struct berval vals[2];
-               const char *text = NULL;
-
-               BER_BVZERO( &vals[0] );
-               BER_BVZERO( &vals[1] );
-               slap_passwd_hash( &op->orb_cred, &vals[0], &text );
-               if ( BER_BVISEMPTY( &vals[0] )) {
-                       Debug( pcache_debug, "pcache_bind_save: hash failed %s\n",
-                               text, 0, 0 );
-               } else {
-                       Operation op2 = *op;
-                       Modifications mod;
-                       SlapReply sr = { REP_RESULT };
-                       slap_callback cb = { 0, slap_null_cb, 0, 0 };
-                       
-                       mod.sml_op = LDAP_MOD_REPLACE;
-                       mod.sml_flags = 0;
-                       mod.sml_desc = slap_schema.si_ad_userPassword;
-                       mod.sml_type = mod.sml_desc->ad_cname;
-                       mod.sml_values = vals;
-                       mod.sml_nvalues = NULL;
-                       mod.sml_numvals = 1;
-                       mod.sml_next = NULL;
 
-                       op2.o_tag = LDAP_REQ_MODIFY;
-                       op2.orm_modlist = &mod;
-                       op2.o_bd = &cm->db;
-                       op2.o_dn = op2.o_bd->be_rootdn;
-                       op2.o_ndn = op2.o_bd->be_rootndn;
-                       op2.o_callback = &cb;
-                       Debug( pcache_debug, "pcache_bind_save: caching bind for %s\n",
-                               op->o_req_dn.bv_val, 0, 0 );
-                       if ( op2.o_bd->be_modify( &op2, &sr ) == LDAP_SUCCESS )
-                               bci->qc->bindref_time = op->o_time + bci->qc->qtemp->bindttr;
-                       ch_free( vals[0].bv_val );
-               }
+               Operation op2 = *op;
+               if ( pc_setpw( &op2, &op->orb_cred, cm ) == LDAP_SUCCESS )
+                       bci->qc->bindref_time = op->o_time + bci->qc->qtemp->bindttr;
        }
        return SLAP_CB_CONTINUE;
 }
@@ -2593,7 +2644,14 @@ pc_bind_attrs( Operation *op, Entry *e, QueryTemplate *temp,
        }
        *p2 = '\0';
        op->o_tmpfree( vals, op->o_tmpmemctx );
-       return str2filter_x( op, fbv->bv_val );
+
+       /* FIXME: are we sure str2filter_x can't fail?
+        * caller needs to check */
+       {
+               Filter *f = str2filter_x( op, fbv->bv_val );
+               assert( f != NULL );
+               return f;
+       }
 }
 
 /* Check if the requested entry is from the cache and has a valid
@@ -2657,78 +2715,97 @@ pc_bind_resp( Operation *op, SlapReply *rs )
        return SLAP_CB_CONTINUE;
 }
 
+#ifdef PCACHE_CONTROL_PRIVDB
 static int
-pcache_op_bind(
+pcache_op_privdb(
        Operation               *op,
        SlapReply               *rs )
 {
        slap_overinst   *on = (slap_overinst *)op->o_bd->bd_info;
        cache_manager   *cm = on->on_bi.bi_private;
-       QueryTemplate *temp;
-       Entry *e;
-       slap_callback   cb = { 0 }, *sc;
-       bindinfo bi;
-       bindcacheinfo *bci;
-       Operation op2;
-       int is_priv = 0, rc;
-
-#ifdef PCACHE_CONTROL_PRIVDB
-       if ( op->o_ctrlflag[ privDB_cid ] == SLAP_CONTROL_CRITICAL )
-               is_priv = 1;
-#endif
+       slap_callback   *save_cb;
+       slap_op_t       type;
 
-       /* Skip if we're not configured for Binds, and no priv control */
-       if ( !cm->cache_binds && !is_priv )
+       /* skip if control is unset */
+       if ( op->o_ctrlflag[ privDB_cid ] != SLAP_CONTROL_CRITICAL ) {
                return SLAP_CB_CONTINUE;
+       }
 
        /* The cache DB isn't open yet */
        if ( cm->defer_db_open ) {
-               if ( !is_priv ) {
-                       /* Just passthru for now */
-                       return SLAP_CB_CONTINUE;
-               } else {
-                       send_ldap_error( op, rs, LDAP_UNAVAILABLE,
-                               "pcachePrivDB: cacheDB not available" );
-                       return rs->sr_err;
-               }
+               send_ldap_error( op, rs, LDAP_UNAVAILABLE,
+                       "pcachePrivDB: cacheDB not available" );
+               return rs->sr_err;
        }
 
-       if ( is_priv ) {
-               int             rc;
-               slap_callback   *save_cb;
+       /* FIXME: might be a little bit exaggerated... */
+       if ( !be_isroot( op ) ) {
+               save_cb = op->o_callback;
+               op->o_callback = NULL;
+               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+                       "pcachePrivDB: operation not allowed" );
+               op->o_callback = save_cb;
 
-               /* FIXME: might be a little bit exaggerated... */
-               if ( !be_isroot( op ) ) {
-                       save_cb = op->o_callback;
-                       op->o_callback = NULL;
-                       send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
-                               "pcachePrivDB: operation not allowed" );
-                       op->o_callback = save_cb;
+               return rs->sr_err;
+       }
 
-                       return rs->sr_err;
-               }
+       /* map tag to operation */
+       type = slap_req2op( op->o_tag );
+       if ( type != SLAP_OP_LAST ) {
+               BI_op_func      **func;
+               int             rc;
 
                /* execute, if possible */
-               if ( cm->db.be_bind != NULL ) {
-                       op2 = *op;
+               func = &cm->db.be_bind;
+               if ( func[ type ] != NULL ) {
+                       Operation       op2 = *op;
+       
                        op2.o_bd = &cm->db;
 
-                       rc = op2.o_bd->be_bind( &op2, rs );
-                       if ( rc == LDAP_SUCCESS ) {
+                       rc = func[ type ]( &op2, rs );
+                       if ( type == SLAP_OP_BIND && rc == LDAP_SUCCESS ) {
                                op->o_conn->c_authz_cookie = cm->db.be_private;
                        }
-               } else {
-                       /* otherwise fall back to error */
-                       save_cb = op->o_callback;
-                       op->o_callback = NULL;
-                       send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
-                               "operation not supported with pcachePrivDB control" );
-                       op->o_callback = save_cb;
-               }
 
-               return rs->sr_err;
+                       return rs->sr_err;
+               }
        }
 
+       /* otherwise fall back to error */
+       save_cb = op->o_callback;
+       op->o_callback = NULL;
+       send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+               "operation not supported with pcachePrivDB control" );
+       op->o_callback = save_cb;
+
+       return rs->sr_err;
+}
+#endif /* PCACHE_CONTROL_PRIVDB */
+
+static int
+pcache_op_bind(
+       Operation               *op,
+       SlapReply               *rs )
+{
+       slap_overinst   *on = (slap_overinst *)op->o_bd->bd_info;
+       cache_manager   *cm = on->on_bi.bi_private;
+       QueryTemplate *temp;
+       Entry *e;
+       slap_callback   cb = { 0 }, *sc;
+       bindinfo bi;
+       bindcacheinfo *bci;
+       Operation op2;
+       int rc;
+
+#ifdef PCACHE_CONTROL_PRIVDB
+       if ( op->o_ctrlflag[ privDB_cid ] == SLAP_CONTROL_CRITICAL )
+               return pcache_op_privdb( op, rs );
+#endif /* PCACHE_CONTROL_PRIVDB */
+
+       /* Skip if we're not configured for Binds, or cache DB isn't open yet */
+       if ( !cm->cache_binds || cm->defer_db_open )
+               return SLAP_CB_CONTINUE;
+
        /* First find a matching template with Bind info */
        for ( temp=cm->qm->templates; temp; temp=temp->qmnext ) {
                if ( temp->bindttr && dnIsSuffix( &op->o_req_ndn, &temp->bindbase ))
@@ -2751,9 +2828,6 @@ pcache_op_bind(
        e = NULL;
        rc = be_entry_get_rw( &op2, &op->o_req_ndn, NULL, NULL, 0, &e );
        if ( rc == LDAP_SUCCESS && e ) {
-               int i;
-               Attribute *a;
-
                bi.bi_flags |= BI_LOOKUP;
                op2.ors_filter = pc_bind_attrs( op, e, temp, &op2.ors_filterstr );
                be_entry_release_r( &op2, e );
@@ -2793,6 +2867,9 @@ pcache_op_bind(
                BackendDB *be = op->o_bd;
                op->o_bd = &cm->db;
 
+               Debug( pcache_debug, "pcache_op_bind: CACHED BIND for %s\n",
+                       op->o_req_dn.bv_val, 0, 0 );
+
                if ( op->o_bd->be_bind( op, rs ) == LDAP_SUCCESS ) {
                        op->o_conn->c_authz_cookie = cm->db.be_private;
                }
@@ -2816,73 +2893,6 @@ pcache_op_bind(
        return SLAP_CB_CONTINUE;
 }
 
-#ifdef PCACHE_CONTROL_PRIVDB
-static int
-pcache_op_privdb(
-       Operation               *op,
-       SlapReply               *rs )
-{
-       slap_overinst   *on = (slap_overinst *)op->o_bd->bd_info;
-       cache_manager   *cm = on->on_bi.bi_private;
-       slap_callback   *save_cb;
-       slap_op_t       type;
-
-       /* skip if control is unset */
-       if ( op->o_ctrlflag[ privDB_cid ] != SLAP_CONTROL_CRITICAL ) {
-               return SLAP_CB_CONTINUE;
-       }
-
-       /* The cache DB isn't open yet */
-       if ( cm->defer_db_open ) {
-               send_ldap_error( op, rs, LDAP_UNAVAILABLE,
-                       "pcachePrivDB: cacheDB not available" );
-               return rs->sr_err;
-       }
-
-       /* FIXME: might be a little bit exaggerated... */
-       if ( !be_isroot( op ) ) {
-               save_cb = op->o_callback;
-               op->o_callback = NULL;
-               send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
-                       "pcachePrivDB: operation not allowed" );
-               op->o_callback = save_cb;
-
-               return rs->sr_err;
-       }
-
-       /* map tag to operation */
-       type = slap_req2op( op->o_tag );
-       if ( type != SLAP_OP_LAST ) {
-               BI_op_func      **func;
-               int             rc;
-
-               /* execute, if possible */
-               func = &cm->db.be_bind;
-               if ( func[ type ] != NULL ) {
-                       Operation       op2 = *op;
-       
-                       op2.o_bd = &cm->db;
-
-                       rc = func[ type ]( &op2, rs );
-                       if ( type == SLAP_OP_BIND && rc == LDAP_SUCCESS ) {
-                               op->o_conn->c_authz_cookie = cm->db.be_private;
-                       }
-
-                       return rs->sr_err;
-               }
-       }
-
-       /* otherwise fall back to error */
-       save_cb = op->o_callback;
-       op->o_callback = NULL;
-       send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
-               "operation not supported with pcachePrivDB control" );
-       op->o_callback = save_cb;
-
-       return rs->sr_err;
-}
-#endif /* PCACHE_CONTROL_PRIVDB */
-
 static int
 pcache_op_search(
        Operation       *op,
@@ -3008,14 +3018,22 @@ pcache_op_search(
                                pbi->bi_cq = answerable;
 
                        op->o_bd = &cm->db;
-#if 0
                        if ( cm->response_cb == PCACHE_RESPONSE_CB_TAIL ) {
+                               slap_callback cb;
                                /* The cached entry was already processed by any
                                 * other overlays, so don't let it get processed again.
+                                *
+                                * This loop removes over_back_response from the stack.
                                 */
-                               op->o_callback = NULL;
+                               if ( overlay_callback_after_backover( op, &cb, 0) == 0 ) {
+                                       slap_callback **scp;
+                                       for ( scp = &op->o_callback; *scp != NULL;
+                                               scp = &(*scp)->sc_next ) {
+                                               if ( (*scp)->sc_next == &cb )
+                                                       *scp = cb.sc_next;
+                                       }
+                               }
                        }
-#endif
                        i = cm->db.bd_info->bi_op_search( op, rs );
                }
                ldap_pvt_thread_rdwr_runlock(&answerable->rwlock);
@@ -3201,7 +3219,7 @@ refresh_merge( Operation *op, SlapReply *rs )
                        /* No local entry, just add it. FIXME: we are not checking
                         * the cache entry limit here
                         */
-                        merge_entry( op, rs->sr_entry, &ri->ri_q->q_uuid );
+                        merge_entry( op, rs->sr_entry, 1, &ri->ri_q->q_uuid );
                } else {
                        /* Entry exists, update it */
                        Entry ne;
@@ -3300,7 +3318,7 @@ refresh_query( Operation *op, SlapReply *rs, CachedQuery *query,
 {
        slap_callback cb = { 0 };
        refresh_info ri = { 0 };
-       char filter_str[ LDAP_LUTIL_UUIDSTR_BUFSIZE + STRLENOF( "(queryId=)" ) ];
+       char filter_str[ LDAP_LUTIL_UUIDSTR_BUFSIZE + STRLENOF( "(pcacheQueryID=)" ) ];
        AttributeAssertion      ava = ATTRIBUTEASSERTION_INIT;
        Filter filter = {LDAP_FILTER_EQUALITY};
        AttributeName attrs[ 2 ] = {{{ 0 }}};
@@ -3778,8 +3796,8 @@ pc_cf_gen( ConfigArgs *c )
                                        temp->attr_set_index,
                                        temp->bindttr,
                                        ldap_pvt_scope2str( temp->bindscope ));
-                               bv.bv_len += temp->bindbase.bv_len + temp->bindftemp.bv_len + 3;
-                               bv.bv_val = ch_malloc( bv.bv_len+1 );
+                               bv.bv_len += temp->bindbase.bv_len + temp->bindftemp.bv_len + 4;
+                               bv.bv_val = ch_malloc( bv.bv_len + 1 );
                                ptr = bv.bv_val;
                                *ptr++ = '"';
                                ptr = lutil_strcopy( ptr, temp->bindftemp.bv_val );
@@ -4388,9 +4406,13 @@ pcache_db_init(
        cm->check_cacheability = 0;
        cm->response_cb = PCACHE_RESPONSE_CB_TAIL;
        cm->defer_db_open = 1;
+       cm->cache_binds = 0;
        cm->cc_period = 1000;
        cm->cc_paused = 0;
        cm->cc_arg = NULL;
+#ifdef PCACHE_MONITOR
+       cm->monitor_cb = NULL;
+#endif /* PCACHE_MONITOR */
 
        qm->attr_sets = NULL;
        qm->templates = NULL;
@@ -4496,7 +4518,7 @@ pcache_db_open2(
                        AttributeAssertion      ava = ATTRIBUTEASSERTION_INIT;
                        AttributeName   attrs[ 2 ] = {{{ 0 }}};
 
-                       connection_fake_init( &conn, &opbuf, thrctx );
+                       connection_fake_init2( &conn, &opbuf, thrctx, 0 );
                        op = &opbuf.ob_op;
 
                        op->o_bd = &cm->db;
@@ -4520,7 +4542,7 @@ pcache_db_open2(
                        op->ors_slimit = 1;
                        op->ors_tlimit = SLAP_NO_LIMIT;
                        op->ors_limit = NULL;
-                       ber_str2bv( "(cachedQueryURL=*)", 0, 0, &op->ors_filterstr );
+                       ber_str2bv( "(pcacheQueryURL=*)", 0, 0, &op->ors_filterstr );
                        f.f_choice = LDAP_FILTER_PRESENT;
                        f.f_desc = ad_cachedQueryURL;
                        op->ors_filter = &f;
@@ -4682,7 +4704,7 @@ pcache_db_close(
 
                thrctx = ldap_pvt_thread_pool_context();
 
-               connection_fake_init( &conn, &opbuf, thrctx );
+               connection_fake_init2( &conn, &opbuf, thrctx, 0 );
                op = &opbuf.ob_op;
 
                if ( qm->templates != NULL ) {
@@ -4842,6 +4864,7 @@ static char *extops[] = {
 };
 #endif /* PCACHE_CONTROL_PRIVDB */
 
+static struct berval pcache_exop_MODIFY_PASSWD = BER_BVC( LDAP_EXOP_MODIFY_PASSWD );
 #ifdef PCACHE_EXOP_QUERY_DELETE
 static struct berval pcache_exop_QUERY_DELETE = BER_BVC( PCACHE_EXOP_QUERY_DELETE );
 
@@ -5077,7 +5100,7 @@ pcache_exop_query_delete(
                len = snprintf( buf, sizeof( buf ), " dn=\"%s\"", op->o_req_ndn.bv_val );
 
                if ( !BER_BVISNULL( &uuid ) && len < sizeof( buf ) ) {
-                       snprintf( &buf[ len ], sizeof( buf ) - len, " queryId=\"%s\"", uuid.bv_val );
+                       snprintf( &buf[ len ], sizeof( buf ) - len, " pcacheQueryId=\"%s\"", uuid.bv_val );
                }
 
                Debug( LDAP_DEBUG_STATS, "%s QUERY DELETE%s\n",
@@ -5115,6 +5138,7 @@ done:;
 
         return rs->sr_err;
 }
+#endif /* PCACHE_EXOP_QUERY_DELETE */
 
 static int
 pcache_op_extended( Operation *op, SlapReply *rs )
@@ -5128,6 +5152,7 @@ pcache_op_extended( Operation *op, SlapReply *rs )
        }
 #endif /* PCACHE_CONTROL_PRIVDB */
 
+#ifdef PCACHE_EXOP_QUERY_DELETE
        if ( bvmatch( &op->ore_reqoid, &pcache_exop_QUERY_DELETE ) ) {
                struct berval   uuid = BER_BVNULL;
                ber_tag_t       tag = LBER_DEFAULT;
@@ -5155,11 +5180,66 @@ pcache_op_extended( Operation *op, SlapReply *rs )
                }
 
                op->o_tmpfree( uuid.bv_val, op->o_tmpmemctx );
+               return rs->sr_err;
        }
+#endif /* PCACHE_EXOP_QUERY_DELETE */
 
-       return rs->sr_err;
+       /* We only care if we're configured for Bind caching */
+       if ( bvmatch( &op->ore_reqoid, &pcache_exop_MODIFY_PASSWD ) &&
+               cm->cache_binds ) {
+               /* See if the local entry exists and has a password.
+                * It's too much work to find the matching query, so
+                * we just see if there's a hashed password to update.
+                */
+               Operation op2 = *op;
+               Entry *e = NULL;
+               int rc;
+               int doit = 0;
+
+               op2.o_bd = &cm->db;
+               op2.o_dn = op->o_bd->be_rootdn;
+               op2.o_ndn = op->o_bd->be_rootndn;
+               rc = be_entry_get_rw( &op2, &op->o_req_ndn, NULL,
+                       slap_schema.si_ad_userPassword, 0, &e );
+               if ( rc == LDAP_SUCCESS && e ) {
+                       /* See if a recognized password is hashed here */
+                       Attribute *a = attr_find( e->e_attrs,
+                               slap_schema.si_ad_userPassword );
+                       if ( a && a->a_vals[0].bv_val[0] == '{' &&
+                               lutil_passwd_scheme( a->a_vals[0].bv_val )) {
+                               doit = 1;
+                       }
+                       be_entry_release_r( &op2, e );
+               }
+
+               if ( doit ) {
+                       rc = overlay_op_walk( op, rs, op_extended, on->on_info,
+                               on->on_next );
+                       if ( rc == LDAP_SUCCESS ) {
+                               req_pwdexop_s *qpw = &op->oq_pwdexop;
+
+                               /* We don't care if it succeeds or not */
+                               pc_setpw( &op2, &qpw->rs_new, cm );
+                       }
+                       return rc;
+               }
+       }
+       return SLAP_CB_CONTINUE;
+}
+
+static int
+pcache_entry_release( Operation  *op, Entry *e, int rw )
+{
+       slap_overinst   *on = (slap_overinst *)op->o_bd->bd_info;
+       cache_manager   *cm = on->on_bi.bi_private;
+       BackendDB *db = op->o_bd;
+       int rc;
+
+       op->o_bd = &cm->db;
+       rc = be_entry_release_rw( op, e, rw );
+       op->o_bd = db;
+       return rc;
 }
-#endif /* PCACHE_EXOP_QUERY_DELETE */
 
 #ifdef PCACHE_MONITOR
 
@@ -5176,8 +5256,6 @@ pcache_monitor_update(
        CachedQuery     *qc;
        BerVarray       vals = NULL;
 
-       assert( ad_cachedQueryURL != NULL );
-
        attr_delete( &e->e_attrs, ad_cachedQueryURL );
        if ( ( SLAP_OPATTRS( rs->sr_attr_flags ) || ad_inlist( ad_cachedQueryURL, rs->sr_attrs ) )
                && qm->templates != NULL )
@@ -5201,6 +5279,36 @@ pcache_monitor_update(
                }
        }
 
+       {
+               Attribute       *a;
+               char            buf[ SLAP_TEXT_BUFLEN ];
+               struct berval   bv;
+
+               /* number of cached queries */
+               a = attr_find( e->e_attrs, ad_numQueries );
+               assert( a != NULL );
+
+               bv.bv_val = buf;
+               bv.bv_len = snprintf( buf, sizeof( buf ), "%lu", cm->num_cached_queries );
+
+               if ( a->a_nvals != a->a_vals ) {
+                       ber_bvreplace( &a->a_nvals[ 0 ], &bv );
+               }
+               ber_bvreplace( &a->a_vals[ 0 ], &bv );
+
+               /* number of cached entries */
+               a = attr_find( e->e_attrs, ad_numEntries );
+               assert( a != NULL );
+
+               bv.bv_val = buf;
+               bv.bv_len = snprintf( buf, sizeof( buf ), "%d", cm->cur_entries );
+
+               if ( a->a_nvals != a->a_vals ) {
+                       ber_bvreplace( &a->a_nvals[ 0 ], &bv );
+               }
+               ber_bvreplace( &a->a_vals[ 0 ], &bv );
+       }
+
        return SLAP_CB_CONTINUE;
 }
 
@@ -5240,6 +5348,22 @@ pcache_monitor_free(
                textbuf, sizeof( textbuf ) );
        /* don't care too much about return code... */
 
+       /* remove attrs */
+       mod.sm_values = NULL;
+       mod.sm_desc = ad_numQueries;
+       mod.sm_numvals = 0;
+       rc = modify_delete_values( e, &mod, 1, &text,
+               textbuf, sizeof( textbuf ) );
+       /* don't care too much about return code... */
+
+       /* remove attrs */
+       mod.sm_values = NULL;
+       mod.sm_desc = ad_numEntries;
+       mod.sm_numvals = 0;
+       rc = modify_delete_values( e, &mod, 1, &text,
+               textbuf, sizeof( textbuf ) );
+       /* don't care too much about return code... */
+
        return SLAP_CB_CONTINUE;
 }
 
@@ -5310,7 +5434,7 @@ pcache_monitor_db_open( BackendDB *be )
        }
 
        /* alloc as many as required (plus 1 for objectClass) */
-       a = attrs_alloc( 1 + 0 );
+       a = attrs_alloc( 1 + 2 );
        if ( a == NULL ) {
                rc = 1;
                goto cleanup;
@@ -5320,6 +5444,18 @@ pcache_monitor_db_open( BackendDB *be )
        attr_valadd( a, &oc_olmPCache->soc_cname, NULL, 1 );
        next = a->a_next;
 
+       {
+               struct berval   bv = BER_BVC( "0" );
+
+               next->a_desc = ad_numQueries;
+               attr_valadd( next, &bv, NULL, 1 );
+               next = next->a_next;
+
+               next->a_desc = ad_numEntries;
+               attr_valadd( next, &bv, NULL, 1 );
+               next = next->a_next;
+       }
+
        cb = ch_calloc( sizeof( monitor_callback_t ), 1 );
        cb->mc_update = pcache_monitor_update;
        cb->mc_free = pcache_monitor_free;
@@ -5489,12 +5625,9 @@ pcache_initialize()
        pcache.on_bi.bi_op_add = pcache_op_privdb;
        pcache.on_bi.bi_op_delete = pcache_op_privdb;
 #endif /* PCACHE_CONTROL_PRIVDB */
-#ifdef PCACHE_EXOP_QUERY_DELETE
        pcache.on_bi.bi_extended = pcache_op_extended;
-#elif defined( PCACHE_CONTROL_PRIVDB )
-       pcache.on_bi.bi_extended = pcache_op_privdb;
-#endif
 
+       pcache.on_bi.bi_entry_release_rw = pcache_entry_release;
        pcache.on_bi.bi_chk_controls = pcache_chk_controls;
 
        pcache.on_bi.bi_cf_ocs = pcocs;