]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/overlays/rwmmap.c
happy new year
[openldap] / servers / slapd / overlays / rwmmap.c
index 9d79679be31ccc694c49d70f784e5e74b5bb1e0b..ce399a8f9ced466bed4ce73aba7f7a8c3b6960ce 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1999-2004 The OpenLDAP Foundation.
+ * Copyright 1999-2007 The OpenLDAP Foundation.
  * Portions Copyright 1999-2003 Howard Chu.
  * Portions Copyright 2000-2003 Pierangelo Masarati.
  * All rights reserved.
@@ -71,29 +71,33 @@ rwm_map_init( struct ldapmap *lm, struct ldapmapping **m )
        const char              *text;
        int                     rc;
 
-       assert( m );
+       assert( m != NULL );
 
        *m = NULL;
        
        mapping = (struct ldapmapping *)ch_calloc( 2, 
                        sizeof( struct ldapmapping ) );
        if ( mapping == NULL ) {
-               return;
+               return LDAP_NO_MEMORY;
        }
 
-       rc = slap_str2ad( "objectClass", &mapping->m_src_ad, &text );
+       /* FIXME: I don't think this is needed any more... */
+       rc = slap_str2ad( "objectClass", &mapping[0].m_src_ad, &text );
        if ( rc != LDAP_SUCCESS ) {
+               ch_free( mapping );
                return rc;
        }
 
-       mapping->m_dst_ad = mapping->m_src_ad;
-       ber_dupbv( &mapping->m_dst, &mapping->m_src_ad->ad_cname );
-       ber_dupbv( &mapping->m_dst, &mapping->m_src );
+       mapping[0].m_dst_ad = mapping[0].m_src_ad;
+       ber_dupbv( &mapping[0].m_src, &mapping[0].m_src_ad->ad_cname );
+       ber_dupbv( &mapping[0].m_dst, &mapping[0].m_src );
 
-       mapping[1].m_src = mapping->m_src;
-       mapping[1].m_dst = mapping->m_dst;
+       mapping[1].m_src = mapping[0].m_src;
+       mapping[1].m_dst = mapping[0].m_dst;
+       mapping[1].m_src_ad = mapping[0].m_src_ad;
+       mapping[1].m_dst_ad = mapping[1].m_src_ad;
 
-       avl_insert( &lm->map, (caddr_t)mapping
+       avl_insert( &lm->map, (caddr_t)&mapping[0]
                        rwm_mapping_cmp, rwm_mapping_dup );
        avl_insert( &lm->remap, (caddr_t)&mapping[1], 
                        rwm_mapping_cmp, rwm_mapping_dup );
@@ -109,7 +113,11 @@ rwm_mapping( struct ldapmap *map, struct berval *s, struct ldapmapping **m, int
        Avlnode *tree;
        struct ldapmapping fmapping;
 
-       assert( m );
+       if ( map == NULL ) {
+               return 0;
+       }
+
+       assert( m != NULL );
 
        if ( remap == RWM_REMAP ) {
                tree = map->remap;
@@ -135,7 +143,7 @@ rwm_map( struct ldapmap *map, struct berval *s, struct berval *bv, int remap )
        struct ldapmapping *mapping;
 
        BER_BVZERO( bv );
-       rwm_mapping( map, s, &mapping, remap );
+       ( void )rwm_mapping( map, s, &mapping, remap );
        if ( mapping != NULL ) {
                if ( !BER_BVISNULL( &mapping->m_dst ) ) {
                        *bv = mapping->m_dst;
@@ -153,15 +161,18 @@ rwm_map( struct ldapmap *map, struct berval *s, struct berval *bv, int remap )
  */
 int
 rwm_map_attrnames(
-               struct ldapmap *at_map,
-               struct ldapmap *oc_map,
-               AttributeName *an,
-               AttributeName **anp,
-               int remap
-)
+       struct ldapmap  *at_map,
+       struct ldapmap  *oc_map,
+       AttributeName   *an,
+       AttributeName   **anp,
+       int             remap )
 {
        int             i, j;
 
+       assert( anp != NULL );
+
+       *anp = NULL;
+
        if ( an == NULL ) {
                return LDAP_SUCCESS;
        }
@@ -169,6 +180,9 @@ rwm_map_attrnames(
        for ( i = 0; !BER_BVISNULL( &an[i].an_name ); i++ )
                /* just count */ ;
        *anp = ch_malloc( ( i + 1 )* sizeof( AttributeName ) );
+       if ( *anp == NULL ) {
+               return LDAP_NO_MEMORY;
+       }
 
        for ( i = 0, j = 0; !BER_BVISNULL( &an[i].an_name ); i++ ) {
                struct ldapmapping      *m;
@@ -236,7 +250,6 @@ rwm_map_attrnames(
                        at_drop_missing = rwm_mapping( at_map, &an[i].an_name, &m, remap );
                
                        if ( at_drop_missing || !m ) {
-
                                oc_drop_missing = rwm_mapping( oc_map, &an[i].an_name, &m, remap );
 
                                /* if both at_map and oc_map required to drop missing,
@@ -291,6 +304,7 @@ rwm_map_attrnames(
        if ( j == 0 && i != 0 ) {
                memset( &(*anp)[0], 0, sizeof( AttributeName ) );
                BER_BVSTR( &(*anp)[0].an_name, LDAP_NO_ATTRS );
+               j = 1;
        }
        memset( &(*anp)[j], 0, sizeof( AttributeName ) );
 
@@ -299,11 +313,10 @@ rwm_map_attrnames(
 
 int
 rwm_map_attrs(
-               struct ldapmap *at_map,
-               AttributeName *an,
-               int remap,
-               char ***mapped_attrs
-)
+       struct ldapmap  *at_map,
+       AttributeName   *an,
+       int             remap,
+       char            ***mapped_attrs )
 {
        int i, j;
        char **na;
@@ -313,209 +326,240 @@ rwm_map_attrs(
                return LDAP_SUCCESS;
        }
 
-       for ( i = 0; !BER_BVISNULL( &an[i].an_name ); i++ ) {
-               /*  */
-       }
+       for ( i = 0; !BER_BVISNULL( &an[ i ].an_name ); i++ )
+               /* count'em */ ;
 
        na = (char **)ch_calloc( i + 1, sizeof( char * ) );
-       if (na == NULL) {
+       if ( na == NULL ) {
                *mapped_attrs = NULL;
                return LDAP_NO_MEMORY;
        }
 
        for ( i = j = 0; !BER_BVISNULL( &an[i].an_name ); i++ ) {
-               struct ldapmapping      *m;
+               struct ldapmapping      *mapping;
                
-               if ( rwm_mapping( at_map, &an[i].an_name, &m, remap ) ) {
+               if ( rwm_mapping( at_map, &an[i].an_name, &mapping, remap ) ) {
                        continue;
                }
 
-               if ( !m || ( m && !BER_BVISNULL( &m->m_dst ) ) ) {
-                       na[j++] = m->m_dst.bv_val;
+               if ( !mapping ) {
+                       na[ j++ ] = an[ i ].an_name.bv_val;
+                       
+               } else if ( !BER_BVISNULL( &mapping->m_dst ) ) {
+                       na[ j++ ] = mapping->m_dst.bv_val;
                }
        }
+
        if ( j == 0 && i != 0 ) {
-               na[j++] = LDAP_NO_ATTRS;
+               na[ j++ ] = LDAP_NO_ATTRS;
        }
-       na[j] = NULL;
+
+       na[ j ] = NULL;
 
        *mapped_attrs = na;
+
        return LDAP_SUCCESS;
 }
 
 static int
 map_attr_value(
-               dncookie                *dc,
-               AttributeDescription    *ad,
-               struct berval           *mapped_attr,
-               struct berval           *value,
-               struct berval           *mapped_value,
-               int                     remap )
+       dncookie                *dc,
+       AttributeDescription    **adp,
+       struct berval           *mapped_attr,
+       struct berval           *value,
+       struct berval           *mapped_value,
+       int                     remap )
 {
-       struct berval           vtmp;
+       struct berval           vtmp = BER_BVNULL;
        int                     freeval = 0;
+       AttributeDescription    *ad = *adp;
+       struct ldapmapping      *mapping = NULL;
 
-       rwm_map( &dc->rwmap->rwm_at, &ad->ad_cname, mapped_attr, remap );
-       if ( BER_BVISNULL( mapped_attr ) || BER_BVISEMPTY( mapped_attr ) ) {
-               /*
-                * FIXME: are we sure we need to search oc_map if at_map fails?
-                */
-               rwm_map( &dc->rwmap->rwm_oc, &ad->ad_cname, mapped_attr, remap );
-               if ( BER_BVISNULL( mapped_attr ) || BER_BVISEMPTY( mapped_attr ) )
-               {
-                       *mapped_attr = ad->ad_cname;
+       rwm_mapping( &dc->rwmap->rwm_at, &ad->ad_cname, &mapping, remap );
+       if ( mapping == NULL ) {
+               if ( dc->rwmap->rwm_at.drop_missing ) {
+                       return -1;
                }
-       }
 
-       if ( value == NULL ) {
-               return 0;
+               *mapped_attr = ad->ad_cname;
+
+       } else {
+               *mapped_attr = mapping->m_dst;
        }
 
-       if ( ad->ad_type->sat_syntax == slap_schema.si_syn_distinguishedName )
-       {
-               dncookie        fdc = *dc;
-               int             rc;
+       if ( value != NULL ) {
+               assert( mapped_value != NULL );
+
+               if ( ad->ad_type->sat_syntax == slap_schema.si_syn_distinguishedName
+                               || ( mapping != NULL && mapping->m_dst_ad->ad_type->sat_syntax == slap_schema.si_syn_distinguishedName ) )
+               {
+                       dncookie        fdc = *dc;
+                       int             rc;
 
 #ifdef ENABLE_REWRITE
-               fdc.ctx = "searchFilterAttrDN";
-#endif
+                       fdc.ctx = "searchFilterAttrDN";
+#endif /* ENABLE_REWRITE */
 
-               rc = rwm_dn_massage( &fdc, value, &vtmp, NULL );
-               switch ( rc ) {
-               case LDAP_SUCCESS:
-                       if ( vtmp.bv_val != value->bv_val ) {
-                               freeval = 1;
-                       }
-                       break;
+                       vtmp = *value;
+                       rc = rwm_dn_massage_normalize( &fdc, value, &vtmp );
+                       switch ( rc ) {
+                       case LDAP_SUCCESS:
+                               if ( vtmp.bv_val != value->bv_val ) {
+                                       freeval = 1;
+                               }
+                               break;
                
-               case LDAP_UNWILLING_TO_PERFORM:
-               case LDAP_OTHER:
-               default:
-                       return -1;
-               }
+                       case LDAP_UNWILLING_TO_PERFORM:
+                       case LDAP_OTHER:
+                       default:
+                               return -1;
+                       }
 
-       } else if ( ad == slap_schema.si_ad_objectClass
-                       || ad == slap_schema.si_ad_structuralObjectClass )
-       {
-               rwm_map( &dc->rwmap->rwm_oc, value, &vtmp, remap );
-               if ( BER_BVISNULL( &vtmp ) || BER_BVISEMPTY( &vtmp ) ) {
+               } else if ( ad == slap_schema.si_ad_objectClass
+                               || ad == slap_schema.si_ad_structuralObjectClass )
+               {
+                       rwm_map( &dc->rwmap->rwm_oc, value, &vtmp, remap );
+                       if ( BER_BVISNULL( &vtmp ) || BER_BVISEMPTY( &vtmp ) ) {
+                               vtmp = *value;
+                       }
+               
+               } else {
                        vtmp = *value;
                }
-               
-       } else {
-               vtmp = *value;
-       }
 
-       filter_escape_value( &vtmp, mapped_value );
+               filter_escape_value( &vtmp, mapped_value );
 
-       if ( freeval ) {
-               ber_memfree( vtmp.bv_val );
+               if ( freeval ) {
+                       ch_free( vtmp.bv_val );
+               }
        }
        
+       if ( mapping != NULL ) {
+               assert( mapping->m_dst_ad != NULL );
+               *adp = mapping->m_dst_ad;
+       }
+
        return 0;
 }
 
 static int
 rwm_int_filter_map_rewrite(
-               dncookie                *dc,
-               Filter                  *f,
-               struct berval           *fstr )
+       Operation               *op,
+       dncookie                *dc,
+       Filter                  *f,
+       struct berval           *fstr )
 {
        int             i;
        Filter          *p;
+       AttributeDescription *ad;
        struct berval   atmp,
                        vtmp,
-                       tmp;
+                       *tmp;
        static struct berval
-                       ber_bvfalse = BER_BVC( "(?=false)" ),
-                       ber_bvtrue = BER_BVC( "(?=true)" ),
+                       /* better than nothing... */
+                       ber_bvfalse = BER_BVC( "(!(objectClass=*))" ),
+                       ber_bvtf_false = BER_BVC( "(|)" ),
+                       /* better than nothing... */
+                       ber_bvtrue = BER_BVC( "(objectClass=*)" ),
+                       ber_bvtf_true = BER_BVC( "(&)" ),
+#if 0
+                       /* no longer needed; preserved for completeness */
                        ber_bvundefined = BER_BVC( "(?=undefined)" ),
+#endif
                        ber_bverror = BER_BVC( "(?=error)" ),
                        ber_bvunknown = BER_BVC( "(?=unknown)" ),
                        ber_bvnone = BER_BVC( "(?=none)" );
        ber_len_t       len;
 
+       assert( fstr != NULL );
+       BER_BVZERO( fstr );
+
        if ( f == NULL ) {
                ber_dupbv( fstr, &ber_bvnone );
-               return -1;
+               return LDAP_OTHER;
        }
 
-       switch ( f->f_choice ) {
+       switch ( f->f_choice & SLAPD_FILTER_MASK ) {
        case LDAP_FILTER_EQUALITY:
-               if ( map_attr_value( dc, f->f_av_desc, &atmp,
+               ad = f->f_av_desc;
+               if ( map_attr_value( dc, &ad, &atmp,
                                        &f->f_av_value, &vtmp, RWM_MAP ) )
                {
-                       return -1;
+                       goto computed;
                }
 
                fstr->bv_len = atmp.bv_len + vtmp.bv_len + STRLENOF( "(=)" );
-               fstr->bv_val = malloc( fstr->bv_len + 1 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=%s)",
                        atmp.bv_val, vtmp.bv_val );
 
-               ber_memfree( vtmp.bv_val );
+               ch_free( vtmp.bv_val );
                break;
 
        case LDAP_FILTER_GE:
-               if ( map_attr_value( dc, f->f_av_desc, &atmp,
+               ad = f->f_av_desc;
+               if ( map_attr_value( dc, &ad, &atmp,
                                        &f->f_av_value, &vtmp, RWM_MAP ) )
                {
-                       return -1;
+                       goto computed;
                }
 
                fstr->bv_len = atmp.bv_len + vtmp.bv_len + STRLENOF( "(>=)" );
-               fstr->bv_val = malloc( fstr->bv_len + 1 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s>=%s)",
                        atmp.bv_val, vtmp.bv_val );
 
-               ber_memfree( vtmp.bv_val );
+               ch_free( vtmp.bv_val );
                break;
 
        case LDAP_FILTER_LE:
-               if ( map_attr_value( dc, f->f_av_desc, &atmp,
+               ad = f->f_av_desc;
+               if ( map_attr_value( dc, &ad, &atmp,
                                        &f->f_av_value, &vtmp, RWM_MAP ) )
                {
-                       return -1;
+                       goto computed;
                }
 
                fstr->bv_len = atmp.bv_len + vtmp.bv_len + STRLENOF( "(<=)" );
-               fstr->bv_val = malloc( fstr->bv_len + 1 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s<=%s)",
                        atmp.bv_val, vtmp.bv_val );
 
-               ber_memfree( vtmp.bv_val );
+               ch_free( vtmp.bv_val );
                break;
 
        case LDAP_FILTER_APPROX:
-               if ( map_attr_value( dc, f->f_av_desc, &atmp,
+               ad = f->f_av_desc;
+               if ( map_attr_value( dc, &ad, &atmp,
                                        &f->f_av_value, &vtmp, RWM_MAP ) )
                {
-                       return -1;
+                       goto computed;
                }
 
                fstr->bv_len = atmp.bv_len + vtmp.bv_len + STRLENOF( "(~=)" );
-               fstr->bv_val = malloc( fstr->bv_len + 1 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s~=%s)",
                        atmp.bv_val, vtmp.bv_val );
 
-               ber_memfree( vtmp.bv_val );
+               ch_free( vtmp.bv_val );
                break;
 
        case LDAP_FILTER_SUBSTRINGS:
-               if ( map_attr_value( dc, f->f_sub_desc, &atmp,
+               ad = f->f_sub_desc;
+               if ( map_attr_value( dc, &ad, &atmp,
                                        NULL, NULL, RWM_MAP ) )
                {
-                       return -1;
+                       goto computed;
                }
 
                /* cannot be a DN ... */
 
                fstr->bv_len = atmp.bv_len + STRLENOF( "(=*)" );
-               fstr->bv_val = malloc( fstr->bv_len + 128 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 128 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=*)",
                        atmp.bv_val );
@@ -532,7 +576,7 @@ rwm_int_filter_map_rewrite(
                                /* "(attr=" */ "%s*)",
                                vtmp.bv_val );
 
-                       ber_memfree( vtmp.bv_val );
+                       ch_free( vtmp.bv_val );
                }
 
                if ( f->f_sub_any != NULL ) {
@@ -546,7 +590,7 @@ rwm_int_filter_map_rewrite(
                                snprintf( &fstr->bv_val[len - 1], vtmp.bv_len + 3,
                                        /* "(attr=[init]*[any*]" */ "%s*)",
                                        vtmp.bv_val );
-                               ber_memfree( vtmp.bv_val );
+                               ch_free( vtmp.bv_val );
                        }
                }
 
@@ -562,20 +606,21 @@ rwm_int_filter_map_rewrite(
                                /* "(attr=[init*][any*]" */ "%s)",
                                vtmp.bv_val );
 
-                       ber_memfree( vtmp.bv_val );
+                       ch_free( vtmp.bv_val );
                }
 
                break;
 
        case LDAP_FILTER_PRESENT:
-               if ( map_attr_value( dc, f->f_desc, &atmp,
+               ad = f->f_desc;
+               if ( map_attr_value( dc, &ad, &atmp,
                                        NULL, NULL, RWM_MAP ) )
                {
-                       return -1;
+                       goto computed;
                }
 
                fstr->bv_len = atmp.bv_len + STRLENOF( "(=*)" );
-               fstr->bv_val = malloc( fstr->bv_len + 1 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s=*)",
                        atmp.bv_val );
@@ -585,18 +630,20 @@ rwm_int_filter_map_rewrite(
        case LDAP_FILTER_OR:
        case LDAP_FILTER_NOT:
                fstr->bv_len = STRLENOF( "(%)" );
-               fstr->bv_val = malloc( fstr->bv_len + 128 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 128 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%c)",
                        f->f_choice == LDAP_FILTER_AND ? '&' :
                        f->f_choice == LDAP_FILTER_OR ? '|' : '!' );
 
                for ( p = f->f_list; p != NULL; p = p->f_next ) {
+                       int     rc;
+
                        len = fstr->bv_len;
 
-                       if ( rwm_int_filter_map_rewrite( dc, p, &vtmp ) )
-                       {
-                               return -1;
+                       rc = rwm_int_filter_map_rewrite( op, dc, p, &vtmp );
+                       if ( rc != LDAP_SUCCESS ) {
+                               return rc;
                        }
                        
                        fstr->bv_len += vtmp.bv_len;
@@ -612,10 +659,11 @@ rwm_int_filter_map_rewrite(
 
        case LDAP_FILTER_EXT: {
                if ( f->f_mr_desc ) {
-                       if ( map_attr_value( dc, f->f_mr_desc, &atmp,
+                       ad = f->f_mr_desc;
+                       if ( map_attr_value( dc, &ad, &atmp,
                                                &f->f_mr_value, &vtmp, RWM_MAP ) )
                        {
-                               return -1;
+                               goto computed;
                        }
 
                } else {
@@ -628,7 +676,7 @@ rwm_int_filter_map_rewrite(
                        ( f->f_mr_dnattrs ? STRLENOF( ":dn" ) : 0 ) +
                        ( f->f_mr_rule_text.bv_len ? f->f_mr_rule_text.bv_len + 1 : 0 ) +
                        vtmp.bv_len + STRLENOF( "(:=)" );
-               fstr->bv_val = malloc( fstr->bv_len + 1 );
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
 
                snprintf( fstr->bv_val, fstr->bv_len + 1, "(%s%s%s%s:=%s)",
                        atmp.bv_val,
@@ -636,29 +684,43 @@ rwm_int_filter_map_rewrite(
                        !BER_BVISEMPTY( &f->f_mr_rule_text ) ? ":" : "",
                        !BER_BVISEMPTY( &f->f_mr_rule_text ) ? f->f_mr_rule_text.bv_val : "",
                        vtmp.bv_val );
-               ber_memfree( vtmp.bv_val );
-               } break;
+               ch_free( vtmp.bv_val );
+               break;
+       }
+
+       case -1:
+computed:;
+               filter_free_x( op, f );
+               f->f_choice = SLAPD_FILTER_COMPUTED;
+               f->f_result = SLAPD_COMPARE_UNDEFINED;
+               /* fallthru */
 
        case SLAPD_FILTER_COMPUTED:
                switch ( f->f_result ) {
                case LDAP_COMPARE_FALSE:
-                       tmp = ber_bvfalse;
+               /* FIXME: treat UNDEFINED as FALSE */
+               case SLAPD_COMPARE_UNDEFINED:
+                       if ( dc->rwmap->rwm_flags & RWM_F_SUPPORT_T_F ) {
+                               tmp = &ber_bvtf_false;
+                               break;
+                       }
+                       tmp = &ber_bvfalse;
                        break;
 
                case LDAP_COMPARE_TRUE:
-                       tmp = ber_bvtrue;
-                       break;
-                       
-               case SLAPD_COMPARE_UNDEFINED:
-                       tmp = ber_bvundefined;
+                       if ( dc->rwmap->rwm_flags & RWM_F_SUPPORT_T_F ) {
+                               tmp = &ber_bvtf_true;
+                               break;
+                       }
+                       tmp = &ber_bvtrue;
                        break;
                        
                default:
-                       tmp = ber_bverror;
+                       tmp = &ber_bverror;
                        break;
                }
 
-               ber_dupbv( fstr, &tmp );
+               ber_dupbv( fstr, tmp );
                break;
                
        default:
@@ -666,23 +728,24 @@ rwm_int_filter_map_rewrite(
                break;
        }
 
-       return 0;
+       return LDAP_SUCCESS;
 }
 
 int
 rwm_filter_map_rewrite(
-               dncookie                *dc,
-               Filter                  *f,
-               struct berval           *fstr )
+       Operation               *op,
+       dncookie                *dc,
+       Filter                  *f,
+       struct berval           *fstr )
 {
        int             rc;
        dncookie        fdc;
        struct berval   ftmp;
 
-       rc = rwm_int_filter_map_rewrite( dc, f, fstr );
+       rc = rwm_int_filter_map_rewrite( op, dc, f, fstr );
 
 #ifdef ENABLE_REWRITE
-       if ( rc != LDAP_SUCCESS ) {
+       if ( rc != 0 ) {
                return rc;
        }
 
@@ -693,25 +756,20 @@ rwm_filter_map_rewrite(
 
        switch ( rewrite_session( fdc.rwmap->rwm_rw, fdc.ctx, 
                                ( !BER_BVISEMPTY( &ftmp ) ? ftmp.bv_val : "" ), 
-                               fdc.conn, &fstr->bv_val )) {
+                               fdc.conn, &fstr->bv_val ) )
+       {
        case REWRITE_REGEXEC_OK:
                if ( !BER_BVISNULL( fstr ) ) {
                        fstr->bv_len = strlen( fstr->bv_val );
-                       free( ftmp.bv_val );
+                       ch_free( ftmp.bv_val );
 
                } else {
                        *fstr = ftmp;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( BACK_LDAP, DETAIL1, 
-                       "[rw] %s: \"%s\" -> \"%s\"\n",
-                       dc->ctx, ftmp.bv_val, fstr->bv_val );           
-#else /* !NEW_LOGGING */
                Debug( LDAP_DEBUG_ARGS,
                        "[rw] %s: \"%s\" -> \"%s\"\n",
-                       dc->ctx, ftmp.bv_val, fstr->bv_val );           
-#endif /* !NEW_LOGGING */
+                       fdc.ctx, ftmp.bv_val, fstr->bv_val );           
                rc = LDAP_SUCCESS;
                break;
                
@@ -731,8 +789,8 @@ rwm_filter_map_rewrite(
                rc = LDAP_OTHER;
                break;
        }
-
 #endif /* ENABLE_REWRITE */
+
        return rc;
 }
 
@@ -744,7 +802,7 @@ rwm_filter_map_rewrite(
  * routines may be macros with args
  */
 int
-rwm_dnattr_rewrite(
+rwm_referral_rewrite(
        Operation               *op,
        SlapReply               *rs,
        void                    *cookie,
@@ -758,38 +816,70 @@ rwm_dnattr_rewrite(
        int                     i, last;
 
        dncookie                dc;
-       struct berval           dn, ndn, *pndn = NULL;
+       struct berval           dn = BER_BVNULL,
+                               ndn = BER_BVNULL;
 
-       assert( a_vals );
+       assert( a_vals != NULL );
 
        /*
-        * Rewrite the bind dn if needed
+        * Rewrite the dn if needed
         */
        dc.rwmap = rwmap;
 #ifdef ENABLE_REWRITE
        dc.conn = op->o_conn;
        dc.rs = rs;
        dc.ctx = (char *)cookie;
-#else
+#else /* ! ENABLE_REWRITE */
        dc.tofrom = ((int *)cookie)[0];
        dc.normalized = 0;
-#endif
+#endif /* ! ENABLE_REWRITE */
 
-       for ( last = 0; !BER_BVISNULL( &a_vals[last] ); last++ );
+       for ( last = 0; !BER_BVISNULL( &a_vals[last] ); last++ )
+               ;
+       last--;
+       
        if ( pa_nvals != NULL ) {
-               pndn = &ndn;
-
                if ( *pa_nvals == NULL ) {
-                       *pa_nvals = ch_malloc( last * sizeof(struct berval) );
-                       memset( *pa_nvals, 0, last * sizeof(struct berval) );
+                       *pa_nvals = ch_malloc( ( last + 2 ) * sizeof(struct berval) );
+                       memset( *pa_nvals, 0, ( last + 2 ) * sizeof(struct berval) );
                }
        }
-       last--;
 
        for ( i = 0; !BER_BVISNULL( &a_vals[i] ); i++ ) {
+               struct berval   olddn = BER_BVNULL,
+                               oldval;
                int             rc;
+               LDAPURLDesc     *ludp;
+
+               oldval = a_vals[i];
+               rc = ldap_url_parse( oldval.bv_val, &ludp );
+               if ( rc != LDAP_URL_SUCCESS ) {
+                       /* leave attr untouched if massage failed */
+                       if ( pa_nvals && BER_BVISNULL( &(*pa_nvals)[i] ) ) {
+                               ber_dupbv( &(*pa_nvals)[i], &oldval );
+                       }
+                       continue;
+               }
+
+               /* FIXME: URLs like "ldap:///dc=suffix" if passed
+                * thru ldap_url_parse() and ldap_url_desc2str() 
+                * get rewritten as "ldap:///dc=suffix??base";
+                * we don't want this to occur... */
+               if ( ludp->lud_scope == LDAP_SCOPE_BASE ) {
+                       ludp->lud_scope = LDAP_SCOPE_DEFAULT;
+               }
+
+               ber_str2bv( ludp->lud_dn, 0, 0, &olddn );
+
+               dn = olddn;
+               if ( pa_nvals ) {
+                       ndn = olddn;
+                       rc = rwm_dn_massage_pretty_normalize( &dc, &olddn,
+                                       &dn, &ndn );
+               } else {
+                       rc = rwm_dn_massage_pretty( &dc, &olddn, &dn );
+               }
 
-               rc = rwm_dn_massage( &dc, &a_vals[i], &dn, pndn );
                switch ( rc ) {
                case LDAP_UNWILLING_TO_PERFORM:
                        /*
@@ -812,21 +902,182 @@ rwm_dnattr_rewrite(
                        break;
                
                case LDAP_SUCCESS:
-                       if ( !BER_BVISNULL( &dn ) && dn.bv_val != a_vals[i].bv_val ) {
-                               ch_free( a_vals[i].bv_val );
-                               a_vals[i] = dn;
+                       if ( !BER_BVISNULL( &dn ) && dn.bv_val != olddn.bv_val ) {
+                               char    *newurl;
+
+                               ludp->lud_dn = dn.bv_val;
+                               newurl = ldap_url_desc2str( ludp );
+                               ludp->lud_dn = olddn.bv_val;
+                               ch_free( dn.bv_val );
+                               if ( newurl == NULL ) {
+                                       /* FIXME: leave attr untouched
+                                        * even if ldap_url_desc2str failed...
+                                        */
+                                       break;
+                               }
+
+                               ber_str2bv( newurl, 0, 1, &a_vals[i] );
+                               LDAP_FREE( newurl );
+
                                if ( pa_nvals ) {
+                                       ludp->lud_dn = ndn.bv_val;
+                                       newurl = ldap_url_desc2str( ludp );
+                                       ludp->lud_dn = olddn.bv_val;
+                                       ch_free( ndn.bv_val );
+                                       if ( newurl == NULL ) {
+                                               /* FIXME: leave attr untouched
+                                                * even if ldap_url_desc2str failed...
+                                                */
+                                               ch_free( a_vals[i].bv_val );
+                                               a_vals[i] = oldval;
+                                               break;
+                                       }
+
                                        if ( !BER_BVISNULL( &(*pa_nvals)[i] ) ) {
                                                ch_free( (*pa_nvals)[i].bv_val );
                                        }
-                                       (*pa_nvals)[i] = *pndn;
+                                       ber_str2bv( newurl, 0, 1, &(*pa_nvals)[i] );
+                                       LDAP_FREE( newurl );
                                }
+
+                               ch_free( oldval.bv_val );
+                               ludp->lud_dn = olddn.bv_val;
                        }
                        break;
 
                default:
                        /* leave attr untouched if massage failed */
                        if ( pa_nvals && BER_BVISNULL( &(*pa_nvals)[i] ) ) {
+                               ber_dupbv( &(*pa_nvals)[i], &a_vals[i] );
+                       }
+                       break;
+               }
+               ldap_free_urldesc( ludp );
+       }
+       
+       return 0;
+}
+
+/*
+ * I don't like this much, but we need two different
+ * functions because different heap managers may be
+ * in use in back-ldap/meta to reduce the amount of
+ * calls to malloc routines, and some of the free()
+ * routines may be macros with args
+ */
+int
+rwm_dnattr_rewrite(
+       Operation               *op,
+       SlapReply               *rs,
+       void                    *cookie,
+       BerVarray               a_vals,
+       BerVarray               *pa_nvals )
+{
+       slap_overinst           *on = (slap_overinst *) op->o_bd->bd_info;
+       struct ldaprwmap        *rwmap = 
+                       (struct ldaprwmap *)on->on_bi.bi_private;
+
+       int                     i, last;
+
+       dncookie                dc;
+       struct berval           dn = BER_BVNULL,
+                               ndn = BER_BVNULL;
+       BerVarray               in;
+
+       if ( a_vals ) {
+               in = a_vals;
+
+       } else {
+               if ( pa_nvals == NULL || *pa_nvals == NULL ) {
+                       return LDAP_OTHER;
+               }
+               in = *pa_nvals;
+       }
+
+       /*
+        * Rewrite the dn if needed
+        */
+       dc.rwmap = rwmap;
+#ifdef ENABLE_REWRITE
+       dc.conn = op->o_conn;
+       dc.rs = rs;
+       dc.ctx = (char *)cookie;
+#else /* ! ENABLE_REWRITE */
+       dc.tofrom = ((int *)cookie)[0];
+       dc.normalized = 0;
+#endif /* ! ENABLE_REWRITE */
+
+       for ( last = 0; !BER_BVISNULL( &in[last] ); last++ );
+       last--;
+       if ( pa_nvals != NULL ) {
+               if ( *pa_nvals == NULL ) {
+                       *pa_nvals = ch_malloc( ( last + 2 ) * sizeof(struct berval) );
+                       memset( *pa_nvals, 0, ( last + 2 ) * sizeof(struct berval) );
+               }
+       }
+
+       for ( i = 0; !BER_BVISNULL( &in[i] ); i++ ) {
+               int             rc;
+
+               if ( a_vals ) {
+                       dn = in[i];
+                       if ( pa_nvals ) {
+                               ndn = (*pa_nvals)[i];
+                               rc = rwm_dn_massage_pretty_normalize( &dc, &in[i], &dn, &ndn );
+                       } else {
+                               rc = rwm_dn_massage_pretty( &dc, &in[i], &dn );
+                       }
+               } else {
+                       ndn = in[i];
+                       rc = rwm_dn_massage_normalize( &dc, &in[i], &ndn );
+               }
+
+               switch ( rc ) {
+               case LDAP_UNWILLING_TO_PERFORM:
+                       /*
+                        * FIXME: need to check if it may be considered 
+                        * legal to trim values when adding/modifying;
+                        * it should be when searching (e.g. ACLs).
+                        */
+                       ch_free( in[i].bv_val );
+                       if (last > i ) {
+                               in[i] = in[last];
+                               if ( a_vals && pa_nvals ) {
+                                       (*pa_nvals)[i] = (*pa_nvals)[last];
+                               }
+                       }
+                       BER_BVZERO( &in[last] );
+                       if ( a_vals && pa_nvals ) {
+                               BER_BVZERO( &(*pa_nvals)[last] );
+                       }
+                       last--;
+                       break;
+               
+               case LDAP_SUCCESS:
+                       if ( a_vals ) {
+                               if ( !BER_BVISNULL( &dn ) && dn.bv_val != a_vals[i].bv_val ) {
+                                       ch_free( a_vals[i].bv_val );
+                                       a_vals[i] = dn;
+
+                                       if ( pa_nvals ) {
+                                               if ( !BER_BVISNULL( &(*pa_nvals)[i] ) ) {
+                                                       ch_free( (*pa_nvals)[i].bv_val );
+                                               }
+                                               (*pa_nvals)[i] = ndn;
+                                       }
+                               }
+                               
+                       } else {
+                               if ( !BER_BVISNULL( &ndn ) && ndn.bv_val != (*pa_nvals)[i].bv_val ) {
+                                       ch_free( (*pa_nvals)[i].bv_val );
+                                       (*pa_nvals)[i] = ndn;
+                               }
+                       }
+                       break;
+
+               default:
+                       /* leave attr untouched if massage failed */
+                       if ( a_vals && pa_nvals && BER_BVISNULL( &(*pa_nvals)[i] ) ) {
                                dnNormalize( 0, NULL, NULL, &a_vals[i], &(*pa_nvals)[i], NULL );
                        }
                        break;
@@ -836,11 +1087,88 @@ rwm_dnattr_rewrite(
        return 0;
 }
 
+int
+rwm_referral_result_rewrite(
+       dncookie                *dc,
+       BerVarray               a_vals )
+{
+       int             i, last;
+
+       for ( last = 0; !BER_BVISNULL( &a_vals[last] ); last++ );
+       last--;
+
+       for ( i = 0; !BER_BVISNULL( &a_vals[i] ); i++ ) {
+               struct berval   dn,
+                               olddn = BER_BVNULL;
+               int             rc;
+               LDAPURLDesc     *ludp;
+
+               rc = ldap_url_parse( a_vals[i].bv_val, &ludp );
+               if ( rc != LDAP_URL_SUCCESS ) {
+                       /* leave attr untouched if massage failed */
+                       continue;
+               }
+
+               /* FIXME: URLs like "ldap:///dc=suffix" if passed
+                * thru ldap_url_parse() and ldap_url_desc2str()
+                * get rewritten as "ldap:///dc=suffix??base";
+                * we don't want this to occur... */
+               if ( ludp->lud_scope == LDAP_SCOPE_BASE ) {
+                       ludp->lud_scope = LDAP_SCOPE_DEFAULT;
+               }
+
+               ber_str2bv( ludp->lud_dn, 0, 0, &olddn );
+
+               dn = olddn;
+               rc = rwm_dn_massage_pretty( dc, &olddn, &dn );
+               switch ( rc ) {
+               case LDAP_UNWILLING_TO_PERFORM:
+                       /*
+                        * FIXME: need to check if it may be considered 
+                        * legal to trim values when adding/modifying;
+                        * it should be when searching (e.g. ACLs).
+                        */
+                       ch_free( a_vals[i].bv_val );
+                       if ( last > i ) {
+                               a_vals[i] = a_vals[last];
+                       }
+                       BER_BVZERO( &a_vals[last] );
+                       last--;
+                       i--;
+                       break;
+
+               default:
+                       /* leave attr untouched if massage failed */
+                       if ( !BER_BVISNULL( &dn ) && olddn.bv_val != dn.bv_val ) {
+                               char    *newurl;
+
+                               ludp->lud_dn = dn.bv_val;
+                               newurl = ldap_url_desc2str( ludp );
+                               if ( newurl == NULL ) {
+                                       /* FIXME: leave attr untouched
+                                        * even if ldap_url_desc2str failed...
+                                        */
+                                       break;
+                               }
+
+                               ch_free( a_vals[i].bv_val );
+                               ber_str2bv( newurl, 0, 1, &a_vals[i] );
+                               LDAP_FREE( newurl );
+                               ludp->lud_dn = olddn.bv_val;
+                       }
+                       break;
+               }
+
+               ldap_free_urldesc( ludp );
+       }
+
+       return 0;
+}
+
 int
 rwm_dnattr_result_rewrite(
        dncookie                *dc,
-       BerVarray               a_vals
-)
+       BerVarray               a_vals )
 {
        int             i, last;
 
@@ -851,7 +1179,8 @@ rwm_dnattr_result_rewrite(
                struct berval   dn;
                int             rc;
                
-               rc = rwm_dn_massage( dc, &a_vals[i], &dn, NULL );
+               dn = a_vals[i];
+               rc = rwm_dn_massage_pretty( dc, &a_vals[i], &dn );
                switch ( rc ) {
                case LDAP_UNWILLING_TO_PERFORM:
                        /*
@@ -859,7 +1188,7 @@ rwm_dnattr_result_rewrite(
                         * legal to trim values when adding/modifying;
                         * it should be when searching (e.g. ACLs).
                         */
-                       LBER_FREE( &a_vals[i].bv_val );
+                       ch_free( a_vals[i].bv_val );
                        if ( last > i ) {
                                a_vals[i] = a_vals[last];
                        }
@@ -870,7 +1199,7 @@ rwm_dnattr_result_rewrite(
                default:
                        /* leave attr untouched if massage failed */
                        if ( !BER_BVISNULL( &dn ) && a_vals[i].bv_val != dn.bv_val ) {
-                               LBER_FREE( a_vals[i].bv_val );
+                               ch_free( a_vals[i].bv_val );
                                a_vals[i] = dn;
                        }
                        break;
@@ -880,6 +1209,16 @@ rwm_dnattr_result_rewrite(
        return 0;
 }
 
+void
+rwm_mapping_dst_free( void *v_mapping )
+{
+       struct ldapmapping *mapping = v_mapping;
+
+       if ( BER_BVISEMPTY( &mapping[0].m_dst ) ) {
+               rwm_mapping_free( &mapping[ -1 ] );
+       }
+}
+
 void
 rwm_mapping_free( void *v_mapping )
 {