]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/overlays/syncprov.c
Fix overlay aux_operational, add contextCSN as operational attribute
[openldap] / servers / slapd / overlays / syncprov.c
index 65635909761372442f57443679bf8f8e492b0903..f6f414aa1c44b3f20818abcbbb33764ca41e86a4 100644 (file)
@@ -38,8 +38,6 @@ typedef struct modtarget {
        ldap_pvt_thread_mutex_t mt_mutex;
 } modtarget;
 
-       
-
 /* A queued result of a persistent search */
 typedef struct syncres {
        struct syncres *s_next;
@@ -92,6 +90,7 @@ typedef struct syncmatches {
        syncops *sm_op;
 } syncmatches;
 
+/* The main state for this overlay */
 typedef struct syncprov_info_t {
        syncops         *si_ops;
        struct berval   si_ctxcsn;      /* ldapsync context */
@@ -123,6 +122,7 @@ typedef struct fbase_cookie {
 static AttributeName csn_anlist[2];
 static AttributeName uuid_anlist[2];
 
+/* Build a LDAPsync intermediate state control */
 static int
 syncprov_state_ctrl(
        Operation       *op,
@@ -182,6 +182,7 @@ syncprov_state_ctrl(
        return LDAP_SUCCESS;
 }
 
+/* Build a LDAPsync final state control */
 static int
 syncprov_done_ctrl(
        Operation       *op,
@@ -227,7 +228,8 @@ syncprov_done_ctrl(
        return LDAP_SUCCESS;
 }
 
-
+#if 0
+/* Generate state based on session log - not implemented yet */
 static int
 syncprov_state_ctrl_from_slog(
        Operation       *op,
@@ -280,6 +282,7 @@ syncprov_state_ctrl_from_slog(
 
        return LDAP_SUCCESS;
 }
+#endif
 
 static int
 syncprov_sendinfo(
@@ -345,6 +348,7 @@ syncprov_sendinfo(
                return ret;
        }
 
+       rs->sr_rspoid = LDAP_SYNC_INFO;
        rs->sr_rspdata = &rspdata;
        send_ldap_intermediate( op, rs );
        rs->sr_rspdata = NULL;
@@ -353,6 +357,7 @@ syncprov_sendinfo(
        return LDAP_SUCCESS;
 }
 
+/* Find a modtarget in an AVL tree */
 static int
 sp_avl_cmp( const void *c1, const void *c2 )
 {
@@ -545,7 +550,6 @@ findpres_cb( Operation *op, SlapReply *rs )
                        pc->num++;
                        ret = LDAP_SUCCESS;
                        if ( pc->num == SLAP_SYNCUUID_SET_SIZE ) {
-                               rs->sr_rspoid = LDAP_SYNC_INFO;
                                ret = syncprov_sendinfo( op, rs, LDAP_TAG_SYNC_ID_SET, NULL,
                                        0, pc->uuids, 0 );
                                ber_bvarray_free_x( pc->uuids, op->o_tmpmemctx );
@@ -558,7 +562,6 @@ findpres_cb( Operation *op, SlapReply *rs )
        } else if ( rs->sr_type == REP_RESULT ) {
                ret = rs->sr_err;
                if ( pc->num ) {
-                       rs->sr_rspoid = LDAP_SYNC_INFO;
                        ret = syncprov_sendinfo( op, rs, LDAP_TAG_SYNC_ID_SET, NULL,
                                0, pc->uuids, 0 );
                        ber_bvarray_free_x( pc->uuids, op->o_tmpmemctx );
@@ -777,6 +780,69 @@ syncprov_sendresp( Operation *op, opcookie *opc, syncops *so, Entry *e, int mode
        return rs.sr_err;
 }
 
+static void
+syncprov_free_syncop( syncops *so )
+{
+       syncres *sr, *srnext;
+
+       ldap_pvt_thread_mutex_lock( &so->s_mutex );
+       so->s_inuse--;
+       if ( so->s_inuse > 0 ) {
+               ldap_pvt_thread_mutex_unlock( &so->s_mutex );
+               return;
+       }
+       ldap_pvt_thread_mutex_unlock( &so->s_mutex );
+       filter_free( so->s_op->ors_filter );
+       ch_free( so->s_op );
+       ch_free( so->s_base.bv_val );
+       for ( sr=so->s_res; sr; sr=srnext ) {
+               srnext = sr->s_next;
+               ch_free( sr );
+       }
+       ldap_pvt_thread_mutex_destroy( &so->s_mutex );
+       ch_free( so );
+}
+
+static int
+syncprov_drop_psearch( syncops *so )
+{
+       ldap_pvt_thread_mutex_lock( &so->s_op->o_conn->c_mutex );
+       so->s_op->o_conn->c_n_ops_executing--;
+       so->s_op->o_conn->c_n_ops_completed++;
+       ldap_pvt_thread_mutex_unlock( &so->s_op->o_conn->c_mutex );
+       syncprov_free_syncop( so );
+}
+
+static int
+syncprov_op_abandon( Operation *op, SlapReply *rs )
+{
+       slap_overinst           *on = (slap_overinst *)op->o_bd->bd_info;
+       syncprov_info_t         *si = on->on_bi.bi_private;
+       syncops *so, *soprev;
+
+       ldap_pvt_thread_mutex_lock( &si->si_ops_mutex );
+       for ( so=si->si_ops, soprev = (syncops *)&si->si_ops; so;
+               soprev=so, so=so->s_next ) {
+               if ( so->s_op->o_connid == op->o_connid &&
+                       so->s_op->o_msgid == op->orn_msgid ) {
+                               so->s_op->o_abandon = 1;
+                               soprev->s_next = so->s_next;
+                               break;
+               }
+       }
+       ldap_pvt_thread_mutex_unlock( &si->si_ops_mutex );
+       if ( so ) {
+               /* Is this really a Cancel exop? */
+               if ( op->o_tag != LDAP_REQ_ABANDON ) {
+                       rs->sr_err = LDAP_CANCELLED;
+                       send_ldap_result( so->s_op, rs );
+               }
+               syncprov_drop_psearch( so );
+       }
+       return SLAP_CB_CONTINUE;
+}
+
+/* Find which persistent searches are affected by this operation */
 static void
 syncprov_matchops( Operation *op, opcookie *opc, int saveit )
 {
@@ -784,7 +850,7 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit )
        syncprov_info_t         *si = on->on_bi.bi_private;
 
        fbase_cookie fc;
-       syncops *ss;
+       syncops *ss, *sprev, *snext;
        Entry *e;
        Attribute *a;
        int rc;
@@ -820,17 +886,28 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit )
        }
 
        ldap_pvt_thread_mutex_lock( &si->si_ops_mutex );
-       for (ss = si->si_ops; ss; ss=ss->s_next)
+       for (ss = si->si_ops, sprev = (syncops *)&si->si_ops; ss;
+               sprev = ss, ss=snext)
        {
                syncmatches *sm;
                int found = 0;
 
+               snext = ss->s_next;
                /* validate base */
                fc.fss = ss;
                fc.fbase = 0;
                fc.fscope = 0;
+
+               /* If the base of the search is missing, signal a refresh */
                rc = syncprov_findbase( op, &fc );
-               if ( rc != LDAP_SUCCESS ) continue;
+               if ( rc != LDAP_SUCCESS ) {
+                       SlapReply rs = {REP_RESULT};
+                       send_ldap_error( ss->s_op, &rs, LDAP_SYNC_REFRESH_REQUIRED,
+                               "search base has changed" );
+                       sprev->s_next = snext;
+                       syncprov_drop_psearch( ss );
+                       continue;
+               }
 
                /* If we're sending results now, look for this op in old matches */
                if ( !saveit ) {
@@ -873,29 +950,6 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit )
        }
 }
 
-static void
-syncprov_free_syncop( syncops *so )
-{
-       syncres *sr, *srnext;
-
-       ldap_pvt_thread_mutex_lock( &so->s_mutex );
-       so->s_inuse--;
-       if ( so->s_inuse > 0 ) {
-               ldap_pvt_thread_mutex_unlock( &so->s_mutex );
-               return;
-       }
-       ldap_pvt_thread_mutex_unlock( &so->s_mutex );
-       filter_free( so->s_op->ors_filter );
-       ch_free( so->s_op );
-       ch_free( so->s_base.bv_val );
-       for ( sr=so->s_res; sr; sr=srnext ) {
-               srnext = sr->s_next;
-               ch_free( sr );
-       }
-       ldap_pvt_thread_mutex_destroy( &so->s_mutex );
-       ch_free( so );
-}
-
 static int
 syncprov_op_cleanup( Operation *op, SlapReply *rs )
 {
@@ -950,6 +1004,7 @@ syncprov_op_response( Operation *op, SlapReply *rs )
                struct berval maxcsn;
                char cbuf[LDAP_LUTIL_CSNSTR_BUFSIZE];
 
+               /* Update our context CSN */
                cbuf[0] = '\0';
                ldap_pvt_thread_mutex_lock( &si->si_csn_mutex );
                slap_get_commit_csn( op, &maxcsn );
@@ -966,6 +1021,7 @@ syncprov_op_response( Operation *op, SlapReply *rs )
                opc->sctxcsn.bv_len = maxcsn.bv_len;
                opc->sctxcsn.bv_val = cbuf;
 
+               /* Handle any persistent searches */
                if ( si->si_ops ) {
                        switch(op->o_tag) {
                        case LDAP_REQ_ADD:
@@ -994,40 +1050,10 @@ syncprov_op_response( Operation *op, SlapReply *rs )
        return SLAP_CB_CONTINUE;
 }
 
-static int
-syncprov_op_abandon( Operation *op, SlapReply *rs )
-{
-       slap_overinst           *on = (slap_overinst *)op->o_bd->bd_info;
-       syncprov_info_t         *si = on->on_bi.bi_private;
-       syncops *so, *soprev;
-
-       ldap_pvt_thread_mutex_lock( &si->si_ops_mutex );
-       for ( so=si->si_ops, soprev = (syncops *)&si->si_ops; so;
-               soprev=so, so=so->s_next ) {
-               if ( so->s_op->o_connid == op->o_connid &&
-                       so->s_op->o_msgid == op->orn_msgid ) {
-                               so->s_op->o_abandon = 1;
-                               soprev->s_next = so->s_next;
-                               break;
-               }
-       }
-       ldap_pvt_thread_mutex_unlock( &si->si_ops_mutex );
-       if ( so ) {
-               ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
-               op->o_conn->c_n_ops_executing--;
-               op->o_conn->c_n_ops_completed++;
-               ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
-               /* Is this really a Cancel exop? */
-               if ( op->o_tag != LDAP_REQ_ABANDON ) {
-                       rs->sr_err = LDAP_CANCELLED;
-                       send_ldap_result( so->s_op, rs );
-               }
-               syncprov_free_syncop( so );
-       }
-       return SLAP_CB_CONTINUE;
-}
-
-#if 0
+/* We don't use a subentry to store the context CSN any more.
+ * We expose the current context CSN as an operational attribute
+ * of the suffix entry.
+ */
 static int
 syncprov_op_compare( Operation *op, SlapReply *rs )
 {
@@ -1035,47 +1061,53 @@ syncprov_op_compare( Operation *op, SlapReply *rs )
        syncprov_info_t         *si = on->on_bi.bi_private;
        int rc = SLAP_CB_CONTINUE;
 
-       if ( dn_match( &op->o_req_ndn, &si->si_e->e_nname ) )
+       if ( dn_match( &op->o_req_ndn, op->o_bd->be_nsuffix ) &&
+               op->oq_compare.rs_ava->aa_desc == slap_schema.si_ad_contextCSN )
        {
-               Attribute *a;
+               Entry e = {0};
+               Attribute a = {0};
+               struct berval bv[2];
 
-               ldap_pvt_thread_mutex_lock( &si->si_e_mutex );
+               e.e_name = op->o_bd->be_suffix[0];
+               e.e_nname = op->o_bd->be_nsuffix[0];
 
-               if ( get_assert( op ) &&
-                       ( test_filter( op, si->si_e, get_assertion( op ) ) != LDAP_COMPARE_TRUE ) )
-               {
-                       rs->sr_err = LDAP_ASSERTION_FAILED;
-                       goto return_results;
-               }
+               bv[1].bv_val = NULL;
+               bv[0] = si->si_ctxcsn;
+
+               a.a_desc = slap_schema.si_ad_contextCSN;
+               a.a_vals = bv;
+               a.a_nvals = a.a_vals;
+
+               ldap_pvt_thread_mutex_lock( &si->si_csn_mutex );
 
-               rs->sr_err = access_allowed( op, si->si_e, op->oq_compare.rs_ava->aa_desc,
+               rs->sr_err = access_allowed( op, &e, op->oq_compare.rs_ava->aa_desc,
                        &op->oq_compare.rs_ava->aa_value, ACL_COMPARE, NULL );
                if ( ! rs->sr_err ) {
                        rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
                        goto return_results;
                }
 
-               rs->sr_err = LDAP_NO_SUCH_ATTRIBUTE;
+               if ( get_assert( op ) &&
+                       ( test_filter( op, &e, get_assertion( op ) ) != LDAP_COMPARE_TRUE ) )
+               {
+                       rs->sr_err = LDAP_ASSERTION_FAILED;
+                       goto return_results;
+               }
+
+
+               rs->sr_err = LDAP_COMPARE_FALSE;
 
-               for ( a = attr_find( si->si_e->e_attrs, op->oq_compare.rs_ava->aa_desc );
-                       a != NULL;
-                       a = attr_find( a->a_next, op->oq_compare.rs_ava->aa_desc ) )
+               if ( value_find_ex( op->oq_compare.rs_ava->aa_desc,
+                       SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH |
+                               SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
+                               a.a_nvals, &op->oq_compare.rs_ava->aa_value, op->o_tmpmemctx ) == 0 )
                {
-                       rs->sr_err = LDAP_COMPARE_FALSE;
-
-                       if ( value_find_ex( op->oq_compare.rs_ava->aa_desc,
-                               SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH |
-                                       SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
-                               a->a_nvals, &op->oq_compare.rs_ava->aa_value, op->o_tmpmemctx ) == 0 )
-                       {
-                               rs->sr_err = LDAP_COMPARE_TRUE;
-                               break;
-                       }
+                       rs->sr_err = LDAP_COMPARE_TRUE;
                }
 
 return_results:;
 
-               ldap_pvt_thread_mutex_unlock( &si->si_e_mutex );
+               ldap_pvt_thread_mutex_unlock( &si->si_csn_mutex );
 
                send_ldap_result( op, rs );
 
@@ -1085,9 +1117,8 @@ return_results:;
                rc = rs->sr_err;
        }
 
-       return SLAP_CB_CONTINUE;
+       return rc;
 }
-#endif
        
 static int
 syncprov_op_mod( Operation *op, SlapReply *rs )
@@ -1272,7 +1303,6 @@ syncprov_search_response( Operation *op, SlapReply *rs )
                } else {
                        int locked = 0;
                /* It's RefreshAndPersist, transition to Persist phase */
-                       rs->sr_rspoid = LDAP_SYNC_INFO;
                        syncprov_sendinfo( op, rs, rs->sr_nentries ?
                                LDAP_TAG_SYNC_REFRESH_PRESENT : LDAP_TAG_SYNC_REFRESH_DELETE,
                                &cookie, 1, NULL, 0 );
@@ -1457,7 +1487,9 @@ syncprov_op_search( Operation *op, SlapReply *rs )
        fava->f_choice = LDAP_FILTER_LE;
        fava->f_ava = op->o_tmpalloc( sizeof(AttributeAssertion), op->o_tmpmemctx );
        fava->f_ava->aa_desc = slap_schema.si_ad_entryCSN;
+       ldap_pvt_thread_mutex_lock( &si->si_csn_mutex );
        ber_dupbv_x( &fava->f_ava->aa_value, &si->si_ctxcsn, op->o_tmpmemctx );
+       ldap_pvt_thread_mutex_unlock( &si->si_csn_mutex );
        fand->f_and = fava;
        if ( gotstate ) {
                fava->f_next = op->o_tmpalloc( sizeof(Filter), op->o_tmpmemctx );
@@ -1498,6 +1530,43 @@ shortcut:
        return SLAP_CB_CONTINUE;
 }
 
+static int
+syncprov_operational(
+       Operation *op,
+       SlapReply *rs )
+{
+       slap_overinst           *on = (slap_overinst *)op->o_bd->bd_info;
+       syncprov_info_t         *si = (syncprov_info_t *)on->on_bi.bi_private;
+
+       if ( rs->sr_entry &&
+               dn_match( &rs->sr_entry->e_nname, op->o_bd->be_nsuffix )) {
+
+               Attribute **ap;
+
+               for ( ap = &rs->sr_operational_attrs; *ap; ap=&(*ap)->a_next ) ;
+
+               if ( SLAP_OPATTRS( rs->sr_attr_flags ) ||
+                       ad_inlist( slap_schema.si_ad_contextCSN, rs->sr_attrs )) {
+                       
+                       Attribute *a = ch_malloc( sizeof(Attribute));
+                       a->a_desc = slap_schema.si_ad_contextCSN;
+                       a->a_vals = ch_malloc( 2 * sizeof(struct berval));
+
+                       ldap_pvt_thread_mutex_lock( &si->si_csn_mutex );
+                       ber_dupbv( &a->a_vals[0], &si->si_ctxcsn );
+                       ldap_pvt_thread_mutex_unlock( &si->si_csn_mutex );
+
+                       a->a_vals[1].bv_val = NULL;
+                       a->a_nvals = a->a_vals;
+                       a->a_next = NULL;
+                       a->a_flags = 0;
+
+                       *ap = a;
+               }
+       }
+       return LDAP_SUCCESS;
+}
+
 static int
 syncprov_db_config(
        BackendDB       *be,
@@ -1698,14 +1767,13 @@ syncprov_init()
        syncprov.on_bi.bi_op_cancel = syncprov_op_abandon;
 
        syncprov.on_bi.bi_op_add = syncprov_op_mod;
-#if 0
        syncprov.on_bi.bi_op_compare = syncprov_op_compare;
-#endif
        syncprov.on_bi.bi_op_delete = syncprov_op_mod;
        syncprov.on_bi.bi_op_modify = syncprov_op_mod;
        syncprov.on_bi.bi_op_modrdn = syncprov_op_mod;
        syncprov.on_bi.bi_op_search = syncprov_op_search;
        syncprov.on_bi.bi_extended = syncprov_op_extended;
+       syncprov.on_bi.bi_operational = syncprov_operational;
 
 #if 0
        syncprov.on_response = syncprov_response;