Fix LBER_ERROR vs. -1 confusion.

[openldap] / servers / slapd / repl.c

diff --git a/servers/slapd/repl.c b/servers/slapd/repl.c
index 4f0105b3e96c0672436a22046f1a502a4d47722d..25fe030e797d022c3c20bf8ccf111f67b2c6a33d 100644 (file)
--- a/servers/slapd/repl.c
+++ b/servers/slapd/repl.c
@@ -1,7 +1,7 @@
 /* repl.c - log modifications for replication purposes */
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
@@ -371,7 +371,8 @@ replog1(
                fprintf( fp, "changetype: modrdn\n" );
                fprintf( fp, "newrdn: %s\n", moddn->newrdn->bv_val );
                fprintf( fp, "deleteoldrdn: %d\n", moddn->deloldrdn ? 1 : 0 );
-               if( moddn->newsup != NULL ) {
+               /* moddn->newsup is never NULL, see modrdn.c */
+               if( moddn->newsup->bv_val != NULL ) {
                        fprintf( fp, "newsuperior: %s\n", moddn->newsup->bv_val );
                }
        }