]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/result.c
Sync with HEAD
[openldap] / servers / slapd / result.c
index 97c5cf385723a7b4225ce032140c2531bea0ec10..081eae7b0ec6d8929f5c0536ae7a797e76275dd0 100644 (file)
 
 #include "slap.h"
 
-#ifdef LDAP_SLAPI
-#include "slapi/slapi.h"
-#endif
-
 const struct berval slap_dummy_bv = BER_BVNULL;
 
 int slap_null_cb( Operation *op, SlapReply *rs )
@@ -50,7 +46,7 @@ int slap_null_cb( Operation *op, SlapReply *rs )
 
 int slap_freeself_cb( Operation *op, SlapReply *rs )
 {
-       assert( op->o_callback );
+       assert( op->o_callback != NULL );
 
        op->o_tmpfree( op->o_callback, op->o_tmpmemctx );
        op->o_callback = NULL;
@@ -246,36 +242,16 @@ static int
 send_ldap_controls( Operation *o, BerElement *ber, LDAPControl **c )
 {
        int rc;
-#ifdef LDAP_SLAPI
-       LDAPControl **sctrls = NULL;
-
-       /*
-        * Retrieve any additional controls that may be set by the
-        * plugin.
-        */
-
-       if ( o->o_pb &&
-               slapi_pblock_get( o->o_pb, SLAPI_RESCONTROLS, &sctrls ) != 0 )
-       {
-               sctrls = NULL;
-       }
 
-       if ( c == NULL && sctrls == NULL ) return 0;
-#else
-       if( c == NULL ) return 0;
-#endif /* LDAP_SLAPI */
+       if( c == NULL )
+               return 0;
 
        rc = ber_printf( ber, "t{"/*}*/, LDAP_TAG_CONTROLS );
        if( rc == -1 ) return rc;
 
-#ifdef LDAP_SLAPI
-       if ( c != NULL )
-#endif /* LDAP_SLAPI */
-       {
-               for( ; *c != NULL; c++) {
-                       rc = send_ldap_control( ber, *c );
-                       if( rc == -1 ) return rc;
-               }
+       for( ; *c != NULL; c++) {
+               rc = send_ldap_control( ber, *c );
+               if( rc == -1 ) return rc;
        }
 
 #ifdef LDAP_DEVEL
@@ -293,7 +269,7 @@ send_ldap_controls( Operation *o, BerElement *ber, LDAPControl **c )
                ber_printf( sber, "{i}", LDAP_UNWILLING_TO_PERFORM );
 
                if( ber_flatten2( ber, &sorted.ldctl_value, 0 ) == -1 ) {
-                       return LBER_ERROR;
+                       return -1;
                }
 
                (void) ber_free_buf( ber );
@@ -303,15 +279,6 @@ send_ldap_controls( Operation *o, BerElement *ber, LDAPControl **c )
        }
 #endif
 
-#ifdef LDAP_SLAPI
-       if ( sctrls != NULL ) {
-               for ( c = sctrls; *c != NULL; c++ ) {
-                       rc = send_ldap_control( ber, *c );
-                       if( rc == -1 ) return rc;
-               }
-       }
-#endif /* LDAP_SLAPI */
-
        rc = ber_printf( ber, /*{*/"N}" );
 
        return rc;
@@ -476,15 +443,6 @@ send_ldap_response(
                goto cleanup;
        }
 
-#ifdef LDAP_SLAPI
-       if ( op->o_pb ) {
-               slapi_pblock_set( op->o_pb, SLAPI_RESULT_CODE, (void *)rs->sr_err );
-               slapi_pblock_set( op->o_pb, SLAPI_RESULT_MATCHED,
-                       (void *)rs->sr_matched );
-               slapi_pblock_set( op->o_pb, SLAPI_RESULT_TEXT, (void *)rs->sr_text );
-       }
-#endif /* LDAP_SLAPI */
-
        ldap_pvt_thread_mutex_lock( &slap_counters.sc_sent_mutex );
        ldap_pvt_mp_add_ulong( slap_counters.sc_pdu, 1 );
        ldap_pvt_mp_add_ulong( slap_counters.sc_bytes, (unsigned long)bytes );
@@ -611,26 +569,6 @@ slap_send_ldap_result( Operation *op, SlapReply *rs )
                }
        }
 
-#ifdef LDAP_SLAPI
-       /*
-        * Call pre-result plugins. To avoid infinite recursion plugins
-        * should just set SLAPI_RESULT_CODE rather than sending a
-        * result if they wish to change the result.
-        */
-       if ( op->o_callback == NULL && op->o_pb != NULL ) {
-               slapi_int_pblock_set_operation( op->o_pb, op );
-               slapi_pblock_set( op->o_pb, SLAPI_RESULT_CODE,
-                       (void *)rs->sr_err );
-               slapi_pblock_set( op->o_pb, SLAPI_RESULT_TEXT,
-                       (void *)rs->sr_text );
-               slapi_pblock_set( op->o_pb, SLAPI_RESULT_MATCHED,
-                       (void *)rs->sr_matched );
-
-               (void) slapi_int_call_plugins( op->o_bd, SLAPI_PLUGIN_PRE_RESULT_FN,
-                       op->o_pb );
-       }
-#endif /* LDAP_SLAPI */
-
        if ( op->o_protocol < LDAP_VERSION3 ) {
                tmp = v2ref( rs->sr_ref, rs->sr_text );
                rs->sr_text = tmp;
@@ -719,11 +657,7 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
        char            *edn;
        int             userattrs;
        AccessControlState acl_state = ACL_STATE_INIT;
-#ifdef LDAP_SLAPI
-       /* Support for computed attribute plugins */
-       computed_attr_context    ctx;
-       AttributeName   *anp;
-#endif
+       int                      attrsonly;
        AttributeDescription *ad_entry = slap_schema.si_ad_entry;
 
        /* a_flags: array of flags telling if the i-th element will be
@@ -756,7 +690,8 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
                                *sc_next = op->o_callback;
 
                rc = SLAP_CB_CONTINUE;
-               for ( sc_next = op->o_callback; sc_next; op->o_callback = sc_next) {
+               for ( sc_next = op->o_callback; sc_next; op->o_callback = sc_next )
+               {
                        sc_next = op->o_callback->sc_next;
                        if ( op->o_callback->sc_response ) {
                                rc = op->o_callback->sc_response( op, rs );
@@ -776,6 +711,8 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
                op->o_connid, rs->sr_entry->e_name.bv_val,
                op->ors_attrsonly ? " (attrsOnly)" : "" );
 
+       attrsonly = op->ors_attrsonly;
+
        if ( !access_allowed( op, rs->sr_entry, ad_entry, NULL, ACL_READ, NULL )) {
                Debug( LDAP_DEBUG_ACL,
                        "send_search_entry: conn %lu access to entry (%s) not allowed\n", 
@@ -794,7 +731,7 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
                struct berval   bv;
 
                bv.bv_len = entry_flatsize( rs->sr_entry, 0 );
-               bv.bv_val = op->o_tmpalloc(bv.bv_len, op->o_tmpmemctx );
+               bv.bv_val = op->o_tmpalloc( bv.bv_len, op->o_tmpmemctx );
 
                ber_init2( ber, &bv, LBER_USE_DER );
                ber_set_option( ber, LBER_OPT_BER_MEMCTX, &op->o_tmpmemctx );
@@ -906,7 +843,7 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
                        }
                }
 
-               if ( op->ors_attrsonly ) {
+               if ( attrsonly ) {
                        if ( ! access_allowed( op, rs->sr_entry, desc, NULL,
                                ACL_READ, &acl_state ) )
                        {
@@ -1085,7 +1022,7 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
                        goto error_return;
                }
 
-               if ( ! op->ors_attrsonly ) {
+               if ( ! attrsonly ) {
                        for ( i = 0; a->a_vals[i].bv_val != NULL; i++ ) {
                                if ( ! access_allowed( op, rs->sr_entry,
                                        desc, &a->a_vals[i], ACL_READ, &acl_state ) )
@@ -1126,46 +1063,6 @@ slap_send_search_entry( Operation *op, SlapReply *rs )
                }
        }
 
-#ifdef LDAP_SLAPI
-       /*
-        * First, setup the computed attribute context that is
-        * passed to all plugins.
-        */
-       if ( op->o_pb ) {
-               ctx.cac_pb = op->o_pb;
-               ctx.cac_attrs = rs->sr_attrs;
-               ctx.cac_attrsonly = op->ors_attrsonly;
-               ctx.cac_userattrs = userattrs;
-               ctx.cac_opattrs = rs->sr_attr_flags;
-               ctx.cac_acl_state = acl_state;
-               ctx.cac_private = (void *)ber;
-
-               /*
-                * For each client requested attribute, call the plugins.
-                */
-               if ( rs->sr_attrs != NULL ) {
-                       for ( anp = rs->sr_attrs; anp->an_name.bv_val != NULL; anp++ ) {
-                               rc = compute_evaluator( &ctx, anp->an_name.bv_val,
-                                       rs->sr_entry, slapi_int_compute_output_ber );
-                               if ( rc == 1 ) break;
-                       }
-               } else {
-                       /*
-                        * Technically we shouldn't be returning operational attributes
-                        * when the user requested only user attributes. We'll let the
-                        * plugin decide whether to be naughty or not.
-                        */
-                       rc = compute_evaluator( &ctx, "*",
-                               rs->sr_entry, slapi_int_compute_output_ber );
-               }
-               if ( rc == 1 ) {
-                       if ( op->o_res_ber == NULL ) ber_free_buf( ber );
-                       send_ldap_error( op, rs, LDAP_OTHER, "computed attribute error" );
-                       goto error_return;
-               }
-       }
-#endif /* LDAP_SLAPI */
-
        /* free e_flags */
        if ( e_flags ) {
                slap_sl_free( e_flags, op->o_tmpmemctx );
@@ -1535,6 +1432,7 @@ int slap_read_controls(
        myop = *op;
        myop.o_bd = NULL;
        myop.o_res_ber = ber;
+       myop.o_callback = NULL;
 
        rc = slap_send_search_entry( &myop, rs );
        if( rc ) return rc;
@@ -1546,7 +1444,7 @@ int slap_read_controls(
        c.ldctl_oid = oid->bv_val;
        c.ldctl_iscritical = 0;
 
-       if ( ctrl == NULL ) {
+       if ( *ctrl == NULL ) {
                /* first try */
                *ctrl = (LDAPControl *) slap_sl_calloc( 1, sizeof(LDAPControl), NULL );
        } else {